Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2786
Yes, we probably don't want to keep running if we hit an Error.
---
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2787#discussion_r207328980
--- Diff:
storm-webapp/src/test/java/org/apache/storm/daemon/logviewer/utils/LogCleanerTest.java
---
@@ -87,8 +88,9 @@ public void
Github user agresch commented on the issue:
https://github.com/apache/storm/pull/2786
If an error occurred, what should be the expected behavior? Shutdown?
---
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2787#discussion_r207326393
--- Diff:
storm-webapp/src/test/java/org/apache/storm/daemon/logviewer/utils/LogCleanerTest.java
---
@@ -87,8 +88,9 @@ public void
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/2763
---
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2763
@zd-project Merged, thanks for your patience. JIRA is down right now, will
update the ticket when it comes back up.
---
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2786
Seems reasonable to me, but do we really want to catch the Error subtypes
as well?
---
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2787#discussion_r207329210
--- Diff:
storm-webapp/src/test/java/org/apache/storm/daemon/logviewer/utils/LogCleanerTest.java
---
@@ -87,8 +88,9 @@ public void
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2787#discussion_r207325422
--- Diff:
storm-webapp/src/test/java/org/apache/storm/daemon/logviewer/utils/LogCleanerTest.java
---
@@ -87,8 +88,9 @@ public void
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2788#discussion_r207327774
--- Diff:
storm-webapp/src/test/java/org/apache/storm/daemon/logviewer/testsupport/MockRemovableFileBuilder.java
---
@@ -0,0 +1,29 @@
+/**
+ *
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2788#discussion_r207328701
--- Diff:
storm-webapp/src/test/java/org/apache/storm/daemon/logviewer/testsupport/MockRemovableFileBuilder.java
---
@@ -0,0 +1,29 @@
+/**
+ *
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2788#discussion_r207327029
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/utils/DirectoryCleaner.java
---
@@ -133,10 +123,15 @@ public int compare(File f1, File
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2787#discussion_r207328445
--- Diff:
storm-webapp/src/test/java/org/apache/storm/daemon/logviewer/utils/LogCleanerTest.java
---
@@ -87,8 +88,9 @@ public void
GitHub user zd-project opened a pull request:
https://github.com/apache/storm/pull/2789
STORM-3173: flush metrics to ScheduledReporter on shutdown
https://issues.apache.org/jira/browse/STORM-3173
You can merge this pull request into a Git repository by running:
$ git pull
Github user agresch commented on the issue:
https://github.com/apache/storm/pull/2786
@srdo - updated to shutdown on errors. Filed
https://issues.apache.org/jira/browse/STORM-3174 to standardize exit codes.
I'm not clear on why we're selecting the values we are.
---
Hi,
I’m trying to optimize storm to process at least a million messages per
second with each message ranging in size from 1kb to 5mb. I’ve been looking
at other benchmarks and the highest I’ve seen was 43 mb per second which is
awfully slow. Is it possible to achieve this task without spinning up
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2786
Thanks. +1
---
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2788#discussion_r207376890
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/utils/DirectoryCleaner.java
---
@@ -133,10 +123,15 @@ public int compare(File f1,
GitHub user dfdemar opened a pull request:
https://github.com/apache/storm/pull/2790
STORM-3175 - Allow usage of custom Callback.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dfdemar/storm custom-kafkabolt-callback
Github user roshannaik commented on the issue:
https://github.com/apache/storm/pull/2711
Spent sometime trying to triage this failure but unable to figure out the
cause. i know the issue has to do with this patch as it passes w/o this patch.
I think it will take me some more time to
Github user dfdemar commented on a diff in the pull request:
https://github.com/apache/storm/pull/2790#discussion_r207428218
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/bolt/KafkaBolt.java
---
@@ -129,6 +140,27 @@ public void prepare(Map topoConf,
Perhaps you can try some things depending on how feasible they it is for your
case:
1- Try to design and deploy your topology to maximize communication within a
worker process instead fo across worker processes. 2- Alternatively you can
spin up multiple single worker instances of you toplo3-
Github user zd-project commented on the issue:
https://github.com/apache/storm/pull/2763
@srdo I've squashed the commits. Sorry about the delay.
---
23 matches
Mail list logo
