[GitHub] incubator-taverna-mobile pull request #56: Migration RxJava 1 -> RxJava2

2018-02-19 Thread sagar15795
Github user sagar15795 commented on a diff in the pull request: https://github.com/apache/incubator-taverna-mobile/pull/56#discussion_r169214069 --- Diff: app/src/main/java/org/apache/taverna/mobile/ui/workflow/WorkflowPresenter.java --- @@ -84,25 +82,27 @@ public void

[GitHub] incubator-taverna-mobile pull request #56: Migration RxJava 1 -> RxJava2

2018-02-19 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/incubator-taverna-mobile/pull/56 ---

RE: Swagger & Taverna

2018-02-19 Thread Mark Fortner
You could extend the same basic principle of semantic annotations to relational databases. You can use the column's 'comments' field to store an ontology reference. You would just need to be able to consume it when you write JDBC queries. Mark On 19 Feb 2018 3:43 am, "Ian Dunlop"

[GitHub] incubator-taverna-mobile pull request #56: Migration RxJava 1 -> RxJava2

2018-02-19 Thread Hiteshgautam01
GitHub user Hiteshgautam01 opened a pull request: https://github.com/apache/incubator-taverna-mobile/pull/56 Migration RxJava 1 -> RxJava2 Please make sure these boxes are checked before submitting your pull request - thanks! - [ ] Apply the `AndroidStyle.xml` style

RE: Swagger & Taverna

2018-02-19 Thread Ian Dunlop
Hello, That sounds like a really interesting idea. I wonder if it could be a generalised approach as well for annotating swagger docs so that taverna/CWL/knime/PP etc could use them. Maybe that exists already? Cheers, Ian Sent from Mail for Windows 10 From: Stian Soiland-Reyes Sent: 18

[GitHub] incubator-taverna-mobile pull request #56: Migration RxJava 1 -> RxJava2

2018-02-19 Thread therajanmaurya
Github user therajanmaurya commented on a diff in the pull request: https://github.com/apache/incubator-taverna-mobile/pull/56#discussion_r169137816 --- Diff: app/src/main/java/org/apache/taverna/mobile/ui/workflowrun/WorkflowRunPresenter.java --- @@ -31,50 +31,48 @@ import

[GitHub] incubator-taverna-mobile pull request #56: Migration RxJava 1 -> RxJava2

2018-02-19 Thread therajanmaurya
Github user therajanmaurya commented on a diff in the pull request: https://github.com/apache/incubator-taverna-mobile/pull/56#discussion_r169131194 --- Diff: app/build.gradle --- @@ -82,11 +88,8 @@ dependencies { compile

[GitHub] incubator-taverna-mobile pull request #56: Migration RxJava 1 -> RxJava2

2018-02-19 Thread therajanmaurya
Github user therajanmaurya commented on a diff in the pull request: https://github.com/apache/incubator-taverna-mobile/pull/56#discussion_r169132417 --- Diff: app/src/main/java/org/apache/taverna/mobile/data/local/PreferencesHelper.java --- @@ -155,9 +158,15 @@ private void

[GitHub] incubator-taverna-mobile pull request #56: Migration RxJava 1 -> RxJava2

2018-02-19 Thread therajanmaurya
Github user therajanmaurya commented on a diff in the pull request: https://github.com/apache/incubator-taverna-mobile/pull/56#discussion_r169136620 --- Diff: app/src/main/java/org/apache/taverna/mobile/ui/myworkflows/MyWorkflowPresenter.java --- @@ -102,23 +101,20 @@ public

[GitHub] incubator-taverna-mobile pull request #56: Migration RxJava 1 -> RxJava2

2018-02-19 Thread therajanmaurya
Github user therajanmaurya commented on a diff in the pull request: https://github.com/apache/incubator-taverna-mobile/pull/56#discussion_r169134000 --- Diff: app/src/main/java/org/apache/taverna/mobile/ui/favouriteworkflowdetail/FavouriteWorkflowDetailPresenter.java --- @@

[GitHub] incubator-taverna-mobile pull request #56: Migration RxJava 1 -> RxJava2

2018-02-19 Thread therajanmaurya
Github user therajanmaurya commented on a diff in the pull request: https://github.com/apache/incubator-taverna-mobile/pull/56#discussion_r169131553 --- Diff: app/src/main/java/org/apache/taverna/mobile/data/local/DBHelper.java --- @@ -46,23 +46,21 @@ public DBHelper() {

[GitHub] incubator-taverna-mobile pull request #56: Migration RxJava 1 -> RxJava2

2018-02-19 Thread therajanmaurya
Github user therajanmaurya commented on a diff in the pull request: https://github.com/apache/incubator-taverna-mobile/pull/56#discussion_r169137166 --- Diff: app/src/main/java/org/apache/taverna/mobile/ui/workflow/WorkflowPresenter.java --- @@ -111,33 +111,36 @@ public void

[GitHub] incubator-taverna-mobile pull request #56: Migration RxJava 1 -> RxJava2

2018-02-19 Thread Hiteshgautam01
Github user Hiteshgautam01 commented on a diff in the pull request: https://github.com/apache/incubator-taverna-mobile/pull/56#discussion_r169177839 --- Diff: app/src/main/java/org/apache/taverna/mobile/ui/login/LoginPresenter.java --- @@ -76,16 +75,15 @@ public void