[GitHub] thrift pull request #1042: THRIFT-3874 PHP Compiler: struct definition is no...

2016-09-23 Thread sashakavun
Github user sashakavun closed the pull request at: https://github.com/apache/thrift/pull/1042 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[jira] [Commented] (THRIFT-3874) _TSPEC is not populated on de-serialization of type classes

2016-09-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15518033#comment-15518033 ] ASF GitHub Bot commented on THRIFT-3874: Github user sashakavun closed the pull request at:

[jira] [Commented] (THRIFT-3507) THttpClient does not use proxy from http_proxy, https_proxy environment variables

2016-09-23 Thread Martin Wilck (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15517514#comment-15517514 ] Martin Wilck commented on THRIFT-3507: -- THRIFT-3507-1.patch was Fabricio. Mine is a modification of

[jira] [Commented] (THRIFT-3798) CLONE - THttpClient does not use proxy from http_proxy, https_proxy environment variables

2016-09-23 Thread Martin Wilck (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15515716#comment-15515716 ] Martin Wilck commented on THRIFT-3798: -- What's going on in this project? Why does it take so long to

[jira] [Commented] (THRIFT-3507) THttpClient does not use proxy from http_proxy, https_proxy environment variables

2016-09-23 Thread Martin Wilck (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15515718#comment-15515718 ] Martin Wilck commented on THRIFT-3507: -- What's going on in this project? Why does it take so long to

[GitHub] thrift pull request #1093: Add persistence patch

2016-09-23 Thread sstach
GitHub user sstach opened a pull request: https://github.com/apache/thrift/pull/1093 Add persistence patch You can merge this pull request into a Git repository by running: $ git pull https://github.com/shopping24/thrift feature/make_persistence_great_again Alternatively

[jira] [Commented] (THRIFT-3773) Swift Library

2016-09-23 Thread Darren Mo (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15516925#comment-15516925 ] Darren Mo commented on THRIFT-3773: --- So how does one get an Apache Thrift pull request merged? > Swift

[jira] [Commented] (THRIFT-3773) Swift Library

2016-09-23 Thread Chris Simpson (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15517318#comment-15517318 ] Chris Simpson commented on THRIFT-3773: --- I'm a bit biased since I wrote it, but I can say that my

[jira] [Commented] (THRIFT-3507) THttpClient does not use proxy from http_proxy, https_proxy environment variables

2016-09-23 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15517380#comment-15517380 ] Jens Geyer commented on THRIFT-3507: Why do we have to tickets that seem to deal with the same issue

[jira] [Commented] (THRIFT-3773) Swift Library

2016-09-23 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15517307#comment-15517307 ] Jens Geyer commented on THRIFT-3773: @all: Any Swift devs around that want to participate in

[GitHub] thrift pull request #1093: Add persistence patch

2016-09-23 Thread Jens-G
Github user Jens-G commented on a diff in the pull request: https://github.com/apache/thrift/pull/1093#discussion_r80308383 --- Diff: lib/php/lib/Thrift/Protocol/TBinaryProtocol.php --- @@ -246,6 +257,10 @@ public function readMessageBegin(&$name, &$type, &$seqid) }

[GitHub] thrift pull request #1093: Add persistence patch

2016-09-23 Thread Jens-G
Github user Jens-G commented on a diff in the pull request: https://github.com/apache/thrift/pull/1093#discussion_r80308235 --- Diff: compiler/cpp/src/generate/t_php_generator.cc --- @@ -1720,6 +1720,7 @@ void t_php_generator::generate_service_client(t_service* tservice) {

[jira] [Commented] (THRIFT-3507) THttpClient does not use proxy from http_proxy, https_proxy environment variables

2016-09-23 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15517445#comment-15517445 ] Jens Geyer commented on THRIFT-3507: Something is conflicting here. There are two patches named