[GitHub] thrift pull request #1094: Fixes THRIFT-3855

2016-09-25 Thread Jens-G
Github user Jens-G commented on a diff in the pull request: https://github.com/apache/thrift/pull/1094#discussion_r80390983 --- Diff: lib/go/thrift/simple_server.go --- @@ -183,9 +186,6 @@ func (p *TSimpleServer) processRequests(client TTransport) error {

[GitHub] thrift pull request #1094: Fixes THRIFT-3855

2016-09-25 Thread Jens-G
Github user Jens-G commented on a diff in the pull request: https://github.com/apache/thrift/pull/1094#discussion_r80390991 --- Diff: lib/go/thrift/simple_server.go --- @@ -183,9 +186,6 @@ func (p *TSimpleServer) processRequests(client TTransport) error {

[jira] [Commented] (THRIFT-3855) In the go simple server, if Stop() is called multiple times it hangs

2016-09-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15521358#comment-15521358 ] ASF GitHub Bot commented on THRIFT-3855: Github user Jens-G commented on a diff in the pull

[jira] [Commented] (THRIFT-3902) TFramedTransport.open throws NullPointerException

2016-09-25 Thread Henrique Andrade (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15521275#comment-15521275 ] Henrique Andrade commented on THRIFT-3902: -- @aki: since this is now marked resolved, can you

[jira] [Commented] (THRIFT-3507) THttpClient does not use proxy from http_proxy, https_proxy environment variables

2016-09-25 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15521391#comment-15521391 ] Jens Geyer commented on THRIFT-3507: Let's just assume, I want to apply the patches that are intended

[jira] [Commented] (THRIFT-3855) In the go simple server, if Stop() is called multiple times it hangs

2016-09-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15521462#comment-15521462 ] ASF GitHub Bot commented on THRIFT-3855: Github user asm0dey commented on a diff in the pull

[jira] [Commented] (THRIFT-3933) Port official C# .NET library for Thrift to C# .NET Core libary

2016-09-25 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15521351#comment-15521351 ] Jens Geyer commented on THRIFT-3933: GitHub user vgotra opened a pull request:

[jira] [Updated] (THRIFT-3933) Port official C# .NET library for Thrift to C# .NET Core libary

2016-09-25 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3933?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer updated THRIFT-3933: --- Flags: (was: Important) > Port official C# .NET library for Thrift to C# .NET Core libary >

Re: [apache/thrift] Microsoft .Net Core library port and generator for this library (#1088)

2016-09-25 Thread Jens Geyer
Hi, > > > lib/netcore/src/Samples > > > > > If that is the Thrift Test Suite client/server pair, that part should be > > move to /test/netcore. All other tests should remain under /lib/netcore. > > [...] > > > Moved it to tutorial/netcore folder > Yes, cool, thanks, but ... we do have

[GitHub] thrift pull request #1094: Fixes THRIFT-3855

2016-09-25 Thread asm0dey
Github user asm0dey commented on a diff in the pull request: https://github.com/apache/thrift/pull/1094#discussion_r80391820 --- Diff: lib/go/thrift/simple_server.go --- @@ -183,9 +186,6 @@ func (p *TSimpleServer) processRequests(client TTransport) error {

[jira] [Commented] (THRIFT-3507) THttpClient does not use proxy from http_proxy, https_proxy environment variables

2016-09-25 Thread Aki Sukegawa (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15521775#comment-15521775 ] Aki Sukegawa commented on THRIFT-3507: -- Reading http_proxy without reading no_proxy would result in

[GitHub] thrift pull request #1094: Fixes THRIFT-3855

2016-09-25 Thread asm0dey
Github user asm0dey commented on a diff in the pull request: https://github.com/apache/thrift/pull/1094#discussion_r80391813 --- Diff: lib/go/thrift/simple_server.go --- @@ -183,9 +186,6 @@ func (p *TSimpleServer) processRequests(client TTransport) error {

[jira] [Commented] (THRIFT-3855) In the go simple server, if Stop() is called multiple times it hangs

2016-09-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15521406#comment-15521406 ] ASF GitHub Bot commented on THRIFT-3855: Github user asm0dey commented on a diff in the pull

[jira] [Commented] (THRIFT-3855) In the go simple server, if Stop() is called multiple times it hangs

2016-09-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15521408#comment-15521408 ] ASF GitHub Bot commented on THRIFT-3855: Github user asm0dey commented on a diff in the pull

[jira] [Commented] (THRIFT-3855) In the go simple server, if Stop() is called multiple times it hangs

2016-09-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15521453#comment-15521453 ] ASF GitHub Bot commented on THRIFT-3855: Github user Jens-G commented on a diff in the pull

[GitHub] thrift pull request #1094: Fixes THRIFT-3855

2016-09-25 Thread Jens-G
Github user Jens-G commented on a diff in the pull request: https://github.com/apache/thrift/pull/1094#discussion_r80392522 --- Diff: lib/go/thrift/simple_server.go --- @@ -183,9 +186,6 @@ func (p *TSimpleServer) processRequests(client TTransport) error {

[jira] [Commented] (THRIFT-3902) TFramedTransport.open throws NullPointerException

2016-09-25 Thread Aki Sukegawa (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15521748#comment-15521748 ] Aki Sukegawa commented on THRIFT-3902: -- [~hcma] it's not marked as resolved. There were 2 identical

[jira] [Commented] (THRIFT-3855) In the go simple server, if Stop() is called multiple times it hangs

2016-09-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15521359#comment-15521359 ] ASF GitHub Bot commented on THRIFT-3855: Github user Jens-G commented on a diff in the pull

[jira] [Comment Edited] (THRIFT-3507) THttpClient does not use proxy from http_proxy, https_proxy environment variables

2016-09-25 Thread Aki Sukegawa (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15521775#comment-15521775 ] Aki Sukegawa edited comment on THRIFT-3507 at 9/26/16 2:02 AM: --- edit: never

[GitHub] thrift pull request #1094: Fixes THRIFT-3855

2016-09-25 Thread asm0dey
Github user asm0dey commented on a diff in the pull request: https://github.com/apache/thrift/pull/1094#discussion_r80392646 --- Diff: lib/go/thrift/simple_server.go --- @@ -183,9 +186,6 @@ func (p *TSimpleServer) processRequests(client TTransport) error {

[jira] [Commented] (THRIFT-3855) In the go simple server, if Stop() is called multiple times it hangs

2016-09-25 Thread Paul Finkelshteyn (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15520419#comment-15520419 ] Paul Finkelshteyn commented on THRIFT-3855: --- To a pity one test is failed due to some technical

[GitHub] thrift pull request #1095: THRIFT-3826 Appveyor builds cannot download winfl...

2016-09-25 Thread nsuke
GitHub user nsuke opened a pull request: https://github.com/apache/thrift/pull/1095 THRIFT-3826 Appveyor builds cannot download winflexbison properly You can merge this pull request into a Git repository by running: $ git pull https://github.com/nsuke/thrift THRIFT-3826

[jira] [Commented] (THRIFT-3826) Appveyor builds cannot download winflexbison properly

2016-09-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15521072#comment-15521072 ] ASF GitHub Bot commented on THRIFT-3826: GitHub user nsuke opened a pull request:

[GitHub] thrift pull request #368: THRIFT-2835 Add possibility to distribute generato...

2016-09-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/368 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] thrift pull request #1021: Fix THRIFT-3844

2016-09-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/1021 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] thrift pull request #971: Update php_thrift_protocol7.cpp

2016-09-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/971 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] thrift pull request #1048: Ensuring that HTTP failures will clear the http t...

2016-09-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/1048 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (THRIFT-3748) Node.js Deserialization of lists of lists is broken

2016-09-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15521090#comment-15521090 ] ASF GitHub Bot commented on THRIFT-3748: Github user asfgit closed the pull request at:

[jira] [Commented] (THRIFT-2835) Add possibility to distribute generators separately from thrift core, and load them dynamically

2016-09-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15521091#comment-15521091 ] ASF GitHub Bot commented on THRIFT-2835: Github user asfgit closed the pull request at:

[GitHub] thrift pull request #1089: THRIFT-3929 php namespace remove tail "\\"

2016-09-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/1089 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (THRIFT-3844) thrift_protocol cannot compile in 7.0.7

2016-09-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15521088#comment-15521088 ] ASF GitHub Bot commented on THRIFT-3844: Github user asfgit closed the pull request at:

[jira] [Commented] (THRIFT-3929) PHP "nsglobal" Option Results in Syntax Error in Generated Code (Trailing Backslash)

2016-09-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15521092#comment-15521092 ] ASF GitHub Bot commented on THRIFT-3929: Github user asfgit closed the pull request at:

[GitHub] thrift pull request #1095: THRIFT-3826 Appveyor builds cannot download winfl...

2016-09-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/1095 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] thrift pull request #1022: THRIFT-3845

2016-09-25 Thread nsuke
Github user nsuke commented on a diff in the pull request: https://github.com/apache/thrift/pull/1022#discussion_r80386819 --- Diff: compiler/cpp/src/generate/t_php_generator.cc --- @@ -1341,9 +1341,13 @@ void t_php_generator::generate_process_function(t_service* tservice,

[jira] [Commented] (THRIFT-3845) TBinaryProtocolAccelerated cannot use thrift_protocol ext

2016-09-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15521146#comment-15521146 ] ASF GitHub Bot commented on THRIFT-3845: Github user nsuke commented on a diff in the pull

[GitHub] thrift pull request #1022: THRIFT-3845

2016-09-25 Thread nsuke
Github user nsuke commented on a diff in the pull request: https://github.com/apache/thrift/pull/1022#discussion_r80386881 --- Diff: lib/php/lib/Thrift/Protocol/TBinaryProtocolAccelerated.php --- @@ -62,4 +62,9 @@ public function isStrictWrite() { return

[GitHub] thrift issue #1039: THRIFT-2835 Add possibility to distribute generators sep...

2016-09-25 Thread nsuke
Github user nsuke commented on the issue: https://github.com/apache/thrift/pull/1039 @dtmuller just committed, thanks for all the help and improvements ! It might have not happened at all if you didn't pick it up and revive it ... --- If your project is set up for it, you can

[jira] [Commented] (THRIFT-2835) Add possibility to distribute generators separately from thrift core, and load them dynamically

2016-09-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15521150#comment-15521150 ] ASF GitHub Bot commented on THRIFT-2835: Github user nsuke commented on the issue:

[jira] [Updated] (THRIFT-3929) PHP "nsglobal" Option Results in Syntax Error in Generated Code (Trailing Backslash)

2016-09-25 Thread Aki Sukegawa (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3929?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aki Sukegawa updated THRIFT-3929: - Affects Version/s: (was: 1.0) 0.9.3 > PHP "nsglobal" Option Results

[jira] [Resolved] (THRIFT-3929) PHP "nsglobal" Option Results in Syntax Error in Generated Code (Trailing Backslash)

2016-09-25 Thread Aki Sukegawa (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3929?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aki Sukegawa resolved THRIFT-3929. -- Resolution: Fixed Assignee: Ben Meynell Fix Version/s: (was: 1.0)

[jira] [Updated] (THRIFT-3844) thrift_protocol cannot compile in 7.0.7

2016-09-25 Thread Aki Sukegawa (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3844?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aki Sukegawa updated THRIFT-3844: - Affects Version/s: (was: 1.0) 0.10.0 > thrift_protocol cannot compile

[jira] [Resolved] (THRIFT-3844) thrift_protocol cannot compile in 7.0.7

2016-09-25 Thread Aki Sukegawa (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3844?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aki Sukegawa resolved THRIFT-3844. -- Resolution: Fixed Assignee: Robert Lu Fix Version/s: 0.10.0 > thrift_protocol

[jira] [Updated] (THRIFT-3845) TBinaryProtocolAccelerated cannot use thrift_protocol ext

2016-09-25 Thread Aki Sukegawa (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3845?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aki Sukegawa updated THRIFT-3845: - Assignee: Robert Lu > TBinaryProtocolAccelerated cannot use thrift_protocol ext >

[jira] [Resolved] (THRIFT-3920) Ruby: Ensuring that HTTP failures will clear the http transport outbuf var

2016-09-25 Thread Aki Sukegawa (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3920?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aki Sukegawa resolved THRIFT-3920. -- Resolution: Fixed Assignee: John Fix Version/s: 0.10.0 committed, thanks. >

[jira] [Updated] (THRIFT-3839) Performance issue with big message deserialization using php extension

2016-09-25 Thread Aki Sukegawa (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3839?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aki Sukegawa updated THRIFT-3839: - Affects Version/s: (was: 1.0) > Performance issue with big message deserialization using php

[jira] [Resolved] (THRIFT-3839) Performance issue with big message deserialization using php extension

2016-09-25 Thread Aki Sukegawa (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3839?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aki Sukegawa resolved THRIFT-3839. -- Resolution: Fixed Assignee: Myroslav Kosinskyi Fix Version/s: (was: 1.0)

[GitHub] thrift pull request #1078: THRIFT-3919 C# TTLSServerSocket does not use clie...

2016-09-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/1078 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (THRIFT-3919) C# TTLSServerSocket does not use clientTimeout

2016-09-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15521172#comment-15521172 ] ASF GitHub Bot commented on THRIFT-3919: Github user asfgit closed the pull request at:

[jira] [Commented] (THRIFT-3925) Client service recieves string instead of buffer when using TCompactProtocol with node.js library.

2016-09-25 Thread Aki Sukegawa (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15521203#comment-15521203 ] Aki Sukegawa commented on THRIFT-3925: -- I think it's resolved as part of THRIFT-3409 in master

[jira] [Resolved] (THRIFT-3901) TFramedTransport.open throws NullPointerException

2016-09-25 Thread Aki Sukegawa (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3901?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aki Sukegawa resolved THRIFT-3901. -- Resolution: Duplicate Assignee: Aki Sukegawa > TFramedTransport.open throws

[jira] [Commented] (THRIFT-3902) TFramedTransport.open throws NullPointerException

2016-09-25 Thread Aki Sukegawa (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15521215#comment-15521215 ] Aki Sukegawa commented on THRIFT-3902: -- {code} if (host_.length() == 0) { {code} This means that