[
https://issues.apache.org/jira/browse/THRIFT-4484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16348660#comment-16348660
]
Craig Ringer commented on THRIFT-4484:
--
[~davejwatson] Brilliant! Apparently it's now spelled "&",
Github user ringerc commented on the issue:
https://github.com/apache/thrift/pull/84
Anyone else facing that issue: workaround is to declare a reference:
```
struct RecSelf {
1: i16 item
2: optional RecSelf
}
```
Note the `&`.
---
[
https://issues.apache.org/jira/browse/THRIFT-4448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16349043#comment-16349043
]
ASF GitHub Bot commented on THRIFT-4448:
Github user johnboiles commented on the issue:
Github user johnboiles commented on the issue:
https://github.com/apache/thrift/pull/1459
@dcelasun I'm happy to do that. Though in my experience, tests that depend
on timing will find a way to be flakey, especially in CI.
If you think the value of testing this is worth the
Github user coveralls commented on the issue:
https://github.com/apache/thrift/pull/841
[](https://coveralls.io/builds/15328429)
Coverage remained the same at ?% when pulling
[
https://issues.apache.org/jira/browse/THRIFT-3608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16348799#comment-16348799
]
ASF GitHub Bot commented on THRIFT-3608:
Github user coveralls commented on the issue:
[
https://issues.apache.org/jira/browse/THRIFT-4454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16349443#comment-16349443
]
ASF GitHub Bot commented on THRIFT-4454:
GitHub user Jens-G opened a pull request:
[
https://issues.apache.org/jira/browse/THRIFT-4485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16349441#comment-16349441
]
ASF GitHub Bot commented on THRIFT-4485:
GitHub user Jens-G opened a pull request:
[
https://issues.apache.org/jira/browse/THRIFT-4448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16349230#comment-16349230
]
ASF GitHub Bot commented on THRIFT-4448:
Github user dcelasun commented on the issue:
Github user dcelasun commented on the issue:
https://github.com/apache/thrift/pull/1459
I think it's worth it. The context passes through most parts of the stack
and having a test to ensure it's propagated properly feels imporant.
Also, we can at least reduce the flakiness
GitHub user johnboiles opened a pull request:
https://github.com/apache/thrift/pull/1488
Golang -remote.go client cleanup
Several changes here related to the generated `-remote.go` clients
* Serialize cli input with TJsonProtocol since json->thrift serialization
is not
[
https://issues.apache.org/jira/browse/THRIFT-4485?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jens Geyer updated THRIFT-4485:
---
Description:
If a read or write operation on pipes reaches the set timeout, the read/write
[
https://issues.apache.org/jira/browse/THRIFT-4485?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jens Geyer updated THRIFT-4485:
---
Description:
If a read or write operation on pipes reaches the set timeout, the read/write
Jens Geyer created THRIFT-4485:
--
Summary: Possible invalid ptr AV with overlapped read/write on
pipes
Key: THRIFT-4485
URL: https://issues.apache.org/jira/browse/THRIFT-4485
Project: Thrift
GitHub user Jens-G opened a pull request:
https://github.com/apache/thrift/pull/1489
THRIFT-4485 Possible invalid ptr AV with overlapped read/write on pipes
Client: Delphi
Patch: Jens Geyer
You can merge this pull request into a Git repository by running:
$ git pull
GitHub user Jens-G opened a pull request:
https://github.com/apache/thrift/pull/1490
THRIFT-4454 Large writes/reads may cause range check errors in debug â¦
â¦mode
Client: Delphi
Patch: Jens Geyer
You can merge this pull request into a Git repository by running:
[
https://issues.apache.org/jira/browse/THRIFT-4484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16349631#comment-16349631
]
Craig Ringer commented on THRIFT-4484:
--
Also, the regression tests show that both {{cpp.ref}} and
[
https://issues.apache.org/jira/browse/THRIFT-4484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16349623#comment-16349623
]
Craig Ringer commented on THRIFT-4484:
--
[~davejwatson] Hrm, too soon. {{&}} generates bogus code
[
https://issues.apache.org/jira/browse/THRIFT-4484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16349662#comment-16349662
]
Craig Ringer commented on THRIFT-4484:
--
If I attempt to actually use {{cpp.ref}} in my code as used
[
https://issues.apache.org/jira/browse/THRIFT-4484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16349631#comment-16349631
]
Craig Ringer edited comment on THRIFT-4484 at 2/2/18 2:05 AM:
--
Also, the
[
https://issues.apache.org/jira/browse/THRIFT-4484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16349662#comment-16349662
]
Craig Ringer edited comment on THRIFT-4484 at 2/2/18 2:09 AM:
--
If I attempt
[
https://issues.apache.org/jira/browse/THRIFT-4484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16349623#comment-16349623
]
Craig Ringer edited comment on THRIFT-4484 at 2/2/18 1:18 AM:
--
[
https://issues.apache.org/jira/browse/THRIFT-4484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16349631#comment-16349631
]
Craig Ringer edited comment on THRIFT-4484 at 2/2/18 1:43 AM:
--
Also, the
[
https://issues.apache.org/jira/browse/THRIFT-2471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16349640#comment-16349640
]
Craig Ringer commented on THRIFT-2471:
--
I think a mistake may have been made in this commit, because
John Boiles created THRIFT-4486:
---
Summary: Golang: -remote.go client cleanup
Key: THRIFT-4486
URL: https://issues.apache.org/jira/browse/THRIFT-4486
Project: Thrift
Issue Type: Task
Github user johnboiles commented on the issue:
https://github.com/apache/thrift/pull/1459
@dcelasun: done, could you take another look?
---
[
https://issues.apache.org/jira/browse/THRIFT-4448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16349864#comment-16349864
]
ASF GitHub Bot commented on THRIFT-4448:
Github user dcelasun commented on the issue:
Github user dcelasun commented on the issue:
https://github.com/apache/thrift/pull/1459
The test fails with:
> src/common/context_test.go:45: server.Close undefined (type *http.Server
has no field or method Close)
`Server.Close()` was added in 1.8 but the test uses
Github user johnboiles commented on the issue:
https://github.com/apache/thrift/pull/1459
@dcelasun I don't think I can do a `runtime.Version` check since the code
is failing at compilation time. I'll just remove that line.
---
[
https://issues.apache.org/jira/browse/THRIFT-4448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16349928#comment-16349928
]
ASF GitHub Bot commented on THRIFT-4448:
Github user dcelasun commented on the issue:
Github user dcelasun commented on the issue:
https://github.com/apache/thrift/pull/1459
It would be nice to add a client test using e.g `context.WithTimeout()`.
Something like:
- In the handler function, sleep for 100ms before returning
- In the client, call the RPC with
[
https://issues.apache.org/jira/browse/THRIFT-4448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16348236#comment-16348236
]
ASF GitHub Bot commented on THRIFT-4448:
Github user dcelasun commented on the issue:
32 matches
Mail list logo
