[GitHub] thrift pull request: Make C++ structs assign __isset field when co...

2014-05-11 Thread nsuke
GitHub user nsuke opened a pull request: https://github.com/apache/thrift/pull/120 Make C++ structs assign __isset field when copy/assigning You can merge this pull request into a Git repository by running: $ git pull https://github.com/nsuke/thrift THRIFT-2526 Alternatively

[GitHub] thrift pull request: THRIFT-2520 Compiler:put non-template method ...

2014-05-15 Thread nsuke
GitHub user nsuke opened a pull request: https://github.com/apache/thrift/pull/118 THRIFT-2520 Compiler:put non-template method definitions in .cpp files See https://issues.apache.org/jira/browse/THRIFT-2520 . You can merge this pull request into a Git repository by running

[GitHub] thrift pull request: TFileTransport missuse of closesocket on wind...

2014-06-17 Thread nsuke
Github user nsuke commented on the pull request: https://github.com/apache/thrift/pull/142#issuecomment-46338660 The failing TFDTransport test is not about avoiding double-close but ensuring that the destructor throws. The problem is that C++11 defaults destructors to noexcept

[GitHub] thrift pull request: THRIFT-2838 TNonblockingServer can bind to po...

2014-12-06 Thread nsuke
GitHub user nsuke opened a pull request: https://github.com/apache/thrift/pull/306 THRIFT-2838 TNonblockingServer can bind to port 0 (i.e., get an OS-assig... ...ned port) but there is no way to get the port number You can merge this pull request into a Git repository by running

[GitHub] thrift pull request: THRIFT-2098 Add support for Qt5+

2014-12-07 Thread nsuke
GitHub user nsuke opened a pull request: https://github.com/apache/thrift/pull/307 THRIFT-2098 Add support for Qt5+ You can merge this pull request into a Git repository by running: $ git pull https://github.com/nsuke/thrift THRIFT-2098 Alternatively you can review and apply

[GitHub] thrift pull request: THRIFT-2098 Add support for Qt5+

2014-12-07 Thread nsuke
Github user nsuke commented on a diff in the pull request: https://github.com/apache/thrift/pull/307#discussion_r21424261 --- Diff: configure.ac --- @@ -152,11 +152,26 @@ if test "$with_cpp" = "yes"; then AC_PATH_PROGS([QT_MOC], [moc-qt4 moc])

[GitHub] thrift pull request: THRIFT-2098 Add support for Qt5+

2014-12-07 Thread nsuke
Github user nsuke commented on a diff in the pull request: https://github.com/apache/thrift/pull/307#discussion_r21424274 --- Diff: lib/cpp/Makefile.am --- @@ -22,6 +22,9 @@ AUTOMAKE_OPTIONS = subdir-objects moc_%.cpp: %.h $(QT_MOC) $(QT_CFLAGS) $<

[GitHub] thrift pull request: THRIFT-2098 Add support for Qt5+

2014-12-07 Thread nsuke
Github user nsuke commented on the pull request: https://github.com/apache/thrift/pull/307#issuecomment-65941695 Yes, sorry for prematurely pushing the fix. I'm having difficulty with Ubuntu 12.04 + trusty apt repo with Qt5 (on travis). It is specifically caus

[GitHub] thrift pull request: THRIFT-2838 TNonblockingServer can bind to po...

2014-12-07 Thread nsuke
Github user nsuke closed the pull request at: https://github.com/apache/thrift/pull/306 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] thrift pull request: THRIFT-2893 CMake build fails with boost thre...

2014-12-16 Thread nsuke
GitHub user nsuke opened a pull request: https://github.com/apache/thrift/pull/321 THRIFT-2893 CMake build fails with boost thread or std thread Following changes are made to fix the build * Add USE_..._THREAD compiler definitions correctly * Link to boost_thread and

[GitHub] thrift pull request: THRIFT-2893 CMake build fails with boost thre...

2014-12-16 Thread nsuke
Github user nsuke commented on the pull request: https://github.com/apache/thrift/pull/321#issuecomment-67169703 Note that current code uses mixed `#if` and `#ifdef` for `USE_..._Thread` preprocessor macro tests and I unified those too. These differs only when macro value

[GitHub] thrift pull request: THRIFT-2902 Generated c_glib code does not co...

2014-12-17 Thread nsuke
GitHub user nsuke opened a pull request: https://github.com/apache/thrift/pull/323 THRIFT-2902 Generated c_glib code does not compile with clang You can merge this pull request into a Git repository by running: $ git pull https://github.com/nsuke/thrift THRIFT-2902

[GitHub] thrift pull request: THRIFT-2903 Qt4 library built with CMake does...

2014-12-17 Thread nsuke
GitHub user nsuke opened a pull request: https://github.com/apache/thrift/pull/324 THRIFT-2903 Qt4 library built with CMake does not work You can merge this pull request into a Git repository by running: $ git pull https://github.com/nsuke/thrift THRIFT-2903 Alternatively

[GitHub] thrift pull request: THRIFT-2902 Generated c_glib code does not co...

2014-12-19 Thread nsuke
Github user nsuke commented on the pull request: https://github.com/apache/thrift/pull/323#issuecomment-67671340 Merged as 80784b1098d95232b329cdec6e8f056d10380409 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] thrift pull request: THRIFT-2902 Generated c_glib code does not co...

2014-12-19 Thread nsuke
Github user nsuke closed the pull request at: https://github.com/apache/thrift/pull/323 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] thrift pull request: THRIFT-2903 Qt4 library built with CMake does...

2014-12-19 Thread nsuke
Github user nsuke commented on the pull request: https://github.com/apache/thrift/pull/324#issuecomment-67672561 The build has been fixed (Travis failure is gcc internal error + make cross instability). I also added CMake build. --- If your project is set up for it, you can

[GitHub] thrift pull request: THRIFT-2098 Add support for Qt5+

2014-12-19 Thread nsuke
Github user nsuke commented on the pull request: https://github.com/apache/thrift/pull/307#issuecomment-67672885 The build has been fixed (Travis failure is gcc internal error + make cross instability). I also added CMake build. --- If your project is set up for it, you can

[GitHub] thrift pull request: fix c++ version zeromq transport, the old ver...

2014-12-21 Thread nsuke
Github user nsuke commented on the pull request: https://github.com/apache/thrift/pull/315#issuecomment-67766086 TTransport inheritance made by TZmqClient is indeed incorrect, it doesn't override anything, only hiding virtual methods. It should still work if used dir

[GitHub] thrift pull request: THRIFT-2909 Improve travis build

2014-12-21 Thread nsuke
GitHub user nsuke opened a pull request: https://github.com/apache/thrift/pull/335 THRIFT-2909 Improve travis build You can merge this pull request into a Git repository by running: $ git pull https://github.com/nsuke/thrift THRIFT-2909 Alternatively you can review and apply

[GitHub] thrift pull request: THRIFT-2909 Improve travis build

2014-12-21 Thread nsuke
Github user nsuke commented on the pull request: https://github.com/apache/thrift/pull/335#issuecomment-67772565 Since every one of my pending PRs conflicts with each other, I lumped them up here. If you want to pick up in a different order or does not want to pull in any of them

[GitHub] thrift pull request: THRIFT-2903 Qt4 library built with CMake does...

2014-12-21 Thread nsuke
Github user nsuke commented on the pull request: https://github.com/apache/thrift/pull/324#issuecomment-67772590 Obsoleted by this https://github.com/apache/thrift/pull/335 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] thrift pull request: THRIFT-2098 Add support for Qt5+

2014-12-21 Thread nsuke
Github user nsuke closed the pull request at: https://github.com/apache/thrift/pull/307 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] thrift pull request: THRIFT-2893 CMake build fails with boost thre...

2014-12-21 Thread nsuke
Github user nsuke closed the pull request at: https://github.com/apache/thrift/pull/321 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] thrift pull request: THRIFT-2903 Qt4 library built with CMake does...

2014-12-21 Thread nsuke
Github user nsuke closed the pull request at: https://github.com/apache/thrift/pull/324 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] thrift pull request: THRIFT-2098 Add support for Qt5+

2014-12-21 Thread nsuke
Github user nsuke commented on the pull request: https://github.com/apache/thrift/pull/307#issuecomment-67772599 Obsoleted by this https://github.com/apache/thrift/pull/335 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] thrift pull request: THRIFT-2893 CMake build fails with boost thre...

2014-12-21 Thread nsuke
Github user nsuke commented on the pull request: https://github.com/apache/thrift/pull/321#issuecomment-67772594 Obsoleted by this https://github.com/apache/thrift/pull/335 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] thrift pull request: THRIFT-2909 Improve travis build

2014-12-21 Thread nsuke
Github user nsuke closed the pull request at: https://github.com/apache/thrift/pull/335 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] thrift pull request: THRIFT-2909 Improve travis build

2014-12-21 Thread nsuke
Github user nsuke commented on the pull request: https://github.com/apache/thrift/pull/335#issuecomment-67789137 Merged as https://github.com/apache/thrift/commit/2825664f25e084a922462c77f496d215e41251a9 https://github.com/apache/thrift/commit

[GitHub] thrift pull request: THRIFT-2912 Autotool build for C++ Qt library...

2014-12-23 Thread nsuke
GitHub user nsuke opened a pull request: https://github.com/apache/thrift/pull/336 THRIFT-2912 Autotool build for C++ Qt library is invalid * Fix incorrect AC_PATH_PROGS usage * Exclude generated source code from distribution You can merge this pull request into a Git

[GitHub] thrift pull request: THRIFT-2910 libevent is not really optional

2014-12-23 Thread nsuke
GitHub user nsuke opened a pull request: https://github.com/apache/thrift/pull/337 THRIFT-2910 libevent is not really optional You can merge this pull request into a Git repository by running: $ git pull https://github.com/nsuke/thrift THRIFT-2910 Alternatively you can

[GitHub] thrift pull request: THRIFT-2924 TNonblockingServer crashes when u...

2015-01-02 Thread nsuke
GitHub user nsuke opened a pull request: https://github.com/apache/thrift/pull/343 THRIFT-2924 TNonblockingServer crashes when user-provided event_base is ... ...used You can merge this pull request into a Git repository by running: $ git pull https://github.com/nsuke/thrift

[GitHub] thrift pull request: THRIFT-2925 CMake build does not work with Op...

2015-01-02 Thread nsuke
GitHub user nsuke opened a pull request: https://github.com/apache/thrift/pull/344 THRIFT-2925 CMake build does not work with OpenSSL nor anything installe... ...d in non-system location This diff fixes them by correcting invalid CMake variable names: * OPENSSL_

[GitHub] thrift pull request: THRIFT-2924 TNonblockingServer crashes when u...

2015-01-05 Thread nsuke
Github user nsuke closed the pull request at: https://github.com/apache/thrift/pull/343 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] thrift pull request: THRIFT-2925 CMake build does not work with Op...

2015-01-05 Thread nsuke
Github user nsuke closed the pull request at: https://github.com/apache/thrift/pull/344 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] thrift pull request: THRIFT-2924 TNonblockingServer crashes when u...

2015-01-05 Thread nsuke
Github user nsuke commented on the pull request: https://github.com/apache/thrift/pull/343#issuecomment-68719963 Merged as 8016af800ff19e2b67f691453c573f3d8f34211d --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] thrift pull request: THRIFT-2925 CMake build does not work with Op...

2015-01-05 Thread nsuke
Github user nsuke commented on the pull request: https://github.com/apache/thrift/pull/344#issuecomment-68719977 Merged as c444fb581d2157c260f36db091a7cdd4511c6e32, thanks :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] thrift pull request: THRIFT-2946 Enhance usability of cross test f...

2015-01-17 Thread nsuke
GitHub user nsuke opened a pull request: https://github.com/apache/thrift/pull/358 THRIFT-2946 Enhance usability of cross test framework You can merge this pull request into a Git repository by running: $ git pull https://github.com/nsuke/thrift THRIFT-2946 Alternatively you

[GitHub] thrift pull request: THRIFT-2951 Fix Erlang name conflict test

2015-01-27 Thread nsuke
GitHub user nsuke opened a pull request: https://github.com/apache/thrift/pull/360 THRIFT-2951 Fix Erlang name conflict test You can merge this pull request into a Git repository by running: $ git pull https://github.com/nsuke/thrift THRIFT-2951 Alternatively you can review

[GitHub] thrift pull request: THRIFT-2971 - C++ test and tutorial parallel ...

2015-01-31 Thread nsuke
GitHub user nsuke opened a pull request: https://github.com/apache/thrift/pull/366 THRIFT-2971 - C++ test and tutorial parallel build is unstable You can merge this pull request into a Git repository by running: $ git pull https://github.com/nsuke/thrift THRIFT-2971

[GitHub] thrift pull request: THRIFT-2972 - Missing backstash in lib/cpp/te...

2015-01-31 Thread nsuke
GitHub user nsuke opened a pull request: https://github.com/apache/thrift/pull/367 THRIFT-2972 - Missing backstash in lib/cpp/test/Makefile.am You can merge this pull request into a Git repository by running: $ git pull https://github.com/nsuke/thrift THRIFT-2972

[GitHub] thrift pull request: THRIFT-2835 Add possibility to distribute gen...

2015-01-31 Thread nsuke
GitHub user nsuke opened a pull request: https://github.com/apache/thrift/pull/368 THRIFT-2835 Add possibility to distribute generators separately from thr... ...ift core, and load them dynamically You can merge this pull request into a Git repository by running: $ git pull

[GitHub] thrift pull request: THRIFT-2971 - C++ test and tutorial parallel ...

2015-02-04 Thread nsuke
Github user nsuke commented on the pull request: https://github.com/apache/thrift/pull/366#issuecomment-72909093 Merged: a0c5ab711ef47142ca8abb55bc1d4ba139ef8129 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] thrift pull request: THRIFT-2972 - Missing backstash in lib/cpp/te...

2015-02-04 Thread nsuke
Github user nsuke closed the pull request at: https://github.com/apache/thrift/pull/367 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] thrift pull request: THRIFT-2972 - Missing backstash in lib/cpp/te...

2015-02-04 Thread nsuke
Github user nsuke commented on the pull request: https://github.com/apache/thrift/pull/367#issuecomment-72909096 Merged: 208738a6e34c7153908bad77210c6d194ea9d3ab --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] thrift pull request: THRIFT-2971 - C++ test and tutorial parallel ...

2015-02-04 Thread nsuke
Github user nsuke closed the pull request at: https://github.com/apache/thrift/pull/366 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] thrift pull request: THRIFT-2914 explicit dependency to Lua5.2 fai...

2015-02-08 Thread nsuke
GitHub user nsuke opened a pull request: https://github.com/apache/thrift/pull/373 THRIFT-2914 explicit dependency to Lua5.2 fails on some systems You can merge this pull request into a Git repository by running: $ git pull https://github.com/nsuke/thrift THRIFT-2914

[GitHub] thrift pull request: THRIFT-3007 - Travis build is broken because ...

2015-02-22 Thread nsuke
GitHub user nsuke opened a pull request: https://github.com/apache/thrift/pull/381 THRIFT-3007 - Travis build is broken because of directory conflict You can merge this pull request into a Git repository by running: $ git pull https://github.com/nsuke/thrift THRIFT-3007

[GitHub] thrift pull request: THRIFT-3008 - Node.js server does not fully s...

2015-02-22 Thread nsuke
GitHub user nsuke opened a pull request: https://github.com/apache/thrift/pull/382 THRIFT-3008 - Node.js server does not fully support exception You can merge this pull request into a Git repository by running: $ git pull https://github.com/nsuke/thrift THRIFT-3008

[GitHub] thrift pull request: THRIFT-2946 Enhance usability of cross test f...

2015-03-25 Thread nsuke
Github user nsuke commented on the pull request: https://github.com/apache/thrift/pull/358#issuecomment-86085905 merged as 41ad4342c5a0389ab2cf2dbf098086413ac01204. Thanks @bufferoverflow :) --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] thrift pull request: THRIFT-2946 Enhance usability of cross test f...

2015-03-25 Thread nsuke
Github user nsuke closed the pull request at: https://github.com/apache/thrift/pull/358 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] thrift pull request: THRIFT-2578 Moving 'make cross' from test.sh ...

2015-03-29 Thread nsuke
GitHub user nsuke opened a pull request: https://github.com/apache/thrift/pull/408 THRIFT-2578 Moving 'make cross' from test.sh to test.pyremove test.sh You can merge this pull request into a Git repository by running: $ git pull https://github.com/nsuke/thrift T

[GitHub] thrift pull request: THRIFT-2578 Moving 'make cross' from test.sh ...

2015-04-04 Thread nsuke
Github user nsuke closed the pull request at: https://github.com/apache/thrift/pull/408 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] thrift pull request: THRIFT-2578 Moving 'make cross' from test.sh ...

2015-04-04 Thread nsuke
Github user nsuke commented on the pull request: https://github.com/apache/thrift/pull/408#issuecomment-89548009 Merged as f5b795d3be6acc0da30afc4b4aa77e531125eec6 58ed1cdf3cd4da9d013e4cd4b92b3f4e440d145d --- If your project is set up for it, you can reply to this email and have

[GitHub] thrift pull request: THRIFT-2946 Enhance usability of cross test f...

2015-04-11 Thread nsuke
GitHub user nsuke opened a pull request: https://github.com/apache/thrift/pull/436 THRIFT-2946 Enhance usability of cross test framework *make fail* runs test.py 4 times to detect nondeterministic failures. You can merge this pull request into a Git repository by running

[GitHub] thrift pull request: Fix THRIFT-3090 (cmake build is broken)

2015-04-11 Thread nsuke
Github user nsuke commented on a diff in the pull request: https://github.com/apache/thrift/pull/434#discussion_r28195428 --- Diff: lib/cpp/CMakeLists.txt --- @@ -26,7 +26,7 @@ if(WITH_BOOSTTHREADS) else() find_package(Boost 1.53.0 REQUIRED) endif

[GitHub] thrift pull request: Fix THRIFT-3090 (cmake build is broken)

2015-04-12 Thread nsuke
Github user nsuke commented on a diff in the pull request: https://github.com/apache/thrift/pull/434#discussion_r28205720 --- Diff: lib/cpp/CMakeLists.txt --- @@ -26,7 +26,7 @@ if(WITH_BOOSTTHREADS) else() find_package(Boost 1.53.0 REQUIRED) endif

[GitHub] thrift pull request: THRIFT-2946 Enhance usability of cross test f...

2015-04-16 Thread nsuke
Github user nsuke commented on the pull request: https://github.com/apache/thrift/pull/436#issuecomment-93725966 merged as 6d71dc868873691a62b3cb28bf48dcb0e225fa95 147a5a278a71e4652edb8f60043a057f26d60d1d --- If your project is set up for it, you can reply to this email and have

[GitHub] thrift pull request: THRIFT-2946 Enhance usability of cross test f...

2015-04-16 Thread nsuke
Github user nsuke closed the pull request at: https://github.com/apache/thrift/pull/436 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] thrift pull request: THRIFT-2850 cmake win cpp library and unit te...

2015-04-23 Thread nsuke
Github user nsuke commented on the pull request: https://github.com/apache/thrift/pull/456#issuecomment-95649911 It seems that the failure is introduced by THRIFT-3000 https://travis-ci.org/apache/thrift/builds/58981770. Unfortunately, there are no way (that I known of) to

[GitHub] thrift pull request: THRIFT-3109 Cross test log file cannot be bro...

2015-04-23 Thread nsuke
GitHub user nsuke opened a pull request: https://github.com/apache/thrift/pull/457 THRIFT-3109 Cross test log file cannot be browsed when served in HTTP se... ...rver You can merge this pull request into a Git repository by running: $ git pull https://github.com/nsuke/thrift

[GitHub] thrift pull request: THRIFT-3110 Print error log after cross test ...

2015-04-23 Thread nsuke
GitHub user nsuke opened a pull request: https://github.com/apache/thrift/pull/458 THRIFT-3110 Print error log after cross test failures on Travis You can merge this pull request into a Git repository by running: $ git pull https://github.com/nsuke/thrift THRIFT-3110

[GitHub] thrift pull request: THRIFT-3111 C# library requries .NET 4.5 comp...

2015-04-23 Thread nsuke
GitHub user nsuke opened a pull request: https://github.com/apache/thrift/pull/459 THRIFT-3111 C# library requries .NET 4.5 compatible Mono You can merge this pull request into a Git repository by running: $ git pull https://github.com/nsuke/thrift THRIFT-3111 Alternatively

[GitHub] thrift pull request: THRIFT-3000 .NET implementation has trouble w...

2015-04-23 Thread nsuke
Github user nsuke commented on the pull request: https://github.com/apache/thrift/pull/450#issuecomment-95710395 @Jens-G, can you take a look at #459 before reverting ? As to the Travis-CI failure, I'm aware that "true" CI is the Jenkins but it would be

[GitHub] thrift pull request: THRIFT-3000 .NET implementation has trouble w...

2015-04-24 Thread nsuke
Github user nsuke commented on the pull request: https://github.com/apache/thrift/pull/450#issuecomment-95990799 How about having unified base for testing ? Can we have build scripts **inside** the repository and invoke them from both Jenkins and Travis/Appveyer ? --- If your

[GitHub] thrift pull request: THRIFT-2850 cmake win cpp library and unit te...

2015-04-24 Thread nsuke
Github user nsuke commented on a diff in the pull request: https://github.com/apache/thrift/pull/456#discussion_r29066107 --- Diff: lib/cpp/src/thrift/transport/TSSLSocket.cpp --- @@ -319,7 +319,7 @@ void TSSLSocket::checkHandshake() { return; } ssl_ = ctx_

[GitHub] thrift pull request: THRIFT-3000 .NET implementation has trouble w...

2015-04-24 Thread nsuke
Github user nsuke commented on the pull request: https://github.com/apache/thrift/pull/450#issuecomment-96126819 No, Jenkins not calling cross tests made the difference. In fact, the log shows that Jenkins doesn't even **build** following languages at all (Building

[GitHub] thrift pull request: THRIFT-3109 Cross test log file cannot be bro...

2015-04-26 Thread nsuke
Github user nsuke closed the pull request at: https://github.com/apache/thrift/pull/457 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] thrift pull request: THRIFT-3109 Cross test log file cannot be bro...

2015-04-26 Thread nsuke
Github user nsuke commented on the pull request: https://github.com/apache/thrift/pull/457#issuecomment-96521435 Thanks. (commit: 783660a335aad8818a9ede210e594b7f8677aa56) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] thrift pull request: THRIFT-3111 C# library requries .NET 4.5 comp...

2015-04-26 Thread nsuke
Github user nsuke commented on the pull request: https://github.com/apache/thrift/pull/459#issuecomment-96521545 Closing since we're not going .NET 4.5 yet. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pr

[GitHub] thrift pull request: THRIFT-3111 C# library requries .NET 4.5 comp...

2015-04-26 Thread nsuke
Github user nsuke closed the pull request at: https://github.com/apache/thrift/pull/459 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] thrift pull request: Thrift-3067

2015-04-27 Thread nsuke
Github user nsuke commented on the pull request: https://github.com/apache/thrift/pull/444#issuecomment-96528996 @bufferoverflow Could you revert (undo) part of the commit corresponding to third commit of this pull request ? This (d1aa53086c286bda716b7414eb04042999bb070a

[GitHub] thrift pull request: THRIFT-2835 Add possibility to distribute gen...

2015-05-08 Thread nsuke
Github user nsuke commented on the pull request: https://github.com/apache/thrift/pull/368#issuecomment-100286364 Hi, you're so diligent :) It's quite old so I'll rather rebase it. --- If your project is set up for it, you can reply to this email and have your

[GitHub] thrift pull request: Thrift 3138

2015-05-10 Thread nsuke
GitHub user nsuke opened a pull request: https://github.com/apache/thrift/pull/487 Thrift 3138 You can merge this pull request into a Git repository by running: $ git pull https://github.com/nsuke/thrift THRIFT-3138 Alternatively you can review and apply these changes as the

[GitHub] thrift pull request: Thrift 3138

2015-05-10 Thread nsuke
Github user nsuke commented on the pull request: https://github.com/apache/thrift/pull/487#issuecomment-100665429 That was fast :o Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] thrift pull request: Thrift 3138

2015-05-10 Thread nsuke
Github user nsuke closed the pull request at: https://github.com/apache/thrift/pull/487 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] thrift pull request: THRIFT-3148 Markdown links to coding_standard...

2015-05-13 Thread nsuke
GitHub user nsuke opened a pull request: https://github.com/apache/thrift/pull/491 THRIFT-3148 Markdown links to coding_standards are dead You can merge this pull request into a Git repository by running: $ git pull https://github.com/nsuke/thrift THRIFT-3148 Alternatively

[GitHub] thrift pull request: THRIFT-2835 Add possibility to distribute gen...

2015-05-16 Thread nsuke
Github user nsuke commented on the pull request: https://github.com/apache/thrift/pull/368#issuecomment-102608115 I rebased it to the current master. The original first commit is extracted as THRIFT-3138 (ef0a8fa62a8a86b23999f9a9ad31478852474854) because it was an unrelated issue

[GitHub] thrift pull request: THRIFT-3211: add php client compact protocol ...

2015-06-30 Thread nsuke
Github user nsuke commented on the pull request: https://github.com/apache/thrift/pull/532#issuecomment-117219526 Maybe you want to run ``` test/test.py --update-expected-failures=merge ``` to add them to known failures as documented [here](https://github.com/apache

[GitHub] thrift pull request: Thrift 3265--servers for pipe applications (s...

2015-07-27 Thread nsuke
Github user nsuke commented on a diff in the pull request: https://github.com/apache/thrift/pull/562#discussion_r35533996 --- Diff: lib/java/test/org/apache/thrift/test/JavaBeansTest.java --- @@ -29,33 +29,32 @@ public static void main(String[] args) throws Exception

[GitHub] thrift pull request: THRIFT-3264 Fix Erlang 16 namespaced types

2015-07-28 Thread nsuke
GitHub user nsuke opened a pull request: https://github.com/apache/thrift/pull/566 THRIFT-3264 Fix Erlang 16 namespaced types You can merge this pull request into a Git repository by running: $ git pull https://github.com/nsuke/thrift THRIFT-3264 Alternatively you can review

[GitHub] thrift pull request: THRIFT-3295 C# library does not build on Mono...

2015-08-16 Thread nsuke
GitHub user nsuke opened a pull request: https://github.com/apache/thrift/pull/586 THRIFT-3295 C# library does not build on Mono 4.0.2.5 or later You can merge this pull request into a Git repository by running: $ git pull https://github.com/nsuke/thrift THRIFT-3295

[GitHub] thrift pull request: THRIFT-3296 - Go cross test does not conform ...

2015-08-16 Thread nsuke
GitHub user nsuke opened a pull request: https://github.com/apache/thrift/pull/587 THRIFT-3296 - Go cross test does not conform to spec You can merge this pull request into a Git repository by running: $ git pull https://github.com/nsuke/thrift THRIFT-3296 Alternatively you

[GitHub] thrift pull request: THRIFT-3296 - Go cross test does not conform ...

2015-08-17 Thread nsuke
Github user nsuke closed the pull request at: https://github.com/apache/thrift/pull/587 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] thrift pull request: THRIFT-3296 - Go cross test does not conform ...

2015-08-17 Thread nsuke
Github user nsuke commented on the pull request: https://github.com/apache/thrift/pull/587#issuecomment-131855129 merged as 2fab3deb09e492cbcb2b1e4ed1c1d302787a9abd Thanks @henrique ! --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] thrift pull request: THRIFT-3302 Go JSON protocol should encode Th...

2015-08-23 Thread nsuke
GitHub user nsuke opened a pull request: https://github.com/apache/thrift/pull/591 THRIFT-3302 Go JSON protocol should encode Thrift byte type as signed… … integer string You can merge this pull request into a Git repository by running: $ git pull https://github.com/nsuke

[GitHub] thrift pull request: THRIFT-3303 Disable concurrent cabal jobs on ...

2015-08-23 Thread nsuke
GitHub user nsuke opened a pull request: https://github.com/apache/thrift/pull/592 THRIFT-3303 Disable concurrent cabal jobs on Travis to avoid GHC crush You can merge this pull request into a Git repository by running: $ git pull https://github.com/nsuke/thrift THRIFT-3303

[GitHub] thrift pull request: THRIFT-3303 Disable concurrent cabal jobs on ...

2015-08-23 Thread nsuke
Github user nsuke commented on the pull request: https://github.com/apache/thrift/pull/592#issuecomment-133867457 Although an unrelated cross test case failed, the build in question "all(automake)" succeeded: https://travis-ci.org/apache/thrift/jobs/76861567

[GitHub] thrift pull request: cmake // fixes for std/boost::thread detectio...

2015-09-02 Thread nsuke
Github user nsuke commented on a diff in the pull request: https://github.com/apache/thrift/pull/598#discussion_r38551876 --- Diff: build/cmake/DefineOptions.cmake --- @@ -62,8 +62,10 @@ endif() find_package(OpenSSL QUIET) CMAKE_DEPENDENT_OPTION(WITH_OPENSSL "Build

[GitHub] thrift pull request: cmake // fixes for std/boost::thread detectio...

2015-09-02 Thread nsuke
Github user nsuke commented on a diff in the pull request: https://github.com/apache/thrift/pull/598#discussion_r38552069 --- Diff: lib/cpp/test/qt/CMakeLists.txt --- @@ -18,11 +18,15 @@ # set(CMAKE_AUTOMOC ON) -find_package(Qt5 REQUIRED COMPONENTS Test

[GitHub] thrift pull request: cmake // fixes for std/boost::thread detectio...

2015-09-02 Thread nsuke
Github user nsuke commented on a diff in the pull request: https://github.com/apache/thrift/pull/598#discussion_r38552467 --- Diff: lib/cpp/test/qt/CMakeLists.txt --- @@ -18,11 +18,15 @@ # set(CMAKE_AUTOMOC ON) -find_package(Qt5 REQUIRED COMPONENTS Test

[GitHub] thrift pull request: cmake // fixes for std/boost::thread detectio...

2015-09-02 Thread nsuke
Github user nsuke commented on a diff in the pull request: https://github.com/apache/thrift/pull/598#discussion_r38552677 --- Diff: lib/cpp/test/qt/CMakeLists.txt --- @@ -18,11 +18,15 @@ # set(CMAKE_AUTOMOC ON) -find_package(Qt5 REQUIRED COMPONENTS Test

[GitHub] thrift pull request: cmake // fixes for std/boost::thread detectio...

2015-09-04 Thread nsuke
Github user nsuke commented on a diff in the pull request: https://github.com/apache/thrift/pull/598#discussion_r38807939 --- Diff: build/cmake/DefineOptions.cmake --- @@ -62,8 +62,10 @@ endif() find_package(OpenSSL QUIET) CMAKE_DEPENDENT_OPTION(WITH_OPENSSL "Build

[GitHub] thrift pull request: cmake // fixes for std/boost::thread detectio...

2015-09-04 Thread nsuke
Github user nsuke commented on a diff in the pull request: https://github.com/apache/thrift/pull/598#discussion_r38807967 --- Diff: lib/cpp/test/qt/CMakeLists.txt --- @@ -18,11 +18,15 @@ # set(CMAKE_AUTOMOC ON) -find_package(Qt5 REQUIRED COMPONENTS Test

[GitHub] thrift pull request: cmake // fixes for std/boost::thread detectio...

2015-09-08 Thread nsuke
Github user nsuke commented on the pull request: https://github.com/apache/thrift/pull/598#issuecomment-138574945 @snikulov sorry if there was any misunderstanding but I'm just reviewing as a peer contributor and I have no way to "approve." That said, I believe it&

[GitHub] thrift pull request: THRIFT-3332 make dist fails on clean build

2015-09-19 Thread nsuke
GitHub user nsuke opened a pull request: https://github.com/apache/thrift/pull/609 THRIFT-3332 make dist fails on clean build You can merge this pull request into a Git repository by running: $ git pull https://github.com/nsuke/thrift THRIFT-3332 Alternatively you can review

[GitHub] thrift pull request: THRIFT-3334 Markdown notation of protocol spe...

2015-09-21 Thread nsuke
GitHub user nsuke opened a pull request: https://github.com/apache/thrift/pull/610 THRIFT-3334 Markdown notation of protocol spec is malformed You can merge this pull request into a Git repository by running: $ git pull https://github.com/nsuke/thrift THRIFT-3334

[GitHub] thrift pull request: THRIFT-3337 Add testBool method to cross test...

2015-09-21 Thread nsuke
GitHub user nsuke opened a pull request: https://github.com/apache/thrift/pull/611 THRIFT-3337 Add testBool method to cross tests You can merge this pull request into a Git repository by running: $ git pull https://github.com/nsuke/thrift THRIFT-3337 Alternatively you can

[GitHub] thrift pull request: THRIFT-3335 Ruby server does not handle proce...

2015-09-21 Thread nsuke
GitHub user nsuke opened a pull request: https://github.com/apache/thrift/pull/612 THRIFT-3335 Ruby server does not handle processor You can merge this pull request into a Git repository by running: $ git pull https://github.com/nsuke/thrift THRIFT-3335 Alternatively you can

[GitHub] thrift pull request: THRIFT-3342 Improve ruby cross test client an...

2015-09-21 Thread nsuke
GitHub user nsuke opened a pull request: https://github.com/apache/thrift/pull/615 THRIFT-3342 Improve ruby cross test client and server compatibility You can merge this pull request into a Git repository by running: $ git pull https://github.com/nsuke/thrift THRIFT-3342

[GitHub] thrift pull request: THRIFT-3343 Fix haskell README

2015-09-21 Thread nsuke
GitHub user nsuke opened a pull request: https://github.com/apache/thrift/pull/616 THRIFT-3343 Fix haskell README You can merge this pull request into a Git repository by running: $ git pull https://github.com/nsuke/thrift THRIFT-3343 Alternatively you can review and apply

  1   2   3   4   5   6   >