Author: markt
Date: Wed Sep 12 08:36:42 2018
New Revision: 1840641
URL: http://svn.apache.org/viewvc?rev=1840641=rev
Log:
OpenSSL 1.1.2 appears to have enabled some TLS 1.3 ciphers. Update the tests
for this.
Modified:
https://bz.apache.org/bugzilla/show_bug.cgi?id=62705
--- Comment #2 from Igal Sapir ---
I just built again with Java 1.8.0_181 and Ant 1.10.5 on Fedora 28 with no
issue.
Ant output shows that the --release switch is ignored on a sub-9 Java version:
[javac] Support for javac --release has
On 12/09/18 04:21, Bill Barker wrote:
>[concat] Testsuites with failed tests:
>[concat] TEST-org.apache.tomcat.util.net.openssl.ciphers.TestCipher.NIO.txt
The above failures have now been fixed.
>[concat]
>
Given the regression [1] in 1.2.44 I think we need a 1.2.45 release
soon. My current thinking is to tag late this week / early next with a
view to completing the release by the end of next week so it is complete
before ApacheCon.
In addition to fixing the regression, there has been a general
Author: markt
Date: Wed Sep 12 07:13:03 2018
New Revision: 1840629
URL: http://svn.apache.org/viewvc?rev=1840629=rev
Log:
Tab police
Modified:
tomcat/jk/trunk/native/apache-2.0/mod_jk.c
tomcat/jk/trunk/native/common/jk_util.c
tomcat/jk/trunk/native/common/jk_util.h
Author: markt
Date: Wed Sep 12 08:25:20 2018
New Revision: 1840634
URL: http://svn.apache.org/viewvc?rev=1840634=rev
Log:
OpenSSL master has bumped version number. Need to take account of this in
version detection used in unit tests.
Modified:
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
Mark,
On 9/12/18 7:12 AM, Mark Thomas wrote:
> OpenSSL currently has the following four active development
> branches: Master (a.k.a. 1.1.2-dev) 1.1.1 (LTS supported until at
> least 2018-09-11
A slight correction:
1.1.1 was *initially* released
Author: markt
Date: Wed Sep 12 15:55:56 2018
New Revision: 1840712
URL: http://svn.apache.org/viewvc?rev=1840712=rev
Log:
Update DBCP merge info (no changes)
Modified:
tomcat/trunk/MERGE.txt
Modified: tomcat/trunk/MERGE.txt
URL:
Author: markt
Date: Wed Sep 12 16:03:12 2018
New Revision: 1840716
URL: http://svn.apache.org/viewvc?rev=1840716=rev
Log:
Update DBCP merge info (no changes)
Modified:
tomcat/tc8.5.x/trunk/ (props changed)
tomcat/tc8.5.x/trunk/MERGE.txt
Propchange: tomcat/tc8.5.x/trunk/
Author: markt
Date: Wed Sep 12 15:38:27 2018
New Revision: 1840706
URL: http://svn.apache.org/viewvc?rev=1840706=rev
Log:
Update mergeinfo (no changes)
Modified:
tomcat/trunk/java/org/apache/tomcat/util/bcel/ (props changed)
Propchange: tomcat/trunk/java/org/apache/tomcat/util/bcel/
On 12/09/18 16:47, Christopher Schultz wrote:
> Mark,
>
> On 9/12/18 7:12 AM, Mark Thomas wrote:
>> OpenSSL currently has the following four active development
>> branches: Master (a.k.a. 1.1.2-dev) 1.1.1 (LTS supported until at
>> least 2018-09-11
>
> A slight correction:
>
> 1.1.1 was
https://bz.apache.org/bugzilla/show_bug.cgi?id=62713
Bug ID: 62713
Summary: caching of classes/statics doesn't work
Product: Tomcat 8
Version: 8.5.32
Hardware: PC
Status: NEW
Severity: critical
Priority: P2
Github user akag98 commented on the issue:
https://github.com/apache/tomcat/pull/121
Thanks @isapir for your review.
I will surely look into that.
Thanks :)
---
-
To unsubscribe, e-mail:
Author: markt
Date: Wed Sep 12 16:02:26 2018
New Revision: 1840715
URL: http://svn.apache.org/viewvc?rev=1840715=rev
Log:
Update the internal fork of Apache Commons Pool 2 to d4e0e88 (2018-09-12) to
pick up some clean-up.
Modified:
tomcat/tc8.5.x/trunk/ (props changed)
https://bz.apache.org/bugzilla/show_bug.cgi?id=62674
Mark Thomas changed:
What|Removed |Added
Severity|blocker |major
--- Comment #5 from Mark Thomas
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
Mark,
On 9/12/18 7:12 AM, Mark Thomas wrote:
> All,
>
> Gump currently tests 7.0.x, 8.5.x and 9.0.x
>
> Support for OpenSSL cipher names is available in 8.5.x onwards and
> we have various unit tests to ensure that our parsing code remains
> in
Author: markt
Date: Wed Sep 12 16:01:06 2018
New Revision: 1840713
URL: http://svn.apache.org/viewvc?rev=1840713=rev
Log:
Update merge info (no changes)
Modified:
tomcat/tc8.5.x/trunk/ (props changed)
tomcat/tc8.5.x/trunk/java/org/apache/tomcat/util/bcel/ (props changed)
Github user isapir commented on the issue:
https://github.com/apache/tomcat/pull/121
While I like the idea of adding an easy way to restart, I'd prefer to add a
switch to startup rather than add a new script just for that, e.g. `startup
-restart` or `catalina restart`.
---
On 12/09/18 15:57, Rainer Jung wrote:
> Am 12.09.2018 um 13:12 schrieb Mark Thomas:
>> Gump currently tests 7.0.x, 8.5.x and 9.0.x
>>
>> Support for OpenSSL cipher names is available in 8.5.x onwards and we
>> have various unit tests to ensure that our parsing code remains in sync
>> with OpenSSL.
https://bz.apache.org/bugzilla/show_bug.cgi?id=62712
--- Comment #2 from Mark Thomas ---
It is the APR connector it doesn't like. Neither NIO+JSSE and NIO+OpenSSL
trigger an NPE in this case. It happens in 9.0.x as well. Investigating...
--
You are receiving this mail because:
You are the
https://bz.apache.org/bugzilla/show_bug.cgi?id=62712
--- Comment #1 from Michael Osipov <1983-01...@gmx.net> ---
The same happens for Trusted Certificates.
--
You are receiving this mail because:
You are the assignee for the bug.
Author: markt
Date: Wed Sep 12 15:49:58 2018
New Revision: 1840709
URL: http://svn.apache.org/viewvc?rev=1840709=rev
Log:
Update the internal fork of Apache Commons Pool 2 to d4e0e88 (2018-09-12) to
pick up some clean-up.
Modified:
tomcat/trunk/MERGE.txt
Am 12.09.2018 um 13:12 schrieb Mark Thomas:
Gump currently tests 7.0.x, 8.5.x and 9.0.x
Support for OpenSSL cipher names is available in 8.5.x onwards and we
have various unit tests to ensure that our parsing code remains in sync
with OpenSSL.
All versions have TLS unit tests that check the
Author: markt
Date: Wed Sep 12 15:41:26 2018
New Revision: 1840707
URL: http://svn.apache.org/viewvc?rev=1840707=rev
Log:
Update mergeinfo (no changes)
Modified:
tomcat/trunk/java/org/apache/tomcat/util/codec/ (props changed)
Propchange: tomcat/trunk/java/org/apache/tomcat/util/codec/
Author: markt
Date: Wed Sep 12 19:47:54 2018
New Revision: 1840747
URL: http://svn.apache.org/viewvc?rev=1840747=rev
Log:
Additional fix for BZ 62712
Modified:
tomcat/trunk/java/org/apache/catalina/manager/ManagerServlet.java
Modified:
Author: markt
Date: Wed Sep 12 21:02:46 2018
New Revision: 1840760
URL: http://svn.apache.org/viewvc?rev=1840760=rev
Log:
Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=62676
Expand the CORS filter documentation to make it clear that explicit
configuration is required to enable support for
The Buildbot has detected a new failure on builder tomcat-trunk while building
. Full details are available at:
https://ci.apache.org/builders/tomcat-trunk/builds/3577
Buildbot URL: https://ci.apache.org/
Buildslave for this Build: silvanus_ubuntu
Build Reason: The AnyBranchScheduler
https://bz.apache.org/bugzilla/show_bug.cgi?id=62712
--- Comment #3 from Michael Osipov ---
The same issue applies to the button below the one mentioned. Shall I spawn a
new ticket for that?
--
You are receiving this mail because:
You are the assignee for the bug.
Author: markt
Date: Wed Sep 12 21:02:16 2018
New Revision: 1840759
URL: http://svn.apache.org/viewvc?rev=1840759=rev
Log:
Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=62676
Expand the CORS filter documentation to make it clear that explicit
configuration is required to enable support for
Author: markt
Date: Wed Sep 12 18:50:23 2018
New Revision: 1840738
URL: http://svn.apache.org/viewvc?rev=1840738=rev
Log:
Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=62712
Correct NPE in Manager application when attempting to view configured
certificates for an APR/native TLS connector.
Author: markt
Date: Wed Sep 12 18:49:31 2018
New Revision: 1840737
URL: http://svn.apache.org/viewvc?rev=1840737=rev
Log:
Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=62712
Correct NPE in Manager application when attempting to view configured
certificates for an APR/native TLS connector.
Author: markt
Date: Wed Sep 12 19:48:31 2018
New Revision: 1840748
URL: http://svn.apache.org/viewvc?rev=1840748=rev
Log:
Additional fix for BZ 62712
Modified:
tomcat/tc8.5.x/trunk/ (props changed)
tomcat/tc8.5.x/trunk/java/org/apache/catalina/manager/ManagerServlet.java
Propchange:
https://bz.apache.org/bugzilla/show_bug.cgi?id=62712
Mark Thomas changed:
What|Removed |Added
Resolution|--- |FIXED
Status|NEW
-Dexecute.test.nio=false
-Dtest.openssl.path=/srv/gump/public/workspace/openssl-1.0.2/dest-20180912/bin/openssl
-Dexec
ute.test.bio=true -Dexecute.test.apr=false -Dtest.excludePerformance=true
-Deasymock.jar=/srv/gump/public/workspace/easymock/core/target/easymock-3.7-SNAPSHOT.jar
-Dhamcrest.jar
The Buildbot has detected a restored build on builder tomcat-trunk while
building . Full details are available at:
https://ci.apache.org/builders/tomcat-trunk/builds/3578
Buildbot URL: https://ci.apache.org/
Buildslave for this Build: silvanus_ubuntu
Build Reason: The AnyBranchScheduler
Am 2018-09-11 um 23:53 schrieb Christopher Schultz:
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
Michael,
On 9/11/18 3:33 PM, Michael Osipov wrote:
in bug 62670 [1] -- contrary to my statement -- Mark pointed out
that is it pefectly legal to have a JDBC driver in WEB-INF/lib.
While I was
https://bz.apache.org/bugzilla/show_bug.cgi?id=62712
--- Comment #4 from Mark Thomas ---
No need. I'll have it patched shortly.
--
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe,
-Dexecute.test.nio=true
-Dtest.openssl.path=/srv/gump/public/workspace/openssl-1.0.2/dest-20180912/bin/openssl
-Dexecu
te.test.bio=false -Dexecute.test.apr=false -Dtest.excludePerformance=true
-Deasymock.jar=/srv/gump/public/workspace/easymock/core/target/easymock-3.7-SNAPSHOT.jar
-Dhamcrest.jar
.x/tomcat-build-libs
-Djdt.jar=/srv/gump/packages/eclipse/plugins/R-4.7.3a-201803300640/ecj-4.7.3a.jar
-Dtest.apr.loc=/srv/gump/public/workspace/tomcat-native-12/dest-20180912/lib
-Dtest.relaxTiming=true
-Dcommons-daemon.jar=/srv/gump/public/workspace/apache-commons/daemon/target/commons-daemon
https://bz.apache.org/bugzilla/show_bug.cgi?id=62712
--- Comment #6 from Michael Osipov ---
(In reply to Mark Thomas from comment #5)
> Thanks for the report.
>
> Fixed in:
> - trunk for 9.0.13 onwards
> - 8.5.x for 8.5.35 onwards
Charming, thanks!
--
You are receiving this mail because:
You
https://bz.apache.org/bugzilla/show_bug.cgi?id=62713
Mark Thomas changed:
What|Removed |Added
OS||All
Resolution|---
-Dtest.accesslog=true
-Dexecute.test.nio=false
-Dtest.openssl.path=/srv/gump/public/workspace/openssl-1.0.2/dest-20180912/bin/openssl
-Dexe
cute.test.bio=false -Dexecute.test.apr=false -Dtest.excludePerformance=true
-Deasymock.jar=/srv/gump/public/workspace/easymock/core/target/easymock-3.7-SNAPSHOT.jar
Author: markt
Date: Wed Sep 12 21:04:24 2018
New Revision: 1840761
URL: http://svn.apache.org/viewvc?rev=1840761=rev
Log:
Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=62676
Expand the CORS filter documentation to make it clear that explicit
configuration is required to enable support for
Author: markt
Date: Wed Sep 12 22:08:04 2018
New Revision: 1840767
URL: http://svn.apache.org/viewvc?rev=1840767=rev
Log:
Reduce unit test run time by ~20%
Modified:
tomcat/tc7.0.x/trunk/ (props changed)
tomcat/tc7.0.x/trunk/java/org/apache/tomcat/util/net/AbstractEndpoint.java
Author: markt
Date: Wed Sep 12 22:07:34 2018
New Revision: 1840766
URL: http://svn.apache.org/viewvc?rev=1840766=rev
Log:
Minor performance tweak.
Don't create an Exception (with an expensive to populate stack trace) unless we
have to.
Modified:
tomcat/tc8.5.x/trunk/ (props changed)
Author: markt
Date: Wed Sep 12 22:07:10 2018
New Revision: 1840765
URL: http://svn.apache.org/viewvc?rev=1840765=rev
Log:
Reduce unit test run time by ~20%
Modified:
tomcat/tc8.5.x/trunk/ (props changed)
tomcat/tc8.5.x/trunk/java/org/apache/tomcat/util/net/AbstractEndpoint.java
https://bz.apache.org/bugzilla/show_bug.cgi?id=62676
Mark Thomas changed:
What|Removed |Added
Resolution|--- |FIXED
OS|
https://bz.apache.org/bugzilla/show_bug.cgi?id=62674
--- Comment #6 from Paul ---
Created attachment 36147
--> https://bz.apache.org/bugzilla/attachment.cgi?id=36147=edit
output of 'strace ant'
--
You are receiving this mail because:
You are the assignee for the bug.
https://bz.apache.org/bugzilla/show_bug.cgi?id=62705
--- Comment #4 from Brett Sutton ---
apologies, looks like ti was a path issue.
I've re-ran the code and yes it does compile with ant 1.10.5 and jdk 8.
So closing this one out.
--
You are receiving this mail because:
You are the assignee
On 12/09/18 17:25, Christopher Schultz wrote:
> Mark,
> On 9/12/18 7:12 AM, Mark Thomas wrote:
>> Testing all 12 combinations (4 OpenSSL * 3 Tomcat) seems like
>> overkill.
>
> I would propose building+testing against both 1.0.2 (LTS) and 1.1.1
> (LTS) but leaving 1.1.0 and master out of the
Author: markt
Date: Wed Sep 12 22:08:20 2018
New Revision: 1840768
URL: http://svn.apache.org/viewvc?rev=1840768=rev
Log:
Minor performance tweak.
Don't create an Exception (with an expensive to populate stack trace) unless we
have to.
Modified:
tomcat/tc7.0.x/trunk/ (props changed)
On 12/09/18 22:20, Mark Thomas wrote:
> I tend to lean more
> towards trying to speed up start/stop as a way to reduce the test time
> as we do that so many times.
With this in mind and with the help of YourKit's Java Profiler I bring
you a 20% reduce in unit test run time :)
I'm still
Author: markt
Date: Wed Sep 12 22:05:50 2018
New Revision: 1840763
URL: http://svn.apache.org/viewvc?rev=1840763=rev
Log:
Reduce unit test run time by ~20%
Modified:
tomcat/trunk/java/org/apache/tomcat/util/net/AbstractEndpoint.java
Modified:
Author: markt
Date: Wed Sep 12 22:06:42 2018
New Revision: 1840764
URL: http://svn.apache.org/viewvc?rev=1840764=rev
Log:
Minor performance tweak.
Don't create an Exception (with an expensive to populate stack trace) unless we
have to.
Modified:
https://bz.apache.org/bugzilla/show_bug.cgi?id=62674
--- Comment #7 from Paul ---
Created attachment 36148
--> https://bz.apache.org/bugzilla/attachment.cgi?id=36148=edit
output of 'ant -d'
--
You are receiving this mail because:
You are the assignee for the bug.
Github user kkolinko commented on the issue:
https://github.com/apache/tomcat/pull/121
1. This does not conform to code style. The "echo off" command and license
header are missing.
2. This approach is naive and does not work. The "shutdown.bat" script does
not stop Tomcat! It
To whom it may engage...
This is an automated request, but not an unsolicited one. For
more information please visit http://gump.apache.org/nagged.html,
and/or contact the folk at gene...@gump.apache.org.
Project tomcat-tc8.5.x-test-nio has an issue affecting its community
To whom it may engage...
This is an automated request, but not an unsolicited one. For
more information please visit http://gump.apache.org/nagged.html,
and/or contact the folk at gene...@gump.apache.org.
Project tomcat-tc8.5.x-test-nio2 has an issue affecting its community
https://bz.apache.org/bugzilla/show_bug.cgi?id=62705
Brett Sutton changed:
What|Removed |Added
Status|RESOLVED|CLOSED
--- Comment #5 from Brett
To whom it may engage...
This is an automated request, but not an unsolicited one. For
more information please visit http://gump.apache.org/nagged.html,
and/or contact the folk at gene...@gump.apache.org.
Project tomcat-tc8.5.x-test-apr has an issue affecting its community
All,
Gump currently tests 7.0.x, 8.5.x and 9.0.x
Support for OpenSSL cipher names is available in 8.5.x onwards and we
have various unit tests to ensure that our parsing code remains in sync
with OpenSSL.
All versions have TLS unit tests that check the APR/Native connector is
working as
https://bz.apache.org/bugzilla/show_bug.cgi?id=62708
Bug ID: 62708
Summary: date of *_jsp.java and *_jsp.class always 1.1.1970
Product: Tomcat 8
Version: 8.5.14
Hardware: PC
OS: Linux
Status: NEW
https://bz.apache.org/bugzilla/show_bug.cgi?id=62709
Bug ID: 62709
Summary: out.write got inefficient with respect to newline in
*_jsp.java
Product: Tomcat 8
Version: 8.5.14
Hardware: All
OS: Linux
Author: markt
Date: Wed Sep 12 14:15:50 2018
New Revision: 1840690
URL: http://svn.apache.org/viewvc?rev=1840690=rev
Log:
Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=62685
Correct an error in host name validation parsing that did not allow a fully
qualified domain name to terminate with a
The Buildbot has detected a restored build on builder tomcat-trunk while
building . Full details are available at:
https://ci.apache.org/builders/tomcat-trunk/builds/3574
Buildbot URL: https://ci.apache.org/
Buildslave for this Build: silvanus_ubuntu
Build Reason: The AnyBranchScheduler
GitHub user akag98 opened a pull request:
https://github.com/apache/tomcat/pull/121
restart.bat
Bat file that calls shutdown.bat and then startup.bat to restart the server.
You can merge this pull request into a Git repository by running:
$ git pull
Author: markt
Date: Wed Sep 12 14:18:04 2018
New Revision: 1840691
URL: http://svn.apache.org/viewvc?rev=1840691=rev
Log:
Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=62685
Correct an error in host name validation parsing that did not allow a fully
qualified domain name to terminate with a
https://bz.apache.org/bugzilla/show_bug.cgi?id=62685
Mark Thomas changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|---
https://bz.apache.org/bugzilla/show_bug.cgi?id=62709
Ralf Hauser changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|---
https://bz.apache.org/bugzilla/show_bug.cgi?id=62696
Mark Thomas changed:
What|Removed |Added
Severity|normal |enhancement
--- Comment #5 from Mark
Author: markt
Date: Wed Sep 12 13:15:43 2018
New Revision: 1840681
URL: http://svn.apache.org/viewvc?rev=1840681=rev
Log:
Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=62685
Correct an error in host name validation parsing that did not allow a fully
qualified domain name to terminate with a
Author: remm
Date: Wed Sep 12 12:59:40 2018
New Revision: 1840674
URL: http://svn.apache.org/viewvc?rev=1840674=rev
Log:
Port single DBCP commit d49d45e.
Modified:
tomcat/trunk/java/org/apache/tomcat/dbcp/dbcp2/managed/BasicManagedDataSource.java
tomcat/trunk/webapps/docs/changelog.xml
https://bz.apache.org/bugzilla/show_bug.cgi?id=62708
Mark Thomas changed:
What|Removed |Added
Resolution|--- |WONTFIX
Status|NEW
The Buildbot has detected a new failure on builder tomcat-trunk while building
. Full details are available at:
https://ci.apache.org/builders/tomcat-trunk/builds/3573
Buildbot URL: https://ci.apache.org/
Buildslave for this Build: silvanus_ubuntu
Build Reason: The AnyBranchScheduler
Author: markt
Date: Wed Sep 12 10:28:32 2018
New Revision: 1840653
URL: http://svn.apache.org/viewvc?rev=1840653=rev
Log:
Better fix for OpenSSL 1.1.2
Add a comment to increase the chances of the right fix next time there is an
OpenSSL version bump
Modified:
Hi,
While looking at the OpenSSL builds on Gump, I noticed that Gmp was
building 8.0.x but not 8.5.x. I've just switched it. Hopefully it will
'just work'.
Mark
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For
Author: markt
Date: Wed Sep 12 10:42:22 2018
New Revision: 1840655
URL: http://svn.apache.org/viewvc?rev=1840655=rev
Log:
Update OpenSSL support dates
Remove 1.0.1 related code as it is no longer supported.
Modified:
Author: markt
Date: Wed Sep 12 10:46:23 2018
New Revision: 1840656
URL: http://svn.apache.org/viewvc?rev=1840656=rev
Log:
OpenSSL master has bumped version number. Need to take account of this in
version detection used in unit tests.
1.0.1 is no longer supported.
Modified:
https://bz.apache.org/bugzilla/show_bug.cgi?id=62705
Konstantin Kolinko changed:
What|Removed |Added
Resolution|--- |WORKSFORME
https://bz.apache.org/bugzilla/show_bug.cgi?id=62712
Bug ID: 62712
Summary: NPE in Manager TLS connector configuration
diagnostics/Certificates
Product: Tomcat 8
Version: 8.5.34
Hardware: HP
OS: HP-UX
80 matches
Mail list logo
