Re: extreemly simple request to add process name variable to catalina.out

2011-07-07 Thread Christopher Schultz
Lance, On 7/7/2011 12:03 PM, Campbell, Lance wrote: Tomcat 6 enhancement: Please consider giving us the ability to change the process name for linux applications. I have identified all of the places I believe this needs to be done. Would you please consider adding the following to the

Using reflection to call tcnative methods

2011-07-08 Thread Christopher Schultz
All, I've been working in AprLifecycleListener to add FIPS support. I need to make an additional native method call in initializeSSL and I'm wondering why all of the native methods are called using reflection instead of direct method calls. The SSL class, for instance, and the

Re: Using reflection to call tcnative methods

2011-07-09 Thread Christopher Schultz
Mladen, On 7/8/2011 11:44 PM, Mladen Turk wrote: On 07/09/2011 04:14 AM, Christopher Schultz wrote: All, I've been working in AprLifecycleListener to add FIPS support. I need to make an additional native method call in initializeSSL and I'm wondering why all of the native methods are called

Re: Distributable contexts and non-serializable session attributes

2011-07-11 Thread Christopher Schultz
Rainer, On 7/10/2011 3:38 PM, Rainer Jung wrote: Unfortunately I stumbled into some code in StandardSession: public void setAttribute(String name, Object value, boolean notify) { ... if ((manager != null) manager.getDistributable() !(value instanceof Serializable)) throw new

Re: [SECURITY] CVE-2011-2526 Apache Tomcat Information disclosure and availability vulnerabilities

2011-07-13 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 All, Great catch to all who were involved in discovery and mitigation of this vulnerability. Since the APR flavor of this vulnerability uses native code to crash the JVM and/or read files without asking the SecurityManager for permission, does that

Casual proposal for change to WebappClassLoader.clearReferencesThreads

2011-07-14 Thread Christopher Schultz
All, Is there any interest in having a configuration option for WCL that allows certain thread names to be ignored during webapp shutdown? See http://markmail.org/message/vqeeyosbqxq3tim6 for a short discussion. It appears that there may sometimes be a race condition where the webapp can't

Re: Casual proposal for change to WebappClassLoader.clearReferencesThreads

2011-07-14 Thread Christopher Schultz
Pid, On 7/14/2011 11:25 AM, Pid wrote: On 14/07/2011 16:11, Pid wrote: On 14/07/2011 15:23, Christopher Schultz wrote: All, Is there any interest in having a configuration option for WCL that allows certain thread names to be ignored during webapp shutdown? See http://markmail.org/message

Re: tagging tc-native 1.1.21

2011-07-25 Thread Christopher Schultz
Jean-Frederic, On 7/25/2011 6:06 AM, jean-frederic clere wrote: On 07/25/2011 11:21 AM, Henri Gomez wrote: nope, let's go for release. BTW, what's the main changes ? Just bug fixes. I will update the changelog now. Nope, it also includes the native part of FIPS mode. I forgot to update

Re: tagging tc-native 1.1.21

2011-08-01 Thread Christopher Schultz
Mladen, On 7/25/2011 3:16 PM, Mladen Turk wrote: On 07/25/2011 07:31 PM, Christopher Schultz wrote: Jean-Frederic, Nope, it also includes the native part of FIPS mode. I forgot to update the changelog when I did that commit. Now updated. Note that the new FIPS code isn't called

Re: Servlet 3.1, Tomcat 8 etc.

2011-08-01 Thread Christopher Schultz
Mark, On 7/26/2011 1:30 PM, Mark Thomas wrote: The Servlet EG is starting to discuss changes to the Servlet API for 3.1. It would be useful if the option existed to implement some of these changes in Tomcat trunk. The benefits of this are: - we can see how feasible the API changes are to

Re: Servlet 3.1, Tomcat 8 etc.

2011-08-01 Thread Christopher Schultz
Mark, On 8/1/2011 2:58 PM, Mark Thomas wrote: On 01/08/2011 19:32, Christopher Schultz wrote: Mark, On 8/1/2011 12:05 PM, Mark Thomas wrote: On 01/08/2011 16:45, Christopher Schultz wrote: Mark, On 7/26/2011 1:30 PM, Mark Thomas wrote: The Servlet EG is starting to discuss changes

Re: tagging tc-native 1.1.21

2011-08-08 Thread Christopher Schultz
Rainer and Mladen, On 8/1/2011 4:52 PM, Mladen Turk wrote: On 08/01/2011 09:23 PM, Rainer Jung wrote: On 01.08.2011 16:50, Christopher Schultz wrote: Oh, I didn't realize that the trunk wasn't the tip of the 1.1 branch. AFAIK tcnative 1.1.x is still CTR. Yep CTR, the split was made

Re: ServletRequestListener.requestDestroyed is called before request leaves a webapp

2011-08-10 Thread Christopher Schultz
Mark, On 8/9/2011 4:35 PM, Mark Thomas wrote: Addressing this would mean either: a) moving the error handling to the context (inside the calls to the ServletRequestListener) or +1 This just feels like the right state management level to me. Certainly the default error handler can be called

Re: svn commit: r1157151 - in /tomcat/trunk/java/org/apache/coyote/http11: AbstractInputBuffer.java InternalInputBuffer.java

2011-08-12 Thread Christopher Schultz
Mark, On 8/12/2011 11:17 AM, ma...@apache.org wrote: +@Override +public void recycle() { +super.recycle(); +inputStream = null; +} If inputStream != null, should it be close()d? Or is this a shared reference for which that kind of thing isn't appropriate? Or do

Re: svn commit: r1159673 - in /tomcat/tc7.0.x/trunk: java/org/apache/catalina/core/JreMemoryLeakPreventionListener.java webapps/docs/changelog.xml webapps/docs/config/listeners.xml

2011-08-19 Thread Christopher Schultz
Konstantin, On 8/19/2011 12:34 PM, Konstantin Kolinko wrote: 2011/8/19 schu...@apache.org: +private boolean awtThreadProtection = false; +public boolean isAWTThreadProtection() { return awtThreadProtection; } +public void setAWTThreadProtection(boolean awtThreadProtection) { +

Re: svn commit: r1159673 - in /tomcat/tc7.0.x/trunk: java/org/apache/catalina/core/JreMemoryLeakPreventionListener.java webapps/docs/changelog.xml webapps/docs/config/listeners.xml

2011-08-20 Thread Christopher Schultz
Konstantin, On 8/19/2011 3:11 PM, Konstantin Kolinko wrote: Mark cleared the changelog file after creating the branch. The idea is that * work is done on trunk * it is merged to tc7.0.x * items merged to tc7.0.x go into TC7's changelog file and those that won't be merged go into TC8's

Re: / on end of context paths breaking existing apps

2011-08-22 Thread Christopher Schultz
Tim, On 8/21/2011 5:49 PM, Tim Whittington wrote: The change in [1] has broken existing behaviour in some applications. To echo some of Mark's comments: Consider the following situation: - An application is context path /application - The application has a servlet mapped to /* So, the only

Re: svn commit: r1159673 - in /tomcat/tc7.0.x/trunk: java/org/apache/catalina/core/JreMemoryLeakPreventionListener.java webapps/docs/changelog.xml webapps/docs/config/listeners.xml

2011-08-23 Thread Christopher Schultz
Mark, On 8/23/2011 3:53 PM, Mark Thomas wrote: On 21/08/2011 01:44, Christopher Schultz wrote: Konstantin, On 8/19/2011 3:11 PM, Konstantin Kolinko wrote: Mark cleared the changelog file after creating the branch. The idea is that * work is done on trunk * it is merged to tc7.0.x * items

Re: DO NOT REPLY [Bug 51580] Severe error deploying WAR application (ExpandWar error)

2011-08-25 Thread Christopher Schultz
Konstantin, On 8/25/2011 10:08 AM, Konstantin Kolinko wrote: 1. You have a typo in LC_CTYPE command above, s/8851/8859/ Thanks, I'll check that. 2. It might be that it reads the characters correctly, but fails to print them. If it were reading UTF-8 characters as ISO-8859-1, wouldn't

Re: svn commit: r1161566 - in /tomcat/tc6.0.x/trunk: STATUS.txt java/org/apache/catalina/core/JreMemoryLeakPreventionListener.java webapps/docs/config/listeners.xml

2011-08-25 Thread Christopher Schultz
Konstantin, On 8/25/2011 10:14 AM, Konstantin Kolinko wrote: Documentation part of this commit is wrong. You added attribute to a wrong listener. (rmiServerPortPlatform ...) Ugh. Thanks for the catch. Fixed. -chris signature.asc Description: OpenPGP digital signature

Re: svn commit: r1161601 - /tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml

2011-08-25 Thread Christopher Schultz
Konstantin, On 8/25/2011 11:18 AM, kkoli...@apache.org wrote: Add changelog record for r1161566 Thanks for cleaning-up after me. I spent a bunch of time this morning trying to forward-port my fix before I realized that it had already been done. Patch isn't smart enough to say duh, that change

Re: Possible bug in Tomcat Date header handling

2011-08-26 Thread Christopher Schultz
Mark and Mick, On 8/26/2011 11:45 AM, Mark Thomas wrote: The fix is to address the root cause which appears to be a poorly configured system clock. I am loath to add a work-around at any point in the Tomcat source code to handle time apparently going backwards rather than forwards. +1 This

Mitigating AJP CPing/Forward-Request packet forgery before next releases

2011-09-08 Thread Christopher Schultz
All, https://issues.apache.org/bugzilla/show_bug.cgi?id=51698 Mark's official report to the users' list indicates that setting a secret for the AJP connection does the trick. (I tried this myself before digging-up his message and can confirm that the sample code fails when a secret is set).

Re: Mitigating AJP CPing/Forward-Request packet forgery before next releases

2011-09-08 Thread Christopher Schultz
Mark, On 9/8/2011 11:47 AM, Mark Thomas wrote: On 08/09/2011 16:13, Christopher Schultz wrote: All, https://issues.apache.org/bugzilla/show_bug.cgi?id=51698 Mark's official report to the users' list indicates that setting a secret for the AJP connection does the trick. (I tried this myself

Re: Mitigating AJP CPing/Forward-Request packet forgery before next releases

2011-09-08 Thread Christopher Schultz
Mark, On 9/8/2011 11:47 AM, Mark Thomas wrote: On 08/09/2011 16:13, Christopher Schultz wrote: Should we mention this on the Security page directly for those who didn't read the announcement on the users' list? No reason why not. Go for it. Also, security-5.html says that Tomcat 5.0.0

Re: Mitigating AJP CPing/Forward-Request packet forgery before next releases

2011-09-09 Thread Christopher Schultz
JF, On 9/9/2011 7:02 AM, jean-frederic clere wrote: Yep. We need a directive to set the secret in httpd, I will discuss that in httpd dev list. Thanks for the confirmation. -chris signature.asc Description: OpenPGP digital signature

Re: [VOTE] Release Apache Tomcat 7.0.22

2011-09-28 Thread Christopher Schultz
Mark, On 9/27/2011 5:36 PM, Mark Thomas wrote: The proposed Apache Tomcat 7.0.22 release is now available for voting. It can be obtained from: http://people.apache.org/~markt/dev/tomcat-7/v7.0.22/ The svn tag is: http://svn.apache.org/repos/asf/tomcat/tc7.0.x/tags/TOMCAT_7_0_22/ The

Re: [VOTE] Release Apache Tomcat 7.0.22

2011-09-29 Thread Christopher Schultz
Mark, On 9/29/2011 8:09 AM, Mark Thomas wrote: On 28/09/2011 14:43, Christopher Schultz wrote: Mark, On 9/27/2011 5:36 PM, Mark Thomas wrote: The proposed Apache Tomcat 7.0.22 release is now available for voting. It can be obtained from: http://people.apache.org/~markt/dev/tomcat-7

Release Testing

2011-10-04 Thread Christopher Schultz
All, I was thinking about the tests that various folks (Konstantin, Mladen, Rainer, etc.) perform and I was wondering if it might be a good idea for everyone to share their techniques for testing that could be automated. For example, contributing some scripts, etc. to a meta-test framework for

Re: Make the InetAddress object available via ServletRequest?

2011-10-10 Thread Christopher Schultz
Francis, On 10/9/2011 10:57 AM, Francis Galiegue wrote: I have my CIDR matching valve/filter ready (still struggling to write unit tests, but it works in real-world situations), and there is something I find quite unoptimized: you have getRemoteHost() and getRemoteAddr() to get the remote

Re: ApacheMeetupsNa11 tomcat one?

2011-10-11 Thread Christopher Schultz
Jean-Frederic, On 10/11/2011 4:04 AM, jean-frederic clere wrote: Do we want to organize a Tomcat meetup during the ApacheCon? +1 I'll be there. Though the content last year was rather thin, it was nice to meet Keiichi there. I'd be happy to have a meet-up at Whistler (local ski resort), too,

Write access to LocalBadContent (and other?) page(s) on wiki

2011-10-12 Thread Christopher Schultz
All, I removed some spam from a wiki page and I was going to update LocalBadContent with the URLs added to that page as spam (see below), but it doesn't look like I have such access rights. Can I get promoted? My userid is ChristopherSchultz. Thanks, -chris Spam URLs: http://www.buchete.ro

Re: ApacheMeetupsNa11 tomcat one?

2011-10-20 Thread Christopher Schultz
All, On 10/19/2011 3:52 PM, Rainer Jung wrote: On 18.10.2011 10:15, Keiichi Fujino wrote: I am going to stay in Vancouver from Monday to Friday. I'll be there too, including the weekends before and after. I'm arriving at 12:47 local time on Tuesday and I've got nothing to do until the next

Re: ApacheMeetupsNa11 tomcat one?

2011-10-21 Thread Christopher Schultz
All, On 10/20/2011 4:32 PM, Christopher Schultz wrote: I'm arriving at 12:47 local time on Tuesday and I've got nothing to do until the next morning besides check-into the hotel. If anyone is interested in getting together for some drinks or exploring the city (I've never been to Vancouver

Re: svn commit: r1187916 - in /tomcat/jk/trunk: native/iis/jk_isapi_plugin.c xdocs/miscellaneous/changelog.xml

2011-10-25 Thread Christopher Schultz
Rainer, On 10/23/2011 12:19 PM, rj...@apache.org wrote: +/* + * Find the first occurrence of path in uri tokenized by /. + * The comparison is done case insensitive. + */ +static const char *find_path_in_uri(const char *uri, const char *path) +{ +size_t len = strlen(path); +while

Re: svn commit: r1187916 - in /tomcat/jk/trunk: native/iis/jk_isapi_plugin.c xdocs/miscellaneous/changelog.xml

2011-10-25 Thread Christopher Schultz
Rainer, On 10/23/2011 12:19 PM, rj...@apache.org wrote: +static const char *find_path_in_uri(const char *uri, const char *path) +{ +size_t len = strlen(path); +while (uri = strchr(uri, '/')) { +uri++; +if (!strncmp(uri, path, len) +(*(uri + len) == '/'

Re: svn commit: r1187916 - in /tomcat/jk/trunk: native/iis/jk_isapi_plugin.c xdocs/miscellaneous/changelog.xml

2011-10-25 Thread Christopher Schultz
All, On 10/25/2011 2:03 PM, Christopher Schultz wrote: On 10/23/2011 12:19 PM, rj...@apache.org wrote: +if (!strncmp(uri, path, len) strncmp doesn't use case-insensitive compare: will this ever match if you use web-inf (as below)? Duh just saw Konstantin's response. Apologies

Re: svn commit: r1187916 - in /tomcat/jk/trunk: native/iis/jk_isapi_plugin.c xdocs/miscellaneous/changelog.xml

2011-10-25 Thread Christopher Schultz
Rainer, On 10/25/2011 3:37 PM, Rainer Jung wrote: On 25.10.2011 20:07, Christopher Schultz wrote: Rainer, On 10/23/2011 12:19 PM, rj...@apache.org wrote: +static const char *find_path_in_uri(const char *uri, const char *path) +{ +size_t len = strlen(path); +while (uri = strchr(uri

Tomcat 7, Valve - Filter conversion, and container-managed authentication/authorization

2010-04-28 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 All, Hello, I'm Chris Schultz, the maintainer of the securityfilter project (http://securityfilter.sourceforge.net/) and active member of the tomcat-user mailing list. I've been loosely following the plans for Tomcat 7 and was interested to see that

Re: Tomcat 7, Valve - Filter conversion, and container-managed authentication/authorization

2010-04-29 Thread Christopher Schultz
David, On 4/28/2010 6:40 PM, David Jencks wrote: I'd be curious how many of the features in securityfilter can be done with servlet 3 (which includes the ability for an app to programatically force a login) and jaspic (jsr 196) which provides for pluggable authentication dialogs between

Re: Some general questions about tomcat instead of GlassFish

2010-06-14 Thread Christopher Schultz
Pouya, On 6/12/2010 12:14 PM, j jj wrote: Please use a semi-legitimate name when posting to the list: this should be easy to configure in your email reader. Also, there's no need to put underscores_between_your_words_in_the_subject, as this is not some kind of wiki. Would you please

Re: ThreadLocal Clear References Problem

2011-01-06 Thread Christopher Schultz
Gurkan, On 1/6/2011 7:08 AM, Gurkan Erdogdu wrote: Could you see the problem in https://issues.apache.org/jira/browse/MYFACES-3006? So, you are stopping a second application from the code shown in the bug? Can you post a working example? -chris signature.asc Description: OpenPGP digital

Re: ASF test Jira instance now running Tomcat 7.0.6

2011-01-11 Thread Christopher Schultz
Mark, On 1/10/2011 1:02 PM, Mark Thomas wrote: Having tagged and built 7.0.6 I have just switched the ASF test Jira instance [1] from 6.0.29 to 7.0.6. A quick smoke test suggests all is OK. Folks will be testing this instance over the next few weeks prior to the migration of the live Jira

Re: Deploying new Applications

2011-01-13 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Jamie, Technically speaking, this is a discussion best left to the user list. I'm cross-posting. Please consider subscribing to the user list and continuing the discussion there. On 1/13/2011 7:27 AM, Jamie wrote: This works, but is not persistent.

Re: Access log changes in 7.0.6

2011-01-14 Thread Christopher Schultz
Mark, On 1/14/2011 9:40 AM, Mark Thomas wrote: c) Refactor the access logging. I don't have a clear picture of what this might look like but I am thinking along the lines of: - log to JULI rather than manage files in the access log -1 I think access logging is something where all

Tomcat 7.0.x. still CTR?

2011-01-18 Thread Christopher Schultz
All, Since Tomcat 7.0.x went stable, does that change the commit policy, or are we still doing commit-them-review? Thanks, -chris signature.asc Description: OpenPGP digital signature

Current TC 7.0.x/trunk fails to build release

2011-01-21 Thread Christopher Schultz
All, $ svn up At revision 1061823. $ ant release [] logkit-warning: [echo] [echo] *** WARNING *** [echo] LogKit not found: Cannot Build LogKitLogger [echo] jdk1.4-warning: avalon-framework-warning: [echo] [echo] *** WARNING *** [echo]

Re: Current TC 7.0.x/trunk fails to build release

2011-01-21 Thread Christopher Schultz
Konstantin, On 1/21/2011 9:47 AM, Konstantin Kolinko wrote: 2011/1/21 Christopher Schultz ch...@christopherschultz.net: $ ant release What is your ant version? 1.8.x is needed. $ ant -version Apache Ant version 1.8.1 compiled on April 30 2010 Buildbot runs ant release repeatedly

Re: bug in TC6 ContainerBase class?

2011-01-21 Thread Christopher Schultz
Chuck, On 1/21/2011 10:02 AM, Caldarale, Charles R wrote: From: sebb [mailto:seb...@gmail.com] Subject: Re: bug in TC6 ContainerBase class? There is no requirement for the compiler to reload variables unless the variable is volatile, or there is a shared lock between threads. Correct -

Proposal: set default for Connector.allowCasualMultipartParsing to true

2011-01-21 Thread Christopher Schultz
All, I've just committed a fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=49711 (HttpServletRequest#getParts() does not work in a Filter) with a new configuration attribute on the Connector called allowCasualMultipartParsing whose default value is false. Please see BZ for details. I

Privileges in Bugzilla

2011-01-21 Thread Christopher Schultz
All, I typically use my home email address instead of my @apache.org for everything, including BZ. I don't currently have rights to do things like assign bugs to myself, etc. Can that be done? Or, should I start using my @apache.org email address to do that sort of thing? Thanks, -chris

Re: svn commit: r1061929 - in /tomcat/trunk: java/org/apache/catalina/ant/ java/org/apache/catalina/connector/ java/org/apache/tomcat/util/net/ test/org/apache/catalina/connector/ webapps/docs/ webapp

2011-01-21 Thread Christopher Schultz
All, Oops. I over-committed files. Evidently, svn commit doesn't work like cvs commit. I'll back-out my changes to: tomcat/trunk/java/org/apache/catalina/ant/AbstractCatalinaTask.java tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java Sorry for the noise. Thanks, -chris On

Re: Privileges in Bugzilla

2011-01-21 Thread Christopher Schultz
Mark, On 1/21/2011 1:02 PM, Mark Thomas wrote: On 21/01/2011 17:53, Christopher Schultz wrote: All, I typically use my home email address instead of my @apache.org for everything, including BZ. I don't currently have rights to do things like assign bugs to myself, etc. Can that be done

Re: Proposal: set default for Connector.allowCasualMultipartParsing to true

2011-01-21 Thread Christopher Schultz
Konstantin, On 1/21/2011 12:57 PM, Konstantin Kolinko wrote: 2011/1/21 Christopher Schultz ch...@christopherschultz.net: All, I've just committed a fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=49711 (HttpServletRequest#getParts() does not work in a Filter) with a new

Re: tagging 6.0.31

2011-01-22 Thread Christopher Schultz
Jean-Frederic, On 1/22/2011 4:53 AM, jean-frederic clere wrote: Due the regression in NIO we need a release, I plan to tag on Monday afternoon my time, comments? +1 Fixing NIO is a big deal. :) -chris signature.asc Description: OpenPGP digital signature

Re: RemoteIpValve advices

2011-01-26 Thread Christopher Schultz
Mark and Henri, On 1/26/2011 4:09 AM, Mark Thomas wrote: On 25/01/2011 23:31, Henri Gomez wrote: FYI, it's the kind of valve required by a Tomcat behind Amazon AWS Load Balancer. I'll detail more later but the current ForwardedValve only handle remote (browser) information and not the local

Regarding c:forEach and memory usage

2011-01-27 Thread Christopher Schultz
All, Today's (duplicate) bug report about held references in JSTL tags has me thinking. What is the resistance to fixing the problem of object retention in these tags? JSP 1.8.2 says that all page-scoped objects are released after the response is written or the request is forwarded to another

Re: Tomcat, OpenSSL and FIPS

2011-01-30 Thread Christopher Schultz
Chris, On 1/27/2011 3:54 PM, Chris Beckey wrote: Chris, To set some context, I posted on the tomcat users list serve a question about running OpenSSL in FIPS mode under Tomcat. The last communication was that you may investigate an enhancement. Since then, one of my co-workers took on

Re: Tomcat, OpenSSL and FIPS

2011-01-31 Thread Christopher Schultz
William, On 1/31/2011 1:57 PM, William A. Rowe Jr. wrote: On 1/30/2011 8:20 AM, Christopher Schultz wrote: Chris, On 1/27/2011 3:54 PM, Chris Beckey wrote: Chris, To set some context, I posted on the tomcat users list serve a question about running OpenSSL in FIPS mode under Tomcat

Re: Tomcat, OpenSSL and FIPS

2011-02-01 Thread Christopher Schultz
Chris, On 1/31/2011 5:09 PM, Chris Beckey wrote: I just zip'd together the source and attached it to the bug report. The changes are in: [...] Thanks for the ZIP and (hopefully) the forthcoming patches. Would you be willing to join the Tomcat dev list for further discussions (just let me know

Potential improvements to JspC

2011-02-01 Thread Christopher Schultz
All, I'm working on getting JspC to create a .jar file that contains all the compiled JSPs as well as a META-INF/web-fragment.xml file for easy drop into a webapp with no WEB-INF/web.xml modifications in a 3.0-spec webapp. At this point, I have it working with a simple patch to

Re: Potential improvements to JspC

2011-02-02 Thread Christopher Schultz
Mark, On 2/2/2011 6:49 AM, Mark Thomas wrote: On 02/02/2011 02:49, Christopher Schultz wrote: I would like to update JspC to accept some new settings in lieu of uriroot: jspSourceDir jspClasspath webXml The webXml parameter name isn't going to work, as that's already used

Re: Connection draining when upload to large

2011-02-10 Thread Christopher Schultz
Rainer, On 2/10/2011 8:04 AM, Rainer Jung wrote: It seems there's still no server-side prevention against huge uploads possible. The upload is not put into memory, but the thread is only freed once the whole request body is read. Shouldn't Tomcat ignore the rest of data and close the

Re: Connection draining when upload to large

2011-02-11 Thread Christopher Schultz
William, On 2/10/2011 4:51 PM, William A. Rowe Jr. wrote: On 2/10/2011 7:04 AM, Rainer Jung wrote: Servlet 3 standardizes file uploads. It contains the ability to limit on request size, pretty much the same as commons fileupload supported for many years. It seems when this conditions

Re: Connection draining when upload to large

2011-02-11 Thread Christopher Schultz
Mark, On 2/11/2011 4:37 AM, Mark Thomas wrote: On 10/02/2011 21:32, Christopher Schultz wrote: Rainer, On 2/10/2011 8:04 AM, Rainer Jung wrote: It seems there's still no server-side prevention against huge uploads possible. The upload is not put into memory, but the thread is only freed

Re: Connection draining when upload to large

2011-02-22 Thread Christopher Schultz
All, On 2/17/2011 5:41 AM, Mark Thomas wrote: On 17/02/2011 10:30, Rainer Jung wrote: On 10.02.2011 18:44, Mark Thomas wrote: Any hints about where to add stuff to the docs? Are people fine with making it controllable via the request attribute? I'm not particularly comfortable with this.

Re: Reaching ulimit values for open files can generate huge log files

2011-02-22 Thread Christopher Schultz
Mark, On 2/21/2011 10:21 AM, Mark Thomas wrote: The ASF Sonar installation managed to generate 46GB of identical log messages [1] today in the 8 hours it took to notice it was down. Ugh. Yeah, that sucks. Hitting the ulimit doesn't necessarily mean disaster and the process could still

Re: Reaching ulimit values for open files can generate huge log files

2011-02-22 Thread Christopher Schultz
Mark, On 2/21/2011 10:21 AM, Mark Thomas wrote: The ASF Sonar installation managed to generate 46GB of identical log messages [1] today in the 8 hours it took to notice it was down. I've not really looked at how Tomcat does its logging, but do we have an opportunity to do what, say, syslogd

Re: Download stats

2011-02-23 Thread Christopher Schultz
Mark, On 2/23/2011 10:27 AM, Mark Thomas wrote: I took a quick look at yesterdays log files to see what the proportion of downloads was for the recent 5.5.x, 6.0.x and 7.0.x releases. After a little filtering to try and ensure I was comparing like with like, the results were: Tomcat 5.5.33 -

Re: Response.getWriter(), getOutputStream(), setContentLength() spec issues

2011-02-25 Thread Christopher Schultz
Mark, On 2/25/2011 7:01 AM, Mark Thomas wrote: So, the questions we need to decide: 1. Is the fix for bug 50748 correct? I think it is. +0 2. Should Tomcat try and handle this situation (e.g. if any bytes have been written by a filter, commit the response). This could be tricky to get

Re: bindOnInit and maxConnections for AJP connectors

2011-04-07 Thread Christopher Schultz
Mark, I understand that a fix has already been applied, but... On 4/6/2011 7:16 AM, Mark Thomas wrote: I thought of two options for issue 3: a) Assign a processor (+ inputbuffer, output buffer etc.) to a socket and don't recycle it until the socket is closed. - Increases memory requirements.

Re: Tomcat-oracle secure connection

2011-04-07 Thread Christopher Schultz
Ramram, On 4/7/2011 9:46 AM, ramram8 wrote: Does anybody have any idea how to secure a tomcat connection to oracle database (jdbc encryption for example) or any other idea that can be easily implemented. This is a question better asked on the users' list. -chris signature.asc Description:

JSP Compiler swallows exceptions when removing files

2011-04-07 Thread Christopher Schultz
All, While reading the code for jasper.compiler.Compiler on an unrelated errand, I noticed that the removeGeneratedFiles and removeGeneratedClassFiles methods contain this code: } catch (Exception e) { // Remove as much as possible, ignore possible exceptions } This

Re: svn commit: r1090072 - /tomcat/tc6.0.x/trunk/STATUS.txt

2011-04-08 Thread Christopher Schultz
Konatantin, On 4/7/2011 9:08 PM, Konstantin Kolinko wrote: 2011/4/8 schu...@apache.org: Author: schultz Date: Fri Apr 8 00:41:29 2011 New Revision: 1090072 URL: http://svn.apache.org/viewvc?rev=1090072view=rev Log: Updated. Modified: tomcat/tc6.0.x/trunk/STATUS.txt + +*

Re: bindOnInit and maxConnections for AJP connectors

2011-04-08 Thread Christopher Schultz
Tim, On 4/8/2011 4:50 AM, Tim Whittington wrote: On Fri, Apr 8, 2011 at 2:40 AM, Christopher Schultz ch...@christopherschultz.net wrote: Mark, I understand that a fix has already been applied, but... On 4/6/2011 7:16 AM, Mark Thomas wrote: I thought of two options for issue 3: a) Assign

Re: svn commit: r1090072 - /tomcat/tc6.0.x/trunk/STATUS.txt

2011-04-08 Thread Christopher Schultz
Konstantin, On 4/8/2011 3:56 PM, Konstantin Kolinko wrote: This one (combined with yours): http://svn.apache.org/viewvc?view=revisionrevision=1073393 Aah, I didn't realize that the code I was updating had actually just been written. but there is only one file to delete in each case:

Re: svn commit: r1127315 - /tomcat/jk/trunk/xdocs/reference/apache.xml

2011-05-24 Thread Christopher Schultz
All, I'm not sure what the policy is on documentation changes and back-porting to already-released versions of mod_jk, but this clarifies how mod_jk works and would be beneficial to have on the web site without having to wait for a new release of mod_jk. Is there a good way to do that, or should

Re: mod_jk 1.2.32 [was: Re: svn commit: r1127315 - /tomcat/jk/trunk/xdocs/reference/apache.xml]

2011-05-26 Thread Christopher Schultz
Rainer, On 5/26/2011 5:06 AM, Rainer Jung wrote: There are enough changes for a 1.2.32 anyhow, so I would propose we start a new release cycle in about 2 weeks. Sounds great. -chris signature.asc Description: OpenPGP digital signature

Re: Expected behavior of Tomcat under load

2011-05-26 Thread Christopher Schultz
Asankha, On 5/26/2011 5:01 AM, Asankha C. Perera wrote: First of all, this is a repost from the user@ list from yesterday, as I think this requires a reply from a developer instead of a user. The dev@ list shouldn't be used as a support forum. The user@ list is the appropriate place to post

Outdated Servlet 3.0 Javadocs available on tomcat.apache.org

2011-05-31 Thread Christopher Schultz
All, I just went to check something in the 3.0 Servlet API and the most convenient place I've found is on the Tomcat site. Unfortunately, it looks like it's out of date: http://tomcat.apache.org/tomcat-7.0-doc/servletapi/index.html Many of the 3.0 classes and methods are left undocumented (for

Re: Outdated Servlet 3.0 Javadocs available on tomcat.apache.org

2011-06-01 Thread Christopher Schultz
Tim, On 6/1/2011 8:35 AM, Tim Funk wrote: Is the PDF of the spec which is downloadable up to date with respect to comments? The version of the PDF I'm looking at (3.0 Final, 1434610 bytes, dated 10 December 2009) does not include the javadoc at all... it does include some documentation of

Re: [PROPOSAL] Enable session replication by default.

2011-06-07 Thread Christopher Schultz
Keiichi, On 6/7/2011 7:37 AM, Keiichi Fujino wrote: Index: conf/web.xml === --- conf/web.xml (revision 1127122) +++ conf/web.xml (working copy) @@ -4176,4 +4176,6 @@ welcome-fileindex.jsp/welcome-file

Re: [VOTE] Release Apache Tomcat 7.0.15

2011-06-07 Thread Christopher Schultz
Mark, On 6/4/2011 4:21 PM, Mark Thomas wrote: The proposed Apache Tomcat 7.0.15 release is now available for voting. The proposed 7.0.15 release is: [X] Broken - do not release Based upon broken distributable capability. :( -chris signature.asc Description: OpenPGP digital signature

Re: [PROPOSAL] Enable session replication by default.

2011-06-07 Thread Christopher Schultz
Mark, On 6/7/2011 2:36 PM, Mark Thomas wrote: On 07/06/2011 19:30, Christopher Schultz wrote: Keiichi, On 6/7/2011 7:37 AM, Keiichi Fujino wrote: Index: conf/web.xml === --- conf/web.xml(revision 1127122) +++ conf/web.xml

Re: Crash in APR when pausing endpoint

2011-06-15 Thread Christopher Schultz
Rainer, On 6/13/2011 11:49 AM, Mark Thomas wrote: Analysis and patch make sense to me. +1 Nice analysis. Nice to see I'm not the only one who can code-up a nice race condition. -chris signature.asc Description: OpenPGP digital signature

Re: Diagram for AsyncStateMachine.java

2011-06-19 Thread Christopher Schultz
Konstantin, On 6/18/2011 8:15 PM, Konstantin Kolinko wrote: I have redrawn the state diagram for trunk's org/apache/coyote/AsyncStateMachine.java. Would it be worth including the state transitions in AsyncStateMachine.java in dot format for rendering in GraphViz? -chris signature.asc

Re: OneLineFormatter by default?

2011-06-20 Thread Christopher Schultz
Mark, On 6/20/2011 10:54 AM, Mark Thomas wrote: On 20/06/2011 15:51, Rainer Jung wrote: Should we use the new OneLineFormatter as the default juli formatter? I never found anyone who liked the default java.util.logging log format, which spreads all messages out via two lines. One line

Re: Overhauling setclasspath.(bat|sh)?

2011-06-23 Thread Christopher Schultz
Rainer, On 6/23/2011 7:33 AM, Rainer Jung wrote: On 21.06.2011 11:40, Konstantin Kolinko wrote: 2011/6/20 Rainer Jung rainer.j...@kippdata.de: 1) Renaming Since quite some time now the setclasspath script doesn't have anything to do with setting a class path. It only searches for JRE / JDK

Re: Supporting more general globs in loader definition?

2011-06-23 Thread Christopher Schultz
Rainer, On 6/23/2011 10:39 AM, Rainer Jung wrote: Globs in the file name and not the directory part is the most important use case and easy to understand in its consequences. So I lean towards this type of improvement right now. So: /path/to/*.jar (allowed today) /path/to/foo*.jar

Re: Supporting more general globs in loader definition?

2011-06-23 Thread Christopher Schultz
Rainer, On 6/23/2011 4:02 PM, Rainer Jung wrote: But supporting a glob in the file name would also work. I'm always irritated when something that looks like it should work doesn't work. The fact that .../*.jar works but .../foo*.jar does not work is surprising, so I'm in support of adding

Tomcat native build requirements

2011-06-28 Thread Christopher Schultz
All, I'm reviewing a patch against the Java portion of tcnative, and I wanted to know what level of JDK support we can require. Specifically, StringBuilder is not available before JDK 1.5. Is that acceptable to use at this point? Not sure if we have to support 1.4 JVMs for the tcnative project

Tomcat FIPS mode questions

2011-06-28 Thread Christopher Schultz
Chris, I've been reviewing your patches to BZ 50570 (https://issues.apache.org/bugzilla/show_bug.cgi?id=50570) and I have a few questions. First, why did you change the name of the init method to initializeAPR? The method is private and should therefore be safe to re-name, but I was wondering

Re: Tomcat FIPS mode questions

2011-06-28 Thread Christopher Schultz
Chris, On 6/28/2011 2:55 PM, Christopher Schultz wrote: I've been reviewing your patches to BZ 50570 (https://issues.apache.org/bugzilla/show_bug.cgi?id=50570) and I have a few questions. Also, why the changes to java/org/apache/tomcat/jni/Library.java? If there's a bug in there (it doesn't

Looking for review of new FIPS mode patches

2011-06-28 Thread Christopher Schultz
All, I have a small patch for tcnative's SSL.c and a somewhat more involved patch for AprLifecycleListener.java, both attached to https://issues.apache.org/bugzilla/show_bug.cgi?id=50570 I'd appreciate some review by those familiar with that code so make sure I haven't made any terrible mistakes

No release date for 7.0.16 on web site changelog

2011-06-30 Thread Christopher Schultz
All, Though TC7.0.x trunk changelog has the release date, the public web site does not. Can you trigger an update of the website to publish this date? -chris signature.asc Description: OpenPGP digital signature

Re: Time for 6.0.33?

2011-07-01 Thread Christopher Schultz
Mark, On 7/1/2011 4:32 AM, Mark Thomas wrote: On 14/06/2011 14:09, Mark Thomas wrote: The changelog is getting quite long for 6.0.x. Is it time for another release? Jean-Frederic - are you able to RM this or do we need to find a volunteer for this one? No replies to this. Is this because

Re: [ANN] CI for Tomcat 6 and 7 docs now available

2010-09-17 Thread Christopher Schultz
Mark, On 9/17/2010 7:27 AM, Mark Thomas wrote: Thanks to the infrastructure team (specifically Gavin in this case) we now have CI builds of the Tomcat 6 7 docs that will update with every commit. Dumb question: what is a CI build? -chris signature.asc Description: OpenPGP digital

Writing unit tests

2010-09-20 Thread Christopher Schultz
All, I'm attempting a patch for https://issues.apache.org/bugzilla/show_bug.cgi?id=49964 and I'd like to write a few unit tests for it. In the Tomcat 6.0.x trunk, I can only find what appear to be 30-40 test files. Is there a test suite elsewhere that I can download and augment in order to

Re: Writing unit tests

2010-09-20 Thread Christopher Schultz
Mark, On 9/20/2010 4:33 PM, Mark Thomas wrote: On 20/09/2010 11:29, Christopher Schultz wrote: All, I'm attempting a patch for https://issues.apache.org/bugzilla/show_bug.cgi?id=49964 and I'd like to write a few unit tests for it. In the Tomcat 6.0.x trunk, I can only find what appear

Re: Writing unit tests

2010-09-20 Thread Christopher Schultz
Mark, On 9/20/2010 4:52 PM, Mark Thomas wrote: That'll probably be better in 7.0.x. I do wonder what init code you might need. I was expecting a simple boolean attribute. Once that is sorted, we can figure out how to port it to 6.0.x Since I was thinking of allowing any set of HTTP methods, I

  1   2   3   4   5   6   7   8   9   10   >