[GitHub] [tomee] nishantraut opened a new pull request #627: Add Portuguese translation for examples/javamail

2020-01-15 Thread GitBox
nishantraut opened a new pull request #627: Add Portuguese translation for examples/javamail URL: https://github.com/apache/tomee/pull/627 This is an automated message from the Apache Git Service. To respond to the message,

Re: How can I help?

2020-01-15 Thread Nishant Raut
Hello Everyone, I have raised PR for Portuguese translation for example/javamail, please review and merge. Look forward to contribute more. Thanks and Regards, Nishant On Wed, Jan 15, 2020, 10:56 AM Nishant Raut wrote: > Hi Cesar, > > As i don't know Spanish or Portuguese i need to use some tr

Re: How can I help?

2020-01-15 Thread Daniel Dias Dos Santos
Hello Nishant, You need to know Spanish or Portuguese to translate the documentation. you can use your own language : ) Em qua., 15 de jan. de 2020 às 06:05, Nishant Raut escreveu: > Hello Everyone, > > I have raised PR for Portuguese translation for example/javamail, please > review and merg

Re: How can I help?

2020-01-15 Thread Nishant Raut
Hello Daniel and Everyone, I have taken help of google translation to convert into Portuguese. :) On Wed, Jan 15, 2020, 5:03 PM Daniel Dias Dos Santos < daniel.dias.analist...@gmail.com> wrote: > Hello Nishant, > > You need to know Spanish or Portuguese to translate the documentation. > > you ca

Re: How can I help?

2020-01-15 Thread Richard Monson-Haefel
Nishant, What is your native language or second language that you know other than English? Richard On Wed, Jan 15, 2020 at 8:14 AM Nishant Raut wrote: > Hello Daniel and Everyone, > > I have taken help of google translation to convert into Portuguese. :) > > On Wed, Jan 15, 2020, 5:03 PM Danie

Please Review PR #624: Fix typo in excluding URLs in the DeploymentResolver

2020-01-15 Thread Richard Monson-Haefel
Hi, This PR has been sitting waiting for review for almost a month. Can someone take a look at it. I'm not sure what JIRA ticket its associated with so I'm not sure if the fix was needed or not. https://github.com/apache/tomee/pull/624 Thanks!! Richard -- Richard Monson-Haefel https://twitter

Please Review PR #627: Add Portuguese translation for examples/javamail

2020-01-15 Thread Richard Monson-Haefel
Nishant Raut submitted this PR for review. He used google translate to convert it to Portuguese. Can someone with Portuguese language skills check it over? I'm pretty sure it will need corrections as Google Translate is not flawless. https://github.com/apache/tomee/pull/627/commits Thanks!! Ric

[GitHub] [tomee] marcoantoniobferreira commented on a change in pull request #627: TOMEE-2761 Add Portuguese translation for examples/javamail

2020-01-15 Thread GitBox
marcoantoniobferreira commented on a change in pull request #627: TOMEE-2761 Add Portuguese translation for examples/javamail URL: https://github.com/apache/tomee/pull/627#discussion_r366923137 ## File path: examples/javamail/README_pt.adoc ## @@ -0,0 +1,201 @@ +:index-gro

[GitHub] [tomee] marcoantoniobferreira commented on a change in pull request #627: TOMEE-2761 Add Portuguese translation for examples/javamail

2020-01-15 Thread GitBox
marcoantoniobferreira commented on a change in pull request #627: TOMEE-2761 Add Portuguese translation for examples/javamail URL: https://github.com/apache/tomee/pull/627#discussion_r366924499 ## File path: examples/javamail/README_pt.adoc ## @@ -0,0 +1,201 @@ +:index-gro

[GitHub] [tomee] marcoantoniobferreira commented on a change in pull request #627: TOMEE-2761 Add Portuguese translation for examples/javamail

2020-01-15 Thread GitBox
marcoantoniobferreira commented on a change in pull request #627: TOMEE-2761 Add Portuguese translation for examples/javamail URL: https://github.com/apache/tomee/pull/627#discussion_r366926487 ## File path: examples/javamail/README_pt.adoc ## @@ -0,0 +1,201 @@ +:index-gro

[GitHub] [tomee] marcoantoniobferreira commented on a change in pull request #627: TOMEE-2761 Add Portuguese translation for examples/javamail

2020-01-15 Thread GitBox
marcoantoniobferreira commented on a change in pull request #627: TOMEE-2761 Add Portuguese translation for examples/javamail URL: https://github.com/apache/tomee/pull/627#discussion_r366927651 ## File path: examples/javamail/README_pt.adoc ## @@ -0,0 +1,201 @@ +:index-gro

Re: Please Review PR #627: Add Portuguese translation for examples/javamail

2020-01-15 Thread Marco Ferreira
Hi Richard and Nishant, i reviewed the PR and left some comments! On Wed, 15 Jan 2020 at 11:57, Richard Monson-Haefel wrote: > Nishant Raut submitted this PR for review. He used google translate to > convert it to Portuguese. Can someone with Portuguese language skills > check it over? I'm pret

Re: How can I help?

2020-01-15 Thread Nishant Raut
Hello Richard, Its hindi. Thanks and Regards, Nishant On Wed, Jan 15, 2020, 8:17 PM Richard Monson-Haefel wrote: > Nishant, > > What is your native language or second language that you know other than > English? > > Richard > > On Wed, Jan 15, 2020 at 8:14 AM Nishant Raut > wrote: > > > Hello

Re: Please Review PR #627: Add Portuguese translation for examples/javamail

2020-01-15 Thread Nishant Raut
Thanks Marco, i will address those comments. Thanks and Regards, Nishant On Wed, Jan 15, 2020, 8:41 PM Marco Ferreira < marcoantoniobferre...@gmail.com> wrote: > Hi Richard and Nishant, i reviewed the PR and left some comments! > > On Wed, 15 Jan 2020 at 11:57, Richard Monson-Haefel < > monsonha

[GitHub] [tomee] nishantraut commented on issue #627: TOMEE-2761 Add Portuguese translation for examples/javamail

2020-01-15 Thread GitBox
nishantraut commented on issue #627: TOMEE-2761 Add Portuguese translation for examples/javamail URL: https://github.com/apache/tomee/pull/627#issuecomment-574733658 > Hi Nishant! Great translation with a few points of attention =) --

[GitHub] [tomee] nishantraut opened a new pull request #627: TOMEE-2761 Add Portuguese translation for examples/javamail

2020-01-15 Thread GitBox
nishantraut opened a new pull request #627: TOMEE-2761 Add Portuguese translation for examples/javamail URL: https://github.com/apache/tomee/pull/627 This is an automated message from the Apache Git Service. To respond to th

[GitHub] [tomee] nishantraut closed pull request #627: TOMEE-2761 Add Portuguese translation for examples/javamail

2020-01-15 Thread GitBox
nishantraut closed pull request #627: TOMEE-2761 Add Portuguese translation for examples/javamail URL: https://github.com/apache/tomee/pull/627 This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [tomee] nishantraut commented on a change in pull request #627: TOMEE-2761 Add Portuguese translation for examples/javamail

2020-01-15 Thread GitBox
nishantraut commented on a change in pull request #627: TOMEE-2761 Add Portuguese translation for examples/javamail URL: https://github.com/apache/tomee/pull/627#discussion_r366968927 ## File path: examples/javamail/README_pt.adoc ## @@ -0,0 +1,201 @@ +:index-group: Unrevi

[GitHub] [tomee] nishantraut removed a comment on issue #627: TOMEE-2761 Add Portuguese translation for examples/javamail

2020-01-15 Thread GitBox
nishantraut removed a comment on issue #627: TOMEE-2761 Add Portuguese translation for examples/javamail URL: https://github.com/apache/tomee/pull/627#issuecomment-574733658 > Hi Nishant! Great translation with a few points of attention =) --

[GitHub] [tomee] nishantraut commented on a change in pull request #627: TOMEE-2761 Add Portuguese translation for examples/javamail

2020-01-15 Thread GitBox
nishantraut commented on a change in pull request #627: TOMEE-2761 Add Portuguese translation for examples/javamail URL: https://github.com/apache/tomee/pull/627#discussion_r366969081 ## File path: examples/javamail/README_pt.adoc ## @@ -0,0 +1,201 @@ +:index-group: Unrevi

[GitHub] [tomee] nishantraut commented on a change in pull request #627: TOMEE-2761 Add Portuguese translation for examples/javamail

2020-01-15 Thread GitBox
nishantraut commented on a change in pull request #627: TOMEE-2761 Add Portuguese translation for examples/javamail URL: https://github.com/apache/tomee/pull/627#discussion_r366969427 ## File path: examples/javamail/README_pt.adoc ## @@ -0,0 +1,201 @@ +:index-group: Unrevi

[GitHub] [tomee] nishantraut commented on issue #627: TOMEE-2761 Add Portuguese translation for examples/javamail

2020-01-15 Thread GitBox
nishantraut commented on issue #627: TOMEE-2761 Add Portuguese translation for examples/javamail URL: https://github.com/apache/tomee/pull/627#issuecomment-574735012 > Hi Nishant! Great translation with a few points of attention =) Thanks @marcoantoniobferreira for review, i have upd

Re: Please Review PR #627: Add Portuguese translation for examples/javamail

2020-01-15 Thread Nishant Raut
PR updated against comments. On Wed, Jan 15, 2020, 9:28 PM Nishant Raut wrote: > Thanks Marco, i will address those comments. > > Thanks and Regards, > Nishant > > On Wed, Jan 15, 2020, 8:41 PM Marco Ferreira < > marcoantoniobferre...@gmail.com> wrote: > >> Hi Richard and Nishant, i reviewed the

Re: How can I help?

2020-01-15 Thread Richard Monson-Haefel
Hi Nishant, I know there are hundreds of dialects in India, but do you think creating Hindi transitions would be better. Using Google translate is cool, but if we can broaden our community with Hindi that would be even better. Richard On Wed, Jan 15, 2020 at 9:55 AM Nishant Raut wrote: > Hell

Re: Please Review PR #627: Add Portuguese translation for examples/javamail

2020-01-15 Thread Richard Monson-Haefel
Great job! On Wed, Jan 15, 2020 at 11:00 AM Nishant Raut wrote: > PR updated against comments. > > On Wed, Jan 15, 2020, 9:28 PM Nishant Raut wrote: > > > Thanks Marco, i will address those comments. > > > > Thanks and Regards, > > Nishant > > > > On Wed, Jan 15, 2020, 8:41 PM Marco Ferreira <

[GitHub] [tomee] monsonhaefel commented on issue #627: TOMEE-2761 Add Portuguese translation for examples/javamail

2020-01-15 Thread GitBox
monsonhaefel commented on issue #627: TOMEE-2761 Add Portuguese translation for examples/javamail URL: https://github.com/apache/tomee/pull/627#issuecomment-574761792 Give another quick look, @marcoantoniobferreira and if its good let us know so it can be merged!

[GitHub] [tomee] marcoantoniobferreira commented on issue #627: TOMEE-2761 Add Portuguese translation for examples/javamail

2020-01-15 Thread GitBox
marcoantoniobferreira commented on issue #627: TOMEE-2761 Add Portuguese translation for examples/javamail URL: https://github.com/apache/tomee/pull/627#issuecomment-574862732 > Amazing! It can be merged @monsonhaefel ! ---

Re: Please Review PR #627: Add Portuguese translation for examples/javamail

2020-01-15 Thread Marco Ferreira
Hi folks, PR approved! Thanks again Nishant and Richard! On Wed, 15 Jan 2020 at 14:14, Richard Monson-Haefel wrote: > Great job! > > On Wed, Jan 15, 2020 at 11:00 AM Nishant Raut > wrote: > > > PR updated against comments. > > > > On Wed, Jan 15, 2020, 9:28 PM Nishant Raut > wrote: > > > > > T

Re: Please Review PR #624: Fix typo in excluding URLs in the DeploymentResolver

2020-01-15 Thread Cesar Hernandez
Hi, I'm not at the desk right now but usually, this can be validated running locally the test over the maven module this change is part of it. El mié., 15 ene. 2020 a las 8:50, Richard Monson-Haefel (< monsonhae...@gmail.com>) escribió: > Hi, > > This PR has been sitting waiting for review for

[GitHub] [tomee] cesarhernandezgt commented on a change in pull request #627: TOMEE-2761 Add Portuguese translation for examples/javamail

2020-01-15 Thread GitBox
cesarhernandezgt commented on a change in pull request #627: TOMEE-2761 Add Portuguese translation for examples/javamail URL: https://github.com/apache/tomee/pull/627#discussion_r367149682 ## File path: examples/javamail/README_pt.adoc ## @@ -0,0 +1,201 @@ +:index-group: U

[GitHub] [tomee] nishantraut commented on a change in pull request #627: TOMEE-2761 Add Portuguese translation for examples/javamail

2020-01-15 Thread GitBox
nishantraut commented on a change in pull request #627: TOMEE-2761 Add Portuguese translation for examples/javamail URL: https://github.com/apache/tomee/pull/627#discussion_r367232699 ## File path: examples/javamail/README_pt.adoc ## @@ -0,0 +1,201 @@ +:index-group: Unrevi

[GitHub] [tomee] nishantraut commented on issue #627: TOMEE-2761 Add Portuguese translation for examples/javamail

2020-01-15 Thread GitBox
nishantraut commented on issue #627: TOMEE-2761 Add Portuguese translation for examples/javamail URL: https://github.com/apache/tomee/pull/627#issuecomment-574985707 > Greate contribution @nishantraut , I just left a comment on the document headers. Thanks @cesarhernandezgt i have f

[GitHub] [tomee] cesarhernandezgt merged pull request #627: TOMEE-2761 Add Portuguese translation for examples/javamail

2020-01-15 Thread GitBox
cesarhernandezgt merged pull request #627: TOMEE-2761 Add Portuguese translation for examples/javamail URL: https://github.com/apache/tomee/pull/627 This is an automated message from the Apache Git Service. To respond to the

Re: How can I help?

2020-01-15 Thread Nishant Raut
Hi Richard, It's a good idea to add hindi support but i feel most of the Indian tech community members knows english. Nishant On Wed, Jan 15, 2020, 10:44 PM Richard Monson-Haefel wrote: > Hi Nishant, > > I know there are hundreds of dialects in India, but do you think creating > Hindi transiti