Re: TomEE 8 Release Preview

2018-10-14 Thread j4fm
Hi, I'm taking a look at the TomEE 8 release preview for the MP 1.3 support. I was wondering about the profiles/editions and what's in them. As I understood RS/MP Plus <> Plume. Plus has the following but Plume doesn't. --batchee-jbatch-0.5-incubating.jar --commons-jcs-core-2.1.jar

Re: TomEE 8 Release Preview

2018-10-14 Thread j4fm
I just understood that Plus was supposed to include everything from RS plus more. And PluME included everything from Plus and more. That seems to not be the case anymore. Now, Plus contains stuff not in PluMe and RS/MP contains stuff not in either and the comparisons page doesn't reflect this

Re: TomEE 8 M1 - MP

2018-11-05 Thread j4fm
Tested with an app and without an app present. Without an app, shouldn't I still be able to reach the tomee status/manager pages? If I remove MP opentracing jars, status/manager pages are reachable both with and without an app. Thanks -- Sent from:

Re: TomEE 8 M1 - MP

2018-11-05 Thread j4fm
That works. Is this something that will be made default and then an app can enable when it wants to use opentracing? Thank you -- Sent from: http://tomee-openejb.979440.n4.nabble.com/TomEE-Dev-f982480.html

TomEE 8 M1 - MP

2018-11-02 Thread j4fm
I ran the tomee:8-jre-8.0.0-M1-microprofile Docker container. Although TomEE starts up just fine, I cannot access it because of the following error (I don't think this is Docker specific). If I move the Microprofile tracing JARs out of the lib folder before start, then I can access TomEE fine.

Re: MicroProfile Integration in Plus and Plume

2018-12-31 Thread j4fm
Hi, I tested with the last TomEE Plus snapshot which had MP in it and #304 below. Apart from having to add a line to exclusions.list for one item, it seems to work fine. Without the exclusions.list entry, I get the following because @Provider is being used in our class (think this could be

Re: MicroProfile Integration in Plus and Plume

2019-01-15 Thread j4fm
Hi again Roberto, I tested this again today and actually I hadn't noticed that another ticket commented out MP jars from being added to the Plus webapp, just like you said. Now if I pull in 304 there our some out of date package references (import

Re: MicroProfile Integration in Plus and Plume

2019-01-16 Thread j4fm
Happy to contribute if/where I can, for sure - how? If the enabling/disabling of MP scans per-context can be done automatically - great. If it's a manual configuration that's workable but automatic is obviously preferred - then things would just work. -- Sent from:

Re: MicroProfile Integration in Plus and Plume

2019-01-17 Thread j4fm
I'm not sure the problem I'm having with our existing apps when MP is in Plus is related to the root context. This is with pull304 you wrote. This problem doesn't happen with only a simply basic war file in TomEE only when our apps are in (class loader and war files). The traditional contexts

Re: MicroProfile Integration in Plus and Plume

2019-01-17 Thread j4fm
They are not small or independent but I will see what I can put together. This looks related... http://tomee-openejb.979440.n4.nabble.com/PRIVATE-ApplicationComposer-7-0-0-and-Jars-td4677302.html "In CdiScanner I can see the classes in BeanInfo beans. But just after the following condition

Re: MicroProfile Integration in Plus and Plume

2019-01-21 Thread j4fm
Hi, sorry for the delay. Both WAR files and also external webbase context with a custom class loader. Interesting, happy to test. Thank you -- Sent from: http://tomee-openejb.979440.n4.nabble.com/TomEE-Dev-f982480.html

Re: MicroProfile Integration in Plus and Plume

2019-01-23 Thread j4fm
On this specific service, there is the following: @Path("/") @GET public Response doGetRoot() { … } Followed by paths with actual values just like you said. It would be good for OpenAPI to provide a fix, I will see if I can test changing it in source directly tonight by just changing "/", to

Re: MicroProfile Integration in Plus and Plume

2019-01-23 Thread j4fm
So progress is good, I feel like it's close to working with MP. Took the SystemInstance parent failover line out and now it's dependent on this issue being resolved https://issues.apache.org/jira/browse/TOMEE-2458 which was why it was put in the first place. I've worked around by adding all the

Re: MicroProfile Integration in Plus and Plume

2019-01-23 Thread j4fm
Okay, so digging into this loader, there is this line: SystemInstance.get().setComponent(ParentClassLoaderFinder.class, fallback -> MyClassLoader._getOrCreateInstance(parent)); Commenting it out seems to make it play nicely with MP but brakes the class loading of the webapps when openejb's

Re: MicroProfile Integration in Plus and Plume

2019-01-23 Thread j4fm
FYI, as you mentioned, I also see OpenAPI annotation index out of bounds. If you would like me to test out any fix for it, I can do that immediately... /Caused by: java.lang.StringIndexOutOfBoundsException: begin 1, end 0, length 1 at

Re: TomEE 8 Release Preview

2018-12-05 Thread j4fm
I know there is an incredible amount of work going on. Is there any chance that MP can be added to Plus anytime soon? I think there was an offer of some help above too. Thanks! -- Sent from: http://tomee-openejb.979440.n4.nabble.com/TomEE-Dev-f982480.html

Re: MicroProfile Integration in Plus and Plume

2019-01-24 Thread j4fm
I could trace it to JaxRS is intercepting it and does not find a resource resulting in the 404. While it should use the DefaultServlet (JAXRSInInterceptor:135 the 404 is created). It is saying in the log: 24-Jan-2019 16:10:35.803 INFO [main]

Re: MicroProfile Integration in Plus and Plume

2019-01-24 Thread j4fm
Hi Roberto, Just digging on the 404 issue. So I have found in one of the webapps web-fragment.xml the following: SomeFilter /* REQUEST FORWARD ASYNC Does this relate to the root context being taken

Re: MicroProfile Integration in Plus and Plume

2019-01-22 Thread j4fm
In the webapps, there is a loader specified in the context.xml. This singleton loader ensures that native libraries used by the webapps are ultimately only loaded once but only the specific webapps load them rather than affecting all webapps on TomEE. -- Sent from:

Re: MicroProfile Integration in Plus and Plume

2019-02-25 Thread j4fm
Hi Roberto, fyi, I've solved the issue of using filenames for enhanceScannableUrls. I changed left your approach intact and is still used for "mp-common" and if you need to add any files in future. But for all other MP JARs, I switched it to use your list of MP fully-qualified extensions class

Re: MicroProfile Integration in Plus and Plume

2019-02-25 Thread j4fm
PR 416 I'm not sure I quite follow the ConfigSource approach. I was thinking it would need to be done in enhanceScannableUrls to avoid the JARs being scanned in the first place. I don't think setting the .active for metrics and opentracing is enough. Do you think that is possible? -- Sent

Re: Microprofile 1.2.0 + CXF 3.3.0

2019-02-26 Thread j4fm
Great news that the build succeeds, thanks! My thoughts were based on this statement in the CXF 3.3.0 Migration page: "Major dependency changes: ... JAX-RS and JAXB APIs are now JakartaEE dependencies. All other JakartaEE dependencies will follow with the next major release. Old dependencies can

Re: PRs

2019-02-26 Thread j4fm
Is anyone able to look at the new PMD violations on openejb-core (the files look like they were changed with this merge via commit 88c62c257f7bed248d42078d0f39456620b9b056)? -- Sent from: http://tomee-openejb.979440.n4.nabble.com/TomEE-Dev-f982480.html

Re: Microprofile 1.2.0 + CXF 3.3.0

2019-02-26 Thread j4fm
PR419 is added for what I described above -- Sent from: http://tomee-openejb.979440.n4.nabble.com/TomEE-Dev-f982480.html

Re: PRs ready for review

2019-02-28 Thread j4fm
Hi César, are you happy with the PR419+PR409 after I resolved your valid points? My local full run of tests succeeds (with the examples too). Thanks again for checking. James -- Sent from: http://tomee-openejb.979440.n4.nabble.com/TomEE-Dev-f982480.html

Re: MicroProfile Integration in Plus and Plume

2019-02-27 Thread j4fm
Hi Roberto I have found that MP-JWT is missing from the default.exclusions. Is that expected? I see the JWT Filter being added in all cases even when tomee.mp.scan=none is set but also when tomee.mp.scan=all is set, the JWT Filter is added twice. If not intended, I have submitted PR424.

Re: MicroProfile Integration in Plus and Plume

2019-02-28 Thread j4fm
FYI, the full run of tests succeeded locally with this PR over night. :) -- Sent from: http://tomee-openejb.979440.n4.nabble.com/TomEE-Dev-f982480.html

Re: MicroProfile Integration in Plus and Plume

2019-02-27 Thread j4fm
Cool then, PR 424 just needs merging to fix this. The setting itself is working just fine. -- Sent from: http://tomee-openejb.979440.n4.nabble.com/TomEE-Dev-f982480.html

Re: TomEE Web vs TomEE MP vs TomEE Plus

2019-02-27 Thread j4fm
Personally, (I'm not sure what the standard process is) I would love to see TomEE 8 final release with CXF 3.3.0/JAXB 2.3.2 and MP in Plus/Plume before end of March. An M3 with what we have (especially CXF 3.3.0/JAXB 2.3.2) would be great too to run stable for a couple of weeks or so. -- Sent

Re: TomEE Web vs TomEE MP vs TomEE Plus

2019-02-27 Thread j4fm
On Jarkata EE cert... +1 for after 8 is released. This conversation just reminded me of this thread quite some time ago now, with some views :) Status-of-TomEE-8 -- Sent from:

Re: Building with Java 11

2019-03-01 Thread j4fm
The tests you copied out do not look like they failed on buildbot or locally. There are no failures so far and it's quite far along. It's appears to just be slow. -- Sent from: http://tomee-openejb.979440.n4.nabble.com/TomEE-Dev-f982480.html

Re: Buildbot slowness

2019-03-01 Thread j4fm
I have a fix for the slow build (works locally without memory error now). If somebody wouldn't mind stopping the current buildbot task and I will create a small PR. Thanks in advance -- Sent from: http://tomee-openejb.979440.n4.nabble.com/TomEE-Dev-f982480.html

Re: Building with Java 11

2019-03-01 Thread j4fm
Started a new thread for slowness... the warnings are out of memory. -- Sent from: http://tomee-openejb.979440.n4.nabble.com/TomEE-Dev-f982480.html

Buildbot slowness

2019-03-01 Thread j4fm
Buildbot is slow with :cdi-tomee tests causing out of memory warnings. The PR409 (CXF 3.3.0 and JAXB 2.3.2) updates was the first merge to cause the slowness. The rolled up merges after show the same. # Created on 2019-03-01T20:48:20.010 Corrupted STDOUT by directly writing to native stream in

Buildbot slowness

2019-03-01 Thread j4fm
Getting this WARNING on :cdi-tomee on buildbot which is taking forever... # Created on 2019-03-01T20:48:20.010 Corrupted STDOUT by directly writing to native stream in forked JVM 1. Stream 'java.lang.OutOfMemoryError: Java heap space'. java.lang.IllegalArgumentException: Stream stdin corrupted.

Re: Building with Java 11

2019-03-01 Thread j4fm
Do you have any idea if you J11 branch build is slow vs normal just yet? -- Sent from: http://tomee-openejb.979440.n4.nabble.com/TomEE-Dev-f982480.html

Re: Apache TomEE channel in the-asf.slack.com

2019-03-01 Thread j4fm
Me too please -- Sent from: http://tomee-openejb.979440.n4.nabble.com/TomEE-Dev-f982480.html

Re: Building with Java 11

2019-03-01 Thread j4fm
That makes sense, just didn't want to confuse the j11 branch test failures vs what could be causing the slowness. I'm seeing those same warnings now locally so I can try and dig deeper here. :) -- Sent from: http://tomee-openejb.979440.n4.nabble.com/TomEE-Dev-f982480.html

Re: Buildbot slowness

2019-03-01 Thread j4fm
Would like to get the stats at the end of the CI build if possible too. PR409 was the first merge to start the issue but there are no code changes in there except to examples and the bumps of CXF and JAXB. Do you see it just being cdi-tomee that's slowed up? I'm checking out it's (indirect)

Re: Buildbot slowness

2019-03-01 Thread j4fm
False fix, it just got a lot further before an oom exception. -- Sent from: http://tomee-openejb.979440.n4.nabble.com/TomEE-Dev-f982480.html

Re: Building with Java 11

2019-03-01 Thread j4fm
Thanks Jon, so it wasn't frozen (impatient me) - just mid-test but running like someone stole it's ponies. Once it finishes I will check the stats, but did you see slowness happen before... could it be busy infra? -- Sent from: http://tomee-openejb.979440.n4.nabble.com/TomEE-Dev-f982480.html

Re: Building with Java 11

2019-03-01 Thread j4fm
PR409 was the merge that was first seen being slow. -- Sent from: http://tomee-openejb.979440.n4.nabble.com/TomEE-Dev-f982480.html

Re: Buildbot slowness

2019-03-01 Thread j4fm
Not sure it's ever going to finish. Seems to be grinding to a halt. You're right, no point letting it run. -- Sent from: http://tomee-openejb.979440.n4.nabble.com/TomEE-Dev-f982480.html

Re: Building with Java 11

2019-03-01 Thread j4fm
I would be happy to pull your PR and build against JDK 11 before merging. I can start that build now. I see buildbot seems to have frozen. I think really my PR 419 should run before the current 409 because the former is mostly prep for the latter. If you are okay with it, I will click stop (if

Re: Building with Java 11

2019-03-01 Thread j4fm
Ah yeah that makes sense. It won't let me stop the current stuck build. Would you be able to? >From the logs it looks like it succeeds up until the point it's frozen... I'm not sure what's up with it. Have you seen it freeze like this before? Maybe it's an issue with the CI agent instead?

Re: Buildbot slowness

2019-03-03 Thread j4fm
So I have a fix for the cdi-tomee tck which means we can add cxf 3.3.0 back in. I just want to wait for full tests to complete before explaining in detail but to sum it up the bug was in testng which was keeping hold of threads. -- Sent from:

Re: Building with Java 11

2019-03-03 Thread j4fm
So I have a fix for the cdi-tomee tck which means we can add cxf 3.3.0 back in. I just want to wait for full tests to complete before explaining in detail but to sum it up the bug was in testng which was keeping hold of threads. -- Sent from:

Re: Buildbot slowness

2019-03-01 Thread j4fm
Hey Jon, thanks for the test. Do you still have all my PRs in there after just removing the PR409? Yeah, I was looking around all the dependency changes that CXF (and JAXB which it depends on) brings in. I do have something I am working on, instead of excluding the older javax conflicting

Re: Buildbot slowness

2019-03-02 Thread j4fm
It's just changing CXF version to 3.3 on it's own that causes it. Reverting back to 3.2.7 solves it. All the JAXB 2.8.2 and related dependency work seems to be fine. Though I see the CXF mp client version bump adds in activation-api which needs excluding. I'm testing 3.3.1 out now just to check

Re: Buildbot slowness

2019-03-02 Thread j4fm
CXF 3.3.1 is also causing the problem. I've submitted PR 429 just to make buildbot happy again for the time being. Would you mind merging just to get the builds going again? Will be good to confirm it's happy with the other PRs. Once a root cause/solution is found can bump CXF back up again.

Re: Buildbot slowness

2019-03-01 Thread j4fm
Building is not a problem, it's the CDI TCK test run causing out of memory exception in tomee -- Sent from: http://tomee-openejb.979440.n4.nabble.com/TomEE-Dev-f982480.html

Re: Buildbot slowness

2019-03-02 Thread j4fm
Hey Jon, do you know if your test run with an increased java heap froze up or succeeded? Thanks -- Sent from: http://tomee-openejb.979440.n4.nabble.com/TomEE-Dev-f982480.html

Re: Buildbot slowness

2019-03-02 Thread j4fm
Slowness is fixed, so buildbot is happier but not quite happy. Just for awareness to avoid someone else looking at it too... 1. I forgot to update the CXF version in the examples\polling-parent. So polling-web failed. 2. Also, it turns out CXF didn't add support for mp rest client 1.2.0 until

Re: Buildbot slowness

2019-03-02 Thread j4fm
I ran the :cdi-tomee tck to successful completion with an extra 756MB added to the max heap for this arquillian run. I'm running it again just to make sure. Would updating master with the config be acceptable? We could have cxf 3.3.0+mp rest client back in if so. -- Sent from:

Re: Buildbot slowness

2019-03-04 Thread j4fm
Thanks for merging. Buildbot is succeeding again. So my testng changes help speed up the tests and improve the heap usage (worth adding the changes in at some point) but it didn't solve the root cause. I see these in the logs: SEVERE [http-nio-37745-exec-211]

Re: MicroProfile Integration in Plus and Plume

2019-02-20 Thread j4fm
I've updated the isCXFResource check to follow the same behaviour as the JAX-RS application logic itself. If the application's getClasses() or getSingletons() return something then Application sub-class fully controls the resources/endpoints so the isCXFResource check returns true and sends all

Re: MicroProfile Integration in Plus and Plume

2019-02-20 Thread j4fm
Basically adding to or removing from restClass as the TomEEMicroProfileListener is currently doing has no effect on REST applications that "extend Application" and provide getClasses() or getSingletons(). Even if the OpenAPIFilter is in the providers, the endpoint is not added so no /openapi

Re: MicroProfile Integration in Plus and Plume

2019-02-20 Thread j4fm
Okay, found out this first one turns out to be straight-up my fault. The OpenAPIFilter isn't expected to be loaded by TomEE itself in the chain and actually goes via an extension loaded by CXF itself triggering it as a pre-match request filter. So the enhancement I made needs to take into

Re: PRs ready for review

2019-02-26 Thread j4fm
Great catches, thank you. The outside of I already did pick up before I reran the tests and appears I forgot to push. The commenting out of examples was in the middle of testing somehing unrelated... was not intended to end up in here. My laptop is offline now, I will update it in the

Re: PRs ready for review

2019-02-26 Thread j4fm
Hi César, actually I pushed the two fixes right now (the other was from parent)! So should be good to go! Thanks! :) -- Sent from: http://tomee-openejb.979440.n4.nabble.com/TomEE-Dev-f982480.html

Re: Building with Java 11

2019-03-06 Thread j4fm
FYI, onyl loosely related but as part of fixing the CDI TCK memory gobbling with CXF 3.3.0, I've added quite a few to the default.exclusions for scanning. I also noticed the lib we have is woodstox-core-5.x.x.jar but in default.exclusions we have woodstox-core-asl-x.x.x.jar. This may avoid your

Re: Building with Java 11

2019-03-06 Thread j4fm
You can just grab this file and give it a shot... https://github.com/j4fm/tomee/blob/CXF-3.3.0-Take-2/container/openejb-core/src/main/resources/default.exclusions I haven't quite finalized the tweaks I'm working on but it's pretty much there. Thanks -- Sent from: http://tomee-openejb.979440

Re: MicroProfile Integration in Plus and Plume

2019-02-22 Thread j4fm
All local build tests PASSED with my PR 406! :D -- Sent from: http://tomee-openejb.979440.n4.nabble.com/TomEE-Dev-f982480.html

Re: CI builds

2019-02-22 Thread j4fm
Hello All the queued builds will fail one or two test cases (cdi-embedded, openapi). PR 406 I submitted has literally just this minute completed full run of tests locally finishing with BUILD SUCCESS (it's up to date with apache/master too). If there is the possibility of cancelling the queued

Re: Microprofile 1.2.0 + CXF 3.3.0

2019-02-25 Thread j4fm
This update should probably also be aligned or include the JAXB update -> Jakarta EE Maven coordinates because CXF does that too. I have already done some work on the JAXB. There are several pom.xml dependency updates and exclusion changes just for JAXB (it affects activation.jar too). So my

Idea of an M3

2019-02-22 Thread j4fm
Hey, I would just like to ask what the chances are of an M3 coming up soon? Now the first green builds with MP built in to Plus/Plume are happening, I think it could be good for an M3 soon to be able to encourage more exposure/usage. So I thought I'd ask the question anyway, I know it takes a

Re: MicroProfile Integration in Plus and Plume

2019-02-22 Thread j4fm
So we have a happy buildbot again for the first time since MP is added to Plus/Plume. Thanks for all your help on this so far. :) -- Sent from: http://tomee-openejb.979440.n4.nabble.com/TomEE-Dev-f982480.html

Re: CI builds

2019-02-22 Thread j4fm
(I didn't receive notification the above messages and only just saw them) Thank you for taking a look and merging my PR, I noticed the buildbot build tests succeeded (phew!). I don't see ant new test cases right now (the existing ones actually did a very good job of making us fix a number of

Re: Microprofile 1.2.0 + CXF 3.3.0

2019-02-22 Thread j4fm
Added a comment to the PR as I remember seeing major dependency changes with CXF 3.3 which might impact. -- Sent from: http://tomee-openejb.979440.n4.nabble.com/TomEE-Dev-f982480.html

Re: MicroProfile Integration in Plus and Plume

2019-02-22 Thread j4fm
For sure... - Do you have an idea for how best to add the tomee.mp.scan per context? - Any preference on fixing the filename scanning issue? I'm wondering if having Maven dependency rename the JAR in the lib folder slightly so that it doesn't catch two in one go would be acceptable? Thanks

Re: Microprofile 1.2.0 + CXF 3.3.0

2019-02-25 Thread j4fm
Also, I notice on the exception above it's coming from openejb code here... with the comment "// TODO: drop when we get a fully supporting java 9 version of CXF" As CXF 3.3.0 supports Java 11, this implies this the call should be removed completely and should resolve the above exception.

Re: Buildbot slowness

2019-03-05 Thread j4fm
This is fixed now. PR on it's way, it was mostly just new exclusions needed adding, duh. -- Sent from: http://tomee-openejb.979440.n4.nabble.com/TomEE-Dev-f982480.html

Re: Buildbot slowness

2019-03-04 Thread j4fm
When running tests in full here are the tests that appear to cause a leak... just to see if anything common between them is obvious from your experience? Just to be sure, the leak exceptions from these do not appear in the logs at all with CXF 3.2.7.

Re: MicroProfile Integration in Plus and Plume

2019-02-27 Thread j4fm
The bad news is my tests showed the default.exclusions did not fix the issue. The good news is I found the static extension that was always registering the JWT providers. So I've commented that out as now your new approach of scanning the providers automatically is working just fine. I've added

Re: MicroProfile Integration in Plus and Plume

2019-03-01 Thread j4fm
Hi Roberto, PR 418 is also ready now that openapi and safeguard latest release versions are in maven -- Sent from: http://tomee-openejb.979440.n4.nabble.com/TomEE-Dev-f982480.html

Re: Building with Java 11

2019-03-01 Thread j4fm
Thanks for the merges, hopefully will save time. Could I make a shameless request for 418 too? (and 424 if poss) :D I'm going to keep a close eye on buildbot too, just in case. James -- Sent from: http://tomee-openejb.979440.n4.nabble.com/TomEE-Dev-f982480.html

Re: Building with Java 11

2019-03-01 Thread j4fm
I already updated all the JAXB related artifacts to 2.3.1 which comes with CXF 3.3.0 too. I already added all the transitive dependency exclusions. Your extra ones could just be added on top of that. The work is in PR 419 which was already reviewed and approved. It would be great to have that

Re: Building with Java 11

2019-03-01 Thread j4fm
For PR 419 and 409 all the full tests pass too. -- Sent from: http://tomee-openejb.979440.n4.nabble.com/TomEE-Dev-f982480.html

Re: Buildbot slowness

2019-03-03 Thread j4fm
Hiya, would you be able to merge PR 430 to allow buildbot to pass again for me? Thanks -- Sent from: http://tomee-openejb.979440.n4.nabble.com/TomEE-Dev-f982480.html

Re: Building with Java 11

2019-03-01 Thread j4fm
Thanks Jon. I'm keeping an eye on each run on buildbot. Maybe I should go out for a while ;) -- Sent from: http://tomee-openejb.979440.n4.nabble.com/TomEE-Dev-f982480.html

Re: PRs

2019-02-26 Thread j4fm
PMD is fixed now. Many thanks. Hopeful for the test cases. :) -- Sent from: http://tomee-openejb.979440.n4.nabble.com/TomEE-Dev-f982480.html

Re: PRs

2019-02-26 Thread j4fm
Awesome thanks, am keen to get the CXF/JAXB PRs in, so if nobody is yet looking at the previous build failure starting at #1038 I will take a look to see if it's anything I can help with. I didn't get it happen locally yet though. -- Sent from:

Re: PRs

2019-02-26 Thread j4fm
Test cases SUCCESS now too :D -- Sent from: http://tomee-openejb.979440.n4.nabble.com/TomEE-Dev-f982480.html

Re: TOMEE-2377 | Add README.adoc to cucumber-jvm example

2019-02-26 Thread j4fm
Any reason for: Revert "Fix PMD issues with double-negation"? -- Sent from: http://tomee-openejb.979440.n4.nabble.com/TomEE-Dev-f982480.html

PRs ready for review

2019-02-26 Thread j4fm
Now that buildbot is happy again, would someone be able to review/merge the following PRs that are ready? Would be greatly appreciated. Local tests were fine. Thanks! PR419 - Prep and bump JAXB 2.3.2, prep for CXF 3.3.0 and fix some existing build warnings. PR409 - Bump CXF+MP REST client (not

Re: MicroProfile Integration in Plus and Plume

2019-02-21 Thread j4fm
PR 406. Also included a small fix for CXF taking over Jersey app even if disabled. -- Sent from: http://tomee-openejb.979440.n4.nabble.com/TomEE-Dev-f982480.html

Re: MicroProfile Integration in Plus and Plume

2019-02-21 Thread j4fm
If I undo your two CDIScanner.java commits: https://github.com/apache/tomee/commit/de5a2ee7aafe08c4caf20c8ae322cabde5f1cbcf#diff-b316d57f3c81b76c38456cebdd2ec27f https://github.com/apache/tomee/commit/76f91408a2ddd5d05ede0d3be93df4c3d5a96079#diff-b316d57f3c81b76c38456cebdd2ec27f CDI-Embedded

Re: MicroProfile Integration in Plus and Plume

2019-03-07 Thread j4fm
Hey Roberto, I have an idea for how to add the per-context tomee.mp.scan. Just want to add the AppInfo param to the EnhanceScannableUrlsEvent and enable/disable the scanning for each mp feature based on per-context config. This event was only added since the last release so won't break any

Re: RestClient issue - different apps with same client

2019-03-12 Thread j4fm
https://issues.apache.org/jira/browse/CXF-7980 -- Sent from: http://tomee-openejb.979440.n4.nabble.com/TomEE-Dev-f982480.html

Re: Buildbot slowness

2019-03-08 Thread j4fm
Hi Jon Would you be able to check and merge PR 438 for me? I've broken the work down into bite sizes. This first one is just to get Cxf/MP Rest client back in (all tests succeed and without slowness). Later I will submit some work around TCK+testng to improve memory handling when running a

Re: MicroProfile Integration in Plus and Plume

2019-02-06 Thread j4fm
Finally got a chance to run through it. Found it, should be pretty straight forward to fix metrics. It's just because the MP prefix list causes duplicate matches i.e. there are two jars beginning geronimo-metrics- (impl+common). It only finds the first (geronimo-metrics-common). Health only

Re: MicroProfile Integration in Plus and Plume

2019-02-06 Thread j4fm
I'm also looking into things here to help out. Will submit a PR to TOMEE-2408 if I get anything -- Sent from: http://tomee-openejb.979440.n4.nabble.com/TomEE-Dev-f982480.html

Re: MicroProfile Integration in Plus and Plume

2019-02-08 Thread j4fm
Hey how's it going with the buildbot failures? Anything I could help with (not an expert on this but willing to have a look and learn)? Do you have any thoughts on root cause(s)? -- Sent from: http://tomee-openejb.979440.n4.nabble.com/TomEE-Dev-f982480.html

Re: MicroProfile Integration in Plus and Plume

2019-02-06 Thread j4fm
Just fyi, harcoded the metrics jar filename as a quick test and it is now adding the metrics endpoints just fine. So that's the only issue with this one. So a fix for this will help make buildbot happier. :) -- Sent from: http://tomee-openejb.979440.n4.nabble.com/TomEE-Dev-f982480.html

Re: MicroProfile Integration in Plus and Plume

2019-02-06 Thread j4fm
If I read you correctly, I thought about that as a quick solution but the problem is the prefixes can be no more specific just because of the filenames used. geronimo-metrics-x.x.x.jar geronimo-metrics-common-x.x.x.jar If both prefixes are added to the list, both will return

Re: MicroProfile Integration in Plus and Plume

2019-02-06 Thread j4fm
Created PR #387 -- Sent from: http://tomee-openejb.979440.n4.nabble.com/TomEE-Dev-f982480.html

Re: MicroProfile Integration in Plus and Plume

2019-02-12 Thread j4fm
Have a remaining test issue but not sure on it's validity. Would like to get your thoughts on the JAX-RS NotFound test. arquillian\arquillian-tomee-tests\arquillian-tomee-jaxrs-tests\src\test\java\org\apache\openejb\arquillian\tests\jaxrs\notfound\NotFoundTest.java This test basically

Re: MicroProfile Integration in Plus and Plume

2019-02-12 Thread j4fm
For now, I've changed the test to do an assertEquals(404, response) type and will add to PR as I think that makes most sense for a "NotFound" test. -- Sent from: http://tomee-openejb.979440.n4.nabble.com/TomEE-Dev-f982480.html

Re: MicroProfile Integration in Plus and Plume

2019-02-09 Thread j4fm
No probs at all. Absolutely sure happy to look. Did open up the cdi-embdded exception yesterday but didn't get very far with the little time I had. Do you think the two are related? fyi, I changed the PR to 390 with its own tickets as I expect it helps more than just MP endpoints, so thought

Re: MicroProfile Integration in Plus and Plume

2019-02-09 Thread j4fm
The test passes without all-adapters specified. Fails with it. So will find out which adapter. -- Sent from: http://tomee-openejb.979440.n4.nabble.com/TomEE-Dev-f982480.html

  1   2   >