[GitHub] twill pull request #58: [TWILL-240] EventHandler Improvement

2017-08-08 Thread chtyim
Github user chtyim commented on a diff in the pull request: https://github.com/apache/twill/pull/58#discussion_r132029365 --- Diff: twill-yarn/src/test/java/org/apache/twill/yarn/EventHandlerTest.java --- @@ -0,0 +1,351 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] twill pull request #58: [TWILL-240] EventHandler Improvement

2017-08-08 Thread chtyim
Github user chtyim commented on a diff in the pull request: https://github.com/apache/twill/pull/58#discussion_r132029465 --- Diff: twill-yarn/src/test/java/org/apache/twill/yarn/EventHandlerTest.java --- @@ -0,0 +1,351 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] twill pull request #58: [TWILL-240] EventHandler Improvement

2017-08-08 Thread chtyim
Github user chtyim commented on a diff in the pull request: https://github.com/apache/twill/pull/58#discussion_r132029508 --- Diff: twill-yarn/src/test/java/org/apache/twill/yarn/EventHandlerTest.java --- @@ -0,0 +1,351 @@ +/* + * Licensed to the Apache Software Foundation

[jira] [Commented] (TWILL-240) Improve EventHandler to handle more application lifecycle events

2017-08-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TWILL-240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16119021#comment-16119021 ] ASF GitHub Bot commented on TWILL-240: -- Github user chtyim commented on a diff in the

[jira] [Commented] (TWILL-240) Improve EventHandler to handle more application lifecycle events

2017-08-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TWILL-240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16119022#comment-16119022 ] ASF GitHub Bot commented on TWILL-240: -- Github user chtyim commented on a diff in the

[jira] [Commented] (TWILL-240) Improve EventHandler to handle more application lifecycle events

2017-08-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TWILL-240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16119023#comment-16119023 ] ASF GitHub Bot commented on TWILL-240: -- Github user chtyim commented on a diff in the

[GitHub] twill pull request #58: [TWILL-240] EventHandler Improvement

2017-08-08 Thread chtyim
Github user chtyim commented on a diff in the pull request: https://github.com/apache/twill/pull/58#discussion_r132040093 --- Diff: twill-yarn/src/main/java/org/apache/twill/internal/appmaster/RunningContainers.java --- @@ -267,6 +280,14 @@ void stopByIdAndWait(String runnableName

[jira] [Commented] (TWILL-240) Improve EventHandler to handle more application lifecycle events

2017-08-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TWILL-240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16119074#comment-16119074 ] ASF GitHub Bot commented on TWILL-240: -- Github user chtyim commented on a diff in the

[jira] [Commented] (TWILL-240) Improve EventHandler to handle more application lifecycle events

2017-08-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TWILL-240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16119075#comment-16119075 ] ASF GitHub Bot commented on TWILL-240: -- Github user chtyim commented on a diff in the

[GitHub] twill pull request #58: [TWILL-240] EventHandler Improvement

2017-08-08 Thread chtyim
Github user chtyim commented on a diff in the pull request: https://github.com/apache/twill/pull/58#discussion_r132040768 --- Diff: twill-yarn/src/test/java/org/apache/twill/yarn/EventHandlerTest.java --- @@ -0,0 +1,351 @@ +/* + * Licensed to the Apache Software Foundation

[jira] [Commented] (TWILL-240) Improve EventHandler to handle more application lifecycle events

2017-08-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TWILL-240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16119072#comment-16119072 ] ASF GitHub Bot commented on TWILL-240: -- Github user chtyim commented on a diff in the

[jira] [Commented] (TWILL-240) Improve EventHandler to handle more application lifecycle events

2017-08-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TWILL-240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16119073#comment-16119073 ] ASF GitHub Bot commented on TWILL-240: -- Github user chtyim commented on a diff in the

[GitHub] twill pull request #58: [TWILL-240] EventHandler Improvement

2017-08-08 Thread chtyim
Github user chtyim commented on a diff in the pull request: https://github.com/apache/twill/pull/58#discussion_r132037568 --- Diff: twill-yarn/src/main/java/org/apache/twill/internal/appmaster/ApplicationMasterService.java --- @@ -221,7 +229,8 @@ protected void doStart() throws Ex

[GitHub] twill pull request #58: [TWILL-240] EventHandler Improvement

2017-08-08 Thread chtyim
Github user chtyim commented on a diff in the pull request: https://github.com/apache/twill/pull/58#discussion_r132038521 --- Diff: twill-yarn/src/main/java/org/apache/twill/internal/appmaster/RunningContainers.java --- @@ -267,6 +280,14 @@ void stopByIdAndWait(String runnableName

[GitHub] twill pull request #58: [TWILL-240] EventHandler Improvement

2017-08-08 Thread chtyim
Github user chtyim commented on a diff in the pull request: https://github.com/apache/twill/pull/58#discussion_r132038164 --- Diff: twill-yarn/src/main/java/org/apache/twill/internal/appmaster/RunningContainers.java --- @@ -173,6 +183,9 @@ void start(String runnableName, Container

[jira] [Commented] (TWILL-240) Improve EventHandler to handle more application lifecycle events

2017-08-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TWILL-240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16119076#comment-16119076 ] ASF GitHub Bot commented on TWILL-240: -- Github user chtyim commented on a diff in the

[GitHub] twill pull request #58: [TWILL-240] EventHandler Improvement

2017-08-08 Thread maochf
Github user maochf commented on a diff in the pull request: https://github.com/apache/twill/pull/58#discussion_r132048851 --- Diff: twill-yarn/src/main/java/org/apache/twill/internal/appmaster/RunningContainers.java --- @@ -267,6 +280,14 @@ void stopByIdAndWait(String runnableName

[jira] [Commented] (TWILL-240) Improve EventHandler to handle more application lifecycle events

2017-08-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TWILL-240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16119110#comment-16119110 ] ASF GitHub Bot commented on TWILL-240: -- Github user maochf commented on a diff in the