[jira] [Commented] (ZOOKEEPER-2893) very poor choice of logging if client fails to connect to server

2017-12-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16288906#comment-16288906 ] ASF GitHub Bot commented on ZOOKEEPER-2893: --- Github user paulmillar commented on a diff in

Failed: ZOOKEEPER- PreCommit Build #1354

2017-12-13 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1354/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 789.38 KB...] [exec]

Failed: ZOOKEEPER- PreCommit Build #1353

2017-12-13 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1353/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 80.97 MB...] [exec] +1

[GitHub] zookeeper pull request #430: ZOOKEEPER-2893. very poor choice of logging if ...

2017-12-13 Thread paulmillar
Github user paulmillar commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/430#discussion_r156594864 --- Diff: src/java/main/org/apache/zookeeper/ClientCnxn.java --- @@ -1041,6 +1041,8 @@ private void sendPing() { private

[GitHub] zookeeper pull request #430: ZOOKEEPER-2893. very poor choice of logging if ...

2017-12-13 Thread paulmillar
Github user paulmillar commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/430#discussion_r156594949 --- Diff: src/java/main/org/apache/zookeeper/ClientCnxn.java --- @@ -1232,11 +1233,12 @@ public void run() { } else if (e

Success: ZOOKEEPER- PreCommit Build #1352

2017-12-13 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1352/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 77.59 MB...] [exec]

Failed: ZOOKEEPER- PreCommit Build #1351

2017-12-13 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1351/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 72.02 MB...] [exec] +1

[GitHub] zookeeper pull request #430: ZOOKEEPER-2893. very poor choice of logging if ...

2017-12-13 Thread anmolnar
Github user anmolnar commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/430#discussion_r156597536 --- Diff: src/java/main/org/apache/zookeeper/ClientCnxn.java --- @@ -1232,11 +1233,12 @@ public void run() { } else if (e

[jira] [Commented] (ZOOKEEPER-2893) very poor choice of logging if client fails to connect to server

2017-12-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16288924#comment-16288924 ] ASF GitHub Bot commented on ZOOKEEPER-2893: --- Github user anmolnar commented on a diff in the

[jira] [Commented] (ZOOKEEPER-2893) very poor choice of logging if client fails to connect to server

2017-12-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16288941#comment-16288941 ] ASF GitHub Bot commented on ZOOKEEPER-2893: --- Github user anmolnar commented on a diff in the

Failed: ZOOKEEPER- PreCommit Build #1357

2017-12-13 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1357/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 42.07 MB...] [exec]

[jira] [Commented] (ZOOKEEPER-2893) very poor choice of logging if client fails to connect to server

2017-12-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16288908#comment-16288908 ] ASF GitHub Bot commented on ZOOKEEPER-2893: --- Github user paulmillar commented on a diff in

[jira] [Commented] (ZOOKEEPER-2893) very poor choice of logging if client fails to connect to server

2017-12-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16288909#comment-16288909 ] ASF GitHub Bot commented on ZOOKEEPER-2893: --- Github user paulmillar commented on a diff in

[GitHub] zookeeper pull request #430: ZOOKEEPER-2893. very poor choice of logging if ...

2017-12-13 Thread paulmillar
Github user paulmillar commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/430#discussion_r156594153 --- Diff: src/java/main/org/apache/zookeeper/ClientCnxn.java --- @@ -1232,11 +1233,12 @@ public void run() { } else if (e

Failed: ZOOKEEPER- PreCommit Build #1355

2017-12-13 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1355/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 30.72 KB...] [exec]

Failed: ZOOKEEPER- PreCommit Build #1358

2017-12-13 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1358/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 33.40 KB...] [exec]

[GitHub] zookeeper pull request #430: ZOOKEEPER-2893. very poor choice of logging if ...

2017-12-13 Thread anmolnar
Github user anmolnar commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/430#discussion_r156599702 --- Diff: src/java/main/org/apache/zookeeper/ClientCnxn.java --- @@ -1041,6 +1041,8 @@ private void sendPing() { private

[GitHub] zookeeper pull request #433: [WIP] ZOOKEEPER-2953: Flaky Test: testNoLogBefo...

2017-12-13 Thread afine
GitHub user afine reopened a pull request: https://github.com/apache/zookeeper/pull/433 [WIP] ZOOKEEPER-2953: Flaky Test: testNoLogBeforeLeaderEstablishment You can merge this pull request into a Git repository by running: $ git pull https://github.com/afine/zookeeper

[GitHub] zookeeper pull request #433: [WIP] ZOOKEEPER-2953: Flaky Test: testNoLogBefo...

2017-12-13 Thread afine
Github user afine closed the pull request at: https://github.com/apache/zookeeper/pull/433 ---

[jira] [Commented] (ZOOKEEPER-2953) Flaky Test: testNoLogBeforeLeaderEstablishment

2017-12-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16288925#comment-16288925 ] ASF GitHub Bot commented on ZOOKEEPER-2953: --- Github user afine closed the pull request at:

[jira] [Commented] (ZOOKEEPER-2953) Flaky Test: testNoLogBeforeLeaderEstablishment

2017-12-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16288926#comment-16288926 ] ASF GitHub Bot commented on ZOOKEEPER-2953: --- GitHub user afine reopened a pull request:

Failed: ZOOKEEPER- PreCommit Build #1350

2017-12-13 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1350/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 79.28 MB...] [exec] +1

Success: ZOOKEEPER- PreCommit Build #1349

2017-12-13 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1349/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 73.26 MB...] [exec]

[jira] [Created] (ZOOKEEPER-2954) ant compile_jute is failing for zookeeper 3.4.11

2017-12-13 Thread Aditya Pawaskar (JIRA)
Aditya Pawaskar created ZOOKEEPER-2954: -- Summary: ant compile_jute is failing for zookeeper 3.4.11 Key: ZOOKEEPER-2954 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2954 Project: ZooKeeper

[jira] [Commented] (ZOOKEEPER-2952) Upgrade third party libraries to address vulnerabilities

2017-12-13 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16289245#comment-16289245 ] Hadoop QA commented on ZOOKEEPER-2952: -- +1 overall. GitHub Pull Request Build +1

[jira] [Commented] (ZOOKEEPER-2952) Upgrade third party libraries to address vulnerabilities

2017-12-13 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16289303#comment-16289303 ] Hadoop QA commented on ZOOKEEPER-2952: -- -1 overall. GitHub Pull Request Build +1

[jira] [Commented] (ZOOKEEPER-2952) Upgrade third party libraries to address vulnerabilities

2017-12-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16289298#comment-16289298 ] ASF GitHub Bot commented on ZOOKEEPER-2952: --- GitHub user anmolnar opened a pull request:

Failed: ZOOKEEPER- PreCommit Build #1362

2017-12-13 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1362/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 34.96 KB...] [exec] +1

[jira] [Commented] (ZOOKEEPER-2952) Upgrade third party libraries to address vulnerabilities

2017-12-13 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16289304#comment-16289304 ] Hadoop QA commented on ZOOKEEPER-2952: -- -1 overall. GitHub Pull Request Build +1

Failed: ZOOKEEPER- PreCommit Build #1361

2017-12-13 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1361/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 30.50 KB...] [exec] +1

[jira] [Commented] (ZOOKEEPER-2893) very poor choice of logging if client fails to connect to server

2017-12-13 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16289186#comment-16289186 ] Hadoop QA commented on ZOOKEEPER-2893: -- +1 overall. GitHub Pull Request Build +1

[jira] [Updated] (ZOOKEEPER-2955) Enable Clover code coverage report

2017-12-13 Thread Mark Fenes (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2955?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Fenes updated ZOOKEEPER-2955: -- Affects Version/s: 3.5.3 3.4.11 > Enable Clover code coverage report

[jira] [Commented] (ZOOKEEPER-2952) Upgrade third party libraries to address vulnerabilities

2017-12-13 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16289325#comment-16289325 ] Hadoop QA commented on ZOOKEEPER-2952: -- +1 overall. GitHub Pull Request Build +1

[GitHub] zookeeper issue #429: ZOOKEEPER-2952. Upgrade third party libs: netty, slf4j

2017-12-13 Thread anmolnar
Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/429 @phunt I've updated the slf4j license. ---

Success: ZOOKEEPER- PreCommit Build #1360

2017-12-13 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1360/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 74.54 MB...] [exec]

[jira] [Commented] (ZOOKEEPER-2953) Flaky Test: testNoLogBeforeLeaderEstablishment

2017-12-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16289275#comment-16289275 ] ASF GitHub Bot commented on ZOOKEEPER-2953: --- Github user anmolnar commented on a diff in the

[jira] [Commented] (ZOOKEEPER-2953) Flaky Test: testNoLogBeforeLeaderEstablishment

2017-12-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16289277#comment-16289277 ] ASF GitHub Bot commented on ZOOKEEPER-2953: --- Github user anmolnar commented on the issue:

[GitHub] zookeeper pull request #435: ZOOKEEPER-2952. Upgrade third party libs: netty...

2017-12-13 Thread anmolnar
GitHub user anmolnar opened a pull request: https://github.com/apache/zookeeper/pull/435 ZOOKEEPER-2952. Upgrade third party libs: netty, slf4j, log4j This is the branch-3.4 version of https://github.com/apache/zookeeper/pull/429 netty, log4j, slf4j You can merge

[jira] [Updated] (ZOOKEEPER-2952) Upgrade third party libraries to address vulnerabilities

2017-12-13 Thread Andor Molnar (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2952?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andor Molnar updated ZOOKEEPER-2952: Description: Hi, I'm going to upgrade the following third party libraries in order to

Success: ZOOKEEPER- PreCommit Build #1363

2017-12-13 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1363/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 75.42 MB...] [exec]

[jira] [Commented] (ZOOKEEPER-2954) ant compile_jute is failing for zookeeper 3.4.11

2017-12-13 Thread Aditya Pawaskar (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16290318#comment-16290318 ] Aditya Pawaskar commented on ZOOKEEPER-2954: Hi Andor Molnar, Thanks for solution. it

[GitHub] zookeeper issue #262: ZOOKEEPER-2789: Reassign `ZXID` for solving 32bit over...

2017-12-13 Thread phunt
Github user phunt commented on the issue: https://github.com/apache/zookeeper/pull/262 Ok, thanks for the update. fwiw restarting taking a few minutes is going to be an issue regardless, no? Any regular type issue, such as a temporary network outage, could cause the quorum to be lost

[jira] [Commented] (ZOOKEEPER-2789) Reassign `ZXID` for solving 32bit overflow problem

2017-12-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16290360#comment-16290360 ] ASF GitHub Bot commented on ZOOKEEPER-2789: --- Github user phunt commented on the issue:

ZooKeeper-trunk - Build # 3656 - Still Failing

2017-12-13 Thread Apache Jenkins Server
See https://builds.apache.org/job/ZooKeeper-trunk/3656/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 140.64 KB...] [junit] Running

[GitHub] zookeeper pull request #427: [ZOOKEEPER-2338] - set SOCK_CLOEXEC on socket i...

2017-12-13 Thread fr0stbyte
Github user fr0stbyte commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/427#discussion_r156860284 --- Diff: src/c/configure.ac --- @@ -130,18 +130,66 @@ main() else exit(0); } -], AC_MSG_RESULT(yes) - ipv6=yes, -

[jira] [Commented] (ZOOKEEPER-2789) Reassign `ZXID` for solving 32bit overflow problem

2017-12-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16290405#comment-16290405 ] ASF GitHub Bot commented on ZOOKEEPER-2789: --- Github user asdf2014 commented on the issue:

[GitHub] zookeeper issue #262: ZOOKEEPER-2789: Reassign `ZXID` for solving 32bit over...

2017-12-13 Thread asdf2014
Github user asdf2014 commented on the issue: https://github.com/apache/zookeeper/pull/262 Hi, @phunt . Indeed, the `FastLeaderElection` algorithm is very efficient. Most of the leader election situation would finished in hundreds milliseconds. However, some real-time stream

[jira] [Commented] (ZOOKEEPER-2338) c bindings should create socket's with SOCK_CLOEXEC to avoid fd leaks on fork/exec

2017-12-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16290385#comment-16290385 ] ASF GitHub Bot commented on ZOOKEEPER-2338: --- Github user fr0stbyte commented on a diff in

[GitHub] zookeeper pull request #377: [ZOOKEEPER-2901] TTL Nodes don't work with Serv...

2017-12-13 Thread phunt
Github user phunt commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/377#discussion_r156821102 --- Diff: src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java --- @@ -476,9 +474,12 @@ public ZooKeeperServerListener

[jira] [Commented] (ZOOKEEPER-2901) Session ID that is negative causes mis-calculation of Ephemeral Type

2017-12-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16290114#comment-16290114 ] ASF GitHub Bot commented on ZOOKEEPER-2901: --- Github user phunt commented on a diff in the

[GitHub] zookeeper pull request #377: [ZOOKEEPER-2901] TTL Nodes don't work with Serv...

2017-12-13 Thread phunt
Github user phunt commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/377#discussion_r156821178 --- Diff: src/docs/src/documentation/content/xdocs/zookeeperAdmin.xml --- @@ -949,14 +949,15 @@ server.3=zoo3:2888:3888

[GitHub] zookeeper pull request #377: [ZOOKEEPER-2901] TTL Nodes don't work with Serv...

2017-12-13 Thread phunt
Github user phunt commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/377#discussion_r156821209 --- Diff: src/docs/src/documentation/content/xdocs/zookeeperProgrammers.xml --- @@ -271,9 +271,9 @@ is not modified within the TTL and has

[jira] [Commented] (ZOOKEEPER-2939) Deal with maxbuffer as it relates to proposals

2017-12-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16290237#comment-16290237 ] ASF GitHub Bot commented on ZOOKEEPER-2939: --- Github user phunt commented on the issue:

[jira] [Commented] (ZOOKEEPER-2901) Session ID that is negative causes mis-calculation of Ephemeral Type

2017-12-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16290118#comment-16290118 ] ASF GitHub Bot commented on ZOOKEEPER-2901: --- Github user phunt commented on a diff in the

[jira] [Commented] (ZOOKEEPER-2901) Session ID that is negative causes mis-calculation of Ephemeral Type

2017-12-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16290117#comment-16290117 ] ASF GitHub Bot commented on ZOOKEEPER-2901: --- Github user phunt commented on a diff in the

[GitHub] zookeeper issue #415: ZOOKEEPER-2939: Added last/min/max proposal size JMX b...

2017-12-13 Thread phunt
Github user phunt commented on the issue: https://github.com/apache/zookeeper/pull/415 This seems like a reasonable addition (see below). I like the refactorings (kudos). The code seems fine. I do have a couple questions though. 1) this information should also be added to

ZooKeeper_branch35_openjdk7 - Build # 778 - Failure

2017-12-13 Thread Apache Jenkins Server
See https://builds.apache.org/job/ZooKeeper_branch35_openjdk7/778/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 59.42 KB...] [junit] Running

[jira] [Commented] (ZOOKEEPER-2893) very poor choice of logging if client fails to connect to server

2017-12-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16290148#comment-16290148 ] ASF GitHub Bot commented on ZOOKEEPER-2893: --- Github user phunt commented on a diff in the

[GitHub] zookeeper pull request #430: ZOOKEEPER-2893. very poor choice of logging if ...

2017-12-13 Thread phunt
Github user phunt commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/430#discussion_r156825456 --- Diff: src/java/main/org/apache/zookeeper/ClientCnxn.java --- @@ -1041,6 +1041,8 @@ private void sendPing() { private

[jira] [Commented] (ZOOKEEPER-2893) very poor choice of logging if client fails to connect to server

2017-12-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16290147#comment-16290147 ] ASF GitHub Bot commented on ZOOKEEPER-2893: --- Github user phunt commented on a diff in the

[GitHub] zookeeper pull request #430: ZOOKEEPER-2893. very poor choice of logging if ...

2017-12-13 Thread phunt
Github user phunt commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/430#discussion_r156825263 --- Diff: src/java/main/org/apache/zookeeper/ClientCnxn.java --- @@ -1236,7 +1237,7 @@ public void run() { "Session

Success: ZOOKEEPER- PreCommit Build #1364

2017-12-13 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1364/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 34.71 MB...] [exec]

[jira] [Comment Edited] (ZOOKEEPER-2954) ant compile_jute is failing for zookeeper 3.4.11

2017-12-13 Thread Andor Molnar (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16289452#comment-16289452 ] Andor Molnar edited comment on ZOOKEEPER-2954 at 12/13/17 4:11 PM: ---

[jira] [Commented] (ZOOKEEPER-2893) very poor choice of logging if client fails to connect to server

2017-12-13 Thread Andor Molnar (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16289437#comment-16289437 ] Andor Molnar commented on ZOOKEEPER-2893: - [~paulmillar] I thought about it, but that would

[jira] [Commented] (ZOOKEEPER-2954) ant compile_jute is failing for zookeeper 3.4.11

2017-12-13 Thread Andor Molnar (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16289452#comment-16289452 ] Andor Molnar commented on ZOOKEEPER-2954: - [~adityap] Ant task 'compile_jute' doesn't trigger

[jira] [Commented] (ZOOKEEPER-2952) Upgrade third party libraries to address vulnerabilities

2017-12-13 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16289423#comment-16289423 ] Hadoop QA commented on ZOOKEEPER-2952: -- +1 overall. GitHub Pull Request Build +1

[jira] [Commented] (ZOOKEEPER-2952) Upgrade third party libraries to address vulnerabilities

2017-12-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16290459#comment-16290459 ] ASF GitHub Bot commented on ZOOKEEPER-2952: --- Github user anmolnar closed the pull request

[GitHub] zookeeper pull request #435: ZOOKEEPER-2952. Upgrade third party libs: netty...

2017-12-13 Thread anmolnar
Github user anmolnar closed the pull request at: https://github.com/apache/zookeeper/pull/435 ---

[jira] [Commented] (ZOOKEEPER-2952) Upgrade third party libraries to address vulnerabilities

2017-12-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16289226#comment-16289226 ] ASF GitHub Bot commented on ZOOKEEPER-2952: --- Github user anmolnar commented on the issue:

[jira] [Commented] (ZOOKEEPER-2953) Flaky Test: testNoLogBeforeLeaderEstablishment

2017-12-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16289894#comment-16289894 ] ASF GitHub Bot commented on ZOOKEEPER-2953: --- Github user afine commented on a diff in the

[GitHub] zookeeper pull request #432: [WIP] ZOOKEEPER-2953: Flaky Test: testNoLogBefo...

2017-12-13 Thread afine
Github user afine commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/432#discussion_r156780239 --- Diff: src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerMainTest.java --- @@ -335,6 +336,100 @@ public void testHighestZxidJoinLate() throws

[GitHub] zookeeper pull request #432: [WIP] ZOOKEEPER-2953: Flaky Test: testNoLogBefo...

2017-12-13 Thread afine
Github user afine commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/432#discussion_r156781040 --- Diff: src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerMainTest.java --- @@ -335,6 +336,100 @@ public void testHighestZxidJoinLate() throws

[jira] [Commented] (ZOOKEEPER-2953) Flaky Test: testNoLogBeforeLeaderEstablishment

2017-12-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16289901#comment-16289901 ] ASF GitHub Bot commented on ZOOKEEPER-2953: --- Github user afine commented on a diff in the

[GitHub] zookeeper issue #432: [WIP] ZOOKEEPER-2953: Flaky Test: testNoLogBeforeLeade...

2017-12-13 Thread afine
Github user afine commented on the issue: https://github.com/apache/zookeeper/pull/432 @anmolnar An explanation is coming, please excuse the cruft at this stage. I wanted to run the new test on apache hardware hence the [WIP] in the title. ---

[jira] [Commented] (ZOOKEEPER-2953) Flaky Test: testNoLogBeforeLeaderEstablishment

2017-12-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16289905#comment-16289905 ] ASF GitHub Bot commented on ZOOKEEPER-2953: --- Github user afine commented on the issue:

Success: ZOOKEEPER- PreCommit Build #1367

2017-12-13 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1367/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 73.31 MB...] [exec]

Success: ZOOKEEPER- PreCommit Build #1366

2017-12-13 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1366/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 69.37 MB...] [exec]

Success: ZOOKEEPER- PreCommit Build #1365

2017-12-13 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1365/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 72.99 MB...] [exec]

Success: ZOOKEEPER- PreCommit Build #1359

2017-12-13 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1359/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 74.61 MB...] [exec]

[jira] [Commented] (ZOOKEEPER-2893) very poor choice of logging if client fails to connect to server

2017-12-13 Thread Paul Millar (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16289222#comment-16289222 ] Paul Millar commented on ZOOKEEPER-2893: The other thing that would be good to fix is that the

[GitHub] zookeeper pull request #432: [WIP] ZOOKEEPER-2953: Flaky Test: testNoLogBefo...

2017-12-13 Thread anmolnar
Github user anmolnar commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/432#discussion_r156660196 --- Diff: src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerMainTest.java --- @@ -335,6 +336,100 @@ public void testHighestZxidJoinLate()

[GitHub] zookeeper issue #432: [WIP] ZOOKEEPER-2953: Flaky Test: testNoLogBeforeLeade...

2017-12-13 Thread anmolnar
Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/432 @afine Generally the new test looks good to me, but would you please elaborate why the old test was flaky and how the new fixes that? ---

[jira] [Commented] (ZOOKEEPER-2953) Flaky Test: testNoLogBeforeLeaderEstablishment

2017-12-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16289276#comment-16289276 ] ASF GitHub Bot commented on ZOOKEEPER-2953: --- Github user anmolnar commented on a diff in the

[GitHub] zookeeper pull request #432: [WIP] ZOOKEEPER-2953: Flaky Test: testNoLogBefo...

2017-12-13 Thread anmolnar
Github user anmolnar commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/432#discussion_r156658012 --- Diff: src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerMainTest.java --- @@ -335,6 +336,100 @@ public void testHighestZxidJoinLate()

[GitHub] zookeeper pull request #432: [WIP] ZOOKEEPER-2953: Flaky Test: testNoLogBefo...

2017-12-13 Thread anmolnar
Github user anmolnar commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/432#discussion_r156657072 --- Diff: src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerMainTest.java --- @@ -335,6 +336,100 @@ public void testHighestZxidJoinLate()

[jira] [Commented] (ZOOKEEPER-2953) Flaky Test: testNoLogBeforeLeaderEstablishment

2017-12-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16289274#comment-16289274 ] ASF GitHub Bot commented on ZOOKEEPER-2953: --- Github user anmolnar commented on a diff in the

[jira] [Created] (ZOOKEEPER-2955) Enable Clover code coverage report

2017-12-13 Thread Mark Fenes (JIRA)
Mark Fenes created ZOOKEEPER-2955: - Summary: Enable Clover code coverage report Key: ZOOKEEPER-2955 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2955 Project: ZooKeeper Issue Type:

[jira] [Commented] (ZOOKEEPER-2953) Flaky Test: testNoLogBeforeLeaderEstablishment

2017-12-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16289943#comment-16289943 ] ASF GitHub Bot commented on ZOOKEEPER-2953: --- Github user anmolnar commented on the issue:

[jira] [Resolved] (ZOOKEEPER-2952) Upgrade third party libraries to address vulnerabilities

2017-12-13 Thread Patrick Hunt (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2952?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt resolved ZOOKEEPER-2952. - Resolution: Fixed Issue resolved by pull request 429

[GitHub] zookeeper issue #429: ZOOKEEPER-2952. Upgrade third party libs: netty, slf4j

2017-12-13 Thread phunt
Github user phunt commented on the issue: https://github.com/apache/zookeeper/pull/429 lgtm +1, thanks @anmolnar ---

[jira] [Commented] (ZOOKEEPER-2952) Upgrade third party libraries to address vulnerabilities

2017-12-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16290003#comment-16290003 ] ASF GitHub Bot commented on ZOOKEEPER-2952: --- Github user asfgit closed the pull request at:

[GitHub] zookeeper issue #435: ZOOKEEPER-2952. Upgrade third party libs: netty, slf4j...

2017-12-13 Thread phunt
Github user phunt commented on the issue: https://github.com/apache/zookeeper/pull/435 lgtm +1, thanks @anmolnar . Please close this one as it's not the default branch. ---

[jira] [Commented] (ZOOKEEPER-2338) c bindings should create socket's with SOCK_CLOEXEC to avoid fd leaks on fork/exec

2017-12-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16290016#comment-16290016 ] ASF GitHub Bot commented on ZOOKEEPER-2338: --- Github user phunt commented on a diff in the

[GitHub] zookeeper pull request #427: [ZOOKEEPER-2338] - set SOCK_CLOEXEC on socket i...

2017-12-13 Thread phunt
Github user phunt commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/427#discussion_r156801636 --- Diff: src/c/configure.ac --- @@ -130,18 +130,66 @@ main() else exit(0); } -], AC_MSG_RESULT(yes) - ipv6=yes, -

[jira] [Commented] (ZOOKEEPER-2338) c bindings should create socket's with SOCK_CLOEXEC to avoid fd leaks on fork/exec

2017-12-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16290026#comment-16290026 ] ASF GitHub Bot commented on ZOOKEEPER-2338: --- Github user phunt commented on a diff in the

ZooKeeper-trunk - Build # 3655 - Failure

2017-12-13 Thread Apache Jenkins Server
See https://builds.apache.org/job/ZooKeeper-trunk/3655/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 140.78 KB...] [junit] Running

[jira] [Commented] (ZOOKEEPER-2952) Upgrade third party libraries to address vulnerabilities

2017-12-13 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16290043#comment-16290043 ] Hudson commented on ZOOKEEPER-2952: --- FAILURE: Integrated in Jenkins build ZooKeeper-trunk #3655 (See

[GitHub] zookeeper issue #432: [WIP] ZOOKEEPER-2953: Flaky Test: testNoLogBeforeLeade...

2017-12-13 Thread anmolnar
Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/432 @afine got it ---

[GitHub] zookeeper pull request #432: [WIP] ZOOKEEPER-2953: Flaky Test: testNoLogBefo...

2017-12-13 Thread anmolnar
Github user anmolnar commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/432#discussion_r156793172 --- Diff: src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerMainTest.java --- @@ -335,6 +336,100 @@ public void testHighestZxidJoinLate()

[jira] [Commented] (ZOOKEEPER-2953) Flaky Test: testNoLogBeforeLeaderEstablishment

2017-12-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16289958#comment-16289958 ] ASF GitHub Bot commented on ZOOKEEPER-2953: --- Github user anmolnar commented on a diff in the

  1   2   >