Re: New PMC Member: Michael Han

2017-06-27 Thread Edward Ribeiro
​Congrat ​ulations ​, ​Mic ​hael! ​ ​Well d ​eserved ​!​ ​ ​ ​ ​ ​ ​ ​ On Tue, Jun 27, 2017 at 2:07 PM, Patrick Hunt wrote: > Kudos Michael, well deserved! > > Patrick > > On Tue, Jun 27, 2017 at 9:49 AM, Jordan Zimmerman < > jor...@jordanzimmerman.com> wrote: > > > Congrats! > > > > > On Jun 2

Re: Let's cut a ZK 3.4.11 release

2017-10-14 Thread Edward Ribeiro
+1 about cutting a new release. Edward On Fri, Oct 13, 2017 at 4:39 PM, Patrick Hunt wrote: > > Please note the subject line. I did that on purpose. ;-) > > That said I don't see why we couldn't have a 3.5.4-beta thereafter, the > hanging issues (e.g. what Jordan mentioned) is one of the reasons

Re: [ANNOUNCE] New ZooKeeper committer: Abraham Fine

2018-01-30 Thread Edward Ribeiro
Awesome news!!! I've been absent from ZK community for some time now (hopefully back soon), but even from afar I see Abe's has been pretty active and a driving force on the community. Congratulations, Abe! :) Edward Em 30 de jan de 2018 6:29 AM, "Andor Molnar" escreveu: > Great news! > > Congr

Re: [VOTE] Upgrade 3.5 and trunk to Java8

2018-03-24 Thread Edward Ribeiro
+1 (non-binding) On Sat, Mar 24, 2018 at 1:42 PM, Brian Nixon wrote: > +1 (non-binding) > > On Fri, Mar 23, 2018 at 2:15 AM, Mark Fenes wrote: > > > +1 > > > > > > On Thu, Mar 22, 2018 at 6:57 PM, Andor Molnar > wrote: > > > > > Hi all, > > > > > > Let's start the vote on upgrading to Java8. >

Re: Discover LEADER from JMX

2018-05-09 Thread Edward Ribeiro
Hi Enrico, Well, I am not an expert on QuorumPeer either (not an expert on anything, really), but maybe it's the variable and method below? - QuorumPeer -- /** * This is who I think the leader currently is. */ volatile private Vote currentVote; public synchroni

Re: Discover LEADER from JMX

2018-05-09 Thread Edward Ribeiro
} return leaderServer; } Edward On Wed, May 9, 2018 at 9:29 AM, Edward Ribeiro wrote: > Hi Enrico, > > Well, I am not an expert on QuorumPeer either (not an expert on anything, > really), but maybe it's the variable and method below? > > - QuorumPeer ---

Re: [SUGGESTION] JvmPauseMonitor in ZooKeeper

2018-05-09 Thread Edward Ribeiro
+1. Sounds really nice to have feature. Let's open a ticket and open a PR. :) Ed Em qua, 9 de mai de 2018 11:15, Norbert Kalmar escreveu: > Hi, > > I just got a tip that we could improve on the logging in ZooKeeper. After a > ZK crash, or client timeout sometimes it's hard to determine from the

Txn logs and snapshots in git repo

2018-05-09 Thread Edward Ribeiro
I am updating my local repo and noticed some transaction logs and snapshots files in src/java/test/data/invalidsnap/version-2. Are those files static data used by unit tests or just artifacts accidentally pushed to the repo? ls -lah src/java/test/data/invalidsnap/version-2/ total 936 drwxr-xr-x

Re: Txn logs and snapshots in git repo

2018-05-09 Thread Edward Ribeiro
Oh, nice. Thanks, Andor! Ed On Wed, May 9, 2018 at 1:52 PM, Andor Molnar wrote: > Hi Ed, > > Static data used by unit tests. > > Andor > > > > On Wed, May 9, 2018 at 9:46 AM, Edward Ribeiro > wrote: > > > I am updating my local repo and noticed some tra

Re: [VOTE] move Apache Zookeeper to git

2016-09-21 Thread Edward Ribeiro
vio > > > On 20 Sep 2016, at 18:57, Edward Ribeiro > wrote: > > > > Hey, I have started porting the kafka-merge.py to work on ZK repos. I > would > > need someone to review it and help me test it now. > > > > The files were uploaded below, but I will cre

Re: [VOTE] move Apache Zookeeper to git

2016-10-04 Thread Edward Ribeiro
ssociated patch file uploaded to JIRA. I've > > > checked > > > https://cwiki.apache.org/confluence/display/ZOOKEEPER/HowToContribute, > > > looks like there is not much change regarding patch process - so > > presumably > > > we still need to generate and upl

Re: [VOTE] move Apache Zookeeper to git

2016-10-05 Thread Edward Ribeiro
se parsing trouble for some mail clients. > > On Wed, Oct 5, 2016 at 6:42 AM, Flavio Junqueira wrote: > > > Dude, I'm just not able to parse your e-mail, did you write that on a > > phone or something? > > > > -Flavio > > > > > On 05 Oct 2016, at

Re: november 17, 2016 zookeeper meetup at facebook

2016-10-18 Thread Edward Ribeiro
There will be live streaming? :) Thanks, Edward On Tue, Oct 18, 2016 at 2:51 AM, Benjamin Reed wrote: > we would like to invite you all to a zookeeper meetup at the facebook > campus on november 17, 2016 starting at 5pm. > > please use the following link to the facebook event to get details and

Re: svn ref in build.xml

2016-10-19 Thread Edward Ribeiro
I guess Ben, may be refereing to these lines in build.xml: https://github.com/apache/zookeeper/blob/master/build.xml#L315-L341 If so, there's an issue that Arshad opened some time ago that is somewhat related to this: https://issues.apache.org/jira/browse/ZOOKEEPER-2573 On Wed, Oct 19, 2016 at

Re: [VOTE] move Apache Zookeeper to git

2016-10-26 Thread Edward Ribeiro
gt; > >> > > >> Can someone float me a link that says how to do this? > > >> > > >> Also a bunch of our documentation still discusses SVN and not git, > which > > >> means we are not done with this migration. If you were pushing for >

Re: [VOTE] move Apache Zookeeper to git

2016-10-26 Thread Edward Ribeiro
t;> comments made by git bot on ZOOKEEPER-761. Now it seems stop working. I > am > >> reopening INFRA-12752 and building a case. > >> > >> On Wed, Oct 26, 2016 at 9:45 AM, Edward Ribeiro < > edward.ribe...@gmail.com> > >> wrote: > >> >

QA github pre-commit queue

2016-10-27 Thread Edward Ribeiro
Dear community, As part of the github move, we are still lacking the plumbing that allows to run Jenkins CI tests, etc, on open Pull Requests. Please, take a look at Kafka pending PR at Github to see what I am referring to. Any committer could open an INFRA JIRA to address this? Best regards, Ed

Re: QA github pre-commit queue

2016-10-27 Thread Edward Ribeiro
; -Flavio > > > On 27 Oct 2016, at 16:54, Edward Ribeiro > wrote: > > > > Dear community, > > > > As part of the github move, we are still lacking the plumbing that allows > > to run Jenkins CI tests, etc, on open Pull Requests. Please, take a look > a

Re: QA github pre-commit queue

2016-10-31 Thread Edward Ribeiro
> >>>> qaed? > >>>> > >>>> > >>>> On Thu, Oct 27, 2016 at 12:04 PM, Michael Han > wrote: > >>>> > >>>>> Created PR94 to ZOOKEEPER-2014. It's been 2 hours, and no QA bot > >>>&g

Re: QA github pre-commit queue

2016-10-31 Thread Edward Ribeiro
My comments below: On Mon, Oct 31, 2016 at 4:07 PM, Flavio Junqueira wrote: > > Feel free to contribute to my changes and suggest a different way in the > jira. We can definitely work together on this, I just want to have this > working soon. > ​Ok. I don't want to slow down your current work i

Re: [DISCUSS] QA github pre-commit queue

2016-11-07 Thread Edward Ribeiro
I am +1 about having patches submitted via PRs. IMHO, we should disable the Jira QA altogether, but have the tool upload the *.patch file to Jira for archiving purposes. On Sun, Nov 6, 2016 at 6:42 PM, Raúl Gutiérrez Segalés wrote: > On 6 November 2016 at 11:54, Flavio Junqueira wrote: > > > ZO

Re: How to contribute with pull requests

2016-11-07 Thread Edward Ribeiro
Hi Flavio, I fixed made two small typos on the HowToContribute link, please see if you agree. Also, as the Github mirror is in sync with the Apache git repo, wouldn't it be the case of non-committers to use the Github URL instead of the official Apache one? A genuine question, I don't know what i

Re: Jenkins issue

2016-11-07 Thread Edward Ribeiro
Hi folks, A cursory look at the new Findbug issues highlighted mostly trivial, and a subtle but drastic change (IMHO): 1. Dodgy code warnings * 3/4 of the cases spotted are due to the File.listFiles() method that could return null if the abstract pathname does not denote a directory or if an I/

Re: [VOTE] move Apache Zookeeper to git

2016-11-09 Thread Edward Ribeiro
ithub+Pull+Requests > > specifically it's asking to "export JIRA_PASSWORD=mypassword" which I feel > very uncomfortable doing. > > Patrick > > On Wed, Oct 26, 2016 at 11:12 AM, Edward Ribeiro > > wrote: > > > AFAIK, yes. I say, if you mean to run

Re: [VOTE] move Apache Zookeeper to git

2016-11-10 Thread Edward Ribeiro
etc. Let me know if you have other ideas. I am open to other ways of incorporating the passing of JIRA_PASSWORD too. Edward On Wed, Nov 9, 2016 at 5:03 PM, Edward Ribeiro wrote: > Hi Patrick, > > We can change the script so that it asks for jira password input on CLI > prompt if th

Re: Merge script

2016-11-13 Thread Edward Ribeiro
+1 about using `sudo pip install jira`. The `sudo easy_install JIRA` is wrong because I should have put 'jira' (lowercase). The library is this one: https://pypi.python.org/pypi/jira/ Edward Em 13 de nov de 2016 10:13 PM, "Michael Han" escreveu: Would 'sudo pip install jira' work for you? On

Re: Merge script

2016-11-13 Thread Edward Ribeiro
al message wasn't clear. I did run `sudo pip install jira` and that's what didn't work. -Flavio > On 13 Nov 2016, at 16:31, Edward Ribeiro wrote: > > +1 about using `sudo pip install jira`. > > The `sudo easy_install JIRA` is wrong because I should have put 'jir

Re: Upcoming 3.4/3.5 releases.

2016-11-23 Thread Edward Ribeiro
Hi Patrick, AFAIK, related to git we have this one: https://issues.apache.org/jira/browse/ZOOKEEPER-2573 And its sibling, this one: https://github.com/apache/zookeeper/blob/master/build.xml#L316-L342 On Wed, Nov 23, 2016 at 3:39 PM, Patrick Hunt wrote: > Forgot to mention. These will be our

Re: [VOTE] move Apache Zookeeper to git

2016-11-24 Thread Edward Ribeiro
wiki.apache.org/confluence/display/ZOOKEEPER/Committing+changes > however I don't see a way to close the PR? https://github.com/apache/ > zookeeper/pull/103 says I don't have "write access". > > Patrick > > On Thu, Nov 10, 2016 at 10:23 AM, Edward Ribeiro &

Re: How to determine if the node is PERSISTENT & SEQUENTIAL

2016-11-30 Thread Edward Ribeiro
Hi, I don't know how stable and up to date it is, but did you take a look at Guano? https://github.com/d2fn/guano Edward Em 30 de nov de 2016 9:10 AM, "Xie Gang" escreveu: > Hi, > > I need to copy some zk nodes to some other place. But I need to skip those > sequence nodes. It seems that we co

Re: [VOTE] move Apache Zookeeper to git

2016-12-06 Thread Edward Ribeiro
tches any more" Edward On Mon, Dec 5, 2016 at 9:07 PM, Patrick Hunt wrote: > No problem Edward. Did you get any insight on what to do with the PR? > > Patrick > > On Thu, Nov 24, 2016 at 10:52 AM, Edward Ribeiro > > wrote: > > > Hi, Patrick, > > > &

Re: [VOTE] move Apache Zookeeper to git

2016-12-07 Thread Edward Ribeiro
On Wed, Dec 7, 2016 at 2:09 PM, Patrick Hunt wrote: > Interesting, thanks for the update Edward. > > "close via a dummy commit" - I don't think that's possible, doesn't GH > match up a PR to a commit based on the hash? > ​Afaik, yes. I didn't understand what he meant by 'dummy commit', tbqh. Gon

Re: [VOTE] move Apache Zookeeper to git

2016-12-07 Thread Edward Ribeiro
doesn't have relation with the PRs. Then GH will close those PRs. Edward On Wed, Dec 7, 2016 at 3:21 PM, Edward Ribeiro wrote: > > On Wed, Dec 7, 2016 at 2:09 PM, Patrick Hunt wrote: > >> Interesting, thanks for the update Edward. >> >> "close via a dummy com

Re: [ANNOUNCE] New ZooKeeper committer: Michael Han

2017-01-03 Thread Edward Ribeiro
Congratulations, Michael! Em 3 de jan de 2017 6:37 PM, "Marshall McMullen" < marshall.mcmul...@gmail.com> escreveu: > Congrats Michael! Well deserved. > > On Tue, Jan 3, 2017 at 1:16 PM, Abraham Fine wrote: > > > Congratulations Michael! > > > > On Tue, Jan 3, 2017, at 11:40, Jordan Zimmerman w

Re: Crash on detecting a corruption

2017-01-09 Thread Edward Ribeiro
Hi, I am not aware if this was a design decision, to be honest. AFAIK, this has been a long standing bug. :( I have compiled a handful of JIRA issues that are basically this problem scattered through multiple repetitive issues. Gonna aggregate them soon, I hope. We, the community, should raise the

Re: [jira] [Commented] (ZOOKEEPER-2447) Zookeeper adds good delay when one of the quorum host is not reachable

2016-06-29 Thread Edward Ribeiro
Hi Dan, The Apache JIRA is undergoing some issues (see here https://twitter.com/infrabot ) , but looks like it has come back. Would you mind to repost this message there? :) Cheers, Ed On Wed, Jun 29, 2016 at 5:46 PM, Dan Benediktson < dbenedikt...@twitter.com.invalid> wrote: > Apologies for s

Re: [VOTE] Apache ZooKeeper release 3.5.2-alpha candidate 1

2016-07-02 Thread Edward Ribeiro
+1 (non-binding) - built ZK from source - ran all the unit tests - generated and checked javadocs - generated and checked docs - executed few manual test (zkCli.sh) and 4lw Some small issues (imho): - the copyright notice is still dating "2008-2013". It's worth updating to the current year? - I

Re: RC1 issues (was: Re: [VOTE] Apache ZooKeeper release 3.5.2-alpha candidate 1)

2016-07-03 Thread Edward Ribeiro
Hi Flavio, On Sun, Jul 3, 2016 at 5:54 AM, Flavio Junqueira wrote: > Hey Eddie, > > A few comments on your points: > > > > > - the copyright notice is still dating "2008-2013". It's worth updating > to > > the current year? > > Where are you seeing this? The NOTICE file is correct from what I c

Re: Status: Apache ZooKeeper release 3.5.2-alpha candidate 1

2016-07-07 Thread Edward Ribeiro
NioNettySuiteTest failed on my dev box too. Edward Em 07/07/2016 12:40, "Camille Fournier" escreveu: > NioNettySuiteTest also regularly fails with this release. Can anyone > confirm if this is an env issue? > > On Thu, Jul 7, 2016 at 11:36 AM, Camille Fournier > wrote: > > > The NettyNettySuite

Re: [ANNOUNCE] Chris Nauroth joins the Apache ZooKeeper PMC

2016-08-08 Thread Edward Ribeiro
Congratulations, Chris! Em 7 de ago de 2016 11:09 PM, "Rakesh Radhakrishnan" escreveu: > Congratulations, Chris! > > Rakesh > > On Sun, Aug 7, 2016 at 11:35 PM, Flavio Junqueira wrote: > > > In recognition of all his contributions to the project, the Apache > > ZooKeeper PMC has invited Chris N

Re: ZOOKEEPER-2169

2016-08-18 Thread Edward Ribeiro
+1 (non binding) Very cool feature. Congratulations, Jordan! Em qui, 18 de ago de 2016 09:53, Jordan Zimmerman < jor...@jordanzimmerman.com> escreveu: > Any chance of getting https://issues.apache.org/jira/browse/ZOOKEEPER-2169 > merged? It has: > > * A patch that’s been reviewed > * 7 Votes > *

Re: switching to git?

2016-08-26 Thread Edward Ribeiro
+1 :+D Em 26 de ago de 2016 2:37 PM, "Raúl Gutiérrez Segalés" escreveu: > On 26 August 2016 at 10:35, Benjamin Reed wrote: > > > i'm starting to get back into zk development :) i'm a bit distressed that > > we are still using svn and patches managed by jiras. i've gotten > extremely > > spoiled

Re: [VOTE] move Apache Zookeeper to git

2016-09-01 Thread Edward Ribeiro
+1 (non binding) On Thu, Sep 1, 2016 at 3:44 AM, Jordan Zimmerman wrote: > +1 (non binding) > > > On Aug 31, 2016, at 8:29 PM, Benjamin Reed wrote: > > > > flip the switch to git and update the relevant scripts and docs. > > > > i couldn't figure out which timeframe this falls under in the voti

Re: [ANNOUNCE] Apache ZooKeeper 3.4.9

2016-09-05 Thread Edward Ribeiro
Hi, I have seen a couple of issues listed on http://zookeeper.apache.org/ doc/r3.4.9/releasenotes.html that are either 'Open' or 'Patch available'. I discover by accident because I will start working on the open one today. ;) https://issues.apache.org/jira/browse/ZOOKEEPER-2512 https://issues.ap

Re: [VOTE] move Apache Zookeeper to git

2016-09-07 Thread Edward Ribeiro
>> > >>> pat please make git happen! :) > >>> > >>> thanx for voting! > >>> > >>> On Thu, Sep 1, 2016 at 9:25 AM, Michael Han wrote: > >>> > >>>> +1 > >>>> > >>>> On Thu, Se

Re: [VOTE] move Apache Zookeeper to git

2016-09-13 Thread Edward Ribeiro
Hey, Flavio, I am with some sparing cycles this week (and genuinely curious about this integration between ASF git repo and Github's), so I can volunteer to pick up this. Could you or another committer guide me, please? :) Thanks, Edward On Tue, Sep 13, 2016 at 5:30 AM, Flavio Junqueira wrote:

Re: I need help to fix bugs

2016-09-14 Thread Edward Ribeiro
Hello Kazuaki, I've commented on ZOOKEEPER-2496. Please, check if the issues are indeed the same, so that we can get the help of any committer to review and merge Arshad's patch. Best regards, Eddie On Wed, Sep 14, 2016 at 9:27 AM, kazuaki banzai wrote: > Dear all, > > I have reported the bug

Re: [VOTE] move Apache Zookeeper to git

2016-09-20 Thread Edward Ribeiro
Just out of curiosity, what's the motivation behind getting rid of CHANGES.txt? Eddie On Mon, Sep 19, 2016 at 8:11 PM, Benjamin Reed wrote: > what you are suggesting sounds good, but i don't know how to do it? since > in the end we are still just accepting diffs on patches, the only thing > tha

Apache JIRA is down?

2016-09-20 Thread Edward Ribeiro
Looks like issues.apache.org is down. I have checked with http://downforeveryoneorjustme.com/issues.apache.org Eddie

Re: Apache JIRA is down?

2016-09-20 Thread Edward Ribeiro
Sorry, ignore previous message. It just came back. On Tue, Sep 20, 2016 at 9:47 AM, Edward Ribeiro wrote: > Looks like issues.apache.org is down. I have checked with > > http://downforeveryoneorjustme.com/issues.apache.org > > Eddie >

Re: Apache JIRA is down?

2016-09-20 Thread Edward Ribeiro
Thanks, bookmarked. :) On Tue, Sep 20, 2016 at 9:53 AM, Flavio Junqueira wrote: > Yeah seems to be back. You can check the status of ASF services here: > > https://status.apache.org <https://status.apache.org/> > > -Flavio > > > On 20 Sep 2016, at 13:49, Edward R

Re: [VOTE] move Apache Zookeeper to git

2016-09-20 Thread Edward Ribeiro
Hey, I have started porting the kafka-merge.py to work on ZK repos. I would need someone to review it and help me test it now. The files were uploaded below, but I will create a github repo yet today. https://www.dropbox.com/sh/od8bet2574jttm3/AADv1DXTb8vfyVCmelFbYCEha?dl=0 I uploaded the kafka

Re: Review Request 51546: ZOOKEEPER-2014: Only admin should be allowed to reconfig a cluster

2016-09-20 Thread Edward Ribeiro
e old grumpy java coder hat here, sorry. :) When we write a Java method that returns a boolean is a widely used practice to name it boolean isXXX(). So it would be nice to rename this method to: ``` isReconfigEnabled() ``` - Edward Ribeiro On Sept. 1, 2016, 4:24 p.m.,

Re: Question on merge script

2018-05-09 Thread Edward Ribeiro
FYI, the merge script was created in the Spark project then ported to Kafka project. And Kafka version was ported to ZK. :) Ed Em qua, 9 de mai de 2018 19:46, Patrick Hunt escreveu: > I believe we forked the script and the process/docs off another TLP, > perhaps spark or kafka? Might be worth c

Re: Apache ZooKeeper meetup May 9th in Palo Alto?

2018-05-11 Thread Edward Ribeiro
Oh, I missed the streaming. :( Was it recorded? The slides are available anywhere? On Thu, May 10, 2018 at 2:22 PM, Srikanth Viswanathan wrote: > Thanks for the presentations! Will the slides be posted somewhere? > > On Thu, May 10, 2018, 09:36 Prasanth Mathialagan < > prasanthmathiala...@gmail

Re: [ANNOUNCE] New ZooKeeper committer: Andor Molnar

2018-06-08 Thread Edward Ribeiro
Congratulations, Andor! :) E. Em sex, 8 de jun de 2018 10:48, Patrick Hunt escreveu: > The Apache ZooKeeper PMC recently extended committer karma to Andor and he > has accepted. Andor has made some great contributions and we are looking > forward to even more :) > > Congratulations and welcome

Re: DISCUSSION: Drop PDF support in documentation

2018-10-14 Thread Edward Ribeiro
+1 about dropping the PDF support. Edward On Fri, Oct 5, 2018 at 5:30 AM Norbert Kalmar wrote: > > Sounds logical to me, dropping pdf support / generation. > +1 > > On Thu, Oct 4, 2018 at 10:47 PM Michael Han wrote: > > > +1 on dropping support for PDF documents. Most if not all of the other >

Re: Zookeeper at Twitter by Micheal

2018-10-23 Thread Edward Ribeiro
Congrats, Michael, Really cool blog post. :) Em seg, 15 de out de 2018 05:26, Norbert Kalmar escreveu: > Good blog post! > Can't wait for the PRs ;) > I'm very positive about ZooKeeper's future (heard lot of talks lately about > etcd overthrowing ZooKeeper - no chance :) ) > > Norbert > > On Su

Re: [ANNOUNCE] New ZooKeeper committer: Fangmin Lv

2018-11-08 Thread Edward Ribeiro
Congratulations Fangmin! Edward Em qua, 7 de nov de 2018 22:35, Patrick Hunt Kudos Fangmin! > > Patrick > > On Wed, Nov 7, 2018 at 4:31 PM Michael Han wrote: > > > The Apache ZooKeeper PMC recently extended committer karma to Fangmin > > and he has accepted. Fangmin has made some great contribu

Re: ZooKeeper 3.4.10 release discussion

2017-01-13 Thread Edward Ribeiro
Hi Rakesh, Thansk for stepping up to this task! Pretty cool! :) Do you think https://issues.apache.org/jira/browse/ZOOKEEPER-2573 is worth targeting 3.4.10 too? Edward On Fri, Jan 13, 2017 at 7:56 AM, Rakesh Radhakrishnan wrote: > Hi All, > > I hope to cut an RC in a week - giving some more

Re: Anyone interested in learning about our QA build? (ZK-2665)

2017-01-16 Thread Edward Ribeiro
Okay, I left two days to anyone step up. You can count on me. :) Where/How do I start? Edward Em 14 de jan de 2017 3:39 PM, "Flavio Junqueira" escreveu: > If anyone wants to learn about our QA build, then working on > ZOOKEEPER-2665 might be a good task. It is not a difficult task as it is > ma

Re: Willing to Contribute to this Project

2017-01-18 Thread Edward Ribeiro
Um... gonna take a closer look on Curator soon, I hope. Thanks Jordan! On Tue, Jan 17, 2017 at 4:34 PM, Jordan Zimmerman < jor...@jordanzimmerman.com> wrote: > we have many Pull Requests that could use review: > https://github.com/apache/curator/pulls curator/pulls>

Re: [ANNOUNCE] New Apache ZooKeeper Committer: Mohammad Arshad

2017-01-21 Thread Edward Ribeiro
Congrats, Arshad! Super well deserved! :) Cheers, Eddie Em 21 de jan de 2017 11:25 AM, "Flavio Junqueira" escreveu: > The Apache ZooKeeper PMC has voted to offer committership to Arshad and he > accepted. Arshad has contributed significantly to this community in the > recent past, and we expect

Running a single unit test

2017-01-23 Thread Edward Ribeiro
Hello community, I am used to run a single unit test with the following command: ant -Dtestcase=CreateTest test where "-Dtestcase" especifies the test class name as described here: https://cwiki.apache.org/confluence/display/ZOOKEEPER/HowToContribute But for many months, I have seen that, after

Re: Running a single unit test

2017-01-23 Thread Edward Ribeiro
Nope. :( For what is worst: I remember it being able to run *only* a single test many years ago (~ 2012/2013). On Mon, Jan 23, 2017 at 5:16 PM, Michael Han wrote: > ant -Dtestcase=foobar test-core-java ? > > On Mon, Jan 23, 2017 at 11:04 AM, Edward Ribeiro > > wrote: > &

Re: Running a single unit test

2017-01-23 Thread Edward Ribeiro
ant - I ended up > > modifying makefile / test driver to do that instead. > > > > On Mon, Jan 23, 2017 at 11:31 AM, Edward Ribeiro < > edward.ribe...@gmail.com > > > wrote: > > > >> Nope. :( > >> > >> For what is worst: I remember

Re: Running a single unit test

2017-01-23 Thread Edward Ribeiro
nch. > > 2. ant -Dtestcase=WatchManagerPerf test-core-java > > I got what I expected. > > *junit.run-single:* > > *junit.run-concurrent:* > > * [echo] Running 1 concurrent JUnit processes.* > > *junit.run:* > > *test-core-java:* > > *BUILD SUCCESSFUL*

Re: ZooKeeper 3.4.10 release discussion

2017-01-26 Thread Edward Ribeiro
gt;>>>>> have focused only the branch related parts in cwiki and below > >>>> sections > >>>>>>> in > >>>>>>>> the page needed changes like, > >>>>>>>> > >>>>>>&

Re: ZooKeeper 3.4.10 release discussion

2017-01-27 Thread Edward Ribeiro
ur committers will > help in pushing it upstream. > > Thanks, > Rakesh > > On Thu, Jan 26, 2017 at 5:35 PM, Edward Ribeiro > wrote: > > > Hi, > > > > Rakesh and Flavio, what do you think about merging ZOOKEEPER-2622 to > > branch-3.4 and include it

Re: ZooKeeper 3.4.10 release discussion

2017-02-02 Thread Edward Ribeiro
converting all the applicable svn commands to git > commands in "HowToRelease using git" cwiki page. Welcome comments, thanks! > > https://cwiki.apache.org/confluence/display/ZOOKEEPER/ > HowToRelease+using+git > > Thanks, > Rakesh > > On Fri, Jan 27, 2017 at 1

Re: Graceful close of ZooKeeper client

2017-02-17 Thread Edward Ribeiro
Hey Enrico, I suggest you to get in touch with Jordan Zimmerman (here on the list) to make sure your proposed change doesn't break backwards compatibility. Jordan is creator of Curator, the best ZK lib out there, and an active member on this list. Cheers, Eddie On Thu, Feb 16, 2017 at 2:14 PM, E

Re: github merging?

2017-03-16 Thread Edward Ribeiro
Hi, it looks like an error on setuptools: http://stackoverflow.com/questions/41827464/pythong-pycparser-setup-error (the lib is different but the error is the same on lines) Eddie On Thu, Mar 16, 2017 at 1:58 PM, Camille Fournier wrote: > Thanks Michael I'll check and see if upgrading to 2.7.1

Re: [VOTE] Make 3.5.3 the first beta release.

2017-03-23 Thread Edward Ribeiro
+1 non binding On Thu, Mar 23, 2017 at 2:17 PM, Rakesh Radhakrishnan wrote: > +1 > > > Rakesh > > On Thu, Mar 23, 2017 at 10:41 PM, Jordan Zimmerman < > jor...@jordanzimmerman.com> wrote: > > > +1 non binding > > > > > > Jordan Zimmerman > > > > > On Mar 23, 2017, at 11:50 A

Re: ZOOKEEPER-900

2017-03-28 Thread Edward Ribeiro
Hi Atri, Comment on the issues themselves. It helps. Regards, Eddie On Tue, Mar 28, 2017 at 1:33 AM, Atri Sharma wrote: > Hi Patrick, > > I am fine with either. I tried pinging the owners but got no response. > > Please let me know. > > Regards, > > Atri > > On Tue, Mar 28, 2017 at 4:51 AM, Pa

Re: Introduce ZooKeeper flaky test dashboard

2017-04-11 Thread Edward Ribeiro
Very cool feature! Congratulations for initiative! :D Em 11 de abr de 2017 11:48 PM, "Jordan Zimmerman" < jor...@jordanzimmerman.com> escreveu: > Nice work - we could really use this on Curator. I'll be stealing this > soon ;D > > > On Apr 11, 2017, at 9:33 PM, Michael Han wrote: > > > > tl;dr >

Re: Graceful close of ZooKeeper client

2017-04-11 Thread Edward Ribeiro
Yup, it sounds great. :) PS: btw, congrats on new BK committer status. Em 11 de abr de 2017 9:21 AM, "Enrico Olivelli" escreveu: 2017-02-17 15:59 GMT+01:00 Edward Ribeiro : > Hey Enrico, > > I suggest you to get in touch with Jordan Zimmerman (here on the list) to > m

Re: [ANNOUNCE] New committer: Chris Nauroth

2015-09-28 Thread Edward Ribeiro
Congratulations, Chris!!! Best, Edward Em 28/09/2015 14:12, "Alexander Shraer" escreveu: > Congrats Chris, and welcome! > > On Mon, Sep 28, 2015 at 9:52 AM, Rakesh Radhakrishnan < > rakeshr.apa...@gmail.com> wrote: > > > Welcome Chris, thanks for all your great work and congrats! > > > > -Rakesh

Re: [VOTE] Apache ZooKeeper release 3.4.7 candidate 0

2015-11-16 Thread Edward Ribeiro
+1 (non binding) Compiled from sources, ran ant test on ubuntu 15.04, reviewed docs. Set up a small ensemble (3 nodes) and ran some zkcli commands and four letter words. Thanks Raul! Very nice work. Regards, Edward Em 15/11/2015 22:36, "Michi Mutsuzaki" escreveu: > +1 (binding) > > Thanks Raul

Re: Release planning for 3.5.0

2012-12-30 Thread Edward Ribeiro
Hi folks, a n00b speaking here. I have been working on ZOOKEEPER-1423 during the latest week and it's working like a charm. :) I only need to include tests, but I will be ready to upload the patch early this week, I guess. In addition, I have been worked on two zkCli related issues (ZOOKEEPER-153

Re: Review Request: ZOOKEEPER-1346: Handle 4lws and monitoring on separate port (creating jetty server)

2013-01-15 Thread Edward Ribeiro
<https://reviews.apache.org/r/8094/#comment33062> We may replace this line by: if (stats.getServerState().equals("leader") && zkServer instanceof LeaderZooKeeperServer) { so that you can get rid of the FindBugs message (2nd one). - Edward Ribeiro O

Re: Review Request: ZOOKEEPER-1346: Handle 4lws and monitoring on separate port (creating jetty server)

2013-01-15 Thread Edward Ribeiro
tps://reviews.apache.org/r/8094/#comment33063> You may use ephemerals.entrySet() instead of ephemerals.keySet() here and proceed accordingly. - Edward Ribeiro On Jan. 4, 2013, 2:17 a.m., Skye Wanderman-Milne wrote: > > ---

Re: Review Request: ZOOKEEPER-1346: Handle 4lws and monitoring on separate port (creating jetty server)

2013-01-15 Thread Edward Ribeiro
s = new HashSet(e.getValue()); sessionExpiryMap.put(time, ids); } Same behavior, less code. But it's just a suggestion, so please feel free to drop it (or point any error/misunderstanding of mine). - Edward Ribeiro On Jan. 4, 2013, 2:17 a.m., Skye W

Re: Review Request: ZOOKEEPER-1346: Handle 4lws and monitoring on separate port (creating jetty server)

2013-01-15 Thread Edward Ribeiro
tps://reviews.apache.org/r/8094/#comment33066> Replace "that that" by "whose". - Edward Ribeiro On Jan. 4, 2013, 2:17 a.m., Skye Wanderman-Milne wrote: > > --- > This is an automatically generat

Re: Review Request: ZOOKEEPER-1346: Handle 4lws and monitoring on separate port (creating jetty server)

2013-01-15 Thread Edward Ribeiro
tps://reviews.apache.org/r/8094/#comment33068> Replace "that that" by "whose" - Edward Ribeiro On Jan. 4, 2013, 2:17 a.m., Skye Wanderman-Milne wrote: > > --- > This is an automatically generat

Re: Review Request: ZOOKEEPER-1346: Handle 4lws and monitoring on separate port (creating jetty server)

2013-01-15 Thread Edward Ribeiro
id, paths); } - Edward Ribeiro On Jan. 4, 2013, 2:17 a.m., Skye Wanderman-Milne wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://revi

Re: Review Request: ZOOKEEPER-1346: Handle 4lws and monitoring on separate port (creating jetty server)

2013-01-15 Thread Edward Ribeiro
(as everything I wrote before). Please, compare these suggestions with your original code to see if it's correct *and* worth rewrite. - Edward Ribeiro On Jan. 4, 2013, 2:17 a.m., Skye Wanderman-Milne wrote: > > --- > This is

Re: Review Request: ZOOKEEPER-1346: Handle 4lws and monitoring on separate port (creating jetty server)

2013-01-17 Thread Edward Ribeiro
<https://reviews.apache.org/r/8094/#comment7> Would you mind to make this lines 57 and 58 "final" too? Just a suggestion, but otherwise I think that this patch is ready to ship. Congratulations on the good work. :) - Edward Ribeiro On Jan. 17, 2013, 2:01 a.m., Skye

Re: Review Request: ZOOKEEPER-1346: Handle 4lws and monitoring on separate port (creating jetty server)

2013-01-17 Thread Edward Ribeiro
/JettyAdminServerTest.java <https://reviews.apache.org/r/8094/#comment33411> Add Apache license (Jenkins alert). - Edward Ribeiro On Jan. 17, 2013, 2:01 a.m., Skye Wanderman-Milne wrote: > > --- > This is an automatically generated e

Re: Review Request: QuorumPeer should unregister only its previsously registered MBeans instead of use MBeanRegistry.unregisterAll() method.

2013-01-20 Thread Edward Ribeiro
bleSet(mapBean2Path.keySet()); // returns a live view I prefer the 1st one, but let you decide. - Edward Ribeiro On Jan. 13, 2012, 12:10 p.m., César Álvarez Núñez wrote: > > --- > This is an automatically generated e

Re: Review Request: ZOOKEEPER-1346: Handle 4lws and monitoring on separate port (creating jetty server)

2013-01-21 Thread Edward Ribeiro
> On Jan. 17, 2013, 11:53 p.m., Edward Ribeiro wrote: > > src/java/test/org/apache/zookeeper/server/admin/JettyAdminServerTest.java, > > line 1 > > <https://reviews.apache.org/r/8094/diff/5/?file=249522#file249522line1> > > > > Add Apache license (J

Re: Review Request: Dynamic reconfiguration, see https://issues.apache.org/jira/browse/ZOOKEEPER-107

2013-01-22 Thread Edward Ribeiro
values). - Edward Ribeiro On Nov. 29, 2012, 7:12 a.m., Alexander Shraer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews

Re: Review Request: Dynamic reconfiguration, see https://issues.apache.org/jira/browse/ZOOKEEPER-107

2013-01-22 Thread Edward Ribeiro
start addressing this issue in this patch and eventually open a JIRA to address the remaining cases. A user has opened a issue recently to address client-side (ZOOKEEPER-1619), but as far as I looked for, it affects the server side too. :( - Edward Ribeiro On Nov. 29, 201

Re: Review Request: Dynamic reconfiguration, see https://issues.apache.org/jira/browse/ZOOKEEPER-107

2013-01-22 Thread Edward Ribeiro
etLeavingServers()); PS: I think this split method should go in a helper class as stated before. - Edward Ribeiro On Nov. 29, 2012, 7:12 a.m., Alexander Shraer wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request: Dynamic reconfiguration, see https://issues.apache.org/jira/browse/ZOOKEEPER-107

2013-01-22 Thread Edward Ribeiro
he latter is more readable, but it's just my opinion. - Edward Ribeiro On Nov. 29, 2012, 7:12 a.m., Alexander Shraer wrote: > > --- > This is an automatically generated e-mail. To repl

Re: Review Request: Dynamic reconfiguration, see https://issues.apache.org/jira/browse/ZOOKEEPER-107

2013-01-22 Thread Edward Ribeiro
/PrepRequestProcessor.java <https://reviews.apache.org/r/6707/#comment33711> Read comment on line 492. - Edward Ribeiro On Nov. 29, 2012, 7:12 a.m., Alexander Shraer wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Review Request: Dynamic reconfiguration, see https://issues.apache.org/jira/browse/ZOOKEEPER-107

2013-01-22 Thread Edward Ribeiro
/PrepRequestProcessor.java <https://reviews.apache.org/r/6707/#comment33712> Lines 500-504 are a parsing logic that obfuscate the core logic of this part of the code. I suggest to extract these lines to a parse method that could return an array with two slots, for example, to be used at line 505. - Edward R

Re: Review Request: ZOOKEEPER-1147: Add support for local sessions

2013-01-24 Thread Edward Ribeiro
tps://reviews.apache.org/r/8935/#comment33773> Wouldn't be the case of adding a "return false" after line 81? - Edward Ribeiro On Jan. 14, 2013, 11:48 p.m., Thawan Kooburat wrote: > > --- > This is an auto

Re: Review Request: ZOOKEEPER-1147: Add support for local sessions

2013-01-27 Thread Edward Ribeiro
ce to pass interfaces makes the code easier to change in the future, and it's best practice. - Edward Ribeiro On Jan. 14, 2013, 11:48 p.m., Thawan Kooburat wrote: > > --- > This is an automatically generated e-mail.

Re: DataTree

2013-02-14 Thread Edward Ribeiro
Cool. I was thinking about something along the lines of Collections.newSetFromMap(new ConcurrentHashMap<...>()) too, so that it'd possible to get rid of synchronized like you did. Another point would be the use of Guava's Multimaps, but then it would loose the benefits of ConcurrentMap. Thanks fo

Re: Storing znode on disks

2013-03-14 Thread Edward Ribeiro
>> For me, latency is acceptable but I require the znodes to be on disk. Why would you need to do that? ZooKeeper stores the dataTree in memory, but it performs periodic snapshots to disk, besides sync-ing a commit log also to disk, so that a node can recover in case of failures. If you are aski

  1   2   3   4   5   6   >