Re: [ANNOUNCE] Apache ZooKeeper 3.4.14

2019-04-02 Thread Justin Ling Mao
Awesome!!! - Original Message - From: Andor Molnar To: DevZooKeeper , u...@zookeeper.apache.org Subject: [ANNOUNCE] Apache ZooKeeper 3.4.14 Date: 2019-04-02 18:32 The Apache ZooKeeper team is proud to announce Apache ZooKeeper version 3.4.14 ZooKeeper is a high-performance coordination

Re: [VOTE] Apache ZooKeeper release 3.5.5 candidate 1

2019-04-03 Thread Justin Ling Mao
A good news!!! A long time to have a stable version. I volunteer to do the following test this weekend. 1.a jepsen test to check the consistency. 2.a namazu fuzzy test to check the stablibity.(which will doc this test tool in ZOOKEEPER-3343.). 3.a test for the zkCli.sh

Re: Re: Re: [VOTE] Apache ZooKeeper release 3.5.5 candidate 2

2019-04-08 Thread Justin Ling Mao
: Re: Re: [VOTE] Apache ZooKeeper release 3.5.5 candidate 2 Date: 2019-04-08 12:24 On Sat, Apr 6, 2019 at 11:47 PM Justin Ling Mao wrote: Test for the 3.5.5 candidate 2: -[0]: Jepsen consistency check had passed. +1. Look at the attachment: jepsen_test_report.txt. how to use it: ht

回复:Travis is Up an running

2019-02-24 Thread Justin Ling Mao
Awesome work,Thanks Enrico! - 原始邮件 - 发件人:Enrico Olivelli 收件人:DevZooKeeper 主题:Travis is Up an running 日期:2019年02月22日 23点42分 Hi folks, Andor merged the patch about Travis configuration, let me recap the status quo about Pull Requests. 1) We are using Travis to test the build on JDK8 and

Re: Re: Question on ZK commit/patch policy.

2019-03-05 Thread Justin Ling Mao
agree with this from Brian Nixon.--->"For trivial changes like spelling, whitespace, pruning of import, does itmake sense to have one super/umbrella ticket with multiple PRs attached" - Original Message -From: Brian Nixon To: dev@zookeeper.apache.org Subject: Re: Question on ZK

Re: Re: Apache ZooKeeper meetup in Palo Alto March 14th

2019-03-11 Thread Justin Ling Mao
If your guys have speechs on some interesting topics, Plz video it, then post to the youtube,share with us. :D - Original Message -From: Jie Huang To: dev@zookeeper.apache.org Subject: Re: Apache ZooKeeper meetup in Palo Alto March 14th Date: 2019-03-12 04:48 Hi, Patric Are we still on

Re: Re: datalength 0

2019-03-11 Thread Justin Ling Mao
. my child znodes under /hbase/tables are all have data. they are multiple tables under neath.. despite that datalength 0. Don't quite understand your explanation. Can you please elaborate?Thanks,Asim On Sun, Mar 10, 2019 at 7:58 PM Justin Ling Mao wrote: --->"I see data length

Re: Re: Jute buffer size increasing.

2019-03-10 Thread Justin Ling Mao
- What's your user case using zk for hbase? Why increase jute.maxbuffer to 128MB? incredible! really need this change?- if the jute.maxbuffer is too large, it will have a side effect on the stability and throughout of the cluster,the response time between server and client.- for the "jmap

Re: datalength 0

2019-03-10 Thread Justin Ling Mao
--->"I see data length of 0 on my znodes?" becasue the data of this node "/hbase/table" is empty check this: [zk: localhost:2181(CONNECTED) 2] get /hbase/table--->"timestamps are also not updating" set the data,the mtime will be updated. e.g [zk: localhost:2181(CONNECTED) 5] set /hbase/table

Re: Re: Re: Jute buffer size increasing.

2019-03-12 Thread Justin Ling Mao
te buffer we are saying significant stability. Can you explain he logic behind jute buffer and instability that you were seeing, I was not able to find a good resources to relate that level of detail so it will be extremely helpful if you can explain. On Sun, Mar 10, 2019 at 7:26 PM Justin Ling Mao

回复:A big refactor for the documetations

2019-02-13 Thread Justin Ling Mao
ping @anmolnar and others, any insights or suggestions ? - 原始邮件 -发件人:"Justin Ling Mao" 收件人:"dev" 主题:A big refactor for the documetations 日期:2019年02月12日 11点50分 Hi gugs:I'am working on doing a big refactor for the documetations.it aims to - 1.make a better reading

回复:回复:Re: A big refactor for the documetations

2019-02-13 Thread Justin Ling Mao
guess people got used to it :) But I'm not against it either. So definitely +1 on adding new stuff and example, and I'm neutral on the changing the doc format part. It has its pros and cons. Regards,Norbert On Wed, Feb 13, 2019 at 2:48 PM Justin Ling Mao wrote: ping @anmolnar and others, any insig

A big refactor for the documetations

2019-02-11 Thread Justin Ling Mao
Hi gugs:I'am working on doing a big refactor for the documetations.it aims to - 1.make a better reading experiences and help users know more about zookeeper quickly,as good as other projects' doc(e.g redis,hbase). - 2.have less changes to diff with the original docs as far as possible. -

Re: ZK Smoke Screen Test

2019-04-13 Thread Justin Ling Mao
Good job,Thanks for this:https://github.com/BELUGABEHR/zk-smoketest#running-under-dockerYou can give a PR to phunt's repo,let more people benefit from it.Look at ZOOKEEPER-3264 which is aimed to implement a better benchmark tool for zookeeper internal.Stay tuned! :D - Original Message

Re: Re: [VOTE] Apache ZooKeeper release 3.5.5 candidate 3

2019-04-13 Thread Justin Ling Mao
+1, no bindingLook at my previous jepsen, benchmark and zkCli test, 3.5.5 works well. - Original Message - From: Andor Molnar To: DevZooKeeper Subject: Re: [VOTE] Apache ZooKeeper release 3.5.5 candidate 3 Date: 2019-04-12 19:58 Hi team, Just to wrap up the votes so far: We got +1 from

Clean up the all the checkstyle violations in the zookeeper-server module

2019-06-23 Thread Justin Ling Mao
Background:zookeeper-server is the main-module of the zk codebase. Unfortunately, there were many checkstyle violations in it. To improve the code quality and code standards, IMHO, it's time to clean up the all the checkstyle violations(turn on the true). we can learn from the hbase whose

Re: Re: Request for review & contribution of Apache Training

2019-04-27 Thread Justin Ling Mao
@Lars.Thanks for this:https://drive.google.com/file/d/1STmz-nTBjGeFuu8ycjrFDSL-KdahAQiG/view - Original Message - From: Flavio Junqueira To: dev@zookeeper.apache.org Cc: Patrick Hunt Subject: Re: Request for review & contribution of Apache Training Date: 2019-04-28 03:10 This is

Re: [Suggestion] Use Co-authored-by in commit messages

2019-05-08 Thread Justin Ling Mao
+1,A very good Suggestion.Thanks Norbert.I also suggest about the sign-off of the Reviewers' name.For the incentive, if someone participate in the review of PR, no matter whether he/she is a committer, we all need include his/her name? - Original Message - From: Norbert Kalmar To:

Re: Re: Great talk from Ben Reed about the origins of ZooKeeper

2019-07-05 Thread Justin Ling Mao
A great video,Thanks for the share. - Original Message - From: Brian Nixon To: dev@zookeeper.apache.org Cc: UserZooKeeper Subject: Re: Great talk from Ben Reed about the origins of ZooKeeper Date: 2019-06-30 02:11 It's great to hear the mindset that the ZooKeeper team was applying in

Re: Zookeeper code optimization

2019-07-05 Thread Justin Ling Mao
A good code optimizationCould you plz help us improve this issue?The contributor guideline is [here](https://cwiki.apache.org/confluence/display/ZOOKEEPER/HowToContribute]) - Original Message - From: 18779116352 <18779116...@163.com> To: dev Subject: Zookeeper code optimization Date:

Re: Re: Clean up the all the checkstyle violations in the zookeeper-server module

2019-07-06 Thread Justin Ling Mao
;>>>> Norbert > > >>>>> > > >>>>> > > >>>>> On Sun, Jun 23, 2019 at 7:27 PM Enrico Olivelli < > eolive...@gmail.com > > >>> > > >>>>> wrote: > > >>>>> > > >

The ZooKeeper Grafana dashboard is now available

2019-07-09 Thread Justin Ling Mao
- Due to the work from ZOOKEEPER-3447(https://github.com/apache/zookeeper/pull/1008), the ZooKeeper Grafana dashboard is now available(https://grafana.com/dashboards/10465) which I had included some screenshots for the preview. - Users can ask for this Grafana dashboard account if having any

Re: [patch] use zookeeper-client-c has some link problems

2019-07-09 Thread Justin Ling Mao
1.--->"I fixed it in a simple way and it looks fine." 1.1 how did you solve this issue? 1.2 It‘s a issue about your demo(may be a link or dependencies error)? not about the zookeeper c client? 2. Could you please tell me how to compile and build the zookeeper c client in the

Re: Discuss on enabling checkstyle rules

2019-06-29 Thread Justin Ling Mao
I also got no reply from the email, but when checking the email archive(https://lists.apache.org/list.html?dev@zookeeper.apache.org) I found the reply from the community.It's very strange!!! @Zili Chen Let us discuss in that thread? After reading all the replies, I will give my new opinion and

Re: Re: Re: Re: Clean up the all the checkstyle violations in the zookeeper-server module

2019-07-15 Thread Justin Ling Mao
- any advance for the discussion???- any objections about these two things: 1.only clean the main-module:zookeeper-server; 2.using the google's checkstyle_style?- who will head it up? how about me? - Original Message - From: "Justin Ling Mao" To: "dev" Subject:

Re: Re: Time to think about a 3.6.0 release?

2019-07-15 Thread Justin Ling Mao
- 1.Since the 3.5.5 has just released in May. we still need some time to collect the users' feedback.we cannot make sure the release time of 3.6.0? Giving the experience from the previous release history:)- 2.please Let me share some my thoughts, and the work in progress will be arriving into

Re: Prometheus.io endpoint vs admin server

2019-04-24 Thread Justin Ling Mao
@Enrico1. --->"bind '/metrics' to the current "Admin server"" What do you mean is the JettyAdminServer? which is enable and binding to default port:8080? 2. Is the following a good option?e.g:http://:8080/commands/metricsor:http://:8080/metrics - Original Message - From: Enrico

Re: Raise the Quality of ZooKeeper Docs with Google Season of Docs Project

2019-04-24 Thread Justin Ling Mao
Thanks Fangmin for bringing up this interesting topic.maybe next year, maybe no time,maybe nobody· :D - Original Message - From: Fangmin Lv To: dev@zookeeper.apache.org Subject: Raise the Quality of ZooKeeper Docs with Google Season of Docs Project Date: 2019-04-24 06:23 Hi guy,

Re: Re: Re: Time to think about a 3.6.0 release?

2019-07-16 Thread Justin Ling Mao
ptember Enrico Il lun 15 lug 2019, 11:55 Justin Ling Mao ha scritto: > - 1.Since the 3.5.5 has just released in May. we still need some time to > collect the users' feedback.we cannot make sure the release time of 3.6.0? > Giving the experience from the previous release history:)

Re: Re: Re: Re: Re: Clean up the all the checkstyle violations in the zookeeper-server module

2019-07-16 Thread Justin Ling Mao
on zookeeper-server Subtask-3: Enable Google checkstyle configuration on zookeeper-jute Subtask-4: Enable Google checkstyle configuration on zookeeper-prometheus ... Best,tison. Enrico Olivelli 于2019年7月16日周二 上午12:06写道: Il lun 15 lug 2019, 09:14 Justin Ling Mao ha scritto: &g

Re: Upgrade FAQ

2019-08-20 Thread Justin Ling Mao
@andor IMHO, we need a documentation about how to do the rolling-upgrade between different release in the code base. Am I right? - Original Message - From: Andor Molnar To: DevZooKeeper Subject: Upgrade FAQ Date: 2019-08-16 23:39 Hi, I’ve created the following FAQ page on the wiki to

Re: Re: Consistency Guarantees

2019-08-25 Thread Justin Ling Mao
@Karolos Thanks for this interesting discussion.Let me quote some words from the Book:《Designing Data-Intensive Applications》Martin Kleppmann. If you have more interested in this topic, have a fun to read the CHAPTER 9:Consistency and Consensus--->"While this procedure ensures linearizable

Re: Re: Cutting Zookeeper 3.5.6

2019-09-02 Thread Justin Ling Mao
awesome!!!. Looking forward to this release. - Original Message - From: Andor Molnar To: DevZooKeeper Subject: Re: Cutting Zookeeper 3.5.6 Date: 2019-09-02 00:28 Great +1 On Thu, Aug 29, 2019 at 4:37 PM Enrico Olivelli wrote: > Hello, > I am going to cut 3.5.6, if you have patches to

Re: Re: Re: Clean up the all the checkstyle violations in the zookeeper-server module

2019-07-19 Thread Justin Ling Mao
ng that checkstyle config, I feel we won't have so many > > > violations. > > > > > > We can keep current checkstyle invokation that checks for @author tags > > as a > > > separate 'execution' of the plugin with a specific checkstyle file (as > &

Re: Re: complete quota system proposal

2019-07-22 Thread Justin Ling Mao
1. IMHO, before that work, we need to merge the ZOOKEEPER-3301(https://github.com/apache/zookeeper/pull/934) firstly(:D) which has a good expansibility to the quota storage and support the soft/hard quota limit and some good refactors and utils for the quota. 2.In the ZOOKEEPER-1383, Thawan

Re: PoweredBy Zookeeper

2019-09-24 Thread Justin Ling Mao
1.Thanks Olivelli for this letter. ZOOKEEPER-3529 has now landed. 1.1 The references may be a good reading material and they're are public and free. welcome scrutiny. 1.2 The documentation has a declaration about intellectual property rights and privacy.2 If you have a use case, please do

Re: Re: Re: Clean up the all the checkstyle violations in the zookeeper-server module

2019-07-07 Thread Justin Ling Mao
ith a specific checkstyle file (as > you > > already said) > > > > I am happy to help, thank you for driving this effort > > > > Enrico > > > > > > Il sab 6 lug 2019, 11:33 Justin Ling Mao ha > > scritto: > > > > > - 1.It se

Re: Re: ZK makes apache 2019 "top 5" projects

2019-12-12 Thread Justin Ling Mao
https://www.cbronline.com/list/top-five-apache-software-projects-in-2019Chinese users can visit this due to GFW :) - Original Message - From: tison To: u...@zookeeper.apache.org Cc: DevZooKeeper Subject: Re: ZK makes apache 2019 "top 5" projects Date: 2019-12-12 19:53 Kudos! Best,

Re: Re: Hadoop logo

2019-12-12 Thread Justin Ling Mao
+1, I have created a ticket for this: https://issues.apache.org/jira/browse/ZOOKEEPER-3648. If someone is interested in, please pick it ip. BTW: the github project description(Mirror of Apache Hadoop ZooKeeper) may also needs a update. - Original Message - From: Michael Han To:

Re: Re: Coding Style

2019-10-07 Thread Justin Ling Mao
this:https://github.com/apache/hbase/blob/master/dev-support/hbase_eclipse_formatter.xml 3. Overall, this work is not in a hurry because mvn cmd can tell us where is the violations - Original Message - From: Zili Chen To: Justin Ling Mao Cc: dev Subject: Re: Coding Style Date: 2019-10

Re: Coding Style

2019-10-07 Thread Justin Ling Mao
1. Currently, our coding style checker(maven checkstyle plugin) doesn't abide by Sun's conventions completely 2. maybe we need a eclipse_formatter.xml to the automatic formatting for the IDEs, https://hbase.apache.org/book.html#eclipse.code.formatting is a good example. - Original Message

Re: Re: [ANNOUNCE] New ZooKeeper committer: Brian Nixon

2019-10-03 Thread Justin Ling Mao
congrats Brian, well-deserved. - Original Message - From: Enrico Olivelli To: DevZooKeeper Subject: Re: [ANNOUNCE] New ZooKeeper committer: Brian Nixon Date: 2019-10-02 18:23 Yeah, congrats Brian, welcome aboard ! Enrico Il giorno mer 2 ott 2019 alle ore 11:15 Zili Chen ha scritto: >

Re: Re: Re: Re: Re: [VOTE] Apache ZooKeeper release 3.5.6 candidate 4

2019-10-14 Thread Justin Ling Mao
+1 (non-binding)A benchmark test for 3.5.6 candidate 4 with YCSB tool: Machine Env:my local(8core,16G, 256SSD) ZooKeeper Env: 3.5.6-c11b7e26bc554b8523dc929761dd28808913f091, built on 10/08/2019 20:18 GMTstandalone mode(one zk server); 100 znodes; data length(per znode):100;default

Re: Re: My Contributions

2020-02-06 Thread Justin Ling Mao
David, highly appreciated your contributions. Looking forward to more. Please go ahead! - Original Message - From: Norbert Kalmar To: DevZooKeeper Subject: Re: My Contributions Date: 2020-02-03 18:34 Hi David, Thanks for your contributions! We consider the patch committed if it should

Re: Re: Jepsen.io report

2020-02-20 Thread Justin Ling Mao
Actually, we have a doc about how to test zookeeper with jepsen(https://github.com/apache/zookeeper/blob/master/zookeeper-docs/src/main/resources/markdown/zookeeperTools.md#jepsen-test) Jepsen had not found any bugs recently? We needs to redo that Jepsen test after we have a linearizability read

2019 year-end review

2020-01-03 Thread Justin Ling Mao
Hi zk guys: Happy New Year, Good luck to your 2020. IMHO it's a good time to look back the community work of the past year(2019) at the beginning of this new year. Forgive my this letter, please let me share some my private and humble observations. In retrospect 2019, these new things have

Re: Re: Pending issue for 3.6.0

2019-12-24 Thread Justin Ling Mao
---> "This is my point of view: Patch 1) introduces wire protocol changes (new RC), it is a big work and we are not ready to ship it, so I would defer to 3.7.0." Agree with this. Stability is much more import than including more features/improvements at the birth of this release. -

Re: Re: Cutting 3.6.1 HEADS UP !

2020-04-25 Thread Justin Ling Mao
I found ZOOKEEPER-3807. lots of bad formats in the website pages build due to bash marker. It's my blame.Do we need to apply it to 3.6.1 ? - Original Message - From: Christopher To: dev@zookeeper.apache.org Subject: Re: Cutting 3.6.1 HEADS UP ! Date: 2020-04-17 13:27 Okay, I found the

Re: Re: Re: Sequential Consistency Guarantees

2020-09-03 Thread Justin Ling Mao
@ Stanislav Thanks for giving an example to help us to get your idea quickly. Just as Ted said, If C read 0x1112209 at t4, we have a guarantee to read v1(0x1112208), not possible to read v0 (0x1112207) Since the write is linearizable, all the writes are ordered with a monotonically

Re: Containerizing ZooKeeper with Twine: Powering container orchestration from within

2020-09-04 Thread Justin Ling Mao
Great blog post!!! - Original Message - From: Mohamed Jeelani To: "dev@zookeeper.apache.org" Cc: Christopher Bunn Subject: Containerizing ZooKeeper with Twine: Powering container orchestration from within Date: 2020-09-01 03:43 Hi ZooKeepers! Hello from your friends here at Facebook.

Re: Re: hacktoberfest

2020-10-14 Thread Justin Ling Mao
That's really cool. I saw the zookeeper had already joined the Hacktoberfest event(https://github.com/topics/hacktoberfest). You can login in (https://hacktoberfest.digitalocean.com/login) with your github account and enjoy yourself Note: you must register and make four valid pull requests (PRs)

Re: Re: Sequential Consistency Guarantees

2020-08-28 Thread Justin Ling Mao
---> if a client creates a node with zxid 0x11122a, it should be able to see (read) all data changes at least up to that zxid. You may have a misunderstanding on what sequential consistency guarantees. For your example: Suppose that you have following operations: create /mypath v0

Re: Re: May violate the ZAB agreement -- version 3.6.1

2020-08-28 Thread Justin Ling Mao
@李珣The situation you describe may have conceptual deviations about how the consensus protocol works:---> Since the data of the follower when the follower uses the DIFF method to synchronize with the leader is still in the memory, it has not had time to persist1. The write path is: write

Re: Grafana dashboard, update?

2020-07-22 Thread Justin Ling Mao
Yes, I'm here. The only supported data source currently is Prometheus. Do you want us to support Influxdb as data source? - Original Message - From: Simon Karberg To: dev@zookeeper.apache.org Subject: Grafana dashboard, update? Date: 2020-07-21 01:24 Hi, I have tried to import the

Re: Re: Re: Re: Re: Re: Grafana dashboard, update?

2020-08-03 Thread Justin Ling Mao
rom: Simon Karberg To: maoling199210...@sina.com Cc: dev Subject: Re: Re: Re: Re: Re: Grafana dashboard, update? Date: 2020-08-03 16:17 Thanks, it looks amazing already. Are there any documentation on what to alert on, related to Zookeeper? On Mon, Aug 3, 2020 at 4:33 AM Justin Ling Mao wr

Re: Re: Re: Re: Re: Re: Re: Grafana dashboard, update?

2020-08-08 Thread Justin Ling Mao
@simon.karberg For alerting documentation, please look at this(https://github.com/apache/zookeeper/pull/1425) - Original Message - From: "Justin Ling Mao" To: "dev" , "simon.karberg" , Subject: Re: Re: Re: Re: Re: Re: Grafana dashboard, update? Date: 2020-

Re: Re: Re: Re: Re: Grafana dashboard, update?

2020-08-02 Thread Justin Ling Mao
- From: Simon Karberg To: maoling199210...@sina.com Cc: dev Subject: Re: Re: Re: Re: Grafana dashboard, update? Date: 2020-07-29 15:46 Great, I will be ready to add it to our grafana on Monday then :) On Wed, Jul 29, 2020 at 9:45 AM Justin Ling Mao wrote: @Simon KarbergWhat a shame for me to do

Re: Re: Re: Grafana dashboard, update?

2020-07-24 Thread Justin Ling Mao
for your great suggestions - Original Message - From: Simon Karberg To: maoling199210...@sina.com Cc: dev Subject: Re: Re: Grafana dashboard, update? Date: 2020-07-24 15:29 Hi, I don't have that option in the dashboard ( 10465 ) :) On Fri, Jul 24, 2020 at 5:16 AM Justin Ling Mao wrote

Re: Re: Re: Re: Grafana dashboard, update?

2020-07-29 Thread Justin Ling Mao
Cc: dev Subject: Re: Re: Re: Grafana dashboard, update? Date: 2020-07-27 06:17 Your welcome and thanks for the good work, i can imagine it takes time to create such dashboards. On Sat, Jul 25, 2020 at 7:57 AM Justin Ling Mao wrote: > 1. Yes, v3 doesn't have that option. I have done this funct

The YCSB benchmark tool for zookeeper is now available

2020-12-13 Thread Justin Ling Mao
Now users can benchmark your zookeeper ensemble with YCSB. Here is the ZK-PR(https://github.com/apache/zookeeper/pull/1558). Have fun for it:)

Re: Re: Rate Quota

2021-01-22 Thread Justin Ling Mao
Here is a initial roadmap about the quote feature(https://cwiki.apache.org/confluence/display/ZOOKEEPER/Quotas). We will nudge this work continuously. Here is the FB's video.(https://www.facebook.com/zkmeetup/videos/2984998221531756/) - Original Message - From: Huizhi Lu To:

Re: Re: [VOTE] Apache ZooKeeper release 3.7.0 candidate 0

2021-01-22 Thread Justin Ling Mao
I create the ticket: ZOOKEEPER-4188: add a doc about whoami CLI for me to do. It's not a blocker. Let's go ahead:) - Original Message - From: Patrick Hunt To: DevZooKeeper Subject: Re: [VOTE] Apache ZooKeeper release 3.7.0 candidate 0 Date: 2021-01-23 05:09 +1 - xsum/sig validated.

Re: Re: New committer: Justin Ling Mao

2021-01-19 Thread Justin Ling Mao
Thanks all for your congratulations. I wish I could do much more works for our community in the future. - Original Message - From: Szalay-Bekő Máté To: DevZooKeeper Subject: Re: New committer: Justin Mao Ling Date: 2021-01-18 20:27 Congratulations Maoling!!! :)) Regards, Mate On Mon,

Re: [ZOOKEEPER-3922] rebase and retest on github

2021-02-01 Thread Justin Ling Mao
Hi ben, for [PR-1444](https://github.com/apache/zookeeper/pull/1444)AFAIK, you can let chingchan1996 grant write access for you and you'll be able to push changes on this branch. Look at an example of [PR-984](https://github.com/apache/zookeeper/pull/984)or you can create another PR to

Re: PR Validation on Github Actions is very flaky

2021-06-18 Thread Justin Ling Mao
Let me take a look. I'm filing the java flaky test happened recently. I will investigate the CPP test issue.Although I almost forget my C language, but you know I am almighty : - Original Message - From: Enrico Olivelli To: DevZooKeeper Subject: PR Validation on Github Actions is

Re: Commit 4faf507 broke the build

2021-02-09 Thread Justin Ling Mao
Oops, it's my blame. I'm very sorry for my mistakes. Since these days the CI is in disorder and it's a typo, so I'm not waiting for CI check and forgot that an UT has covered this change although I wrote these related codes. It's all my mistake and I will summarize our submission process and

Re: Re: [Commit Accident Case Study] Commit 4faf507 broke the build

2021-02-10 Thread Justin Ling Mao
patch, so now please create a new PR with all the required changes included. Also I second Enrico’s comment: if CI is in bad shape, we should fix it. Regards, Andor > On 2021. Feb 9., at 13:45, Justin Ling Mao wrote: > > Oops, it's my blame. I'm very sorry for my mistakes. Sinc

Re: Re: [ANNOUNCE] Apache ZooKeeper 3.7.0 released

2021-04-03 Thread Justin Ling Mao
Awesome!!! Thanks Damien for working as RM, thank the contributors that made the release possible. Cheers!!! - Original Message - From: Szalay-Bekő Máté To: DevZooKeeper Cc: annou...@apache.org, UserZooKeeper Subject: Re: [ANNOUNCE] Apache ZooKeeper 3.7.0 released Date: 2021-03-29

Re: Re: quota stats data consistency

2021-03-02 Thread Justin Ling Mao
Thanks Li Wang for your question. If you have more questions, please ask again here:) - Original Message - From: Li Wang To: dev Subject: Re: quota stats data consistency Date: 2021-03-02 05:07 Some updates on this. I looked more into this and found that quota usage is actually

Re: collecting and exposing quota related metrics to Prometheus

2021-02-16 Thread Justin Ling Mao
@Li Wang Great addition, we really need this. Please help us to do this:) - Original Message - From: Li Wang To: dev@zookeeper.apache.org Subject: collecting and exposing quota related metrics to Prometheus Date: 2021-02-16 09:23 Hi, In 3.7, Quota limit can be enforced and the quota

Re: Re: Re: [Commit Accident Case Study] Commit 4faf507 broke the build

2021-02-20 Thread Justin Ling Mao
I have created the PR(https://github.com/apache/zookeeper/pull/1610) to add the committer checklist to commit script to avoid The Accident Case like: PR-1597. Please review it and provide more checklists if I have not covered. - Original Message - From: "Justin Ling Mao" To: