[GitHub] zookeeper issue #262: ZOOKEEPER-2789: Reassign `ZXID` for solving 32bit over...

2017-05-24 Thread maoling
Github user maoling commented on the issue: https://github.com/apache/zookeeper/pull/262 A good and interesting question! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] zookeeper issue #262: ZOOKEEPER-2789: Reassign `ZXID` for solving 32bit over...

2017-06-05 Thread maoling
Github user maoling commented on the issue: https://github.com/apache/zookeeper/pull/262 Hi, @asdf2014 .Thanks for your explanation! But I still have some confusions about the question one: look at code like this : ``` int epoch = (int)Long.rotateRight(zxid, 32);// >&

[GitHub] zookeeper pull request #308: ZOOKEEPER-2842

2017-07-12 Thread maoling
GitHub user maoling opened a pull request: https://github.com/apache/zookeeper/pull/308 ZOOKEEPER-2842 1.optimize the finish() of Send/RecvWorker in QuorumCnxManager 2.remove testInitiateConnection() 3. formates some codes You can merge this pull request into a Git

[GitHub] zookeeper issue #308: ZOOKEEPER-2842

2017-07-18 Thread maoling
Github user maoling commented on the issue: https://github.com/apache/zookeeper/pull/308 ``` boolean isMyShitCodeReviewed = false; while (!isMyShitCodeReviewed) { synchronized (this) { feelSad(); feelLonely

[GitHub] zookeeper pull request #322: [ZOOKEEPER-2853] Update lastZxidSeen in FileTxn...

2017-08-01 Thread maoling
Github user maoling commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/322#discussion_r130567289 --- Diff: src/java/main/org/apache/zookeeper/server/persistence/FileTxnLog.java --- @@ -199,14 +199,16 @@ public synchronized boolean append(TxnHeader

[GitHub] zookeeper pull request #322: [ZOOKEEPER-2853] Update lastZxidSeen in FileTxn...

2017-08-01 Thread maoling
Github user maoling commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/322#discussion_r130566850 --- Diff: src/java/main/org/apache/zookeeper/server/persistence/FileTxnLog.java --- @@ -118,7 +118,7 @@ fsyncWarningThresholdMS

[GitHub] zookeeper pull request #308: ZOOKEEPER-2842:Optimize the finish() of Send/Re...

2017-08-07 Thread maoling
Github user maoling commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/308#discussion_r131591226 --- Diff: src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java --- @@ -233,25 +233,25 @@ public QuorumCnxManager(QuorumPeer self

[GitHub] zookeeper pull request #308: ZOOKEEPER-2842:Optimize the finish() of Send/Re...

2017-08-07 Thread maoling
Github user maoling commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/308#discussion_r131591446 --- Diff: src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java --- @@ -233,25 +233,25 @@ public QuorumCnxManager(QuorumPeer self

[GitHub] zookeeper pull request #308: ZOOKEEPER-2842:Optimize the finish() of Send/Re...

2017-08-07 Thread maoling
Github user maoling commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/308#discussion_r131591962 --- Diff: src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java --- @@ -880,19 +876,20 @@ public void run

[GitHub] zookeeper pull request #298: ZOOKEEPER-2826: Code refactoring for `CLI` modu...

2017-08-08 Thread maoling
Github user maoling commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/298#discussion_r131847801 --- Diff: src/java/main/org/apache/zookeeper/cli/ReconfigCommand.java --- @@ -52,12 +52,12 @@ private String members; /* version

[GitHub] zookeeper pull request #334: ZOOKEEPER-2836 SocketTimeoutException

2017-08-12 Thread maoling
Github user maoling commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/334#discussion_r132820615 --- Diff: src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java --- @@ -647,11 +648,11 @@ public void run

[GitHub] zookeeper pull request #336: ZOOKEEPER-2836: fix SocketTimeoutException

2017-08-17 Thread maoling
Github user maoling commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/336#discussion_r133864927 --- Diff: src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java --- @@ -647,11 +648,10 @@ public void run

[GitHub] zookeeper pull request #336: ZOOKEEPER-2836: fix SocketTimeoutException

2017-08-17 Thread maoling
Github user maoling commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/336#discussion_r133865685 --- Diff: src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java --- @@ -647,11 +648,10 @@ public void run

[GitHub] zookeeper pull request #339: ZOOKEEPER-2581:Not handled NullPointerException...

2017-08-22 Thread maoling
GitHub user maoling opened a pull request: https://github.com/apache/zookeeper/pull/339 ZOOKEEPER-2581:Not handled NullPointerException while creating key manager and trustManager - when **zookeeper.ssl.keyStore.password**is null,**keyStorePasswordProp** is **null** ,then

[GitHub] zookeeper pull request #342: ZOOKEEPER-2488: Synchronized access to shutting...

2017-08-24 Thread maoling
Github user maoling commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/342#discussion_r135038449 --- Diff: src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java --- @@ -1155,6 +1134,19 @@ public void run

[GitHub] zookeeper pull request #348: ZOOKEEPER-2319:UnresolvedAddressException cause...

2017-08-24 Thread maoling
GitHub user maoling opened a pull request: https://github.com/apache/zookeeper/pull/348 ZOOKEEPER-2319:UnresolvedAddressException cause the QuorumCnxManager.Listener exit more details in [JIRA](https://issues.apache.org/jira/browse/ZOOKEEPER-2319) You can merge this pull request

[GitHub] zookeeper pull request #349: ZOOKEEPER-2349:Update documentation for snapCou...

2017-08-24 Thread maoling
GitHub user maoling opened a pull request: https://github.com/apache/zookeeper/pull/349 ZOOKEEPER-2349:Update documentation for snapCount Origin patch can not apply now and it has something inaccurate.so I give it a new PR. more details in [JIRA](https://issues.apache.org/jira

[GitHub] zookeeper pull request #349: ZOOKEEPER-2349:Update documentation for snapCou...

2017-08-26 Thread maoling
Github user maoling commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/349#discussion_r135400691 --- Diff: src/docs/src/documentation/content/xdocs/zookeeperAdmin.xml --- @@ -823,10 +823,10 @@ server.3=zoo3:2888:3888 role="

[GitHub] zookeeper pull request #348: ZOOKEEPER-2319:UnresolvedAddressException cause...

2017-08-26 Thread maoling
Github user maoling commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/348#discussion_r135400760 --- Diff: src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java --- @@ -621,7 +621,7 @@ public Listener() { @Override

[GitHub] zookeeper pull request #303: ZOOKEEPER-2840: Should using `System.nanoTime()...

2017-08-29 Thread maoling
Github user maoling commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/303#discussion_r135789082 --- Diff: src/java/main/org/apache/zookeeper/client/StaticHostProvider.java --- @@ -71,7 +71,7 @@ * if serverAddresses is empty or

[GitHub] zookeeper pull request #356: ZOOKEEPER-2572: Fix potential resource leak in ...

2017-09-03 Thread maoling
Github user maoling commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/356#discussion_r136731827 --- Diff: src/java/main/org/apache/zookeeper/server/persistence/FileTxnLog.java --- @@ -399,18 +403,20 @@ public boolean truncate(long zxid) throws

[GitHub] zookeeper pull request #356: ZOOKEEPER-2572: Fix potential resource leak in ...

2017-09-03 Thread maoling
Github user maoling commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/356#discussion_r136732072 --- Diff: src/java/main/org/apache/zookeeper/server/persistence/FileTxnLog.java --- @@ -399,18 +403,20 @@ public boolean truncate(long zxid) throws

[GitHub] zookeeper pull request #356: ZOOKEEPER-2572: Fix potential resource leak in ...

2017-09-03 Thread maoling
Github user maoling commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/356#discussion_r136732115 --- Diff: src/java/main/org/apache/zookeeper/server/quorum/Learner.java --- @@ -395,11 +395,12 @@ else if (qp.getType() == Leader.SNAP

[GitHub] zookeeper pull request #356: ZOOKEEPER-2572: Fix potential resource leak in ...

2017-09-05 Thread maoling
Github user maoling commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/356#discussion_r137003935 --- Diff: src/java/main/org/apache/zookeeper/server/persistence/FileTxnLog.java --- @@ -409,13 +409,15 @@ public void truncate(long zxid) throws

[GitHub] zookeeper pull request #356: ZOOKEEPER-2572: Fix potential resource leak in ...

2017-09-05 Thread maoling
Github user maoling commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/356#discussion_r137008765 --- Diff: src/java/main/org/apache/zookeeper/server/persistence/FileTxnLog.java --- @@ -399,18 +403,20 @@ public boolean truncate(long zxid) throws

[GitHub] zookeeper issue #339: ZOOKEEPER-2581:Not handled NullPointerException while ...

2017-09-11 Thread maoling
Github user maoling commented on the issue: https://github.com/apache/zookeeper/pull/339 ping @hanm ---

[GitHub] zookeeper issue #376: Update OutputArchive.java

2017-09-22 Thread maoling
Github user maoling commented on the issue: https://github.com/apache/zookeeper/pull/376 This PR is duplicated with [PR-350](https://github.com/apache/zookeeper/pull/350) ---

[GitHub] zookeeper issue #380: Develeper shonminh

2017-09-26 Thread maoling
Github user maoling commented on the issue: https://github.com/apache/zookeeper/pull/380 ????? ---

[GitHub] zookeeper pull request #446: ZOOKEEPER-1580:QuorumPeer.setRunning is not use...

2018-01-08 Thread maoling
GitHub user maoling opened a pull request: https://github.com/apache/zookeeper/pull/446 ZOOKEEPER-1580:QuorumPeer.setRunning is not used more details in [JIRA:ZOOKEEPER-1580](https://issues.apache.org/jira/browse/ZOOKEEPER-1580) You can merge this pull request into a Git

[GitHub] zookeeper pull request #446: ZOOKEEPER-1580:QuorumPeer.setRunning is not use...

2018-01-09 Thread maoling
Github user maoling commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/446#discussion_r160580471 --- Diff: src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java --- @@ -1751,7 +1751,7 @@ public synchronized void initConfigInZKDatabase

[GitHub] zookeeper pull request #446: ZOOKEEPER-1580:QuorumPeer.setRunning is not use...

2018-01-26 Thread maoling
Github user maoling closed the pull request at: https://github.com/apache/zookeeper/pull/446 ---

[GitHub] zookeeper pull request #452: ZOOKEEPER-1580:QuorumPeer.setRunning is not use...

2018-01-26 Thread maoling
GitHub user maoling opened a pull request: https://github.com/apache/zookeeper/pull/452 ZOOKEEPER-1580:QuorumPeer.setRunning is not used - more details in [JIRA:ZOOKEEPER-1580](https://issues.apache.org/jira/browse/ZOOKEEPER-1580) - I forget fetching the upstream codes, make a

[GitHub] zookeeper pull request #464: ZOOKEEPER-2963:standalone

2018-02-13 Thread maoling
GitHub user maoling opened a pull request: https://github.com/apache/zookeeper/pull/464 ZOOKEEPER-2963:standalone more details in [JIRA:ZOOKEEPER-2963](https://issues.apache.org/jira/browse/ZOOKEEPER-2963) You can merge this pull request into a Git repository by running

[GitHub] zookeeper issue #480: c++ zookeeper base java zookeeper v3.4.11

2018-03-05 Thread maoling
Github user maoling commented on the issue: https://github.com/apache/zookeeper/pull/480 I can @cxxjava 你是Pull Request pull错了!!忘记 git fetch upstream 把所有的commits都push进来了! 这个中文[文档](https://zhuanlan.zhihu.com/p/23457016)很è

[GitHub] zookeeper pull request #490: ZOOKEEPER-3000: Use error-prone compiler

2018-03-20 Thread maoling
Github user maoling commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/490#discussion_r175772100 --- Diff: src/java/systest/org/apache/zookeeper/test/system/InstanceManager.java --- @@ -266,7 +282,7 @@ synchronized public void removeInstance(String

[GitHub] zookeeper pull request #490: ZOOKEEPER-3000: Use error-prone compiler

2018-03-20 Thread maoling
Github user maoling commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/490#discussion_r175774472 --- Diff: src/java/test/org/apache/zookeeper/test/ZooKeeperTestClient.java --- @@ -71,13 +71,14 @@ private void deleteZKDir(ZooKeeper zk, String nodeName

[GitHub] zookeeper issue #493: ZOOKEEPER-3006: Potential NPE in ZKDatabase#calculateT...

2018-03-25 Thread maoling
Github user maoling commented on the issue: https://github.com/apache/zookeeper/pull/493 +1,LGTM ---

[GitHub] zookeeper pull request #495: ZOOKEEPER-3007:Potential NPE in ReferenceCounte...

2018-03-26 Thread maoling
Github user maoling commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/495#discussion_r177294282 --- Diff: src/java/main/org/apache/zookeeper/server/ReferenceCountedACLCache.java --- @@ -109,16 +109,18 @@ public synchronized void deserialize

[GitHub] zookeeper issue #489: ZOOKEEPER-2989: IPv6 literal address causes problems f...

2018-03-28 Thread maoling
Github user maoling commented on the issue: https://github.com/apache/zookeeper/pull/489 @troodes can we move on ? ---

[GitHub] zookeeper issue #476: ZOOKEEPER-2988: NPE triggered if server receives a vot...

2018-03-28 Thread maoling
Github user maoling commented on the issue: https://github.com/apache/zookeeper/pull/476 @enixon can we move on ? ---

[GitHub] zookeeper issue #498: fix typo, charater --> character

2018-04-16 Thread maoling
Github user maoling commented on the issue: https://github.com/apache/zookeeper/pull/498 @hughobrienjet It is better to create a [JIRA](https://issues.apache.org/jira/projects/ZOOKEEPER/) issues (sign up JIRA if you don't have an account) to bind this PR to a JIRA-ID

[GitHub] zookeeper issue #511: Incorrect constant value

2018-05-14 Thread maoling
Github user maoling commented on the issue: https://github.com/apache/zookeeper/pull/511 Good Catch. It's better to create a [JIRA](https://issues.apache.org/jira/projects/ZOOKEEPER/) issues (sign up JIRA if you don't have an account) to bind this PR to a JIRA-ID Mo

[GitHub] zookeeper issue #489: ZOOKEEPER-2989: IPv6 literal address causes problems f...

2018-05-23 Thread maoling
Github user maoling commented on the issue: https://github.com/apache/zookeeper/pull/489 @phunt I will pick it up if @troodes feel free or no reaction within three days ---

[GitHub] zookeeper pull request #464: ZOOKEEPER-2963:standalone

2018-05-23 Thread maoling
Github user maoling closed the pull request at: https://github.com/apache/zookeeper/pull/464 ---

[GitHub] zookeeper pull request #533: ZOOKEEPER-2989:IPv6 literal address causes prob...

2018-05-25 Thread maoling
GitHub user maoling opened a pull request: https://github.com/apache/zookeeper/pull/533 ZOOKEEPER-2989:IPv6 literal address causes problems for Quorum members More details in [ZOOKEEPER-2989]( https://issues.apache.org/jira/browse/ZOOKEEPER-2989) Thanks for the old [PR-489

[GitHub] zookeeper pull request #533: ZOOKEEPER-2989:IPv6 literal address causes prob...

2018-05-25 Thread maoling
Github user maoling closed the pull request at: https://github.com/apache/zookeeper/pull/533 ---

[GitHub] zookeeper pull request #533: ZOOKEEPER-2989:IPv6 literal address causes prob...

2018-05-25 Thread maoling
GitHub user maoling reopened a pull request: https://github.com/apache/zookeeper/pull/533 ZOOKEEPER-2989:IPv6 literal address causes problems for Quorum members More details in [ZOOKEEPER-2989]( https://issues.apache.org/jira/browse/ZOOKEEPER-2989) Thanks for the old [PR-489

[GitHub] zookeeper issue #533: ZOOKEEPER-2989:IPv6 literal address causes problems fo...

2018-05-30 Thread maoling
Github user maoling commented on the issue: https://github.com/apache/zookeeper/pull/533 @anmolnar **InitialMessage** is a inner-class of **QuorumCnxManager**. Is it necessary to a separate test file? @phunt @hanm What's your opinion? ---

[GitHub] zookeeper pull request #489: ZOOKEEPER-2989: IPv6 literal address causes pro...

2018-06-09 Thread maoling
Github user maoling commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/489#discussion_r194247374 --- Diff: src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java --- @@ -222,15 +222,15 @@ static public InitialMessage parse(Long

[GitHub] zookeeper pull request #533: ZOOKEEPER-2989:IPv6 literal address causes prob...

2018-06-09 Thread maoling
Github user maoling commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/533#discussion_r194247586 --- Diff: src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java --- @@ -222,15 +222,15 @@ static public InitialMessage parse(Long

[GitHub] zookeeper pull request #539: ZOOKEEPER-3058: Do length check first before ac...

2018-06-10 Thread maoling
Github user maoling commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/539#discussion_r194248152 --- Diff: src/java/main/org/apache/jute/Utils.java --- @@ -268,15 +268,14 @@ static String toCSVBuffer(byte barr[]) { return

[GitHub] zookeeper pull request #530: [ZOOKEEPER-2474] Support session reconnection w...

2018-06-11 Thread maoling
Github user maoling commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/530#discussion_r194383541 --- Diff: src/java/main/org/apache/zookeeper/ZooKeeper.java --- @@ -1218,6 +1294,79 @@ public ZooKeeper(String connectString, int sessionTimeout, Watcher

[GitHub] zookeeper issue #490: ZOOKEEPER-3000: Use error-prone compiler

2018-06-11 Thread maoling
Github user maoling commented on the issue: https://github.com/apache/zookeeper/pull/490 @leventov Can we move on? ---

[GitHub] zookeeper issue #474: ZOOKEEPER-2977: Concurrency for addAuth corrupts quoru...

2018-06-11 Thread maoling
Github user maoling commented on the issue: https://github.com/apache/zookeeper/pull/474 @sumitagrawl Can we move on? ---

[GitHub] zookeeper pull request #348: ZOOKEEPER-2319:UnresolvedAddressException cause...

2018-06-18 Thread maoling
Github user maoling closed the pull request at: https://github.com/apache/zookeeper/pull/348 ---

[GitHub] zookeeper issue #541: ZOOKEEPER-3059 EventThread leak in case of Sasl AuthFa...

2018-06-23 Thread maoling
Github user maoling commented on the issue: https://github.com/apache/zookeeper/pull/541 @abhishek-chouhan close this PR and reopen it will retrigger jenkins.It seems the failures isn't related with this PR ---

[GitHub] zookeeper pull request #548: [ZOOKEEPER-3057] Fix IPv6 literal usage

2018-06-24 Thread maoling
Github user maoling commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/548#discussion_r197633896 --- Diff: src/java/test/org/apache/zookeeper/common/NetUtilsTest.java --- @@ -0,0 +1,46 @@ +package apache.zookeeper.common; --- End diff -- ??? ---

[GitHub] zookeeper pull request #548: [ZOOKEEPER-3057] Fix IPv6 literal usage

2018-06-24 Thread maoling
Github user maoling commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/548#discussion_r197633888 --- Diff: src/java/main/org/apache/zookeeper/server/util/ConfigUtils.java --- @@ -60,4 +60,25 @@ static public String getClientConfigStr(String

[GitHub] zookeeper pull request #548: [ZOOKEEPER-3057] Fix IPv6 literal usage

2018-06-24 Thread maoling
Github user maoling commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/548#discussion_r197633793 --- Diff: src/java/main/org/apache/zookeeper/client/FourLetterWordMain.java --- @@ -86,7 +86,7 @@ public static String send4LetterWord(String host, int

[GitHub] zookeeper issue #548: [ZOOKEEPER-3057] Fix IPv6 literal usage

2018-06-24 Thread maoling
Github user maoling commented on the issue: https://github.com/apache/zookeeper/pull/548 - It seems that zk server side supports ipv6 style like this: `server.1=[2001:db8:1::242:ac11:2]:2888:3888`,but zk client side supports ipv6 like this:`2001:db8:1::242:ac11:2:2181`.we need unify

[GitHub] zookeeper pull request #553: continue can be replaced with break

2018-06-28 Thread maoling
Github user maoling commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/553#discussion_r198735418 --- Diff: src/java/main/org/apache/zookeeper/server/persistence/FileTxnLog.java --- @@ -254,7 +254,7 @@ public synchronized boolean append(TxnHeader hdr

[GitHub] zookeeper issue #553: continue can be replaced with break

2018-06-28 Thread maoling
Github user maoling commented on the issue: https://github.com/apache/zookeeper/pull/553 IMHO: If the file are sorted,can we use binary search ,find the index then subList? Should we call `Util.getZxidFromName ` twice? ---

[GitHub] zookeeper pull request #556: ZOOKEEPER-3074:Flaky test:org.apache.zookeeper....

2018-07-03 Thread maoling
GitHub user maoling opened a pull request: https://github.com/apache/zookeeper/pull/556 ZOOKEEPER-3074:Flaky test:org.apache.zookeeper.server.ServerStatsTest.testLatencyMetrics more details in [ZOOKEEPER-3074](https://issues.apache.org/jira/browse/ZOOKEEPER-3074) You can merge

[GitHub] zookeeper pull request #548: [ZOOKEEPER-3057] Fix IPv6 literal usage

2018-07-04 Thread maoling
Github user maoling commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/548#discussion_r200064561 --- Diff: src/java/main/org/apache/zookeeper/server/util/ConfigUtils.java --- @@ -60,4 +60,25 @@ static public String getClientConfigStr(String

[GitHub] zookeeper issue #561: ZOOKEEPER-3083: Remove some redundant and noisy log li...

2018-07-05 Thread maoling
Github user maoling commented on the issue: https://github.com/apache/zookeeper/pull/561 @enixon It seems that your IDE also makes some noises(grin) ---

[GitHub] zookeeper issue #521: ZOOKEEPER-3042: testFailedTxnAsPartOfQuorumLoss is fla...

2018-07-09 Thread maoling
Github user maoling commented on the issue: https://github.com/apache/zookeeper/pull/521 ping @anmolnar ---

[GitHub] zookeeper issue #530: [ZOOKEEPER-2474] Support session reconnection when usi...

2018-07-09 Thread maoling
Github user maoling commented on the issue: https://github.com/apache/zookeeper/pull/530 @timothyjward Can we move on ? ---

[GitHub] zookeeper pull request #556: ZOOKEEPER-3074:Flaky test:org.apache.zookeeper....

2018-07-09 Thread maoling
GitHub user maoling reopened a pull request: https://github.com/apache/zookeeper/pull/556 ZOOKEEPER-3074:Flaky test:org.apache.zookeeper.server.ServerStatsTest.testLatencyMetrics more details in [ZOOKEEPER-3074](https://issues.apache.org/jira/browse/ZOOKEEPER-3074) You can merge

[GitHub] zookeeper pull request #556: ZOOKEEPER-3074:Flaky test:org.apache.zookeeper....

2018-07-09 Thread maoling
Github user maoling closed the pull request at: https://github.com/apache/zookeeper/pull/556 ---

[GitHub] zookeeper pull request #533: ZOOKEEPER-2989:IPv6 literal address causes prob...

2018-07-11 Thread maoling
Github user maoling closed the pull request at: https://github.com/apache/zookeeper/pull/533 ---

[GitHub] zookeeper pull request #548: [ZOOKEEPER-3057] Fix IPv6 literal usage

2018-07-11 Thread maoling
Github user maoling commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/548#discussion_r201923793 --- Diff: src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java --- @@ -226,17 +230,25 @@ static public InitialMessage parse(Long

[GitHub] zookeeper pull request #548: [ZOOKEEPER-3057] Fix IPv6 literal usage

2018-07-11 Thread maoling
Github user maoling commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/548#discussion_r201926608 --- Diff: src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java --- @@ -857,15 +869,15 @@ public void run

[GitHub] zookeeper pull request #548: [ZOOKEEPER-3057] Fix IPv6 literal usage

2018-07-11 Thread maoling
Github user maoling commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/548#discussion_r201923508 --- Diff: src/java/main/org/apache/zookeeper/server/util/ConfigUtils.java --- @@ -61,10 +61,16 @@ static public String getClientConfigStr(String

[GitHub] zookeeper pull request #548: [ZOOKEEPER-3057] Fix IPv6 literal usage

2018-07-11 Thread maoling
Github user maoling commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/548#discussion_r201901490 --- Diff: src/java/test/org/apache/zookeeper/server/util/ConfigUtilsTest.java --- @@ -29,4 +30,21 @@ public void testSplitServerConfig() throws

[GitHub] zookeeper issue #553: continue can be replaced with break

2018-07-13 Thread maoling
Github user maoling commented on the issue: https://github.com/apache/zookeeper/pull/553 @a470577391 it's useful and enough to change `continue` to `break`,especially when call `getLogFiles(logDir.listFiles(), 0)` It's better to create a [JIRA](https://issues.apach

[GitHub] zookeeper issue #556: ZOOKEEPER-3074:Flaky test:org.apache.zookeeper.server....

2018-07-13 Thread maoling
Github user maoling commented on the issue: https://github.com/apache/zookeeper/pull/556 It seems that Jenkins doesn't like me, even doesn't reject me,let me wait and wait ,just like some girls I chase. ---

[GitHub] zookeeper issue #521: ZOOKEEPER-3042: testFailedTxnAsPartOfQuorumLoss is fla...

2018-07-15 Thread maoling
Github user maoling commented on the issue: https://github.com/apache/zookeeper/pull/521 @lavacat [Jenkins](https://builds.apache.org/job/ZooKeeper_branch34_java10/79/testReport/junit/org.apache.zookeeper.server.quorum/QuorumPeerMainTest/testFailedTxnAsPartOfQuorumLoss/) still

[GitHub] zookeeper issue #572: ZOOKEEPER-3085 define exit codes in enum

2018-07-17 Thread maoling
Github user maoling commented on the issue: https://github.com/apache/zookeeper/pull/572 @nkalmar these two places([1](https://github.com/apache/zookeeper/blob/master/src/java/main/org/apache/zookeeper/ZooKeeperMain.java#L365), [2](https://github.com/apache/zookeeper/blob/master/src

[GitHub] zookeeper issue #566: ZOOKEEPER-3062: mention fsync.warningthresholdms in Fi...

2018-07-17 Thread maoling
Github user maoling commented on the issue: https://github.com/apache/zookeeper/pull/566 Is is really necessary to log this property `fsync.warningthresholdms`? ---

[GitHub] zookeeper pull request #556: ZOOKEEPER-3074:Flaky test:org.apache.zookeeper....

2018-07-17 Thread maoling
Github user maoling closed the pull request at: https://github.com/apache/zookeeper/pull/556 ---

[GitHub] zookeeper pull request #556: ZOOKEEPER-3074:Flaky test:org.apache.zookeeper....

2018-07-17 Thread maoling
GitHub user maoling reopened a pull request: https://github.com/apache/zookeeper/pull/556 ZOOKEEPER-3074:Flaky test:org.apache.zookeeper.server.ServerStatsTest.testLatencyMetrics more details in [ZOOKEEPER-3074](https://issues.apache.org/jira/browse/ZOOKEEPER-3074) You can merge

[GitHub] zookeeper issue #583: [ZOOKEEPER-3104] Fix data inconsistency due to NEWLEAD...

2018-07-26 Thread maoling
Github user maoling commented on the issue: https://github.com/apache/zookeeper/pull/583 @lvfangmin discard your vim,embrace IEDA(smirk) ---

[GitHub] zookeeper pull request #567: ZOOKEEPER-3071: Add a config parameter to contr...

2018-07-26 Thread maoling
Github user maoling commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/567#discussion_r205527457 --- Diff: src/java/test/org/apache/zookeeper/test/TxnLogSizeLimitTest.java --- @@ -0,0 +1,173 @@ +/** + * Licensed to the Apache Software

[GitHub] zookeeper pull request #567: ZOOKEEPER-3071: Add a config parameter to contr...

2018-07-26 Thread maoling
Github user maoling commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/567#discussion_r205526853 --- Diff: src/java/main/org/apache/zookeeper/server/persistence/FileTxnLog.java --- @@ -102,6 +102,20 @@ /** Maximum time we allow for elapsed

[GitHub] zookeeper pull request #567: ZOOKEEPER-3071: Add a config parameter to contr...

2018-07-26 Thread maoling
Github user maoling commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/567#discussion_r205526028 --- Diff: src/java/main/org/apache/zookeeper/server/persistence/FileTxnLog.java --- @@ -127,14 +127,11 @@ Long logSize = Long.getLong

[GitHub] zookeeper pull request #567: ZOOKEEPER-3071: Add a config parameter to contr...

2018-07-26 Thread maoling
Github user maoling commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/567#discussion_r205525593 --- Diff: src/java/main/org/apache/zookeeper/server/persistence/FileTxnLog.java --- @@ -109,7 +109,7 @@ * * The feature is disabled

[GitHub] zookeeper pull request #584: ZOOKEEPER-3102: Potential race condition when c...

2018-07-28 Thread maoling
Github user maoling commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/584#discussion_r205941687 --- Diff: src/java/main/org/apache/zookeeper/server/DataTree.java --- @@ -478,7 +478,10 @@ public void createNode(final String path, byte data[], List

[GitHub] zookeeper pull request #584: ZOOKEEPER-3102: Potential race condition when c...

2018-07-28 Thread maoling
Github user maoling commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/584#discussion_r205961633 --- Diff: src/java/main/org/apache/zookeeper/server/DataTree.java --- @@ -478,7 +478,10 @@ public void createNode(final String path, byte data[], List

[GitHub] zookeeper pull request #:

2018-07-29 Thread maoling
Github user maoling commented on the pull request: https://github.com/apache/zookeeper/commit/a2623a625a4778720f7d5482d0a66e9b37ae556f#commitcomment-29873077 @nkalmar Could you plz create a JIRA to document this metric `zk_fsync_threshold_exceed_count` in the part of `mntr` of

[GitHub] zookeeper pull request #:

2018-07-30 Thread maoling
Github user maoling commented on the pull request: https://github.com/apache/zookeeper/commit/a2623a625a4778720f7d5482d0a66e9b37ae556f#commitcomment-29885683 @nkalmar Thanks for your ACK. 4 letter words will be deprecated? why? ---

[GitHub] zookeeper pull request #587: ZOOKEEPER-3106: Zookeeper client supports IPv6 ...

2018-07-30 Thread maoling
GitHub user maoling opened a pull request: https://github.com/apache/zookeeper/pull/587 ZOOKEEPER-3106: Zookeeper client supports IPv6 address and document the "IPV6 feature" The related UTs in the `ConnectStringParserTest` have all passed,I also tested it in the rea

[GitHub] zookeeper pull request #:

2018-07-31 Thread maoling
Github user maoling commented on the pull request: https://github.com/apache/zookeeper/commit/a2623a625a4778720f7d5482d0a66e9b37ae556f#commitcomment-29915646 @anmolnar Sir, Could you plz tell me why the 4 letter words is insecure? ---

[GitHub] zookeeper pull request #:

2018-08-01 Thread maoling
Github user maoling commented on the pull request: https://github.com/apache/zookeeper/commit/a2623a625a4778720f7d5482d0a66e9b37ae556f#commitcomment-29922823 @nkalmar Thanks for your nice explain. these security problems can also exist in the JMX and Jetty? ---

[GitHub] zookeeper pull request #587: ZOOKEEPER-3106: Zookeeper client supports IPv6 ...

2018-08-01 Thread maoling
Github user maoling commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/587#discussion_r207090394 --- Diff: src/java/main/org/apache/zookeeper/client/ConnectStringParser.java --- @@ -68,14 +69,26 @@ public ConnectStringParser(String connectString

[GitHub] zookeeper pull request #:

2018-08-02 Thread maoling
Github user maoling commented on the pull request: https://github.com/apache/zookeeper/commit/a2623a625a4778720f7d5482d0a66e9b37ae556f#commitcomment-29935400 wonderful explain.thanks @nkalmar ---

[GitHub] zookeeper pull request #587: ZOOKEEPER-3106: Zookeeper client supports IPv6 ...

2018-08-03 Thread maoling
Github user maoling commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/587#discussion_r207535136 --- Diff: src/java/test/org/apache/zookeeper/test/ConnectStringParserTest.java --- @@ -39,27 +44,44 @@ public void testMultipleServersChrootPath

[GitHub] zookeeper pull request #587: ZOOKEEPER-3106: Zookeeper client supports IPv6 ...

2018-08-05 Thread maoling
Github user maoling commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/587#discussion_r207727691 --- Diff: src/java/main/org/apache/zookeeper/client/ConnectStringParser.java --- @@ -68,14 +69,26 @@ public ConnectStringParser(String connectString

[GitHub] zookeeper pull request #587: ZOOKEEPER-3106: Zookeeper client supports IPv6 ...

2018-08-05 Thread maoling
Github user maoling commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/587#discussion_r207730177 --- Diff: src/java/main/org/apache/zookeeper/client/ConnectStringParser.java --- @@ -68,14 +69,26 @@ public ConnectStringParser(String connectString

[GitHub] zookeeper issue #584: ZOOKEEPER-3102: Potential race condition when create e...

2018-08-08 Thread maoling
Github user maoling commented on the issue: https://github.com/apache/zookeeper/pull/584 sorry ,too embarrassed.I was wrong about my previous opinion. look at my thread-pool [unit test](https://github.com/maoling/zookeeper/blob/ZOOKEEPER-3102/src/java/test/org/apache/zookeeper/server

[GitHub] zookeeper issue #590: [ZOOKEEPER-1177] Add the memory optimized watch manage...

2018-08-08 Thread maoling
Github user maoling commented on the issue: https://github.com/apache/zookeeper/pull/590 @lvfangmin interesting.where can we find a benchmark which shows how this pr improves the memory? ---

  1   2   3   4   5   6   >