Re: [edk2-devel] [PATCH 00/16] OvmfPkg, ArmVirtPkg: upstream the EnrollDefaultKeys app

On 04/27/19 02:53, Laszlo Ersek wrote: > Bugzilla: https://bugzilla.tianocore.org/show_bug.cgi?id=1747 > Repo: https://github.com/lersek/edk2.git > Branch: enroll_bz_1747 > > Please see the goal / use case in the BZ. > > Anatomy of the series: > > - Patch 01 adds the application as-is

[edk2-devel] [PATCH 11/16] OvmfPkg/EnrollDefaultKeys: extract MICROSOFT_VENDOR_GUID

The GUID 77FA9ABD-0359-4D32-BD60-28F4E78F784B is specified in MSDN, at , therefore it deserves an entry in the package DEC file, and a header file under "Include/Guid". (Arguably, this GUID declaration / definition could even live under

[edk2-devel] [PATCH 13/16] OvmfPkg/EnrollDefaultKeys: document the steps of the entry point function

The entry point function of EnrollDefaultKeys finishes with a sanity check, verifying the values of the Secure Boot-related "control" variables. Add a diagram to explain why we expect the values we do. While at it, write comments on the rest of the entry point function. Cc: Anthony Perard Cc:

[edk2-devel] [PATCH 04/16] ArmVirtPkg: build EnrollDefaultKeys.efi

Having removed VALID_ARCHITECTURES from "OvmfPkg/EnrollDefaultKeys/EnrollDefaultKeys.inf", it now makes sense to reflect the related platform DSC bits from OvmfPkg to ArmVirtPkg. Build "EnrollDefaultKeys.efi" as part of ArmVirtQemu and ArmVirtQemuKernel (which are the ArmVirtPkg platforms that

[edk2-devel] [PATCH 08/16] OvmfPkg/EnrollDefaultKeys: remove unneeded EFIAPI call. conv. specifiers

The GetExact(), GetSettings(), PrintSettings() functions are only called from within "EnrollDefaultKeys.c", and none of them take variable arguments. Drop their EFIAPI calling convention specifiers. Cc: Anthony Perard Cc: Ard Biesheuvel Cc: Jordan Justen Cc: Julien Grall Bugzilla:

[edk2-devel] [PATCH 10/16] OvmfPkg/EnrollDefaultKeys: split out certificate and signature constants

A large portion of "EnrollDefaultKeys.c" is hex-encoded X509 certificates, GUIDs, and signatures. These objects are constants, unlikely to see changes anytime soon. Move them out of the way, to "AuthData.c", so we can more easily work on functions in "EnrollDefaultKeys.c". Cc: Anthony Perard Cc:

[edk2-devel] [PATCH 12/16] OvmfPkg/EnrollDefaultKeys: describe functions with leading comment blocks

The GetExact(), GetSettings(), PrintSettings(), and ShellAppMain() functions lack leading comment blocks. Supply those. While at it, make sure that every such comment block is preceded by two blank lines. Cc: Anthony Perard Cc: Ard Biesheuvel Cc: Jordan Justen Cc: Julien Grall Bugzilla:

[edk2-devel] [PATCH 02/16] OvmfPkg/EnrollDefaultKeys: update @file comment blocks

Refresh the sentence that states the purpose of the application. Extend the copyright notice to the year 2019. Replace the 2-clause BSD License banner with the BSD-2-Clause-Patent SPDX ID. Cc: Anthony Perard Cc: Ard Biesheuvel Cc: Jordan Justen Cc: Julien Grall Bugzilla:

[edk2-devel] [PATCH 00/16] OvmfPkg, ArmVirtPkg: upstream the EnrollDefaultKeys app

Bugzilla: https://bugzilla.tianocore.org/show_bug.cgi?id=1747 Repo: https://github.com/lersek/edk2.git Branch: enroll_bz_1747 Please see the goal / use case in the BZ. Anatomy of the series: - Patch 01 adds the application as-is from RHEL, as the starting point for upstreaming

[edk2-devel] [PATCH 14/16] OvmfPkg: introduce OVMF_PK_KEK1_APP_PREFIX_GUID

For the EnrollDefaultKeys application, the hypervisor is expected to add a string entry to the "OEM Strings" (Type 11) SMBIOS table, with the following format: 4e32566d-8e9e-4f52-81d3-5bb9715f9727: The string representation of the GUID at the front is the "application prefix", in terms of QEMU

[edk2-devel] [PATCH 16/16] OvmfPkg/EnrollDefaultKeys: remove Red Hat's hard-coded PK/KEK1

The certificate "Red Hat Secure Boot (PK/KEK key 1)/emailAddress=secal...@redhat.com" SHA1: fd:fc:7f:3c:7e:f3:e0:57:76:ad:d7:98:78:21:6c:9b:e0:e1:95:97 is no longer referenced; remove it. Cc: Anthony Perard Cc: Ard Biesheuvel Cc: Jordan Justen Cc: Julien Grall Bugzilla:

[edk2-devel] [PATCH 06/16] OvmfPkg/EnrollDefaultKeys: clean up global variable name prefixes

In edk2, we should start the names of module-global variables with "m". Rename the "RedHatPkKek1", "MicrosoftKEK", "MicrosoftPCA", "MicrosoftUefiCA" variables accordingly, with the following command: sed --regexp-extended --in-place \

[edk2-devel] [PATCH 07/16] OvmfPkg/EnrollDefaultKeys: clean up acronym capitalization in identifiers

According to the edk2 coding standards, "[w]hen all letters in an acronym are capitalized, it makes the prior and subsequent words visually difficult to distinguish". Fix the spellings of three acronyms, accordingly: - "KEK" (Key Exchange Key) should be written as "Kek", in "mMicrosoftKEK", -

[edk2-devel] [PATCH 01/16] OvmfPkg: introduce EnrollDefaultKeys application

Add the OvmfPkg/EnrollDefaultKeys shell application source as it is at the "edk2-20190308git89910a39dcfd-2.el8" tag in RHEL8's downstream "edk2" package. Further patches in this series will replace Red Hat-specific bits in the application, with a conduit to pass in parameters directly from the

[edk2-devel] [PATCH 03/16] OvmfPkg/EnrollDefaultKeys: refresh INF file

Bump INF_VERSION to the latest edk2 INF specification. Regenerate FILE_GUID to distinguish this application from downstream-only versions. Remove the VALID_ARCHITECTURES comment as there is nothing ISA or platform specific in the application. Ensure all sections apart from [Defines] are

[edk2-devel] [PATCH 09/16] OvmfPkg/EnrollDefaultKeys: extract typedefs to a header file

"EnrollDefaultKeys.c" defines three structure types: SINGLE_HEADER, REPEATING_HEADER, and SETTINGS. The definitions are scattered over the C file, and lack high-level summary comments. Extract the structures to "EnrollDefaultKeys.h", and add the missing comments. Cc: Anthony Perard Cc: Ard

[edk2-devel] [PATCH 05/16] OvmfPkg/EnrollDefaultKeys: clean up minor whitespace wart

In edk2, we should spell "#pragma pack(...)" with a space character in front of the opening parenthesis. Fix up locations that suggest otherwise. Cc: Anthony Perard Cc: Ard Biesheuvel Cc: Jordan Justen Cc: Julien Grall Bugzilla: https://bugzilla.tianocore.org/show_bug.cgi?id=1747

Re: [edk2-devel] [PATCH] CryptoPkg: add issetugid declaration to fix openssl build on FreeBSD

On 2019-04-26 14:19, Laszlo Ersek wrote: > > This one looks good -- the From address has changed from > > rebecca via Groups.Io > > to > > rebe...@bluestop.org Oh, it's in their FAQ! :D https://groups.io/static/help#dmarc Why Are Emails From Some People Changed To Be 'via

Re: [edk2-devel] [PATCH] EmbeddedPkg: Allow DXE_DRIVER to depend on NvVarStoreFormattedLib

On 04/26/19 19:02, Laszlo Ersek wrote: > On 04/25/19 13:04, Ard Biesheuvel wrote: >> On Thu, 25 Apr 2019 at 11:18, Marcin Wojtas wrote: >>> >>> Some modules (such as FaultTolerantWriteDxe) use the FlashNvStorage >>> PCDs (PcdFlashNvStorageFtw*). In case the flash contents are not >>> mapped in

Re: [edk2-devel] [Patch v3 1/3] NetworkPkg DSC: Add the required ARM library to pass ARM build

On Sat, 27 Apr 2019 at 00:04, Laszlo Ersek wrote: > > On 04/25/19 14:37, Liming Gao wrote: > > Signed-off-by: Liming Gao > > --- > > NetworkPkg/NetworkPkg.dsc | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > diff --git a/NetworkPkg/NetworkPkg.dsc b/NetworkPkg/NetworkPkg.dsc

Re: [edk2-devel] [Patch V2 2/2] edk2: Update ReadMe.md and Maintainer.txt for edk2-libc repo

On 04/26/19 03:07, Michael D Kinney wrote: > https://bugzilla.tianocore.org/show_bug.cgi?id=1734 > > The following packages have been moved to the new edk2-libc > repository. Remove references to these packages from > Readme.md and Maintainers.txt. > > * AppPkg > * StdLib > *

Re: [edk2-devel] [Patch V2 1/2] edk2: Remove AppPkg, StdLib, StdLibPrivateInternalFiles

On 04/26/19 03:07, Michael D Kinney wrote: > https://bugzilla.tianocore.org/show_bug.cgi?id=1734 > > Remove the following packages and move them to the new > edk2-libc repository > > * AppPkg > * StdLib > * StdLibPrivateInternalFiles > > Cc: Jaben Carsey > Cc: Daryl McDaniel > Signed-off-by:

Re: [edk2-devel] [edk2][edk2-libc/master V2]Request to add new edk2-libc repository

On 04/26/19 02:55, Michael D Kinney wrote: > Hello, > > New in V2 > = > * Add details to Readme.md on how the history for these > three packages was exported from the edk2 repository > using git filter-branch. > * Remove redundant content in edk2-libc Readme.md and >

Re: [edk2-devel] [Patch v3 1/3] NetworkPkg DSC: Add the required ARM library to pass ARM build

On 04/25/19 14:37, Liming Gao wrote: > Signed-off-by: Liming Gao > --- > NetworkPkg/NetworkPkg.dsc | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/NetworkPkg/NetworkPkg.dsc b/NetworkPkg/NetworkPkg.dsc > index 66d43bec12..955e45e84d 100644 > ---

Re: [edk2-devel] reg : UEFI Secure Boot is stuck with Black Screen

Hi Pavan, On 04/25/19 12:37, Pavan Kumar Aravapalli wrote: > Hi > > I am new to this and i am trying to perform Windows Server 2016 [Guest VM] > UEFI secure boot mode on KVM(Hypervisor) Host using > edk2.git-ovmf-x64-0-20190308.1017.g0eccea3fbe.noarch.I am looking for support > documents

Re: [edk2-devel] [Patch 1/4] MdePkg/BaseLib: Verify SSE2 support in IA32 AsmLfence()

On 4/26/19 3:27 PM, Laszlo Ersek wrote: On 04/25/19 19:53, Michael D Kinney wrote: Use CPUID in IA32 implementation of AsmLfence() to verify that SSE2 is supported before using the LFENCE instruction. Cc: Liming Gao Signed-off-by: Michael D Kinney ---

Re: [edk2-devel] [Patch 1/4] MdePkg/BaseLib: Verify SSE2 support in IA32 AsmLfence()

On 04/25/19 19:53, Michael D Kinney wrote: > Use CPUID in IA32 implementation of AsmLfence() to verify > that SSE2 is supported before using the LFENCE instruction. > > Cc: Liming Gao > Signed-off-by: Michael D Kinney > --- > MdePkg/Library/BaseLib/Ia32/Lfence.nasm | 14 +- > 1

Re: [edk2-devel] [PATCH] CryptoPkg: add issetugid declaration to fix openssl build on FreeBSD

On 04/26/19 15:55, rebe...@bluestop.org wrote: > On 2019-04-24 13:17, Laszlo Ersek wrote: >> >> And, again, that's exactly how the sender is displayed to me by >> Thunderbird, in my list folder only: >> >> From: Rebecca via Groups.Io >> >> Again, in email that I get directly from Rebecca, the

Re: [edk2-devel] [PATCH V3 0/8] make mExitBootServicesEvent static

On 04/26/19 03:03, Zhichao Gao wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1740 > > V1: > The DebugLib instances of DebugPortProtocol, ConOut and StdErr > use a global variable "mExitBootServicesEvent" which is in > conflict with the same variable in

Re: [edk2-devel] [PATCH V3 5/8] MdeModulePkg/FirmwarePerformanceDxe: make global variable static

On 04/26/19 10:30, Wu, Hao A wrote: >> -Original Message- >> From: Gao, Zhichao >> Sent: Friday, April 26, 2019 4:12 PM >> To: Wu, Hao A; devel@edk2.groups.io; Laszlo Ersek >> Cc: Laszlo Ersek; Wang, Jian J; Ni, Ray; Zeng, Star; Gao, Liming; Bi, Dandan >> Subject: RE: [edk2-devel] [PATCH

Re: [edk2-devel] [Patch 2/4] UefiCpuPkg/MpInitLib: Avoid MSR_IA32_APIC_BASE for single core

(+Jian) Hi Mike, thank you for the CC. On 04/25/19 19:53, Michael D Kinney wrote: > Avoid access to MSR_IA32_APIC_BASE that may not be supported > on single core CPUs. If PcdCpuMaxLogicalProcessorNumber is 1, > then there is only one CPU that must be the BSP. > > Cc: Eric Dong > Cc: Ray Ni >

Re: [edk2-devel] [PATCH V2 2/2] MdeModulePkg/GraphicsConsoleDxe: Do not clean the screen

There is no reason the devices have to start in mode -1. A device when started should report an accurate list of modes and if it is already in one of those modes it should report the correct mode. This way higher level software can choose not to call setmode because it identifies that the

Re: [edk2-devel] [edk2] Request to add new edk2-libc repository

On 04/25/19 22:52, Kinney, Michael D wrote: > SafeIntLib demonstrates a unit test that runs without any > user input and verifies the result of each unit test and > provides test results in a standard format. > > The OrderedCollectionLibTest provides a way for a developer > to manually test that

Re: [edk2-devel] [PATCH] EmbeddedPkg: Allow DXE_DRIVER to depend on NvVarStoreFormattedLib

On 04/25/19 13:04, Ard Biesheuvel wrote: > On Thu, 25 Apr 2019 at 11:18, Marcin Wojtas wrote: >> >> Some modules (such as FaultTolerantWriteDxe) use the FlashNvStorage >> PCDs (PcdFlashNvStorageFtw*). In case the flash contents are not >> mapped in memory, the module loading order of the FVB

Re: [edk2-devel] [PATCH V2 3/8] MdePkg/UefiDebugLibStdErr: Decrease the name collisions

On 04/24/19 19:09, Ard Biesheuvel wrote: > On Wed, 24 Apr 2019 at 18:59, Kinney, Michael D > wrote: >> >> Hi Ard, >> >> I see a mix of use of 'static' and 'STATIC' in the sources. >> >> The reason to use STATIC is if it needs to be replaced with >> something other than 'static' for a specific

Re: [edk2-devel] [Patch 0/7] Add new CLANG8ELF tool chain for new LLVM/CLANG8

On Fri, 26 Apr 2019 at 16:43, Liming Gao wrote: > > BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=1603 > LLVM/CLANG8 formal release http://releases.llvm.org/download.html#8.0.0 > It can be downloaded and installed in Windows/Linux/Mac OS. > > CLANG8ELF tool chain is added to generate ELF

Re: [edk2-devel] [PATCH v2] MdeModulePkg/DxeCore: Please static checker for false report

Reviewed-by: Michael D Kinney > -Original Message- > From: Wu, Hao A > Sent: Thursday, April 25, 2019 10:39 PM > To: Ard Biesheuvel ; Kinney, > Michael D ; Gao, Liming > ; Wang, Jian J > > Cc: edk2-devel-groups-io > Subject: RE: [PATCH v2] MdeModulePkg/DxeCore: Please > static checker

[edk2-devel] [Patch 0/7] Add new CLANG8ELF tool chain for new LLVM/CLANG8

BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=1603 LLVM/CLANG8 formal release http://releases.llvm.org/download.html#8.0.0 It can be downloaded and installed in Windows/Linux/Mac OS. CLANG8ELF tool chain is added to generate ELF image, and convert to PE/COFF. On Windows OS, set

[edk2-devel] [Patch 6/7] BaseTools: Add new CLANG8ELF tool chain for new LLVM/CLANG8

BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=1603 LLVM/CLANG8 formal release http://releases.llvm.org/download.html#8.0.0 It can be downloaded and installed in Windows/Linux/Mac OS. CLANG8ELF tool chain is added to generate ELF image, and convert to PE/COFF. On Windows OS, set

[edk2-devel] [Patch 4/7] BaseTools: Update build_rule to skip CLANG resource section generation

LLVM/CLANG doesn't support resource section generation when ELF image generated. Signed-off-by: Liming Gao --- BaseTools/Conf/build_rule.template | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/BaseTools/Conf/build_rule.template b/BaseTools/Conf/build_rule.template

[edk2-devel] [Patch 7/7] OvmfPkg: Update DSC/FDF to support CLANG8ELF tool chain

Signed-off-by: Liming Gao --- OvmfPkg/OvmfPkgIa32.dsc| 4 +++- OvmfPkg/OvmfPkgIa32.fdf| 2 +- OvmfPkg/OvmfPkgIa32X64.dsc | 4 +++- OvmfPkg/OvmfPkgIa32X64.fdf | 2 +- OvmfPkg/OvmfPkgX64.dsc | 4 +++- OvmfPkg/OvmfPkgX64.fdf | 2 +- 6 files changed, 12 insertions(+), 6 deletions(-)

[edk2-devel] [Patch 1/7] BaseTools: Add ClangBase.lds for CLANG8 tool chain with max-page-size

LLVM LLD linker doesn't support common-page-size option. So, max-page-size is used. To not impact GCC tool chain, new ClangBase.lds is added. Signed-off-by: Liming Gao --- BaseTools/Scripts/ClangBase.lds | 79 + 1 file changed, 79 insertions(+) create

[edk2-devel] [Patch 5/7] BaseTools: Update tools_def.template to directly refer to AutoGen.h

Full path $(DEST_DIR_DEBUG)\AutoGen.h is not necessary, because $(DEST_DIR_DEBUG) has been listed in $(INC) include paths. Change-Id: Iadf2c7223708468b504298f0b43034c4f117ac66 Signed-off-by: Liming Gao --- BaseTools/Conf/tools_def.template | 16 1 file changed, 8 insertions(+),

[edk2-devel] [Patch 3/7] BaseTools: Update build_rule.template for ASLC rule with full C flags

Update ASLC GCC link step with the full C compiler flags. It can make sure lto option works correctly. Signed-off-by: Liming Gao --- BaseTools/Conf/build_rule.template | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/BaseTools/Conf/build_rule.template

[edk2-devel] [Patch 2/7] BaseTools GenFw: Support CLANG8ELF with conversion ELF to PE/COFF image

CLANG8ELF tool chain generated ELF image with the different attributes in section. Update GenFw to handle them. 1. .text section with writable attribute (support) 2. .reloc section has the symbol for *ABS* (skip) Signed-off-by: Liming Gao --- BaseTools/Source/C/GenFw/Elf32Convert.c | 12

Re: [edk2-devel] [PATCH edk2-platforms 3/3] Platform/Secure96Dxe: add ACPI description of the GPIO LEDs

On Fri, 26 Apr 2019 at 16:17, Leif Lindholm wrote: > > On Fri, Apr 26, 2019 at 01:56:54PM +0200, Ard Biesheuvel wrote: > > On Fri, 26 Apr 2019 at 13:16, Leif Lindholm > > wrote: > > > > > > On Thu, Apr 25, 2019 at 02:32:54PM +0200, Ard Biesheuvel wrote: > > > > Wire up the new 96boards

Re: [edk2-devel] [PATCH edk2-platforms 3/3] Platform/Secure96Dxe: add ACPI description of the GPIO LEDs

On Fri, Apr 26, 2019 at 01:56:54PM +0200, Ard Biesheuvel wrote: > On Fri, 26 Apr 2019 at 13:16, Leif Lindholm wrote: > > > > On Thu, Apr 25, 2019 at 02:32:54PM +0200, Ard Biesheuvel wrote: > > > Wire up the new 96boards mezzanine SSDT loading support, and use it > > > to describe the four GPIO

Re: [edk2-devel] [PATCH] CryptoPkg: add issetugid declaration to fix openssl build on FreeBSD

> On Apr 26, 2019, at 6:55 AM, rebe...@bluestop.org wrote: > > On 2019-04-24 13:17, Laszlo Ersek wrote: >> >> And, again, that's exactly how the sender is displayed to me by >> Thunderbird, in my list folder only: >> >> From: Rebecca via Groups.Io >> >> Again, in email that I get directly

Re: [edk2-devel] [PATCH] CryptoPkg: add issetugid declaration to fix openssl build on FreeBSD

On 2019-04-24 13:17, Laszlo Ersek wrote: > > And, again, that's exactly how the sender is displayed to me by > Thunderbird, in my list folder only: > > From: Rebecca via Groups.Io > > Again, in email that I get directly from Rebecca, the From field looks > just fine. > > So I don't think

Re: [edk2-devel] [PATCH edk2-platforms 3/3] Platform/Secure96Dxe: add ACPI description of the GPIO LEDs

On Fri, 26 Apr 2019 at 13:16, Leif Lindholm wrote: > > On Thu, Apr 25, 2019 at 02:32:54PM +0200, Ard Biesheuvel wrote: > > Wire up the new 96boards mezzanine SSDT loading support, and use it > > to describe the four GPIO LEDs on the Secure96 mezzanine board. > > > > Contributed-under: TianoCore

Re: [edk2-devel] [PATCH edk2-platforms 3/3] Platform/Secure96Dxe: add ACPI description of the GPIO LEDs

On Thu, Apr 25, 2019 at 02:32:54PM +0200, Ard Biesheuvel wrote: > Wire up the new 96boards mezzanine SSDT loading support, and use it > to describe the four GPIO LEDs on the Secure96 mezzanine board. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ard Biesheuvel >

Re: [edk2-devel] [PATCH edk2-platforms 0/3] enable Secure96 GPIO LEDs on ACPI systems

On Thu, Apr 25, 2019 at 02:32:51PM +0200, Ard Biesheuvel wrote: > This series plumbs in the support for describing 96boards mezzanines > via ACPI. For now, only the GPIO LEDs are described: in the future, > I intend to wire up the I2C and SPI parts as well, but these are > currently untested and

Re: [edk2-devel] [PATCH edk2-platforms] Silicon/SynQuacer: add ACPI description of GPIO controller and power button

On Thu, Apr 25, 2019 at 12:51:27PM +0200, Ard Biesheuvel wrote: > Add ACPI descriptions of the GPIO and external interrupt (EXIU) > controllers as well as the power button. Note that on rev 0.3 > boards, the power button appears to reset the system (this was > not the case on rev 0.1 boards), so

Re: [edk2-devel] [PATCH v5 1/1] MdeModulePkg: BaseSerialPortLib16550: Add Mmio32 support

> -Original Message- > From: Loh, Tien Hock > Sent: Friday, April 26, 2019 2:27 PM > To: devel@edk2.groups.io; thlo...@gmail.com > Cc: Loh, Tien Hock; Wang, Jian J; Wu, Hao A > Subject: [PATCH v5 1/1] MdeModulePkg: BaseSerialPortLib16550: Add Mmio32 > support > > From: "Tien Hock, Loh" >

Re: [edk2-devel] [PATCH V3 5/8] MdeModulePkg/FirmwarePerformanceDxe: make global variable static

> -Original Message- > From: Gao, Zhichao > Sent: Friday, April 26, 2019 4:12 PM > To: Wu, Hao A; devel@edk2.groups.io; Laszlo Ersek > Cc: Laszlo Ersek; Wang, Jian J; Ni, Ray; Zeng, Star; Gao, Liming; Bi, Dandan > Subject: RE: [edk2-devel] [PATCH V3 5/8] >

Re: [edk2-devel] [PATCH V3 5/8] MdeModulePkg/FirmwarePerformanceDxe: make global variable static

> -Original Message- > From: Wu, Hao A > Sent: Friday, April 26, 2019 1:58 PM > To: devel@edk2.groups.io; Gao, Zhichao ; Laszlo > Ersek > Cc: Laszlo Ersek ; Wang, Jian J ; > Ni, Ray ; Zeng, Star ; Gao, Liming > ; Bi, Dandan > Subject: RE: [edk2-devel] [PATCH V3 5/8] >

Re: [edk2-devel] [PATCH v2] MdeModulePkg/DxeCore: Please static checker for false report

Hao: The change is good to me. Reviewed-by: Liming Gao >-Original Message- >From: Wu, Hao A >Sent: Friday, April 26, 2019 1:39 PM >To: Ard Biesheuvel ; Kinney, Michael D >; Gao, Liming ; Wang, >Jian J >Cc: edk2-devel-groups-io >Subject: RE: [PATCH v2] MdeModulePkg/DxeCore: Please

Re: [edk2-devel] [edk2-platforms/devel-MinPlatform] [patch 0/2] Remove PcdFrameworkCompatibilitySupport usage

Reviewed-by: Michael Kubacki > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Dandan Bi > Sent: Thursday, April 25, 2019 8:32 PM > To: devel@edk2.groups.io > Cc: Kubacki, Michael A ; Sinha, Ankit > ; Desimone, Nathaniel L > ; Chiu, Chasel >

[edk2-devel] [PATCH v5 1/1] MdeModulePkg: BaseSerialPortLib16550: Add Mmio32 support

From: "Tien Hock, Loh" Some busses doesn't allow 8 bit MMIO read/write, this adds support for 32 bits read/write Signed-off-by: "Tien Hock, Loh" Cc: Jian J Wang Cc: Hao Wu --- v5 - Updates function header comments - Change the implementation to eliminate unnecessary else clause v4 - Updates

Re: [edk2-devel] [PATCH 1/1] MdeModulePkg: BaseSerialPortLib16550: Add Mmio32 support

> -Original Message- > From: Wu, Hao A > Sent: Friday, April 26, 2019 1:36 PM > To: thlo...@gmail.com; devel@edk2.groups.io; Loh, Tien Hock > ; Kinney, Michael D > > Cc: Wang, Jian J > Subject: RE: [PATCH 1/1] MdeModulePkg: BaseSerialPortLib16550: Add > Mmio32 support > > >

Re: [edk2-devel] [PATCH V3 8/8] MdeModulePkg/StatusCodeHandlerRuntimeDxe: make global variable static

> -Original Message- > From: Gao, Zhichao > Sent: Friday, April 26, 2019 9:04 AM > To: devel@edk2.groups.io > Cc: Laszlo Ersek; Wang, Jian J; Wu, Hao A; Ni, Ray; Zeng, Star; Gao, Liming; > Bi, > Dandan > Subject: [PATCH V3 8/8] MdeModulePkg/StatusCodeHandlerRuntimeDxe: make > global