Reviewed-by: Bob Feng
-Original Message-
From: Srinivasan, ManickamX
Sent: Wednesday, September 13, 2023 4:56 PM
To: devel@edk2.groups.io
Cc: Srinivasan, ManickamX ; Feng, Bob C
; Gao, Liming ; Chen, Christine
; T V, Krishnamoorthy
Subject: [PATCH] Platform/Intel: Enhance
Reviewed-by: Bob Feng
-Original Message-
From: Srinivasan, ManickamX
Sent: Wednesday, August 23, 2023 3:29 PM
To: devel@edk2.groups.io
Cc: Srinivasan, ManickamX ; Feng, Bob C
; Gao, Liming ; Chen, Christine
; T V, Krishnamoorthy
Subject: [PATCH] Platform/Intel: Enhance the BOARD_ID
Reviewed-by: Bob Feng
-Original Message-
From: Chen, Christine
Sent: Thursday, June 29, 2023 11:35 AM
To: devel@edk2.groups.io
Cc: Rebecca Cran ; Gao, Liming ;
Feng, Bob C
Subject: [Patch V2 4/4] BaseTools: FMMT replace new free space fixing in replace
In FMMT replace function, when
Reviewed-by: Bob Feng
-Original Message-
From: Chen, Christine
Sent: Thursday, June 29, 2023 11:35 AM
To: devel@edk2.groups.io
Cc: Rebecca Cran ; Feng, Bob C ; Gao,
Liming
Subject: [Patch V2 3/4] BaseTools: FMMT support ELF UPLD parser
FMMT add new function to support the .elf file
Reviewed-by: Bob Feng
-Original Message-
From: Chen, Christine
Sent: Thursday, June 29, 2023 11:35 AM
To: devel@edk2.groups.io
Cc: Rebecca Cran ; Feng, Bob C ; Gao,
Liming
Subject: [Patch V2 2/4] BaseTools: FMMT replace output file is not generated
successfully
For replace function
Reviewed-by: Bob Feng
-Original Message-
From: Chen, Christine
Sent: Thursday, June 29, 2023 11:34 AM
To: devel@edk2.groups.io
Cc: Rebecca Cran ; Gao, Liming ;
Feng, Bob C
Subject: [Patch V2 1/4] BaseTools: fixing FMMT ShrinkFv issue
1. FvLength not change issue;
2. FileSystemGuid
Reviewed-by: Bob Feng
-Original Message-
From: Chen, Christine
Sent: Tuesday, April 18, 2023 5:55 PM
To: devel@edk2.groups.io
Cc: Rebecca Cran ; Feng, Bob C ; Gao,
Liming
Subject: [Patch V1 3/3] BaseTools: FMMT support ELF UPLD parser
FMMT add new function to support the .elf file
Reviewed-by: Bob Feng
-Original Message-
From: Chen, Christine
Sent: Tuesday, April 18, 2023 5:53 PM
To: devel@edk2.groups.io
Cc: Rebecca Cran ; Feng, Bob C ; Gao,
Liming
Subject: [Patch V1 2/3] BaseTools: FMMT replace output file is not generated
successfully
For replace function
This patch is good to me.
Reviewed-by: Bob Feng
Thanks,
Bob
-Original Message-
From: Chen, Christine
Sent: Tuesday, April 18, 2023 5:53 PM
To: devel@edk2.groups.io
Cc: Rebecca Cran ; Gao, Liming ;
Feng, Bob C
Subject: [Patch V1 1/3] BaseTools: fixing FMMT ShrinkFv issue
1. FvLength
Reviewed-by: Bob Feng
-Original Message-
From: Rebecca Cran
Sent: Monday, April 24, 2023 10:06 PM
To: devel@edk2.groups.io; Gao, Liming ; Feng, Bob C
; Chen, Christine
Cc: Rebecca Cran
Subject: [PATCH v2 1/1] BaseTools: Add quotes around OBJCOPY cmd in
build_rule.template
Add
Hi Rebecca,
With this patch, the UniversalPayload will be built fail on windows.
It can be reproduced with this command on windows.
edksetup
python UefiPayloadPkg\UniversalPayloadBuild.py -t VS2019
But the root cause is a bug in build_rule.template.
Under the section, 2 $(OBJCOPY) should be
Reviewed-by: Bob Feng
-Original Message-
From: devel@edk2.groups.io On Behalf Of Rebecca Cran
Sent: Thursday, March 30, 2023 1:35 AM
To: devel@edk2.groups.io
Cc: Rebecca Cran ; Gao, Liming ;
Feng, Bob C
Subject: [edk2-devel] [PATCH 1/1] Maintainers.txt: BaseTools Bob Feng ->
revie
Ray, it's merged to edk2 repo.
-Original Message-
From: Ni, Ray
Sent: Wednesday, March 15, 2023 9:12 AM
To: Palomino Sosa, Guillermo A ; Kinney,
Michael D ; Feng, Bob C ;
Gao, Liming ; devel@edk2.groups.io
Cc: Chen, Christine ; Oram, Isaac W
; Sean Brogan ;
a...@kernel.org
Subject:
Thanks Christine.
Reviewed-by: Bob Feng
-Original Message-
From: Chen, Christine
Sent: Thursday, March 9, 2023 10:55 AM
To: devel@edk2.groups.io
Cc: Kinney, Michael D ; Feng, Bob C
; Gao, Liming
Subject: [PATCH] Maintainers: Add 'Yuwei Chen' as BaseTools maintainer.
Add myself
Reviewed-by: Bob Feng
-Original Message-
From: Chen, Christine
Sent: Monday, January 30, 2023 2:27 PM
To: devel@edk2.groups.io
Cc: Feng, Bob C ; Gao, Liming
Subject: [Patch V2 3/3] [edk2-staging]BaseTools: Add new build option for
Variable default value generation
Add new build
Reviewed-by: Bob Feng
-Original Message-
From: Chen, Christine
Sent: Monday, January 30, 2023 2:27 PM
To: devel@edk2.groups.io
Cc: Feng, Bob C ; Gao, Liming
Subject: [Patch V2 2/3] [edk2-staging]BaseTools: Add new build option for
PyVfrCompiler yaml generation
Add new build option
t; > ???: tlaro...@polynum.com
> > : 2023?1?26? 18:03
> > ???: devel@edk2.groups.io
> > ??: Bob Feng ; Liming Gao
> > ; Yuwei Chen
> > ??: [PATCH 1/1] BaseTools: remove useless header inclusion
> >
> > GenFvInternalLib.
Reviewed-by: Bob Feng
-Original Message-
From: devel@edk2.groups.io On Behalf Of PierreGondois
Sent: Wednesday, January 25, 2023 5:21 PM
To: devel@edk2.groups.io
Cc: Feng, Bob C ; Gao, Liming ;
Chen, Christine ; Leif Lindholm
; Ard Biesheuvel ; Sami
Mujawar ; Laszlo Ersek
Subject
Hi Ard,
I have no objections. For the patch series,
Acked-by: Bob Feng
Thanks,
Bob
-Original Message-
From: devel@edk2.groups.io On Behalf Of Ard Biesheuvel
Sent: Saturday, January 28, 2023 1:00 AM
To: devel@edk2.groups.io; rebe...@bsdio.com; Gao, Liming
; Feng, Bob C
Cc: Leif
wrote:
>
> Konstantin,
>
>
>
> The patch missed “Signed-off-by:”, I help you add it and open a PR
> https://github.com/tianocore/edk2/pull/3909 for merge.
>
>
>
> Thanks,
>
> Bob
>
> From: devel@edk2.groups.io On Behalf Of Bob
> Feng
> Sent:
Reviewed-by: Bob Feng
From: Jake Garver
Sent: Wednesday, December 14, 2022 2:48 AM
To: Konstantin Aladyshev ; devel@edk2.groups.io
Cc: Feng, Bob C ; Gao, Liming ;
Chen, Christine
Subject: Re: [PATCH] Fix cyclic dependency error on OptionROM build
Thanks, Konstantin,
I approve this version
Reviewed-by: Bob Feng
-Original Message-
From: devel@edk2.groups.io On Behalf Of gaoliming via
groups.io
Sent: Wednesday, December 21, 2022 9:25 AM
To: 'Pedro Falcato' ; devel@edk2.groups.io
Cc: 'Marvin Häuser' ; Feng, Bob C ;
Chen, Christine
Subject: [edk2-devel] 回复: [PATCH 1/1
Thank you for fixing this issue.
Reviewed-by: Bob Feng
-Original Message-
From: Jake Garver
Sent: Tuesday, December 20, 2022 9:14 PM
To: devel@edk2.groups.io
Cc: jbra...@nvidia.com; ashishsin...@nvidia.com; Feng, Bob C
; Gao, Liming ; Chen, Christine
; Jake Garver
Subject: [PATCH
This patch is good to me.
Reviewed-by: Bob Feng
-Original Message-
From: devel@edk2.groups.io On Behalf Of Jake Garver via
groups.io
Sent: Friday, December 9, 2022 12:22 AM
To: devel@edk2.groups.io; jbra...@nvidia.com; ashishsin...@nvidia.com
Cc: Jake Garver
Subject: [edk2-devel
] [edk2-staging]BaseTools: Add new build
option for Variable default value generation
Add new build option "--gen-default-variable-bin" for Variable default value
generation from Python VFR tool's extended json output file.
Cc: Bob Feng
Cc: Liming Gao
Signed-off-by: Yuwei Chen
---
Reviewed-by: Bob Feng
-Original Message-
From: Chiang, Dakota
Sent: Tuesday, December 27, 2022 5:23 PM
To: devel@edk2.groups.io
Cc: Chiang, Dakota ; Feng, Bob C
; Gao, Liming ; Lin, Jason1
; Kumar, Rahul R
Subject: [PATCH] S-ACM entry ver 0x200 does not contain requested FMS
From
Reviewed-by: Bob Feng
-Original Message-
From: Chen, Christine
Sent: Tuesday, November 15, 2022 4:46 PM
To: devel@edk2.groups.io
Cc: Feng, Bob C ; Gao, Liming
Subject: [Patch V2 2/3] [edk2-staging]BaseTools: Add new build option for
PyVfrCompiler yaml generation
Add new build option
Reviewed-by: Bob Feng
-Original Message-
From: Kumar, Rahul R
Sent: Wednesday, November 16, 2022 9:58 AM
To: devel@edk2.groups.io; Feng, Bob C ; Gao, Liming
; Chen, Christine ; Oram, Isaac
W ; Chaganty, Rangasai V
; West, Catharine
Cc: Kumar, Rahul R
Subject: [PATCH] Silicon/Intel
Reviewed-by: Bob Feng
-Original Message-
From: Kinney, Michael D
Sent: Friday, November 4, 2022 11:31 AM
To: devel@edk2.groups.io
Cc: Feng, Bob C ; Gao, Liming ;
Chen, Christine
Subject: [Patch 6/7] BaseTools/Plugin/HostBaseUnitTestRunner: Enable gtest xml
output
REF: https
Hi Pavamana,
This is the output on my side.
py -3 BaseTools\Scripts\PatchCheck.py
edk2-devel]-[PATCH-v2]-edk2Platforms-Silicon-Add-VAB-FIT-record-types-support-in-FitGen.c.patch
Checking patch file:
edk2-devel]-[PATCH-v2]-edk2Platforms-Silicon-Add-VAB-FIT-record-types-support-in-FitGen.c.patch
Hi Pavamana,
I found there are few patch format issues. Please use
edk2\BaseTools\Scripts\PatchCheck.py to check the patch and fix them. After
that, I’ll merge it.
Thanks,
Bob
From: devel@edk2.groups.io On Behalf Of gaoliming via
groups.io
Sent: Friday, October 28, 2022 9:11 AM
To:
Reviewed-by: Bob Feng
-Original Message-
From: devel@edk2.groups.io On Behalf Of Ard Biesheuvel
Sent: Monday, October 24, 2022 2:17 PM
To: devel@edk2.groups.io
Cc: quic_llind...@quicinc.com; Gao, Liming ; Feng,
Bob C ; rebe...@bsdio.com; Ard Biesheuvel
Subject: [edk2-devel] [PATCH
Reviewed-by: Bob Feng
Thanks,
Bob
-Original Message-
From: Wu, JessyX
Sent: Tuesday, October 4, 2022 10:04 AM
To: devel@edk2.groups.io
Cc: Wu, JessyX ; Feng, Bob C ; Gao,
Liming ; Chen, Christine
Subject: [PATCH v3] remove GCC build warning
Fix gcc: warning:
-x c after last input
Reviewed-by: Bob Feng
-Original Message-
From: devel@edk2.groups.io On Behalf Of Chao Li
Sent: Thursday, October 20, 2022 5:25 PM
To: devel@edk2.groups.io
Cc: Feng, Bob C ; Gao, Liming ;
Chen, Christine
Subject: [edk2-devel] [PATCH v2] BaseTools: Fixed the multiple pairs brackets
Reviewed-by: Bob Feng
-Original Message-
From: devel@edk2.groups.io On Behalf Of Hv, Pavamana
Sent: Thursday, October 20, 2022 11:57 AM
To: devel@edk2.groups.io
Cc: Hv, Pavamana
Subject: [edk2-devel] [PATCH v2] edk2Platforms-Silicon:Add VAB FIT record types
support in FitGen.c
REF
Hi Liming, Christine,
Please help review this patch.
This patch can unblock the CI test for the change of Makefile/GNUmakefile.
https://github.com/tianocore/edk2/pull/3436
Thanks,
Bob
-Original Message-
From: devel@edk2.groups.io On Behalf Of Bob Feng
Sent: Sunday, October 16, 2022
Hi Liming, Christine,
Please review this patch.
Thanks,
Bob
-Original Message-
From: devel@edk2.groups.io On Behalf Of Bob Feng
Sent: Sunday, October 16, 2022 8:11 PM
To: devel@edk2.groups.io
Cc: Feng, Bob C ; Gao, Liming ;
Chen, Christine
Subject: [edk2-devel] [PATCH 1/1] pip
Signed-off-by: Bob Feng
Cc: Liming Gao
Cc: Yuwei Chen
---
pip-requirements.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/pip-requirements.txt b/pip-requirements.txt
index 967da7cb3783..40e9ad72ee4f 100644
--- a/pip-requirements.txt
+++ b/pip-requirements.txt
@@ -14,5 +14,5
Signed-off-by: Bob Feng
Cc: Liming Gao
Cc: Yuwei Chen
---
pip-requirements.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/pip-requirements.txt b/pip-requirements.txt
index 967da7cb3783..40e9ad72ee4f 100644
--- a/pip-requirements.txt
+++ b/pip-requirements.txt
@@ -14,5 +14,5
The syntax for Makefiles requires that indented lines s
tart with a tab, but not a space.
This change of PatchCheck.py make the patch for Makefile/GNUmakefile
pass the PatchCheck.py.
Signed-off-by: Bob Feng
Cc: Liming Gao
Cc: Yuwei Chen
---
BaseTools/Scripts/PatchCheck.py | 3 +++
1 file
.io
Cc: Wu, JessyX ; Feng, Bob C ; Gao,
Liming ; Chen, Christine
Subject: [PATCH] remove GCC build warning
Fix gcc: warning:
-x c after last input file has no effect
Change-Id: I743d47ed0cb9d2c0c099af461fa1d5e9024d9526
Cc: Bob Feng
Cc: Liming Gao
Cc: Yuwei Chen
Signed-off-by: JessyX Wu
---
Hi Pierre,
Could you split this patch into 2? One is for basetools C tool, the other is
for python tool because the python code patch will be merged to edk2-basetools
repo also.
Thanks,
Bob
-Original Message-
From: devel@edk2.groups.io On Behalf Of Bob Feng
Sent: Saturday, October 1
Reviewed-by: Bob Feng
-Original Message-
From: Rebecca Cran
Sent: Tuesday, September 20, 2022 5:39 AM
To: devel@edk2.groups.io; Feng, Bob C ; Gao, Liming
; Chen, Christine
Cc: Rebecca Cran
Subject: [PATCH 1/1] BaseTools: Fix check for ${PYTHON_COMMAND} in
Tests/GNUmakefile
When
Reviewed-by: Bob Feng
-Original Message-
From: Chen, Christine
Sent: Friday, September 16, 2022 9:51 AM
To: devel@edk2.groups.io
Cc: Feng, Bob C ; Gao, Liming
Subject: [PATCH 2/2] BaseTools/FMMT: Add Shrink Fv function
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3938
Reviewed-by: Bob Feng
-Original Message-
From: Konstantin Aladyshev
Sent: Tuesday, August 30, 2022 6:20 PM
To: devel@edk2.groups.io
Cc: Feng, Bob C ; Gao, Liming ;
Chen, Christine ; Konstantin Aladyshev
Subject: [PATCH v2] BaseTools: Support COMPAT16 section generation
Currently
This patch is good to me.
Reviewed-by: Bob Feng
-Original Message-
From: devel@edk2.groups.io On Behalf Of Konstantin
Aladyshev
Sent: Wednesday, July 20, 2022 10:01 PM
To: devel@edk2.groups.io
Cc: Feng, Bob C ; Gao, Liming ;
Chen, Christine ; Konstantin Aladyshev
Subject: [edk2
Reviewed-by: Bob Feng
-Original Message-
From: devel@edk2.groups.io On Behalf Of Konstantin
Aladyshev
Sent: Friday, July 22, 2022 11:38 PM
To: devel@edk2.groups.io
Cc: Feng, Bob C ; Gao, Liming ;
Chen, Christine ; Konstantin Aladyshev
Subject: [edk2-devel] [PATCH] BaseTools/VolInfo
Reviewed-by: Bob Feng
-Original Message-
From: devel@edk2.groups.io On Behalf Of Konstantin
Aladyshev
Sent: Friday, July 22, 2022 9:30 PM
To: devel@edk2.groups.io
Cc: Feng, Bob C ; Gao, Liming ;
Chen, Christine ; Konstantin Aladyshev
Subject: [edk2-devel] [PATCH] BaseTools/VolInfo
Reviewed-by: Bob Feng
-Original Message-
From: Konstantin Aladyshev
Sent: Thursday, July 21, 2022 9:12 PM
To: devel@edk2.groups.io
Cc: Feng, Bob C ; Gao, Liming ;
Chen, Christine ; Konstantin Aladyshev
Subject: [PATCH] BaseTools/VolInfo: Increase GUID base name string
The current
Reviewed-by: Bob Feng
-Original Message-
From: devel@edk2.groups.io On Behalf Of Konstantin
Aladyshev
Sent: Tuesday, August 30, 2022 6:15 PM
To: devel@edk2.groups.io
Cc: Feng, Bob C ; Gao, Liming ;
Chen, Christine ; Konstantin Aladyshev
Subject: [edk2-devel] [PATCH 1/6] BaseTools
Reviewed-by: Bob Feng
-Original Message-
From: devel@edk2.groups.io On Behalf Of PierreGondois
Sent: Tuesday, September 6, 2022 4:29 PM
To: devel@edk2.groups.io
Cc: Pierre Gondois ; Feng, Bob C
; Gao, Liming
Subject: [edk2-devel] [PATCH v2 02/17] BaseTools: Remove duplicated words
Reviewed-by: Bob Feng
-Original Message-
From: Konstantin Aladyshev
Sent: Tuesday, August 30, 2022 6:21 PM
To: devel@edk2.groups.io
Cc: Feng, Bob C ; Gao, Liming ;
Chen, Christine ; Konstantin Aladyshev
Subject: [PATCH v2] BaseTools: Correct initialization data size check for array
Reviewed-by: Bob Feng
-Original Message-
From: devel@edk2.groups.io On Behalf Of gaoliming via
groups.io
Sent: Wednesday, September 21, 2022 9:02 AM
To: devel@edk2.groups.io; aladyshe...@gmail.com
Cc: Feng, Bob C ; Chen, Christine
Subject: 回复: [edk2-devel] [PATCH v2] BaseTools: Add
Yes, I agree that in the case of GenCrc32 we can just set
EFI_GUIDED_SECTION_PROCESSING_REQUIRED=0 and point DataOffset to the
(EFI_GUID_DEFINED_SECTION + 4 bytes).
For this patch,
Reviewed-by: Bob Feng
-Original Message-
From: devel@edk2.groups.io On Behalf Of Konstantin
Aladyshev
Reviewed-by: Bob Feng
-Original Message-
From: Konstantin Aladyshev
Sent: Monday, September 5, 2022 5:19 PM
To: devel@edk2.groups.io
Cc: Feng, Bob C ; Gao, Liming ;
Chen, Christine ; Konstantin Aladyshev
Subject: [PATCH] BaseTools: Correct BPDG tool error prints
Popen communication
From: Foster Nong
Per SR-IOV spec,InitialVFs minimum is 0. Below code which use to calculate
SR-IOV bus number,
if InitialVFs =0, it maybe calculate the wrong bus number.
LastVF = PFRid + FirstVFOffset + (PciIoDevice->InitialVFs - 1) * VFStride
we can fix it with below code:
if
Create PR https://github.com/tianocore/edk2/pull/3378 for merge.
-Original Message-
From: devel@edk2.groups.io On Behalf Of Bob Feng
Sent: Thursday, September 22, 2022 7:11 PM
To: Kun Qin ; devel@edk2.groups.io
Cc: Gao, Liming ; Chen, Christine
; Sean Brogan
Subject: Re: [edk2-devel
Reviewed-by: Bob Feng
-Original Message-
From: Kun Qin
Sent: Thursday, September 22, 2022 4:45 AM
To: devel@edk2.groups.io
Cc: Feng, Bob C ; Gao, Liming ;
Chen, Christine ; Sean Brogan
Subject: [PATCH v1 1/1] BaseTools: Edk2ToolsBuild: Fixing pipeline build due to
path too long
Reviewed-by: Bob Feng
-Original Message-
From: Kuo, Ted
Sent: Monday, August 29, 2022 5:28 PM
To: devel@edk2.groups.io
Cc: Feng, Bob C ; Gao, Liming ;
Chen, Christine ; Hamel, Lee M
Subject: [edk2-devel][PATCH v1] BaseTools: 64bit FSP FV map file cannot be
created correctly
https
version from 0.1.28 to 0.1.29
Reviewed-by: Michael D Kinney
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Bob
> Feng
> Sent: Wednesday, September 7, 2022 8:24 AM
> To: devel@edk2.groups.io
> Cc: Feng, Bob C ; Gao, Liming
> ; Chen, Christ
features and bug fixes:
1. Revert "BaseTools: Fix DSC LibraryClass precedence rule"
Signed-off-by: Bob Feng
Cc: Liming Gao
Cc: Yuwei Chen
Cc: Rebecca Cran
---
pip-requirements.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/pip-requirements.txt b/pip-requir
Yes. I'll sync the edk2-basetools.
Thanks,
Bob
-Original Message-
From: devel@edk2.groups.io On Behalf Of Rebecca Cran
Sent: Wednesday, September 7, 2022 9:08 PM
To: devel@edk2.groups.io; Leif Lindholm ; Kinney,
Michael D ; Andrew Fish ; Michael
Kubacki ; Sean Brogan
; Barkelew, Bret
Acked-by: Bob Feng
-Original Message-
From: Leif Lindholm
Sent: Tuesday, September 6, 2022 7:54 PM
To: Ard Biesheuvel ; Rebecca Cran
Cc: devel@edk2.groups.io; Feng, Bob C ; Gao, Liming
; Kinney, Michael D
Subject: Re: [edk2-devel] [PATCH] BaseTools/GenFw AARCH64: Convert more types
features and bug fixes:
1. Fix the incremental build issue on Linux @176016387f
2. Fix DSC LibraryClass precedence rule @039bdb4d3e
3. INF should use latest Pcd value instead of default value @a512913
4. Support signtool input subject name to sign capsule @594b795
Signed-off-by: Bob Feng
Cc
Acked-by: Bob Feng
-Original Message-
From: devel@edk2.groups.io On Behalf Of gaoliming via
groups.io
Sent: Friday, August 26, 2022 10:15 AM
To: devel@edk2.groups.io
Cc: Chen, Christine ; Feng, Bob C
Subject: [edk2-devel] [edk2-stable202208 3/3] Revert "BaseTools: Fi
+ Huang Long, the bug submitter.
I am OK to revert this patch for this stable tag.
Since this patch break the MdeModulePkg build, also suggest to add this case in
edk2 CI.
Thanks,
Bob
-Original Message-
From: Kinney, Michael D
Sent: Thursday, August 25, 2022 11:44 PM
To:
Hi Liming,
This commit 039bdb4d3e96f9c9264abf135b8a0eef2e2b4860 was to fix the bug that
the basetools implementation dose not follow the dsc spec and pass the edk2 CI.
The patch was send on June 30, reviewed on July 11 and pushed on July 17. I
think there was enough time to give feedback to
Hi Liming,
Reverting patch may not a good idea, some platforms have done the
implementation based on the DSC spec, if revert, those platforms build will
break.
This commit 039bdb4d3e96f9c9264abf135b8a0eef2e2b4860 make the Basetools
behavior be consistent with DSC spec so I don't think it's a
Reviewed-by: Bob Feng
-Original Message-
From: devel@edk2.groups.io On Behalf Of Michael D Kinney
Sent: Tuesday, August 16, 2022 9:49 AM
To: devel@edk2.groups.io
Cc: Konstantin Aladyshev ; Feng, Bob C
; Gao, Liming ; Chen, Christine
Subject: [edk2-devel] [Patch edk2-stable202208 1/2
This patch is good to me.
Reviewed-by: Bob Feng
-Original Message-
From: Kinney, Michael D
Sent: Tuesday, August 16, 2022 9:49 AM
To: devel@edk2.groups.io
Cc: Konstantin Aladyshev ; Feng, Bob C
; Gao, Liming ; Chen, Christine
Subject: [Patch edk2-stable202208 2/2] BaseTools/Source
Reviewed-by: Bob Feng
-Original Message-
From: Konstantin Aladyshev
Sent: Tuesday, July 19, 2022 11:46 PM
To: devel@edk2.groups.io
Cc: Feng, Bob C ; Gao, Liming ;
Chen, Christine ; Konstantin Aladyshev
Subject: [PATCH] BaseTools/VolInfo: Show FV section boundaries
Currently
Reviewed-by: Bob Feng
-Original Message-
From: Konstantin Aladyshev
Sent: Wednesday, July 20, 2022 10:08 PM
To: devel@edk2.groups.io
Cc: Feng, Bob C ; Gao, Liming ;
Chen, Christine ; Konstantin Aladyshev
Subject: [PATCH] BaseTools/GenSec: Support EFI_SECTION_FREEFORM_SUBTYPE_GUID
Reviewed-by: Bob Feng
-Original Message-
From: Konstantin Aladyshev
Sent: Wednesday, July 20, 2022 8:01 PM
To: devel@edk2.groups.io
Cc: Feng, Bob C ; Gao, Liming ;
Chen, Christine ; Konstantin Aladyshev
Subject: [PATCH] BaseTools/VolInfo: Parse EFI_SECTION_FREEFORM_SUBTYPE_GUID
Reviewed-by: Bob Feng
-Original Message-
From: devel@edk2.groups.io On Behalf Of Konstantin
Aladyshev
Sent: Tuesday, July 19, 2022 10:27 PM
To: devel@edk2.groups.io
Cc: Feng, Bob C ; Gao, Liming ;
Chen, Christine ; Konstantin Aladyshev
Subject: [edk2-devel] [PATCH] BaseTools/GenSec
Reviewed-by: Bob Feng
-Original Message-
From: Konstantin Aladyshev
Sent: Tuesday, July 19, 2022 8:29 PM
To: devel@edk2.groups.io
Cc: Feng, Bob C ; Gao, Liming ;
Chen, Christine ; Konstantin Aladyshev
Subject: [PATCH v2] BaseTools/VolInfo: Show encapsulation sections
Currently
送时间: 2022年7月8日 19:42
> 收件人: devel@edk2.groups.io
> 抄送: Jason1 Lin ; Bob Feng
> ; Liming Gao ; Yuwei
> Chen ; Michael D Kinney
> ; Dakota Chiang
> 主题: [edk2-devel] [PATCH v3] BaseTools/Capsule: Add support for
> signtool
to
> input subject name to sign capsule file
>
Reviewed-by: Bob Feng
-Original Message-
From: Konstantin Aladyshev
Sent: Monday, July 18, 2022 5:44 PM
To: devel@edk2.groups.io
Cc: Feng, Bob C ; Gao, Liming ;
Chen, Christine ; Konstantin Aladyshev
Subject: [PATCH] BaseTools/VolInfo: Correct EFI_SECTION_VERSION display
- Correct
Copyright (c) 2022, Konstantin Aladyshev
Will be fine.
Thanks,
Bob
-Original Message-
From: devel@edk2.groups.io On Behalf Of Konstantin
Aladyshev
Sent: Sunday, July 24, 2022 4:34 PM
To: Feng, Bob C
Cc: devel@edk2.groups.io; Gao, Liming ; Chen,
Christine
Subject: Re: [edk2-devel]
Hi Konstantin,
Could you update the copyright in VolInfo.c?
Thanks,
Bob
-Original Message-
From: devel@edk2.groups.io On Behalf Of Konstantin
Aladyshev
Sent: Friday, July 22, 2022 11:38 PM
To: devel@edk2.groups.io
Cc: Feng, Bob C ; Gao, Liming ;
Chen, Christine ; Konstantin Aladyshev
Reviewed-by: Bob Feng
-Original Message-
From: Jiang, Guomin
Sent: Friday, July 15, 2022 9:51 AM
To: devel@edk2.groups.io
Cc: Feng, Bob C ; Gao, Liming ;
Chen, Christine
Subject: [Patch v2 10/11] BaseTools: Remove all UGA support
REF: https://bugzilla.tianocore.org/show_bug.cgi?id
Reviewed-by: Bob Feng
-Original Message-
From: Konstantin Aladyshev
Sent: Monday, July 18, 2022 8:56 PM
To: devel@edk2.groups.io
Cc: Feng, Bob C ; Gao, Liming ;
Chen, Christine ; Konstantin Aladyshev
Subject: [PATCH] BaseTools/VolInfo: Increase define for highest section value
Reviewed-by: Bob Feng
-Original Message-
From: Konstantin Aladyshev
Sent: Wednesday, July 13, 2022 9:11 PM
To: devel@edk2.groups.io
Cc: Feng, Bob C ; Gao, Liming ;
Chen, Christine ; Konstantin Aladyshev
Subject: [PATCH] BaseTools/VolInfo: Correct alignment attributes display
Reviewed-by: Bob Feng
-Original Message-
From: Li, Yi1
Sent: Monday, July 11, 2022 1:48 PM
To: devel@edk2.groups.io
Cc: Li, Yi1 ; Feng, Bob C ; Gao, Liming
Subject: [PATCH 1/1] BaseTools: INF should use latest Pcd value instead of
default value
This patch is a bug fix about
Upgrade the edk2-basetools version from 0.1.14 to 0.1.26
features and bug fixes:
1. Fix the incremental build issue on Linux
@176016387f
2. Fix DSC LibraryClass precedence rule
@039bdb4d3e
Signed-off-by: Bob Feng
---
pip-requirements.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion
Hello,
The "VfrCompileEnhancement" branch was created on edk2-staging repository
https://github.com/tianocore/edk2-staging/tree/VfrCompileEnhancement. This
branch is based on the edk2 SHA-1: 176016387f and it's for the enhancement
features on VfrCompile.
Best Regards
Reviewed-by: Bob Feng
-Original Message-
From: Lin, Jason1
Sent: Wednesday, July 13, 2022 1:56 PM
To: devel@edk2.groups.io
Cc: Lin, Jason1 ; Feng, Bob C ;
Gao, Liming ; Chen, Christine ;
Oram, Isaac W ; Chaganty, Rangasai V
; Chiang, Dakota
Subject: [PATCH v1] Silicon/Intel/FitGen
Reviewed-by: Bob Feng
-Original Message-
From: Chen, Christine
Sent: Thursday, June 30, 2022 5:04 PM
To: devel@edk2.groups.io
Cc: Feng, Bob C ; Gao, Liming ;
Huang, Long1 ; Ni, Ray
Subject: [PATCH 1/1] BaseTools: Fix DSC LibraryClass precedence rule
REF: https
Reviewed-by: Bob Feng
-Original Message-
From: Chen, Christine
Sent: Friday, July 8, 2022 1:45 PM
To: devel@edk2.groups.io
Cc: Feng, Bob C ; Gao, Liming
Subject: [PATCH 1/1] BaseTools: remove directly calling for gcc command
In some environment, the directly calling for gcc
Reviewed-by: Bob Feng
-Original Message-
From: Chen, Christine
Sent: Friday, July 8, 2022 9:10 PM
To: devel@edk2.groups.io
Cc: Feng, Bob C ; Gao, Liming
Subject: [PATCH 1/1] BaseTools: add '-p' for Linux 'cp' command.
Currently BaseTools use 'cp' command for PcdValueInit and GenMake
Reviewed-by: Bob Feng
-Original Message-
From: Lin, Jason1
Sent: Friday, July 8, 2022 7:42 PM
To: devel@edk2.groups.io
Cc: Lin, Jason1 ; Feng, Bob C ;
Gao, Liming ; Chen, Christine ;
Kinney, Michael D ; Chiang, Dakota
Subject: [PATCH v3] BaseTools/Capsule: Add support for signtool
: devel@edk2.groups.io; bob.c.f...@intel.com; Jeff Brasen
> >
> > Cc: 'Chen, Christine'
> > Subject: 回复: [edk2-devel] [PATCH] .gitignore: Ignore build tools
> > build logs
> >
> > External email: Use caution opening links or attachments
> >
> >
>
is used to support multiple type 2 entries up to 0x20.
Signed-off-by: Jason1 Lin
Cc: Bob Feng
Cc: Liming Gao
Cc: Yuwei Chen
Cc: Isaac W Oram
Cc: Rangasai V Chaganty
Cc: Dakota Chiang
---
Silicon/Intel/Tools/FitGen/FitGen.c | 89 +++-
Silicon/Intel/Tools/FitGen/FitGen.h | 4 +-
2
Created a PR https://github.com/tianocore/edk2/pull/3033
-Original Message-
From: devel@edk2.groups.io On Behalf Of Bob Feng
Sent: Thursday, June 30, 2022 12:11 PM
To: devel@edk2.groups.io
Cc: Kinney, Michael D ; Kubacki, Michael
Subject: [edk2-devel] [Patch V2] pip-requirements.txt
for .cpp source file
Signed-off-by: Bob Feng
Reviewed-by: Michael D Kinney
Acked-by: Michael Kubacki
---
update the commit message.
pip-requirements.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/pip-requirements.txt b/pip-requirements.txt
index 6585df201d..29424b08bd
Synced the basetools patch from edk2 repo to
edk2-basetools repo.
edk2 sha-1: 59141288716f8917968d4bb96367b7d08fe5ab8a
Update the basetools pip module version
to the latest 0.1.24.
Signed-off-by: Bob Feng
---
pip-requirements.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff
Reviewed-by: Bob Feng
-Original Message-
From: Chen, Christine
Sent: Friday, June 24, 2022 9:25 AM
To: devel@edk2.groups.io; quic_rc...@quicinc.com; Feng, Bob C
; Gao, Liming
Subject: RE: [edk2-devel] [PATCH 1/1] BaseTools/Ecc: Fix grammar in Ecc error
message
Reviewed-by: Yuwei
From: "Feng, Bob C"
Build-rules.txt lists .cc and .cpp as supported file extensions.
BaseTools commit 05217d210e introduce a regression issue that
ignore the .cc and .cpp file type.
This patch is to fix this bug.
Signed-off-by: Bob Feng
Cc: Liming Gao
Cc: Yuwei Chen
---
BaseTo
Reviewed-by: Bob Feng
-Original Message-
From: Ni, Ray
Sent: Wednesday, June 15, 2022 12:55 PM
To: devel@edk2.groups.io
Cc: Feng, Bob C ; Gao, Liming ;
Chen, Christine
Subject: [PATCH] BaseTools: output the intermediate library instance when error
occurs
When a module "M
This patch looks good to me.
Reviewed-by: Bob Feng
-Original Message-
From: Jiang, Wenyi
Sent: Friday, June 10, 2022 9:15 AM
To: devel@edk2.groups.io
Cc: Chen, Christine ; Feng, Bob C
Subject: [PATCH v3 1/1] [edk2-platforms]Tools\FitGen: Add extra parameter fixed
FIT address
From
o the type coversion from UINT64 to INT64 to do the comparsion with possible
nagative value.
Signed-off-by: Jason1 Lin
Cc: Bob Feng
Cc: Liming Gao
Cc: Yuwei Chen
Cc: Dakota Chiang
Cc: Vanessa Chuang
---
Silicon/Intel/Tools/FitGen/FitGen.c | 30 +++-
Silicon/Intel/Tools/FitGen/
1 - 100 of 762 matches
Mail list logo
