Re: [edk2-devel] [PATCH] Maintainers.txt: remove Laszlo's entries

On 3/11/24 18:49, Pedro Falcato wrote: > On Mon, Mar 11, 2024 at 3:04 AM Ni, Ray wrote: >> >> This is a good idea to have a CREDITS file in edk2 repo. >> >> Pedro, would you mind initiating one? > > Laszlo told me (in private) that he doesn't want a CREDITS entry for > him, git log is enough. >

Re: [edk2-devel] [PATCH] Maintainers.txt: remove Laszlo's entries

On 3/11/24 11:29, Zeng, Star wrote: > Thank you Laszlo. > > Is ler...@redhat.com still reachable for now ?  March 14th is my last day at Red Hat; my email access will be revoked on that day. Laszlo -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group.

Re: [edk2-devel] [PATCH v2 00/10] clean up ProcessLibraryConstructorList() declarations in SEC modules

On 3/8/24 10:13, Laszlo Ersek wrote: > On 3/5/24 12:38, Laszlo Ersek wrote: >> Bugzillas: >> - https://bugzilla.tianocore.org/show_bug.cgi?id=990 >> - https://bugzilla.tianocore.org/show_bug.cgi?id=991 >> - https://bugzilla.tianocore.org/show_bug.cgi?id=4643 >&g

Re: [edk2-devel] [edk2-platforms PATCH v2 0/4] clean up ProcessLibraryConstructorList() declarations in SEC modules

On 3/5/24 13:01, Laszlo Ersek wrote: > Bugzilla: > - https://bugzilla.tianocore.org/show_bug.cgi?id=990 > > This patch series puts the recent BaseTools feature to use in which > AutoGen generates the ProcessLibraryConstructorList() declaration in > "AutoGen.h" for

Re: [edk2-devel] [PATCH] Maintainers.txt: remove Laszlo's entries

On 3/6/24 23:22, Michael D Kinney wrote: > Reviewed-by: Michael D Kinney Merged as commit ccf91b518f22, via <https://github.com/tianocore/edk2/pull/5450>. Thank you all for everything, Laszlo >> -Original Message- >> From: devel@edk2.groups.io On Behalf Of La

Re: [edk2-devel] [PATCH v2 00/10] clean up ProcessLibraryConstructorList() declarations in SEC modules

On 3/5/24 12:38, Laszlo Ersek wrote: > Bugzillas: > - https://bugzilla.tianocore.org/show_bug.cgi?id=990 > - https://bugzilla.tianocore.org/show_bug.cgi?id=991 > - https://bugzilla.tianocore.org/show_bug.cgi?id=4643 > > CI: > - https://github.com/tianocore/edk2/pull/5442 >

Re: [edk2-devel] [PATCH v3 2/3] UefiCpuPkg: RISC-V: MMU: Support Svpbmt extension

On 3/7/24 23:00, Tuan Phan wrote: > > > On Mon, Mar 4, 2024 at 10:01 AM Laszlo Ersek <mailto:ler...@redhat.com>> wrote: > > On 3/2/24 00:20, Tuan Phan wrote: > > Thanks for the detailed review. Please see my comments below. > > > > O

Re: [edk2-devel] [PATCH] OvmfPkg/SmbiosPlatformDxe: tweak fallback release date again

On 3/7/24 10:04, joeyli via groups.io wrote: > Hi Laszlo, > > On Tue, Mar 05, 2024 at 09:53:33AM +0100, Laszlo Ersek wrote: >> On 3/4/24 12:37, joeyli via groups.io wrote: >>> Hi, >>> >>> On Wed, Feb 07, 2024 at 04:02:52PM +0800, joeyli via groups.io wrot

Re: [edk2-devel] [PATCH] MdeModulePkg/SMM: Support to unregister SMI handler inside SMI handler

s your needs. I'll probably not be around to review it, though. Cheers! Laszlo > > Thanks > Zhiguang > >> -----Original Message- >> From: Laszlo Ersek >> Sent: Thursday, January 25, 2024 6:48 PM >> To: devel@edk2.groups.io; Liu, Zhiguang >> Cc: Li

Re: [edk2-devel] [edk2-platforms PATCH v2 2/4] SimicsOpenBoardPkg: auto-gen & fix SEC ProcessLibraryConstructorList() decl

Can I please get a quick R-b for this patch -- it's urgent because of <https://edk2.groups.io/g/devel/message/116453>. Thank you, Laszlo On 3/5/24 13:01, Laszlo Ersek wrote: > declares a bogus > ProcessLibraryConstructorList() for SimicsOpenBoardPkg's SEC module. Rely > on AutoGe

Re: [edk2-devel] [PATCH v2 10/10] UefiPayloadPkg: auto-generate SEC ProcessLibraryConstructorList() decl

Can I please get a quick R-b for this patch -- it's urgent because of <https://edk2.groups.io/g/devel/message/116453>. Thank you, Laszlo On 3/5/24 12:38, Laszlo Ersek wrote: > Rely on AutoGen for declaring ProcessLibraryConstructorList(). > > Build-tested with: > >

Re: [edk2-devel] [PATCH v2 09/10] UefiCpuPkg: auto-generate SEC ProcessLibraryConstructorList() decl

Can I please get a quick R-b for this patch -- it's urgent because of <https://edk2.groups.io/g/devel/message/116453>. Thank you, Laszlo On 3/5/24 12:38, Laszlo Ersek wrote: > Rely on AutoGen for declaring ProcessLibraryConstructorList(). > > Build-tested with: > > bui

Re: [edk2-devel] [PATCH v2 08/10] IntelFsp2Pkg: auto-generate SEC ProcessLibraryConstructorList() decl

Can I please get a quick R-b for this patch -- it's urgent because of <https://edk2.groups.io/g/devel/message/116453>. Thank you, Laszlo On 3/5/24 12:38, Laszlo Ersek wrote: > Rely on AutoGen for declaring ProcessLibraryConstructorList(). > > Build-tested with: > > bui

Re: [edk2-devel] [PATCH v2 07/10] EmulatorPkg: auto-generate SEC ProcessLibraryConstructorList() decl

Can I please get a quick R-b for this patch -- it's urgent because of <https://edk2.groups.io/g/devel/message/116453>. Thank you, Laszlo On 3/5/24 12:38, Laszlo Ersek wrote: > Rely on AutoGen for declaring ProcessLibraryConstructorList(). > > Build-tested with: > > bui

Re: [edk2-devel] [PATCH v2 01/10] pip-requirements.txt: require edk2-basetools version 0.1.51

Can I please get a quick R-b for this patch -- it's urgent because of <https://edk2.groups.io/g/devel/message/116453>. Thank you, Laszlo On 3/5/24 12:38, Laszlo Ersek wrote: > The edk2-basetools commit that corresponds to edk2 commit bac9c74080cf > ("BaseTools

[edk2-devel] [PATCH] Maintainers.txt: remove Laszlo's entries

Red Hat and I have mutually and amicably agreed to separate. Remove my entries from "Maintainers.txt". Cc: Andrew Fish Cc: Ard Biesheuvel Cc: Gerd Hoffmann Cc: Jiewen Yao Cc: Leif Lindholm Cc: Michael D Kinney Cc: Rahul Kumar Cc: Ray Ni Cc: Sami Mujawar Signed-off-by: La

Re: 回复: [edk2-devel] [PATCH v1 1/1] MdeModulePkg: Warn if out of flash space when writing variables

On 3/5/24 13:44, Oliver Steffen wrote: > The root cause is of course not addressed by this, but it might also be > hard to solve. One would have to identify obsolete network/hardware > settings somehow, but there is no way to tell if a certain NIC/MAC > might come back at a later point or not.

Re: [edk2-devel] [PATCH v8 14/37] UefiCpuPkg: Add CpuMmuLib to UefiCpuPkg

In the same folder as CpuMmuLib -- no. Instances of different library classes are never placed in the same folder. Laszlo > > > Thanks, > Chao > On 2024/3/5 17:26, Laszlo Ersek wrote: >> Hello Chao, >> >> On 3/4/24 04:39, Chao Li wrote: >>> Hi Laszlo, >&g

[edk2-devel] [edk2-platforms PATCH v2 4/4] SG2042Pkg/Sec: clean up ProcessLibraryConstructorList() decl

/SecMain.inf \ -p Platform/Sophgo/SG2042_EVB_Board/SG2042.dsc -t GCC5 Cc: Sunil V L Cc: USER0FISH Cc: caiyuqing379 Cc: dahogn Cc: meng-cz Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=990 Signed-off-by: Laszlo Ersek --- Silicon/Sophgo/SG2042Pkg/Sec/SecMain.inf | 2 +- Silicon/Sophgo

[edk2-devel] [edk2-platforms PATCH v2 2/4] SimicsOpenBoardPkg: auto-gen & fix SEC ProcessLibraryConstructorList() decl

micsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc \ -t GCC5 Cc: Nate DeSimone Cc: Sai Chaganty Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=990 Signed-off-by: Laszlo Ersek --- Platform/Intel/SimicsOpenBoardPkg/SecCore/SecMain.inf | 2 +- Platform/Intel/SimicsOpenBoardPkg/SecCore/SecMain.c

[edk2-devel] [edk2-platforms PATCH v2 3/4] LoongArchQemuPkg: auto-gen & fix SEC ProcessLibraryConstructorList() decl

Platform/Loongson/LoongArchQemuPkg/Loongson.dsc -t GCC5 Cc: Bibo Mao Cc: Chao Li Cc: Xianglai li Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=990 Signed-off-by: Laszlo Ersek --- Platform/Loongson/LoongArchQemuPkg/Sec/SecMain.inf | 2 +- Platform/Loongson/LoongArchQemuPkg/Sec/SecMain.c

[edk2-devel] [edk2-platforms PATCH v2 1/4] BeagleBoardPkg: auto-generate SEC ProcessLibraryConstructorList() decl

://bugzilla.tianocore.org/show_bug.cgi?id=990 Signed-off-by: Laszlo Ersek --- Platform/BeagleBoard/BeagleBoardPkg/PrePi/PeiUniCore.inf | 2 +- Platform/BeagleBoard/BeagleBoardPkg/PrePi/PrePi.h| 6 -- 2 files changed, 1 insertion(+), 7 deletions(-) diff --git a/Platform/BeagleBoard

[edk2-devel] [edk2-platforms PATCH v2 0/4] clean up ProcessLibraryConstructorList() declarations in SEC modules

iyuqing379 Cc: dahogn Cc: meng-cz Thanks, Laszlo Laszlo Ersek (4): BeagleBoardPkg: auto-generate SEC ProcessLibraryConstructorList() decl SimicsOpenBoardPkg: auto-gen & fix SEC ProcessLibraryConstructorList() decl LoongArchQemuPkg: auto-gen & fix SEC ProcessLibraryConstructorList

[edk2-devel] [PATCH v2 10/10] UefiPayloadPkg: auto-generate SEC ProcessLibraryConstructorList() decl

/UefiPayloadPkg.dsc -t GCC5 \ -D BUILD_ARCH=X64 Cc: Gua Guo Cc: Guo Dong Cc: James Lu Cc: Sean Rhodes Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=990 Signed-off-by: Laszlo Ersek --- UefiPayloadPkg/UefiPayloadEntry/FitUniversalPayloadEntry.inf | 2 +- UefiPayloadPkg/UefiPayloadEntry

[edk2-devel] [PATCH v2 09/10] UefiCpuPkg: auto-generate SEC ProcessLibraryConstructorList() decl

: Catharine West Cc: Gerd Hoffmann Cc: Rahul Kumar Cc: Ray Ni Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=990 Signed-off-by: Laszlo Ersek --- UefiCpuPkg/SecCore/SecCore.inf | 2 +- UefiCpuPkg/SecCore/SecCoreNative.inf | 2 +- UefiCpuPkg/SecCore/SecMain.h | 12

[edk2-devel] [PATCH v2 08/10] IntelFsp2Pkg: auto-generate SEC ProcessLibraryConstructorList() decl

/IntelFsp2Pkg.dsc -t GCC5 Cc: Ashraf Ali S Cc: Chasel Chiu Cc: Duggapu Chinni B Cc: Nate DeSimone Cc: Star Zeng Cc: Susovan Mohapatra Cc: Ted Kuo Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=990 Signed-off-by: Laszlo Ersek --- IntelFsp2Pkg/FspSecCore/Fsp24SecCoreM.inf | 2 +- IntelFsp2Pkg

[edk2-devel] [PATCH v2 07/10] EmulatorPkg: auto-generate SEC ProcessLibraryConstructorList() decl

Rely on AutoGen for declaring ProcessLibraryConstructorList(). Build-tested with: build -a X64 -b DEBUG -m EmulatorPkg/Sec/Sec.inf \ -p EmulatorPkg/EmulatorPkg.dsc -t GCC5 Cc: Andrew Fish Cc: Ray Ni Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=990 Signed-off-by: Laszlo Ersek

[edk2-devel] [PATCH v2 04/10] OvmfPkg/RiscVVirt/Sec: clean up ProcessLibraryConstructorList() decl

/SecMain.inf \ -p OvmfPkg/RiscVVirt/RiscVVirtQemu.dsc -t GCC5 Cc: Andrei Warkentin Cc: Ard Biesheuvel Cc: Gerd Hoffmann Cc: Jiewen Yao Cc: Sunil V L Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=990 Signed-off-by: Laszlo Ersek --- OvmfPkg/RiscVVirt/Sec/SecMain.inf | 2 +- OvmfPkg

[edk2-devel] [PATCH v2 06/10] ArmVirtPkg: auto-generate SEC ProcessLibraryConstructorList() decl

Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=990 Signed-off-by: Laszlo Ersek --- ArmVirtPkg/PrePi/ArmVirtPrePiUniCoreRelocatable.inf | 2 +- ArmVirtPkg/PrePi/PrePi.c| 6 -- 2 files changed, 1 insertion(+), 7 deletions(-) diff --git a/ArmVirtPkg/PrePi

[edk2-devel] [PATCH v2 05/10] ArmPlatformPkg: auto-generate SEC ProcessLibraryConstructorList() decl

-t GCC5 Cc: Ard Biesheuvel Cc: Leif Lindholm Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=990 Signed-off-by: Laszlo Ersek --- ArmPlatformPkg/PrePeiCore/PrePeiCoreMPCore.inf | 2 +- ArmPlatformPkg/PrePeiCore/PrePeiCoreUniCore.inf | 2 +- ArmPlatformPkg/PrePi/PeiMPCore.inf

[edk2-devel] [PATCH v2 03/10] OvmfPkg/IntelTdx: auto-gen & fix SEC ProcessLibraryConstructorList() decl

Cc: Ard Biesheuvel Cc: Gerd Hoffmann Cc: Jiewen Yao Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=990 Signed-off-by: Laszlo Ersek --- OvmfPkg/IntelTdx/Sec/SecMain.inf | 2 +- OvmfPkg/IntelTdx/Sec/SecMain.c | 3 +-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/OvmfPkg

[edk2-devel] [PATCH v2 02/10] OvmfPkg: auto-generate (and fix) SEC ProcessLibraryConstructorList() decl

Cc: Erdem Aktas Cc: Gerd Hoffmann Cc: Jiewen Yao Cc: Michael Roth Cc: Min Xu Cc: Tom Lendacky Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=990 Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=4643 Signed-off-by: Laszlo Ersek --- OvmfPkg/Sec/SecMain.inf | 2 +- OvmfPkg/Sec/SecMain.c

[edk2-devel] [PATCH v2 00/10] clean up ProcessLibraryConstructorList() declarations in SEC modules

Cc: Sean Brogan Cc: Sean Rhodes Cc: Star Zeng Cc: Sunil V L Cc: Susovan Mohapatra Cc: Ted Kuo Cc: Tom Lendacky Cc: Yuwei Chen Thanks, Laszlo Laszlo Ersek (10): pip-requirements.txt: require edk2-basetools version 0.1.51 OvmfPkg: auto-generate (and fix) SEC ProcessLibraryConstructorList(

[edk2-devel] [PATCH v2 01/10] pip-requirements.txt: require edk2-basetools version 0.1.51

Vagedes Cc: Liming Gao Cc: Michael D Kinney Cc: Rebecca Cran Cc: Sean Brogan Cc: Yuwei Chen Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=991 Signed-off-by: Laszlo Ersek --- pip-requirements.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pip-requirem

Re: [edk2-devel] [PATCH v8 14/37] UefiCpuPkg: Add CpuMmuLib to UefiCpuPkg

Hello Chao, On 3/4/24 04:39, Chao Li wrote: > Hi Laszlo, > > OK. > > When I discussed the CpuMmuLib API as a public API with Ray in the early > days, the API recommended by Ray should be the patch 13 in this series, > which only contains set/get memory region attribute, but in the first >

Re: [edk2-devel] [PATCH] OvmfPkg/SmbiosPlatformDxe: tweak fallback release date again

On 3/4/24 12:37, joeyli via groups.io wrote: > Hi, > > On Wed, Feb 07, 2024 at 04:02:52PM +0800, joeyli via groups.io wrote: >> On Wed, Feb 07, 2024 at 03:55:49PM +0800, joeyli wrote: >>> Hi Laszlo, >>> >>> First, thanks for your review! >>> &

Re: 回复: [edk2-devel] [PATCH v1 1/1] MdeModulePkg: Warn if out of flash space when writing variables

>> 抄送: Oliver Steffen ; Bob Feng >> ; Liming Gao ; Rebecca >> Cran ; Yuwei Chen ; Gerd >> Hoffmann ; Laszlo Ersek >> 主题: [edk2-devel] [PATCH v1 1/1] MdeModulePkg: Warn if out of flash space >> when writing variables >> >> Emit a DEBUG_WARN message if

Re: [edk2-devel] [PATCH v3 2/3] UefiCpuPkg: RISC-V: MMU: Support Svpbmt extension

On 3/2/24 00:20, Tuan Phan wrote: > Thanks for the detailed review. Please see my comments below. > > On Fri, Mar 1, 2024 at 4:14 AM Laszlo Ersek <mailto:ler...@redhat.com>> wrote: > > On 3/1/24 02:29, Tuan Phan wrote: > > The GCD EFI_MEMORY_UC and E

Re: [edk2-devel] [PATCH v1 1/1] MdeModulePkg: Warn if out of flash space when writing variables

his new message helps identifying this condition. > > Cc: Bob Feng > Cc: Gerd Hoffmann > Cc: Laszlo Ersek > Cc: Liming Gao > Cc: Rebecca Cran > Cc: Yuwei Chen > > Signed-off-by: Oliver Steffen > --- > MdeModulePkg/Universal/Variable/RuntimeDxe/V

Re: [edk2-devel] [v2] BaseTools/AutoGen: declare ProcessLibraryConstructorList() for SEC modules

On 2/28/24 00:41, Rebecca Cran wrote: > edk2-basetools v0.1.50 has just been published so we're back up and > running. > > I'll work my way through the backlog of BaseTools changes in the next > few days. Thanks! Once you merge and make a

Re: [edk2-devel] [PATCH v2 00/10] OvmfPkg/ResetVector: cleanup and add 5-level paging support.

On 3/1/24 08:43, Gerd Hoffmann wrote: > So I ran with the suggestion by Laszlo to move the page table setup into > macros and untangle the non-CoCo / TDX / SEV code paths. The first five > patches of the series are doing that (without functional changes). > > Support for 5-level paging is added

Re: [edk2-devel] [PATCH v2] UefiCpuPkg/CpuPageTableLib: Fix IN OUT parameters marked as IN

bSetPle(): Ple > PageTableLibSetPnle(): Pnle > > Reviewed-by: Ray Ni > Signed-off-by: Zhou Jianfeng > Cc: Ray Ni > Cc: Laszlo Ersek > Cc: Rahul Kumar > Cc: Gerd Hoffmann > --- > .../Library/CpuPageTableLib/CpuPageTableMap.c | 32 +-- > 1 file chan

Re: [edk2-devel] [PATCH v1] MdeModulePkg/Core/Pei: Improve the copy performance

On 3/1/24 08:11, Li, Zhihao wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4697 > > EvacuateTempRam function will copy the temporary memory context to the rebased > pages and the raw pages. Migrations of rebased PEIMs is from cache to memory, > while raw PEIMs is from memory to

Re: [edk2-devel] [PATCH v3 0/4] Support to unregister SMI handler inside SMI handler

On 3/1/24 04:01, Zhiguang Liu wrote: > This patch set is to support to unregister SMI handler inside SMI handler, > also add check to not allow unregister SMI handler in other SMI handler. > This patch set also have the same logic in StandaloneMmPkg. > Because no change on the first patch, I kept

Re: [edk2-devel] [PATCH] UefiCpuPkg/CpuPageTableLib: qualify page table accesses as volatile

On 3/1/24 03:54, Zhou Jianfeng wrote: > Add volatile qualifier to page table related variable to prevent > compiler from optimizing away the variables which may lead to > unexpected result. > > Signed-off-by: Zhou Jianfeng > Cc: Ray Ni > Cc: Laszlo Ersek > Cc: Rahul Ku

Re: [edk2-devel] [PATCH v2 00/10] OvmfPkg/ResetVector: cleanup and add 5-level paging support.

On 3/1/24 08:43, Gerd Hoffmann wrote: > [...] For future patch submissions: please include the Cc: tags in the commit message bodies; PatchCheck.py (also part of CI) enforces that now. Thanks Laszlo -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group.

Re: [edk2-devel] [PATCH v2 09/10] OvmfPkg/ResetVector: leave SEV VC handler installed longer

On 3/1/24 15:52, Gerd Hoffmann wrote: > Hi, > >>> OneTimeCall CheckSevFeatures >>> +cmp byte[WORK_AREA_GUEST_TYPE], 1 >>> +jnz NoSevIa32 >>> +OneTimeCall SevClearVcHandlerAndStack >>> >>> +NoSevIa32: >>> ; >>> ; Restore initial EAX value into the EAX

Re: 回复: [edk2-devel] [edk2-InfSpecification PATCH 0/2] README: INF_VERSION >= 1.30: declare ProcessLibraryCon...() for SEC modules

On 3/1/24 13:52, gaoliming via groups.io wrote: > Looks good. Reviewed-by: Liming Gao Thank you, merged as commit range a31e3c842bee..1ea6546578fe. Laszlo > >> -邮件原件- >> 发件人: devel@edk2.groups.io 代表 Laszlo Ersek >> 发送时间: 2024年2月25日 5:29 >> 收件人: edk2-de

Re: 回复: [edk2-devel] [edk2-BuildSpecification PATCH 0/3] AutoGen.h: declare ProcessLibraryConstructorList() for SEC modules

On 3/1/24 13:53, gaoliming via groups.io wrote: > Looks good. Reviewed-by: Liming Gao Thank you, merged as commit range db69f5661cae..7a7165a7d199. Laszlo > >> -邮件原件- >> 发件人: devel@edk2.groups.io 代表 Laszlo Ersek >> 发送时间: 2024年2月25日 5:24 >> 收件人: edk2-de

Re: [edk2-devel] [PATCH v2 10/10] OvmfPkg/ResetVector: wire up 5-level paging for SEV

only make the macros visible, but also rearrange how the code (the binary instructions) are laid out in the reset vector -- however, that should not be a problem. Reviewed-by: Laszlo Ersek > > Signed-off-by: Gerd Hoffmann > --- > OvmfPkg/ResetVector/Ia32/AmdSev.asm | 16 ++

Re: [edk2-devel] [PATCH v2 09/10] OvmfPkg/ResetVector: leave SEV VC handler installed longer

mall, *optional*, simplification, IIUC); however, I don't understand why you didn't pick up Tom's R-b. I'm ready to merge this (adding Tom's R-b, if you, Gerd, confirm that that's what you want). Having deferred to Tom's judgement on this: Acked-by: Laszlo Ersek -=-=-=-=-=-=-=-=-=-=-=

Re: [edk2-devel] [PATCH v2 08/10] OvmfPkg/ResetVector: wire up 5-level paging for TDX

L" scope. (My proposal under v1 patch#6 was: %if PG_5_LEVEL cmp eax, TDX_AP_5_LEVEL jne CheckForSev Enable5LevelPaging jmp SetCr3 CheckForSev: %endif ) Did you place the "CheckForSev:" label intentionally outside of the %if scope? If it was intent

Re: [edk2-devel] [PATCH v2 06/10] OvmfPkg/ResetVector: add 5-level paging support

SetCr3ForPageTables64: > ; normal (non-CoCo) workflow > ; > ClearOvmfPageTables > +%if PG_5_LEVEL > +Check5LevelPaging Paging4Level > +CreatePageTables5Level 0 > +Enable5LevelPaging > +jmp SetCr3 > +Paging4Level: > +%endif > CreatePage

Re: [edk2-devel] [PATCH] UefiCpuPkg/CpuPageTableLib: qualify page table accesses as volatile

On 3/1/24 03:54, Zhou Jianfeng wrote: > Add volatile qualifier to page table related variable to prevent > compiler from optimizing away the variables which may lead to > unexpected result. > > Signed-off-by: Zhou Jianfeng > Cc: Ray Ni > Cc: Laszlo Ersek > Cc: Rahul Ku

Re: [edk2-devel] [PATCH v3 4/4] StandaloneMmPkg: Disallow unregister MMI handler in other MMI handler

ler in other MMI handler. > > Cc: Liming Gao > Cc: Jiaxin Wu > Cc: Ray Ni > Cc: Laszlo Ersek > Cc: Ard Biesheuvel > Cc: Sami Mujawar > Cc: Ray Ni > Signed-off-by: Zhiguang Liu > --- > StandaloneMmPkg/Core/Mmi.c | 32 +++- >

Re: [edk2-devel] [PATCH v3 2/4] MdeModulePkg/SMM: Disallow unregister SMI handler in other SMI handler

ler in other SMI handler. > > Cc: Liming Gao > Cc: Jiaxin Wu > Cc: Ray Ni > Cc: Laszlo Ersek > Signed-off-by: Zhiguang Liu > --- > MdeModulePkg/Core/PiSmmCore/Smi.c | 29 + > 1 file changed, 21 insertions(+), 8 deletions(-) > > d

Re: [edk2-devel] [PATCH v3 2/3] UefiCpuPkg: RISC-V: MMU: Support Svpbmt extension

On 3/1/24 02:29, Tuan Phan wrote: > The GCD EFI_MEMORY_UC and EFI_MEMORY_WC memory attributes will be > supported when Svpbmt extension available. > > Cc: Gerd Hoffmann > Cc: Laszlo Ersek > Cc: Rahul Kumar > Cc: Ray Ni > Signed-off-by: Tuan Phan > --- >

Re: [edk2-devel] [v2] BaseTools/AutoGen: declare ProcessLibraryConstructorList() for SEC modules

Hi Mike, can you please comment on the Build and Inf spec changes proposed in this thread? Thanks, Laszlo On 2/24/24 21:59, Laszlo Ersek wrote: > v1 posting: > > https://edk2.groups.io/g/devel/message/115193 > msgid <36593e23-d3e8-b71a-808d-ef94260b5...@redhat.com

Re: [edk2-devel] [PATCH v8 14/37] UefiCpuPkg: Add CpuMmuLib to UefiCpuPkg

On 3/1/24 02:26, Chao Li wrote: > Hi Ray, Lazslo, > > This library is almost complete to refactored, it refer to ARM and > RISC-V version, the API include set/get memory region attribute. > > I have one last question, in ARM and RISC-V version, even LoongArch old > and current version, they all

Re: [edk2-devel] [PATCH] BaseTools: PcdValueInit enhancement

On 3/1/24 03:10, Yuting Yang wrote: > Enhance PcdValueInit for storage saving > > Cc: Rebecca Cran rebe...@bsdio.com > Cc: Liming Gao gaolim...@byosoft.com.cn > Cc: Bob Feng bob.c.f...@intel.com > Signed-off-by: Yuting Yang > --- > .../Source/Python/Workspace/DscBuildData.py | 43

Re: [edk2-devel] [PATCH v2 1/1] UefiCpuPkg/MpInitLib: add struct MP_HAND_OFF_CONFIG

On 2/28/24 12:48, Gerd Hoffmann wrote: > Move the WaitLoopExecutionMode and StartupSignalValue fields to a > separate HOB with the new struct. > > WaitLoopExecutionMode and StartupSignalValue are independent of > processor index ranges; they are global to MpInitLib (i.e., the entire > system).

Re: [edk2-devel] 回复: [PATCH] BaseTools/AutoGen: declare ProcessLibraryConstructorList() for SEC modules

On 2/25/24 04:32, gaoliming via groups.io wrote: > Laszlo: > Thanks for your work to make sure this issue be fixed. I agree this change. > Reviewed-by: Liming Gao Thanks; merged as commit bac9c74080cf, via . -=-=-=-=-=-=-=-=-=-=-=- Groups.io

Re: [edk2-devel] [PATCH v4 0/3] OvmfPkg: Add support for 5-level paging

On 2/22/24 11:54, Gerd Hoffmann wrote: > Patch #1 + #2 fix MdeModulePkg/DxeIplPeim to not assert in case a > 5-level enabled build runs in 4-level paging mode. > > Patch #3 updates PlatformInitLib for 5-level paging support (update > PhysBits calculation). > > v4: > - drop OvmfPkg/ResetVecor

Re: [edk2-devel] [edk2-redfish-client][PATCH 00/13] use Redfish HTTP protocol

Hi Nickle, On 2/29/24 09:52, Nickle Wang via groups.io wrote: > Redfish HTTP protocol is introduced to edk2 RedfishPkg. Update > RedfishClientPkg to use RedfishHttpLib. And remove the use of > RedfishHttpCacheLib. > > I also replace several functions from RedfishLib with the function >

Re: [edk2-devel] [PATCH v2 1/1] UefiCpuPkg/MpInitLib: add struct MP_HAND_OFF_CONFIG

t;MpHandOff->CpuCount = CpusInHob; > - > - if (CpuMpData->ApLoopMode != ApInHltLoop) { > -MpHandOff->StartupSignalValue= MP_HAND_OFF_SIGNAL; > -MpHandOff->WaitLoopExecutionMode = sizeof (VOID *); > - } > } > >

Re: [edk2-devel] CI: GCC13 and lcov problem

On 2/28/24 14:59, Oliver Steffen wrote: > Hi, > > I am working on switching the Linux CI jobs over to the Fedora 39 image > which comes with gcc 13. > > Unfortunately, some jobs fail due to some error related to lcov / > geninfo, see below. > > Does anybody know from the top of the head what

Re: [edk2-devel] [PATCH 1/1] MdeModulePkg: Load Serial driver earlier in DXE

On 2/28/24 17:27, Albecki, Mateusz wrote: > Sorry, I didn't want to make an impression that I expected solution to > be delivered, I was merely trying to explain some of the complexity we > are trying to handle on our side and why we didn't went for SerialDxe > and instead opted to make

Re: [edk2-devel] [PATCH 02/10] OvmfPkg/ResetVector: add ClearOvmfPageTables macro

On 2/28/24 09:22, Gerd Hoffmann wrote: > On Wed, Feb 28, 2024 at 05:09:32AM +0100, Laszlo Ersek wrote: >> On 2/22/24 12:54, Gerd Hoffmann wrote: >>> Move code to clear the page tables to a nasm macro. >>> No functional change. >>> >>> Signed-off-by: Ge

Re: [edk2-devel] [PATCH 1/1] MdeModulePkg: Load Serial driver earlier in DXE

On 2/27/24 18:15, Albecki, Mateusz wrote: > Is the idea to refactor PciSioSerialDxe to extract functions that access > the HW and wrap it in the SerialPortLib instance? That solution would > still save us some maintenance cost. However exploring the idea further > I see following problems: > > 1.

Re: [edk2-devel] [PATCH v2 4/4] StandaloneMmPkg: Disallow unregister MMI handler in other MMI handler

MMI handler in other MMI handler. > > Cc: Liming Gao > Cc: Jiaxin Wu > Cc: Ray Ni > Cc: Laszlo Ersek > Cc: Ard Biesheuvel > Cc: Sami Mujawar > Cc: Ray Ni > Signed-off-by: Zhiguang Liu > --- > StandaloneMmPkg/Core/Mmi.c | 35 ++- >

Re: [edk2-devel] [PATCH v2 3/4] StandaloneMmPkg: Support to unregister MMI handler inside MMI handler

; Cc: Jiaxin Wu > Cc: Ray Ni > Cc: Laszlo Ersek > Cc: Ard Biesheuvel > Cc: Sami Mujawar > Signed-off-by: Zhiguang Liu > --- > StandaloneMmPkg/Core/Mmi.c | 9 +++-- > 1 file changed, 7 insertions(+), 2 deletions(-) > > diff --git a/StandaloneMmPkg/Core/Mm

Re: [edk2-devel] [PATCH v2 2/4] MdeModulePkg/SMM: Disallow unregister SMI handler in other SMI handler

SMI handler in other SMI handler. > > Cc: Liming Gao > Cc: Jiaxin Wu > Cc: Ray Ni > Cc: Laszlo Ersek > Signed-off-by: Zhiguang Liu > --- > MdeModulePkg/Core/PiSmmCore/Smi.c | 32 +++ > 1 file changed, 24 insertions(+), 8 deletions(-) >

Re: [edk2-devel] Tagging and releases of edk2-basetools

On 2/28/24 02:15, Rebecca Cran wrote: > edk2-basetools is finally fixed and releases can once again be published > to PyPI. > > However, in moving from setup.py to pyproject.toml the process has > changed, and Joey suggested the old way might have been chosen > deliberately to be different from

Re: [edk2-devel] [PATCH 09/10] OvmfPkg/ResetVector: leave SEV VC handler installed longer

On 2/22/24 12:54, Gerd Hoffmann wrote: > When running in SEV mode keep the VC handler installed. > Add a function to uninstall it later. > > This allows using the cpuid instruction in SetCr3ForPageTables64, > which is needed to check for la57 & 1G page support. > > Signed-off-by: Gerd Hoffmann

Re: [edk2-devel] [PATCH 10/10] OvmfPkg/ResetVector: wire up 5-level paging for SEV

On 2/22/24 12:54, Gerd Hoffmann wrote: > Removes the GetSevCBitMaskAbove31 OneTimeCall because we need that twice > (for 4-level and 5-level paging). Open code the single instruction left > in that function instead. > > Signed-off-by: Gerd Hoffmann > --- > OvmfPkg/ResetVector/Ia32/AmdSev.asm

Re: [edk2-devel] [PATCH 08/10] OvmfPkg/ResetVector: wire up 5-level paging for TDX

On 2/22/24 12:54, Gerd Hoffmann wrote: > BSP workflow is quite simliar to the non-coco case. > > TDX_WORK_AREA_PGTBL_READY is used to record the paging mode: > 1 == 4-level paging > 2 == 5-level paging > > APs will look at TDX_WORK_AREA_PGTBL_READY to figure whenever > they should enable

Re: [edk2-devel] [PATCH 07/10] OvmfPkg/ResetVector: print post codes for 4/5 level paging

cate 5-level paging > +debugShowPostCode 0x51 > + > ; level 5 > mov dword[PT_ADDR (0)], PT_ADDR (0x1000) + PAGE_PDE_DIRECTORY_ATTR > mov dword[PT_ADDR (4)], %1 Reviewed-by: Laszlo Ersek -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sen

Re: [edk2-devel] [PATCH 06/10] OvmfPkg/ResetVector: add 5-level paging support

On 2/22/24 12:54, Gerd Hoffmann wrote: > Add macros to check for 5-level paging and gigabyte page support. > Enable 5-level paging for the non-confidential-computing case. > > Signed-off-by: Gerd Hoffmann > --- > OvmfPkg/ResetVector/ResetVector.inf | 1 + >

Re: [edk2-devel] [PATCH 05/10] OvmfPkg/ResetVector: split SEV and non-CoCo workflows

> - > -ClearOvmfPageTables > CreatePageTables4Level edx > - > ; Clear the C-bit from the GHCB page if the SEV-ES is enabled. > OneTimeCall SevClearPageEncMaskForGhcbPage > jmp SetCr3 Nice. The patch also sneakily reorders ClearOvm

Re: [edk2-devel] [PATCH 04/10] OvmfPkg/ResetVector: split TDX BSP workflow

gt; > -; TDX will do some PostBuildPages task, such as setting > -; byte[TDX_WORK_AREA_PGTBL_READY]. > -OneTimeCall TdxPostBuildPageTables > +TdxBspInit: > +; > + ; TDX BSP workflow > +; > +ClearOvmfPageTables > +CreatePageTables4Level 0 >

Re: [edk2-devel] [PATCH 03/10] OvmfPkg/ResetVector: add CreatePageTables4Level macro

PT_ADDR (0x2000 - 8)) + 4], edx > -looppageTableEntriesLoop > +CreatePageTables4Level edx > > ; Clear the C-bit from the GHCB page if the SEV-ES is enabled. > OneTimeCall SevClearPageEncMaskForGhcbPage Nice. "--color-moved=zebra" is really useful fo

Re: [edk2-devel] [PATCH 02/10] OvmfPkg/ResetVector: add ClearOvmfPageTables macro

l the label ..@clearPageTablesMemoryLoop ? According to the documentation, that seems to be the safest / most robust label type to be used inside macros. Reviewed-by: Laszlo Ersek Thanks Laszlo > @@ -69,22 +87,7 @@ SetCr3ForPageTables64: > OneTimeCall GetSevCBitMaskAbove31 >

Re: [edk2-devel] [PATCH 1/1] UefiCpuPkg/MpInitLib: add struct MP_HAND_OFF_CONFIG

On 2/27/24 12:41, Gerd Hoffmann wrote: > Move the WaitLoopExecutionMode and StartupSignalValue fields to a > separate HOB with the new struct. > > Signed-off-by: Gerd Hoffmann > --- > UefiCpuPkg/Library/MpInitLib/MpHandOff.h | 13 ++-- > UefiCpuPkg/Library/MpInitLib/MpLib.h | 3 +- >

Re: [edk2-devel] [PATCH 1/1] UefiCpuPkg/MpInitLib: add struct MP_HAND_OFF_CONFIG

other subthread Re: [edk2-devel] CodeQL Analysis in edk2 msgid: <80abb140-9a9c-43b8-ba0b-d8ea631d9...@linux.microsoft.com> https://edk2.groups.io/g/devel/message/116054 I suggest replacing this with: if (MpHandOffConfig == NULL) { DEBUG (( DEBUG_ERROR, "%

Re: [edk2-devel] CodeQL Analysis in edk2

On 2/27/24 17:04, Michael Kubacki wrote: > Hi Gerd, > > There is a way to suppress results explained here: > https://github.com/tianocore/edk2/tree/master/BaseTools/Plugin/CodeQL#filter-patterns > > A real-world example is here: >

Re: [edk2-devel] [PATCH v3 4/4] OvmfPkg/PlatformPei: log pei memory cap details

On 2/27/24 09:44, Gerd Hoffmann wrote: > On Thu, Feb 15, 2024 at 09:24:41AM +0100, Laszlo Ersek wrote: >> >> Reviewed-by: Laszlo Ersek >> >> This series is now ready for merging, as far as I'm concerned (thanks >> for the updates in the other patches too, I've

Re: [edk2-devel] [PATCH v4 0/3] OvmfPkg: Add support for 5-level paging

Hi Liming, can you please check the first two patches in the series? They should be easy to review. Thanks! Laszlo On 2/22/24 11:54, Gerd Hoffmann wrote: > Patch #1 + #2 fix MdeModulePkg/DxeIplPeim to not assert in case a > 5-level enabled build runs in 4-level paging mode. > > Patch #3

Re: [edk2-devel] [PATCH v3 0/6] UefiCpuPkg/MpInitLib: Add support for multiple MP_HAND_OFF HOBs

aszlo > > Thanks, > Ray >> -Original Message- >> From: devel@edk2.groups.io On Behalf Of Laszlo >> Ersek >> Sent: Monday, February 26, 2024 11:20 PM >> To: devel@edk2.groups.io; kra...@redhat.com >> Cc: Ni, Ray ; Kumar, Rahul R ; >> O

Re: [edk2-devel] [PATCH] NetworkPkg:Resolved Consecutive Pxe-Http Boot Issue

velopment (CC'd), so I figure bug analysis and bugfix posting should occur on their normal development mailing list. Laszlo > -Original Message- > From: Sivaraman Nainar > Sent: Monday, February 26, 2024 4:01 PM > To: devel@edk2.groups.io; Sivaraman Nainar ; Laszlo Ersek &g

Re: [edk2-devel] [PATCH v3 0/6] UefiCpuPkg/MpInitLib: Add support for multiple MP_HAND_OFF HOBs

On 2/26/24 16:19, Laszlo Ersek wrote: > On 2/22/24 17:01, Gerd Hoffmann wrote: >> Needed to boot guests with thousands of vcpus. >> >> v3: >> - refine comments and commit messages. >> - fix MaxCpusPerHob calculation. >> - pick up review tags. >>

Re: [edk2-devel] [PATCH v3 0/6] UefiCpuPkg/MpInitLib: Add support for multiple MP_HAND_OFF HOBs

Hi Joey, On 2/26/24 16:41, Joey Vagedes wrote: > Hi Lazlo, > > I just looked at the pipelines - Looks like everything is fine, there is just > currently a backup of runners of jobs in the runners. It is common for jobs > that end in CODE_COVERAGE to appear frozen in queued status, but this is

Re: [edk2-devel] [PATCH v3 0/6] UefiCpuPkg/MpInitLib: Add support for multiple MP_HAND_OFF HOBs

On 2/26/24 16:41, Joey Vagedes via groups.io wrote: > Taking a look at all the runners > (https://dev.azure.com/tianocore/edk2-ci/_settings/buildqueue?_a=concurrentJobs > [Click "Microsoft Hosted", "View in-progress jobs"]), I don't see any > runners that are frozen, which is why it appears it's

Re: [edk2-devel] [PATCH 1/1] MdeModulePkg: Load Serial driver earlier in DXE

On 2/26/24 16:13, Albecki, Mateusz wrote: > 1. Using SerialDxe instead of PciSioSerialDxe - from our perspective > the main idea is to avoid maintaining our own implementation of > functions that actually communicate with UART controller. To use > SerialDxe we would have to still maintain our own

Re: [edk2-devel] [PATCH v3 0/6] UefiCpuPkg/MpInitLib: Add support for multiple MP_HAND_OFF HOBs

4a3 ! 1: ecd6c4bb3396 UefiCpuPkg/MpInitLib: Add support for multiple HOBs to GetMpHandOffHob @@ Commit message Signed-off-by: Gerd Hoffmann Message-Id: <20240222160106.686484-2-kra...@redhat.com> +Reviewed-by: Ray Ni +Reviewed-by: Laszlo Ersek ## Uef

Re: [edk2-devel] [PATCH v3 0/6] UefiCpuPkg/MpInitLib: Add support for multiple MP_HAND_OFF HOBs

On 2/22/24 17:01, Gerd Hoffmann wrote: > Needed to boot guests with thousands of vcpus. > > v3: > - refine comments and commit messages. > - fix MaxCpusPerHob calculation. > - pick up review tags. > - add patch to speed up GetBspNumber a bit. > v2: > - rework HOB loops for better

Re: [edk2-devel] [PATCH v3 6/6] UefiCpuPkg/MpInitLib: return early in GetBspNumber()

On 2/22/24 17:01, Gerd Hoffmann wrote: > After finding the BSP Number return the result instead of > continuing to loop over the remaining processors. > > Suggested-by: Laszlo Ersek > Signed-off-by: Gerd Hoffmann > --- > UefiCpuPkg/Library/MpInitLib/MpLib.c | 11

Re: [edk2-devel] [PATCH v3 6/6] UefiCpuPkg/MpInitLib: return early in GetBspNumber()

On 2/23/24 03:33, Ni, Ray wrote: >> + ASSERT (FALSE); > > How about ASSERT (EFI_NOT_FOUND)? Which is more meaningful than FALSE. I'll edit the patch -- assuming you mean ASSERT_EFI_ERROR (EFI_NOT_FOUND); Laszlo > > No matter you change or not, Reviewed-by: Ray Ni > >> + return 0; >> }

Re: [edk2-devel] [PATCH v3 5/6] UefiCpuPkg/MpInitLib: Add support for multiple HOBs to SaveCpuMpData()

On 2/23/24 03:16, Ni, Ray wrote: > > > Thanks, > Ray >> -Original Message- >> From: Gerd Hoffmann >> Sent: Friday, February 23, 2024 12:01 AM >> To: devel@edk2.groups.io >> Cc: Laszlo Ersek ; Ni, Ray ; Kumar, >> Rahul R ; Oliver Steff

Re: [edk2-devel] [PATCH v3 5/6] UefiCpuPkg/MpInitLib: Add support for multiple HOBs to SaveCpuMpData()

t; - MpHandOff->Info[Index].StartupSignalAddress= > (UINT64)(UINTN)CpuMpData->CpuData[Index].StartupApSignal; > - MpHandOff->Info[Index].StartupProcedureAddress = > (UINT64)(UINTN)>CpuData[Index].ApFunction; > + MpHandOff->Info[Index-HobBase].Startup

Re: [edk2-devel] [PATCH v3 4/6] UefiCpuPkg/MpInitLib: Add support for multiple HOBs to MpInitLibInitialize

--- > 1 file changed, 47 insertions(+), 21 deletions(-) Based on comparison against v2 (commit message update, plus plan to extract WaitLoopExecutionMode and StartupSignalValue to a new, library-internal, HOB): Reviewed-by: Laszlo Ersek -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all

  1   2   3   4   5   6   7   8   9   10   >