Sorry for missing consider of the commit message #1 and #2.
I got your point. SlitSystemLocalityCount's high 32 bit (actually high 48 bit)
data is useless.
On my opinion, this field should be 2 bytes length and the spec should be
updated. Then our code can be updated to match the spec.
For now,
BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=2041
In Platform\Intel\MinPlatformPkg\Tools\Fsp\RebaseFspBinBaseAddress.py
It will run another python code.
But if the environment variable "PYTHON_HOME" is not exist
and we didn't add any python's path to "PATH".
It will cause error because
> -Original Message-
> From: Zurcher, Christopher J
> Sent: Saturday, August 17, 2019 4:22 AM
> To: Wu, Hao A; devel@edk2.groups.io
> Cc: Kinney, Michael D; Yao, Jiewen; Wang, Jian J; Gao, Liming
> Subject: RE: [edk2-devel] [PATCH v4 2/2] MdeModulePkg/ScsiDiskDxe:
> Support Storage
Hi Zhichao,
Please find my comments inline marked as [Krzysztof].
Kind regards,
Krzysztof
-Original Message-
From: Gao, Zhichao
Sent: Monday, August 19, 2019 2:19
To: devel@edk2.groups.io; Krzysztof Koch
Cc: Carsey, Jaben ; Ni, Ray ; Sami
Mujawar ; Matteo Carlini ; nd
Subject:
Now, edk2 stable tag release is
https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Release-Planning
After edk2-stable201903 tag, edk2 supports Python3. User needs to install
Python3.x, doesn’t need to set PYTHON path.
Thanks
Liming
From: devel@edk2.groups.io
Reviewed-by: Nate DeSimone
-Original Message-
From: Cheng, Ching JenX
Sent: Monday, August 19, 2019 2:24 AM
To: devel@edk2.groups.io
Cc: Chan, Amy ; Kubacki, Michael A
; Chiu, Chasel ; Desimone,
Nathaniel L ; Gao, Liming
Subject: [edk2-platforms: PATCH v2] Python run fail if env
> On Aug 19, 2019, at 6:09 AM, Liming Gao wrote:
>
> Andrew:
> This is the history reason. Before, Edk2 BaseTools included the binary
> Windows tools in BaseTools\Bin\Win32. There is no
> BaseTools/BinWrappers/WindowsLike directory.
>
> When migrate BaseTools Windows tools from binary
On Fri, Aug 16, 2019 at 10:57:22PM +0200, Marcin Wojtas wrote:
> Hi Leif,
>
> pt., 16 sie 2019 o 19:41 Leif Lindholm napisał(a):
> >
> > On Thu, Aug 15, 2019 at 04:54:14AM +0200, Marcin Wojtas wrote:
> > > SmbiosPlatformDxe is used both by Armada 7k8k and CN913x platforms.
> > > Replace board
Hi Jordan,
Thank you for the reviews. I have addressed the two issues
you raised in my local branch and I verified that the lldbefi.py
script behaves the same after breaking up the long line.
Best regards,
Mike
> -Original Message-
> From: Justen, Jordan L
> Sent: Sunday, August 18,
+Stewards (don't panic!)
On Fri, Aug 16, 2019 at 11:03:42PM +0200, Marcin Wojtas wrote:
> Hi Leif,
>
> pt., 16 sie 2019 o 19:10 Leif Lindholm napisał(a):
> >
> > On Thu, Aug 15, 2019 at 04:54:07AM +0200, Marcin Wojtas wrote:
> > > This patch adds device tree sources which are common for Cn913x
Liming,
Below patch already got the reviewed-by tag before the freezing point. Can I
push it now?
https://edk2.groups.io/g/devel/topic/32737146 UefiCpuPkg/PiSmmCpuDxeSmm: don't
free page table pages that are required to handle current page fault
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You
On 19/08/19 01:00, Yao, Jiewen wrote:
> in real world, we deprecate AB-seg usage because they are vulnerable
> to smm cache poison attack. I assume cache poison is out of scope in
> the virtual world, or there is a way to prevent ABseg cache poison.
Indeed the SMRR would not cover the A-seg on
Hi Mike,
Within the "EDK2 Platforms" product on Bugzilla, the following Intel packages
are missing:
* BoardModulePkg (edk2-platforms/Platform/Intel/BoardModulePkg)
* DebugFeaturePkg (edk2-platforms/Platform/Intel/DebugFeaturePkg)
* UserInterfaceFeaturePkg
Feedback I could not find already noted elsewhere:
1. Remove the batch build files:
- GitEdk2X58ICH10.bat
- bld.bat
- prebuild.bat
The changes must be built with the Python scripts.
2. General comment that applies to multiple files:
Files such as
You will need to resolve a conflict in build.cfg. When you do so, please keep
the boards under
[PLATFORMS] in lexicographically ascending order for ease of maintenance.
> -Original Message-
> From: Wei, David Y
> Sent: Friday, August 9, 2019 3:47 PM
> To: devel@edk2.groups.io
> Cc: Wu,
Eric,
The whole patch series are very clean and easy to understand.
Reviewed-by: Ray Ni
> -Original Message-
> From: Dong, Eric
> Sent: Thursday, August 15, 2019 8:57 PM
> To: devel@edk2.groups.io
> Cc: Ni, Ray ; Laszlo Ersek
> Subject: [Patch v4 0/6] Add "test then write" mechanism
>
Ray,
With your review, my vote is yes.
Mike
From: Ni, Ray
Sent: Monday, August 19, 2019 4:06 PM
To: devel@edk2.groups.io; Gao, Liming ; Laszlo Ersek
(ler...@redhat.com) ; leif.lindh...@linaro.org; Kinney,
Michael D ; af...@apple.com; Cetola, Stephano
Subject: RE: [edk2-devel] Patch List for
Ray:
It follows current soft feature freeze process. I am OK to fix it for this
stable tag.
Thanks
Liming
From: Ni, Ray [mailto:ray...@intel.com]
Sent: Tuesday, August 20, 2019 2:05 AM
To: Gao; Gao, Liming ; devel@edk2.groups.io
Subject: Re: [edk2-devel] Patch List for 201908 stable tag
BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=2093
The PlatformAutoGen object has a DataPipe property but no DataPile property
So change the variable name 'DataPile' to 'DataPipe' in BuildReport.py
This patch is going to fix that issue.
Cc: Liming Gao
Cc: Bob Feng
Signed-off-by: Zhiju.Fan
Done.
Mike
> -Original Message-
> From: Kinney, Michael D
> Sent: Monday, August 19, 2019 3:39 PM
> To: Kubacki, Michael A ;
> devel@edk2.groups.io; Kinney, Michael D
>
> Cc: Dong, Eric ; Gao, Liming
> ; Bi, Dandan ;
> Chiu, Chasel ; Desimone, Nathaniel
> L ; Chaganty, Rangasai V
> ;
Tom,
1. It's not a common practice to have static inline functions defined in header
file. Who is going to call them?
2. Recently I made a change to move the AMD registers definitions to
MdePkg/Include/Register/Amd from UefiCpuPkg. Do you think that's a good idea
and can you please put your new
Reviewed-by: Michael Kubacki
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Cheng, Ching JenX
> Sent: Monday, August 19, 2019 2:24 AM
> To: devel@edk2.groups.io
> Cc: Chan, Amy ; Kubacki, Michael A
> ; Chiu, Chasel ;
> Desimone, Nathaniel L
Michael,
I agree. I will add these packages that have already been approved and added
to edk2-platforms/master.
Mike
> -Original Message-
> From: Kubacki, Michael A
> Sent: Monday, August 19, 2019 2:57 PM
> To: devel@edk2.groups.io
> Cc: Kinney, Michael D ;
> Dong, Eric ; Gao, Liming
All stewards,
Though it was already listed by Liming, I would like explicitly ask for
including below changes in the coming stable tag:
https://edk2.groups.io/g/devel/message/45773 [Patch v4 0/6] Add "test then
write" mechanism
The whole patches had gone through 4 rounds of review process while
Hi David,
This patch no longer applies cleanly on the latest edk2-platforms master
branch. In addition to addressing the review feedback I previously sent, please
rebase your patch.
Thanks,
Nate
-Original Message-
From: Wei, David Y
Sent: Friday, August 9, 2019 3:47 PM
To:
> -Original Message-
> From: Laszlo Ersek [mailto:ler...@redhat.com]
> Sent: Friday, August 16, 2019 11:38 AM
> To: Gao, Liming ;
> leif.lindh...@linaro.org; Kinney, Michael D
> ; af...@apple.com; Cetola,
> Stephano
> Cc: devel@edk2.groups.io; Shi, Steven
> ; Kuo, Donald
> ; Vitaly
Feedback I could not find already noted elsewhere:
1. Silicon/Intel/SimicsX58SktPkg/Smm/Access/SmmAccessPei.c:
There's some style issues throughout the file related to a missing space
before opening parenthesis and parameters than span multiple lines.
Some of these are pre-existing in
My code review comments are already noted elsewhere.
> -Original Message-
> From: Wei, David Y
> Sent: Friday, August 9, 2019 3:47 PM
> To: devel@edk2.groups.io
> Cc: Wu, Hao A ; Gao, Liming ;
> Sinha, Ankit ; Agyeman, Prince
> ; Kubacki, Michael A
> ; Desimone, Nathaniel L
> ; Kinney,
Thanks Laszlo help to review and great feedbacks. That we did miss to fulfil
BZ.
I had updated Bugzilla https://bugzilla.tianocore.org/show_bug.cgi?id=1909 for
more documentation.
As I know for the edk2-platforms should be consumed as KBL (7th Generation)
platform in Client, and this feature
This change makes the following updates:
1. Indicate that build via batch scripts is no longer allowed.
2. Remove ClevoOpenBoardPkg batch build instructions since
the batch build scripts no longer exist in the package.
3. Move firmware image flashing instructions to a clearly labeled
Reviewed-by: Bob Feng
-Original Message-
From: Fan, ZhijuX
Sent: Tuesday, August 20, 2019 8:49 AM
To: devel@edk2.groups.io
Cc: Gao, Liming ; Feng, Bob C
Subject: [PATCH V3] [edk2-stable201908] BaseTools: Update incorrect variable
name 'DataPile'
Reviewed-by: Chasel Chiu
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Kubacki, Michael A
> Sent: Tuesday, August 20, 2019 10:03 AM
> To: devel@edk2.groups.io
> Cc: Chaganty, Rangasai V ; Chiu, Chasel
> ; Gao, Liming ; Desimone,
>
Pushed:
https://github.com/tianocore/edk2-platforms/commit/05e9ca3abfcf89795d90e31415bac28a9f350299
> -Original Message-
> From: Cheng, Ching JenX
> Sent: Monday, August 19, 2019 5:24 PM
> To: devel@edk2.groups.io
> Cc: Chan, Amy ; Kubacki, Michael A
> ; Chiu, Chasel ;
> Desimone,
Hi, Liming:
Based on the below web info:
https://github.com/tianocore/tianocore.github.io/wiki/Edk2-buildtools
The python tools are used to compile the building tools written by python.
https://github.com/tianocore/tianocore.github.io/wiki/BuildTool-Setup-Guide
in the above web, it said:
“The
Andrew:
>-Original Message-
>From: af...@apple.com [mailto:af...@apple.com]
>Sent: Tuesday, August 20, 2019 2:17 AM
>To: devel@edk2.groups.io; Gao, Liming
>Subject: Re: [edk2-devel] BaseTools/BinWrappers question?
>
>
>
>> On Aug 19, 2019, at 6:09 AM, Liming Gao wrote:
>>
>> Andrew:
>>
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1571
Besides, EOL is converted to CRLF.
Cc: Supreeth Venkatesh
Signed-off-by: Eric Jin
---
uefi-sct/SctPkg/UEFI/UEFI.dec | 206 +-
1 file changed, 103 insertions(+), 103 deletions(-)
diff --git
Check if global pointers have been successfully updated before they
are used for further table parsing.
Signed-off-by: Krzysztof Koch
---
Changes can be seen at:
https://github.com/KrzysztofKoch1/edk2/tree/612_add_pointer_validation_v2
Notes:
v1:
- Test against NULL pointers
Reviewed-by: Alexei Fedorov
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#46028): https://edk2.groups.io/g/devel/message/46028
Mute This Topic: https://groups.io/mt/32941781/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe:
Please correct subject as you are modifying edk2-platform files:
--subject-prefix="edk2-platforms: PATCH"
Also the RebaseAndPatchFspBinBaseAddress.py should be obsolete soon, so please
focus on RebaseFspBinBaseAddress.py.
> -Original Message-
> From: devel@edk2.groups.io
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
-Original Message-
From: Krzysztof Koch
Sent: 15 August 2019 02:11 PM
To: devel@edk2.groups.io
Cc: jaben.car...@intel.com; ray...@intel.com; zhichao@intel.com; Sami
Mujawar ; Matteo Carlini ; nd
Subject: [PATCH v1 05/11]
Hi Andy,
Something is fishy here - these (non-identical) patches *delete* code,
they don't add it.
On Mon, Aug 19, 2019 at 12:18:20PM +0100, Andy Hayes wrote:
> Cc: Leif Lindholm
> Cc: Michael D Kinney
> Signed-off-by: Andy Hayes
> ---
> Drivers/DisplayLink/DisplayLinkPkg/DisplayLinkPkg.dsc
Andrew:
This is the history reason. Before, Edk2 BaseTools included the binary
Windows tools in BaseTools\Bin\Win32. There is no
BaseTools/BinWrappers/WindowsLike directory.
When migrate BaseTools Windows tools from binary to source build, Edk2
BaseTools C source is still compiled to
The PlatformAutoGen object has a DataPipe property but no DataPile property
So change the variable name 'DataPile' to 'DataPipe' in BuildReport.py
This patch is going to fix that issue.
Cc: Liming Gao
Cc: Bob Feng
Signed-off-by: Zhiju.Fan
---
BaseTools/Source/Python/build/BuildReport.py | 2
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2093
The PlatformAutoGen object has a DataPipe property but no DataPile property
So change the variable name 'DataPile' to 'DataPipe' in BuildReport.py
This patch is going to fix that issue.
Cc: Liming Gao
Cc: Bob Feng
Signed-off-by:
On 17/08/19 02:20, Yao, Jiewen wrote:
> [Jiewen] That is OK. Then we MUST add the third adversary.
> -- Adversary: Simple hardware attacker, who can use device to perform DMA
> attack in the virtual world.
> NOTE: The DMA attack in the real world is out of scope. That is be handled by
> IOMMU in
On Fri, 16 Aug 2019 22:15:15 +0200
Laszlo Ersek wrote:
> +Alex (direct question at the bottom)
>
> On 08/16/19 09:49, Yao, Jiewen wrote:
> > below
> >
> >> -Original Message-
> >> From: Paolo Bonzini [mailto:pbonz...@redhat.com]
> >> Sent: Friday, August 16, 2019 3:20 PM
> >> To:
Hello,
I have a question about needing install python 2.7
If user wants to setup udk compiling environment, he needs install python 2.7.
When running build command every time, it always check python tool path.
Why?
If I compiled basetools before, and use the prebuilt basetools package, then I
On 8/16/19 7:24 AM, Igor Mammedov wrote:
> for purpose of demo SMRAM (at 0x3) is aliased at a in system address
> space
> for easy initialization of SMI entry point.
> Here is resulting debug output showing that RAM at 0x3 is not affected
> by SMM and only RAM in SMM adderss space is
Reviewed-by: Chasel Chiu
> -Original Message-
> From: Cheng, Ching JenX
> Sent: Monday, August 19, 2019 5:24 PM
> To: devel@edk2.groups.io
> Cc: Chan, Amy ; Kubacki, Michael A
> ; Chiu, Chasel ;
> Desimone, Nathaniel L ; Gao, Liming
>
> Subject: [edk2-platforms: PATCH v2] Python run
BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=2041
[PATCH v2] Update related files
In Platform\Intel\MinPlatformPkg\Tools\Fsp\RebaseFspBinBaseAddress.py
It will run another python code.
But if the environment variable "PYTHON_HOME" is not exist
and we didn't add any python's path to "PATH".
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
-Original Message-
From: Krzysztof Koch
Sent: 15 August 2019 02:11 PM
To: devel@edk2.groups.io
Cc: jaben.car...@intel.com; ray...@intel.com; zhichao@intel.com; Sami
Mujawar ; Matteo Carlini ; nd
Subject: [PATCH v1 00/11] Test
51 matches
Mail list logo
