REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2116
Cc: Ray Ni
Cc: Rangasai V Chaganty
Signed-off-by: Michael Kubacki
---
Silicon/Intel/IntelSiliconPkg/Feature/VTd/IntelVTdDxe/DmaProtection.c | 19
+++
1 file changed, 11 insertions(+), 8 deletions(-)
diff --git
I give my thought.
Paolo may add more.
> -Original Message-
> From: Kinney, Michael D
> Sent: Friday, August 23, 2019 11:25 PM
> To: Yao, Jiewen ; Paolo Bonzini
> ; Laszlo Ersek ;
> r...@edk2.groups.io; Kinney, Michael D
> Cc: Alex Williamson ; devel@edk2.groups.io;
> qemu devel list ;
Reviewed-by: Nate DeSimone
-Original Message-
From: Kubacki, Michael A
Sent: Friday, August 23, 2019 4:24 PM
To: devel@edk2.groups.io
Cc: Chiu, Chasel ; Desimone, Nathaniel L
; Gao, Liming
Subject: [edk2-platforms][PATCH V1 1/1]
MinPlatformPkg/MultiBoardInitSupportLib: Fix NULL
As noted by others, please update copyright year. With that change...
Reviewed-by: Nate DeSimone
-Original Message-
From: Zhang, Shenglei
Sent: Thursday, August 22, 2019 12:08 AM
To: devel@edk2.groups.io
Cc: Kubacki, Michael A ; Chiu, Chasel
; Desimone, Nathaniel L
; Gao, Liming ;
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2114
Removes potential NULL pointer de-references in the library and
validates NULL pointers are not passed to library functions.
Cc: Chasel Chiu
Cc: Nate DeSimone
Cc: Liming Gao
Signed-off-by: Michael Kubacki
---
1.
WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/BoardInitLib/PeiWhiskeylakeURvpInitPreMemLib.c
- BoardConfigInitPreMem()
You added the ASSERT_EFI_ERROR macros which is good, but it would probably make
sense to also return the failing error code from this function. Also, the
comment
On 2019-08-23 14:41, Andrew Fish via Groups.Io wrote:
> I was following the instructions on how to build OVMF and my build failed. It
> looks like the reason it failed was because I did not do a `git submodule
> update --init --recursive`. It would be good if we could make how to clone
> the
Pch/Include/ConfigBlock/HdAudioConfig.h - I think like it would make more sense
if Uefi.h is included first.
With that change...
Reviewed-by: Nate DeSimone
-Original Message-
From: devel@edk2.groups.io On Behalf Of Kubacki, Michael
A
Sent: Friday, August 23, 2019 2:23 PM
To:
Reviewed-by: Nate DeSimone
-Original Message-
From: Kubacki, Michael A
Sent: Thursday, August 22, 2019 11:17 AM
To: devel@edk2.groups.io
Cc: Chiu, Chasel ; Desimone, Nathaniel L
; Gao, Liming
Subject: [edk2-platforms][PATCH V2 1/2] KabylakeOpenBoardPkg: Fix GCC Build
Failures
Reviewed-by: Nate DeSimone
-Original Message-
From: Kubacki, Michael A
Sent: Thursday, August 22, 2019 11:17 AM
To: devel@edk2.groups.io
Cc: Desimone, Nathaniel L ; Gao, Liming
; Sinha, Ankit
Subject: [edk2-platforms][PATCH V2 2/2] ClevoOpenBoardPkg: Fix GCC Build
Failures
Fixes
Reviewed-by: Nate DeSimone
-Original Message-
From: devel@edk2.groups.io On Behalf Of Kubacki, Michael
A
Sent: Thursday, August 22, 2019 10:40 AM
To: devel@edk2.groups.io
Cc: Desimone, Nathaniel L ; Gao, Liming
; Sinha, Ankit
Subject: [edk2-devel] [edk2-platforms][PATCH V1 2/2]
With copyright year change...
Reviewed-by: Nate DeSimone <
-Original Message-
From: devel@edk2.groups.io On Behalf Of Kubacki, Michael
A
Sent: Thursday, August 22, 2019 10:40 AM
To: devel@edk2.groups.io
Cc: Chiu, Chasel ; Desimone, Nathaniel L
; Gao, Liming
Subject: [edk2-devel]
With copyright change noted by other reviewers...
Reviewed-by: Nate DeSimone
-Original Message-
From: Zhang, Shenglei
Sent: Wednesday, August 21, 2019 1:01 AM
To: devel@edk2.groups.io
Cc: Kubacki, Michael A ; Chiu, Chasel
; Desimone, Nathaniel L
; Gao, Liming
Subject: [edk2-platform
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2110
Fixes build failures on GCC7.3.0. Tested on Ubunutu 18.04.1 LTS.
Cc: Chasel Chiu
Cc: Nate DeSimone
Cc: Liming Gao
Signed-off-by: Michael Kubacki
---
Platform/Intel/WhiskeylakeOpenBoardPkg/OpenBoardPkg.dec
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2124
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2110
Fixes GCC build failures in WhiskeylakeOpenBoardPkg and CoffeelakeSiliconPkg
(silicon package used by WhiskeylakeOpenBoardPkg).
V2 Changes:
* Breaks changes into a dedicated patch for
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2124
Fixes build failures on GCC7.3.0. Tested on Ubuntu 18.04.1 LTS.
Cc: Chasel Chiu
Cc: Sai Chaganty
Signed-off-by: Michael Kubacki
---
Silicon/Intel/CoffeelakeSiliconPkg/Pch/Include/ConfigBlock/HdAudioConfig.h
| 2 ++
It's not recommended to make IntelSiliconPkg depend on MdeModulePkg.
> -Original Message-
> From: Chaganty, Rangasai V
> Sent: Friday, August 23, 2019 11:34 AM
> To: Chen, Marc W ; devel@edk2.groups.io
> Cc: Ni, Ray
> Subject: RE: [edk2-platforms:PATCH] Intel/IntelSiliconPkg Implement
I was following the instructions on how to build OVMF and my build failed. It
looks like the reason it failed was because I did not do a `git submodule
update --init --recursive`. It would be good if we could make how to clone the
edk2 instructions a bit more obvious.
Thanks,
Andrew Fish
I missed splitting the changes into commits per packages. I will send a V2 with
a dedicated patch for CoffeelakeSiliconPkg and WhiskeylakeOpenBoardPkg in a
patch series.
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#46326):
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2110
Fixes build failures on GCC7.3.0. Tested on Ubunutu 18.04.1 LTS.
Cc: Chasel Chiu
Cc: Nate DeSimone
Cc: Liming Gao
Signed-off-by: Michael Kubacki
---
Platform/Intel/WhiskeylakeOpenBoardPkg/OpenBoardPkg.dec
May I know the reason to implement the SmmAccessLib instance under \Feature
folder?
Can we move it under IntelSiliconPkg\Library (We need to create a library
folder in the root) and keep just the module in the \Feature folder?
I've noticed there is a dependency on MdeModulePkg with this change.
Have you tried adding the path in AdvancedFeaturePkg.dec under [Includes]
section?
-Original Message-
From: Zhang, Shenglei
Sent: Wednesday, August 21, 2019 1:01 AM
To: devel@edk2.groups.io
Cc: Kubacki, Michael A ; Chaganty, Rangasai V
; Gao, Liming
Subject: [edk2-platform PATCH 1/2]
Reviewed-by: Sai Chaganty
-Original Message-
From: Zhang, Shenglei
Sent: Thursday, August 22, 2019 12:08 AM
To: devel@edk2.groups.io
Cc: Kubacki, Michael A ; Chaganty, Rangasai V
; Gao, Liming ; Zhang,
Shenglei
Subject: [edk2-platforms PATCH 1/4] Platform/AdvancedFeaturePkg.dsc: Add
Please extend the copyright date in all files touched to 2019. With that change:
Reviewed-by: Michael Kubacki
> -Original Message-
> From: Zhang, Shenglei
> Sent: Wednesday, August 21, 2019 1:01 AM
> To: devel@edk2.groups.io
> Cc: Kubacki, Michael A ; Chiu, Chasel
> ; Desimone,
Please extend the copyright date in SmbiosDxe.inf to 2019. With that change:
Reviewed-by: Michael Kubacki
> -Original Message-
> From: Zhang, Shenglei
> Sent: Wednesday, August 21, 2019 1:01 AM
> To: devel@edk2.groups.io
> Cc: Kubacki, Michael A ; Chaganty, Rangasai V
> ; Gao, Liming
>
Please extend the file copyright date. With that change:
Reviewed-by: Michael Kubacki
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Zhang, Shenglei
> Sent: Thursday, August 22, 2019 12:08 AM
> To: devel@edk2.groups.io
> Cc: Kubacki,
Reviewed-by: Michael Kubacki
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Zhang, Shenglei
> Sent: Thursday, August 22, 2019 12:08 AM
> To: devel@edk2.groups.io
> Cc: Bi, Dandan ; Gao, Liming ;
> Zhang, Shenglei
> Subject: [edk2-devel]
Reviewed-by: Michael Kubacki
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Zhang, Shenglei
> Sent: Thursday, August 22, 2019 12:08 AM
> To: devel@edk2.groups.io
> Cc: Dong, Eric ; Gao, Liming ;
> Zhang, Shenglei
> Subject: [edk2-devel]
Reviewed-by: Michael Kubacki
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Zhang, Shenglei
> Sent: Thursday, August 22, 2019 12:08 AM
> To: devel@edk2.groups.io
> Cc: Kubacki, Michael A ; Chaganty, Rangasai V
> ; Gao, Liming ; Zhang,
>
Hi Mike,
Please see the updates online below. Please let me know if you have any more
comments.
Thanks
David
-Original Message-
From: Kubacki, Michael A
Sent: Monday, August 19, 2019 6:05 PM
To: Wei, David Y ; devel@edk2.groups.io
Cc: Wu, Hao A ; Gao, Liming ; Sinha,
Ankit ; Agyeman,
Hi Mike,
Please see the updates online below. Please let me know if you have any more
comments.
Thanks
David
-Original Message-
From: Kubacki, Michael A
Sent: Monday, August 19, 2019 6:05 PM
To: Wei, David Y ; devel@edk2.groups.io
Cc: Wu, Hao A ; Gao, Liming ; Sinha,
Ankit ; Agyeman,
On Fri, 2019-08-23 at 00:46 -0500, Eric Jin wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2098
>
> In the ExitBootServices() test, after ExitBootServices() call, all
> boot services are forbidden. The original design is to save the
> return
> status value of ExitBootServices() in
On Thu, 2019-08-22 at 22:37 -0500, Jin, Eric wrote:
> Hi Supreeth,
>
> > -Original Message-
> > From: Supreeth Venkatesh [mailto:supreeth.venkat...@arm.com]
> > Sent: Friday, August 23, 2019 2:43 AM
> > To: devel@edk2.groups.io; Jin, Eric
> > Subject: Re: [edk2-devel] [edk2-test][Patch
Hi Jiewen,
If a hot add CPU needs to run any code before the
first SMI, I would recommend is only executes code
from a write protected FLASH range without a stack
and then wait for the first SMI.
For this OVMF use case, is any CPU init required
before the first SMI?
From Paolo's list of steps
On 22/08/19 22:06, Kinney, Michael D wrote:
> The SMBASE register is internal and cannot be directly accessed
> by any CPU. There is an SMBASE field that is member of the SMM Save
> State area and can only be modified from SMM and requires the
> execution of an RSM instruction from SMM for the
On 23/08/19 00:32, Kinney, Michael D wrote:
> Paolo,
>
> It is my understanding that real HW hot plug uses the SDM defined
> methods. Meaning the initial SMI is to 3000:8000 and they rebase
> to TSEG in the first SMI. They must have chipset specific methods
> to protect 3000:8000 from DMA.
It
On 08/22/19 20:51, Paolo Bonzini wrote:
> On 22/08/19 20:29, Laszlo Ersek wrote:
>> On 08/22/19 08:18, Paolo Bonzini wrote:
>>> On 21/08/19 22:17, Kinney, Michael D wrote:
DMA protection of memory ranges is a chipset feature. For the current
QEMU implementation, what ranges of memory are
Is this warning reported on ARM arch?
In Base.h, VA_START is defined as below for ARM arch. Do you mean VS2017 report
the warning for below macro?
If so, can you propose the change in VA_START macro to fix this warning, then
doesn't need to update consumer source code.
#define
On 08/22/19 22:44, Jordan Justen wrote:
> On 2019-08-22 06:46:07, Laszlo Ersek wrote:
>> On 08/21/19 23:51, Jordan Justen wrote:
>>> On 2019-08-21 07:21:25, Laszlo Ersek wrote:
On 08/19/19 23:35, Lendacky, Thomas wrote:
> From: Tom Lendacky
>
> + //
> + // Enable caching
On 08/22/19 17:24, Lendacky, Thomas wrote:
> On 8/22/19 9:12 AM, Laszlo Ersek wrote:
>> On 08/21/19 23:42, Lendacky, Thomas wrote:
>>> On 8/21/19 9:31 AM, Laszlo Ersek wrote:
On 08/19/19 23:35, Lendacky, Thomas wrote:
> From: Tom Lendacky
>
> Allocate memory for the GHCB pages
On 08/22/19 16:52, Gao, Liming wrote:
>> -Original Message-
>> From: Laszlo Ersek [mailto:ler...@redhat.com]
>> Sent: Thursday, August 22, 2019 7:56 PM
>> To: Gao, Liming
>> Cc: devel@edk2.groups.io; Kinney, Michael D ;
>> Mike Turner ; Wang, Jian J
>> ; Wu, Hao A ; Bi, Dandan
>> ;
(v2 as the previous patch had a FreePool call missing).
The following patch adds automatic the insertion of "bcm,bcm2835-usb" into the
"usb" Device Tree node for the Raspberry Pi 3, if not already present.
In terms of DTS structure, this patch basically alters:
compatible = "brcm,bcm2708-usb";
Some Linux kernels (e.g. Debian) require "bcm,bcm2835-usb" to be present in
the list of compatible properties for the "usb" node, else they are unable
to handle some USB devices.
This patch ensures that the compatible property is added if not present.
Signed-off-by: Pete Batard
---
Some Linux kernels (e.g. Debian) require "bcm,bcm2835-usb" to be present in
the list of compatible properties for the "usb" node, else they are unable
to handle some USB devices.
This patch ensures that the compatible property is added if not present.
Signed-off-by: Pete Batard
---
The following patch adds automatic the insertion of "bcm,bcm2835-usb" into the
"usb" Device Tree node for the Raspberry Pi 3, if not already present.
In terms of DTS structure, this patch basically alters:
compatible = "brcm,bcm2708-usb";
to:
compatible = "brcm,bcm2708-usb",
Reviewed-by: Alexei Fedorov
Alexei
From: Sami Mujawar
Sent: 23 August 2019 11:55
To: devel@edk2.groups.io
Cc: Sami Mujawar ; Alexei Fedorov
; leif.lindh...@linaro.org ;
Matteo Carlini ; nd
Subject: [PATCH v1 09/19] DynamicTablesPkg: Fix unaligned pointers
Reviewed-by: Alexei Fedorov
Alexei
From: Sami Mujawar
Sent: 23 August 2019 11:55
To: devel@edk2.groups.io
Cc: Sami Mujawar ; Alexei Fedorov
; leif.lindh...@linaro.org ;
Matteo Carlini ; nd
Subject: [PATCH v1 08/19] DynamicTablesPkg: Fix ACPI table rev
Reviewed-by: Alexei Fedorov
Alexei
From: Sami Mujawar
Sent: 23 August 2019 11:55
To: devel@edk2.groups.io
Cc: Sami Mujawar ; Alexei Fedorov
; leif.lindh...@linaro.org ;
Matteo Carlini ; nd
Subject: [PATCH v1 11/19] DynamicTablesPkg: Remove redundant frame
Reviewed-by: Alexei Fedorov
Alexei
From: devel@edk2.groups.io on behalf of Sami Mujawar via
Groups.Io
Sent: 23 August 2019 11:55
To: devel@edk2.groups.io
Cc: Sami Mujawar ; ard.biesheu...@linaro.org
; leif.lindh...@linaro.org
; Matteo Carlini ; Stephanie
Reviewed-by: Alexei Fedorov
Alexei
From: devel@edk2.groups.io on behalf of Sami Mujawar via
Groups.Io
Sent: 23 August 2019 11:55
To: devel@edk2.groups.io
Cc: Sami Mujawar ; ard.biesheu...@linaro.org
; leif.lindh...@linaro.org
; Matteo Carlini ; Stephanie
Reviewed-by: Alexei Fedorov
Alexei
From: devel@edk2.groups.io on behalf of Sami Mujawar via
Groups.Io
Sent: 23 August 2019 11:55
To: devel@edk2.groups.io
Cc: Sami Mujawar ; ard.biesheu...@linaro.org
; leif.lindh...@linaro.org
; Matteo Carlini ; Stephanie
Reviewed-by: Alexei Fedorov
Alexei
From: Sami Mujawar
Sent: 23 August 2019 11:55
To: devel@edk2.groups.io
Cc: Sami Mujawar ; Alexei Fedorov
; leif.lindh...@linaro.org ;
Matteo Carlini ; nd
Subject: [PATCH v1 15/19] DynamicTablesPkg: Remove erroneous use of
Reviewed-by: Alexei Fedorov
Alexei
From: Sami Mujawar
Sent: 23 August 2019 11:55
To: devel@edk2.groups.io
Cc: Sami Mujawar ; Alexei Fedorov
; leif.lindh...@linaro.org ;
Matteo Carlini ; nd
Subject: [PATCH v1 16/19] DynamicTablesPkg: Option for VS2017
Reviewed-by: Alexei Fedorov
Alexei
From: Sami Mujawar
Sent: 23 August 2019 11:55
To: devel@edk2.groups.io
Cc: Sami Mujawar ; Alexei Fedorov
; leif.lindh...@linaro.org ;
Matteo Carlini ; nd
Subject: [PATCH v1 14/19] DynamicTablesPkg: PPTT: Fix uninitialized
Reviewed-by: Alexei Fedorov
Alexei
From: Sami Mujawar
Sent: 23 August 2019 11:55
To: devel@edk2.groups.io
Cc: Sami Mujawar ; Alexei Fedorov
; ard.biesheu...@linaro.org
; leif.lindh...@linaro.org
; Matteo Carlini ; nd
Subject: [PATCH v1 18/19]
Reviewed-by: Alexei Fedorov
Alexei
From: Sami Mujawar
Sent: 23 August 2019 11:55
To: devel@edk2.groups.io
Cc: Sami Mujawar ; Alexei Fedorov
; ard.biesheu...@linaro.org
; leif.lindh...@linaro.org
; Matteo Carlini ; nd
Subject: [PATCH v1 17/19]
Reviewed-by: Alexei Fedorov
Alexei
From: Sami Mujawar
Sent: 23 August 2019 11:55
To: devel@edk2.groups.io
Cc: Sami Mujawar ; Alexei Fedorov
; ard.biesheu...@linaro.org
; leif.lindh...@linaro.org
; Matteo Carlini ;
michael.d.kin...@intel.com ;
Reviewed-by: Alexei Fedorov
Alexei
From: Sami Mujawar
Sent: 23 August 2019 11:55
To: devel@edk2.groups.io
Cc: Sami Mujawar ; Alexei Fedorov
; leif.lindh...@linaro.org ;
Matteo Carlini ; nd
Subject: [PATCH v1 01/19] DynamicTablesPkg: Fix entry point param
Reviewed-by: Alexei Fedorov
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#46281): https://edk2.groups.io/g/devel/message/46281
Mute This Topic: https://groups.io/mt/32999779/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe:
The VS2017 compiler reports 'warning C4244: '=': conversion
from 'UINT64' to 'UINT32', possible loss of data' for the
calculation of the UART Divisor value.
Fix this warning by adding appropriate typecast and a validation
that ensures that the UART divisor value generated does not exceed
The VS2017 compiler reports 'warning C6001: Using
uninitialized memory 'Marker'.' for VA_LIST
variables.
To fix this issue declare a VA_LIST global variable
and use this to initialise VA_LIST variables before
use.
Note: The VA_LIST cannot be assigned a NULL value
because some compilers define
The VS2017 compiler reports 'warning C6326: potential
comparison of a constant with another constant' when
a fixed PCD value is compared with a constant value.
The faulting code is as marked by '-->' below:
--> if (FixedPcdGet32 (PL011UartInteger) != 0) {
Integer = FixedPcdGet32
On enabling the /analyse option the VS2017 compiler
reports: warning C6001: Using uninitialized memory.
This warning is reported as some variables that were
being logged were uninitialised. To fix this, moved
the logging code after the variables being logged are
initialised.
Signed-off-by: Sami
The Dynamic Tables Factory protocol has an erroneous
EFIAPI calling convention macro in the function
pointer declaration.
Remove the erroneous EFIAPI calling convention macro
from the interface declarations.
Signed-off-by: Sami Mujawar
---
The ARM DCC serial port subtype is an option that is
supported by the DBG2 generator. However, the serial
port initialisation should only be done for PL011/SBSA
compatible UARTs.
Add check to conditionally initialise the serial port.
Signed-off-by: Sami Mujawar
---
The VS2017 compiler reports 'warning C4244: '=': conversion from
'const UINT32' to 'UINT8', possible loss of data' when the ACPI
table revision field is being updated.
The width of the revision field in the EFI_ACPI_DESCRIPTION_HEADER
struct is 8-bit wide. Therefore, to fix the above warning make
The VS2017 compiler reports 'warning C4267: 'return': conversion
from 'size_t' to 'UINT32', possible loss of data' for a number of
functions that compute the IORT node length. Similarly, it reports
warnings for IORT node length field assignments as the length
field is 16-bit wide.
This patch adds
Removing GT Block frame count check from AddGTBlockTimerFrames()
as this is already validated in BuildGtdtTable().
Signed-off-by: Sami Mujawar
---
DynamicTablesPkg/Library/Acpi/Arm/AcpiGtdtLibArm/GtdtGenerator.c | 10
--
1 file changed, 10 deletions(-)
diff --git
Add build option STATIC_ANALYSIS to enable VS2017 static
code analysis.
Signed-off-by: Sami Mujawar
---
DynamicTablesPkg/DynamicTablesPkg.dsc | 9 -
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/DynamicTablesPkg/DynamicTablesPkg.dsc
The VS2017 compiler reports 'error C2016: C requires that
a struct or union has at least one member' for the struct
CM_ARM_CPU_INFO.
Remove struct CM_ARM_CPU_INFO as this is not in use.
Signed-off-by: Sami Mujawar
---
DynamicTablesPkg/Include/ArmNameSpaceObjects.h | 4
1 file changed, 4
The VS2017 compiler reports 'warning C4366: The result of
the unary '&' operator may be unaligned' if an address of
an unaligned structure member is passed as an argument to
a function.
Fix this warning by using local variables in place of
unaligned structure members.
Signed-off-by: Sami Mujawar
The VS2017 compiler reports 'warning C4244: '=': conversion
from 'UINT16' to 'UINT8', possible loss of data' for the
SPCR InterfaceType field assignment.
The SPCR InterfaceType field uses the same encoding as that
of the DBG2 table Port Subtype field. However SPCR.InterfaceType
is 8-bit while the
The VS2017 compiler reports 'warning C4267: '=': conversion from
'size_t' to 'UINT16', possible loss of data'.
The sizeof() operator is used to calculate the size of the
GT Block structure. The length field in the GT Block structure
is 16-bit wide. Since the return type of sizeof() operator
is
The length field for the Processor Hierarchy node structure is
8-bit wide while the number of private resource field is 32-bit
wide. Therefore, the GetProcHierarchyNodeSize() returns the size
as a 32-bit value.
The VS2017 compiler reports 'warning C4244: '=': conversion from
'UINT32' to 'UINT8',
The ArmBootArch field of the FADT table is 16-bit wide. The
VS2017 compiler reports 'warning C4244: '=': conversion from
'UINT32' to 'UINT16', possible loss of data' when assigning the
CM_ARM_BOOT_ARCH_INFO.BootArchFlags value as the width of this
field in CM_ARM_BOOT_ARCH_INFO is 32-bit wide.
To
VS2017 reports 'warning C4028: formal parameter 2 different
from declaration' for the library constructor and destructor
interfaces for the Generator modules. VS2017 compiler also
reports similar warnings for the DXE entry points.
Remove the CONST qualifier for the SystemTable pointer (the
second
On enabling the /analyse option the VS2017 compiler
reports: warning C6001: Using uninitialized memory.
This warning is reported as some variables that were
being logged were uninitialised. To fix this, moved
the logging code after the variables being logged are
initialised.
Signed-off-by: Sami
This patch series:
- fixes warnings reported by the VS2017 compiler
- adds an option to enable VS2017 static code
analysis
- fixes warnings reported by the edk2 build
system
The issues fixed in this series were identified
by building DynamicTablesPkg/DynamicTablesPkg.dsc
using the
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2121
Implement SmmAccess for PEI and DXE phase in IntelSiliconPkg
Signed-off-by: Marc Chen
Cc: Ray Ni
Cc: Rangasai V Chaganty
---
.../Library/PeiSmmAccessLib/PeiSmmAccessLib.c | 343 +
Hi, all
Today, we will enter into Hard Feature Freeze phase until edk2-stable201908
tag is created at 2019-08-30. In this phase, there is no feature to be pushed.
The critical bug fix is still allowed.
If the patch is sent after Hard Feature Freeze, and plans to catch this
stable tag,
Reviewed-by: Chasel Chiu
> -Original Message-
> From: Kubacki, Michael A
> Sent: Friday, August 23, 2019 2:17 AM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel ; Desimone, Nathaniel L
> ; Gao, Liming
> Subject: [edk2-platforms][PATCH V2 1/2] KabylakeOpenBoardPkg: Fix GCC
> Build
Pushed at 6dd9aa40193cc905cda5f97d07e30ffbd5299439
-Original Message-
From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Bob Feng
Sent: Thursday, August 22, 2019 11:14 AM
To: devel@edk2.groups.io; Shi, Steven
Cc: Gao, Liming
Subject: Re: [edk2-devel] [PATCH]
Pushed at 5f7bb39117167018729dc938452c65ea7572eb1f
-Original Message-
From: Gao, Liming
Sent: Wednesday, August 21, 2019 9:35 PM
To: devel@edk2.groups.io; Feng, Bob C
Subject: RE: [edk2-devel] [Patch][edk2-stable201908] BaseTools: Fix incremental
build genmake issue
Reviewed-by:
Pushed @abc0155b034230128ad4aaa51ac05a315acfa7c1
-Original Message-
From: Gao, Liming
Sent: Thursday, August 22, 2019 10:32 PM
To: Feng, Bob C ; devel@edk2.groups.io
Subject: RE: [Patch V2][edk2-stable201908] BaseTools: Incorrect error message
for library instance not found
84 matches
Mail list logo
