Re: [edk2-devel] Conditionally Include FDF File

That is not the same use case. You are always including NetworkPkg/Network.fdf.inc and then inside of it you are using NETWORK_ENABLE flag to include the associated drivers or not include anything at all but the file exists. My use case differs where the file may not exist and that is why I

Re: [edk2-devel] [PATCH v4 12/13] OvmfPkg/MptScsiDxe: Report multiple targets

On 04/14/20 19:38, Nikita Leshenko wrote: > The controller supports up to 8 targets (Not reported by the > controller, but based on the implementation of the virtual device), > report them in GetNextTarget and GetNextTargetLun. The firmware will > then try to communicate with them and create a

Re: [edk2-devel] edk2 repo for RedfishPkg

Agreed. I’d like to see edk2 Core, edk2 Optional, and edk2 Platform. I think that’s an appropriate division that helps address some of the placement and dependency concerns a number of us (not just MS ) have identified. - Bret From: devel@edk2.groups.io on

Re: [edk2-devel] edk2 repo for RedfishPkg

I support somewhere other than edk2 core. I would offer a third option to think about; create a new tianocore repo. For optional features or features that don't have broad community adoption it would allow for those downstream consumers to easily pick and chose their consumption. It also

Re: [edk2-devel] [PATCH v4 13/13] OvmfPkg/MptScsiDxe: Reset device on ExitBootServices()

On 04/14/20 19:38, Nikita Leshenko wrote: > This causes the device to forget about the reply frame. We allocated the > reply frame in EfiBootServicesData type memory, and code executing after > ExitBootServices() is permitted to overwrite it. > > Ref:

Re: [edk2-devel] FW: Discussion: Basetools a separate repo

Laszlo, PIP vs Submodules: The issue with submodule and not using python packages (pip is really just a super convenient helper to install that consistently) is that it requires the paradigm of file system python path management. Think of this as edk1 vs edk2 public includes (if you remember

[edk2-devel] [PATCH v2 2/6] ArmVirtPkg: Add Platform CI and configuration for Core CI

From: Sean Brogan REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2570 Add new Azure Pipeline definitions to build and run ArmVirtPkg with: * Ubuntu GCC5 Add PyTool based build of ArmVirtPkg Add extdep for managing the iasl dependency Add ArmVirtPkg.ci.yaml for Core CI Add ReadMe.rst for

[edk2-devel] [PATCH v2 5/6] .pytool: Update CI Settings to support Emulator, ArmVirt, and Ovmf packages

From: Sean Brogan REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2570 Update pytools configuration to enable EmulatorPkg, ArmVirtPkg, and OvmfPkg. Update documentation for the status of those packages. Remove future work items that are now complete. Cc: Sean Brogan Cc: Bret Barkelew Cc:

[edk2-devel] [PATCH v2 0/6] Edk2 Platform and Core CI for ArmVirtPkg, EmulatorPkg, and OvmfPkg

From: Michael Kubacki The following 6 patches adds support for "Platform CI" for ArmVirtPkg, OvmfPkg, and EmulatorPkg. Each readme has live status and links to the builds as well as details of how to build and run the same way the CI server will. ArmVirtPkg:

[edk2-devel] [PATCH v2 6/6] .azurepipelines: Update Core CI build matrix to include platforms

From: Sean Brogan REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2570 Add ArmVirtPkg to Core CI matrix Add EmulatorPkg to Core CI matrix Add OvmfPkg to Core CI matrix Cc: Sean Brogan Cc: Bret Barkelew Cc: Michael D Kinney Cc: Liming Gao Signed-off-by: Sean Brogan Signed-off-by:

[edk2-devel] [PATCH v2 3/6] EmulatorPkg: Add Platform CI and configuration for Core CI

From: Sean Brogan REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2570 Add new Azure Pipeline definitions to build and run EmulatorPkg with: * Ubuntu GCC5 * Windows VS2019 Add PyTool based build of EmulatorPkg Add EmulatorPkg.ci.yaml for Core CI Add ReadMe.rst for status, details and

[edk2-devel] [PATCH v2 1/6] .azurepipelines: Add Platform CI template

From: Sean Brogan REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2570 Add template for Platform CI steps for a Pytools based build. Add README to describe the template and how to use it. Add helpful information for working with azurepipelines, templates, and lessons learned. Cc: Sean

[edk2-devel] [PATCH v2 4/6] OvmfPkg: Add Platform CI and configuration for Core CI

From: Sean Brogan REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2570 Add new Azure Pipeline definitions to build and run OvmfPkg with: * Ubuntu GCC5 * Windows VS2019 Add PyTool based build of OvmfPkg Add extdep for managing the iasl dependency Add OvmfPkg.ci.yaml for Core CI Add

Re: [edk2-devel] [PATCH v1 1/1] MdePkg: Add AML FieldList OpCode definitions

Hello everyone, Just to push the patch forward a bit: the patch has received reviewed-by from Liming Gao, Zhiguang Liu and Sami Mujawar, Regards, Pierre -Original Message- From: devel@edk2.groups.io On Behalf Of Liming Gao via groups.io Sent: Friday, April 10, 2020 4:19 AM To: Liu,

Re: [edk2-devel] [PATCH 1/1] ShellPkg/DynamicCommand: add HttpDynamicCommand

Hi Samer, > -Original Message- > From: Samer El-Haj-Mahmoud > Sent: Sunday, April 19, 2020 5:31 AM > To: devel@edk2.groups.io; vladimir.olovyanni...@broadcom.com; Ray Ni > ; Zhichao Gao > Cc: nd > Subject: RE: [edk2-devel] [PATCH 1/1] ShellPkg/DynamicCommand: add > HttpDynamicCommand >

Re: [edk2-devel] [PATCH v4 11/13] OvmfPkg/MptScsiDxe: Implement the PassThru method

On 04/14/20 19:38, Nikita Leshenko wrote: > Machines should be able to boot after this commit. Tested with different > Linux distributions (Ubuntu, CentOS) and different Windows > versions (Windows 7, Windows 10, Server 2016). > > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2390 >

[edk2-devel] [PATCH 1/2] OvmfPkg/OvmfXen: Remove DEBUG_ON_SERIAL_PORT

Remove support for DEBUG_ON_SERIAL_PORT because OvmfXen can't be build with it due to a circular dependency: DebugLib: BaseDebugLibSerialPort -> SerialPortLib : XenConsoleSerialPortLib -> XenHypercallLib : XenHypercallLib -> DebugLib Also, if that dependency is fixed, I think it

[edk2-devel] [PATCH 2/2] OvmfPkg/OvmfXen: Introduce XenDebugLibIoPort

Introduce XenDebugLibIoPort which is enabled with DEBUG_ON_HYPERVISOR_CONSOLE which send the debug output to Xen's console. It's a copy PlatformDebugLibIoPort which always write to the IO port. It works with both Xen HVM guest and Xen PVH guest whereas the default PlatformDebugLibIoPort works

[edk2-devel] [PATCH 0/2] OvmfXen: Cleanup debug options

Patch series available in this git branch: git://xenbits.xen.org/people/aperard/ovmf.git br.ovmfxen-debug-io-v1 Remove non working DEBUG_ON_SERIAL_PORT, then add a new LibIoPort which always writes to the IO port. Issues was discovered and discuss in this mail threads: "OvmfPkg XenPkg:

Re: [edk2-devel] [PATCH v1 1/1] INF Spec: Add file dependency to [Sources] syntax

Hello Bob, Michael and Liming, I don't have a clear idea on which direction to go in order to enable building ASL files before C files in edk2. I would need an answer to agree on which direction I should continue to investigate. For the record, the matching patch in edk2 is available at

Re: [edk2-devel] [PATCH v1 1/1] MdePkg: Add AML FieldList OpCode definitions

It has been merged. https://github.com/tianocore/edk2/pull/521 -Original Message- From: devel@edk2.groups.io On Behalf Of PierreGondois Sent: 2020年4月21日 2:27 To: devel@edk2.groups.io; Gao, Liming ; Liu, Zhiguang Cc: Kinney, Michael D ; Sami Mujawar ; nd Subject: Re: [edk2-devel]

[edk2-devel] [edk2-platforms: PATCH] Revert "MinPlatformPkg/PlatformInitPei: ReportCpuHobLib."

The patch broke all OpenBoardPkg build so reverted: 944af47a8c83115dcd5dae581e5c3770a12a2ed2. Cc: Nate DeSimone Cc: Liming Gao Signed-off-by: Chasel Chiu --- Platform/Intel/MinPlatformPkg/PlatformInit/Library/ReportCpuHobLib/ReportCpuHobLib.c | 32

[edk2-devel] ShellPkg: acpiview command doesn't appear to be included in any profile

I noticed there's an acpiview command, in UefiShellAcpiViewCommandLib, but unlike similar commands like smbiosview it's not included in any of the shell profiles. Is that deliberate? -- Rebecca Cran -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group.

[edk2-devel] [edk2-staging/EdkRepo] [PATCH] EdkRepo: Remove required delimiter from edkrepo base config class

Remote the 'delimeters='=' from the instantation of config parser objects in the BaseConfig class and update the manifest-repos section of the edkrepo.cfg to remove the '=' from after the manifest repo name. Signed-off-by: Ashley E Desimone Cc: Nate DeSimone Cc: Puja Pandya Cc: Erik Bjorge

Re: [edk2-devel] ShellPkg: acpiview command doesn't appear to be included in any profile

smbiosview (and other standard commands) are defined in the UEFI Shell specification, which specifies the profiles/for each command (UEFI Shell Spec 2.2, Table 11). For instance, smbiosview is defined as part of the Debug1 profile. This is why the code registers that command in

Re: [edk2-devel] [edk2-platforms: PATCH] Revert "MinPlatformPkg/PlatformInitPei: ReportCpuHobLib."

Reviewed-by: Liming Gao -Original Message- From: Chiu, Chasel Sent: 2020年4月21日 8:53 To: devel@edk2.groups.io Cc: Desimone, Nathaniel L ; Gao, Liming Subject: [edk2-platforms: PATCH] Revert "MinPlatformPkg/PlatformInitPei: ReportCpuHobLib." The patch broke all OpenBoardPkg build so

Re: [edk2-devel] [PATCH v1 0/1] BaseTools: BaseTools changes for RISC-V platform.

For this change, I suggest to separate it to three patches. One is for tools_def.template, another is for Build Python, last one is for BaseTools C tool. -Original Message- From: devel@edk2.groups.io On Behalf Of Chang, Abner (HPS SW/FW Technologist) Sent: 2020年4月10日 15:47 To:

Re: [edk2-devel] [PATCH v1 0/9] MdePkg changes for RISC-V edk2 port

> -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Liming Gao > Sent: Tuesday, April 21, 2020 8:55 AM > To: devel@edk2.groups.io; Chang, Abner (HPS SW/FW Technologist) > > Subject: Re: [edk2-devel] [PATCH v1 0/9] MdePkg changes for RISC-V

Re: [edk2-devel] ShellPkg: acpiview command doesn't appear to be included in any profile

The default build of the shell does not include AcpiView. However, there is a second version of the shell built from ShellPkg.dsc that does include the AcpiView command. # # Build a second version of the shell with all commands integrated # ShellPkg/Application/Shell/Shell.inf {

Re: [edk2-devel] ShellPkg: acpiview command doesn't appear to be included in any profile

I believe the reason that you don't see ACPIVIEW in any profile is largely because the SMBIOSVIEW utility was around at the time of the creation of the Shell specification and I don't believe the ACPIVIEW one was. Thanks, Mike Rothman (迈克 罗斯曼 / माइकल रोथ्मेन् / Михаил Ротман / משה רוטמן) רועה

Re: [edk2-devel] [edk2-staging/EdkRepo] [PATCH] EdkRepo: Remove required delimiter from edkrepo base config class

Reviewed-by: Erik Bjorge -Original Message- From: devel@edk2.groups.io On Behalf Of Ashley E Desimone Sent: Monday, April 20, 2020 3:21 PM To: devel@edk2.groups.io Cc: Desimone, Nathaniel L ; Pandya, Puja ; Bjorge, Erik C ; Bret Barkelew ; Agyeman, Prince Subject: [edk2-devel]

Re: [edk2-devel] [PATCH v2 0/7] Add linked list iteration macros to BaseLib.h

Reviewed-by: Liming Gao for this patch set. -Original Message- From: Michael Kubacki Sent: 2020年4月16日 1:10 To: devel@edk2.groups.io; Zhang, Chao B ; Bi, Dandan ; Wu, Hao A ; Wang, Jian J ; Gao, Liming Cc: Kinney, Michael D ; Ni, Ray ; Sean Brogan Subject: Re: [PATCH v2 0/7] Add

Re: [edk2-devel] [PATCH v1 0/9] MdePkg changes for RISC-V edk2 port

Abner: Here is my minor comments. 1. For RISC-V processor related definitions, have they been defined in public definitions? 2. For MdePkg/BaseSynchronizationLib, why name file SynchronizationAsm.S? Can it name to Synchronization.S? Thanks Liming -Original Message- From:

Re: [edk2-devel] [PATCH v2 0/6] Mark the File parameter as OPTIONAL

Hi Laszlo, I'm sad when saw the message. but I still appreciate the advice provided by you. I think that this is not the only documentation issue, and should discuss in other topic. Hi Jian, Chao, Just for this issue, please give some feedback. Best Regards Guomin > -Original

[edk2-devel] [edk2-staging][PATCH] BaseTools/FMMT: Fix FV add FFs issue

when Fv not include any FFS, will encounter not enough space to add issue. Change-Id: Ie401f0edcf3f9b6bcae706a877b284e840f61fe9 Cc: Bob Feng Cc: Liming Gao Signed-off-by: Yunhua Feng --- BaseTools/Source/C/FMMT/FirmwareModuleManagement.c | 12 1 file changed, 12 insertions(+)

[edk2-devel] [PATCH] EdkRepo: Fix Linux install failures

Install script currently attempts to run EdkRepo as root, which fails. The fix ensures that EdkRepo is run under a user account. Signed-off-by: Nate DeSimone Cc: Ashley E Desimone Cc: Puja Pandya Cc: Erik Bjorge Cc: Bret Barkelew Cc: Prince Agyeman ---

Re: [edk2-devel] [PATCH v3 3/3] BaseTools: BaseTools changes for RISC-V platform.

Good catch Zhiquang, Do you have other comments on those patches? I can fix it at once and send the patch to ML. Thanks Abner > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Zhiguang Liu > Sent: Tuesday, April 21, 2020 1:28 PM > To:

[edk2-devel] [PATCH v2 3/8] OvmfPkg: Add QemuFwCfgLibNull

Add a null implementation library for QemuFwCfgLib, in order to support bhyve. Signed-off-by: Rebecca Cran --- .../Library/QemuFwCfgLib/QemuFwCfgLibNull.inf | 37 OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgNull.c | 209 ++ 2 files changed, 246 insertions(+) create mode 100644

[edk2-devel] [PATCH v2 0/8] Add BhyvePkg, to support the bhyve hypervisor

Many changes from the first patch series, hopefully incorporating all feedback I received. Changes include switching to the SPDX license headers, updating Maintainers.txt, moving PlatformPei and AcpiPlatformDxe under BhyvePkg, changing FILE_GUIDs to be unique (except AcpiTables, which needs to

[edk2-devel] [PATCH v2 1/8] OvmfPkg: Add bhyve support into AcpiTimerLib

On bhyve, the ACPI timer is located at a fixed IO address; it need not be programmed into, nor fetched from, the PMBA -- power management base address -- register of the PCI host bridge. Signed-off-by: Rebecca Cran Reviewed-by: Laszlo Ersek --- OvmfPkg/Include/IndustryStandard/Bhyve.h |

[edk2-devel] [PATCH v2 2/8] BhyvePkg: Add BhyveFwCtlLibNull

Add a null implementation of BhyveFwCtlLib, to support building AcpiPlatformDxe for Qemu/Xen. Signed-off-by: Rebecca Cran --- .../BhyveFwCtlLibNull/BhyveFwCtlLibNull.c | 53 +++ .../BhyveFwCtlLibNull/BhyveFwCtlLibNull.inf | 39 ++ 2 files changed, 92

[edk2-devel] [PATCH v2 6/8] BhyvePkg: Add PlatformPei

Make a copy of OvmfPkg/PlatformPei under BhyvePkg with the changes that are needed to support the bhyve hypervisor. Signed-off-by: Rebecca Cran --- BhyvePkg/PlatformPei/AmdSev.c | 106 + BhyvePkg/PlatformPei/ClearCache.c | 111 + BhyvePkg/PlatformPei/Cmos.c | 58

[edk2-devel] [PATCH v2 7/8] BhyvePkg: Add AcpiPlatformDxe

Make a copy of OvmfPkg/AcpiPlatformDxe under BhyvePkg, with the changes needed to support the bhyve hypervisor. Signed-off-by: Rebecca Cran --- BhyvePkg/AcpiPlatformDxe/AcpiPlatform.c | 250 +++ BhyvePkg/AcpiPlatformDxe/AcpiPlatform.h | 76 ++

[edk2-devel] [PATCH v2 8/8] BhyvePkg: Add InstrinsicsLib to BhyveFwCtlLib

On Windows, building BhyveFwCtlLib using VS2019 causes a call to memcpy to be generated. Work around this by adding IntrinsicsLib to resolve the reference. Signed-off-by: Rebecca Cran --- BhyvePkg/Library/BhyveFwCtlLib/BhyveFwCtlLib.inf | 1 + 1 file changed, 1 insertion(+) diff --git

[edk2-devel] [PATCH v2 4/8] OvmfPkg: Add VBE2 mode info structure to LegacyVgaBios.h

bhyve uses the older VESA BIOS Extensions 2.0, so add the mode info structure to IndustryStandard/LegacyVgaBios.h Signed-off-by: Rebecca Cran Acked-by: Laszlo Ersek --- .../Include/IndustryStandard/LegacyVgaBios.h | 38 +++ 1 file changed, 38 insertions(+) diff --git

Re: [edk2-devel] [PATCH v3 3/3] BaseTools: BaseTools changes for RISC-V platform.

Hi Abner Why this line doesn't specify the architect? +DEFINE GCC5_ASM_FLAGS = DEF(GCC5_RISCV_ALL_ASM_FLAGS) -march=DEF(GCC5_RISCV64_ARCH) -mcmodel=medany -mabi=lp64 I think it should be GCC5_ RISCV_ASM_FLAGS, or it may affect other architect. Thanks Zhiguang

Re: [edk2-devel] FW: Discussion: Basetools a separate repo

Even though submodule approach solves the problem after detaching BaseTools from edk2, I think maintaining BaseTools with PIP is best possible approach. Using PIP and versioning helps to easy environment setup for users over submodule with TAG approach. Moving all non-python based tools to

Re: [edk2-devel] [PATCH v1 0/1] BaseTools: BaseTools changes for RISC-V platform.

PATCH V3 sent. > -Original Message- > From: Gao, Liming [mailto:liming@intel.com] > Sent: Tuesday, April 21, 2020 8:57 AM > To: devel@edk2.groups.io; Chang, Abner (HPS SW/FW Technologist) > > Subject: RE: [edk2-devel] [PATCH v1 0/1] BaseTools: BaseTools changes for > RISC-V platform.

Re: [edk2-devel] [edk2][PATCH v2 1/2] MdeModulePkg: PcdAcpiExposedTableVersions default for Arm64 platforms

Hi Laszlo, I think it should be Ok. But if can get ACK/R-B from the maintainer of MdeModulePkg, that would be better, which follows process more. Thanks, Dandan > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Monday, April 20, 2020 8:15 PM > To: Bi, Dandan

[edk2-devel] [PATCH v3 1/3] BaseTools: BaseTools changes for RISC-V platform.

Python code changes for building EDK2 RISC-V platform. Signed-off-by: Abner Chang Co-authored-by: Gilbert Chen Co-authored-by: Daniel Helmut Schaefer Reviewed-by: Leif Lindholm Cc: Bob Feng Cc: Liming Gao Cc: Leif Lindholm Cc: Gilbert Chen --- BaseTools/Source/Python/Common/DataType.py

[edk2-devel] [PATCH v3 0/3] BaseTools changes for RISC-V edk2 port

BZ for entire RISC-V edk2 port, https://bugzilla.tianocore.org/show_bug.cgi?id=2672 These commits are verified by below PR, https://github.com/tianocore/edk2/pull/512 Abner Chang (3): BaseTools: BaseTools changes for RISC-V platform. BaseTools: BaseTools changes for RISC-V platform.

[edk2-devel] [PATCH v3 2/3] BaseTools: BaseTools changes for RISC-V platform.

C code changes for building EDK2 RISC-V platform. Signed-off-by: Abner Chang Co-authored-by: Gilbert Chen Co-authored-by: Daniel Helmut Schaefer Reviewed-by: Leif Lindholm Cc: Bob Feng Cc: Liming Gao Cc: Leif Lindholm Cc: Gilbert Chen --- BaseTools/Source/C/Common/PeCoffLib.h |

[edk2-devel] [PATCH v3 3/3] BaseTools: BaseTools changes for RISC-V platform.

Tools definitions template file changes for building EDK2 RISC-V platform. Signed-off-by: Abner Chang Co-authored-by: Gilbert Chen Co-authored-by: Daniel Helmut Schaefer Reviewed-by: Leif Lindholm Cc: Bob Feng Cc: Liming Gao Cc: Leif Lindholm Cc: Gilbert Chen ---

[edk2-devel] [PATCH v3 6/6] BhyvePkg: Add AcpiPlatformDxe

Make a copy of OvmfPkg/AcpiPlatformDxe under BhyvePkg, with the changes needed to support the bhyve hypervisor. Signed-off-by: Rebecca Cran --- BhyvePkg/AcpiPlatformDxe/AcpiPlatform.c | 250 +++ BhyvePkg/AcpiPlatformDxe/AcpiPlatform.h | 76 ++

[edk2-devel] [PATCH v3 5/6] BhyvePkg: Add PlatformPei

Make a copy of OvmfPkg/PlatformPei under BhyvePkg with the changes that are needed to support the bhyve hypervisor. Signed-off-by: Rebecca Cran --- BhyvePkg/PlatformPei/AmdSev.c | 106 + BhyvePkg/PlatformPei/ClearCache.c | 111 + BhyvePkg/PlatformPei/Cmos.c | 58

[edk2-devel] [PATCH v3 1/6] OvmfPkg: Add bhyve support into AcpiTimerLib

On bhyve, the ACPI timer is located at a fixed IO address; it need not be programmed into, nor fetched from, the PMBA -- power management base address -- register of the PCI host bridge. Signed-off-by: Rebecca Cran Reviewed-by: Laszlo Ersek --- OvmfPkg/Include/IndustryStandard/Bhyve.h |

[edk2-devel] [PATCH v3 2/6] OvmfPkg: Add QemuFwCfgLibNull

Add a null implementation library for QemuFwCfgLib, in order to support building PciHostBridgeLib for bhyve. Signed-off-by: Rebecca Cran --- .../Library/QemuFwCfgLib/QemuFwCfgLibNull.inf | 37 OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgNull.c | 209 ++ 2 files changed, 246

[edk2-devel] [PATCH v3 3/6] OvmfPkg: Add VBE2 mode info structure to LegacyVgaBios.h

bhyve uses the older VESA BIOS Extensions 2.0, so add the mode info structure to IndustryStandard/LegacyVgaBios.h Signed-off-by: Rebecca Cran Acked-by: Laszlo Ersek --- .../Include/IndustryStandard/LegacyVgaBios.h | 38 +++ 1 file changed, 38 insertions(+) diff --git

[edk2-devel] [PATCH v3 0/6] Add BhyvePkg, to support the bhyve hypervisor

I noticed a few things wrong with the v2 series: o BhyveFwCtlLibNull is no longer used, and could be deleted. o Some changes from the v1 AcpiPlatformDxe patch were left in OvmfPkg. o BhyvePkg/License.txt still referred to OvmfPkg. I've updated it so everything under BhyvePkg should be

Re: [edk2-devel] [edk2-staging/EdkRepo] [PATCH] EdkRepo: Remove required delimiter from edkrepo base config class

Reviewed-by: Nate DeSimone -Original Message- From: devel@edk2.groups.io On Behalf Of Ashley E Desimone Sent: Monday, April 20, 2020 3:21 PM To: devel@edk2.groups.io Cc: Desimone, Nathaniel L ; Pandya, Puja ; Bjorge, Erik C ; Bret Barkelew ; Agyeman, Prince Subject: [edk2-devel]

Re: [edk2-devel] Conditionally Include FDF File

Spoke to soon. My change works for the case where BUILD_PLATFORM_XYZ is not defined but the case where it is defined I guess INCLUDE_XYZ_FDF needs to be defined in a different way with proper escape characters. Thanks Ashish From: Ashish Singhal Sent: Monday,

Re: [edk2-devel] [PATCH v1 1/1] NetworkPkg/SnpDxe: Register SnpNotifyExitBootServices at TPL_CALLBACK

On 04/16/20 18:12, Andrew Fish wrote: > Laszlo, > > This is "way back" but UNDI was defined in the Preboot Execution Environment > (PXE) Specification. I think version 2.1 was the last one in and it was > released in 1999. The how to do it in EFI ended up in the EFI spec. > > PXE was a PC

[edk2-devel] [PATCH v2] MdePkg: Include Acpi header file

ACPI memory mapped configuration space access (MCFG) table requires defination of EFI_ACPI_DESCRIPTION_HEADER. Signed-off-by: Wasim Khan --- Changes in v2: Corrected typo in subject .../IndustryStandard/MemoryMappedConfigurationSpaceAccessTable.h| 2 ++ 1 file changed, 2 insertions(+)

Re: [edk2-devel] [PATCH v2] EmulatorPkg/WinHost: Enable network support.

Hi Justen, Andrew, Ray, Could you please help me to review my change? This is version 2 patch to address the comment from TianoDesign meeting on 04/03. Thanks, Nickle -Original Message- From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Nickle Wang Sent: Thursday,

Re: [edk2-devel] [edk2-platform][PATCH v1 0/4] Platform/RaspberryPi : Enable TFTP shell command

On 4/20/20 4:41 AM, awarken...@vmware.com wrote: Hi Andrew, This particular issue revolves around enabling a feature by default in the DSC for Pi 3/4 platforms - the TFTP Shell command. Clearly, enabling this for Pi bears no effect on other Tiano platforms. So far I've heard something about

Re: [edk2-devel] Conditionally Include FDF File

It seems like this is happening because in FdfParser.py, include files are processed before processing the conditional statements. I think this is being done so that all defines (even from the included files) can be accounted for before processing any conditionals. This seems to be a valid flow

Re: [edk2-devel] Conditionally Include FDF File

I saw this issue too. The included file is always included no matter the condition is TRUE or FALSE. ``` !if FALSE !include abc.fdf !endif ``` -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#57597):

Re: [edk2-devel] [PATCH] UefiCpuPkg/MpInitLib: Skip reading PlatformId on AMD processors.

On 04/17/20 10:14, Gary Lin wrote: > On Sat, Feb 29, 2020 at 09:05:45AM -0600, Leo Duran wrote: >> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2556 >> >> This patch uses CPUID signature check to skip reading the PlatformId MSR, >> which is not implemented on AMD processors. >> >> The

Re: [edk2-devel] [PATCH 00/13] BhyvePkg - initial patch series for review

On 04/17/20 08:55, Rebecca Cran wrote: > On 4/17/20 12:46 AM, Rebecca Cran wrote: > >> >> I'm running into a problem with Ecc against any code: I'm using Ubuntu >> 19.10, and have copied the output of running it against MdePkg at the >> end of this email. Does Ecc work with Python 3, or does it

Re: [edk2-devel] [PATCH v2 4/6] MdeModulePkg/SecurityManagementLib: Mark the File parameter as OPTIONAL

On 04/16/20 09:33, Guomin Jiang wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2652 > > According to the File description, the File is optional and can be NULL. > > Signed-off-by: Guomin Jiang > Cc: Jian J Wang > Cc: Hao A Wu > Cc: Dandan Bi > Cc: Liming Gao > --- >

Re: [edk2-devel] [PATCH 00/13] BhyvePkg - initial patch series for review

On 04/17/20 08:46, Rebecca Cran wrote: >> (2) Regarding platform code correctness, if someone from the bhyve >> community can help you and review your code, that's welcome. We've had >> fruitful examples for such collaboration, between xen-devel and >> edk2-devel subscribers. But, I won't really

Re: [edk2-devel] [PATCH 0/6] OvmfPkg/ResetSystemLib: clean up, refactor, fix

On 4/20/20 11:48 AM, Laszlo Ersek wrote: On 04/17/20 18:19, Philippe Mathieu-Daudé wrote: On 4/17/20 5:59 PM, Ard Biesheuvel wrote: On 4/17/20 5:37 PM, Laszlo Ersek wrote: Ref:    https://bugzilla.tianocore.org/show_bug.cgi?id=2675 Repo:   https://pagure.io/lersek/edk2.git Branch: rsl_cleanup

Re: [edk2-devel] [PATCH v2 0/6] Mark the File parameter as OPTIONAL

On 04/16/20 09:33, Guomin Jiang wrote: > File paramter should be optional according to the descritpion. > > Guomin Jiang (6): > SecurityPkg/TPM: measure UEFI images without associated device paths > again > SecurityPkg/DxeImageAuth: Mark the File parameter as option >

Re: [edk2-devel] [PATCH 0/6] OvmfPkg/ResetSystemLib: clean up, refactor, fix

On 04/17/20 18:19, Philippe Mathieu-Daudé wrote: > On 4/17/20 5:59 PM, Ard Biesheuvel wrote: >> On 4/17/20 5:37 PM, Laszlo Ersek wrote: >>> Ref:    https://bugzilla.tianocore.org/show_bug.cgi?id=2675 >>> Repo:   https://pagure.io/lersek/edk2.git >>> Branch: rsl_cleanup >>> >>> Rebecca's >>> >>>   

Re: [edk2-devel] [PATCH v1 2/6] ArmVirtPkg: Add Platform CI and configuration for Core CI

On 04/19/20 22:56, Rebecca Cran wrote: > Where are those pages linked from (i.e. how would people find them)? I've used the following three methods to find content in the wiki: (1) web search (2) if you open and click on the "Pages" box

Re: [edk2-devel] [edk2-discuss] Load Option passing. Either bugs or my confusion.

I'm glad we can reach a consensus that ramfb needs sanity checks. And well, I'm probably at fault with the hijacking. Your QEMU/TCG in QEMU/TCG example also made me realize a deeper problem, though: your setting still can't escape the host display / physical GPU issue. The middle display layers

[edk2-devel] [PATCH] StandaloneMmPkg: Code Cleanup

Removes MmDriverDispatchHandler() declaration. All MM drivers are dispatched at init time, hence implemention of MmDriverDispatchHandler() removed. Signed-off-by: Abdul Lateef Attar --- StandaloneMmPkg/Core/StandaloneMmCore.h | 22 -- 1 file changed, 22 deletions(-) diff

Re: [edk2-devel] SEV Live Migration Support in OVMF

While testing this i found that the Uefi Variable module is loaded much later after AmdSevDxe module is loaded, hence the SetVariable() runtime service is available much later, so now i am setting this new Uefi variable as part of AmdIoMmuDxe module IoMmuMap() call. Thanks, Ashish On Fri, Apr

[edk2-devel] SEV Live Migration Support in OVMF

This is with reference to adding SEV Live migration support in OVMF, which basically is adding a hypercall as part of the MemEncryptSevClearPageEncMask() function. We unconditionally make a hypercall and if the hypercall succeeds then it can sets a new UEFI environment variable

Re: [edk2-devel] [PATCH v2 0/6] Mark the File parameter as OPTIONAL

Thanks Guomin! This change is critical now, because it could fix OpROM dispatch issue, we need this solution check-in as soon as possible to unblock validation tests. --Thanks Shiwei Xu -Original Message- From: Jiang, Guomin Sent: Monday, April 20, 2020 8:56 AM To:

[edk2-devel] [PATCH] MdeModulePkg: Sets the Cursor to selected BootOption.

Its been observed that in MenuManagerMenuApp when user selects a different BootOption using Up/Down key, the current Cursor position is not chaning. Still points to the old BootOption. This changes first dispalys/redraws the old BootOption followed by new BootOption. Doing so will make current

Re: [edk2-devel] [edk2-platform][PATCH v1 0/4] Platform/RaspberryPi : Enable TFTP shell command

Hi Andrei, On Sun, Apr 19, 2020 at 19:56:32 +, awarken...@vmware.com wrote: > If we have to choose abstract goodness over functionality, why > wouldn't we choose functionality? Functionality that's part of > Tiano? The real world doesn't care about the TFTP command being an > "unsupported

Re: [edk2-devel] [edk2-discuss] Load Option passing. Either bugs or my confusion.

On 04/17/20 05:22, Hou Qiming wrote: > I'm glad we can reach a consensus that ramfb needs sanity checks. And well, > I'm probably at fault with the hijacking. > > Your QEMU/TCG in QEMU/TCG example also made me realize a deeper problem, > though: your setting still can't escape the host display /

Re: [edk2-devel] [PATCH 0/6] OvmfPkg/ResetSystemLib: clean up, refactor, fix

On 04/17/20 17:59, Ard Biesheuvel wrote: > On 4/17/20 5:37 PM, Laszlo Ersek wrote: >> Ref:    https://bugzilla.tianocore.org/show_bug.cgi?id=2675 >> Repo:   https://pagure.io/lersek/edk2.git >> Branch: rsl_cleanup >> >> Rebecca's >> >>    [PATCH 02/13] OvmfPkg: support powering off bhyve guests >>

Re: [edk2-devel] [PATCH v1 2/6] ArmVirtPkg: Add Platform CI and configuration for Core CI

On 04/19/20 11:35, Ard Biesheuvel wrote: > On 4/19/20 10:29 AM, Sean via groups.io wrote: >> Laszlo, >> >> Regarding your comments about disliking the verbosity of the markdown >> table/html table for build status both in Core Ci and now these >> Platform CI readme files. >> >> As a learning

Re: [edk2-devel] [PATCH v2 6/6] MdePkg/Security2: Mark the File parameter as OPTIONAL.

On 04/16/20 09:33, Guomin Jiang wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2652 > > According to the description, the File is OPTIONAL and can be NULL. > > Signed-off-by: Guomin Jiang > Cc: Michael D Kinney > Cc: Liming Gao > --- > MdePkg/Include/Protocol/Security2.h | 2 +-

Re: [edk2-devel] [PATCH v4 10/13] OvmfPkg/MptScsiDxe: Initialize hardware

On 04/16/20 18:00, Nikita Leshenko wrote: > > >> On 16 Apr 2020, at 12:53, Laszlo Ersek wrote: >> >> On 04/14/20 19:38, Nikita Leshenko wrote: [...] > I break out the inner structs into separate typedefs, wrap all of them in > #pragma pack (1) / pack () and then create the wrapping aligning

Re: [edk2-devel] OvmfPkg XenPkg: X64 DEBUG GCC5 -DDEBUG_ON_SERIAL_PORT=TRUE build is broken

On Wed, Apr 15, 2020 at 04:04:35PM +0200, Laszlo Ersek wrote: > On 04/14/20 20:01, Rebecca Cran wrote: > > I was trying to build OvmfPkg/XenPkg -a X64 -t GCC5 -b DEBUG > > -DDEBUG_ON_SERIAL_PORT=TRUE, but the build fails. Both plain DEBUG and > > RELEASE builds without trying to put the debug

Re: [edk2-devel] [edk2-platform][PATCH v1 0/4] Platform/RaspberryPi : Enable TFTP shell command

Thanks Ard! > -Original Message- > From: devel@edk2.groups.io On Behalf Of Ard > Biesheuvel via groups.io > Sent: Monday, April 20, 2020 9:25 AM > To: Samer El-Haj-Mahmoud ; > devel@edk2.groups.io > Cc: Leif Lindholm ; Pete Batard ; Andrei > Warkentin (awarken...@vmware.com) > Subject:

Re: [edk2-devel] [edk2-platform][PATCH v1 0/4] Platform/RaspberryPi : Enable TFTP shell command

On 2020.04.20 07:45, Ard Biesheuvel wrote: On 4/20/20 4:41 AM, awarken...@vmware.com wrote: Hi Andrew, This particular issue revolves around enabling a feature by default in the DSC for Pi 3/4 platforms - the TFTP Shell command. Clearly, enabling this for Pi bears no effect on other Tiano

Re: [edk2-devel] [edk2][PATCH v2 1/2] MdeModulePkg: PcdAcpiExposedTableVersions default for Arm64 platforms

Dandan, On 04/18/20 17:14, Samer El-Haj-Mahmoud wrote: > Jian, Hao, > > Can you please push this simple patch? It has been reviewed a while ago and > ready to be committed. should we consider your R-b on the first patch sufficient for pushing? You are marked as "R" for "MdeModulePkg: ACPI

Re: [edk2-devel] [edk2-platform][PATCH v1 0/4] Platform/RaspberryPi : Enable TFTP shell command

On 4/20/20 1:55 PM, Pete Batard wrote: On 2020.04.20 07:45, Ard Biesheuvel wrote: ... I rejected ACPI 6.3 table upgrades because, in their current form, the only thing they achieve is losing the ability to boot an OS that predates ACPI 6.3. Every piece of the platform currently being

Re: [edk2-devel] [edk2-platform][PATCH v1 0/4] Platform/RaspberryPi : Enable TFTP shell command

I have no objection to dropping the "enable TFTP by default". I already stated that to Ard in my original reply. That is not really a big issue (or an issue at all) since we have the -D build option to enable the command in some builds, and the net is no functionality change for end-users. In

Re: [edk2-devel] [edk2-staging/UEFI_PCI_ENHANCE-2 PATCH 05/12] PciBusDxe: Setup sub-phases for PCI feature enumeration

Ray, Sorry for late response as I got into other priorities. Let's try to finish this ASAP. Certainly the implementation of yours has reduced the code size in great deal by deprecating the EFI encodings for the PCIe features, and using the actual HW values along with the global definition of

Re: [edk2-devel] Conditionally Include FDF File

On 04/20/20 07:25, Ashish Singhal wrote: > I am trying to change my top-level FDF file layout by conditionally including > an FDF depending on a build time define being passed or not. > Any help getting around this Try including unconditionally, and pushing down the !if into the includee.

Re: [edk2-devel] FW: Discussion: Basetools a separate repo

On 04/17/20 03:40, Ni, Ray wrote: > From: Matthew Carlson mailto:mac...@microsoft.com>> > Sent: Wednesday, April 15, 2020 4:42 AM > To: Ni, Ray mailto:ray...@intel.com>>; Sean Brogan > mailto:sean.bro...@microsoft.com>> > Subject: Discussion: Basetools a separate repo > > Hello Ray, > > I sent

[edk2-devel] [PATCH v2 0/1] BaseTools changes for RISC-V edk2 port

BZ for entire RISC-V edk2 port, https://bugzilla.tianocore.org/show_bug.cgi?id=2672 These commits are verified by below PR, https://github.com/tianocore/edk2/pull/512 Abner Chang (1): BaseTools: BaseTools changes for RISC-V platform. BaseTools/Source/C/Common/PeCoffLib.h | 9 +

[edk2-devel] [PATCH v2 1/1] BaseTools: BaseTools changes for RISC-V platform.

BaseTools changes for building EDK2 RISC-V platform. The changes made to build_rule.template is to avoid build errors caused by GCC5 tool chain. Signed-off-by: Abner Chang Co-authored-by: Gilbert Chen Co-authored-by: Daniel Helmut Schaefer Reviewed-by: Leif Lindholm Cc: Bob Feng Cc: Liming

Re: [edk2-devel] [edk2-platform][PATCH v1 0/4] Platform/RaspberryPi : Enable TFTP shell command

On 4/19/20 3:04 PM, Samer El-Haj-Mahmoud wrote: Fix an ASSERT with the TFTP dynamic Shell command on the RPi3 and RPi4 when running DEBUG builds. Also, enable the command by default for all builds. Cc: Leif Lindholm Cc: Ard Biesheuvel Cc: Pete Batard Cc: Andrei Warkentin Samer

[edk2-devel] edk2 repo for RedfishPkg

Hi edk2 community members, Per to the short discussion with Mike and Ray, we would like to know your opinions regard to which edk2 repo to accommodate RedfishPkg, edk2/RedfshPkg or edk2-platforms/Features/RedfishPkg? The current direction of edk2 open source is going to reduce the size and some

  1   2   >