Re: [edk2-devel] [PATCH V3 5/8] MdeModulePkg/FirmwarePerformanceDxe: make global variable static

2019-04-25 Thread Wu, Hao A
> -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Gao, > Zhichao > Sent: Friday, April 26, 2019 9:04 AM > To: devel@edk2.groups.io > Cc: Laszlo Ersek; Wang, Jian J; Wu, Hao A; Ni, Ray; Zeng, Star; Gao, Liming; > Bi, > Dandan > Subject:

Re: [edk2-devel] [PATCH v2 3/4] ShellPkg/UefiHandleParsingLib: Remove some unused Guids

2019-04-25 Thread Ni, Ray
Reviewed-by: Ray Ni > -Original Message- > From: Zhang, Shenglei > Sent: Thursday, April 25, 2019 8:02 PM > To: devel@edk2.groups.io > Cc: Carsey, Jaben ; Ni, Ray > Subject: [PATCH v2 3/4] ShellPkg/UefiHandleParsingLib: Remove some > unused Guids > > ExtendedSalBootService.h,

Re: [edk2-devel] [PATCH 2/2] MdeModulePkg/BdsDxe: Use a pcd to set OS indications bit

2019-04-25 Thread Ni, Ray
> -Original Message- > From: Gao, Zhichao > Sent: Thursday, April 25, 2019 8:13 PM > To: Ni, Ray ; 'devel@edk2.groups.io' > > Cc: Bret Barkelew ; Wang, Jian J > ; Zeng, Star ; Gao, Liming > ; Sean Brogan ; > Michael Turner > Subject: RE: [PATCH 2/2] MdeModulePkg/BdsDxe: Use a pcd to set

Re: [edk2-devel] [PATCH v2 2/4] ShellPkg/UefiShellDebug1CommandsLib

2019-04-25 Thread Ni, Ray
Reviewed-by: Ray Ni > -Original Message- > From: Zhang, Shenglei > Sent: Thursday, April 25, 2019 8:02 PM > To: devel@edk2.groups.io > Cc: Carsey, Jaben ; Ni, Ray > Subject: [PATCH v2 2/4] ShellPkg/UefiShellDebug1CommandsLib > > With Itanium architecture unsupported,

Re: [edk2-devel] [PATCH v2] MdeModulePkg/DxeCore: Please static checker for false report

2019-04-25 Thread Wu, Hao A
> -Original Message- > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > Sent: Wednesday, April 24, 2019 3:07 PM > To: Wu, Hao A > Cc: edk2-devel-groups-io; Kinney, Michael D; Gao, Liming; Wang, Jian J > Subject: Re: [PATCH v2] MdeModulePkg/DxeCore: Please static checker for >

Re: [edk2-devel] [PATCH 1/1] MdeModulePkg: BaseSerialPortLib16550: Add Mmio32 support

2019-04-25 Thread Wu, Hao A
> -Original Message- > From: Loh, Tien Hock > Sent: Thursday, April 25, 2019 2:13 PM > To: thlo...@gmail.com devel@edk2.groups.io; Kinney, Michael D > Cc: Loh, Tien Hock; Wang, Jian J; Wu, Hao A > Subject: [PATCH 1/1] MdeModulePkg: BaseSerialPortLib16550: Add Mmio32 > support > > From:

Re: [edk2-devel] [PATCH v2 0/4] Remove IPF and related code

2019-04-25 Thread Liming Gao
Please add the comments in BZ on why Mps.h can't be removed. Thanks Liming >-Original Message- >From: Zhang, Shenglei >Sent: Friday, April 26, 2019 11:02 AM >To: devel@edk2.groups.io >Cc: Justen, Jordan L ; Laszlo Ersek >; Ard Biesheuvel ; Carsey, >Jaben ; Ni, Ray ; Kinney, >Michael D ;

Re: [edk2-devel] [edk2-platforms/devel-MinPlatform] [patch 1/2] KabylakeOpenBoardPkg/KBLRvp3: Remove PcdFrameworkCompatibilitySupport usage

2019-04-25 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Bi, Dandan > Sent: Friday, April 26, 2019 11:32 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Kubacki, Michael A > > Subject: [edk2-platforms/devel-MinPlatform] [patch 1/2] > KabylakeOpenBoardPkg/KBLRvp3: Remove >

[edk2-devel] [edk2-platforms/devel-MinPlatform] [patch 1/2] KabylakeOpenBoardPkg/KBLRvp3: Remove PcdFrameworkCompatibilitySupport usage

2019-04-25 Thread Dandan Bi
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1464 Framework compatibility support is no needed and PcdFrameworkCompatibilitySupport will be removed from edk2. So remove the usage of this PCD in platforms firstly. Cc: Chasel Chiu Cc: Michael Kubacki Contributed-under: TianoCore

[edk2-devel] [edk2-platforms/devel-MinPlatform] [patch 2/2] ClevoOpenBoardPkg/N1xxWU: Remove PcdFrameworkCompatibilitySupport usage

2019-04-25 Thread Dandan Bi
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1464 Framework compatibility support is no needed and PcdFrameworkCompatibilitySupport will be removed from edk2. So remove the usage of this PCD in platforms firstly. Cc: Michael Kubacki Cc: Ankit Sinha Cc: Nate DeSimone Contributed-under:

[edk2-devel] [edk2-platforms/devel-MinPlatform] [patch 0/2] Remove PcdFrameworkCompatibilitySupport usage

2019-04-25 Thread Dandan Bi
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1464 Framework compatibility support is no needed and PcdFrameworkCompatibilitySupport will be removed from edk2. So remove this PCD in platforms firstly. Test done for the series: Build pass for ClevoOpenBoardPkg KabylakeOpenBoardPkg. Boot to

Re: [edk2-devel] [PATCH 2/2] MdeModulePkg/BdsDxe: Use a pcd to set OS indications bit

2019-04-25 Thread Gao, Zhichao
Hi Ray, Refer to the spec 2.8 section 3.4.3: If system firmware supports boot option recovery as described in Section 3.4, system firmware must include a PlatformRecovery variable specifying a short-form File Path Media Device Path (see Section 3.1.2) containing the platform default file

[edk2-devel] [PATCH v2 3/4] ShellPkg/UefiHandleParsingLib: Remove some unused Guids

2019-04-25 Thread Zhang, Shenglei
ExtendedSalBootService.h, ExtendedSalServiceClasses.h and McaInitPmi.h will be deleted. So remove the Guids defined in these Protocols. And also remove strings in uni file. https://bugzilla.tianocore.org/show_bug.cgi?id=1560 Cc: Jaben Carsey Cc: Ray Ni Contributed-under: TianoCore Contribution

[edk2-devel] [PATCH v2 0/4] Remove IPF and related code

2019-04-25 Thread Zhang, Shenglei
Itanium arch is not supported any longer. So remove IPF and related code. https://bugzilla.tianocore.org/show_bug.cgi?id=1560 v2: Withdraw the removal of Mps.h and related changes. Cc: Jordan Justen Cc: Laszlo Ersek Cc: Ard Biesheuvel Cc: Jaben Carsey Cc: Ray Ni Cc: Michael D Kinney Cc:

[edk2-devel] [PATCH v2 2/4] ShellPkg/UefiShellDebug1CommandsLib

2019-04-25 Thread Zhang, Shenglei
With Itanium architecture unsupported, gEfiSalSystemTableGuid and gEfiMpsTableGuid will be no longer used. https://bugzilla.tianocore.org/show_bug.cgi?id=1560 v2:Withdraw the removal of #include and gEfiMpsTableGuid. Cc: Jaben Carsey Cc: Ray Ni Contributed-under: TianoCore Contribution

[edk2-devel] [PATCH v2 1/4] OvmfPkg/PlatformBootManagerLib: Remove dependency on Mps.h

2019-04-25 Thread Zhang, Shenglei
Mps.h is included in BdsPlatform.h but not actually used. So remove it. Cc: Jordan Justen Cc: Laszlo Ersek Cc: Ard Biesheuvel Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Shenglei Zhang Reviewed-by: Laszlo Ersek ---

Re: [edk2-devel] [edk2][edk2-libc/master V2]Request to add new edk2-libc repository

2019-04-25 Thread Carsey, Jaben
The 3 new commits look good. Reviewed-by: Jaben Carsey > -Original Message- > From: Kinney, Michael D > Sent: Thursday, April 25, 2019 5:56 PM > To: devel@edk2.groups.io; Kinney, Michael D > Cc: Carsey, Jaben ; Daryl McDaniel (edk2- > li...@mc2research.org) ; >

Re: [edk2-devel] [PATCH V2 2/2] MdeModulePkg/GraphicsConsoleDxe: Do not clean the screen

2019-04-25 Thread Gao, Zhichao
The change you provided is covered in patch #1. But that can only save one problem: not to repeat clearing the screen which is already set a console mode while adding console devices. This is not match the info in 1412: “This is not a desired

[edk2-devel] [PATCH V2] BaseTools:Fixed an issue where the order of GuidS changed in guid.xref

2019-04-25 Thread Fan, ZhijuX
BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=1749 Add content to dsc [PcdsPatchableInModule.common] gEfiMdeModulePkgTokenSpaceGuid.test1|FALSE The order of file Guid.xref will change after increment build. The root cause is set() is used in Get all the PCDS the order of the data may

Re: [edk2-devel] [PATCH] BaseTools:Fixed an issue where the order of Guids changed in guid.xref

2019-04-25 Thread Bob Feng
Yes. please file a new BZ for this issue. -Original Message- From: Fan, ZhijuX Sent: Friday, April 26, 2019 9:38 AM To: devel@edk2.groups.io; Gao, Liming Cc: Feng, Bob C Subject: FW: [PATCH] BaseTools:Fixed an issue where the order of Guids changed in guid.xref Hi: There is no, Need

[edk2-devel] FW: [PATCH] BaseTools:Fixed an issue where the order of Guids changed in guid.xref

2019-04-25 Thread Fan, ZhijuX
Hi: There is no, Need to create one? Any question, please let me know. Thanks. Best Regards Fan Zhiju -Original Message- From: Gao, Liming Sent: Friday, April 26, 2019 9:32 AM To: Fan, ZhijuX ; devel@edk2.groups.io Cc: Feng, Bob C Subject: RE: [PATCH] BaseTools:Fixed an issue

Re: [edk2-devel] [PATCH V3 6/8] IntelFsp2WrapperPkg/FspWrapperNotifyDxe: make global variable static

2019-04-25 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Gao, Zhichao > Sent: Friday, April 26, 2019 9:04 AM > To: devel@edk2.groups.io > Cc: Laszlo Ersek ; Kinney, Michael D > ; Gao, Liming ; Bi, > Dandan ; Chiu, Chasel ; > Desimone, Nathaniel L > Subject: [PATCH V3 6/8]

Re: [edk2-devel] [PATCH] BaseTools:Fixed an issue where the order of Guids changed in guid.xref

2019-04-25 Thread Liming Gao
Zhiju: Is there one BZ for it? >-Original Message- >From: Fan, ZhijuX >Sent: Friday, April 26, 2019 9:31 AM >To: devel@edk2.groups.io >Cc: Gao, Liming ; Feng, Bob C >Subject: [PATCH] BaseTools:Fixed an issue where the order of Guids changed >in guid.xref > >Add content to dsc

[edk2-devel] [PATCH] BaseTools:Fixed an issue where the order of Guids changed in guid.xref

2019-04-25 Thread Fan, ZhijuX
Add content to dsc [PcdsPatchableInModule.common] gEfiMdeModulePkgTokenSpaceGuid.test1|FALSE Compare the 2 times build result,the order of file Guid.xref change The root cause is set() is used in Get all the PCDS the order of the data may change if set() is used This patch is going to fix that

Re: [edk2-devel] [PATCH V2 2/2] MdeModulePkg/GraphicsConsoleDxe: Do not clean the screen

2019-04-25 Thread Sean via Groups.Io
Is there a branch where this code change can be reviewed?   The intent of bug 1412 was not to break spec alignment on the uefi defined protocol and SetMode() function.  We had a proposed change that can be seen here. https://github.com/Microsoft/mu_basecore/pull/13/files  The idea was for new

[edk2-devel] [Patch V2 2/2] edk2: Update ReadMe.md and Maintainer.txt for edk2-libc repo

2019-04-25 Thread Michael D Kinney
https://bugzilla.tianocore.org/show_bug.cgi?id=1734 The following packages have been moved to the new edk2-libc repository. Remove references to these packages from Readme.md and Maintainers.txt. * AppPkg * StdLib * StdLibPrivateInternalFiles Cc: Jaben Carsey Cc: Daryl McDaniel

[edk2-devel] [Patch V2 1/2] edk2: Remove AppPkg, StdLib, StdLibPrivateInternalFiles

2019-04-25 Thread Michael D Kinney
https://bugzilla.tianocore.org/show_bug.cgi?id=1734 Remove the following packages and move them to the new edk2-libc repository * AppPkg * StdLib * StdLibPrivateInternalFiles Cc: Jaben Carsey Cc: Daryl McDaniel Signed-off-by: Michael D Kinney Reviewed-by: Jaben Carsey ===

Re: [edk2-devel] [Patch] BaseTools: Support customized compiling command

2019-04-25 Thread Liming Gao
Reviewed-by: Liming Gao >-Original Message- >From: Feng, Bob C >Sent: Tuesday, April 23, 2019 11:21 AM >To: devel@edk2.groups.io >Cc: Feng, Bob C ; Gao, Liming >Subject: [Patch] BaseTools: Support customized compiling command > >BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1737

[edk2-devel] [PATCH V3 7/8] IntelFrameworkModulePkg: make global variable static

2019-04-25 Thread Gao, Zhichao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1740 Add a 'static' storage-class specifier to the global variables that only used in a single file to minimize the name collisions. This is only for the variable named 'mExitBootServicesEvent'. Cc: Laszlo Ersek Cc: Michael D Kinney Cc:

[edk2-devel] [PATCH V3 5/8] MdeModulePkg/FirmwarePerformanceDxe: make global variable static

2019-04-25 Thread Gao, Zhichao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1740 Add a 'static' storage-class specifier to the global variables that only used in a single file to minimize the name collisions. This is only for the variable named 'mExitBootServicesEvent'. Cc: Laszlo Ersek Cc: Jian J Wang Cc: Hao Wu

[edk2-devel] [PATCH V3 1/8] MdePkg/UefiDebugLibConOut: make global variable static

2019-04-25 Thread Gao, Zhichao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1740 Add a 'static' storage-class specifier to the global variables that only used in a single file to minimize the name collisions. This is only for the variable named 'mExitBootServicesEvent'. Cc: Laszlo Ersek Cc: Michael D Kinney Cc:

[edk2-devel] [PATCH V3 4/8] IntelFrameworkModulePkg: make global variable static

2019-04-25 Thread Gao, Zhichao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1740 Add a 'static' storage-class specifier to the global variables that only used in a single file to minimize the name collisions. This is only for the variable named 'mExitBootServicesEvent'. Cc: Laszlo Ersek Cc: Michael D Kinney Cc:

[edk2-devel] [PATCH V3 8/8] MdeModulePkg/StatusCodeHandlerRuntimeDxe: make global variable static

2019-04-25 Thread Gao, Zhichao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1740 Add a 'static' storage-class specifier to the global variables that only used in a single file to minimize the name collisions. This is only for the variable named 'mExitBootServicesEvent'. Cc: Laszlo Ersek Cc: Jian J Wang Cc: Hao Wu

[edk2-devel] [PATCH V3 6/8] IntelFsp2WrapperPkg/FspWrapperNotifyDxe: make global variable static

2019-04-25 Thread Gao, Zhichao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1740 Add a 'static' storage-class specifier to the global variables that only used in a single file to minimize the name collisions. This is only for the variable named 'mExitBootServicesEvent'. Cc: Laszlo Ersek Cc: Michael D Kinney Cc:

[edk2-devel] [edk2][edk2-libc/master V2]Request to add new edk2-libc repository

2019-04-25 Thread Michael D Kinney
Hello, New in V2 = * Add details to Readme.md on how the history for these three packages was exported from the edk2 repository using git filter-branch. * Remove redundant content in edk2-libc Readme.md and Maintainters.txt and instead point to content in edk2 repository. * Mark

Re: [edk2-devel] [patch] MdeModulePkg/HiiDB: Minimize memory allocation times after ReadyToBoot

2019-04-25 Thread Dong, Eric
Reviewed-by: Eric Dong > -Original Message- > From: Bi, Dandan > Sent: Thursday, April 25, 2019 11:37 AM > To: devel@edk2.groups.io > Cc: Kinney, Michael D ; Gao, Liming > ; Dong, Eric > Subject: [patch] MdeModulePkg/HiiDB: Minimize memory allocation times > after ReadyToBoot > > REF:

Re: [edk2-devel] [Patch 3/4] QuarkSocPkg/SmmAccessDxe: Set region to UC on SMRAM close

2019-04-25 Thread Steele, Kelly
Reviewed-by: Kelly Steele > -Original Message- > From: Kinney, Michael D > Sent: April 25, 2019 10:54 > To: devel@edk2.groups.io > Cc: Steele, Kelly > Subject: [Patch 3/4] QuarkSocPkg/SmmAccessDxe: Set region to UC on SMRAM > close > > The following commit removed the

Re: [edk2-devel] [Patch 4/4] QuarkPlatformPkg/PlatformInit: Resolve ResetSystemLib name collision

2019-04-25 Thread Steele, Kelly
Reviewed-by: Kelly Steele > -Original Message- > From: Kinney, Michael D > Sent: April 25, 2019 10:54 > To: devel@edk2.groups.io > Cc: Steele, Kelly > Subject: [Patch 4/4] QuarkPlatformPkg/PlatformInit: Resolve ResetSystemLib > name collision > > Change function name from

Re: [edk2-devel] [Patch] QuarkPlatformPkg/AcpiTables: Resolve iASL warnings

2019-04-25 Thread Steele, Kelly
Reviewed-by: Kelly Steele > -Original Message- > From: Kinney, Michael D > Sent: April 25, 2019 11:59 > To: devel@edk2.groups.io > Cc: Steele, Kelly > Subject: [Patch] QuarkPlatformPkg/AcpiTables: Resolve iASL warnings > > Resolve a few warnings from the latest iASL compilers. >

Re: [edk2-devel] [patch] MdeModulePkg/HiiDB: Minimize memory allocation times after ReadyToBoot

2019-04-25 Thread Michael D Kinney
Reviewed-by: Michael D Kinney > -Original Message- > From: Bi, Dandan > Sent: Wednesday, April 24, 2019 8:37 PM > To: devel@edk2.groups.io > Cc: Kinney, Michael D ; Gao, > Liming ; Dong, Eric > > Subject: [patch] MdeModulePkg/HiiDB: Minimize memory > allocation times after ReadyToBoot >

Re: [edk2-devel] [edk2] Request to add new edk2-libc repository

2019-04-25 Thread Michael D Kinney
Hi Laszlo, Thanks for all your feedback. Responses included below. Mike > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Wednesday, April 24, 2019 2:51 AM > To: Kinney, Michael D ; > devel@edk2.groups.io > Cc: Carsey, Jaben ; Daryl > McDaniel

[edk2-devel] [Patch] QuarkPlatformPkg/AcpiTables: Resolve iASL warnings

2019-04-25 Thread Michael D Kinney
Resolve a few warnings from the latest iASL compilers. Cc: Kelly Steele Signed-off-by: Michael D Kinney --- QuarkPlatformPkg/Acpi/AcpiTables/Dsdt/GpioClient.asi | 4 ++-- QuarkPlatformPkg/Acpi/AcpiTables/Dsdt/Platform.asl | 6 +++--- 2 files changed, 5 insertions(+), 5 deletions(-) diff

Re: [edk2-devel] [RFC] Propose to remove QuarkPlatformPkg and QuarkSocPkg

2019-04-25 Thread Michael D Kinney
Ray, Yes. I am working on a patch to do that move. I have been discussing with edk2-platforms maintainers. Mike From: Ni, Ray Sent: Thursday, April 25, 2019 11:23 AM To: Kinney, Michael D ; 'devel@edk2.groups.io' Cc: Steele, Kelly Subject: RE: [RFC] Propose to remove QuarkPlatformPkg and

Re: [edk2-devel] [RFC] Propose to remove QuarkPlatformPkg and QuarkSocPkg

2019-04-25 Thread Ni, Ray
Mike, Thanks for the patch sets that fix the Quark build & boot issues. Do you think we can immediately move Quark to edk2-platforms repo after your fixes are checked in? Thanks, Ray From: Kinney, Michael D Sent: Thursday, April 25, 2019 10:56 AM To: Ni, Ray ; 'devel@edk2.groups.io' ; Kinney,

Re: [edk2-devel] [edk2-platforms/devel-MinPlatform][PATCH v1 2/2] ClevoOpenBoardPkg/AcpiTables: Remove dead code

2019-04-25 Thread Nate DeSimone
Reviewed-by: Nate DeSimone -Original Message- From: Kubacki, Michael A Sent: Wednesday, April 24, 2019 6:09 PM To: devel@edk2.groups.io Cc: Desimone, Nathaniel L ; Sinha, Ankit ; Kinney, Michael D Subject: [edk2-platforms/devel-MinPlatform][PATCH v1 2/2] ClevoOpenBoardPkg/AcpiTables:

Re: [edk2-devel] [edk2-platforms/devel-MinPlatform][PATCH v1 1/2] KabylakeOpenBoardPkg/AcpiTables: Remove dead code

2019-04-25 Thread Nate DeSimone
Reviewed-by: Nate DeSimone -Original Message- From: Kubacki, Michael A Sent: Wednesday, April 24, 2019 6:09 PM To: devel@edk2.groups.io Cc: Desimone, Nathaniel L ; Chiu, Chasel ; Kinney, Michael D Subject: [edk2-platforms/devel-MinPlatform][PATCH v1 1/2]

Re: [edk2-devel] [Patch 2/4] UefiCpuPkg/MpInitLib: Avoid MSR_IA32_APIC_BASE for single core

2019-04-25 Thread Ni, Ray
Reviewed-by: Ray Ni > -Original Message- > From: Kinney, Michael D > Sent: Thursday, April 25, 2019 10:54 AM > To: devel@edk2.groups.io > Cc: Dong, Eric ; Ni, Ray ; Laszlo > Ersek > Subject: [Patch 2/4] UefiCpuPkg/MpInitLib: Avoid MSR_IA32_APIC_BASE for > single core > > Avoid access

Re: [edk2-devel] [RFC] Propose to remove QuarkPlatformPkg and QuarkSocPkg

2019-04-25 Thread Michael D Kinney
Ray, I prefer to keep the Quark packages active in edk2-platforms for a while longer. Mike From: Ni, Ray Sent: Monday, April 8, 2019 7:49 AM To: Kinney, Michael D ; 'devel@edk2.groups.io' Cc: Steele, Kelly Subject: RE: [RFC] Propose to remove QuarkPlatformPkg and QuarkSocPkg Mike, This RFC

[edk2-devel] [Patch 3/4] QuarkSocPkg/SmmAccessDxe: Set region to UC on SMRAM close

2019-04-25 Thread Michael D Kinney
The following commit removed the unconditional UC setting just prior to closing the SMRAM region. This is a correct change for most platforms. https://github.com/tianocore/edk2/commit/bfc87aa78e77ed15b09d1b4499c5eab63e8842bb The Quark platforms still require this UC setting, so move the UC

[edk2-devel] [Patch 0/4] Resolve Quark build and boot issues

2019-04-25 Thread Michael D Kinney
This series of patches resolves a few issues with building and booting Quark platforms. * Name collision from API added to ResetSystemLib * Set SMRAM region to UC when SMRAM region is closed * Do no use LFENCE if CPU does not support SSE2 * Avoid MSR_IA32_APIC_BASE if there is only one CPU Cc:

[edk2-devel] [Patch 4/4] QuarkPlatformPkg/PlatformInit: Resolve ResetSystemLib name collision

2019-04-25 Thread Michael D Kinney
Change function name from ResetSystem() to PlatformResetSystem() to resolve name collision with ResetSystemLib. Cc: Kelly Steele Signed-off-by: Michael D Kinney --- QuarkPlatformPkg/Platform/Pei/PlatformInit/MemoryCallback.c | 6 +++--- .../Platform/Pei/PlatformInit/PlatformEarlyInit.h

[edk2-devel] [Patch 1/4] MdePkg/BaseLib: Verify SSE2 support in IA32 AsmLfence()

2019-04-25 Thread Michael D Kinney
Use CPUID in IA32 implementation of AsmLfence() to verify that SSE2 is supported before using the LFENCE instruction. Cc: Liming Gao Signed-off-by: Michael D Kinney --- MdePkg/Library/BaseLib/Ia32/Lfence.nasm | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git

Re: [edk2-devel] [PATCH V2 20/25] QuarkSocPkg/ResetSystemLib: Add new API ResetSystem

2019-04-25 Thread Michael D Kinney
Reviewed-by: Michael D Kinney > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] > On Behalf Of Gao, Zhichao > Sent: Tuesday, April 16, 2019 11:27 PM > To: devel@edk2.groups.io > Cc: Kinney, Michael D ; > Steele, Kelly ; Gao, Liming > > Subject: [edk2-devel]

Re: [edk2-devel] [PATCH V2 00/25] Add the new APIs ResetSystem and ResetSystemWithSubtype

2019-04-25 Thread Steele, Kelly
QuarkSocPkg/ResetSystemLib Reviewed-by: Kelly Steele > -Original Message- > From: Gao, Zhichao > Sent: April 16, 2019 23:27 > To: devel@edk2.groups.io > Cc: Kinney, Michael D ; Gao, Liming > ; Zhang, Chao B ; Yao, > Jiewen ; Wang, Jian J ; Wu, > Hao A ; Ni, Ray ; Zeng, Star > ; Leif

[edk2-devel] Missing protocols in IHV SCT compared to generic SCT

2019-04-25 Thread jabir
Hi, There are few applicable protocols which are missing for selection in IHV SCT e.g. EFI_HII_CONFIG_ACCESS_PROTOCOL, EFI_FIRMWARE_MANAGEMENT_PROTOCOL when compared to generic SCT. These protocols can be ported to IHV SCT.. Can anybody help me to understand if there is any limitation/issues for

[edk2-devel] reg : UEFI Secure Boot is stuck with Black Screen

2019-04-25 Thread Pavan Kumar Aravapalli
Hi I am new to this and i am trying to perform Windows Server 2016 [Guest VM] UEFI secure boot mode on KVM(Hypervisor) Host using edk2.git-ovmf-x64-0-20190308.1017.g0eccea3fbe.noarch.I am looking for support documents which helps me in assessing the same. Environment Details KVM Host

Re: [edk2-devel] [Patch v3 0/3] Add package level include DSC/FDF in NetworkPkg

2019-04-25 Thread Liming Gao
Cc platform owner and package owner. > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Liming > Gao > Sent: Thursday, April 25, 2019 8:38 PM > To: devel@edk2.groups.io > Subject: [edk2-devel] [Patch v3 0/3] Add package level include DSC/FDF in

[edk2-devel] [Patch][edk2-platform] Migrate devel-MinPlatform branch to master branch

2019-04-25 Thread Liming Gao
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1748 There is no objection on the RFC https://edk2.groups.io/g/devel/topic/31236064#39516 to migrate devel-MinPlatform branch to master branch. This patch moves all patches in devel-MinPlatform branch to master branch. Here is the migrated code

[edk2-devel] [Patch v3 3/3] NetworkPkg: Add package level include DSC file

2019-04-25 Thread Liming Gao
Platform DSC can include Network.dsc.inc to enable network features. Signed-off-by: Liming Gao --- NetworkPkg/Network.dsc.inc | 30 ++ NetworkPkg/NetworkPkg.dsc | 23 +-- 2 files changed, 31 insertions(+), 22 deletions(-) create mode 100644

[edk2-devel] [Patch v3 0/3] Add package level include DSC/FDF in NetworkPkg

2019-04-25 Thread Liming Gao
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1293 BZ 1293 requests to move Network modules from MdeModulePkg to NetworkPkg. To keep the backword compatiblity, Network package level include DSC/FDF are introduced to be used in the platform DSC/FDF files. When Network modules are moved from

[edk2-devel] [Patch v3 2/3] NetworkPkg: Add DSC/FDF include segment files to NetworkPkg.

2019-04-25 Thread Liming Gao
This patch provides a set of include segment files for platform owner to easily enable/disable network stack support on their platform. For DSC, there are: - a "NetworkDefines.dsc.inc" for the [Defines] section(s), - a "NetworkLibs.dsc.inc" for the [LibraryClasses*] section(s), - a

Re: [edk2-devel] [edk2-platforms: PATCH v3 0/4] Armada7k8k FVB improvements

2019-04-25 Thread Marcin Wojtas
Hi Leif, czw., 25 kwi 2019 o 14:01 Leif Lindholm napisał(a): > > Hi Marcin, > > Just to be awkward - edk2-platforms (and edk2-non-osi) have not yet > been relicensed, so we still need "contributed-under" here. > > For this series, can you confirm to the list that this is indeed >

[edk2-devel] [PATCH edk2-platforms 3/3] Platform/Secure96Dxe: add ACPI description of the GPIO LEDs

2019-04-25 Thread Ard Biesheuvel
Wire up the new 96boards mezzanine SSDT loading support, and use it to describe the four GPIO LEDs on the Secure96 mezzanine board. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel --- Platform/96Boards/Secure96Dxe/Secure96.asl| 103

[edk2-devel] [PATCH edk2-platforms 1/3] Silicon/SynQuacer: describe 96boards LS connector GPIOs via ACPI

2019-04-25 Thread Ard Biesheuvel
Describe the 96boards LS connector GPIO resources via a new LS96 device object. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel --- Silicon/Socionext/SynQuacer/AcpiTables/AcpiTables.inf | 14 ++ Silicon/Socionext/SynQuacer/AcpiTables/Dsdt.asl

[edk2-devel] [PATCH edk2-platforms 0/3] enable Secure96 GPIO LEDs on ACPI systems

2019-04-25 Thread Ard Biesheuvel
This series plumbs in the support for describing 96boards mezzanines via ACPI. For now, only the GPIO LEDs are described: in the future, I intend to wire up the I2C and SPI parts as well, but these are currently untested and so not ready for review. Note that this applies onto Silicon/SynQuacer:

[edk2-devel] [PATCH edk2-platforms 2/3] Platform/96Boards: add ACPI support to mezzanine/LS connector driver

2019-04-25 Thread Ard Biesheuvel
Make the LS connector mezzanine support code ACPI aware, and invoke the appropriate hook in the driver code to install a SSDT instead of a DT overlay when running on a system that is booting in ACPI mode. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel ---

Re: [edk2-devel] [edk2-platforms: PATCH v3 0/4] Armada7k8k FVB improvements

2019-04-25 Thread Leif Lindholm
Hi Marcin, Just to be awkward - edk2-platforms (and edk2-non-osi) have not yet been relicensed, so we still need "contributed-under" here. For this series, can you confirm to the list that this is indeed Contributed-under: TianoCore Contribution Agreement 1.1 ? If so, we can fix that up before

[edk2-devel] [edk2-platforms: PATCH v3 0/4] Armada7k8k FVB improvements

2019-04-25 Thread Marcin Wojtas
Hi, The third version of the patchset cleans up the dependencies between the SPI drivers, so that now they explicitly rely on the protocols' instead of BEFORE statements and modules GUIDs. Also force dependency between FTW and MvFvbDxe using library NULL resolution. The patches are available in

[edk2-devel] [edk2-platforms: PATCH v3 4/4] Marvell/Drivers: MvFvbDxe: Introduce non-mmio mode

2019-04-25 Thread Marcin Wojtas
From: Kornel Duleba This path enables support for reading variables directly from flash without relying on it to be memory mapped. It adds PcdSpiMemoryMapped PCD that allows to switch between the modes. When in non-memory-mapped mode the driver will copy the variables from flash to previously

[edk2-devel] [edk2-platforms: PATCH v3 3/4] Marvell/Drivers/Spi: Improve modules dependencies

2019-04-25 Thread Marcin Wojtas
Currently the Marvell SPI DXE drivers depexes are specified with explicit modules' GUIDs and BEFORE/AFTER expressions. Replace it with the actual protocol dependencies. Signed-off-by: Marcin Wojtas --- Silicon/Marvell/Marvell.dec | 3 ---

[edk2-devel] [edk2-platforms: PATCH v3 1/4] Marvell/Drivers: MvFvbDxe: Change Pcd parameters to be 64 bit

2019-04-25 Thread Marcin Wojtas
From: Hanna Hawa Update PCD paramters to be 64 bit, so that to add more flexibility for the platforms in terms of configuring memory-mapped SPI access. Signed-off-by: Marcin Wojtas --- Silicon/Marvell/Marvell.dec | 2 +- Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc

Re: [edk2-devel] [PATCH] EmbeddedPkg: Allow DXE_DRIVER to depend on NvVarStoreFormattedLib

2019-04-25 Thread Ard Biesheuvel
On Thu, 25 Apr 2019 at 11:18, Marcin Wojtas wrote: > > Some modules (such as FaultTolerantWriteDxe) use the FlashNvStorage > PCDs (PcdFlashNvStorageFtw*). In case the flash contents are not > mapped in memory, the module loading order of the FVB driver > may become important. > > To handle above,

[edk2-devel] [PATCH edk2-platforms] Silicon/SynQuacer: add ACPI description of GPIO controller and power button

2019-04-25 Thread Ard Biesheuvel
Add ACPI descriptions of the GPIO and external interrupt (EXIU) controllers as well as the power button. Note that on rev 0.3 boards, the power button appears to reset the system (this was not the case on rev 0.1 boards), so it is included for reference primarily. The same GPIO event mechanism

[edk2-devel] [PATCH] EmbeddedPkg: Allow DXE_DRIVER to depend on NvVarStoreFormattedLib

2019-04-25 Thread Marcin Wojtas
Some modules (such as FaultTolerantWriteDxe) use the FlashNvStorage PCDs (PcdFlashNvStorageFtw*). In case the flash contents are not mapped in memory, the module loading order of the FVB driver may become important. To handle above, this patch allows to hook the dependency of desired DXE_DRIVER

Re: [edk2-devel] [PATCH V2 0/8] Decrease the name collisions

2019-04-25 Thread Gao, Zhichao
> -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Wednesday, April 24, 2019 7:16 PM > To: Gao, Zhichao ; devel@edk2.groups.io > Cc: Wang, Jian J ; Wu, Hao A ; > Ni, Ray ; Zeng, Star ; Kinney, > Michael D ; Gao, Liming > ; Bi, Dandan > Subject: Re: [PATCH V2

Re: [edk2-devel] [PATCH 19/25] PcAtChipsetPkg/ResetSystemLib: Add new API ResetSystem

2019-04-25 Thread Ni, Ray
Reviewed-by: Ray Ni > > -Original Message- > > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > > Gao, Zhichao > > Sent: Monday, April 15, 2019 11:06 AM > > To: devel@edk2.groups.io > > Cc: Ni, Ray ; Gao, Liming > > Subject: [edk2-devel] [PATCH 19/25]