Re: [edk2-devel] [PATCH v3 1/4] ArmPkg: Replace CoreId and ClusterId with Mpidr in ARM_CORE_INFO struct

2022-02-04 Thread Rebecca Cran
On 1/31/22 04:42, Ard Biesheuvel wrote: On Mon, 31 Jan 2022 at 00:22, Ard Biesheuvel wrote: I've had a stab at refactoring this code. Branch can be found here: https://github.com/ardbiesheuvel/edk2/tree/armpkg-mpservicesdxe-refactor OK, I've did some more work on this, and ended up with a

Re: [edk2-devel] [PATCH v4 7/8] PciHostBridgeDxe: Extend service to get base addresses before allocation

2022-02-04 Thread Ojeda Leon, Nicolas via groups.io
Hi Gerd, > Hmm, so you are hiding the #define here to avoid updating > Protocol/PciHostBridgeResourceAllocation.h ... > > I suspect if this can't be implemented in the pci enumerator alone there is > just no way around actually extending uefi protocols. But it's also not > fully clear to me

Re: [edk2-devel] [PATCH v4 7/8] PciHostBridgeDxe: Extend service to get base addresses before allocation

2022-02-04 Thread Ojeda Leon, Nicolas via groups.io
Hi Gerd, > Also: Maybe split this series into two? One for the host-provided bridges, > and another for the pre-populated bars? So the former can already be merged > while the later is still sorted? Is it already possible for someone to merge the first 5 patches or should I submit a new

[edk2-devel] [PATCH v2 1/1] OvmfPkg/VmgExitLib: Fix uninitialized variable warning with XCODE5

2022-02-04 Thread Rebecca Cran
XCODE5 reported the following warning: OvmfPkg/Library/VmgExitLib/VmgExitVcHandler.c:1895:12: note: uninitialized use occurs here Compacted ^ Initialize the 'Compacted' variable to fix the warning. Signed-off-by: Rebecca Cran ---

Re: [edk2-devel] [PATCH 1/1] BaseTools: Update CLANG{35,38}_WARNING_OVERRIDES to ignore unused vars

2022-02-04 Thread Michael D Kinney
Reviewed-by: Michael D Kinney Mike > -Original Message- > From: devel@edk2.groups.io On Behalf Of Rebecca Cran > Sent: Friday, February 4, 2022 11:51 AM > To: devel@edk2.groups.io; Feng, Bob C ; Gao, Liming > ; Chen, Christine > ; Kinney, Michael D ; > Andrew Fish > Cc: Rebecca Cran

[edk2-devel] [PATCH 1/1] BaseTools: Update CLANG{35,38}_WARNING_OVERRIDES to ignore unused vars

2022-02-04 Thread Rebecca Cran
Building with the CLANG35 and CLANG38 toolset fails because of variables which are set but not otherwise used in the RELEASE build. GCC added -Wno-unused-but-set-variable back in 2016, and later added -Wno-unused-const-variable. Add those to CLANG35_WARNING_OVERRIDES and

Re: [edk2-devel] [PATCH 01/79] ProcessorPkg/Include: Add header files of RISC-V processor package

2022-02-04 Thread Abner Chang
BTW Mike, Can Core CI on edk2 repo allow the modules referred in the DSC/FDF (e.g., OvmgRiscV64.dsc) to stay in edk2-platform? Abner From: Kinney, Michael D Sent: Saturday, January 22, 2022 1:37 AM To: Chang, Abner (HPS SW/FW Technologist) ; Leif Lindholm ;

Re: [edk2-devel] OvmfPkg VmgExitLib fails to build with CLANG38 (clang 13.0.0)

2022-02-04 Thread Brijesh Singh via groups.io
On 2/2/22 6:16 PM, Rebecca Cran wrote: > On 2/2/22 14:16, Lendacky, Thomas via groups.io wrote: >> This looks like the same error that XCODE5 was complaining about. The >> patch was submitted by Brijesh, but some CI failure occurred. I'm not >> sure how that is possible from a one line patch

[edk2-devel] [PATCH] IntelFsp2WrapperPkg: Make GetFspm(s)UpdDataAddress reusable

2022-02-04 Thread Kuo, Ted
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3821 Moved GetFspmUpdDataAddress and GetFspsUpdDataAddress to FspWrapperApiLib so that they can be consumed by other drivers. Signed-off-by: Ted Kuo --- .../FspmWrapperPeim/FspmWrapperPeim.c | 18 ---

Re: [edk2-devel] [PATCH v4 7/8] PciHostBridgeDxe: Extend service to get base addresses before allocation

2022-02-04 Thread Gerd Hoffmann
Hi, > -if (ResStatus == EFI_RESOURCE_SATISFIED) { > +if ((ResStatus == EFI_RESOURCE_SATISFIED) || > +(ResStatus == PCI_RESOURCE_PARTIAL)) > +{ > +++ b/MdeModulePkg/Include/Library/PciResourceLib.h > @@ -0,0 +1,20 @@ > +/** @file > + Pci resource library consumed by