Re: Patch to configure sleep time when encountering SMPP throttling error

2010-04-12 Thread Alexander Malysh
this line: +time_t tr_timeout = smpp-throttling_err_time.tv_sec + (int) (smpp-throttling_sleep_time / 100 + 0.5) - now; + 0.5 ?? why is that? and why time_t ? Thanks, Alexander Malysh P.S. Please don't forget userguide patch :) Am 14.03.2010 um 19:47 schrieb Michael

Re: Patch: wtls provision

2010-04-12 Thread Alexander Malysh
but please understand that we are all volunteers and don't receive salary for our work and make this only in our private time. So for such large patches it may take some time to review, test and commit it. Thanks for your understanding and contribution, Alexander Malysh Am 14.03.2010 um 17:46

Re: [PATCH] msg storage abstraction to instances

2010-04-12 Thread Alexander Malysh
that make use of the above Msg* doesn't belongs to gwlib as you made it in your patch. Msg* is gateway internals and not gwlib. Thanks, Alexander Malysh Am 01.03.2010 um 12:46 schrieb Stipe Tolj: Hi list, I have attached a patch against CVS HEAD, that abstracts our current code in gw

Re: ERROR: HTTP[http_smsc]: Message was rejected. SMSC reponse was:

2010-03-25 Thread Alexander Malysh
Hi, please enable debug level and ask your question on us...@kannel.org. This is developer mailing list... Thanks, Alexander Malysh Am 25.03.2010 um 10:27 schrieb Kidi Kidi: Hi all, I'm using HTTP SMSC and i got the error below. Help me Please. 1) When a MO come to my gateway, i can

Re: Switch CVS to SVN

2010-03-22 Thread Alexander Malysh
HI, Am 21.03.2010 um 22:26 schrieb Stipe Tolj: Alexander Malysh schrieb: Hi together, conversion is done. SVN repository is available and usable. Please let me know if you have some issues accessing SVN repo. I will now change cron scripts to generate snapshots etc. Hi Alex

Re: XML Post and dlr-url

2010-03-20 Thread Alexander Malysh
Hi, patch commited to CVS. Thanks, Alexander Malysh Am 16.03.2010 um 12:20 schrieb Alexander Malysh: Hi, attached is patch that should fix any xml related issues. Please test it. Thanks, Alexander Malyshsmsbox_xml.patch Am 27.02.2010 um 10:03 schrieb oscar cassetti: Any

Re: Patch: userguide - modem initialization

2010-03-20 Thread Alexander Malysh
Hi, patch commited to CVS. Thanks, Alexander Malysh Am 17.03.2010 um 05:18 schrieb Nikos Balkanas: Patch resubmitted, merging in some comments by Alvaro. BR, Nikos - Original Message - From: Nikos Balkanas To: devel@kannel.org Cc: Alvaro Cornejo Sent: Monday, March 15, 2010

Switch CVS to SVN

2010-03-20 Thread Alexander Malysh
repository will be available at: https://svn.kannel.org/MODULENAME 4) after that CVS repository is available only in readonly mode Questions? Thanks, Alexander Malysh

Re: [PATCH] fix bug #529 (sms-resend-* ignored for concatenated messages)

2010-03-19 Thread Alexander Malysh
:00 AM, Alexander Malysh amal...@kannel.org wrote: Hi, the possibility for endless loop is equal for each part. So this will not help... We need real fix... Thanks, Alexander Malysh Am 17.03.2010 um 18:04 schrieb Michael Zervakis: Dear Alex, From my experience endless loops

Re: [PATCH] fix bug #529 (sms-resend-* ignored for concatenated messages)

2010-03-18 Thread Alexander Malysh
Hi, the possibility for endless loop is equal for each part. So this will not help... We need real fix... Thanks, Alexander Malysh Am 17.03.2010 um 18:04 schrieb Michael Zervakis: Dear Alex, From my experience endless loops from temporary errors usually occur before ever transmitting

Re: XML Post and dlr-url

2010-03-16 Thread Alexander Malysh
Hi, attached is patch that should fix any xml related issues. Please test it. Thanks, Alexander Malysh smsbox_xml.patch Description: Binary data Am 27.02.2010 um 10:03 schrieb oscar cassetti: Any development on this? On Mon, Feb 22, 2010 at 1:32 PM, Nikos Balkanas n...@amdtelecom.net

Re: sms-resend-freq in sms_router

2010-03-15 Thread Alexander Malysh
Hi, This is really trivial. Not all messages coming at the same second into the global retry queue. Then if we sleep for a long time then we have more messages to send. Got it? Thanks, Alexander Malysh P.S. I don't think it should be documented in the userguide because it just implementation

Re: XML Post and dlr-url

2010-03-15 Thread Alexander Malysh
Hi, yes this is bug, but my point is: if you submit patch then it should be _complete_ instead of half fixed... Thanks, Alexander Malysh Am 15.03.2010 um 19:23 schrieb Nikos Balkanas: Hi, Do you appreciate how heavy/slow libxml is? Besides, that section doesn't use libxml. What you

Re: reenable HTTP_MAX_RETRIES and HTTP_RETRY_DELAY for dlr-url

2010-02-25 Thread Alexander Malysh
Hi Juan, as far as I see in source code, DLRs handled the same. So please try with those 2 config options. Thanks, Alexander Malysh Am 25.02.2010 um 14:54 schrieb Juan Nin: Alex, I'm not sure if you were that night on Barcelona with Alejandro, Stipe, etc, but I asked him to ask you guys

Re: ***HAPPY NEW YEAR! *** from the Kannel Group!

2010-01-04 Thread Alexander Malysh
happy new year!!! Am 31.12.2009 um 15:25 schrieb Stipe Tolj: Dear developers, Dear users, in the name of the whole Kannel Group, and to all the great individual supporters and contributor that have shown tremendous participation and encouragement in this year - making and keeping Kannel

Re: Patch: Compiler warnings

2009-12-23 Thread Alexander Malysh
Hi Nikos, good catch, commited to CVS. Thanks, Alexander Malysh Am 18.12.2009 um 16:20 schrieb Nikos Balkanas: Hi, A couple of ominus compiler warnings: warning: array subscript is above array bounds At least the first one should result in an invalid write during normal

Re: [PATCH] fix bug #529 (sms-resend-* ignored for concatenated messages)

2009-12-17 Thread Alexander Malysh
- handset rejects it We have only two possibility here: 1) if temp error occurs put the _whole_ message into resend queue and resend then _all_ parts (very easy todo) 2) remember smsc which was used for first parts and resend it via the same smsc (complicated but save money :) ) Thanks, Alexander

Re: [PATCH] fix bug #529 (sms-resend-* ignored for concatenated messages)

2009-12-17 Thread Alexander Malysh
get extra messages to the handset despite it not being able to reconstruct (not to mention the extra money ;) ) On Thu, Dec 17, 2009 at 11:33 AM, Alexander Malysh amal...@kannel.org wrote: Hi, unfortunately this will not work as expected (the rule is: _all_ parts if multipart message

Re: [PATCH] Meta Data on DLR's

2009-12-07 Thread Alexander Malysh
Hi, ok I see the reason for dlr_status... but it's not dlr_status field that we forward... should we rename it to cmd_status then ? Thanks, Alexander Malysh Am 06.12.2009 um 20:58 schrieb Alejandro Guerrieri: We added this because some users needed to get command_status values. See Dante

Re: Patch: http-timeout support

2009-12-07 Thread Alexander Malysh
Hi, yes, timeout is not changed and is 240 sec. Don't worry userguide changed as well :) Thanks, Alexander Malysh Am 06.12.2009 um 19:05 schrieb Nikos Balkanas: Hi, You mean that you left gwlib/http.c as before with default timeout to 240 s. Am I reading you correctly? In such case you

Re: Patch: http-timeout support

2009-12-06 Thread Alexander Malysh
Hi Nikos, patch commited to cvs but I dropped part that changed default value. Thanks, Alexander Malysh Am 03.12.2009 um 23:01 schrieb Nikos Balkanas: Hi, This patch adds configurable http-timeout support for outgoing http client connections. Patch provided for bearerbox, wapbox, smsbox

Re: Munin plugin

2009-12-06 Thread Alexander Malysh
Hi, I don't know of any munin plugin. If you write one and post it then we will happily add it to contrib. Thanks, Alexander Malysh Am 18.11.2009 um 09:56 schrieb Rolandow: Hi all, I was wondering if there exists a Munin plugin for Kannel? The plugin's are really easy to write, so I

Re: [PATCH] Meta Data on DLR's

2009-12-06 Thread Alexander Malysh
? I'm +1 for this patch without dlr_status part. Thanks, Alexander Malysh P.S. Don't forget to rebase your patch due to recent changes in dlr_pgsql.c :) Am 05.11.2009 um 23:41 schrieb Alejandro Guerrieri: This is an expanded version of a patch I've done a couple of months ago. It adds

Re: Patch: meta_data.c

2009-12-03 Thread Alexander Malysh
Hi Nikos,thanks for patch but your patch is not enough.Full fix commited to cvs and attached.Thanks,Alexander Malysh meta_memleak.diff Description: Binary data Am 03.12.2009 um 08:46 schrieb Nikos Balkanas:Hi,This patch fixes a memory leak each time an smpp_pdu is processed. Reported first

Re: Patch: meta_data.c

2009-12-03 Thread Alexander Malysh
the list is empty. It doesn't hurt, but would you be kind enough to revert it to the original one? gwlist_destroy(keys, NULL) BR, Nikos - Original Message - From: Alexander Malysh To: Nikos Balkanas Cc: devel@kannel.org Sent: Thursday, December 03, 2009 11:45 AM Subject: Re

Re: SMPP data_sm implementation for MT messages

2009-11-27 Thread Alexander Malysh
that's clear. Thanks, Alexander Malysh Am 27.11.2009 um 15:21 schrieb Michael Zervakis: Let's assume that we follow Alex's recommendation meta-data=?smpp?operation=data_sm... and if operation is omitted we use submit_sm as default. We should clarify what should happen to text=

Re: sqlite3 patches for DLR

2009-11-24 Thread Alexander Malysh
Guerrieri aguerrieri at kannel.org for DB based message store. He already started (completed?) this patch. It would be great to put this all together. Thanks in advance, Alexander Malysh P.S. If you want to post to devel ML you have to subscribe. Am 23.11.2009 um 20:18 schrieb G. David Butler

Re: sqlite3 patches for DLR

2009-11-24 Thread Alexander Malysh
...@kannel.org On 24/11/2009, at 10:32, Alexander Malysh wrote: Hi David, great patch! Some comments: 1) please keep config option database instead of file. I know file is more appropriate but it could be already used and we don't want to break compatibility. 2) please provide patch

Re: DLR counters on the status page

2009-11-24 Thread Alexander Malysh
Alex, could you please commit this patch? Thanks, Alexander Malysh Am 17.11.2009 um 20:40 schrieb Alejandro Guerrieri: Please find a zip with the full folder attached. It's almost a full code rewrite, with lots of changes on the code structure and UI as well, apart from support

Re: [PATCH] dlr_pgsql.c - Table name fix

2009-11-23 Thread Alexander Malysh
Hi, seems no objections, patch commited to cvs... Thanks, Alexander Malysh Am 20.11.2009 um 18:29 schrieb Vincent CHAVANIS: no objections for this patch ? Vincent Stipe Tolj a écrit : Damián Viano schrieb: On Sun, Nov 15, 2009 at 03:43:01PM +0100, Alexander Malysh wrote: Hi, any

Re: DLR counters on the status page

2009-11-19 Thread Alexander Malysh
new, ajaxified version as well, stay tuned ;) Regards, -- Alejandro Guerrieri aguerri...@kannel.org kannel-monitor.zip On 15/11/2009, at 15:44, Alexander Malysh wrote: Hi, @Alex: any news about kannel-monitor patch? Thanks, Alexander Malysh Am 11.11.2009 um 19:47 schrieb

Re: [PATCH] Fix MO concatenation

2009-11-15 Thread Alexander Malysh
Hi, patch commited to cvs... Thanks, Alexander Malysh Am 11.11.2009 um 15:16 schrieb Alexander Malysh: Hi, attached if patch that fixes issue in MO concatenation handling. Just example: - First MO with 2 parts (from:123, to:456, reference id in concat=0, udh=A) - Second

Re: Patch: wap_push_ppg.c

2009-11-15 Thread Alexander Malysh
Hi Nikos, sorry I did not realized that we already allow requesting DLRs without dlr-url in smsbox. I applied your first patch. Thanks, Alexander Malysh Am 14.11.2009 um 15:24 schrieb Nikos Balkanas: Well, sqlbox is not smsbox, and I don't know it. Original patch was to align ppg

Re: [PATCH] dlr_pgsql.c - Table name fix

2009-11-15 Thread Alexander Malysh
Hi, any objections from anybody to apply this patch? AFAIK nobody should depend on case sensitivity for table names... Thanks, Alexander Malysh Am 14.11.2009 um 16:17 schrieb Vincent CHAVANIS: Also, just a warning, before this patch tables/column names were NOT case sensitives. Now

Re: DLR counters on the status page

2009-11-15 Thread Alexander Malysh
Hi, @Alex: any news about kannel-monitor patch? Thanks, Alexander Malysh Am 11.11.2009 um 19:47 schrieb Alejandro Guerrieri: Working on it already, it'll be ready for tomorrow probably. Regards, -- Alejandro Guerrieri aguerri...@kannel.org On 11/11/2009, at 19:35, Alvaro Cornejo

Re: Patch: wap_push_ppg.c

2009-11-14 Thread Alexander Malysh
{ +msg_destroy(copy); +rc = 1; +} What will happens when another box as smsbox is connected to bearerbox and want to receive all DLRs independent whether dlr-url set or not? I think this should be handled in smsbox... Thanks, Alexander Malysh Am 14.11.2009 um 12:06 schrieb

Re: Patch: wap_push_ppg.c

2009-11-14 Thread Alexander Malysh
something special about empty dlr_urls. BR, Nikos - Original Message - From: Alexander Malysh To: Nikos Balkanas Cc: devel@kannel.org Sent: Saturday, November 14, 2009 1:52 PM Subject: Re: Patch: wap_push_ppg.c Hi Nikos, I don't think that blocking DLRs in bearerbox when no dlr

Re: [PATCH] dlr_pgsql.c - Table name fix

2009-11-13 Thread Alexander Malysh
Hi Vincent, seems you sent reverse patch? Thanks, Alexander Malysh Am 13.11.2009 um 18:45 schrieb Vincent CHAVANIS: Here is the PostgreSQL patch. Vincent. refs: http://www.postgresql.org/docs/8.0/static/sql-syntax.html#SQL-SYNTAX-IDENTIFIERS This allows constructing table or column

Re: DLR counters on the status page

2009-11-11 Thread Alexander Malysh
. Are you thinking of turning kannel to SMSc? yes, and it works already... BR, Nikos - Original Message - From: Alexander Malysh amal...@kannel.org To: Alejandro Guerrieri aguerri...@kannel.org Cc: Kannel Devel devel@kannel.org Sent: Wednesday, November 11, 2009 10:36 AM Subject: Re

Re: DLR counters on the status page

2009-11-11 Thread Alexander Malysh
Guerrieri aguerri...@kannel.org On 11/11/2009, at 9:36, Alexander Malysh wrote: Hi Alex, I think we have to expand this patch to handle incoming and outgoing DLRs. Now we don't differentiate DLRs from SMS traffic and therefore this is not a issue. But if we start to differentiate

Re: DLR counters on the status page

2009-11-11 Thread Alexander Malysh
) but yes, on HTTP and derivatives would make sense. Regards, -- Alejandro Guerrieri aguerri...@kannel.org On 11/11/2009, at 11:42, Alexander Malysh wrote: Am 11.11.2009 um 11:38 schrieb Alejandro Guerrieri: Alex, Outgoing DLR's? At least on SMPP, there's not such a thing: when

[PATCH] Fix MO concatenation

2009-11-11 Thread Alexander Malysh
attached patch. Looking for feedback... Thanks, Alexander Malysh bb_smscconn_concat.diff Description: Binary data

Re: [PATCH] Fix MO concatenation

2009-11-11 Thread Alexander Malysh
background info is bellow please read given example and read code. there is nothing I can add to this info... Thanks, Alexander Malysh Am 11.11.2009 um 15:24 schrieb Nikos Balkanas: Hi, Any background info? Did MO concatenation work so far? If yes what is wrong now? Any relevant ticket

Re: [PATCH] Fix MO concatenation

2009-11-11 Thread Alexander Malysh
Nikos, did you read the code? I don't think so... Please do it before saying anything... Thanks, Alexander Malysh Am 11.11.2009 um 15:31 schrieb Nikos Balkanas: I see. But according to SMS spec any concat should be specified in the UDH header (?). Why do we try to support it outside

Re: [PATCH] Fix MO concatenation

2009-11-11 Thread Alexander Malysh
waste time and bandwidth for such emails... Thanks, Alexander Malysh Am 11.11.2009 um 16:19 schrieb Nikos Balkanas: Hi, No i haven't read the code. And i don't think I should. A couple of lines about what the patch is intended to do/or correct would be much more preferable, inasmuch

Re: DLR counters on the status page

2009-11-11 Thread Alexander Malysh
-status-v2.diff.zip On 11/11/2009, at 12:33, Alexander Malysh wrote: Am 11.11.2009 um 12:09 schrieb Alejandro Guerrieri: Ok, so you'd like the patch to transparently handle the concept of outgoing dlrs? yes that would be great... This is 5 minutes patch :) It would be useless

Re: DLR counters on the status page

2009-11-11 Thread Alexander Malysh
clear. I'm +1 on this new format. Do you want me to commit it myself or will you do it? Regards, -- Alejandro Guerrieri aguerri...@kannel.org On 11/11/2009, at 16:46, Alexander Malysh wrote: Hi Alex, I changed your patch a bit. I hope that it would me more clear for users

Re: DLR counters on the status page

2009-11-11 Thread Alexander Malysh
commited to cvs... Am 11.11.2009 um 17:21 schrieb Alexander Malysh: I will commit it shortly... Am 11.11.2009 um 16:54 schrieb Alejandro Guerrieri: Yes you're right, now that we have MO and MT dlr info, it makes more sense to have that on the dlr section instead of having it along

Re: Patch: wap_push_ppg.c

2009-11-11 Thread Alexander Malysh
, Alexander Malysh Am 02.11.2009 um 16:21 schrieb Nikos Balkanas: Hi, Another trivial patch for wap. The code disables dlrs, if no dlr_url is specified, despite if dlr_mask is set. These are 2 different variables, and I don't see why they should be linked like that. I just want the DLR in my

Re: [PATCH] compiling on OSX Snow Leopard

2009-11-09 Thread Alexander Malysh
Hi, this patch will break old OSX support and 32bit compilation. Thanks, Alexander Malysh Am 06.11.2009 um 12:24 schrieb Paul Bagyenda: Kannel CVS crashes when compiled as-is on Snow Leopard. Minor patch fixes things. Attached. x86_64-osx.patch

Re: Patch: smsc_smpp.c

2009-11-09 Thread Alexander Malysh
Hi, I don't see reason to apply this patch. User can just define ton and npi settings. Maybe userguide patch would be more helpful? Thanks, Alexander Malysh Am 02.11.2009 um 12:31 schrieb Nikos Balkanas: Hi, This is another one in my series of trivial patches. This part

Re: Max Log Files

2009-11-09 Thread Alexander Malysh
Hi, this is only for performance reasons. But IMHO 128 log files are too many for one instance :) Thanks, Alexander Malysh Am 06.11.2009 um 21:17 schrieb Alejandro Guerrieri: log.c, line 104: #define MAX_LOGFILES 128 Is there any reason why this number is so low? After adding about 30

Re: Patch: smsc_smpp.c

2009-11-09 Thread Alexander Malysh
Hi, AFAIK ton and npi always bundled together. Therefore I don't see reason to define only one value... Thanks, Alexander Malysh Am 09.11.2009 um 10:54 schrieb Nikos Balkanas: Hi, I don't see a reason to keep these variables bundled. ton is more frequently changed. npi almost never

Re: Max Log Files

2009-11-09 Thread Alexander Malysh
level defined... Regards, -- Alejandro Guerrieri aguerri...@kannel.org On 09/11/2009, at 10:45, Alexander Malysh wrote: Hi, this is only for performance reasons. But IMHO 128 log files are too many for one instance :) Thanks, Alexander Malysh Am 06.11.2009 um 21:17 schrieb Alejandro

Re: [PATCH] compiling on OSX Snow Leopard

2009-11-09 Thread Alexander Malysh
commited to cvs. Thanks, Alexander Malysh Am 09.11.2009 um 11:40 schrieb Paul Bagyenda: True indeed. Updated one (attached) does not. x86_64-osx-2.patch On Nov 09, 2009, at 12:30, Alexander Malysh wrote: Hi, this patch will break old OSX support and 32bit compilation. Thanks, Alexander

Re: Max Log Files

2009-11-09 Thread Alexander Malysh
Hi again, sorry, very busy today, will try review it tomorrow. Thanks, Alexander Malysh Am 09.11.2009 um 14:41 schrieb Alejandro Guerrieri: Ok, that explains it, then :) PS: When you have a minute (or 15 ;)), could you please review the two patches I've sent last week for meta-data

Re: Patch: smsc_smpp.c

2009-10-23 Thread Alexander Malysh
parsing in SMPP due to this clear SMSC bug. This is some homegrown SMSC just don't accept quasi standard. This SMSC should be fixed and not kannel... Thanks, Alexander Malysh PS: I think we should have this configurable and regex group matching should do it... Am 22.10.2009 um 19:24 schrieb

Re: Patch: smsc_smpp.c

2009-10-23 Thread Alexander Malysh
/maker why they ignore quasi standard. The more people ask the more SMSC operator/maker will think about to fix this issue. Thanks, Alexander Malysh Am 23.10.2009 um 11:43 schrieb Nikos Balkanas: Unfortunately mail archives list only first few mails. Many experienced contributors, like

[ANN] Kannel.org downtime Tuesday 23.10.2009

2009-10-23 Thread Alexander Malysh
Hello all, please be aware that kannel.org machine will be down on Tuesday 23.10.2009 from 10:00 CEST till appr. 21:00 CEST due to the move to new data centre. Thanks for understanding, Alexander Malysh

Re: [ANN] Kannel.org downtime Tuesday 27.10.2009

2009-10-23 Thread Alexander Malysh
oops, wrong date 27.10.2009 instead of 23.10.2009 Alexander Malysh schrieb: Hello all, please be aware that kannel.org machine will be down on Tuesday 27.10.2009 from 10:00 CEST till appr. 21:00 CEST due to the move to new data centre. Thanks for understanding, Alexander Malysh

Re: dlr_mysql.c patch

2009-10-22 Thread Alexander Malysh
Hi Niko, could you please send this as one patch because it's too difficult to review? Thanks, Alexander Malysh Am 22.10.2009 um 01:30 schrieb Nikos Balkanas: Here you go. Sorry for the delay, got caught up with my work. I expanded to rest of dbs and to insert and delete statements. BR

Re: Patch: smsc_smpp.c

2009-10-22 Thread Alexander Malysh
can you please give me link to this discussion? Thanks, Alexander Malysh Am 22.10.2009 um 13:17 schrieb Nikos Balkanas: Hi, Oh boy. You missed all the fun :-) Original email by Latitude Test on 13/10/2009, where DELIVERD DLRs are misreported by kannel as failures (type 2). There was quite

Re: dlr_mysql.c patch

2009-10-22 Thread Alexander Malysh
commited to cvs. Thanks, Alexander Malysh Am 22.10.2009 um 13:39 schrieb Nikos Balkanas: Here you go. BR, Nikos - Original Message - From: Alexander Malysh amal...@kannel.org To: Nikos Balkanas nbalka...@gmail.com Cc: devel@kannel.org Sent: Thursday, October 22, 2009 11:06 AM

Re: dlr_mysql.c patch

2009-10-14 Thread Alexander Malysh
of mysql daemon) then mysql reconnect feature doesn't work but our reconnect will work. Thanks, Alexander Malysh Am 14.10.2009 um 01:28 schrieb Nikos Balkanas: Gladly, It is something I found along the way and thought it might be useful to others. No biggie, though. We are returning error

Re: [PATCH] dlr_mysql.c - Table name fix

2009-10-13 Thread Alexander Malysh
functional line in this function... We always can easy add this function again if we find any case that we have to escape... Vincent. Alexander Malysh a écrit : hmm, you make it tooo complicated ;) why not just: octstr_replace(fields-table, octstr_imm(`), octstr_imm(``)); ... instead of calling

Re: [PATCH] dlr_mysql.c - Table name fix

2009-10-13 Thread Alexander Malysh
commited to cvs, thx! Thanks, Alexander Malysh Am 13.10.2009 um 11:01 schrieb Vincent CHAVANIS: Ok, attached the new patch here. Vincent. Alexander Malysh a écrit : Am 13.10.2009 um 00:09 schrieb Vincent CHAVANIS: I'm sure we will find other specific cases that will be processed

Re: [PATCH] dlr_mysql.c - Table name fix

2009-10-12 Thread Alexander Malysh
Hi, +1 for this patch but patch is not complete. It doesn't handle this case: CREATE TABLE `a``b` (`cd` INT); Would you like update your patch? I think as optional callback function ? Thanks, Alex Am 09.10.2009 um 16:27 schrieb Vincent CHAVANIS: this is Mysql specs (cf

Re: [PATCH] dlr_mysql.c - Table name fix

2009-10-12 Thread Alexander Malysh
during the init process Comments ? Vincent. Alexander Malysh a écrit : Hi, +1 for this patch but patch is not complete. It doesn't handle this case: CREATE TABLE `a``b` (`cd` INT); Would you like update your patch? I think as optional callback function ? Thanks, Alex Am 09.10.2009 um 16:27

Re: [PATCH] dlr_mysql.c - Table name fix

2009-10-12 Thread Alexander Malysh
hmm, you make it tooo complicated ;) why not just: octstr_replace(fields-table, octstr_imm(`), octstr_imm(``)); ... instead of calling function/macro with only one line? Thanks, Alex Am 12.10.2009 um 13:45 schrieb Vincent CHAVANIS: done. Vincent Alexander Malysh a écrit : Hi again, I

Re: Kannel wiki

2009-10-02 Thread Alexander Malysh
yes... Thanks, Alex Am 28.09.2009 um 17:03 schrieb Juan Nin: ah that would be cool! would it be http://redmine.kannel.org/wiki/kannel ? On Mon, Sep 28, 2009 at 4:52 AM, Alexander Malysh amal...@kannel.org wrote: HI, we already have wiki in redmine. check redmine.kannel.org. let me know

Re: Kannel wiki

2009-09-28 Thread Alexander Malysh
HI, we already have wiki in redmine. check redmine.kannel.org. let me know if you are willing to edit/maintain wiki and you user account details, then I can get you access to edit wiki. Thanks, Alexander Malysh Am 28.09.2009 um 01:24 schrieb Juan Nin: Tthe User Guide already includes

Re: Bearerbox Panic after receiving CIFS/SMB request at smsbox-port

2009-09-22 Thread Alexander Malysh
Hi Nikos, hmm I saw your patch after I commited my version. sorry... Thanks, Alexander Maysh Am 20.09.2009 um 21:58 schrieb Nikos Balkanas: Hi Alex, Which one? I just sent a patch about the very same thing 10 hrs ago. BR, Nikos - Original Message - From: Alexander Malysh amal

Re: Bearerbox Panic after receiving CIFS/SMB request at smsbox-port

2009-09-22 Thread Alexander Malysh
, Alexander Malysh Am 22.09.2009 um 09:34 schrieb Nikos Balkanas: Hi Alex, No problem. It was quite trivial. But i ask because I don't see the same fix. Which file did you patch? BR, Nikos - Original Message - From: Alexander Malysh amal...@kannel.org To: Nikos Balkanas nbalka

Re: Bearerbox Panic after receiving CIFS/SMB request at smsbox-port

2009-09-20 Thread Alexander Malysh
Hi, thanks for report. I just fixed this issue in cvs. Please retest. Thanks, Alexander Malysh Am 18.09.2009 um 17:00 schrieb Michael Zervakis: Dear all, During testing of Bearerbox using version cvs-20090506 I found that if smsbox socket receives a CIFS/SMB request bearerbox panics

Re: [PATCH] Pass meta-data from message to dlrs

2009-09-04 Thread Alexander Malysh
don't see reason to add internal smpp sequence. this is just one counter and will not add any useful information. 3) ++1 :) Thanks, Alexander Malysh Am 04.09.2009 um 01:08 schrieb Alejandro Guerrieri: Ok, silly diff errors aside (I wasn't including dlr_p.h :P), here's the new patches also

Re: [PATCH] Pass meta-data from message to dlrs

2009-09-04 Thread Alexander Malysh
ahh alex, before you start to add meta_data to db storages please give me time to merge mysql-prepaid branch. Just update your cvs in 30-60min. Thanks, Alexander Malysh Am 04.09.2009 um 09:40 schrieb Alexander Malysh: Hi Alex, if you add: + Octstr *meta_data; to dlr struct then you have

Re: [PATCH] MySQL Escape String (another one)

2009-09-04 Thread Alexander Malysh
Hi, as no objection were there, commited to cvs. Thanks, Alexander Malysh Am 11.08.2009 um 15:14 schrieb Stipe Tolj: Alexander Malysh schrieb: HI, if I look lifecycle page then we can really drop support for mysql 4.1 because 4.0 ended it's lifecycle 30 Aug 2008. I'm +1 in dropping

Re: [PATCH] Pass meta-data from message to dlrs

2009-09-04 Thread Alexander Malysh
Am 04.09.2009 um 13:05 schrieb Alejandro Guerrieri: 2009-09-04 Alexander Malysh amalysh at kannel.org * aclocal.m4, configure, configure.in, gw/dlr_mysql.c, gwlib/ dbpool_mysql.c, test/test_dbpool.c: implemented select/update function calls for dbpool_mysql. This require

Re: [PATCH] Pass meta-data from message to dlrs

2009-09-04 Thread Alexander Malysh
they are all correct if you speak about limit and rownum. we are unable to pass limit or rownum clause to sdb engine because it's abstraction of DBs and we don't know which DB is used. Thanks, Alexander Malysh Am 04.09.2009 um 14:11 schrieb Alejandro Guerrieri: BTW, while I'm adding

Re: [PATCH] Pass meta-data from message to dlrs

2009-09-04 Thread Alexander Malysh
there was a long discussion how to fix this but we didn't get to consensus. please keep it as is. we need to start this discussion again. Thanks, Alexander Malysh Am 04.09.2009 um 14:42 schrieb Damián Viano: On Fri, Sep 04, 2009 at 02:26:57PM +0200, Alexander Malysh wrote: they are all

Re: [PATCH] add support of smsc-id for smpp-tlv group

2009-09-03 Thread Alexander Malysh
with Reply-To. When you change default behaviour you confuse the hell out of people that are using the list correctly. Please revert to old configuration, Nikos - Original Message - From: Alexander Malysh To: Nikos Balkanas Cc: Development mailing list Sent: Wednesday, September 02, 2009 1:57

Re: [PATCH] Pass meta-data from message to dlrs

2009-09-03 Thread Alexander Malysh
? +octstr_format(0x%08lx, pdu- u.submit_sm_resp.command_status), 1); Thanks, Alexander Malysh Am 03.09.2009 um 21:13 schrieb Alejandro Guerrieri: Oh, I see, I've attached the ~ backup file from vim. This are the right files, just in case: kannel-dlr-command-status.diff

Re: [PATCH] add support of smsc-id for smpp-tlv group

2009-09-02 Thread Alexander Malysh
? seems you read only even rows? :) /* we use ; in the middle because ; is split char in smsc-id and can'be in the smsc-id */ #define DEFAULT_SMSC_ID def;ault BR, Nikos - Original Message - From: Alexander Malysh amal...@kannel.org To: Development mailing list devel@kannel.org Sent

Re: [PATCH] add support of smsc-id for smpp-tlv group

2009-09-02 Thread Alexander Malysh
, at 12:57, Alexander Malysh wrote: Am 02.09.2009 um 12:33 schrieb Nikos Balkanas: Yes, but octstr_split can return a single member list, same way it would handle single smsc-ids configured by the user. I have no reading problems, and your comment doesn't explain why you have to use a list

Re: [PATCH] add support of smsc-id for smpp-tlv group

2009-09-02 Thread Alexander Malysh
...@kannel.org Your lists will now only work with Reply-To. When you change default behaviour you confuse the hell out of people that are using the list correctly. Please revert to old configuration, Nikos - Original Message - From: Alexander Malysh To: Nikos Balkanas Cc: Development

[PATCH] add support of smsc-id for smpp-tlv group

2009-09-01 Thread Alexander Malysh
be a list splitted by ; 2) then if we need tlv by name/tag we look first for specific smsc-id Dict and if tlv not found for default smsc-id Comments are welcome. Thanks, Alexander Malysh smpp-tlv-smsc-id.diff Description: Binary data

Re: Queue length

2009-08-31 Thread Alexander Malysh
Hi Alex, sorry for delay... Yes you are right, -1 meanst not infitine but large enough IMO. We should fix docs but not the code. Because if someone want to allow bigger queue then he can set it in config. Thanks, Alex Am 29.08.2009 um 12:40 schrieb Alejandro Guerrieri: Alex, can you

Re: Queue length

2009-08-31 Thread Alexander Malysh
, grp, octstr_imm(sms-outgoing-queue- limit)) == -1) max_outgoing_sms_qlength = DEFAULT_SMS_QLENGTH; I'll prepare a doc patch in the meantime. Regards, -- Alejandro Guerrieri aguerri...@kannel.org On 31/08/2009, at 11:11, Alexander Malysh wrote: Hi

Re: Queue length

2009-08-31 Thread Alexander Malysh
yes, I think bearerbox.h is a good place... Am 31.08.2009 um 12:01 schrieb Alejandro Guerrieri: Ok, where do you suggest to place the macro definition? bearerbox.h? Regards, -- Alejandro Guerrieri aguerri...@kannel.org On 31/08/2009, at 11:50, Alexander Malysh wrote: Hi

Re: Queue length

2009-08-31 Thread Alexander Malysh
+1 from me. can you please commit it? Thanks, Alex Am 31.08.2009 um 12:27 schrieb Alejandro Guerrieri: Ok, here it is. kannel-outgoing-queue-limit.diff Regards, -- Alejandro Guerrieri aguerri...@kannel.org On 31/08/2009, at 12:02, Alexander Malysh wrote: yes, I think bearerbox.h

Re: [PATCH] http admin commands + userguide

2009-08-21 Thread Alexander Malysh
Hi, I looked through this patch but found it too compilcated. I just don't have time to write properly review... sorry... Thanks, Alexander Malysh Am 21.08.2009 um 11:44 schrieb Hillel: Hi Alex, As you picked up some bugs in the last version of this patch, any chance to review

Re: Next release

2009-08-19 Thread Alexander Malysh
Hi, to time no time to check all the bugs and features that should go in. I will have some time in one month to check this... If someone will check redmine and post/close old/no_a_bug tickets then it would be great. Thanks, Alex Am 19.08.2009 um 09:55 schrieb Donald Jackson: Hi everyone,

Re: [PATCH] MySQL Escape String (another one)

2009-08-08 Thread Alexander Malysh
HI, if I look lifecycle page then we can really drop support for mysql 4.1 because 4.0 ended it's lifecycle 30 Aug 2008. Thanks, Alex Am 08.08.2009 um 12:11 schrieb Thomas Göttgens: Hello Alexander, 2 alternatives: - judging by the gap between 1.4.1 and 1.4.3 we're at least another 6

Re: [PATCH] MySQL Escape String (another one)

2009-08-07 Thread Alexander Malysh
done.. Thanks, Alex Am 07.08.2009 um 12:15 schrieb Nikos Balkanas: Holly spam! Can someone please remove from list? BR, Nikos - Original Message - From: jda...@angelmih.com To: devel@kannel.org Sent: Friday, August 07, 2009 1:05 PM Subject: Re: Re: Re: Re: Re: Re: Re: Re: Re: Re:

Re: [PATCH] MySQL Escape String (another one)

2009-08-07 Thread Alexander Malysh
Hi, escpaing have to be done with DB connection otherwise it's just impossible ro escape (think about different charsets). But if we drop support for mysql 4.1 then I'm -1 for this patch because we can use prepared statements that don't require escaping. If we decide to drop mysql

[PATCH] Re: [PATCH] MySQL Escape String (another one)

2009-08-07 Thread Alexander Malysh
and there is a patch that adds handling of bind vars for mysql but require mysql version = 4.1 Thanks, Alex mysql-prepared.patch Description: Binary data Am 07.08.2009 um 14:13 schrieb Alexander Malysh: Hi, escpaing have to be done with DB connection otherwise it's just impossible

Re: Kannel store issue

2009-08-03 Thread Alexander Malysh
Hi Donald, which type of store you use? I think, you use file? please try different store type and then see if it helps. Thanks, Alex Am 02.08.2009 um 10:11 schrieb Donald Jackson: Hi Nikos, No its not dependant on queue size and is fairly unpredictable. I see it does happen when the

Re: Mysql with short wait_timeout

2009-07-29 Thread Alexander Malysh
Hi, Am 29.07.2009 um 17:51 schrieb Mathieu Bruneau: On Wed, Jul 29, 2009 at 3:33 AM, Alexander Malysh amal...@kannel.org wrote: Hi, Am 28.07.2009 um 22:18 schrieb Mathieu Bruneau: On Tue, Jul 28, 2009 at 12:03 PM, Alexander Malysh amal...@kannel.org wrote: just add store support

Re: Mysql with short wait_timeout

2009-07-28 Thread Alexander Malysh
Hi, I don't think there is something to fix. Kannel checks connection before using it and then try to reconnect if needed. If your mysql instance is not allowing to connect anymore then kannel has only 2 options: 1) panic, this is what we doing now 2) try to connect in a loop with some

Re: Mysql with short wait_timeout

2009-07-28 Thread Alexander Malysh
Hi, Am 28.07.2009 um 09:59 schrieb Guillaume Cottenceau: Alexander Malysh amalysh 'at' kannel.org writes: If your mysql instance is not allowing to connect anymore then kannel has only 2 options: 1) panic, this is what we doing now 2) try to connect in a loop with some timeout

<    1   2   3   4   5   6   7   8   9   10   >