Re: fedpkg sources - downloading unused source files: opt-in/opt-out

2022-05-10 Thread Artur Frenszek-Iwicki
> Are you manually editing the "sources" file? No, why would I? A.FI. ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct:

Re: fedpkg sources - downloading unused source files: opt-in/opt-out

2022-05-10 Thread Otto Urpelainen
Neal Gompa kirjoitti 10.5.2022 klo 2.10: On Mon, May 9, 2022 at 7:00 PM Kevin Fenzi wrote: On Mon, May 09, 2022 at 01:21:53PM -0400, Neal Gompa wrote: On Mon, May 9, 2022 at 1:13 PM Kevin Fenzi wrote: On Wed, May 04, 2022 at 09:45:55PM +0300, Otto Urpelainen wrote: Ondrej Nosek kirjoitti

Re: fedpkg sources - downloading unused source files: opt-in/opt-out

2022-05-10 Thread Sérgio Basto
A ter, 10-05-2022 às 10:22 +0200, Vít Ondruch escreveu: > Ok, now I see commits such as: > > https://src.fedoraproject.org/rpms/ffmpeg/c/70ecae14df6b89cbd269778fc6808eb6e51e141e?branch=rawhide > > which is awful that we need something like this. But @Neal, wouldn't > it > be better if your

Re: fedpkg sources - downloading unused source files: opt-in/opt-out

2022-05-10 Thread Vitaly Zaitsev via devel
On 10/05/2022 10:23, Artur Frenszek-Iwicki wrote: 2. Edit the spec file in a way that changes which sources are used (say, update to a new version) 3. Do not run "fedpkg new-sources" to upload the new tarballs 4. The "sources" file now lists files that are not actually used by the spec Are

Re: fedpkg sources - downloading unused source files: opt-in/opt-out

2022-05-10 Thread Petr Pisar
V Tue, May 10, 2022 at 08:23:17AM -, Artur Frenszek-Iwicki napsal(a): > > I somehow don't understand why there should be anything like "unused > > source files". Why is something like this even possible? > 1. Grab a package > 2. Edit the spec file in a way that changes which sources are used

Re: fedpkg sources - downloading unused source files: opt-in/opt-out

2022-05-10 Thread Artur Frenszek-Iwicki
> I very likely have the files listed in sources > around from previous attempts Well, yeah, but it's also likely that someone: 1. Has multiple machines, hadn't done any work on this package on the current machine, and did a fresh "fedpkg clone" 2. Got fed up with clutter in the directory and

Re: fedpkg sources - downloading unused source files: opt-in/opt-out

2022-05-10 Thread Vít Ondruch
Dne 10. 05. 22 v 10:23 Artur Frenszek-Iwicki napsal(a): I somehow don't understand why there should be anything like "unused source files". Why is something like this even possible? 1. Grab a package 2. Edit the spec file in a way that changes which sources are used (say, update to a new

Re: fedpkg sources - downloading unused source files: opt-in/opt-out

2022-05-10 Thread Artur Frenszek-Iwicki
> I somehow don't understand why there should be anything like "unused > source files". Why is something like this even possible? 1. Grab a package 2. Edit the spec file in a way that changes which sources are used (say, update to a new version) 3. Do not run "fedpkg new-sources" to upload the

Re: fedpkg sources - downloading unused source files: opt-in/opt-out

2022-05-10 Thread Vít Ondruch
Ok, now I see commits such as: https://src.fedoraproject.org/rpms/ffmpeg/c/70ecae14df6b89cbd269778fc6808eb6e51e141e?branch=rawhide which is awful that we need something like this. But @Neal, wouldn't it be better if your `ffmpeg_gen_free_tarball.sh` simply updated the hashes in `sources`

Re: fedpkg sources - downloading unused source files: opt-in/opt-out

2022-05-10 Thread Vít Ondruch
I somehow don't understand why there should be anything like "unused source files". Why is something like this even possible? It seems strange that this was not questioned originally and it seems still strange nobody questions this in this thread. Vít Dne 04. 05. 22 v 17:01 Ondrej Nosek

Re: fedpkg sources - downloading unused source files: opt-in/opt-out

2022-05-09 Thread Neal Gompa
On Mon, May 9, 2022 at 7:00 PM Kevin Fenzi wrote: > > On Mon, May 09, 2022 at 01:21:53PM -0400, Neal Gompa wrote: > > On Mon, May 9, 2022 at 1:13 PM Kevin Fenzi wrote: > > > > > > On Wed, May 04, 2022 at 09:45:55PM +0300, Otto Urpelainen wrote: > > > > Ondrej Nosek kirjoitti 4.5.2022 klo 18.01:

Re: fedpkg sources - downloading unused source files: opt-in/opt-out

2022-05-09 Thread Kevin Fenzi
On Mon, May 09, 2022 at 01:21:53PM -0400, Neal Gompa wrote: > On Mon, May 9, 2022 at 1:13 PM Kevin Fenzi wrote: > > > > On Wed, May 04, 2022 at 09:45:55PM +0300, Otto Urpelainen wrote: > > > Ondrej Nosek kirjoitti 4.5.2022 klo 18.01: > > > > Hi all, > > > > > > > > A few months ago fedpkg

Re: fedpkg sources - downloading unused source files: opt-in/opt-out

2022-05-09 Thread Neal Gompa
On Mon, May 9, 2022 at 1:13 PM Kevin Fenzi wrote: > > On Wed, May 04, 2022 at 09:45:55PM +0300, Otto Urpelainen wrote: > > Ondrej Nosek kirjoitti 4.5.2022 klo 18.01: > > > Hi all, > > > > > > A few months ago fedpkg introduced a change which avoids downloading > > > source > > > files (from

Re: fedpkg sources - downloading unused source files: opt-in/opt-out

2022-05-09 Thread Kevin Fenzi
On Wed, May 04, 2022 at 09:45:55PM +0300, Otto Urpelainen wrote: > Ondrej Nosek kirjoitti 4.5.2022 klo 18.01: > > Hi all, > > > > A few months ago fedpkg introduced a change which avoids downloading source > > files (from dist-git) that are not used in the specfile and therefore > > downloading

Re: fedpkg sources - downloading unused source files: opt-in/opt-out

2022-05-08 Thread Otto Urpelainen
Sérgio Basto kirjoitti 8.5.2022 klo 7.52: On Wed, 2022-05-04 at 21:45 +0300, Otto Urpelainen wrote: Author of the patch under discussion here. The premise was that "specfile sources" equal "sources file sources". Since there is a request like this, that is apparently not always the case.

Re: fedpkg sources - downloading unused source files: opt-in/opt-out

2022-05-07 Thread Sérgio Basto
On Wed, 2022-05-04 at 21:45 +0300, Otto Urpelainen wrote: > Ondrej Nosek kirjoitti 4.5.2022 klo 18.01: > > Hi all, > > > > A few months ago fedpkg introduced a change which avoids > > downloading source > > files (from dist-git) that are not used in the specfile and > > therefore > > downloading

Re: fedpkg sources - downloading unused source files: opt-in/opt-out

2022-05-04 Thread Otto Urpelainen
Ondrej Nosek kirjoitti 4.5.2022 klo 18.01: Hi all, A few months ago fedpkg introduced a change which avoids downloading source files (from dist-git) that are not used in the specfile and therefore downloading them would be wasting of resources and time. The original request was opened here [1]

Re: fedpkg sources - downloading unused source files: opt-in/opt-out

2022-05-04 Thread Miro Hrončok
On 04. 05. 22 17:21, Petr Pisar wrote: V Wed, May 04, 2022 at 03:14:24PM -, Artur Frenszek-Iwicki napsal(a): For me personally, opt-out would be better, since the logic is right most of the time. And doesn't break it, in the rare cases, building packages in Koji? When a source package is

Re: fedpkg sources - downloading unused source files: opt-in/opt-out

2022-05-04 Thread Sérgio Basto
On Wed, 2022-05-04 at 17:01 +0200, Ondrej Nosek wrote: > Hi all, > > A few months ago fedpkg introduced a change which avoids downloading > source files (from dist-git) that are not used in the specfile and > therefore downloading them would be wasting of resources and time. > The original

Re: fedpkg sources - downloading unused source files: opt-in/opt-out

2022-05-04 Thread Petr Pisar
V Wed, May 04, 2022 at 03:14:24PM -, Artur Frenszek-Iwicki napsal(a): > For me personally, opt-out would be better, since the logic is right most of > the time. > And doesn't break it, in the rare cases, building packages in Koji? When a source package is built in Koji, sources are

Re: fedpkg sources - downloading unused source files: opt-in/opt-out

2022-05-04 Thread Artur Frenszek-Iwicki
For me personally, opt-out would be better, since the logic is right most of the time. That being said, how about adding a value for this in $HOME/.config/rpkg/fedpkg.conf? That way, you have some default value, which can be overridden by the config, which in turn can be overridden by the

fedpkg sources - downloading unused source files: opt-in/opt-out

2022-05-04 Thread Ondrej Nosek
Hi all, A few months ago fedpkg introduced a change which avoids downloading source files (from dist-git) that are not used in the specfile and therefore downloading them would be wasting of resources and time. The original request was opened here [1] and implemented here [2]. The logic is part