[developer] Re: [openzfs/openzfs] 9630 add lzc_rename and lzc_destroy to libzfs_core (#660)

2018-07-10 Thread Andriy Gapon
@avg-I pushed 4 commits. faddcee make zfs_ioc_destroy and zfs_ioc_rename automatically determine objset type 29f6d88 lzc_rename: assert that libzfs_core is initialized 8b2c4bb move lzc_rename and lzc_destroy to a new version, ILLUMOS_0.3 9d3e5ae ZFS_IOC_DESTROY -> lzc_destroy, ZFS_IOC_RENAME

[developer] Re: [openzfs/openzfs] 9630 add lzc_rename and lzc_destroy to libzfs_core (#660)

2018-07-10 Thread Andrew Stormont
andy-js approved this pull request. LGTM. Thanks for taking the time to clean-up libzfs. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openzfs/openzfs/pull/660#pullrequestreview-135829277

[developer] Re: [openzfs/openzfs] 9647 Introduce ZFS Read/Write kstats (#664)

2018-07-10 Thread Roman Strashkin
Ramzec commented on this pull request. > + * There should not be anything wrong with having kstats for +* snapshots. Since we are not sure how useful they would be +* though nor how much their memory overhead would matter in +* a filesystem with many snapshots, we

[developer] Re: [openzfs/openzfs] 9630 add lzc_rename and lzc_destroy to libzfs_core (#660)

2018-07-10 Thread Andriy Gapon
@avg-I pushed 1 commit. 6d3ea4b fix up copy-paste errors -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/openzfs/openzfs/pull/660/files/9d3e5ae329d085a4c54623af8b30899ce88458d0..6d3ea4b966e57446bd6aad2fff2d3807f5937027

[developer] [openzfs/openzfs] 9647 Introduce ZFS Read/Write kstats (#664)

2018-07-10 Thread Serapheim Dimitropoulos
Reviewed by: Sara Hartse Reviewed by: Sebastien Roy Reviewed by: Matthew Ahrens Reviewed by: George Wilson There are use-cases when we want to look into dataset performance (reads/writes) in ZFS and create high-level tooling for it. In illumos we already have some of these kstats already in

Re: [developer] re-adding a drive to a pool causes resilver to start over?

2018-07-10 Thread Pawel Jakub Dawidek
On 7/9/18 23:39, Ken Merry wrote: > Hi ZFS folks, > > We (Spectra Logic) have seen some odd behavior with resilvers in RAIDZ3 pools. > > The codebase in question is FreeBSD stable/11 from July 2017, at > approximately FreeBSD SVN version 321310. > > We have customer systems with (sometimes)

[developer] Re: [openzfs/openzfs] 9647 Introduce ZFS Read/Write kstats (#664)

2018-07-10 Thread Serapheim Dimitropoulos
sdimitro commented on this pull request. > + * There should not be anything wrong with having kstats for +* snapshots. Since we are not sure how useful they would be +* though nor how much their memory overhead would matter in +* a filesystem with many snapshots, we

[developer] Re: [openzfs/openzfs] 9647 Introduce ZFS Read/Write kstats (#664)

2018-07-10 Thread Roman Strashkin
Ramzec commented on this pull request. > + * There should not be anything wrong with having kstats for +* snapshots. Since we are not sure how useful they would be +* though nor how much their memory overhead would matter in +* a filesystem with many snapshots, we

Re: [developer] re-adding a drive to a pool causes resilver to start over?

2018-07-10 Thread Andrew Gabriel
On 10/07/2018 09:26, Pawel Jakub Dawidek wrote: On 7/9/18 23:39, Ken Merry wrote: Hi ZFS folks, We (Spectra Logic) have seen some odd behavior with resilvers in RAIDZ3 pools. The codebase in question is FreeBSD stable/11 from July 2017, at approximately FreeBSD SVN version 321310. We have

Re: [developer] re-adding a drive to a pool causes resilver to start over?

2018-07-10 Thread Kenneth D. Merry
On Tue, Jul 10, 2018 at 10:26:52 +0200, Pawel Jakub Dawidek wrote: > On 7/9/18 23:39, Ken Merry wrote: > > Hi ZFS folks, > > > > We (Spectra Logic) have seen some odd behavior with resilvers in RAIDZ3 > > pools. > > > > The codebase in question is FreeBSD stable/11 from July 2017, at > >