Re: RFC #2705 (Support for SELECT FOR UPDATE)

2011-04-15 Thread Dan Fairs
Thanks for following up on those. I reviewed the Oracle tests shortly before the 1.3 release and fixed all the real failures in the backend. The remaining failures as of then were due to the backend not interacting well with the test suite as documented in ticket #15573, plus a DB cache issue

Re: RFC #2705 (Support for SELECT FOR UPDATE)

2011-04-13 Thread Ian Kelly
On Wed, Apr 13, 2011 at 2:08 PM, Dan Fairs wrote: > However, > it's worth mentioning that the Oracle tests seemed to be mostly broken in > the first place, with dozens of errors. Thanks for following up on those. I reviewed the Oracle tests shortly before the 1.3 release

Re: RFC #2705 (Support for SELECT FOR UPDATE)

2011-04-13 Thread Dan Fairs
Hi, Sorry to bump this one again. Now 1.3's out the door, I'd like this to be looked at again, if possible. http://code.djangoproject.com/ticket/2705 I'll re-apply Ramiro's patch locally and make sure everything still checks out for me, and report back. The latest version of the patch

Re: RFC #2705 (Support for SELECT FOR UPDATE)

2011-04-02 Thread Dan Fairs
Hi, Now 1.3's out the door, I'd like this to be looked at again, if possible. http://code.djangoproject.com/ticket/2705 I'll re-apply Ramiro's patch locally and make sure everything still checks out for me, and report back. The latest version of the patch still applied cleanly for me

Re: RFC #2705 (Support for SELECT FOR UPDATE)

2010-12-22 Thread Dan Fairs
> > On Tue, Dec 21, 2010 at 10:31 AM, Dan Fairs wrote: >> I've mainly worked on the tests and docs, not the core content of the patch, >> but I'd welcome any comments on the implementation as well - I'd like to see >> this get in (be it in a 1.3 or 1.4 timeframe) so if any

Re: RFC #2705 (Support for SELECT FOR UPDATE)

2010-12-21 Thread Ian Kelly
On Tue, Dec 21, 2010 at 10:31 AM, Dan Fairs wrote: > I've mainly worked on the tests and docs, not the core content of the patch, > but I'd welcome any comments on the implementation as well - I'd like to see > this get in (be it in a 1.3 or 1.4 timeframe) so if any changes