Re: TemplateView and FormView inconsistency

2019-08-14 Thread Adam Johnson
I came up with a PR that will raise a deprecation warning on variable access - see the ticket. On Wed, 14 Aug 2019 at 14:46, step21 wrote: > I do not have a better idea right now, but also do not know the django > core code that well. Personally, as you could get all TemplateViews via Ack > or

Re: TemplateView and FormView inconsistency

2019-08-14 Thread step21
I do not have a better idea right now, but also do not know the django core code that well. Personally, as you could get all TemplateViews via Ack or another code search method, I do not think replacing them would take long. > Am 14.08.2019 um 09:45 schrieb Adam Johnson : > > Hi, > > After

Re: TemplateView and FormView inconsistency

2019-08-14 Thread Adam Johnson
Hi, After reading the ticket, I agree this could be deprecated as a backwards incompatibility. The deprecation plan suggested by loic84 looks like it could work but would be a bit unwieldy on large projects. Maybe there's another path? One thing that's not explicitly in the discussion: the view

TemplateView and FormView inconsistency

2019-08-13 Thread step21
Hi all, When developing I noticed an inconsistency - when using TemplateView, kwargs are passed to context, but not when using FormView or others. Source comparison: https://dpaste.de/Jwdn Relevant super old issue talking about depreciation here: https://code.djangoproject.com/ticket/19878 I