Re: proposing max line length of 119 + enforcing it with flake8

2014-09-03 Thread Anssi Kääriäinen
+1 It is a good idea to have some limit on line lengths. There are some exceptions where longer lines improve readability, but in those rare cases we can just use # noqa. - Anssi On Wed, 2014-09-03 at 12:47 -0700, Tim Graham wrote: > Ticket #23395 raised the issue that our contributing guidelin

Re: Proposal: The 'use' template tag, a cross between 'include' and 'extends'.

2014-09-03 Thread Curtis Maloney
Interesting idea... so much so I'd like to steal it :) However, since it can be implemented as a 3rd party app, I suspect you'll get some push-back from trying to get it into core. I've recently started work to reimagine my "sniplates" project [ https://bitbucket.org/funkybob/django-sniplates], w

Re: proposing max line length of 119 + enforcing it with flake8

2014-09-03 Thread Aymeric Augustin
That works for me. Considering the amount of code that needs fixing, it isn't a big deal if the cleanup is spread over many commits. -- Aymeric. -- You received this message because you are subscribed to the Google Groups "Django developers" group. To unsubscribe from this group and stop rece

Re: proposing max line length of 119 + enforcing it with flake8

2014-09-03 Thread Daniele Procida
On Wed, Sep 3, 2014, Tim Graham wrote: >The biggest hurdle is cleaning up the existing code as we currently have >~1700 lines longer than that. I attached an initial patch on the ticket to >show how long strings can be restructured. If there is no objection, >perhaps I can work with some afrai

Re: DatabaseError: no such table: django_content_type

2014-09-03 Thread Tim Graham
This is django-developers, the list for discussing the development of Django itself. For questions about using Django, please use the django-users mailing list. It's also helpful to include a traceback of the error. On Wednesday, September 3, 2014 4:29:52 PM UTC-4, Leandro Moreno wrote: > > Hel

Re: Please don't kill the ecosystem

2014-09-03 Thread Collin Anderson
Considering we're trying to come out with more frequent releases, I wonder if it would sometimes make sense to sometimes have a 3-release deprecation for some features. -- You received this message because you are subscribed to the Google Groups "Django developers" group. To unsubscribe from thi

DatabaseError: no such table: django_content_type

2014-09-03 Thread Leandro Moreno
Hello list! I'm trying to run my tests and I have these error. In a config.py file I'm doing this: from django.contrib.contenttypes.models import ContentType ContentType.objects.get_for_model(model=MyModel) And when I run the tests, this error apears, and only with tests. I'm including contrib.

Re: proposing max line length of 119 + enforcing it with flake8

2014-09-03 Thread Carl Meyer
On 09/03/2014 01:47 PM, Tim Graham wrote: > Ticket #23395 raised the > issue that our contributing guidelines is not exactly clear regarding > long lines. Currently it says, > > "One big exception to PEP 8 is our preference of longer line lengths. > We

proposing max line length of 119 + enforcing it with flake8

2014-09-03 Thread Tim Graham
Ticket #23395 raised the issue that our contributing guidelines is not exactly clear regarding long lines. Currently it says, "One big exception to PEP 8 is our preference of longer line lengths. We’re well into the 21st Century, and we have high-re

Re: Please don't kill the ecosystem

2014-09-03 Thread Pkl
Hello, Hello, My apologies for sounding rude, and for raising these issues so late. Yes, upgrading a project itself is a matter of a pair of evenings, the problem is with third-party libraries, and more again, plugins of third-party libraries (especially CMS-related). I've had to bundle a doz

Re: integrating django-secure

2014-09-03 Thread Tim Graham
Over the past couple days, I've made some more updates and polish to the PR. A couple people have looked at it, but some more eyes would be appreciated as it's hopefully now in a mergeable state. Thanks! https://github.com/django/django/pull/3128 p.s. It uses flat, non-dict settings. We can con

Re: Proposal: The 'use' template tag, a cross between 'include' and 'extends'.

2014-09-03 Thread Sam Willis
If this was to be an addition to 'include' it would result in it having an optional closing tag, that seems a little confusing and you would need an argument to flag that there are blocks to override (and parse until the 'endinclude'). The advantage over Jonathans 'decorate' tag is that you can

Re: Proposal: The 'use' template tag, a cross between 'include' and 'extends'.

2014-09-03 Thread Jonathan Slenders
From 2011: https://github.com/vikingco/django-template-tags/blob/master/src/django_template_tags/templatetags/decorate.py My proposal was refused back then, but I'll be very happy if something similar would make it. :) Le mercredi 3 septembre 2014 18:42:44 UTC+2, Jonathan Slenders a écrit :

Re: Proposal: The 'use' template tag, a cross between 'include' and 'extends'.

2014-09-03 Thread Jonathan Slenders
It's not similar. This implements the "decorator" pattern. Something that I've been proposing years ago. Le mercredi 3 septembre 2014 18:24:17 UTC+2, Ian a écrit : > > On Wed, Sep 3, 2014 at 10:10 AM, Sam Willis > wrote: > > Although I have implemented this with the 'use' word, there may be a

Re: Proposal: The 'use' template tag, a cross between 'include' and 'extends'.

2014-09-03 Thread Ian Kelly
On Wed, Sep 3, 2014 at 10:10 AM, Sam Willis wrote: > Although I have implemented this with the 'use' word, there may be a better > word. I considered 'embed' but thought 'use' was a little cleaner Since it's so similar to 'include', is there a reason not to just add the new functionality to the e

Proposal: The 'use' template tag, a cross between 'include' and 'extends'.

2014-09-03 Thread Sam Willis
Hi All, I would like to propose a new template tag to be included in Django, it is sort of a cross between 'include' and 'extends'. You can find an implementation here: https://gist.github.com/samwillis/af3992f69c2597a16252 The main use case for this tag is being able to create reusable 'compo

Re: [ANNOUNCE] Django 1.7 released

2014-09-03 Thread Thomas Leo
Keep up the great work! On Tuesday, September 2, 2014 6:13:21 PM UTC-4, James Bennett wrote: > > Django 1.7 is now available: > > https://www.djangoproject.com/weblog/2014/sep/02/release-17-final/ > > Alongside this are bugfix releases for 1.4, 1.5 and 1.6. The bugfix 1.5 > release is the final r

[ANNOUNCE] Django 1.7 released

2014-09-03 Thread Yo-Yo Ma
Epic, thanks so much! -- You received this message because you are subscribed to the Google Groups "Django developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to django-developers+unsubscr...@googlegroups.com. To post to this group, send email to d

Re: Please don't kill the ecosystem

2014-09-03 Thread Anssi Kääriäinen
On Wed, 2014-09-03 at 14:46 +0200, Aymeric Augustin wrote: > 1.5 and 1.6 must have been easier than 1.4. 1.7 may be more difficult > because > of migrations and app-loading. If anyone has improvements to suggest > for the > documentation, please do! We could perhaps have better documentation of

Re: Please don't kill the ecosystem

2014-09-03 Thread Aymeric Augustin
2014-09-03 10:40 GMT+02:00 Tom Evans : > > I think it was more distraction by topics he had not come across. We > set him off by saying "look at the release notes, go thru each change > in turn, see if we are affected and what we need to fix it". > Thanks Tom for the details. I understand better.

Re: Please don't kill the ecosystem

2014-09-03 Thread Tom Evans
On Tue, Sep 2, 2014 at 2:53 PM, Aymeric Augustin wrote: > 2014-09-02 15:33 GMT+02:00 Tom Evans : > >> this story was scored >> at 8 points, it took a junior developer much longer than 8 points and >> wasn't finished in a single sprint - and 1.3->1.4 was *easy* > > > I don't know how much a point o