Re: ModelAdmin.prepopulated_fields removes stop words

2018-04-25 Thread Kelly
Thank you for your help Collin! On Wednesday, April 25, 2018 at 4:57:17 PM UTC-4, Collin Anderson wrote: > > Hi Kelly, > > I believe it's in urlify.js > https://github.com/django/django/blob/master/django/contrib/admin/static/admin/js/urlify.js#L172-L175 > > Collin >

ModelAdmin.prepopulated_fields removes stop words

2018-04-25 Thread Kelly
ion as specific as possible. Can anyone help pinpoint where the stop words are being filtered out or is just stating that stop words are filtered out sufficient? Cheers, Kelly -- You received this message because you are subscribed to the Google Groups "Django developers (Contribution

Re: A more useful list of common passwords?

2018-04-16 Thread Kelly
Thank you for your quick reply! We will try that. Cheers, Kelly On Friday, April 13, 2018 at 5:33:24 PM UTC-4, James Bennett wrote: > > One approach you might try is on every test run, randomly select some > lines from the list of common passwords and verify they fail the validator

Re: A more useful list of common passwords?

2018-04-13 Thread Kelly
Hello! I am Kelly, a member of the group working on ticket #29274. We really appreciate your help thus far! We have successfully replaced the list of passwords and ran the unit tests with ./runtests.py. When looking at the CommonPasswordValidatorTest(TestCase) class found in https

Re: Django template 'if ... is' feature design

2016-04-14 Thread Stephen Kelly
Sven R. Kunze wrote: > Good evening everybody. That's my first post here, so let's how this > works. :) > > This particular discussion caught my sight as it might introduce something > really "low-level" functionality into the template engine. As far as I understand from https://github.com/dja

Re: Django template 'if ... is' feature design

2016-04-07 Thread Stephen Kelly
Carl Meyer wrote: > No to tests, because we would be adding tests for undefined and > unreliable behavior. Yes, makes sense. Thanks again for the explanation. > It might be worth adding a short documentation note. We largely want to > avoid documenting Python's behavior in the Django docs, but a

Re: Django template 'if ... is' feature design

2016-04-07 Thread Stephen Kelly
Carl Meyer wrote: > The point is that you shouldn't ever expect any consistent behavior when > using `is` with strings (whether in Python code or in Django templates), > because that behavior is not defined by the Python language, it's > implementation dependent. It happens that the CPython implem

Re: Django template 'if ... is' feature design

2016-04-07 Thread Stephen Kelly
Ryan Hiebert wrote: >> * What should work / what should not work? Is the documentation clear? > > I don't know about the docs, but it _does_ work exactly like the Python > version. I suppose you are not responding to what you quoted. Anyway, that makes at least two people telling me that

Re: Django template 'if ... is' feature design

2016-04-07 Thread Stephen Kelly
Stephen Kelly wrote: > * The unit tests added both have the same name ("template"). They should > have different names of the form 'if-tag-isNN' FYI, I made a pull request which fixes this and some other minor issues in the if-tag tests: https://github.com/django

Re: Django template 'if ... is' feature design

2016-04-07 Thread Stephen Kelly
Daniel Chimeno wrote: > I think we should give an emphasis on this because are going to cause > problems to some people. Yes, this is why I suggested in my original mail that the feature needs more design consideration. * What should work / what should not work? Is the documentation clear?

Re: Django template 'if ... is' feature design

2016-04-07 Thread Stephen Kelly
Ryan Hiebert wrote: > The `is` operator in Python checks for identical objects. A string is not > guaranteed to be exactly the same object as another string (in this > example "True" is not the same object (bytes in memory) as the second > "True", so Python rightly sees that they are not the same

Django template 'if ... is' feature design

2016-04-07 Thread Stephen Kelly
Hello, I reviewed https://github.com/django/django/commit/c00ae7f5 while updating the features of Grantlee, and I have the following notes: * The unit tests added both have the same name ("template"). They should have different names of the form 'if-tag-isNN' * The feature does not work th

Re: Proposal: The 'use' template tag, a cross between 'include' and 'extends'.

2014-09-03 Thread Ian Kelly
On Wed, Sep 3, 2014 at 10:10 AM, Sam Willis wrote: > Although I have implemented this with the 'use' word, there may be a better > word. I considered 'embed' but thought 'use' was a little cleaner Since it's so similar to 'include', is there a reason not to just add the new functionality to the e

Re: 1.7 release status (RC2 coming soon)

2014-07-25 Thread Ian Kelly
On Fri, Jul 25, 2014 at 7:12 AM, Ryan Hiebert wrote: > >> On Jul 25, 2014, at 12:22 AM, Ian Kelly wrote: >> >> It seems to me that a new release would be useful to have for the >> reasons given, but it should be called what it is: a beta version, not >> an RC

Re: 1.7 release status (RC2 coming soon)

2014-07-24 Thread Ian Kelly
On Thu, Jul 24, 2014 at 5:49 PM, Ryan Hiebert wrote: > My opinion is worth less than 2c, but I’m inclined to agree with the dissent. > > It seems to me that its easy enough to install the very latest from the > github repository versus from a tarball, so leaving RC versions to actually > be cand

Re: Supporting and using EOL'd software (was Re: Time to drop support for Oracle < 11?)

2014-06-15 Thread Ian Kelly
On Sun, Jun 15, 2014 at 8:59 AM, Michael Manfre wrote: > I don't see how it should be up to Django to continue to support all of > these archaic versions of Oracle. To paraphrase the mantra repeated during > various mssql discussions, "Django doesn't need to include everything in > core, it just n

Re: Time to drop support for Oracle < 11?

2014-06-13 Thread Ian Kelly
On Fri, Jun 13, 2014 at 7:40 PM, Shai Berger wrote: > Hi Tim and all, > > On Saturday 14 June 2014 03:52:57 Tim Graham wrote: >> >> Release - GA Date - Premier Support Ends - Extended Support Ends >> >> 11.1 - Aug 2007 - Aug 2012 - Aug 2015 >> 10.2 - Jul 2005 - Jul 2010 - Jul 2013 >> 10.1 Jan 2004

Re: Support Negative Indexing on QuerySets

2013-07-31 Thread Ian Kelly
On Tue, Jul 30, 2013 at 4:04 PM, Wim Lewis wrote: > > On 30 Jul 2013, at 2:06 PM, Florian Apolloner wrote: >> How do you think such support would look like? For negative indices you'd >> have to know the size of the resultset to be able to do "limit somthing >> offset length-your_negative_index"

Re: History of datetime_cast_sql() in Oracle

2013-05-21 Thread Ian Kelly
On Sun, May 19, 2013 at 7:33 AM, Shai Berger wrote: > Hi, > > In my quest to solve Oracle bugs, I found the function datetime_cast_sql() in > the Oracle backend. It causes a problem these days, because it gets in the way > of querying a date as string (mydate__startswith='2005'). It is a function

Re: URL dispatcher fallthrough?

2013-03-19 Thread Ian Kelly
On Tue, Mar 19, 2013 at 12:26 PM, Felipe Prenholato wrote: > Hi Julian. My 2 cents. > > What you want is: > > urlpatterns = patterns('', > url_fallthrought(r'^(?P[-\w]+)$', > views=[(ProductView.as_view(), >CategorView.as_view(), >OccasionView.as

Re: Test failures under Oracle

2013-03-10 Thread Ian Kelly
On Sun, Mar 10, 2013 at 3:03 PM, Petite Abeille wrote: > Another point perhaps worthwhile mentioning: > > # There's no way for the DatabaseOperations class to know the > # currently active Oracle version, so we do some setups here. > > https://github.com/django/django/blob/master/d

Re: Test failures under Oracle

2013-03-10 Thread Ian Kelly
On Sun, Mar 10, 2013 at 2:15 PM, Petite Abeille wrote: > > On Mar 10, 2013, at 8:28 PM, Aymeric Augustin > wrote: > >> https://github.com/django/django/blob/master/django/db/backends/oracle/base.py#L548-L555 > > Last but not least… I couldn't help notice these suspicious looking operators: > > h

Re: Test failures under Oracle

2013-03-10 Thread Ian Kelly
On Sun, Mar 10, 2013 at 1:44 PM, Petite Abeille wrote: > > On Mar 10, 2013, at 8:28 PM, Aymeric Augustin > wrote: > >> Django does this already: >> https://github.com/django/django/blob/master/django/db/backends/oracle/base.py#L548-L555 > > Perfect. > > In the case of #20015, the issue is the ot

Re: Test failures under Oracle

2013-03-10 Thread Ian Kelly
On Sun, Mar 10, 2013 at 1:52 AM, Aymeric Augustin wrote: > Hi folks, > > At the moment, a few tests are failing under Oracle. I've created tickets for > each of them: > > https://code.djangoproject.com/ticket/20010 > https://code.djangoproject.com/ticket/20011 > https://code.djangoproject.com/tic

Re: Switch to database-level autocommit

2013-03-05 Thread Ian Kelly
On Tue, Mar 5, 2013 at 3:13 PM, Aymeric Augustin wrote: > In the mean time, I discovered that it's impossible to implement > TransactionMiddleware reliably as a middleware, because there's no guarantee > that process_response or process_exception will be called. Perhaps this could be fixed. We c

Re: Switch to database-level autocommit

2013-03-05 Thread Ian Kelly
On Tue, Mar 5, 2013 at 6:38 AM, Shai Berger wrote: > I'm not sure what you mean by "unsafe". > > Version 1: code in the question > > rows = MyModel.objects.all() > for row in rows: > try: > MyModel.objects.get(photo_id=row.photo_id) > except:

Re: first() and last(), earliest() and latest()

2013-02-27 Thread Ian Kelly
On Wed, Feb 27, 2013 at 3:34 PM, Wim Feijen wrote: > Which style do you prefer? > > .filter(last_name__startswith='b').order_by('last_name').first()# clear > and long > .first(last_name__startswith='b').order_by('last_name')# first method > has filter syntax. > .filter(last_name__startswit

Re: ANNOUNCE: Django 1.5 release candidate 2, Django 1.4.4, Django 1.3.6 (security releases)

2013-02-20 Thread Ian Kelly
On Feb 20, 2013 4:41 PM, "Carl Meyer" wrote: > > On 02/20/2013 04:25 PM, Nick Phillips wrote: > >> There was extensive back-and-forth discussion of this in writing the > >> patch. The issue is that in almost all cases the correct value of the > >> setting in local development and under test are di

Re: Request for review / Multiple time zone support for datetime representation

2013-02-13 Thread Ian Kelly
On Tue, Feb 12, 2013 at 3:35 PM, Aymeric Augustin wrote: >> Against the possible issue of non-recognition of UTC, I suggest using >> '0:00' instead of 'UTC'. > > Thanks for looking into this problem! > > I tried '0:00' instead of 'UTC', and '+03:00' instead of > 'Africa/Nairobi' with the same resu

Re: Request for review / Multiple time zone support for datetime representation

2013-02-12 Thread Ian Kelly
On Tue, Feb 12, 2013 at 3:06 PM, Ian Kelly wrote: > On Tue, Feb 12, 2013 at 2:25 PM, Aymeric Augustin > wrote: >>>>> c.execute("""SELECT "DT" FROM "TIMEZONES_EVENT" WHERE EXTRACT(MONTH FROM >>>>> CAST((FROM_TZ(&quo

Re: Request for review / Multiple time zone support for datetime representation

2013-02-12 Thread Ian Kelly
On Tue, Feb 12, 2013 at 2:25 PM, Aymeric Augustin wrote: c.execute("""SELECT "DT" FROM "TIMEZONES_EVENT" WHERE EXTRACT(MONTH FROM CAST((FROM_TZ("DT", 'UTC') AT TIME ZONE (:arg)) AS DATE)) = 1""", ['Africa/Nairobi']).fetchall() > Traceback (most recent call last): > File "", line

Re: Possible ORM bug with SQL syntax & generic relations

2013-01-30 Thread Ian Kelly
On Wed, Jan 30, 2013 at 10:10 PM, Dylan Klomparens wrote: > It's interesting this seems to work with 10g XE. I am not sure if this is > relevant, but I am using the Full Oracle Client with Administrative Tools > (as oppose to the Oracle Instant Client) and cx_Oracle for Python access to > the data

Re: Possible ORM bug with SQL syntax & generic relations

2013-01-30 Thread Ian Kelly
On Wed, Jan 30, 2013 at 4:30 PM, Dylan Klomparens wrote: > Hello, > > I've encountered what may be a Django ORM bug and am writing to see what the > dev community thinks. I have a model that uses generic relations. An error > is returned when I attempt to delete multiple rows of said model in the

Re: URLField definition on creation.py

2012-12-17 Thread Ian Kelly
On Mon, Dec 17, 2012 at 3:40 PM, maxi wrote: > I was seeing that the new URLField [1] is just defined on oracle backend > (into creation.py) > Why not in other backend modules? Actually, I think that line in oracle/creation.py is dead code. The internal type of URLField is CharField, so the Char

Re: Oracle backend bug makes testing on oracle slower?

2012-12-11 Thread Ian Kelly
On Tue, Dec 11, 2012 at 6:31 AM, Shai Berger wrote: > Hi all, > > I've just been hit by a very simple and annoying bug on Oracle, on Django > 1.3.4. Without testing, it seems to no longer be as bad on master, but a shade > of it still remains. > > The bug is this: The DatabaseFeatures for the Orac

Re: Confusion with Unicode

2012-11-24 Thread Ian Kelly
On Sat, Nov 24, 2012 at 6:55 AM, Santiago Basulto wrote: > Hey guys, i'm posting this here because I posted this on django-users > yesterday and didn't get any help. > > I'm kind of confused here... > > If I get data from a request, say: > > request.GET.get("something") or request.POST.get("someth

Re: Django produce sql with table name different then specified in meta db_table

2012-10-31 Thread Ian Kelly
On Wed, Oct 31, 2012 at 2:57 PM, Łukasz Rekucki wrote: > Why all the slashes ? Unless you specify r'' or make them double, they > don't do anything! > Because the OP had them, and for visual clarity, since it can be hard to distinguish whether '" is an a single quote followed by a double quote o

Re: Django produce sql with table name different then specified in meta db_table

2012-10-31 Thread Ian Kelly
On Wed, Oct 31, 2012 at 2:18 PM, Michał Nowotka wrote: > But what is really buggy here is if i explicitly specify that this > table is not managed django should respect db_table and not perform > any truncation. That's all. > It won't truncate the name if you fully enclose it in quotes. Instead

Re: Django produce sql with table name different then specified in meta db_table

2012-10-31 Thread Ian Kelly
On Wed, Oct 31, 2012 at 12:34 PM, Michał Nowotka wrote: > Another thing - this name is not truncated - some junk is appended and not > after 30 characters but earlier and only for some table names regardless of > length. > The truncation actually truncates to 26 characters and then appends the f

Re: Django produce sql with table name different then specified in meta db_table

2012-10-31 Thread Ian Kelly
On Wed, Oct 31, 2012 at 1:23 PM, Shai Berger wrote: > I'm not sure -- perhaps the db_tablespace option is interpreted by the > Oracle > backend as schema, which would allow what Michal is trying to do with a > sane > API. Otherwise, I'd advise Michal to look at Oracle's table aliases, and > mark

Re: Django produce sql with table name different then specified in meta db_table

2012-10-31 Thread Ian Kelly
On Wed, Oct 31, 2012 at 1:23 PM, Shai Berger wrote: > This, almost worthy of being called an sql injection, can't be the right way > to achieve the goal. In fact, the Oracle backend (or even some higher, more > generic level) should have doubled those '"' characters to make them part of > the name

Re: Possible bug in django oracle backend - no way to map from model type to oracle NUMBER type.

2012-10-17 Thread Ian Kelly
On Wed, Oct 17, 2012 at 4:26 AM, Michał Nowotka wrote: > Currently I'm working with some oracle legacy db which I would like to > access using django ORM. > I have a column of type NUMERIC (without precision and scale) and all > possible values are kept there (for example, 65, 2.3, 0.5

Re: Django Oracle backend vs. numbers

2012-09-25 Thread Ian Kelly
On Tue, Sep 25, 2012 at 11:47 AM, Ian Kelly wrote: > Thanks for putting together a pull request. Please note the patch > will also need to update the documentation to state the new cx_Oracle > version requirement (was 4.3.1, now 5.0.1). Also, there should probably be something about th

Re: Django Oracle backend vs. numbers

2012-09-25 Thread Ian Kelly
to chime in, > the pull request is https://github.com/django/django/pull/393. There is, so > far, anecdotal evidence of very significant improvements, from Ian Kelly > (original author of this patch) and myself (on a somewhat different > implementation and older Django versions, but same g

Re: Django Oracle backend vs. numbers

2012-09-04 Thread Ian Kelly
On Tue, Sep 4, 2012 at 3:28 PM, Anssi Kääriäinen wrote: > I did some digging, and the reason for the error is this line in the > patch: > self.cursor.outputtypehandler = self._outputtypehandler > > What is happening is that self has a reference to self.cursor, which > has reference to bound me

Re: Django Oracle backend vs. numbers

2012-09-04 Thread Ian Kelly
Resending to the list: On Sep 4, 2012 11:44 AM, "Ian Kelly" wrote: > > On Mon, Sep 3, 2012 at 6:14 AM, Shai Berger wrote: > > On Wednesday 29 August 2012 22:17:22 Ian Kelly wrote: > >> > >> https://github.com/ikelly/django/commit/086f502a1c2acb9db27531f7

Re: Django Oracle backend vs. numbers

2012-08-29 Thread Ian Kelly
On Wed, Aug 29, 2012 at 10:34 AM, Jacob Kaplan-Moss wrote: > Hey Shai -- > > Generally sounds like a good idea, I don't see why this shouldn't go > in. You might want to wait until someone with more Oracle experience > chimes in, but I'm having a hard time seeing why a number -> str -> > number da

Re: Python 3 str.format()

2012-08-24 Thread Ian Kelly
On Fri, Aug 24, 2012 at 10:30 AM, Daniel Swarbrick wrote: > On 24 August 2012 18:12, Carl Meyer wrote: >> Can you link to where in the current docs it specifies that %-formatting >> is deprecated and/or will be removed? I can't even find, on a cursory >> search, where it says the new .format() st

Re: #18557: get_or_create() causes a race condition with MySQL

2012-08-08 Thread Ian Kelly
On Aug 8, 2012 10:25 AM, "Cal Leeming [Simplicity Media Ltd]" < cal.leem...@simplicitymedialtd.co.uk> wrote: > > I'm not entirely sure that suggesting every query needs to be committed is the right way forward either, given that you only need to commit once before get_or_create() is called to preve

Re: #18557: get_or_create() causes a race condition with MySQL

2012-07-16 Thread Ian Kelly
On Mon, Jul 16, 2012 at 2:18 PM, Cal Leeming [Simplicity Media Ltd] wrote: > Okay - anyone else want to throw their thoughts at this? > > Also - messing with the isolation levels on MySQL is really not a great > idea.. it can cause all sorts of unexpected behavior. Just a thought -- I don't have

Re: Newline stripping in templates: the dnl way

2012-06-28 Thread Stephen Kelly
Leon Matthews wrote: > On 2 March 2012 09:45, Carl Meyer > wrote: >> Same reason any ticket stalls - it seems that nobody felt strongly >> enough about it to put the time into reviewing and thoroughly testing >> the patch and marking it Ready for Checkin. If you'd like to see it in >> (post 1.4 a

Re: admin_changelist failing on Oracle

2012-06-01 Thread Ian Kelly
On Fri, Jun 1, 2012 at 12:29 PM, Vinay Sajip wrote: > > On Jun 1, 6:39 pm, Ian Kelly wrote: >> >> The error is caused by one of the column names in the table.  See the >> second paragraph at: >> >> https://docs.djangoproject.com/en/1.4/ref/databases/#naming-i

Re: admin_changelist failing on Oracle

2012-06-01 Thread Ian Kelly
On Fri, Jun 1, 2012 at 11:29 AM, Vinay Sajip wrote: > I'm getting an error when syncdb tries to execute the following SQL > against Oracle 10g XE: > > CREATE OR REPLACE TRIGGER "ADMIN_CHANGELIST_EVENT_TR" > BEFORE INSERT ON "ADMIN_CHANGELIST_EVENT" > FOR EACH ROW > WHEN (new."ID" IS NULL) >    BEG

Re: Python 3 port - now available on GitHub

2012-05-28 Thread Ian Kelly
On Sat, May 26, 2012 at 4:31 AM, Vinay Sajip wrote: > Anssi, > > Thanks very much for the feedback. > >> Both Oracle and MySQL fail to run because of this error (on both 2.7 >> and 3.2): >>   File "/home/akaariai/Programming/django/tests/django/db/backends/ >> mysql/compiler.py", line 2, in >>  

Re: New Release of IBM_DB_DJANGO (1.0.4)

2012-05-22 Thread Ian Kelly
On Tue, May 22, 2012 at 4:07 PM, Anssi Kääriäinen wrote: > I don't know about licensing... I believe the issue is that we don't > have enough manpower to keep more backends updated in core. Even now > the Oracle backend is somewhat problematic - there aren't that many > contributors (or committers

Re: suggestion: Don't make the tag "url" dirty in Django1.5

2012-03-27 Thread Ian Kelly
On Tue, Mar 27, 2012 at 1:26 PM, gs412 wrote: > Less symbol is the tide, the future. for example: > coffeescript、sass、haml、slim and python, there are all less symbol, this > feature make developer fell well This is incorrect. If Python were all about "fewer symbols", then we would favor tabs ove

Re: incorrect check email with 'email_re' in 'django.core.validators'

2011-12-19 Thread Ian Kelly
On Mon, Dec 19, 2011 at 7:20 PM, Wim Lewis wrote: > > On 19 Dec 2011, at 4:50 PM, Nick Fitzsimons wrote: >> Strictly speaking that regex cannot determine that an email address is >> well-formed per the RFC as the grammar defining the form of email addresses >> is a Type 2 Chomsky Grammar and reg

Re: incorrect check email with 'email_re' in 'django.core.validators'

2011-12-19 Thread Ian Kelly
On Mon, Dec 19, 2011 at 9:36 AM, Maxim Badika wrote: > Hello all! > > i found that > > email_re.search(u'my...@mydomain.com.') # with dot at the end of > address > > returns true. I think that is incorrect. > Thanks. That is actually correct, and it is equivalent to "my...@domain.com". See RFC 36

Re: Python 3 port - notes for people wanting to review changes/port apps

2011-12-17 Thread Ian Kelly
On Dec 17, 2011 10:12 PM, "Yo-Yo Ma" wrote: > > Is this a prank, or is there really going to need to be a u('') for > every u'' (of which there are thousands, since everything is Unicode > in Django) in my Django apps, in order to use P3K? Removing the "u" is > one thing, but adding another text f

Re: Django 1.4 alpha on December 22nd

2011-12-15 Thread Ian Kelly
On Thu, Dec 15, 2011 at 5:00 PM, Kiril Vladimirov wrote: > While I'm reading all topics, listed below I'm thinking... is it too early > to announce *experimental* Python 3.2 support in Django 1.4? Already been discussed: http://groups.google.com/group/django-developers/msg/32c3526c4efe278d?hl=en

Re: Python 3 port - all PostgreSQL tests now pass on 2.7.2 and 3.2.2 with the same codebase

2011-12-10 Thread Ian Kelly
On Sat, Dec 10, 2011 at 1:03 AM, Vinay Sajip wrote: > So - with Ian Clelland's post[1] from a couple of days ago, we have > successful runs on 2.x and 3.x using a single codebase and SQLite, > PostgreSQL and MySQL backends. I suppose Oracle will be the next one > to focus

Re: FileField should be a context manager

2011-12-09 Thread Ian Kelly
On Fri, Dec 9, 2011 at 11:49 AM, Florian Apolloner wrote: > > > On Thursday, December 8, 2011 11:36:53 PM UTC+1, Alex_Gaynor wrote: >> >> It isn't alreayd?!?!  All file objects django exposes should be context >> managers, I thought I added that to a base mixin class a while ago, but >> apparently

Re: Python 3 port - all tests now pass on 2.7.2 and 3.2.2 with the same codebase

2011-12-06 Thread Ian Kelly
On Tue, Dec 6, 2011 at 8:46 PM, Ian Clelland wrote: > >> * compiler.py still had a map(None) call, that I replaced with >> izip_longest. > >> >> The biggest change was just adding izip_longest to utils.py3 and >> utils.itercompat. > > > I had the same issue with MySQL -- I used a block like this:

Re: Python 3 port - all tests now pass on 2.7.2 and 3.2.2 with the same codebase

2011-12-06 Thread Ian Kelly
I've just finished going through the oracle tests and sent you a pull request that fixes a few issues: * compiler.py still had a map(None) call, that I replaced with izip_longest. * cx_Oracle doesn't seem to want to accept bools as bind parameters with Python 3; these had to be converted to ints.

Re: Python 3 port - all tests now pass on 2.7.2 and 3.2.2 with the same codebase

2011-12-02 Thread Ian Kelly
On Fri, Dec 2, 2011 at 11:34 AM, Joe & Anne Tennies wrote: > So, last time I saw, you had only run against sqlite. Do you need help > testing it against postgres, MySQL, and oracle (perhaps some unofficial > ones)? What about all the caching backends? Do we need tests Python 3 > equivalent tests f

Re: Django 1.4 roadmap

2011-11-29 Thread Ian Kelly
On Tue, Nov 29, 2011 at 5:10 AM, Luke Plant wrote: > 2) Broken tests: > > http://ci.djangoproject.com/builds > > It looks like tests are failing on Oracle and spatialite. I guess any > failing tests need to be added to the release blockers. I'll make a note to go through the Oracle failures soon.

Re: Suggested Oracle double-fetch fix (was Re: Can we drop Oracle 9 support?)

2011-11-24 Thread Ian Kelly
On Thu, Nov 24, 2011 at 3:00 PM, Shai Berger wrote: > While we're all at it, I would like to bring to your attention another > suggested fix for Oracle. The patch attached here tells the backend that if a > fetch operation retrieved less than the requested array size, then no further > fetch attem

Re: Can we drop Oracle 9 support?

2011-11-22 Thread Ian Kelly
On Tue, Nov 22, 2011 at 1:54 AM, Anssi Kääriäinen wrote: > I can do a patch for this if needed. Are you (or somebody else) > working on this? I had some specific ideas for how to approach it, but I haven't done any actual work yet. Feel free to claim it. -- You received this message because yo

Re: Can we drop Oracle 9 support?

2011-11-16 Thread Ian Kelly
On Wed, Nov 16, 2011 at 4:55 PM, Shai Berger wrote: > Hi, > > Oracle 10 has been released in 2003 -- the same year as Python 2.3, which is > no longer supported by Django. > > Oracle 9 is essentially end-of-life'd -- Oracle will not provide patches for > it, even for critical bugs, and even if you

Re: queryset caching note in docs

2011-11-02 Thread Ian Kelly
On Wed, Nov 2, 2011 at 5:05 AM, Anssi Kääriäinen wrote: > For PostgreSQL this would be a nice feature. Any idea what MySQL and Oracle > do currently? If I'm following the thread correctly, the oracle backend already does chunked reads. The default chunk size is 100 rows, IIRC. -- You received

Re: Curious (bug?) with db filter __in

2011-10-03 Thread Ian Kelly
Have a look at the DatabaseOperations.max_in_list_size method, but it sounds like it's not going to be a simple constant for MySQL. On Oct 3, 2011 1:01 PM, "Cal Leeming [Simplicity Media Ltd]" < cal.leem...@simplicitymedialtd.co.uk> wrote: > Ahh - max_allowed_packet pops up its ugly head again - it

Re: please reopen ticket 15567

2011-09-13 Thread Ian Kelly
On Tue, Sep 13, 2011 at 11:24 AM, Adam Jenkins wrote: > +1 on making the error say more than incorrect username/password. That > is confusing. In regards to leaking information about the user. The > error message in general could be changed to something like this, of > course with better wording:

Re: Reversing translated urls in templates

2011-07-05 Thread Stephen Kelly
Jannis Leidel wrote: > > On 05.07.2011, at 09:26, Jonathan Slenders wrote: > >> I'm also +1 on {% language lang_code %}... {% endlanguage %} >> >> We are using exactly this template tag for maybe about half a year >> already. Not for i18n urls, but for formatting numbers. The decimal >> separat

Re: Timezone-aware storage of DateTime

2011-06-30 Thread Ian Kelly
On Thu, Jun 30, 2011 at 3:10 PM, Aymeric Augustin wrote: > Strictly speaking, converting a naive datetime + a time zone to a "point in > time" (eg. UTC timestamp) isn't possible, because of DST: one hour doesn't > exist, and another one happens twice. In my opinion, the primary goal of the > Da

Re: Removal of DictCursor from raw query.. why??

2011-06-17 Thread Ian Kelly
On Fri, Jun 17, 2011 at 5:54 AM, Cal Leeming [Simplicity Media Ltd] wrote: > Because I feel this is just something that should work (or be available) out > of the box. There are plenty of other places where Django docs has included > code snippets to give the user a heads up, and I think this is t

Re: Test optimizations (2-5x as fast)

2011-05-17 Thread Ian Kelly
On Mon, May 16, 2011 at 10:12 PM, David Cramer wrote: > Postgres requires resetting the sequences I believe. I just assume > Oracle/MSSQL are probably similar. Actually in the Oracle backend, resetting the sequence for an empty table is currently a no-op for transactional reasons. -- You receiv

Re: math tag

2011-05-03 Thread Ian Kelly
On Tue, May 3, 2011 at 12:57 PM, Johannes Dollinger wrote: > * __mul__: Display a value of 0.42 as 42%. This would be better implemented as a "percentage" filter, IMO. It would be a natural candidate for inclusion in django.contrib.humanize. -- You received this message because you are subscri

Re: DDN: #2594 (Template system whitespace) may cause blocktrans issue

2011-04-20 Thread Stephen Kelly
Jonathan Slenders writes: > > Some concerns, even if I don't know much about the subject. > > Are you sure that it's always appropriate to strip indentation? I didn't say anything about 'always' :) -- You received this message because you are subscribed to the Google Groups "Django develop

DDN: #2594 (Template system whitespace) may cause blocktrans issue

2011-04-17 Thread Stephen Kelly
Hi, I posted this before but I think people had the 1.3 release on the brain, so now that's out (congrats :)), I'm trying again: http://thread.gmane.org/gmane.comp.python.django.devel/30752 ** copied content ** #2594 is now ready for checkin as far as I can tell for the 1.4 milestone (I under

Re: Comments no longer possible on djangobook.com?

2011-04-17 Thread Stephen Kelly
Alex Gaynor wrote: > Hi Steve, > > The DjangoBook is not part of the Django Project itself, so this isn't > really the right place to report a bug with it: > http://djangobook.com/contact/ is the appropriate way to try and get into > contact with the authors. Ok done, thanks. > > Alex > --

Comments no longer possible on djangobook.com?

2011-04-17 Thread Stephen Kelly
Hi, I think someone here runs that site. Are the comments all gone or am I missing something? Thanks, Steve. -- You received this message because you are subscribed to the Google Groups "Django developers" group. To post to this group, send email to django-developers@googlegroups.com. To u

Re: RFC #2705 (Support for SELECT FOR UPDATE)

2011-04-13 Thread Ian Kelly
On Wed, Apr 13, 2011 at 2:08 PM, Dan Fairs wrote: > However, > it's worth mentioning that the Oracle tests seemed to be mostly broken in > the first place, with dozens of errors. Thanks for following up on those. I reviewed the Oracle tests shortly before the 1.3 release and fixed all the real f

Re: Proposal: switch to HTML5 for bundled templates

2011-03-30 Thread Issac Kelly
on't work without modernizr if you put HTML5 tags in it. > Modernizr is just a support detection library. It does not ..um... modernize any browsers Issac Kelly -- You received this message because you are subscribed to the Google Groups "Django developers" group. To pos

Re: secret key from file...

2011-03-22 Thread Ian Kelly
On Tue, Mar 22, 2011 at 5:17 PM, Carl Meyer wrote: > Interesting. I would have assumed that the reason is so that code in > site_settings.py has access to the previously defined values in the main > settings.py, and can actually modify them (i.e. append to > MIDDLEWARE_CLASSES or whatnot). With an

Re: secret key from file...

2011-03-22 Thread Ian Kelly
On Tue, Mar 22, 2011 at 4:49 PM, Matt Robenolt wrote: > Why not just do an import for your custom settings? > > try: >        from site_settings import * > except ImportError: >        pass No particularly compelling reason that I know of, the import machinery is just unnecessary in this case. T

Re: secret key from file...

2011-03-22 Thread Ian Kelly
On Tue, Mar 22, 2011 at 6:44 AM, Kristaps Kūlis wrote: >  I personally would greatly appreciate update in docs to show "best > way" to handle per enviroment settings / sensitive settings, as now > there is many ways :) >  Consider when one has his local development enviroment with locmem > cache a

Re: the new SELECT DISTINCT query in 1.3 rc1, and how to turn it off

2011-03-09 Thread Ian Kelly
2011/3/9 Łukasz Rekucki : > It's probably messy in general case, but maybe we can try emulating > this in this particular case. Using an ordinary DISTINCT in a subquery > seems to solve the issue: > >    base_query = > self.rel.to._default_manager.using(db).complex_filter(self.rel.limit_choices_to)

Re: the new SELECT DISTINCT query in 1.3 rc1, and how to turn it off

2011-03-08 Thread Ian Kelly
2011/3/8 Łukasz Rekucki : > It's also supported by Oracle, AFAIK. It is not, although it can be emulated using an analytic query. I tried adding this to the patch in #6422 some time ago, but I found that the structure of an analytic query was going to be rather complicated to shoe-horn that into

Re: 'ascii' codec can't encode characters in position 0-8: ordinal not in range(128)

2011-02-22 Thread Ian Kelly
2011/2/22 Alexander Bolotnov > I created a simple model: > > class Menu(models.Model): > name = models.CharField(null=False, > blank=False,unique=True,max_length=50) > url = models.CharField(null=False, blank=False, > unique=True,max_length=100) > sortOrder = models.IntegerField(null=

Re: Various small issues

2011-01-31 Thread Stephen Kelly
Klaas van Schelven wrote: > Hi all, > > Maybe I wasn't clear enough last time... I've provided patches for > both these old problems and would appreciate either a brutal Linus > style rant for being such an idiot or would like to see the patches > applied. Silence... not so much. > Hi Klass, Y

DDN: #2594 (Template system whitespace) may cause blocktrans issue

2011-01-23 Thread Stephen Kelly
Hi, #2594 is now ready for checkin as far as I can tell for the 1.4 milestone (I understand 1.3 is closed), with one side-issue. http://code.djangoproject.com/ticket/2594 The side issue is that msgids in the .po file extracted with makemessages will not match the untranslated string that Djang

Re: RFC #2705 (Support for SELECT FOR UPDATE)

2010-12-21 Thread Ian Kelly
On Tue, Dec 21, 2010 at 10:31 AM, Dan Fairs wrote: > I've mainly worked on the tests and docs, not the core content of the patch, > but I'd welcome any comments on the implementation as well - I'd like to see > this get in (be it in a 1.3 or 1.4 timeframe) so if any changes are needed > for tha

Re: Python 3

2010-12-15 Thread Ian Kelly
On Wed, Dec 15, 2010 at 12:45 AM, sirex wrote: > On 15 Gruo, 01:51, Russell Keith-Magee > wrote: >> but we're not planning to actively support Python 3 any time soon. > > Why? Dependencies, for one. Psycopg2 and MySQLdb do not officially support Python 3 yet, so the only backends available out

Re: django.contrib.admin and null=True

2010-12-07 Thread Ian Kelly
On Tue, Dec 7, 2010 at 4:26 PM, schinckel wrote: > I think this is broken behaviour: NULL values are semantically > different to empty strings, and in certain cases (I think it was > IPAddressField, but I will have another look later), it would fail to > write to the database. > > Is there a reaso

Re: Is their much benefit In using a second hidden salt

2010-12-07 Thread Ian Kelly
On Tue, Dec 7, 2010 at 2:27 PM, andy wrote: > However I'm a bit curious about the significance of adding a second > salt to the password before it is hashed and then using the regular > per-user salt. Currently my opinion is that their is added benefit > since it make dictionary attacks more chall

Re: #14770: Set cookies from request: Design decision needed

2010-11-24 Thread Ian Kelly
On Wed, Nov 24, 2010 at 1:11 PM, Jacob Kaplan-Moss wrote: >> In my >> case I was creating a small framework for registering functions that >> would check for and set messages via the messages framework. If I >> called the view and passed the request and response to these >> functions, the messages

DDN: Localize anything with _(this_syntax) ?

2010-11-11 Thread Stephen Kelly
Hi, Currently strings in templates can be translated with {{ _("foo") }} syntax. Localizing values can be done with a filter {{ foo|localize }}. I have a patch to allow localizing localizable values like {{ _(foo) }}, which I think is more convenient. It sort of mixes up the meaning of _() to

Re: Settings for a pure Oracle multi-db Django test suite setup

2010-11-10 Thread Ian Kelly
On Mon, Nov 8, 2010 at 10:02 PM, Ramiro Morales wrote: > Has anybody had success with this setup i.e. one where the 'default and > 'other' > alias pointing to such an Oracle product/install?. Is it possible at all? > > If so, could you please share the relevant Django settings file (not > really,

Re: Receipt for mail to security@ ?

2010-11-10 Thread Stephen Kelly
Jacob Kaplan-Moss wrote: > On Wed, Nov 10, 2010 at 1:39 PM, Stephen Kelly > wrote: >> Can someone confirm that the email I sent yesterday made it through? Last >> time I emailed that list it was marked as spam apparently. > > Yes, we've got it. We'll get b

Receipt for mail to security@ ?

2010-11-10 Thread Stephen Kelly
Hi, Can someone confirm that the email I sent yesterday made it through? Last time I emailed that list it was marked as spam apparently. All the best, Steve. -- You received this message because you are subscribed to the Google Groups "Django developers" group. To post to this group, send em

  1   2   3   >