Re: Make clickable area of object links larger

2008-07-14 Thread Tai Lee
> If I'm not mistaken, in NFA, you can create a custom subclass of > ModelAdmin that always sets list_display_links equal to list_display, > and have all of your models inherit from that.  This is the most > flexible solution because people who don't want it to default to > clickable get their

Re: Make clickable area of object links larger

2008-07-13 Thread [EMAIL PROTECTED]
On Jul 13, 12:56 pm, David Danier <[EMAIL PROTECTED]> wrote: > So making the whole field () clickable should really be enough, the > row itself (everything inside ) does not need to be clickable by > default. If I'm not mistaken, in NFA, you can create a custom subclass of ModelAdmin that always

Re: Make clickable area of object links larger

2008-07-13 Thread David Danier
> There is already a way to control which fields are links to the change > page: http://www.djangoproject.com/documentation/model-api/#list-display-links I know, thats what I meant. To make the whole row clickable you have to put all fields which are in list_display into list_display_links,

Re: Make clickable area of object links larger

2008-07-13 Thread David Danier
> Each row in a change list represents one object, usability suffers by > making only one potentially tiny (an integer primary key) field > clickable. What about supporting custom urls for some fields in the future? (e.g. linking to an foreign object for model.ForeignKey) I would make the whole

Re: Make clickable area of object links larger

2008-07-12 Thread Michael
Ben et al; There is no reason to sit on this, especially while the sprint is going. I just wrote up a 2 line patch [1] that changes the display to block. It is a simple enough change. The next step is getting some review and committer time. This patch isn't critical for the 1.0 launch, so the

Re: Make clickable area of object links larger

2008-07-12 Thread Ben Spaulding
I agree with Malcolm that making the whole row clickable is not a good idea. However, that will effectively be the case for models that do not have the list_display or filter options in their inner Admin class (or the equivalent in newforms-admin) because the one link will be as wide as the whole

Re: Make clickable area of object links larger

2008-07-12 Thread Malcolm Tredinnick
On Sat, 2008-07-12 at 19:51 +0700, Mikhail Gusarov wrote: > Twas brillig at 22:43:11 12.07.2008 UTC+10 when [EMAIL PROTECTED] did gyre > and gimble: > > >> Even better, make the entire row the link (like trac). I don't see > >> why only the value of the first field should be the link. > >

Re: Make clickable area of object links larger

2008-07-12 Thread Mikhail Gusarov
Twas brillig at 22:43:11 12.07.2008 UTC+10 when [EMAIL PROTECTED] did gyre and gimble: >> Even better, make the entire row the link (like trac). I don't see >> why only the value of the first field should be the link. MT> That's a usability disaster. You accidentally click anywhere to MT>

Re: Make clickable area of object links larger

2008-07-12 Thread Malcolm Tredinnick
On Sat, 2008-07-12 at 05:26 -0700, Tai Lee wrote: > Even better, make the entire row the link (like trac). I don't see why > only the value of the first field should be the link. That's a usability disaster. You accidentally click anywhere to give focus to the window and it runs off to some

Re: Make clickable area of object links larger

2008-07-12 Thread Tai Lee
Even better, make the entire row the link (like trac). I don't see why only the value of the first field should be the link. --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "Django developers" group. To post to

Re: Make clickable area of object links larger

2008-07-12 Thread Yuri Baburov
Hi Ben, Yes, it's worth it. Or alternatively you can blog this. On Sat, Jul 12, 2008 at 12:11 AM, Ben Spaulding <[EMAIL PROTECTED]> wrote: > > There are many cases where the clickable text of objects listed on a > change-list page is only a few characters. I propose making the entire > cell

Re: Make clickable area of object links larger

2008-07-11 Thread Rajeev J Sebastian
On Sat, Jul 12, 2008 at 2:43 AM, J Meier <[EMAIL PROTECTED]> wrote: > > For me, yes it is. My users would appreciate it greatly. Even if it > doesn't go into Django, having a patch available on a ticket lets all > us others out here know about it. > > My CSS-fu is weak: How do you make the whole

Re: Make clickable area of object links larger

2008-07-11 Thread J Meier
For me, yes it is. My users would appreciate it greatly. Even if it doesn't go into Django, having a patch available on a ticket lets all us others out here know about it. My CSS-fu is weak: How do you make the whole area clickable with just style rules? -Jim On Jul 11, 11:11 am, Ben Spaulding

Make clickable area of object links larger

2008-07-11 Thread Ben Spaulding
There are many cases where the clickable text of objects listed on a change-list page is only a few characters. I propose making the entire cell containing the link clickable. - http://junkdrawer.benspaulding.com/img/change_list-object_link-proposed.png This is easily achieved with a few minor