Re: PatchHammer 40,000

2011-05-06 Thread Julien Phalip
On May 6, 8:25 am, Luke Plant wrote: > I do think this could be useful though. If someone submits a patch that > *immediately* doesn't apply to trunk, then it will be useful to know > that, and hooking this in to Trac at the point the patch is uploaded > would be useful.

Re: PatchHammer 40,000

2011-05-05 Thread Jeremy Dunck
On Thu, May 5, 2011 at 5:57 PM, Alex Gaynor wrote: ... > > Another option (which I haven't though much about).  Is a button on trac to > spot check a patch with this.  When I start to look at a ticket a 1-click > way to check if the patch is even going to apply is a

Re: PatchHammer 40,000

2011-05-05 Thread Alex Gaynor
On Thu, May 5, 2011 at 6:25 PM, Luke Plant wrote: > On 05/05/11 20:12, Dave McLain wrote: > > I have apologized on #django-dev as well, but I do feel like I ought to > > throw my mea culpa up here as well for posterity. I misread Jacob's "I > > think this is a great idea"

Re: PatchHammer 40,000

2011-05-05 Thread Luke Plant
On 05/05/11 20:12, Dave McLain wrote: > I have apologized on #django-dev as well, but I do feel like I ought to > throw my mea culpa up here as well for posterity. I misread Jacob's "I > think this is a great idea" to mean "Go ahead and set 'Patch needs > Improvement'" on 100 tickets rather than

Re: PatchHammer 40,000

2011-05-05 Thread Dave McLain
I have apologized on #django-dev as well, but I do feel like I ought to throw my mea culpa up here as well for posterity. I misread Jacob's "I think this is a great idea" to mean "Go ahead and set 'Patch needs Improvement'" on 100 tickets rather than what I should have read "Some method of

Re: PatchHammer 40,000

2011-05-05 Thread Jannis Leidel
Hi all, After having gotten almost 100 emails from patchhammer via Trac in under a minute, I'd like to suggest to be a bit less hammer-y and let actual humans review the patches instead of doing the patch apply check. In my experience attached patches usually only need little modification to

Re: PatchHammer 40,000

2011-05-05 Thread Gabriel Hurley
That should be relatively trivial to hook up remotely via the XML-RPC API, similarly to the script Jacob posted here: https://gist.github.com/933116 - Gabriel -- You received this message because you are subscribed to the Google Groups "Django developers" group. To post to this group,

Re: PatchHammer 40,000

2011-05-05 Thread Jacob Kaplan-Moss
On Thu, May 5, 2011 at 6:21 AM, Dave McLain wrote: > I got frustrated with the number of patches that wouldn't merge with trunk, > so like any sane person would at 2 in the morning I started writing a script > that would screen scrape the Ready For Commit report, download the

PatchHammer 40,000

2011-05-05 Thread Dave McLain
I've been trying to move along some tickets that are in the 'Patch Needs Review' category, in the hopes that I might accrue enough karma that somebody would promote #15900 to ready for commit. I got frustrated with the number of patches that wouldn't merge with trunk, so like any sane person