[PATCH 1/2] drm/fb-helper: Explain unload sequence a bit better

2017-02-07 Thread Daniel Vetter
While reviewing Chris' patches to properly cancel our async workers I checked that this happens after the fbdev is already unregistered. That's the case, but I found a small gap in our docs, fill that in. Note that I don't explain what release_fbi does, because that function will disappear in the

Re: [PATCH 2/2] drm: Cancel drm_fb_helper_resume_work on unload

2017-02-07 Thread Daniel Vetter
On Tue, Feb 07, 2017 at 12:49:56PM +, Chris Wilson wrote: > We can not allow the worker to run after its fbdev, or even the module, > has been removed. > > Fixes: cfe63423d9be ("drm/fb-helper: Add > drm_fb_helper_set_suspend_unlocked()") > Signed-off-by: Chris Wilson

Re: [PATCH v3 18/23] drm: shmobile: use vblank hooks in struct drm_crtc_funcs

2017-02-07 Thread Laurent Pinchart
Hi Shawn, Thank you for the patch. On Tuesday 07 Feb 2017 17:16:30 Shawn Guo wrote: > From: Shawn Guo > > The vblank hooks in struct drm_driver are deprecated and only meant for > legacy drivers. For modern drivers with DRIVER_MODESET flag, the hooks > in struct

Re: [PATCH v3 16/23] drm: rcar-du: use vblank hooks in struct drm_crtc_funcs

2017-02-07 Thread Laurent Pinchart
Hi Shawn, Thank you for the patch. On Tuesday 07 Feb 2017 17:16:28 Shawn Guo wrote: > From: Shawn Guo > > The vblank hooks in struct drm_driver are deprecated and only meant for > legacy drivers. For modern drivers with DRIVER_MODESET flag, the hooks > in struct

Re: [PATCH v3 01/23] drm: add vblank hooks to struct drm_crtc_funcs

2017-02-07 Thread Laurent Pinchart
Hi Shawn, Thank you for the patch. On Tuesday 07 Feb 2017 17:16:13 Shawn Guo wrote: > From: Shawn Guo > > The vblank is mostly CRTC specific and implemented as part of CRTC > driver. Let's keep the vblank hooks struct drm_driver for legacy > drivers, and add

Re: [PATCH] drm/i915/debugfs: Add i915_hpd_storm_ctl

2017-02-07 Thread Jani Nikula
On Sat, 04 Feb 2017, Lyude wrote: > This adds a file in i915's debugfs directory that allows userspace to > manually control HPD storm detection. This is mainly for hotplugging > tests, where we might want to test HPD storm functionality or disable > storm detection to speed up

Re: [PATCH v2 4/6] drm: scrambling support in drm layer

2017-02-07 Thread Jani Nikula
On Tue, 07 Feb 2017, Jose Abreu wrote: >> +bool drm_scdc_check_scrambling_status(struct i2c_adapter *adapter) >> +{ >> +u8 status; >> +int ret; >> + >> +ret = drm_scdc_readb(adapter, SCDC_SCRAMBLER_STATUS, ); >> +if (ret < 0) { >> +

[Bug 97879] [amdgpu] Rocket League: long hangs (several seconds) when loading assets (models/textures/shaders?)

2017-02-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97879 --- Comment #63 from Marek Olšák --- OK. Let's wait for more people to report the same findings. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the

Re: [PATCH v3 2/7] drm/tinydrm: Add helper functions

2017-02-07 Thread Daniel Vetter
On Tue, Feb 07, 2017 at 12:44:19PM +0100, Thierry Reding wrote: > On Tue, Feb 07, 2017 at 12:21:28PM +0100, Daniel Vetter wrote: > > On Tue, Feb 07, 2017 at 12:11:28PM +0100, Thierry Reding wrote: > > > On Tue, Feb 07, 2017 at 08:28:16AM +1000, Dave Airlie wrote: > > > > > > > > > > I definitely

[patch] drm/i915/gvt/kvmgt: remove some dead code

2017-02-07 Thread Dan Carpenter
If "caps.buf" is already NULL then it doesn't need to be freed or set to NULL. Signed-off-by: Dan Carpenter diff --git a/drivers/gpu/drm/i915/gvt/kvmgt.c b/drivers/gpu/drm/i915/gvt/kvmgt.c index 3f656e3a6e5a..de2a55178a37 100644 --- a/drivers/gpu/drm/i915/gvt/kvmgt.c

[patch] drm/amdgpu/virt: double free in amdgpu_map_static_csa()

2017-02-07 Thread Dan Carpenter
The amdgpu_vm_bo_rmv() function frees "bo_va" so we shouldn't free it a second time. Fixes: 4e4bbe7343a6 ("drm/amdgpu:add new file for SRIOV") Signed-off-by: Dan Carpenter diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c

[patch] drm/radeon: remove some dead code

2017-02-07 Thread Dan Carpenter
If "rdev->bios" is NULL then we don't need to free it. Signed-off-by: Dan Carpenter diff --git a/drivers/gpu/drm/radeon/radeon_bios.c b/drivers/gpu/drm/radeon/radeon_bios.c index 00cfb5d2875f..04c0ed41374f 100644 --- a/drivers/gpu/drm/radeon/radeon_bios.c +++

Re: [PATCH v2 7/7] drm/rockchip: Call drm_gem_object_release() to destroy GEM base

2017-02-07 Thread Tomasz Figa
Hi Mark, On Tue, Feb 7, 2017 at 9:37 PM, Thierry Reding wrote: > On Tue, Feb 07, 2017 at 04:39:33PM +0800, Mark Yao wrote: >> From: Tomasz Figa >> >> When converting the driver to use shmem-backed GEMs for IOMMU-enabled >> systems, we forgot to add

[PATCH 2/2] drm: Cancel drm_fb_helper_resume_work on unload

2017-02-07 Thread Chris Wilson
We can not allow the worker to run after its fbdev, or even the module, has been removed. Fixes: cfe63423d9be ("drm/fb-helper: Add drm_fb_helper_set_suspend_unlocked()") Signed-off-by: Chris Wilson Cc: Noralf Trønnes Cc: Daniel Vetter

[PATCH 1/2] drm: Cancel drm_fb_helper_dirty_work on unload

2017-02-07 Thread Chris Wilson
We can not allow the worker to run after its fbdev, or even the module, has been removed. Fixes: eaa434defaca ("drm/fb-helper: Add fb_deferred_io support") Signed-off-by: Chris Wilson Cc: Noralf Trønnes Cc: Daniel Vetter Cc:

Re: [PATCH v2 0/7] drm/rockchip: switch to drm_mm for support arm64 iommu

2017-02-07 Thread Thierry Reding
On Tue, Feb 07, 2017 at 04:35:35PM +0800, Mark Yao wrote: > Some iommu patches on the series[0] "iommu/rockchip: Fix bugs and > enable on ARM64" already landed, So drm/rockchip related patches [1] and [2] > ready to landed, this series just rebase them to lastest drm-next. > > And fix some bugs

Re: [PATCH v2 7/7] drm/rockchip: Call drm_gem_object_release() to destroy GEM base

2017-02-07 Thread Thierry Reding
On Tue, Feb 07, 2017 at 04:39:33PM +0800, Mark Yao wrote: > From: Tomasz Figa > > When converting the driver to use shmem-backed GEMs for IOMMU-enabled > systems, we forgot to add calls to drm_gem_object_release(), which gave > us a quite nice memory leak. This patch adds the

Re: [PATCH v2 6/7] drm/rockchip: Respect page offset in IOMMU mmap

2017-02-07 Thread Thierry Reding
On Tue, Feb 07, 2017 at 04:39:09PM +0800, Mark Yao wrote: > From: Ørjan Eide > > When mapping buffers through the PRIME DMA-buf mmap path we might be > given an offset which has to be respected. The DRM GEM mmap path already > takes care of zeroing out the fake mmap offset,

[Bug 97879] [amdgpu] Rocket League: long hangs (several seconds) when loading assets (models/textures/shaders?)

2017-02-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97879 --- Comment #62 from lod --- the patch kind of works for me. The Game loads much faster now, so does the options menu and I can play the game without any lags, but know I only get 30-40fps (60+ before) at Radeon

Re: [PATCH v2 3/7] drm/rockchip: gem: add mutex lock for drm mm

2017-02-07 Thread Thierry Reding
On Tue, Feb 07, 2017 at 04:35:38PM +0800, Mark Yao wrote: > drm_mm_insert_node_generic and drm_mm_remove_node may access same > resource with list ops, it's not threads safe, so protect this context > with mutex lock. > > Fix bug: > [49451.856244] >

Re: [PATCH v3 0/7] drm: Add support for tiny LCD displays

2017-02-07 Thread Thierry Reding
On Tue, Jan 31, 2017 at 05:03:12PM +0100, Noralf Trønnes wrote: > drm: Add support for tiny LCD displays > > This is an attempt at providing a DRM version of drivers/staging/fbtft. > > The tinydrm library provides a very simplified view of DRM in particular > for tiny displays that has onboard

Re: [PATCH v3 01/23] drm: add vblank hooks to struct drm_crtc_funcs

2017-02-07 Thread Thierry Reding
On Tue, Feb 07, 2017 at 11:52:06AM +0100, Daniel Vetter wrote: > On Tue, Feb 07, 2017 at 11:38:08AM +0100, Andrzej Hajda wrote: > > On 07.02.2017 10:16, Shawn Guo wrote: > > > +static u32 __get_vblank_counter(struct drm_device *dev, unsigned int > > > pipe) > > > +{ > > > + if

Re: [PATCH v4] drm/imx: ipuv3-plane: use drm_plane_helper_check_state, clipped coordinates

2017-02-07 Thread Philipp Zabel
On Tue, 2017-02-07 at 13:19 +0200, Ville Syrjälä wrote: > On Tue, Feb 07, 2017 at 09:51:50AM +0100, Philipp Zabel wrote: > > On Fri, 2017-02-03 at 15:20 +0200, Ville Syrjälä wrote: > > > On Fri, Feb 03, 2017 at 10:31:39AM +0100, Philipp Zabel wrote: > > > > Use drm_plane_helper_check_state to clip

Re: [PATCH v3 1/7] drm: Add DRM support for tiny LCD displays

2017-02-07 Thread Thierry Reding
On Tue, Feb 07, 2017 at 07:58:52AM +0100, Daniel Vetter wrote: > On Mon, Feb 06, 2017 at 08:23:36PM +0100, Noralf Trønnes wrote: > > > > Den 06.02.2017 10.17, skrev Thierry Reding: > > > On Tue, Jan 31, 2017 at 05:03:13PM +0100, Noralf Trønnes wrote: > > > > tinydrm provides helpers for very

Re: [PATCH v3 2/7] drm/tinydrm: Add helper functions

2017-02-07 Thread Thierry Reding
On Tue, Feb 07, 2017 at 12:21:28PM +0100, Daniel Vetter wrote: > On Tue, Feb 07, 2017 at 12:11:28PM +0100, Thierry Reding wrote: > > On Tue, Feb 07, 2017 at 08:28:16AM +1000, Dave Airlie wrote: > > > > > > > > I definitely don't want that we don't attempt this. But brought from > > > > years > >

Re: [PATCH v3 2/7] drm/tinydrm: Add helper functions

2017-02-07 Thread Thierry Reding
On Mon, Feb 06, 2017 at 11:11:27PM +0100, Noralf Trønnes wrote: > > Den 06.02.2017 16.53, skrev Daniel Vetter: > > On Mon, Feb 06, 2017 at 12:08:47PM +0100, Thierry Reding wrote: > > > On Mon, Feb 06, 2017 at 11:07:42AM +0100, Daniel Vetter wrote: > > > > On Mon, Feb 6, 2017 at 10:35 AM, Thierry

Re: [PATCH v3 2/7] drm/tinydrm: Add helper functions

2017-02-07 Thread Daniel Vetter
On Tue, Feb 07, 2017 at 12:11:28PM +0100, Thierry Reding wrote: > On Tue, Feb 07, 2017 at 08:28:16AM +1000, Dave Airlie wrote: > > > > > > I definitely don't want that we don't attempt this. But brought from years > > > of experience, I recommend to merge first (with pre-refactoring already > > >

Re: [PATCH v4] drm/imx: ipuv3-plane: use drm_plane_helper_check_state, clipped coordinates

2017-02-07 Thread Ville Syrjälä
On Tue, Feb 07, 2017 at 09:51:50AM +0100, Philipp Zabel wrote: > On Fri, 2017-02-03 at 15:20 +0200, Ville Syrjälä wrote: > > On Fri, Feb 03, 2017 at 10:31:39AM +0100, Philipp Zabel wrote: > > > Use drm_plane_helper_check_state to clip raw user coordinates to crtc > > > bounds. This checks for full

Re: [PATCH v3 2/7] drm/tinydrm: Add helper functions

2017-02-07 Thread Thierry Reding
On Tue, Feb 07, 2017 at 08:28:16AM +1000, Dave Airlie wrote: > > > > I definitely don't want that we don't attempt this. But brought from years > > of experience, I recommend to merge first (with pre-refactoring already > > applied, but helpers only extracted, not yet at the right spot), and then

Re: [PATCH v3 01/23] drm: add vblank hooks to struct drm_crtc_funcs

2017-02-07 Thread Thierry Reding
On Tue, Feb 07, 2017 at 05:16:13PM +0800, Shawn Guo wrote: > From: Shawn Guo > > The vblank is mostly CRTC specific and implemented as part of CRTC > driver. Let's keep the vblank hooks struct drm_driver for legacy > drivers, and add corresponding hooks in struct

Re: [PATCH v3 20/23] drm: tegra: use vblank hooks in struct drm_crtc_funcs

2017-02-07 Thread Thierry Reding
On Tue, Feb 07, 2017 at 05:16:32PM +0800, Shawn Guo wrote: > From: Shawn Guo > > The vblank hooks in struct drm_driver are deprecated and only meant for > legacy drivers. For modern drivers with DRIVER_MODESET flag, the hooks > in struct drm_crtc_funcs should be used

Re: [PATCH v3 02/23] drm: remove drm_vblank_no_hw_counter assignment from driver code

2017-02-07 Thread Thierry Reding
On Tue, Feb 07, 2017 at 10:44:49AM +, Russell King - ARM Linux wrote: > On Tue, Feb 07, 2017 at 12:42:15PM +0200, Laurent Pinchart wrote: > > On an unrelated note, for security reasons we should try to make the driver > > structure static, or at least move ops to a static structure. > > ITYM

Re: [PATCH] drm/radeon: avoid kernel segfault in vce when gpu fails to resume

2017-02-07 Thread Christian König
Am 06.02.2017 um 21:13 schrieb j.gli...@gmail.com: From: Jérôme Glisse When GPU fails to resume we can not trust that value we write to GPU memory will post and we might get garbage (more like 0x on x86) when reading them back. This trigger out of range memory

Re: [PATCH v3 02/23] drm: remove drm_vblank_no_hw_counter assignment from driver code

2017-02-07 Thread Laurent Pinchart
Hi Russell, On Tuesday 07 Feb 2017 10:44:49 Russell King - ARM Linux wrote: > On Tue, Feb 07, 2017 at 12:42:15PM +0200, Laurent Pinchart wrote: > > On an unrelated note, for security reasons we should try to make the > > driver > > structure static, or at least move ops to a static structure. >

Re: [PATCH v3 03/23] drm: unexport function drm_vblank_no_hw_counter()

2017-02-07 Thread Laurent Pinchart
Hi Shawn, Thank you for the patch. On Tuesday 07 Feb 2017 17:16:15 Shawn Guo wrote: > From: Shawn Guo > > The function drm_vblank_no_hw_counter() is now only used in core vblank > wrapper code. Let's unexport it by making it a static function. > > Signed-off-by: Shawn

Re: [PATCH v3 01/23] drm: add vblank hooks to struct drm_crtc_funcs

2017-02-07 Thread Daniel Vetter
On Tue, Feb 07, 2017 at 11:38:08AM +0100, Andrzej Hajda wrote: > On 07.02.2017 10:16, Shawn Guo wrote: > > +static u32 __get_vblank_counter(struct drm_device *dev, unsigned int pipe) > > +{ > > + if (drm_core_check_feature(dev, DRIVER_MODESET)) { > > + struct drm_crtc *crtc =

Re: [PATCH v3 08/23] drm: exynos: use vblank hooks in struct drm_crtc_funcs

2017-02-07 Thread Andrzej Hajda
On 07.02.2017 10:16, Shawn Guo wrote: > From: Shawn Guo > > The vblank hooks in struct drm_driver are deprecated and only meant for > legacy drivers. For modern drivers with DRIVER_MODESET flag, the hooks > in struct drm_crtc_funcs should be used instead. > > As the result,

Re: [PATCH v3 02/23] drm: remove drm_vblank_no_hw_counter assignment from driver code

2017-02-07 Thread Laurent Pinchart
Hi Shawn, Thank you for the patch. On Tuesday 07 Feb 2017 17:16:14 Shawn Guo wrote: > From: Shawn Guo > > Core code already makes drm_driver.get_vblank_counter hook optional by > letting drm_vblank_no_hw_counter be the default implementation for the > function hook. So

[Bug 97879] [amdgpu] Rocket League: long hangs (several seconds) when loading assets (models/textures/shaders?)

2017-02-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97879 --- Comment #61 from Marek Olšák --- Created attachment 129379 --> https://bugs.freedesktop.org/attachment.cgi?id=129379=edit patch - possible workaround Does the attached patch help? -- You are receiving this mail

[Bug 97879] [amdgpu] Rocket League: long hangs (several seconds) when loading assets (models/textures/shaders?)

2017-02-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97879 Marek Olšák changed: What|Removed |Added Assignee|mesa-dev@lists.freedesktop.

Re: [PATCH v3 01/23] drm: add vblank hooks to struct drm_crtc_funcs

2017-02-07 Thread Andrzej Hajda
On 07.02.2017 10:16, Shawn Guo wrote: > From: Shawn Guo > > The vblank is mostly CRTC specific and implemented as part of CRTC > driver. Let's keep the vblank hooks struct drm_driver for legacy > drivers, and add corresponding hooks in struct drm_crtc_funcs. These > hooks

[Bug 99136] Blood Effects Total War: Warhammer

2017-02-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99136 --- Comment #20 from Gregor Münch --- (In reply to Samuel Pitoiset from comment #19) > Created attachment 129356 [details] > no blood effects option (v 1.5) Maybe you need the Blood DLC? (just wild guess)

[Bug 98856] [Regression, SI] DIRT: Showdown broken graphics

2017-02-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98856 --- Comment #7 from Gregor Münch --- I finally was able to start bisecting this, I was going back to Mesa from early October but couldnt find the culprit. I used PKGBUILD provided from here:

Re: [PATCH v2 5/6] drm/i915: enable scrambling

2017-02-07 Thread Jani Nikula
On Mon, 06 Feb 2017, Shashank Sharma wrote: > Geminilake platform sports a native HDMI 2.0 controller, and is > capable of driving pixel-clocks upto 594Mhz. HDMI 2.0 spec > mendates scrambling for these higher clocks, for reduced RF footprint. > > This patch checks if

Re: [PATCH v3 12/23] drm: imx: remove struct imx_drm_crtc and imx_drm_crtc_helper_funcs

2017-02-07 Thread Philipp Zabel
Hi Shawn, On Tue, 2017-02-07 at 17:16 +0800, Shawn Guo wrote: > From: Shawn Guo > > With the vblank hooks in struct drm_crtc_funcs, we do not need to > maintain the CRTC specific vblank callbacks with struct > imx_drm_crtc_helper_funcs any more. By moving the stuff that

Re: [PATCH v3 14/23] drm: meson: use vblank hooks in struct drm_crtc_funcs

2017-02-07 Thread Neil Armstrong
On 02/07/2017 10:16 AM, Shawn Guo wrote: > From: Shawn Guo > > The vblank hooks in struct drm_driver are deprecated and only meant for > legacy drivers. For modern drivers with DRIVER_MODESET flag, the hooks > in struct drm_crtc_funcs should be used instead. > >

Re: [PATCH v3 02/23] drm: remove drm_vblank_no_hw_counter assignment from driver code

2017-02-07 Thread Neil Armstrong
On 02/07/2017 10:16 AM, Shawn Guo wrote: > From: Shawn Guo > > Core code already makes drm_driver.get_vblank_counter hook optional by > letting drm_vblank_no_hw_counter be the default implementation for the > function hook. So the drm_vblank_no_hw_counter assignment in the

Re: [PATCH v8 2/3] drm/panel: Add support for S6E3HA2 panel driver on TM2 board

2017-02-07 Thread Andrzej Hajda
On 06.02.2017 11:39, Thierry Reding wrote: > On Fri, Feb 03, 2017 at 09:54:42AM +0100, Andrzej Hajda wrote: >> Hi Thierry, >> >> Finally something technical :) >> >> On 02.02.2017 18:58, Thierry Reding wrote: >>> On Tue, Jan 31, 2017 at 01:05:20PM +0100, Andrzej Hajda wrote: On 31.01.2017

Re: [PATCH v3 07/23] drm: atmel: use vblank hooks in struct drm_crtc_funcs

2017-02-07 Thread Boris Brezillon
On Tue, 7 Feb 2017 17:16:19 +0800 Shawn Guo wrote: > From: Shawn Guo > > The vblank hooks in struct drm_driver are deprecated and only meant for > legacy drivers. For modern drivers with DRIVER_MODESET flag, the hooks > in struct drm_crtc_funcs

Re: [PATCH v3 02/23] drm: remove drm_vblank_no_hw_counter assignment from driver code

2017-02-07 Thread Boris Brezillon
On Tue, 7 Feb 2017 17:16:14 +0800 Shawn Guo wrote: > From: Shawn Guo > > Core code already makes drm_driver.get_vblank_counter hook optional by > letting drm_vblank_no_hw_counter be the default implementation for the > function hook. So the

Re: [PATCH v3 21/23] drm: tilcdc: use vblank hooks in struct drm_crtc_funcs

2017-02-07 Thread Jyri Sarha
On 02/07/17 11:16, Shawn Guo wrote: > From: Shawn Guo > > The vblank hooks in struct drm_driver are deprecated and only meant for > legacy drivers. For modern drivers with DRIVER_MODESET flag, the hooks > in struct drm_crtc_funcs should be used instead. > > While at it,

Re: [PATCH v3 19/23] drm: sun4i: use vblank hooks in struct drm_crtc_funcs

2017-02-07 Thread Maxime Ripard
On Tue, Feb 07, 2017 at 05:16:31PM +0800, Shawn Guo wrote: > From: Shawn Guo > > The vblank hooks in struct drm_driver are deprecated and only meant for > legacy drivers. For modern drivers with DRIVER_MODESET flag, the hooks > in struct drm_crtc_funcs should be used

Re: [PATCH v3 02/23] drm: remove drm_vblank_no_hw_counter assignment from driver code

2017-02-07 Thread Maxime Ripard
On Tue, Feb 07, 2017 at 05:16:14PM +0800, Shawn Guo wrote: > From: Shawn Guo > > Core code already makes drm_driver.get_vblank_counter hook optional by > letting drm_vblank_no_hw_counter be the default implementation for the > function hook. So the drm_vblank_no_hw_counter

[PATCH v3 21/23] drm: tilcdc: use vblank hooks in struct drm_crtc_funcs

2017-02-07 Thread Shawn Guo
From: Shawn Guo The vblank hooks in struct drm_driver are deprecated and only meant for legacy drivers. For modern drivers with DRIVER_MODESET flag, the hooks in struct drm_crtc_funcs should be used instead. While at it, the 'return' of .disable_vblank is dropped to fix

[PATCH v3 22/23] drm: vc4: use vblank hooks in struct drm_crtc_funcs

2017-02-07 Thread Shawn Guo
From: Shawn Guo The vblank hooks in struct drm_driver are deprecated and only meant for legacy drivers. For modern drivers with DRIVER_MODESET flag, the hooks in struct drm_crtc_funcs should be used instead. Signed-off-by: Shawn Guo Cc: Eric Anholt

[PATCH v3 23/23] drm: zte: use vblank hooks in struct drm_crtc_funcs

2017-02-07 Thread Shawn Guo
From: Shawn Guo The vblank hooks in struct drm_driver are deprecated and only meant for legacy drivers. For modern drivers with DRIVER_MODESET flag, the hooks in struct drm_crtc_funcs should be used instead. The functions are moved around to save forward declaration.

[PATCH v3 20/23] drm: tegra: use vblank hooks in struct drm_crtc_funcs

2017-02-07 Thread Shawn Guo
From: Shawn Guo The vblank hooks in struct drm_driver are deprecated and only meant for legacy drivers. For modern drivers with DRIVER_MODESET flag, the hooks in struct drm_crtc_funcs should be used instead. As the result, the wrapper functions tegra_drm_xxx get killed

[PATCH v3 19/23] drm: sun4i: use vblank hooks in struct drm_crtc_funcs

2017-02-07 Thread Shawn Guo
From: Shawn Guo The vblank hooks in struct drm_driver are deprecated and only meant for legacy drivers. For modern drivers with DRIVER_MODESET flag, the hooks in struct drm_crtc_funcs should be used instead. Signed-off-by: Shawn Guo Cc: Maxime

[PATCH v3 18/23] drm: shmobile: use vblank hooks in struct drm_crtc_funcs

2017-02-07 Thread Shawn Guo
From: Shawn Guo The vblank hooks in struct drm_driver are deprecated and only meant for legacy drivers. For modern drivers with DRIVER_MODESET flag, the hooks in struct drm_crtc_funcs should be used instead. As the result, shmob_drm_crtc_enable_vblank() becomes a static

[PATCH v3 16/23] drm: rcar-du: use vblank hooks in struct drm_crtc_funcs

2017-02-07 Thread Shawn Guo
From: Shawn Guo The vblank hooks in struct drm_driver are deprecated and only meant for legacy drivers. For modern drivers with DRIVER_MODESET flag, the hooks in struct drm_crtc_funcs should be used instead. Signed-off-by: Shawn Guo Cc: Laurent

[PATCH v3 17/23] drm: rockchip: remove struct rockchip_crtc_funcs

2017-02-07 Thread Shawn Guo
From: Shawn Guo With the vblank hooks in struct drm_crtc_funcs, we do not need to maintain struct rockchip_crtc_funcs and the related registration functions. Remove them. Signed-off-by: Shawn Guo Cc: Mark Yao ---

[PATCH v3 14/23] drm: meson: use vblank hooks in struct drm_crtc_funcs

2017-02-07 Thread Shawn Guo
From: Shawn Guo The vblank hooks in struct drm_driver are deprecated and only meant for legacy drivers. For modern drivers with DRIVER_MODESET flag, the hooks in struct drm_crtc_funcs should be used instead. Signed-off-by: Shawn Guo Cc: Neil

[PATCH v3 15/23] drm: qxl: use vblank hooks in struct drm_crtc_funcs

2017-02-07 Thread Shawn Guo
From: Shawn Guo The vblank hooks in struct drm_driver are deprecated and only meant for legacy drivers. For modern drivers with DRIVER_MODESET flag, the hooks in struct drm_crtc_funcs should be used instead. Signed-off-by: Shawn Guo Cc: Dave Airlie

[PATCH v3 13/23] drm: mediatek: use vblank hooks in struct drm_crtc_funcs

2017-02-07 Thread Shawn Guo
From: Shawn Guo The vblank hooks in struct drm_driver are deprecated and only meant for legacy drivers. For modern drivers with DRIVER_MODESET flag, the hooks in struct drm_crtc_funcs should be used instead. Signed-off-by: Shawn Guo Cc: CK Hu

[PATCH v3 11/23] drm: kirin: use vblank hooks in struct drm_crtc_funcs

2017-02-07 Thread Shawn Guo
From: Shawn Guo The vblank hooks in struct drm_driver are deprecated and only meant for legacy drivers. For modern drivers with DRIVER_MODESET flag, the hooks in struct drm_crtc_funcs should be used instead. Signed-off-by: Shawn Guo Cc: Xinliang Liu

[PATCH v3 12/23] drm: imx: remove struct imx_drm_crtc and imx_drm_crtc_helper_funcs

2017-02-07 Thread Shawn Guo
From: Shawn Guo With the vblank hooks in struct drm_crtc_funcs, we do not need to maintain the CRTC specific vblank callbacks with struct imx_drm_crtc_helper_funcs any more. By moving the stuff that we currently do in imx_drm_add_crtc(), like of_node setting and

[PATCH v3 10/23] drm: hibmc: use vblank hooks in struct drm_crtc_funcs

2017-02-07 Thread Shawn Guo
From: Shawn Guo The vblank hooks in struct drm_driver are deprecated and only meant for legacy drivers. For modern drivers with DRIVER_MODESET flag, the hooks in struct drm_crtc_funcs should be used instead. Signed-off-by: Shawn Guo Cc: Xinliang Liu

[PATCH v3 06/23] drm: armada: use vblank hooks in struct drm_crtc_funcs

2017-02-07 Thread Shawn Guo
From: Shawn Guo The vblank hooks in struct drm_driver are deprecated and only meant for legacy drivers. For modern drivers with DRIVER_MODESET flag, the hooks in struct drm_crtc_funcs should be used instead. As the result, functions armada_drm_crtc_enable[disable]_irq()

[PATCH v3 08/23] drm: exynos: use vblank hooks in struct drm_crtc_funcs

2017-02-07 Thread Shawn Guo
From: Shawn Guo The vblank hooks in struct drm_driver are deprecated and only meant for legacy drivers. For modern drivers with DRIVER_MODESET flag, the hooks in struct drm_crtc_funcs should be used instead. As the result, exynos_drm_crtc_enable[disable]_vblank() become

[PATCH v3 05/23] drm: malidp: use vblank hooks in struct drm_crtc_funcs

2017-02-07 Thread Shawn Guo
From: Shawn Guo The vblank hooks in struct drm_driver are deprecated and only meant for legacy drivers. For modern drivers with DRIVER_MODESET flag, the hooks in struct drm_crtc_funcs should be used instead. Signed-off-by: Shawn Guo Cc: Mali DP

[PATCH v3 09/23] drm: fsl-dcu: use vblank hooks in struct drm_crtc_funcs

2017-02-07 Thread Shawn Guo
From: Shawn Guo The vblank hooks in struct drm_driver are deprecated and only meant for legacy drivers. For modern drivers with DRIVER_MODESET flag, the hooks in struct drm_crtc_funcs should be used instead. Signed-off-by: Shawn Guo Cc: Stefan Agner

[PATCH v3 07/23] drm: atmel: use vblank hooks in struct drm_crtc_funcs

2017-02-07 Thread Shawn Guo
From: Shawn Guo The vblank hooks in struct drm_driver are deprecated and only meant for legacy drivers. For modern drivers with DRIVER_MODESET flag, the hooks in struct drm_crtc_funcs should be used instead. Signed-off-by: Shawn Guo Cc: Boris

[PATCH v3 04/23] drm: hdlcd: use vblank hooks in struct drm_crtc_funcs

2017-02-07 Thread Shawn Guo
From: Shawn Guo The vblank hooks in struct drm_driver are deprecated and only meant for legacy drivers. For modern drivers with DRIVER_MODESET flag, the hooks in struct drm_crtc_funcs should be used instead. Signed-off-by: Shawn Guo Acked-by: Liviu

[PATCH v3 01/23] drm: add vblank hooks to struct drm_crtc_funcs

2017-02-07 Thread Shawn Guo
From: Shawn Guo The vblank is mostly CRTC specific and implemented as part of CRTC driver. Let's keep the vblank hooks struct drm_driver for legacy drivers, and add corresponding hooks in struct drm_crtc_funcs. These hooks take struct drm_crtc pointer as argument, and

[PATCH v3 02/23] drm: remove drm_vblank_no_hw_counter assignment from driver code

2017-02-07 Thread Shawn Guo
From: Shawn Guo Core code already makes drm_driver.get_vblank_counter hook optional by letting drm_vblank_no_hw_counter be the default implementation for the function hook. So the drm_vblank_no_hw_counter assignment in the driver code becomes redundant and can be removed

[PATCH v3 03/23] drm: unexport function drm_vblank_no_hw_counter()

2017-02-07 Thread Shawn Guo
From: Shawn Guo The function drm_vblank_no_hw_counter() is now only used in core vblank wrapper code. Let's unexport it by making it a static function. Signed-off-by: Shawn Guo --- drivers/gpu/drm/drm_irq.c | 28 ++--

[PATCH v3 00/23] Add vblank hooks to struct drm_crtc_funcs

2017-02-07 Thread Shawn Guo
From: Shawn Guo The vblank is mostly CRTC specific and implemented as part of CRTC driver. The first patch adds 3 vblank core<->driver hooks into struct drm_crtc_funcs, and plug them into core by adding wrapper functions for vblank handling code. We effectively make the

[Bug 99078] Desktop icons oversaturated with red after December 11 2016 update

2017-02-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99078 --- Comment #35 from Matt Turner --- As did Gentoo in 3.9.1-r1. -- You are receiving this mail because: You are the assignee for the bug.___ dri-devel mailing list

Re: [PATCH v4] drm/imx: ipuv3-plane: use drm_plane_helper_check_state, clipped coordinates

2017-02-07 Thread Philipp Zabel
On Fri, 2017-02-03 at 15:20 +0200, Ville Syrjälä wrote: > On Fri, Feb 03, 2017 at 10:31:39AM +0100, Philipp Zabel wrote: > > Use drm_plane_helper_check_state to clip raw user coordinates to crtc > > bounds. This checks for full plane coverage and scaling already, so > > we can drop some custom

[PATCH v2 7/7] drm/rockchip: Call drm_gem_object_release() to destroy GEM base

2017-02-07 Thread Mark Yao
From: Tomasz Figa When converting the driver to use shmem-backed GEMs for IOMMU-enabled systems, we forgot to add calls to drm_gem_object_release(), which gave us a quite nice memory leak. This patch adds the missing calls. Fixes: f11d5f0 ("FROMLIST: drm/rockchip: Do not use

[PATCH v2 6/7] drm/rockchip: Respect page offset in IOMMU mmap

2017-02-07 Thread Mark Yao
From: Ørjan Eide When mapping buffers through the PRIME DMA-buf mmap path we might be given an offset which has to be respected. The DRM GEM mmap path already takes care of zeroing out the fake mmap offset, so we can just make the IOMMU mmap implementation always respect the

[PATCH v2 5/7] drm/rockchip: Fix the call to drm_gem_put_pages()

2017-02-07 Thread Mark Yao
From: Tomasz Figa When freeing the buffer we don't have any means of determining if the buffer was read or written, so we must assume both and pass true for both arguments of drm_gem_put_pages(). Let's fix the code which currently passes false. TEST=while true; do

[PATCH v2 3/7] drm/rockchip: gem: add mutex lock for drm mm

2017-02-07 Thread Mark Yao
drm_mm_insert_node_generic and drm_mm_remove_node may access same resource with list ops, it's not threads safe, so protect this context with mutex lock. Fix bug: [49451.856244] == [49451.856350] BUG: KASAN: wild-memory-access on

[PATCH v2 2/7] drm/rockchip: Use common IOMMU API to attach devices

2017-02-07 Thread Mark Yao
From: Shunqian Zheng Rockchip DRM used the arm special API, arm_iommu_*(), to attach iommu for ARM32 SoCs. This patch convert to common iommu API so it would support ARM64 like RK3399. Since previous patch added support for direct IOMMU address space management, there is

[PATCH v2 1/7] drm/rockchip: Do not use DMA mapping API if attached to IOMMU domain

2017-02-07 Thread Mark Yao
From: Tomasz Figa The API is not suitable for subsystems consisting of multiple devices and requires severe hacks to use it. To mitigate this, this patch implements allocation and address space management locally by using helpers provided by DRM framework, like other DRM

[PATCH v2 4/7] drm/rockchip: gem: fixup iommu_map_sg error path

2017-02-07 Thread Mark Yao
The return value of iommu_map_sg is size_t, it's unsigned, So check ret < 0 is wrong. And if iommu_map_sg is error, it's return value is zero, but rockchip_gem_iommu_map feel the zero return value is success, bug happen: [5.227458] [drm:rockchip_gem_iommu_map] *ERROR* failed to map buffer: 0

[PATCH v2 0/7] drm/rockchip: switch to drm_mm for support arm64 iommu

2017-02-07 Thread Mark Yao
Some iommu patches on the series[0] "iommu/rockchip: Fix bugs and enable on ARM64" already landed, So drm/rockchip related patches [1] and [2] ready to landed, this series just rebase them to lastest drm-next. And fix some bugs for drm/rockchip drm_mm [0]:

Re: [RFC PATCH v2 0/5] Add vblank hooks to struct drm_crtc_funcs

2017-02-07 Thread Shawn Guo
On Tue, Feb 07, 2017 at 08:32:46AM +0100, Daniel Vetter wrote: > On Tue, Jan 24, 2017 at 08:55:35AM +0100, Daniel Vetter wrote: > > On Sun, Jan 22, 2017 at 02:09:01PM +0800, Shawn Guo wrote: > > > From: Shawn Guo > > > > > > The vblank is mostly CRTC specific and

[Bug 99078] Desktop icons oversaturated with red after December 11 2016 update

2017-02-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99078 Andre Heider changed: What|Removed |Added See Also|

Re: [PATCH 1/4] drm/rockchip: Do not use DMA mapping API if attached to IOMMU domain

2017-02-07 Thread Mark yao
On 2017年02月07日 14:53, Tomasz Figa wrote: Hi Mark, Thanks for reviving this series and sorry for not taking care of it myself. Please see some comments inline. Hi Tomasz Thanks for review, I will add the patches you mentioned into v2 version. On Tue, Feb 7, 2017 at 3:09 PM, Mark Yao

<    1   2