Re: [PATCH 1/1] drm/ttm: Set memory as decrypted for ttm framebuffer mappings

2018-08-22 Thread Christian König
Am 22.08.2018 um 22:57 schrieb Jiandi An: On 08/22/2018 02:09 PM, Christian König wrote: Am 22.08.2018 um 20:57 schrieb Jiandi An: Framebuffer memory needs to be accessed decrypted.  Ensure the memory encryption mask is not set for the ttm framebuffer mappings. NAK, the memory not only needs

Re: [PATCH 1/1] drm/ttm: Set memory as decrypted for ttm framebuffer mappings

2018-08-22 Thread kbuild test robot
Hi Jiandi, Thank you for the patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v4.18 next-20180822] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux

Re: [PATCH 1/1] drm/ttm: Set memory as decrypted for ttm framebuffer mappings

2018-08-22 Thread kbuild test robot
Hi Jiandi, Thank you for the patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v4.18 next-20180822] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux

Re: [PATCH v5 4/8] drm/cma-helper: Use the generic fbdev emulation

2018-08-22 Thread John Stultz
On Wed, Aug 22, 2018 at 10:51 PM, Daniel Vetter wrote: > On Thu, Aug 23, 2018 at 6:14 AM, John Stultz wrote: >> On Mon, Aug 20, 2018 at 11:44 PM, John Stultz wrote: >>> Hey Noralf, all, >>> I've been digging for a bit on the regression that this patch has >>> tripped on the HiKey board as repo

Re: Possible use_mm() mis-uses

2018-08-22 Thread Zhenyu Wang
On 2018.08.22 20:20:46 +0200, Paolo Bonzini wrote: > On 22/08/2018 18:44, Linus Torvalds wrote: > > An example of something that *isn't* right, is the i915 kvm interface, > > which does > > > > use_mm(kvm->mm); > > > > on an mm that was initialized in virt/kvm/kvm_main.c using > > > >

Re: [RFC PATCH 0/7] add at91sam9 LCDC DRM driver

2018-08-22 Thread Daniel Vetter
On Wed, Aug 22, 2018 at 10:12 PM, Sam Ravnborg wrote: > Hi Daniel. > >> > > Based on the above, would it be possible to utilise some >> > > of these features without any dedicated userspace (mesa) support? >> > > Any other driver that has something similar that can be used >> > > for inspiration?

Re: [PATCH] drm/i915: Add plane alpha blending support, v2.

2018-08-22 Thread Maarten Lankhorst
Op 23-08-18 om 00:57 schreef Matt Roper: > On Wed, Aug 15, 2018 at 12:34:05PM +0200, Maarten Lankhorst wrote: >> Add plane alpha blending support with the different blend modes. >> This has been tested on a icl to show the correct results, >> on earlier platforms small rounding errors cause issues.

Re: [PATCH v5 4/8] drm/cma-helper: Use the generic fbdev emulation

2018-08-22 Thread Daniel Vetter
On Thu, Aug 23, 2018 at 6:14 AM, John Stultz wrote: > On Mon, Aug 20, 2018 at 11:44 PM, John Stultz wrote: >> Hey Noralf, all, >> I've been digging for a bit on the regression that this patch has >> tripped on the HiKey board as reported here: >> https://lkml.org/lkml/2018/8/16/81 >> >> The fir

RE: [RFC v4 7/8] drm/i915: Implement Plane Gamma for Bdw and Gen9 platforms

2018-08-22 Thread Shankar, Uma
>-Original Message- >From: Alexandru-Cosmin Gheorghe [mailto:Alexandru- >cosmin.gheor...@arm.com] >Sent: Tuesday, August 21, 2018 3:26 PM >To: Shankar, Uma >Cc: intel-...@lists.freedesktop.org; dri-devel@lists.freedesktop.org; >dcasta...@chromium.org; emil.l.veli...@gmail.com; seanp...@c

RE: [RFC v4 1/8] drm: Add Enhanced Gamma LUT precision structure

2018-08-22 Thread Shankar, Uma
>-Original Message- >From: Alexandru-Cosmin Gheorghe [mailto:Alexandru- >cosmin.gheor...@arm.com] >Sent: Tuesday, August 21, 2018 3:00 PM >To: Shankar, Uma >Cc: intel-...@lists.freedesktop.org; dri-devel@lists.freedesktop.org; >dcasta...@chromium.org; emil.l.veli...@gmail.com; seanp...@c

RE: [Intel-gfx] [RFC v4 3/8] drm: Add Plane CTM property

2018-08-22 Thread Shankar, Uma
>-Original Message- >From: Ville Syrjälä [mailto:ville.syrj...@linux.intel.com] >Sent: Wednesday, August 22, 2018 6:36 PM >To: Brian Starkey >Cc: Lankhorst, Maarten ; >dcasta...@chromium.org; intel-...@lists.freedesktop.org; dri- >de...@lists.freedesktop.org; Shankar, Uma ; >seanp...@chr

Re: [PATCH v5 4/8] drm/cma-helper: Use the generic fbdev emulation

2018-08-22 Thread John Stultz
On Mon, Aug 20, 2018 at 11:44 PM, John Stultz wrote: > Hey Noralf, all, > I've been digging for a bit on the regression that this patch has > tripped on the HiKey board as reported here: > https://lkml.org/lkml/2018/8/16/81 > > The first issue was that the kirin driver was setting > mode_config.

Re: [PATCH v6 4/5] drm/amdgpu: use bulk moves for efficient VM LRU handling (v6)

2018-08-22 Thread Zhang, Jerry (Junwei)
On 08/22/2018 06:12 PM, Huang Rui wrote: I continue to work for bulk moving that based on the proposal by Christian. Background: amdgpu driver will move all PD/PT and PerVM BOs into idle list. Then move all of them on the end of LRU list one by one. Thus, that cause so many BOs moved to the end

[Bug 107572] Unrecoverable GPU hang with IP block:gfx_v8_0 is hung

2018-08-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107572 --- Comment #16 from Andrew Cook --- https://github.com/ValveSoftware/Proton/blob/proton_3.7/PREREQS.md#directx-11-games Suggests using llvm 7 to avoid gpu hangs, is someone able to test that? In addition, is it expected for userspace to be ca

[PATCH 1/3] drm/nouveau: Fix potential memory leak in nouveau_drm_load()

2018-08-22 Thread Lyude Paul
We forget to free drm in all instances of failure, and additionally also forget to destroy the master client if the other client fails initialization. Signed-off-by: Lyude Paul Cc: Karol Herbst --- drivers/gpu/drm/nouveau/nouveau_drm.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-)

[PATCH 3/3] drm/nouveau: Shut down GPU on kernel shutdown

2018-08-22 Thread Lyude Paul
A little while ago I sent some patches to try to fix issues with initializing the GM107 GPU with nouveau on the ThinkPad P50. The issues I was witnessing were rather bizarre: seemingly at random, initializing the GPU would fail with failed mthds from disp that nouveau had not actually kicked throug

[PATCH 0/3] drm/nouveau: Fixup module probe to add ->shutdown()

2018-08-22 Thread Lyude Paul
This series is intended to add support for shutting down the GPU on kernel shutdown/reboot using the ->shutdown() hook, similar to what amdgpu does. This is mainly intended to workaround a bios issue on the P50 that was preventing nouveau from initializing the dedicated GM107 GPU on that system pro

[PATCH 2/3] drm/nouveau: Start using new drm_dev initialization helpers

2018-08-22 Thread Lyude Paul
Per the documentation in drm_get_pci_dev(), this function is deprecated and shouldn't be used anymore. As it turns out, we're going to need to stop using drm_get_pci_dev() anyway in order to allow us to turn off the card before full system shutdowns, otherwise we'll hit race conditions with userspa

[PATCH 1/5] drm/nouveau: Check backlight IDs are >= 0, not > 0

2018-08-22 Thread Lyude Paul
Remember, ida IDs start at 0, not 1! Signed-off-by: Lyude Paul Cc: sta...@vger.kernel.org Cc: Jeffery Miller Cc: Karol Herbst --- drivers/gpu/drm/nouveau/nouveau_backlight.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_backlight.c b/d

[PATCH 5/5] drm/nouveau: Refactor nvXX_backlight_init()

2018-08-22 Thread Lyude Paul
There's literally no difference between any of the backlight init functions besides the backlight properties they set and the backlight callbacks that they set, so move all of the duplicated backlight init code out of there and into nouveau_backlight_init(). This gets rid of a lot of copy pasta!

[PATCH 4/5] drm/nouveau: Cleanup indenting in nouveau_backlight.c

2018-08-22 Thread Lyude Paul
Still no functional changes. Signed-off-by: Lyude Paul Cc: Jeffery Miller Cc: Karol Herbst --- drivers/gpu/drm/nouveau/nouveau_backlight.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_backlight.c b/drivers/gpu/drm/nouveau/no

[PATCH 2/5] drm/nouveau: Move backlight device into nouveau_connector

2018-08-22 Thread Lyude Paul
Currently module unloading is broken in nouveau due to a rather annoying race condition resulting from nouveau_backlight.c having gone a bit stale over time: [ 1960.791143] == [ 1960.791394] BUG: KASAN: use-after-free in nouveau_back

[PATCH 0/5] drm/nouveau: Backlight fixes and cleanup

2018-08-22 Thread Lyude Paul
This series fixes some issues with nouveau's backlight support that were causing kernel panics on module reloads, specifically on systems with nouveau handling the backlight of one of the displays. While we're at it, let's cleanup nouveau_backlight.c as well Lyude Paul (5): drm/nouveau: Check b

[PATCH 3/5] drm/nouveau: s/nouveau_backlight_exit/nouveau_backlight_fini/

2018-08-22 Thread Lyude Paul
More consistent with the rest of the codebase, no functional changes here. Signed-off-by: Lyude Paul Cc: Jeffery Miller Cc: Karol Herbst --- drivers/gpu/drm/nouveau/nouveau_backlight.c | 2 +- drivers/gpu/drm/nouveau/nouveau_connector.c | 2 +- drivers/gpu/drm/nouveau/nouveau_connector.h | 4 +

Re: [PATCH] drm/i915: Add plane alpha blending support, v2.

2018-08-22 Thread Matt Roper
On Wed, Aug 15, 2018 at 12:34:05PM +0200, Maarten Lankhorst wrote: > Add plane alpha blending support with the different blend modes. > This has been tested on a icl to show the correct results, > on earlier platforms small rounding errors cause issues. But this > already happens case with fully tr

[Bug 102322] System crashes after "[drm] IP block:gmc_v8_0 is hung!" / [drm] IP block:sdma_v3_0 is hung!

2018-08-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=102322 --- Comment #62 from dwagner --- Created attachment 141243 --> https://bugs.freedesktop.org/attachment.cgi?id=141243&action=edit crash trace with amdgpu.vm_update_mode=3 -- You are receiving this mail because: You are the assignee for the bu

[Bug 102322] System crashes after "[drm] IP block:gmc_v8_0 is hung!" / [drm] IP block:sdma_v3_0 is hung!

2018-08-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=102322 --- Comment #61 from dwagner --- > Please use amdgpu.vm_update_mode=3 to get back to VM_FAULTs issue. The "good" news is that reproduction of the crashes with 3-fps-video-replay is very quick when using amdgpu.vm_update_mode=3. But the bad new

Re: [RFC PATCH radeon-alex] drm/amdgpu: amdgpu_kiq_reg_write_reg_wait() can be static

2018-08-22 Thread Alex Deucher
On Tue, Aug 21, 2018 at 10:38 PM Deng, Emily wrote: > > Reviewed-by: Emily Deng Applied. thanks! Alex > > >-Original Message- > >From: kbuild test robot > >Sent: Wednesday, August 22, 2018 10:31 AM > >To: Deng, Emily > >Cc: kbuild-...@01.org; dri-devel@lists.freedesktop.org; Deucher

Re: [PATCH 1/1] drm/ttm: Set memory as decrypted for ttm framebuffer mappings

2018-08-22 Thread Jiandi An
On 08/22/2018 02:09 PM, Christian König wrote: > Am 22.08.2018 um 20:57 schrieb Jiandi An: >> Framebuffer memory needs to be accessed decrypted.  Ensure the >> memory encryption mask is not set for the ttm framebuffer mappings. > > NAK, the memory not only needs to be decrypted while CPU accesse

[pull] amdgpu drm-next-4.19

2018-08-22 Thread Alex Deucher
Hi Dave, Fixes for 4.19: - Fix build when KCOV is enabled - Misc display fixes - A couple of SR-IOV fixes - Fence fixes for eviction handling for KFD - Misc other fixes The following changes since commit 3d63a3c14741ed015948943076f3c6a2f2cd7b27: Merge tag 'drm-msm-next-2018-08-10' of git://pe

[Bug 107560] radeon (amdgpu) GDM flip queue failed invalid argument, DisplayPort issues

2018-08-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107560 --- Comment #6 from Jorge Blasio --- I've an almost identical issue, however I'm using HDMI and I can get back to the graphical session by switching to VT1 and then back to VT2. The issue happens when exiting games from fullscreen. It started af

[Bug 107560] radeon (amdgpu) GDM flip queue failed invalid argument, DisplayPort issues

2018-08-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107560 --- Comment #5 from Jorge Blasio --- Created attachment 141242 --> https://bugs.freedesktop.org/attachment.cgi?id=141242&action=edit dmesg output -- You are receiving this mail because: You are the assignee for the bug.__

[Bug 105251] [Vega10] GPU lockup on boot: VMC page fault

2018-08-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105251 --- Comment #23 from Andrey Grodzovsky --- (In reply to CheatCodesOfLife from comment #22) > You're welcome. > > Not the exact same problem, no. I can get a hard-lock by trying to use > amdvlk to play rpcs3, but it doesn't produce the same erro

Re: [PATCH v1 1/7] atmel-hlcdc: renamed directory to drm/atmel/

2018-08-22 Thread Daniel Vetter
On Wed, Aug 22, 2018 at 10:09 PM, Sam Ravnborg wrote: > Hi Daniel. > >> > > >> > > I'd strongly suggest you group-maintain the entire atmel stuff in >> > > drm-misc instead of only atmel-hlcdc. >> > >> > If OK with Boris then I am fine with this too. >> > Will suggest so in v2. >> >> Boris acked t

Re: [PATCH v2 4/5] drm: Add support for handling linear tile formats

2018-08-22 Thread Daniel Vetter
On Tue, Aug 21, 2018 at 07:30:03PM +0100, Alexandru Gheorghe wrote: > The previous patch added tile_w and tile_h, which represent the > horizontal and vertical sizes of a tile. > > This one uses that to plumb through drm core in order to be able to > handle linear tile formats without the need for

Re: [RFC PATCH 0/7] add at91sam9 LCDC DRM driver

2018-08-22 Thread Sam Ravnborg
Hi Daniel. > > > Based on the above, would it be possible to utilise some > > > of these features without any dedicated userspace (mesa) support? > > > Any other driver that has something similar that can be used > > > for inspiration? > > > > This is really an interesting question indeed. > > N

Re: [PATCH v1 1/7] atmel-hlcdc: renamed directory to drm/atmel/

2018-08-22 Thread Sam Ravnborg
Hi Daniel. > > > > > > I'd strongly suggest you group-maintain the entire atmel stuff in > > > drm-misc instead of only atmel-hlcdc. > > > > If OK with Boris then I am fine with this too. > > Will suggest so in v2. > > Boris acked too, but he's on vacation. He said on irc he'll review the > pat

Re: Possible use_mm() mis-uses

2018-08-22 Thread Linus Torvalds
On Wed, Aug 22, 2018 at 12:44 PM Felix Kuehling wrote: > > You're right, but that's a bit fragile and convoluted. I'll fix KFD to > handle this more robustly. See the attached (untested) patch. Yes, this patch that makes the whole "has to use current mm" or uses "get_task_mm()" looks good from a

Re: [PATCH v2 4/5] drm: Add support for handling linear tile formats

2018-08-22 Thread Daniel Vetter
On Tue, Aug 21, 2018 at 07:30:03PM +0100, Alexandru Gheorghe wrote: > The previous patch added tile_w and tile_h, which represent the > horizontal and vertical sizes of a tile. > > This one uses that to plumb through drm core in order to be able to > handle linear tile formats without the need for

Re: Possible use_mm() mis-uses

2018-08-22 Thread Oded Gabbay
On Wed, Aug 22, 2018 at 10:58 PM Linus Torvalds wrote: > > On Wed, Aug 22, 2018 at 12:37 PM Oded Gabbay wrote: > > > > Having said that, I think we *are* protected by the mmu_notifier > > release because if the process suddenly dies, we will gracefully clean > > the process's data in our driver a

Re: Possible use_mm() mis-uses

2018-08-22 Thread Linus Torvalds
On Wed, Aug 22, 2018 at 12:37 PM Oded Gabbay wrote: > > Having said that, I think we *are* protected by the mmu_notifier > release because if the process suddenly dies, we will gracefully clean > the process's data in our driver and on the H/W before returning to > the mm core code. And before we

Re: [PATCH v2 2/5] drm/fourcc: Add tile width and height to drm_format_info

2018-08-22 Thread Daniel Vetter
On Tue, Aug 21, 2018 at 07:30:01PM +0100, Alexandru Gheorghe wrote: > Add two new fields(tile_w and tile_h) to drm_format_info, which > represent the horizontal and vertical sizes of a tile in tiled > formats. > This fields will be used by the next patch to add support in drm > core for handling fr

Re: [PATCH v2 4/5] drm: Add support for handling linear tile formats

2018-08-22 Thread Daniel Vetter
On Wed, Aug 22, 2018 at 4:05 PM, Alexandru-Cosmin Gheorghe wrote: > On Wed, Aug 22, 2018 at 04:45:34PM +0300, Ville Syrjälä wrote: >> On Wed, Aug 22, 2018 at 02:36:06PM +0100, Alexandru-Cosmin Gheorghe wrote: >> > On Wed, Aug 22, 2018 at 04:18:54PM +0300, Ville Syrjälä wrote: >> > > On Tue, Aug 21

Re: Possible use_mm() mis-uses

2018-08-22 Thread Felix Kuehling
On 2018-08-22 02:13 PM, Christian König wrote: > Adding Felix because the KFD part of amdgpu is actually his > responsibility. > > If I'm not completely mistaken the release callback of the > mmu_notifier should take care of that for amdgpu. You're right, but that's a bit fragile and convoluted.

[PULL] drm-misc-next-fixes

2018-08-22 Thread Sean Paul
Hi Dave, A couple fixes for you that didn't quite make your -rc1 pull last week. I'm sending this since Gustavo is busy organizing linuxdev-br. drm-misc-next-fixes-2018-08-22: - Add an unprepare delay to the tv123wam panel (Sean) - Update seanpaul's email in MAINTAINERS (Sean) Cc: seanp...@chro

Re: Possible use_mm() mis-uses

2018-08-22 Thread Oded Gabbay
On Wed, Aug 22, 2018 at 7:44 PM Linus Torvalds wrote: > One of the complex ones is the amdgpu driver. It does a > "use_mm(mmptr)" deep deep in the guts of a macro that ends up being > used in fa few places, and it's very hard to tell if it's right. > > It looks almost certainly buggy (there is no

Re: [PATCH v2 2/2] drm/msm/dpu: fix for cursor blend issue

2018-08-22 Thread Sean Paul
On Wed, Aug 22, 2018 at 11:19:57PM +0530, Sravanthi Kollukuduru wrote: > The current driver has the opaque blend mode set as the > default causing the black box effect around the cursor. > The fix enables choosing a different blend mode for alpha > enabled formats. > > Changes in V2: > - Use

Re: [PATCH v2 1/2] drm/msm/dpu: enable cursor plane on dpu

2018-08-22 Thread Sean Paul
On Wed, Aug 22, 2018 at 11:19:56PM +0530, Sravanthi Kollukuduru wrote: > Reserve DMA pipe for cursor plane and attach it to the > crtc during the initialization. > > Changes in V2: > None > > Signed-off-by: Sravanthi Kollukuduru In the future, if someone gives you a Reviewed-by: on a prev

Re: [PATCH 1/1] drm/ttm: Set memory as decrypted for ttm framebuffer mappings

2018-08-22 Thread Christian König
Am 22.08.2018 um 20:57 schrieb Jiandi An: Framebuffer memory needs to be accessed decrypted. Ensure the memory encryption mask is not set for the ttm framebuffer mappings. NAK, the memory not only needs to be decrypted while CPU accessed but all the time. ttm_page_alloc.c and ttm_page_alloc

Re: Possible use_mm() mis-uses

2018-08-22 Thread Zhi Wang
Hi Linus: Thanks for letting us know that. We would fix this ASAP. The kvmgt.c module is a part of GVT-g code. It's our fault that we didn't find this mis-uses, not i915 or KVM guys. Wish they would feel better after seeing this message. Thanks, Zhi. On 08/23/18 00:44, Linus Torvalds wrote:

[PATCH 1/1] drm/ttm: Set memory as decrypted for ttm framebuffer mappings

2018-08-22 Thread Jiandi An
Framebuffer memory needs to be accessed decrypted. Ensure the memory encryption mask is not set for the ttm framebuffer mappings. Signed-off-by: Jiandi An --- drivers/gpu/drm/ttm/ttm_bo_util.c | 12 +++- drivers/gpu/drm/ttm/ttm_bo_vm.c | 6 -- 2 files changed, 15 insertions(+), 3

Re: Possible use_mm() mis-uses

2018-08-22 Thread Linus Torvalds
On Wed, Aug 22, 2018 at 11:33 AM Linus Torvalds wrote: > > On Wed, Aug 22, 2018 at 11:21 AM Paolo Bonzini wrote: > > > > Yes, KVM is correct but the i915 bits are at least fishy. It's probably > > as simple as adding a mmget/mmput pair respectively in kvmgt_guest_init > > and kvmgt_guest_exit, o

Re: [PATCH] drm/syncobj: Drop add/remove_callback from driver interface

2018-08-22 Thread Daniel Vetter
On Wed, Aug 22, 2018 at 11:09:21AM -0500, Jason Ekstrand wrote: > Fine with me. > > Reviewed-by: Jason Ekstrand Thanks for the review, applied to drm-misc-next. -Daniel > > On Wed, Aug 22, 2018 at 4:29 AM Daniel Vetter > wrote: > > > This is used for handling future fences. Currently no driv

Re: Possible use_mm() mis-uses

2018-08-22 Thread Linus Torvalds
On Wed, Aug 22, 2018 at 11:21 AM Paolo Bonzini wrote: > > Yes, KVM is correct but the i915 bits are at least fishy. It's probably > as simple as adding a mmget/mmput pair respectively in kvmgt_guest_init > and kvmgt_guest_exit, or maybe mmget_not_zero. Definitely mmget_not_zero(). If it was just

Re: Possible use_mm() mis-uses

2018-08-22 Thread Paolo Bonzini
On 22/08/2018 18:44, Linus Torvalds wrote: > An example of something that *isn't* right, is the i915 kvm interface, > which does > > use_mm(kvm->mm); > > on an mm that was initialized in virt/kvm/kvm_main.c using > > mmgrab(current->mm); > kvm->mm = current->mm; > > whic

Re: Possible use_mm() mis-uses

2018-08-22 Thread Christian König
Adding Felix because the KFD part of amdgpu is actually his responsibility. If I'm not completely mistaken the release callback of the mmu_notifier should take care of that for amdgpu. Regards, Christian. Am 22.08.2018 um 18:44 schrieb Linus Torvalds: Guys and gals, this is a *very* random

[PATCH v2 1/2] drm/msm/dpu: enable cursor plane on dpu

2018-08-22 Thread Sravanthi Kollukuduru
Reserve DMA pipe for cursor plane and attach it to the crtc during the initialization. Changes in V2: None Signed-off-by: Sravanthi Kollukuduru --- drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 5 ++- drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.h | 4 +- drivers/gpu/drm/msm/disp/d

[PATCH v2 2/2] drm/msm/dpu: fix for cursor blend issue

2018-08-22 Thread Sravanthi Kollukuduru
The current driver has the opaque blend mode set as the default causing the black box effect around the cursor. The fix enables choosing a different blend mode for alpha enabled formats. Changes in V2: - Use drm_get_format_name() in the logs (Sean) Signed-off-by: Sravanthi Kollukuduru --

[PATCH v2 0/2] Enable cursor plane on DPU

2018-08-22 Thread Sravanthi Kollukuduru
s patchset adds the cursor plane support on DPU driver. It also includes the fix for the black box artifacts seen around the cursor when enabled. Changes in V2: - Minor comments in logging in blend config function (Sean) Sravanthi Kollukuduru (2): drm/msm/dpu: enable cursor plane on dpu

[Bug 107516] Firefox for WebGL fallbacks to swrast_dri.so, not using radeon_si.so

2018-08-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107516 Michel Dänzer changed: What|Removed |Added Component|DRM/AMDgpu |libdrm -- You are receiving this mail

[Bug 107516] Firefox for WebGL fallbacks to swrast_dri.so, not using radeon_si.so

2018-08-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107516 --- Comment #7 from Michel Dänzer --- Emil, as it might take a while for users to get the related Firefox sandbox change, would it be possible for libdrm to fall back to the same method that worked before? -- You are receiving this mail becaus

[Bug 107516] Firefox for WebGL fallbacks to swrast_dri.so, not using radeon_si.so

2018-08-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107516 Michel Dänzer changed: What|Removed |Added CC||k...@dev.carbon-project.org --- Comment

[Bug 107660] [regression] Firefox crashes on any WebGL usage with latest libdrm

2018-08-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107660 Michel Dänzer changed: What|Removed |Added Resolution|--- |DUPLICATE Status|NEW

Re: [igt-dev] RFC: Migration to Gitlab

2018-08-22 Thread Rodrigo Vivi
On Wed, Aug 22, 2018 at 05:37:22PM +0100, Daniel Stone wrote: > Hi Rodrigo, > > On Wed, 22 Aug 2018 at 17:06, Rodrigo Vivi wrote: > > On Wed, Aug 22, 2018 at 10:19:19AM -0400, Adam Jackson wrote: > > > On Wed, 2018-08-22 at 16:13 +0300, Jani Nikula wrote: > > > > - Sticking to fdo bugzilla and di

Re: [Intel-gfx] [PATCH V2 4/4] drm/crc: add pre_crc_read function

2018-08-22 Thread Rodrigo Vivi
On Wed, Aug 22, 2018 at 12:37:05PM +0200, Maarten Lankhorst wrote: > Op 21-08-18 om 10:38 schreef Mahesh Kumar: > > This patch implements a callback function which will be called before > > crc read. In this function driver can implement any preparation work > > required for successfully reading CR

Possible use_mm() mis-uses

2018-08-22 Thread Linus Torvalds
Guys and gals, this is a *very* random list of people on the recipients list, but we had a subtle TLB shootdown issue in the VM, and that brought up some issues when people then went through the code more carefully. I think we have a handle on the TLB shootdown bug itself. But when people were di

Re: [igt-dev] RFC: Migration to Gitlab

2018-08-22 Thread Daniel Stone
Hi Rodrigo, On Wed, 22 Aug 2018 at 17:06, Rodrigo Vivi wrote: > On Wed, Aug 22, 2018 at 10:19:19AM -0400, Adam Jackson wrote: > > On Wed, 2018-08-22 at 16:13 +0300, Jani Nikula wrote: > > > - Sticking to fdo bugzilla and disabling gitlab issues for at least > > > drm-intel for the time being. D

[Bug 107660] [regression] Firefox crashes on any WebGL usage with latest libdrm

2018-08-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107660 Bug ID: 107660 Summary: [regression] Firefox crashes on any WebGL usage with latest libdrm Product: DRI Version: XOrg git Hardware: x86-64 (AMD64) OS: Linu

Re: [igt-dev] RFC: Migration to Gitlab

2018-08-22 Thread Daniel Stone
Hi, On Wed, 22 Aug 2018 at 15:44, Daniel Vetter wrote: > On Wed, Aug 22, 2018 at 3:13 PM, Jani Nikula > wrote: > > Just a couple of concerns from drm/i915 perspective for starters: > > > > - Patchwork integration. I think we'll want to keep patchwork for at > > least intel-gfx etc. for the ti

Re: RFC: Migration to Gitlab

2018-08-22 Thread Daniel Stone
Hi, On Wed, 22 Aug 2018 at 16:02, Emil Velikov wrote: > On 22 August 2018 at 12:44, Daniel Vetter wrote: > > I think it's time to brainstorm a bit about the gitlab migration. Basic > > reasons: > > > > - fd.o admins want to deprecate shell accounts and hand-rolled > > infrastructure, because i

Re: [PATCH] drm/syncobj: Drop add/remove_callback from driver interface

2018-08-22 Thread Jason Ekstrand
Fine with me. Reviewed-by: Jason Ekstrand On Wed, Aug 22, 2018 at 4:29 AM Daniel Vetter wrote: > This is used for handling future fences. Currently no driver use > these, and I think given the new timeline fence proposed by KHR it > would be better to have a more abstract interface for future

Re: [PATCH 0/2] drm: convert to SPDX identifiers for Renesas

2018-08-22 Thread Laurent Pinchart
Hi Morimoto-san, On Wednesday, 22 August 2018 04:56:37 EEST Kuninori Morimoto wrote: > Hi Laurent > > These are not yet appear on Linus tree. > I will re-post it. Thank you, but there was no need to, they're stored safely in my tree :-) I'll send a pull request for v4.20. > Kuninori Morimoto (

Re: [igt-dev] RFC: Migration to Gitlab

2018-08-22 Thread Rodrigo Vivi
On Wed, Aug 22, 2018 at 10:19:19AM -0400, Adam Jackson wrote: > On Wed, 2018-08-22 at 16:13 +0300, Jani Nikula wrote: > > > - Sticking to fdo bugzilla and disabling gitlab issues for at least > > drm-intel for the time being. Doing that migration in the same go is a > > bit much I think. Reass

Re: [PATCH] drm/fourcc: Add DOC: overview comment

2018-08-22 Thread Brian Starkey
Hi, On Wed, Aug 22, 2018 at 05:11:55PM +0200, Daniel Vetter wrote: On Wed, Aug 22, 2018 at 4:59 PM, Eric Engestrom wrote: On Tuesday, 2018-08-21 17:44:17 +0100, Brian Starkey wrote: Hi Matthew, On Tue, Aug 21, 2018 at 09:26:39AM -0700, Matthew Wilcox wrote: > On Tue, Aug 21, 2018 at 05:16:11

[PATCH v2] drm/malidp: Fix writeback in NV12

2018-08-22 Thread Alexandru Gheorghe
When we want to writeback to memory in NV12 format we need to program the RGB2YUV coefficients. Currently, we don't program the coefficients and NV12 doesn't work at all. This patchset fixes that by programming a sane default(bt709, limited range) as rgb2yuv coefficients. In the long run, probabl

Re: [PATCH] drm/fourcc: Add DOC: overview comment

2018-08-22 Thread Daniel Vetter
On Wed, Aug 22, 2018 at 4:59 PM, Eric Engestrom wrote: > On Tuesday, 2018-08-21 17:44:17 +0100, Brian Starkey wrote: >> Hi Matthew, >> >> On Tue, Aug 21, 2018 at 09:26:39AM -0700, Matthew Wilcox wrote: >> > On Tue, Aug 21, 2018 at 05:16:11PM +0100, Brian Starkey wrote: >> > > There's a number of t

Re: RFC: Migration to Gitlab

2018-08-22 Thread Emil Velikov
Hi Dan, On 22 August 2018 at 12:44, Daniel Vetter wrote: > Hi all, > > I think it's time to brainstorm a bit about the gitlab migration. Basic > reasons: > > - fd.o admins want to deprecate shell accounts and hand-rolled > infrastructure, because it's a pain to keep secure&updated. > > - gitlab

Re: [PATCH] drm/fourcc: Add DOC: overview comment

2018-08-22 Thread Eric Engestrom
On Tuesday, 2018-08-21 17:44:17 +0100, Brian Starkey wrote: > Hi Matthew, > > On Tue, Aug 21, 2018 at 09:26:39AM -0700, Matthew Wilcox wrote: > > On Tue, Aug 21, 2018 at 05:16:11PM +0100, Brian Starkey wrote: > > > There's a number of things which haven't previously been documented > > > around th

Re: [igt-dev] RFC: Migration to Gitlab

2018-08-22 Thread Daniel Vetter
On Wed, Aug 22, 2018 at 3:13 PM, Jani Nikula wrote: > On Wed, 22 Aug 2018, Daniel Vetter wrote: >> Hi all, >> >> I think it's time to brainstorm a bit about the gitlab migration. Basic >> reasons: >> >> - fd.o admins want to deprecate shell accounts and hand-rolled >> infrastructure, because it'

[Bug 105046] Screen resolution reset to 1368x768 when turning monitor off

2018-08-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105046 --- Comment #16 from Michael Zapf --- Maybe this is another indication that something goes wrong: (screen at 1920x1200) michael@capella:~> xrandr --verbose | grep EDID -A16 EDID: 0000412f271001010101

[Bug 102322] System crashes after "[drm] IP block:gmc_v8_0 is hung!" / [drm] IP block:sdma_v3_0 is hung!

2018-08-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=102322 --- Comment #60 from Andrey Grodzovsky --- (In reply to dwagner from comment #58) > Here comes another trace log, with your info2.patch applied. > > Something must have changed since the last test, as it took pretty long this > time to reproduc

Re: [igt-dev] RFC: Migration to Gitlab

2018-08-22 Thread Adam Jackson
On Wed, 2018-08-22 at 16:13 +0300, Jani Nikula wrote: > - Sticking to fdo bugzilla and disabling gitlab issues for at least > drm-intel for the time being. Doing that migration in the same go is a > bit much I think. Reassignment across bugzilla and gitlab will be an > issue. Can you elabor

Re: [PATCH v2 4/5] drm: Add support for handling linear tile formats

2018-08-22 Thread Alexandru-Cosmin Gheorghe
On Wed, Aug 22, 2018 at 04:45:34PM +0300, Ville Syrjälä wrote: > On Wed, Aug 22, 2018 at 02:36:06PM +0100, Alexandru-Cosmin Gheorghe wrote: > > On Wed, Aug 22, 2018 at 04:18:54PM +0300, Ville Syrjälä wrote: > > > On Tue, Aug 21, 2018 at 07:30:03PM +0100, Alexandru Gheorghe wrote: > > > > The previo

Re: [PROTO][PATCH 05/10] drm/bridge: adv7511: Add max-clock, min-vrefresh options

2018-08-22 Thread Laurent Pinchart
Hi Ulrich, On Wednesday, 22 August 2018 12:13:59 EEST Ulrich Hecht wrote: > On August 21, 2018 at 10:09 AM Laurent Pinchart wrote: > > On Tuesday, 21 August 2018 11:03:45 EEST Ulrich Hecht wrote: > >> On August 20, 2018 at 11:28 AM Laurent Pinchart wrote: > >>> On Tuesday, 14 August 2018 16:49:59

Re: [PATCH v2 4/5] drm: Add support for handling linear tile formats

2018-08-22 Thread Ville Syrjälä
On Wed, Aug 22, 2018 at 02:36:06PM +0100, Alexandru-Cosmin Gheorghe wrote: > On Wed, Aug 22, 2018 at 04:18:54PM +0300, Ville Syrjälä wrote: > > On Tue, Aug 21, 2018 at 07:30:03PM +0100, Alexandru Gheorghe wrote: > > > The previous patch added tile_w and tile_h, which represent the > > > horizontal

[Bug 107175] [CI][SKL][IOMMU] i915: probe of 0000:00:02.0 failed with error -25

2018-08-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107175 Lakshmi changed: What|Removed |Added Status|RESOLVED|CLOSED --- Comment #3 from Lakshmi --- This

Re: [PATCH v2 4/5] drm: Add support for handling linear tile formats

2018-08-22 Thread Alexandru-Cosmin Gheorghe
On Wed, Aug 22, 2018 at 04:18:54PM +0300, Ville Syrjälä wrote: > On Tue, Aug 21, 2018 at 07:30:03PM +0100, Alexandru Gheorghe wrote: > > The previous patch added tile_w and tile_h, which represent the > > horizontal and vertical sizes of a tile. > > > > This one uses that to plumb through drm core

Re: [PATCH v4 1/2] drm: Add per-plane pixel blend mode property

2018-08-22 Thread Maarten Lankhorst
Op 15-08-18 om 08:35 schreef Lowry Li: > Pixel blend modes represent the alpha blending equation > selection, describing how the pixels from the current > plane are composited with the background. > > Adds a pixel_blend_mode to drm_plane_state and a > blend_mode_property to drm_plane, and related s

Re: [PATCH v2 4/5] drm: Add support for handling linear tile formats

2018-08-22 Thread Ville Syrjälä
On Tue, Aug 21, 2018 at 07:30:03PM +0100, Alexandru Gheorghe wrote: > The previous patch added tile_w and tile_h, which represent the > horizontal and vertical sizes of a tile. > > This one uses that to plumb through drm core in order to be able to > handle linear tile formats without the need for

Re: [igt-dev] RFC: Migration to Gitlab

2018-08-22 Thread Jani Nikula
On Wed, 22 Aug 2018, Daniel Vetter wrote: > Hi all, > > I think it's time to brainstorm a bit about the gitlab migration. Basic > reasons: > > - fd.o admins want to deprecate shell accounts and hand-rolled > infrastructure, because it's a pain to keep secure&updated. > > - gitlab will allow us to

Re: [Intel-gfx] [RFC v4 3/8] drm: Add Plane CTM property

2018-08-22 Thread Ville Syrjälä
On Wed, Aug 22, 2018 at 12:11:42PM +0100, Brian Starkey wrote: > Hi, > > On Wed, Aug 22, 2018 at 12:53:58PM +0300, Ville Syrjälä wrote: > >On Wed, Aug 22, 2018 at 08:40:19AM +, Lankhorst, Maarten wrote: > >> fre 2018-08-17 klockan 19:48 +0530 skrev Uma Shankar: > >> > Add a blob property for p

Re: [PATCH v2 4/5] drm: Add support for handling linear tile formats

2018-08-22 Thread Liviu Dudau
On Tue, Aug 21, 2018 at 07:30:03PM +0100, Alexandru Gheorghe wrote: > The previous patch added tile_w and tile_h, which represent the > horizontal and vertical sizes of a tile. > > This one uses that to plumb through drm core in order to be able to > handle linear tile formats without the need for

Re: [Intel-gfx] RFC: Migration to Gitlab

2018-08-22 Thread Sean Paul
On Wed, Aug 22, 2018 at 01:44:56PM +0200, Daniel Vetter wrote: > Hi all, > > I think it's time to brainstorm a bit about the gitlab migration. Basic > reasons: > > - fd.o admins want to deprecate shell accounts and hand-rolled > infrastructure, because it's a pain to keep secure&updated. > > -

Re: [PATCH 4/4] drm/fb: Stop leaking physical address

2018-08-22 Thread Sean Paul
On Wed, Aug 22, 2018 at 10:54:05AM +0200, Daniel Vetter wrote: > For buffer sharing, use dma-buf instead. We can't set smem_start to 0 > unconditionally since that's used by the fbdev mmap default > implementation. And we have plenty of userspace which would like to > keep that working. > > This m

Re: [Intel-gfx] [RFC v4 3/8] drm: Add Plane CTM property

2018-08-22 Thread Lankhorst, Maarten
ons 2018-08-22 klockan 12:11 +0100 skrev Brian Starkey: > Hi, > > On Wed, Aug 22, 2018 at 12:53:58PM +0300, Ville Syrjälä wrote: > > On Wed, Aug 22, 2018 at 08:40:19AM +, Lankhorst, Maarten wrote: > > > fre 2018-08-17 klockan 19:48 +0530 skrev Uma Shankar: > > > > Add a blob property for plane

Re: [PATCH v4 1/2] drm: Add per-plane pixel blend mode property

2018-08-22 Thread Sean Paul
On Wed, Aug 15, 2018 at 02:35:32PM +0800, Lowry Li wrote: > Pixel blend modes represent the alpha blending equation > selection, describing how the pixels from the current > plane are composited with the background. > > Adds a pixel_blend_mode to drm_plane_state and a > blend_mode_property to drm_

Re: [PATCH 2/3] drm: rcar-du: Write ESCR register per channel

2018-08-22 Thread Laurent Pinchart
Hi Jacopo, Thank you for the patch. On Wednesday, 22 August 2018 10:21:48 EEST Jacopo Mondi wrote: > The ESCR registers offset definition is confusing, as each channel is > equipped with an ESCR register instance, but the names suggest only ESCR and > ESCR2 are taken into account. > > Rename the

RFC: Migration to Gitlab

2018-08-22 Thread Daniel Vetter
Hi all, I think it's time to brainstorm a bit about the gitlab migration. Basic reasons: - fd.o admins want to deprecate shell accounts and hand-rolled infrastructure, because it's a pain to keep secure&updated. - gitlab will allow us to add committers on our own, greatly simplifying that proces

Re: [Mesa-dev] [PATCH libdrm] Add basic CONTRIBUTING file

2018-08-22 Thread Eric Engestrom
On Wednesday, 2018-08-22 13:10:42 +0200, Daniel Vetter wrote: > On Wed, Aug 22, 2018 at 1:08 PM, Eric Engestrom > wrote: > > On Wednesday, 2018-08-22 12:51:39 +0200, Daniel Vetter wrote: > >> I picked up a bunch of the pieces from wayland's version: > >> > >> https://gitlab.freedesktop.org/wayland

[Bug 105912] [IGT] gem_exec_reloc@cpu-30 iwlwifi 0000:00:14.3: Scan failed! ret -110 dmesg-warn

2018-08-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105912 Lakshmi changed: What|Removed |Added Status|RESOLVED|CLOSED -- You are receiving this mail becaus

  1   2   >