Re: [PATCH v2] drm/modes: Apply video parameters with only reflect option

Hi Stephan, On Mon, Jan 13, 2020 at 05:30:39PM +0100, Stephan Gerhold wrote: > On Mon, Dec 16, 2019 at 07:08:12PM +0100, Stephan Gerhold wrote: > > On Mon, Dec 16, 2019 at 07:27:25PM +0200, Ville Syrjälä wrote: > > > On Mon, Dec 16, 2019 at 06:10:17PM +0100, Stephan Gerhold wrote: > > > > At the m

Re: [PATCH] drm: Inject a cond_resched() into long drm_clflush_sg()

Quoting Daniel Vetter (2020-01-16 06:52:42) > On Wed, Jan 15, 2020 at 08:52:45PM +, Chris Wilson wrote: > > Since we may try and flush the cachelines associated with large buffers > > (an 8K framebuffer is about 128MiB, even before we try HDR), this leads > > to unacceptably long latencies (whe

Re: [PATCH v2 4/4] drm/simple-kms: Let DRM core send VBLANK events by default

Hi Am 16.01.20 um 07:41 schrieb Daniel Vetter: > On Wed, Jan 15, 2020 at 01:52:26PM +0100, Thomas Zimmermann wrote: >> In drm_atomic_helper_fake_vblank() the DRM core sends out VBLANK events >> if struct drm_crtc_state.no_vblank is enabled in the check() callbacks. >> >> For drivers that have neit

Re: [PATCH] drm: Inject a cond_resched() into long drm_clflush_sg()

On Wed, Jan 15, 2020 at 08:52:45PM +, Chris Wilson wrote: > Since we may try and flush the cachelines associated with large buffers > (an 8K framebuffer is about 128MiB, even before we try HDR), this leads > to unacceptably long latencies (when using a voluntary CONFIG_PREEMPT). > If we call co

Re: [PATCH v2 4/4] drm/simple-kms: Let DRM core send VBLANK events by default

On Wed, Jan 15, 2020 at 01:52:26PM +0100, Thomas Zimmermann wrote: > In drm_atomic_helper_fake_vblank() the DRM core sends out VBLANK events > if struct drm_crtc_state.no_vblank is enabled in the check() callbacks. > > For drivers that have neither an enable_vblank() callback nor a check() > callb

Re: [PATCH v4] drm/trace: Buffer DRM logs in a ringbuffer accessible via debugfs

On Tue, Jan 14, 2020 at 12:21:43PM -0500, Sean Paul wrote: > From: Sean Paul > > This patch uses a ring_buffer to keep a "flight recorder" (name credit Weston) > of DRM logs for a specified set of debug categories. The user writes a > bitmask of debug categories to the "trace_mask" node and can r

linux-next: manual merge of the generic-ioremap tree with the drm-misc tree

Hi all, Today's linux-next merge of the generic-ioremap tree got a conflict in: drivers/video/fbdev/s1d13xxxfb.c between commit: 091be7245a03 ("fbdev: s1d13xxxfb: use resource_size") from the drm-misc tree and commit: 4bdc0d676a64 ("remove ioremap_nocache and devm_ioremap_nocache") fro

Re: [PATCH v3] drm/panfrost: Add the panfrost_gem_mapping concept

On Wed, Jan 15, 2020 at 8:14 PM Rob Herring wrote: > > From: Boris Brezillon > > With the introduction of per-FD address space, the same BO can be mapped > in different address space if the BO is globally visible (GEM_FLINK) > and opened in different context or if the dmabuf is self-imported. The

[PATCH v3] drm/panfrost: Add the panfrost_gem_mapping concept

From: Boris Brezillon With the introduction of per-FD address space, the same BO can be mapped in different address space if the BO is globally visible (GEM_FLINK) and opened in different context or if the dmabuf is self-imported. The current implementation does not take case into account, and at

[PATCH v9 5/5] drm/panel: support for auo, b101uan08.3 wuxga dsi video mode panel

Auo,auo,b101uan08.3's connector is same as boe,tv101wum-nl6. The most codes can be reuse. So auo,b101uan08.3 and boe,tv101wum-nl6 use one driver file. Add the different parts in driver data. Signed-off-by: Jitao Shi Reviewed-by: Sam Ravnborg --- .../gpu/drm/panel/panel-boe-tv101wum-nl6.c| 7

[PATCH v9 3/5] drm/panel: support for auo, kd101n80-45na wuxga dsi video mode panel

Auo,kd101n80-45na's connector is same as boe,tv101wum-nl6. The most codes can be reuse. So auo,kd101n80-45na and boe,tv101wum-nl6 use one driver file. Add the different parts in driver data. Signed-off-by: Jitao Shi --- drivers/gpu/drm/panel/Kconfig | 6 +- .../gpu/drm/panel/pan

[PATCH v9 2/5] drm/panel: support for boe tv101wum-nl6 wuxga dsi video mode panel

Add driver for BOE tv101wum-nl6 panel is a 10.1" 1200x1920 panel. Signed-off-by: Jitao Shi --- drivers/gpu/drm/panel/Kconfig | 9 + drivers/gpu/drm/panel/Makefile| 1 + .../gpu/drm/panel/panel-boe-tv101wum-nl6.c| 693 ++ 3 files changed, 70

[PATCH v9 1/5] dt-bindings: display: panel: Add boe tv101wum-n16 panel bindings

Add documentation for "boe,tv101wum-n16", "auo,kd101n80-45na", "boe,tv101wum-n53" and "auo,b101uan08.3" panels. Signed-off-by: Jitao Shi Reviewed-by: Sam Ravnborg --- .../display/panel/boe,tv101wum-nl6.yaml | 81 +++ 1 file changed, 81 insertions(+) create mode 100644 Do

[PATCH v9 4/5] drm/panel: support for boe, tv101wum-n53 wuxga dsi video mode panel

Boe,tv101wum-n53's connector is same as boe,tv101wum-nl6. The most codes can be reuse. So boe,tv101wum-n53 and boe,tv101wum-nl6 use one driver file. Add the different parts in driver data. Signed-off-by: Jitao Shi Reviewed-by: Sam Ravnborg --- .../gpu/drm/panel/panel-boe-tv101wum-nl6.c| 31

[PATCH v3] drm/panfrost: Add the panfrost_gem_mapping concept

From: Boris Brezillon With the introduction of per-FD address space, the same BO can be mapped in different address space if the BO is globally visible (GEM_FLINK) and opened in different context or if the dmabuf is self-imported. The current implementation does not take case into account, and at

[PATCH v9 0/5] add driver for "boe, tv101wum-nl6", "boe, tv101wum-n53", "auo, kd101n80-45na" and "auo, b101uan08.3" panels

Changes since v8: - merge the panel documents to one. - delay move the drm_panel_of_backlight after drm_panel_init Changes since v7: - base drm-misc-next branch - fix document pass dt_binding_check - remove backlight from panel driver Changes since v6: - fix boe_panel_init err uninit. - ad

RE: [PATCH] drm/dp_mst: Have DP_Tx send one msg at a time

[AMD Public Use] Appreciate for your time. Thanks! > -Original Message- > From: Lyude Paul > Sent: Thursday, January 16, 2020 5:58 AM > To: Lin, Wayne ; dri-devel@lists.freedesktop.org; > amd-...@lists.freedesktop.org > Cc: Kazlauskas, Nicholas ; Wentland, Harry > ; Zuo, Jerry > Subject

[pull] amdgpu drm-fixes-5.5

Hi Dave, Daniel, A couple of small fixes for 5.5. The following changes since commit 023b3b0e139f54a680202790ba801f61aa43a5c8: Merge tag 'drm-intel-fixes-2020-01-09-1' of git://anongit.freedesktop.org/drm/drm-intel into drm-fixes (2020-01-10 11:43:02 +1000) are available in the Git reposito

Re: [PATCH v2 19/21] drm/vkms: Convert to CRTC VBLANK callbacks

Hi, Thanks for the patch, I reviewed and tested it. Everything looks fine for VKMS. Reviewed-by: Rodrigo Siqueira Tested-by: Rodrigo Siqueira On 01/15, Thomas Zimmermann wrote: > VBLANK callbacks in struct drm_driver are deprecated in favor of > their equivalents in struct drm_crtc_funcs. Conv

Re: [PATCH 09/10] drm/vkms: plane_state->fb iff plane_state->crtc

Hi Sam, On 01/15, Sam Ravnborg wrote: > Hi Rodrigo. > > On Tue, Jan 14, 2020 at 06:50:13PM -0500, Rodrigo Siqueira wrote: > > On 12/13, Daniel Vetter wrote: > > > Checking both is one too much, so wrap a WARN_ON around it to stope > > > the copypasta. > > > > > > Signed-off-by: Daniel Vetter >

Re: [PATCH v2 1/5] dt-bindings: display: sitronix, st7735r: Convert to DT schema

Hi Sam, On Wed, Jan 15, 2020 at 10:01 PM Sam Ravnborg wrote: > On Wed, Jan 15, 2020 at 01:45:44PM +0100, Geert Uytterhoeven wrote: > > Convert the DT binding documentation for Sitronix ST7735R displays to DT > > schema. > > > > Add a reference to the Adafruit 1.8" LCD while at it. > > > > Signed-

Re: [PATCH] drm/dp_mst: Have DP_Tx send one msg at a time

Reviewed-by: Lyude Paul I will push this to drm-misc-fixes in just a moment, thanks! On Mon, 2020-01-13 at 17:36 +0800, Wayne Lin wrote: > [Why] > Noticed this while testing MST with the 4 ports MST hub from > StarTech.com. Sometimes can't light up monitors normally and get the > error message a

Re: [PATCH v12 11/22] mm/gup: introduce pin_user_pages*() and FOLL_PIN

On 1/15/20 7:30 AM, Christoph Hellwig wrote: > On Tue, Jan 07, 2020 at 02:45:47PM -0800, John Hubbard wrote: >> Introduce pin_user_pages*() variations of get_user_pages*() calls, >> and also pin_longterm_pages*() variations. >> >> For now, these are placeholder calls, until the various call sites >

Re: [PATCH v8 1/8] dt-bindings: display: panel: Add BOE tv101wum-n16 panel bindings

Hi Jitao. A few comments that I missed in last round. Please consider to combine the three panels in one binding. I realise they are almost identical so no need for three binding files. On Wed, Jan 15, 2020 at 09:59:51PM +0800, Jitao Shi wrote: > Add documentation for boe tv101wum-n16 panel. >

Re: [PATCH v12 04/22] mm: devmap: refactor 1-based refcounting for ZONE_DEVICE pages

On 1/15/20 7:23 AM, Christoph Hellwig wrote: ... > > I'm really not sold on this scheme. Note that I think it is > particularly bad, but it also doesn't seem any better than what > we had before, and it introduced quite a bit more code. > Hi Christoph, All by itself, yes. But the very next pat

Re: [PATCH v8 2/8] drm/panel: support for BOE tv101wum-nl6 wuxga dsi video mode panel

Hi Jitao. > + > +static int boe_panel_add(struct boe_panel *boe) > +{ > + struct device *dev = &boe->dsi->dev; > + int err; > + > + boe->avdd = devm_regulator_get(dev, "avdd"); > + if (IS_ERR(boe->avdd)) > + return PTR_ERR(boe->avdd); > + > + boe->avee = devm_regula

Re: [PATCH v2 2/5] dt-bindings: display: sitronix, st7735r: Add Okaya RH128128T

On Wed, Jan 15, 2020 at 01:45:45PM +0100, Geert Uytterhoeven wrote: > Document support for the Okaya RH128128T display, which is a 128x128 > 1.44" TFT display driven by a Sitronix ST7715R TFT Controller/Driver. > It can be found on e.g. the Renesas YRSK-LCD-PMOD extension board, which > comes with

Re: [PATCH v2 1/5] dt-bindings: display: sitronix,st7735r: Convert to DT schema

Hi Geert. Thanks for doing the conversion to meta-schema. On Wed, Jan 15, 2020 at 01:45:44PM +0100, Geert Uytterhoeven wrote: > Convert the DT binding documentation for Sitronix ST7735R displays to DT > schema. > > Add a reference to the Adafruit 1.8" LCD while at it. > > Signed-off-by: Geert U

[PATCH] drm: Inject a cond_resched() into long drm_clflush_sg()

Since we may try and flush the cachelines associated with large buffers (an 8K framebuffer is about 128MiB, even before we try HDR), this leads to unacceptably long latencies (when using a voluntary CONFIG_PREEMPT). If we call cond_resched() between each sg chunk, that it about every 128 pages, we

Re: [PATCH v4] drm/trace: Buffer DRM logs in a ringbuffer accessible via debugfs

On Wed, Jan 15, 2020 at 05:38:13PM +, Chris Wilson wrote: > Quoting Sean Paul (2020-01-15 14:21:18) > > On Wed, Jan 15, 2020 at 02:01:19PM +, Chris Wilson wrote: > > > Quoting Sean Paul (2020-01-15 13:41:58) > > > > On Wed, Jan 15, 2020 at 10:36:36AM +, Chris Wilson wrote: > > > > > Quo

Re: [PATCH v4] drm/trace: Buffer DRM logs in a ringbuffer accessible via debugfs

Quoting Sean Paul (2020-01-15 14:21:18) > On Wed, Jan 15, 2020 at 02:01:19PM +, Chris Wilson wrote: > > Quoting Sean Paul (2020-01-15 13:41:58) > > > On Wed, Jan 15, 2020 at 10:36:36AM +, Chris Wilson wrote: > > > > Quoting Sean Paul (2020-01-14 17:21:43) > > > > > From: Sean Paul > > > >

Re: [PATCH v6 4/5] drm/tidss: New driver for TI Keystone platform Display SubSystem

Hi Jyri. > Well, I'll bite the bullet then, and start mangling the code to the > "strict" format. While touching the code please consider moving all logging over to the new drm_{err,warn,info,dbg} functions. They give the nice "[drm]" marker. And they are a tad shorter as you do not have to deref

Re: [PATCH 1/2] dmaengine: sun4i: Add support for cyclic requests with dedicated DMA

On Wed, Jan 15, 2020 at 06:01:37PM +0530, Vinod Koul wrote: > On 10-01-20, 16:11, Stefan Mavrodiev wrote: > > Currently the cyclic transfers can be used only with normal DMAs. They > > can be used by pcm_dmaengine module, which is required for implementing > > sound with sun4i-hdmi encoder. This is

Re: [PATCH 02/23] drm/amdgpu: Convert to struct drm_crtc_helper_funcs.get_scanout_position()

On Wed, Jan 15, 2020 at 4:41 AM Thomas Zimmermann wrote: > > Hi > > Am 13.01.20 um 19:52 schrieb Alex Deucher: > > On Fri, Jan 10, 2020 at 4:21 AM Thomas Zimmermann > > wrote: > >> > >> The callback struct drm_driver.get_scanout_position() is deprecated in > >> favor of struct drm_crtc_helper_fu

Re: [PATCH] video: fbdev: nvidia: clean up indentation issues and comment block

On 1/13/20 3:46 PM, Colin King wrote: > From: Colin Ian King > > There is a hunk of code that is incorrectly indented, clean up the > indentation and a comment block. Also remove block braces around a > one line statement on an if condition and add missing spaces after > if keywords. > > Signe

Re: [PATCH] fbdev: remove object duplication in Makefile

On 1/6/20 9:13 AM, Masahiro Yamada wrote: > The objects in $(fb-objs) $(fb-y) $(fb-m) are linked to fb.ko . > > This line adds $(fb-y) to fb-objs, so the objects from $(fb-y) are > listed twice as the dependency of the module. > > It works because Kbuild trims the duplicated objects from linkin

Re: [PATCH v2 15/20] video: exynos: Rename Exynos to lowercase

On 1/4/20 4:21 PM, Krzysztof Kozlowski wrote: > Fix up inconsistent usage of upper and lowercase letters in "Exynos" > name. > > "EXYNOS" is not an abbreviation but a regular trademarked name. > Therefore it should be written with lowercase letters starting with > capital letter. > > The lowerc

Re: [PATCH 07/10] video: fbdev: use resource_size

On 1/1/20 6:49 PM, Julia Lawall wrote: > Use resource_size rather than a verbose computation on > the end and start fields. > > The semantic patch that makes this change is as follows: > (http://coccinelle.lip6.fr/) > > > @@ struct resource ptr; @@ > - (ptr.end - ptr.start + 1) > + resource_si

Re: [PATCH 03/10] fbdev: s1d13xxxfb: use resource_size

On 1/1/20 6:49 PM, Julia Lawall wrote: > Use resource_size rather than a verbose computation on > the end and start fields. > > The semantic patch that makes these changes is as follows: > (http://coccinelle.lip6.fr/) > > > @@ struct resource ptr; @@ > - (ptr.end - ptr.start + 1) > + resource

Re: [PATCH 07/16] video: sa1100fb: constify copied structure

On 1/1/20 8:43 AM, Julia Lawall wrote: > The monspecs structure is only copied into another structure, > so make it const. > > The opportunity for this change was found using Coccinelle. > > Signed-off-by: Julia Lawall Patch queued for v5.6, thanks. Best regards, -- Bartlomiej Zolnierkiewic

Re: [PATCH] fbmem: Adjust indentation in fb_prepare_logo and fb_blank

On 12/20/19 7:09 PM, Nick Desaulniers wrote: > On Tue, Dec 17, 2019 at 7:00 PM Nathan Chancellor > wrote: >> >> Clang warns: >> >> ../drivers/video/fbdev/core/fbmem.c:665:3: warning: misleading >> indentation; statement is not part of the previous 'else' >> [-Wmisleading-indentation] >>

Re: [PATCH] fbcon: Adjust indentation in set_con2fb_map

On 12/20/19 7:07 PM, Nick Desaulniers wrote: > On Tue, Dec 17, 2019 at 6:53 PM Nathan Chancellor > wrote: >> >> Clang warns: >> >> ../drivers/video/fbdev/core/fbcon.c:915:3: warning: misleading >> indentation; statement is not part of the previous 'if' >> [-Wmisleading-indentation] >> re

Re: [PATCH] pxa168fb: fix release function mismatch in probe failure

On 12/5/19 5:06 PM, Chuhong Yuan wrote: > The driver uses kfree() to release the resource allocated by > framebuffer_alloc(), which does not match. > Use framebuffer_release() instead to fix it. For pxa168fb driver framebuffer_release() does only kfree() so there is no real breakage currently. L

Re: [PATCH] OMAP: DSS2: remove non-zero check on variable r

On 12/4/19 4:28 PM, Colin King wrote: > From: Colin Ian King > > Variable r is being initialized to zero, so the check of a non-zero > rv is redundant and can be removed. > > It appears that the previous case statements set r to be -EINVAL > and the "Fallthrough" comment afterwards suggested i

Re: [PATCH v3] video: Fix Kconfig indentation

On 11/21/19 5:09 AM, Krzysztof Kozlowski wrote: > Adjust indentation from spaces to tab (+optional two spaces) as in > coding style with command like: > $ sed -e 's/^/\t/' -i */Kconfig > > Signed-off-by: Krzysztof Kozlowski > Acked-by: Bartlomiej Zolnierkiewicz Patch queued for

Re: [PATCH] video: ssd1307fb: add the missed regulator_disable

On 12/6/19 3:09 PM, Michal Vokáč wrote: > On 18. 11. 19 12:41, Chuhong Yuan wrote: >> The driver forgets to disable the regulator in remove like what is done >> in probe failure. >> Add the missed call to fix it. >> >> Signed-off-by: Chuhong Yuan >> --- >>   drivers/video/fbdev/ssd1307fb.c | 2 ++

Re: [PATCH] fbdev: s1d13xxxfb: add missed unregister_framebuffer in remove

On 11/18/19 9:09 AM, Chuhong Yuan wrote: > The driver calls register_framebuffer in probe but does not call > unregister_framebuffer in remove. > Add the missed call to fix it. > > Signed-off-by: Chuhong Yuan > --- > drivers/video/fbdev/s1d13xxxfb.c | 1 + > 1 file changed, 1 insertion(+) > >

Re: [PATCH 4/5] dt-bindings: arm: sunxi: add binding for PineTab tablet

On Fri, 10 Jan 2020 23:52:24 +0800, Icenowy Zheng wrote: > Add the device tree binding for Pine64's PineTab tablet, which uses > Allwinner A64 SoC. > > Signed-off-by: Icenowy Zheng > --- > Documentation/devicetree/bindings/arm/sunxi.yaml | 5 + > 1 file changed, 5 insertions(+) > Reviewed-

Re: [RFC PATCH 4/4] drm/i915/gvt: move public gvt headers out into global include

On Thu, Jan 09, 2020 at 07:13:57PM +0200, Julian Stecklina wrote: > Now that the GVT interface to hypervisors does not depend on i915/GVT > internals anymore, we can move the headers to the global include/. > > This makes out-of-tree modules for hypervisor integration possible. What kind of out-o

Re: [PATCH 1/5] dt-bindings: vendor-prefix: add Shenzhen Feixin Photoelectics Co., Ltd

On Fri, 10 Jan 2020 23:52:21 +0800, Icenowy Zheng wrote: > Shenzhen Feixin Photoelectics Co., Ltd is a company to provide LCD > modules. > > Add its vendor prefix. > > Signed-off-by: Icenowy Zheng > --- > Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++ > 1 file changed, 2 inserti

Re: [PATCH v4] video: hyperv: hyperv_fb: Use physical memory for fb on HyperV Gen 1 VMs.

On 1/6/20 11:37 PM, Dexuan Cui wrote: >> From: Michael Kelley >> Sent: Monday, December 9, 2019 8:33 AM >> To: Wei Hu ; b.zolnier...@samsung.com; KY >> Srinivasan ; Haiyang Zhang ; >> Stephen Hemminger ; sas...@kernel.org; >> h...@lst.de; m.szyprow...@samsung.com; mchehab+sams...@kernel.org; >>

Re: [PATCH v2 07/21] drm/i915: Convert to CRTC VBLANK callbacks

On Wed, Jan 15, 2020 at 01:16:38PM +0100, Thomas Zimmermann wrote: > VBLANK callbacks in struct drm_driver are deprecated in favor of their > equivalents in struct drm_crtc_funcs. Convert i915 over. > > The callback struct drm_driver.get_scanout_position() is deprecated > in favor of struct drm_cr

Re: [PATCH] video: fbdev: arcfb: add missed free_irq

On 11/16/19 4:44 PM, Chuhong Yuan wrote: > The driver forgets to free irq in remove which is requested in > probe. > Add the missed call to fix it. > > Signed-off-by: Chuhong Yuan > --- > drivers/video/fbdev/arcfb.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/video/fbd

Re: [PATCH v6 4/5] drm/tidss: New driver for TI Keystone platform Display SubSystem

On 15/01/2020 16:43, Sam Ravnborg wrote: > Hi Jyri. > >>> ... v6: - Check CTM and gamma support from dispc_features when creating crtc - Implement CTM support for k2g and fix k3 CTM implementation - Remove gamma property persistence and always write color properties >>>

Re: [PATCH v2] video: fbdev: vesafb: add missed release_region

On 12/5/19 5:07 PM, Chuhong Yuan wrote: > The driver forgets to free the requested irq in remove and probe > failure. This is I/O region not IRQ. > Add the missed calls to fix it. > > Signed-off-by: Chuhong Yuan > --- > Changes in v2: > - Modify commit message. > > drivers/video/fbdev/ves

Re: [Intel-gfx] [PATCH v2 03/21] drm: Add get_vblank_timestamp() to struct drm_crtc_funcs

On Wed, Jan 15, 2020 at 01:16:34PM +0100, Thomas Zimmermann wrote: > The callback get_vblank_timestamp() is currently located in struct > drm_driver, but really belongs into struct drm_crtc_funcs. Add an > equivalent there. Driver will be converted in separate patches. > > The default implementati

Re: [PATCH v6 4/5] drm/tidss: New driver for TI Keystone platform Display SubSystem

Hi Jyri. > >> > > ... > >> v6: - Check CTM and gamma support from dispc_features when creating crtc > >> - Implement CTM support for k2g and fix k3 CTM implementation > >> - Remove gamma property persistence and always write color properties > >> in a new modeset > > > > I applied t

Re: [Intel-gfx] [PATCH v2 02/21] drm: Evaluate struct drm_device.vblank_disable_immediate on each use

On Wed, Jan 15, 2020 at 01:16:33PM +0100, Thomas Zimmermann wrote: > VBLANK interrupts can be disabled immediately or with a delay, where the > latter is the default. The former option can be selected by setting > get_vblank_timestamp, and enabling vblank_disable_immediate in struct > drm_device. >

Re: [PATCH][next] video: hyperv: hyperv_fb: fix indentation issue

On 11/14/19 6:27 PM, Colin King wrote: > From: Colin Ian King > > There is a block of statements that are indented > too deeply, remove the extraneous tabs. > > Signed-off-by: Colin Ian King Patch queued for v5.6, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Pola

Re: [PATCH v2] fbdev: potential information leak in do_fb_ioctl()

On 1/13/20 12:08 PM, Dan Carpenter wrote: > The "fix" struct has a 2 byte hole after ->ywrapstep and the > "fix = info->fix;" assignment doesn't necessarily clear it. It depends > on the compiler. The solution is just to replace the assignment with an > memcpy(). > > Fixes: 1f5e31d7e55a ("fbme

Re: [PATCH v6 4/5] drm/tidss: New driver for TI Keystone platform Display SubSystem

On 15/01/2020 14:22, Sam Ravnborg wrote: > Hi Jyri. > > On Wed, Jan 15, 2020 at 01:45:38PM +0200, Jyri Sarha wrote: >> This patch adds a new DRM driver for Texas Instruments DSS IPs used on >> Texas Instruments Keystone K2G, AM65x, and J721e SoCs. The new DSS IP is >> a major change to the older D

Re: [PATCH v4] drm/trace: Buffer DRM logs in a ringbuffer accessible via debugfs

On Wed, Jan 15, 2020 at 02:01:19PM +, Chris Wilson wrote: > Quoting Sean Paul (2020-01-15 13:41:58) > > On Wed, Jan 15, 2020 at 10:36:36AM +, Chris Wilson wrote: > > > Quoting Sean Paul (2020-01-14 17:21:43) > > > > From: Sean Paul > > > > > > > > This patch uses a ring_buffer to keep a "

Re: [Intel-gfx] [PATCH] drm/i915/dp: Add current maximum eDP link rate to sink_rate array.

On Wed, Jan 15, 2020 at 02:34:02PM +0200, Jani Nikula wrote: > On Fri, 10 Jan 2020, Ville Syrjälä wrote: > > On Thu, Jan 09, 2020 at 04:26:19PM -0500, Harry Wentland wrote: > >> > >> > >> On 2020-01-09 4:04 p.m., Mario Kleiner wrote: > >> > On Thu, Jan 9, 2020 at 8:49 PM Alex Deucher >> >

[PATCH] drm/vmwgfx: Use VM_PFNMAP instead of VM_MIXEDMAP when possible

From: Thomas Hellstrom For shared, and read-only private mappings of graphics memory, use VM_PFNMAP instead of VM_MIXEDMAP. This means less accounting overhead when inserting and removing page-table entries. TTM doesn't do this by default, since there was a performance problem with book-keeping o

[PATCH v8 0/8] add driver for "boe, tv101wum-nl6", "boe, tv101wum-n53", "auo, kd101n80-45na" and "auo, b101uan08.3" panels

Changes since v7: - base drm-misc-next branch - fix document pass dt_binding_check - remove backlight from panel driver Changes since v6: - fix boe_panel_init err uninit. - adjust the delay of backlight on. Changes since v5: - covert the documents to yaml - fine tune boe, tv101wum-n53 pane

[PATCH v8 7/8] dt-bindings: display: panel: add AUO auo, b101uan08.3 panel documentation

Add dcumentation for auo,b101uan08.3, which is mipi dsi video panel and resolution is 1200x1920. Signed-off-by: Jitao Shi --- .../display/panel/auo,b101uan08.3.yaml| 74 +++ 1 file changed, 74 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/pa

Re: [PATCH v4] drm/trace: Buffer DRM logs in a ringbuffer accessible via debugfs

Quoting Sean Paul (2020-01-15 13:41:58) > On Wed, Jan 15, 2020 at 10:36:36AM +, Chris Wilson wrote: > > Quoting Sean Paul (2020-01-14 17:21:43) > > > From: Sean Paul > > > > > > This patch uses a ring_buffer to keep a "flight recorder" (name credit > > > Weston) > > > of DRM logs for a speci

[PATCH v8 5/8] dt-bindings: display: panel: add boe tv101wum-n53 panel documentation

Add dcumentation for boe,tv101wum-n53, which is mipi dsi video panel and resolution is 1200x1920. Signed-off-by: Jitao Shi --- .../display/panel/boe,tv101wum-n53.yaml | 74 +++ 1 file changed, 74 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/p

[PATCH v8 4/8] drm/panel: support for auo, kd101n80-45na wuxga dsi video mode panel

Auo,kd101n80-45na's connector is same as boe,tv101wum-nl6. The most codes can be reuse. So auo,kd101n80-45na and boe,tv101wum-nl6 use one driver file. Add the different parts in driver data. Signed-off-by: Jitao Shi --- drivers/gpu/drm/panel/Kconfig | 6 +- .../gpu/drm/panel/pan

[PATCH v8 8/8] drm/panel: support for auo, b101uan08.3 wuxga dsi video mode panel

Auo,auo,b101uan08.3's connector is same as boe,tv101wum-nl6. The most codes can be reuse. So auo,b101uan08.3 and boe,tv101wum-nl6 use one driver file. Add the different parts in driver data. Signed-off-by: Jitao Shi Reviewed-by: Sam Ravnborg --- .../gpu/drm/panel/panel-boe-tv101wum-nl6.c| 7

[PATCH v8 6/8] drm/panel: support for boe, tv101wum-n53 wuxga dsi video mode panel

Boe,tv101wum-n53's connector is same as boe,tv101wum-nl6. The most codes can be reuse. So boe,tv101wum-n53 and boe,tv101wum-nl6 use one driver file. Add the different parts in driver data. Signed-off-by: Jitao Shi Reviewed-by: Sam Ravnborg --- .../gpu/drm/panel/panel-boe-tv101wum-nl6.c| 31

[PATCH v8 3/8] dt-bindings: display: panel: add auo kd101n80-45na panel bindings

Add documentation for auo kd101n80-45na panel. Signed-off-by: Jitao Shi Reviewed-by: Sam Ravnborg --- .../display/panel/auo,kd101n80-45na.yaml | 74 +++ 1 file changed, 74 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/panel/auo,kd101n80-45na.y

[PATCH v8 2/8] drm/panel: support for BOE tv101wum-nl6 wuxga dsi video mode panel

Add driver for BOE tv101wum-nl6 panel is a 10.1" 1200x1920 panel. Signed-off-by: Jitao Shi --- drivers/gpu/drm/panel/Kconfig | 9 + drivers/gpu/drm/panel/Makefile| 1 + .../gpu/drm/panel/panel-boe-tv101wum-nl6.c| 693 ++ 3 files changed, 70

[PATCH v8 1/8] dt-bindings: display: panel: Add BOE tv101wum-n16 panel bindings

Add documentation for boe tv101wum-n16 panel. Signed-off-by: Jitao Shi Reviewed-by: Sam Ravnborg --- .../display/panel/boe,tv101wum-nl6.yaml | 74 +++ 1 file changed, 74 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/panel/boe,tv101wum-nl6.yam

Re: [PATCH v4] drm/trace: Buffer DRM logs in a ringbuffer accessible via debugfs

On Wed, Jan 15, 2020 at 10:36:36AM +, Chris Wilson wrote: > Quoting Sean Paul (2020-01-14 17:21:43) > > From: Sean Paul > > > > This patch uses a ring_buffer to keep a "flight recorder" (name credit > > Weston) > > of DRM logs for a specified set of debug categories. The user writes a > > bi

Re: [PATCH v4] drm/trace: Buffer DRM logs in a ringbuffer accessible via debugfs

On Wed, Jan 15, 2020 at 12:28:31PM +0200, Jani Nikula wrote: > On Tue, 14 Jan 2020, Sean Paul wrote: > > From: Sean Paul > > > > This patch uses a ring_buffer to keep a "flight recorder" (name credit > > Weston) > > of DRM logs for a specified set of debug categories. The user writes a > > bitma

Re: [PATCH][RESEND] video: hyperv_fb: Fix hibernation for the deferred IO feature

On 1/11/20 5:29 PM, Sasha Levin wrote: > On Mon, Jan 06, 2020 at 02:41:51PM -0800, Dexuan Cui wrote: >> fb_deferred_io_work() can access the vmbus ringbuffer by calling >> fbdefio->deferred_io() -> synthvid_deferred_io() -> synthvid_update(). >> >> Because the vmbus ringbuffer is inaccessible bet

Re: [PATCH v4] drm/trace: Buffer DRM logs in a ringbuffer accessible via debugfs

On Wed, Jan 15, 2020 at 12:14:50PM +0200, Pekka Paalanen wrote: > On Tue, 14 Jan 2020 12:21:43 -0500 > Sean Paul wrote: > > > From: Sean Paul > > > > This patch uses a ring_buffer to keep a "flight recorder" (name credit > > Weston) > > of DRM logs for a specified set of debug categories. The

Re: [PATCH] drm/amdgpu: flush the fence on the bo after we individualize

Am 15.01.20 um 07:26 schrieb Pan, Xinhui: As we move the ttm_bo_individualize_resv() upwards, we need flush the copied fence too. Otherwise the driver keeps waiting for fence. run&Kill kfdtest, then perf top. 25.53% [ttm] [k] ttm_bo_delayed_delete 24.29% [kernel]

Re: [PATCH] fbdev: potential information leak in do_fb_ioctl()

On Wed, Jan 15, 2020 at 2:09 PM Bartlomiej Zolnierkiewicz wrote: > > $ git grep -wl register_framebuffer | xargs grep -L framebuffer_alloc > > Documentation/fb/framebuffer.rst > > drivers/media/pci/ivtv/ivtvfb.c > > drivers/media/platform/vivid/vivid-osd.c > > drivers/video/fbdev/68328fb.c > > dr

Re: [PATCH] fbdev: potential information leak in do_fb_ioctl()

On 1/13/20 1:49 PM, Arnd Bergmann wrote: > On Fri, Jan 3, 2020 at 2:09 PM Bartlomiej Zolnierkiewicz > wrote: >> On 10/29/19 8:02 PM, Eric W. Biederman wrote: >>> >>> The goal is to avoid memory that has values of the previous users of >>> that memory region from leaking to userspace. Which depe

Re: [PATCH v2 0/4] Use no_vblank property for drivers without VBLANK

Hi, On 15-01-2020 13:52, Thomas Zimmermann wrote: (Resending because I did not cc dri-devel properly.) Instead of faking VBLANK events by themselves, drivers without VBLANK support can enable drm_crtc_vblank.no_vblank and let DRM do the rest. The patchset makes this official and converts over s

[PATCH v2 resend/trivial] drm/bridge: ti-tfp410: Update drm_connector_init_with_ddc() error message

The code was changed to call drm_connector_init_with_ddc() instead of drm_connector_init(), but the corresponding error message was not updated. Fixes: cfb444552926989f ("drm/bridge: ti-tfp410: Provide ddc symlink in connector sysfs directory") Signed-off-by: Geert Uytterhoeven Reviewed-by: Neil

Re: TTM or vmwgfx tree? Re: [PATCH v5 0/2] mm, drm/ttm: Fix pte insertion with customized protection

Am 15.01.20 um 13:45 schrieb Thomas Hellström (VMware): Hi Christian, On 1/15/20 1:41 PM, Thomas Hellström (VMware) wrote: From: Thomas Hellstrom The drm/ttm module is using a modified on-stack copy of the struct vm_area_struct to be able to set a page protection with customized caching. Fi

[PATCH v2 1/4] drm: Document struct drm_crtc_state.no_vblank for faking VBLANK events

Drivers for CRTC hardware without support for VBLANK interrupts can set struct drm_crtc_state.no_vblank and let DRM's atomic commit helpers generate the VBLANK events automatically. Document this in order to make it official. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/drm_atomic_helper

[PATCH v2 2/4] drm/ast: Set struct drm_crtc_state.no_vblank in atomic_check()

CRTC state properties should be computed in atomic_check(). Do so for the no_vblank field. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/ast/ast_mode.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/ast/ast_mode.c b/drivers/gpu/drm/ast/ast_mode.c i

[PATCH v2 4/4] drm/simple-kms: Let DRM core send VBLANK events by default

In drm_atomic_helper_fake_vblank() the DRM core sends out VBLANK events if struct drm_crtc_state.no_vblank is enabled in the check() callbacks. For drivers that have neither an enable_vblank() callback nor a check() callback, the simple-KMS helpers enable VBLANK generation by default. This simplif

[PATCH v2 3/4] drm/cirrus: Let DRM core send VBLANK events

In drm_atomic_helper_fake_vblank(), the DRM core sends out VBLANK events if struct drm_crtc_state.no_vblank is enabled. Replace cirrus' VBLANK events with the DRM core's functionality. v2: * set struct_drm_crtc_state.no_vblank in cirrus_pipe_check() Signed-off-by: Thomas Zimmermann ---

[PATCH v2 0/4] Use no_vblank property for drivers without VBLANK

(Resending because I did not cc dri-devel properly.) Instead of faking VBLANK events by themselves, drivers without VBLANK support can enable drm_crtc_vblank.no_vblank and let DRM do the rest. The patchset makes this official and converts over several drivers. Ast already uses the functionality a

[PATCH v2 2/5] dt-bindings: display: sitronix, st7735r: Add Okaya RH128128T

Document support for the Okaya RH128128T display, which is a 128x128 1.44" TFT display driven by a Sitronix ST7715R TFT Controller/Driver. It can be found on e.g. the Renesas YRSK-LCD-PMOD extension board, which comes with various Renesas development kits (e.g. Renesas Starter Kit+ for RZ/A1H[1]).

[PATCH v2 3/5] drm/mipi_dbi: Add support for display offsets

If the resolution of the TFT display is smaller than the maximum resolution supported by the display controller, the display may be connected to the driver output arrays with a horizontal and/or vertical offset, leading to a shifted image. Add support for specifying these offsets. Signed-off-by:

TTM or vmwgfx tree? Re: [PATCH v5 0/2] mm, drm/ttm: Fix pte insertion with customized protection

Hi Christian, On 1/15/20 1:41 PM, Thomas Hellström (VMware) wrote: From: Thomas Hellstrom The drm/ttm module is using a modified on-stack copy of the struct vm_area_struct to be able to set a page protection with customized caching. Fix that by adding a vmf_insert_mixed_prot() function similar

[PATCH v2 1/5] dt-bindings: display: sitronix, st7735r: Convert to DT schema

Convert the DT binding documentation for Sitronix ST7735R displays to DT schema. Add a reference to the Adafruit 1.8" LCD while at it. Signed-off-by: Geert Uytterhoeven --- v2: - New. --- .../bindings/display/sitronix,st7735r.txt | 35 -- .../bindings/display/sitronix,st7735r.yaml

[PATCH v2 5/5] drm: tiny: st7735r: Add support for Okaya RH128128T

Add support for the Okaya RH128128T display to the st7735r driver on DT-enabled systems. The RH128128T is a 128x128 1.44" TFT display driven by a Sitronix ST7715R TFT Controller/Driver. The latter is very similar to the ST7735R, and can be handled by the existing st7735r driver. Signed-off-by: G

[PATCH v2 0/5] drm: Add support for Okaya RH128128T

Hi all, This patch series adds support for the Okaya RH128128T LCD to the existing ST7735R driver. This is a 128x128 1.4" TFT display driven by a Sitronix ST7715R TFT Controller/Driver. It is used on e.g. the Renesas YRSK-LCD-PMOD extension board, which is shipped with Renesas RSK+RZA1 d

[PATCH v2 4/5] drm: tiny: st7735r: Prepare for adding support for more displays

Currently the st7735r driver supports only a single display panel. Prepare for adding support for other display panels by factoring out the display-specific parameters in struct st7735r_cfg. For now, the following parameters can be configured: - Display resolution, - Horizontal/vertical displa

[PATCH v5 0/2] mm, drm/ttm: Fix pte insertion with customized protection

From: Thomas Hellstrom The drm/ttm module is using a modified on-stack copy of the struct vm_area_struct to be able to set a page protection with customized caching. Fix that by adding a vmf_insert_mixed_prot() function similar to the existing vmf_insert_pfn_prot() for use with drm/ttm. Patches

[PATCH v5 1/2] mm: Add a vmf_insert_mixed_prot() function

From: Thomas Hellstrom The TTM module today uses a hack to be able to set a different page protection than struct vm_area_struct::vm_page_prot. To be able to do this properly, add the needed vm functionality as vmf_insert_mixed_prot(). Cc: Andrew Morton Cc: Michal Hocko Cc: "Matthew Wilcox (Or

[PATCH v5 2/2] mm, drm/ttm: Fix vm page protection handling

From: Thomas Hellstrom TTM graphics buffer objects may, transparently to user-space, move between IO and system memory. When that happens, all PTEs pointing to the old location are zapped before the move and then faulted in again if needed. When that happens, the page protection caching mode- an

Re: [PATCH v2 07/21] drm/i915: Convert to CRTC VBLANK callbacks

On Wed, 15 Jan 2020, Thomas Zimmermann wrote: > VBLANK callbacks in struct drm_driver are deprecated in favor of their > equivalents in struct drm_crtc_funcs. Convert i915 over. > > The callback struct drm_driver.get_scanout_position() is deprecated > in favor of struct drm_crtc_helper_funcs.get_s

  1   2   >