From: Chen-Yu Tsai
When the extra HPD polling in sun4i_hdmi was removed, the result of
HPD was accidentally inverted.
Fix this by inverting the check.
Fixes: bda8eaa6dee7 ("drm: sun4i: hdmi: Remove extra HPD polling")
Signed-off-by: Chen-Yu Tsai
---
Sorry for the screw-up.
---
On Fri, Jul 10, 2020 at 4:11 PM Jonathan Marek wrote:
>
> On 7/9/20 11:15 AM, Rob Clark wrote:
> > On Thu, Jul 9, 2020 at 7:35 AM Jonathan Marek wrote:
> >>
> >> Check for errors instead of silently not using icc if the msm driver
> >> probes before the interconnect driver.
> >>
> >> Allow
This is just like the patch ("dt-bindings: msm/disp: Add simple-bus to
dpu bindings") but for the mdp5 bindings.
Signed-off-by: Douglas Anderson
---
Documentation/devicetree/bindings/display/msm/mdp5.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
I found that if I ever had a little mistake in my kernel config,
or device tree, or graphics driver that my system would sit in a loop
at bootup trying again and again and again. An example log was:
msm ae0.mdss: bound ae01000.mdp (ops 0xffe596e951f8)
msm_dsi ae94000.dsi: ae94000.dsi
As described in the bindings patch, this means that our child nodes
are devices in their own right.
Signed-off-by: Douglas Anderson
---
If this patch lands before the patch ("drm/msm: Avoid manually
populating our children if "simple-bus" is there") it doesn't seem to
be the end of the world.
As described in the bindings patch, this means that our child nodes
are devices in their own right.
Signed-off-by: Douglas Anderson
---
If this patch lands before the patch ("drm/msm: Avoid manually
populating our children if "simple-bus" is there") it doesn't seem to
be the end of the world.
Hi Sebastian,
Thank you for the patch.
On Tue, Jun 30, 2020 at 07:50:31AM +0200, Sam Ravnborg wrote:
> On Tue, Jun 30, 2020 at 12:33:12AM +0200, Sebastian Reichel wrote:
> > Convert panel-dsi-cm bindings to YAML and add
> > missing properties while at it.
> >
> > Signed-off-by: Sebastian
As described in the bindings patch, this means that our child nodes
are devices in their own right.
Signed-off-by: Douglas Anderson
---
If this patch lands before the patch ("drm/msm: Avoid manually
populating our children if "simple-bus" is there") it doesn't seem to
be the end of the world.
As described in the bindings patch, this means that our child nodes
are devices in their own right.
Signed-off-by: Douglas Anderson
---
If this patch lands before the patch ("drm/msm: Avoid manually
populating our children if "simple-bus" is there") it doesn't seem to
be the end of the world.
If our compatible string has "simple-bus" at the end of it then the
system will handle probing our children for us. Doing this has a few
advantages:
1. If we defer we don't have to keep probing / removing our children
which should speed up boot. The system just probes them once.
2. It fixes
As described in the bindings patch, this means that our child nodes
are devices in their own right.
Signed-off-by: Douglas Anderson
---
If this patch lands before the patch ("drm/msm: Avoid manually
populating our children if "simple-bus" is there") it doesn't seem to
be the end of the world.
We have a whole bunch of child devices that we really just want
treated as other devices to instantiate. Add the "simple-bus"
property for this.
Commit-notes
This bindings file really needs to move over to yaml. Hopefully
someone at Qualcomm who's working on display code can help with that.
Let's save ourselves some hassle and use the devm variant of
of_platform_populate() do we don't need to worry about manually
depopulating.
Signed-off-by: Douglas Anderson
---
drivers/gpu/drm/msm/msm_drv.c | 20
1 file changed, 4 insertions(+), 16 deletions(-)
diff --git
Hi Sebastian,
Thank you for the patch.
On Tue, Jun 30, 2020 at 12:33:15AM +0200, Sebastian Reichel wrote:
> Add information about panel orientation, so that the
> system boots into a properly rotated shell.
>
> Signed-off-by: Sebastian Reichel
Reviewed-by: Laurent Pinchart
> ---
>
Hi Sebastian,
Thank you for the patch.
On Tue, Jun 30, 2020 at 12:33:13AM +0200, Sebastian Reichel wrote:
> The standard binding for DSI requires, that the channel number
s/requires,/requires/
> of the panel is encoded in DT. This adds the channel number in
> all OMAP3-5 boards, in preparation
Hi Sebastian,
Thank you for the patch, and for your continuous effort on this.
On Tue, Jun 30, 2020 at 12:33:14AM +0200, Sebastian Reichel wrote:
> Add Droid 4 specific compatible value in addition to the
> generic one, so that we have the ability to add panel
> specific quirks in the future.
>
Hi Sam,
Thank you for the patch.
On Fri, Jul 03, 2020 at 09:24:17PM +0200, Sam Ravnborg wrote:
> Prepare the bridge driver for use in a chained setup by
> replacing direct use of drm_panel with drm_panel_bridge support.
>
> Note: the bridge panel will use the connector type from the panel.
>
>
Hi Sam,
Thank you for the patch.
On Fri, Jul 03, 2020 at 09:24:16PM +0200, Sam Ravnborg wrote:
> Make the connector creation optional to enable usage of the
> nxp-ptn3460 bridge with the DRM bridge connector helper.
>
> Signed-off-by: Sam Ravnborg
> Cc: Andrzej Hajda
> Cc: Neil Armstrong
>
Hi Sam,
Thank you for the patch.
On Fri, Jul 03, 2020 at 09:24:15PM +0200, Sam Ravnborg wrote:
> Add the get_modes() bridge operation to prepare for
> use as a chained bridge.
> Add helper function that is also used by the connector.
>
> Signed-off-by: Sam Ravnborg
> Cc: Andrzej Hajda
> Cc:
Hi Sam,
Thank you for the patch.
On Fri, Jul 03, 2020 at 09:24:14PM +0200, Sam Ravnborg wrote:
> Prepare the bridge driver for use in a chained setup by
> replacing direct use of drm_panel with drm_panel_bridge support.
>
> Note: the bridge panel will use the connector type from the panel.
>
>
Hi Sam,
Thank you for the patch.
On Fri, Jul 03, 2020 at 09:24:13PM +0200, Sam Ravnborg wrote:
> Make the connector creation optional to enable usage of the
> megachips-stdp-ge-b850v3-fw bridge with the DRM bridge connector helper.
>
> Signed-off-by: Sam Ravnborg
> Cc: Peter Senna Tschudin
Hi Sam,
Thank you for the patch.
On Fri, Jul 03, 2020 at 09:24:12PM +0200, Sam Ravnborg wrote:
> To prepare for a chained bridge setup add support for the
> get_edid bridge operation.
>
> Signed-off-by: Sam Ravnborg
> Cc: Peter Senna Tschudin
> Cc: Martin Donnelly
> Cc: Martyn Welch
> Cc:
On 7/11/2020 2:43 AM, Akhil P Oommen wrote:
On 7/10/2020 1:34 AM, Jonathan Marek wrote:
On 7/9/20 4:00 PM, Akhil P Oommen wrote:
Newer targets support changing gpu frequency through HFI. So
use that wherever supported instead of the legacy method.
It was already using HFI on newer
Hi Sam,
Thank you for the patch.
On Fri, Jul 03, 2020 at 09:24:11PM +0200, Sam Ravnborg wrote:
> To prepare for use in a chained bridge setup enable the
> detect operation.
>
> Signed-off-by: Sam Ravnborg
> Cc: Peter Senna Tschudin
> Cc: Martin Donnelly
> Cc: Martyn Welch
> Cc: Andrzej
Hi Sam,
Thank you for the patch.
On Fri, Jul 03, 2020 at 09:24:09PM +0200, Sam Ravnborg wrote:
> Factor out connector creation to a small helper function.
>
> Signed-off-by: Sam Ravnborg
> Cc: Peter Senna Tschudin
> Cc: Martin Donnelly
> Cc: Martyn Welch
> Cc: Andrzej Hajda
> Cc: Neil
Hi Sam,
Thank you for the patch.
On Fri, Jul 03, 2020 at 09:24:10PM +0200, Sam Ravnborg wrote:
> Fix so drm_device is read from the bridge.
> This is a preparation for the connector being optional.
>
> Signed-off-by: Sam Ravnborg
> Cc: Peter Senna Tschudin
> Cc: Martin Donnelly
> Cc: Martyn
Hi Sam,
Thank you for the patch.
On Fri, Jul 03, 2020 at 09:24:08PM +0200, Sam Ravnborg wrote:
> Make the connector creation optional to enable usage of the
> parade-ps8622 bridge with the DRM bridge connector helper.
>
> This change moves drm_helper_hpd_irq_event() call in the attach
>
On Fri, Jul 10, 2020 at 2:03 PM Akhil P Oommen wrote:
>
>
> On 7/11/2020 1:11 AM, Rob Clark wrote:
> > On Thu, Jul 9, 2020 at 1:01 PM Akhil P Oommen
> > wrote:
> >> From: Sharat Masetty
> >>
> >> This patches replaces the previously used static DDR vote and uses
> >> dev_pm_opp_set_bw() to
Hi Sam,
Thank you for the patch.
On Fri, Jul 03, 2020 at 09:24:07PM +0200, Sam Ravnborg wrote:
> Prepare the bridge driver for use in a chained setup by
> replacing direct use of drm_panel with drm_panel_bridge support.
>
> Note: the bridge panel will use the connector type from the panel.
>
>
Hi Sam,
Thank you for the patch.
On Fri, Jul 03, 2020 at 09:24:06PM +0200, Sam Ravnborg wrote:
> The ti-tpd12s015 do not create any connector, so ignore
> the flags argument, just pass it on to the next bridge
> in the chain.
>
> Signed-off-by: Sam Ravnborg
> Cc: Andrzej Hajda
> Cc: Neil
Hi Sam,
Thank you for the patch.
s/bride/bridge/ in the subject line.
On Fri, Jul 03, 2020 at 09:24:04PM +0200, Sam Ravnborg wrote:
> Prepare for chained bridge with the addition of
> get_edid support.
>
> Signed-off-by: Sam Ravnborg
> Cc: Andrzej Hajda
> Cc: Neil Armstrong
> Cc: Laurent
Hi Sam,
Thank you for the patch.
On Fri, Jul 03, 2020 at 09:24:05PM +0200, Sam Ravnborg wrote:
> Display drivers are in the new model expected to create
> the connector using drm_bridge_connector_init().
> Allow users of this bridge driver to support the new
> model by introducing support for
On Fri, Jul 10, 2020 at 03:31:44PM -0400, Lyude Paul wrote:
> From: Lee Shawn C
>
> So far, max dot clock rate for MST mode rely on physcial
> bandwidth limitation. It would caused compatibility issue
> if source display resolution exceed MST hub output ability.
>
> For example, source DUT had
Hi Sam,
Thank you for the patch.
On Fri, Jul 03, 2020 at 09:24:03PM +0200, Sam Ravnborg wrote:
> Prepare the bridge driver for chained operation by adding
> support for the detect operation.
>
> Signed-off-by: Sam Ravnborg
> Cc: Andrzej Hajda
> Cc: Neil Armstrong
> Cc: Laurent Pinchart
>
Hi Sam,
Thank you for the patch.
On Fri, Jul 03, 2020 at 09:24:02PM +0200, Sam Ravnborg wrote:
> Prepare the bridge driver for use in a chained setup by
> replacing direct use of drm_panel with drm_panel_bridge support.
>
> The bridge driver assume the panel is optional.
> The relevant tests
On Fri, Jul 10, 2020 at 03:31:43PM -0400, Lyude Paul wrote:
> This is just an atomic version of mode_valid, which is intended to be
> used for situations where a driver might need to check the atomic state
> of objects other than the connector itself. One such example is with
> MST, where the
Hi Sam,
Thank you for the patch.
On Fri, Jul 03, 2020 at 09:23:58PM +0200, Sam Ravnborg wrote:
> All panels shall report a connector type.
> panel-simple has a lot of panels with no connector_type,
> and for these fall back to DPI as the default.
>
> Signed-off-by: Sam Ravnborg
> Cc: Thierry
Hi Sam,
Thank you for the patch.
On Fri, Jul 03, 2020 at 09:23:57PM +0200, Sam Ravnborg wrote:
> The boe,hv070wsa-100 panel is a LVDS panel.
> Fix connector type to reflect this.
>
> With this change users of this panel do not have to specify the
> connector type.
>
> v3:
> - Drop PIXDATA
On 7/10/2020 1:34 AM, Jonathan Marek wrote:
On 7/9/20 4:00 PM, Akhil P Oommen wrote:
Newer targets support changing gpu frequency through HFI. So
use that wherever supported instead of the legacy method.
It was already using HFI on newer targets. Don't break it in one
commit then fix it in
> > Acked-by: Thomas Zimmermann
> >
> > but I'd like to have someone with more architecture expertise ack this
> > as well.
>
> Agreed. All my testing is using the bochs_drm framebuffer under
> qemu-system-sparc64
> (a sun4u machine) so it would be nice to get an ACK from Dave or someone else
>
On 7/11/2020 1:11 AM, Rob Clark wrote:
On Thu, Jul 9, 2020 at 1:01 PM Akhil P Oommen wrote:
From: Sharat Masetty
This patches replaces the previously used static DDR vote and uses
dev_pm_opp_set_bw() to scale GPU->DDR bandwidth along with scaling
GPU frequency. Also since the icc path
On Fri, Jul 10, 2020 at 4:38 AM Colin King wrote:
>
> From: Colin Ian King
>
> There is a spelling mistake in a DRM_ERROR error message. Fix it.
>
> Signed-off-by: Colin Ian King
Applied. Thanks!
Alex
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 2 +-
> 1 file changed, 1 insertion(+),
Commit 13871279ff5c ("arm64: dts: allwinner: h6: Fix Cedrus IOMMU usage")
introduced a double instance of 'iommus' causing the following build
error with 'make dt_binding_check':
found duplicate key "iommus" with value "{}" (original value: "{}")
in "", line 45, column 3
Remove the double
On Fri, Jul 10, 2020 at 4:23 PM Jason Gunthorpe wrote:
>
> On Fri, Jul 10, 2020 at 04:02:35PM +0200, Daniel Vetter wrote:
>
> > > dma_fence only possibly makes some sense if you intend to expose the
> > > completion outside a single driver.
> > >
> > > The prefered kernel design pattern for this
On Sun, Jul 05, 2020 at 05:45:14PM +0800, Jitao Shi wrote:
> Delay the backlight on to make sure the video stable.
>
> Signed-off-by: Jitao Shi
Thanks, fixed up and applied to drm-misc-next.
Sam
> ---
> drivers/gpu/drm/panel/panel-simple.c | 7 +++
> 1 file changed, 7
On Thu, Jul 9, 2020 at 1:01 PM Akhil P Oommen wrote:
>
> From: Sharat Masetty
>
> This patches replaces the previously used static DDR vote and uses
> dev_pm_opp_set_bw() to scale GPU->DDR bandwidth along with scaling
> GPU frequency. Also since the icc path voting is handled completely
> in the
Something we've been missing for a while with drivers that support MST
is being able to prune modes that can't be set due to bandwidth
limitations. So, let's go ahead and add that. This also adds a new hook
that was needed, mode_valid_ctx, so that we can grab additional locks as
needed when
This is just an atomic version of mode_valid, which is intended to be
used for situations where a driver might need to check the atomic state
of objects other than the connector itself. One such example is with
MST, where the maximum possible bandwidth on a connector can change
dynamically
From: Lee Shawn C
So far, max dot clock rate for MST mode rely on physcial
bandwidth limitation. It would caused compatibility issue
if source display resolution exceed MST hub output ability.
For example, source DUT had DP 1.2 output capability.
And MST docking just support HDMI 1.4 spec. When
On Sat, Jul 04, 2020 at 04:35:43PM +0200, Sam Ravnborg wrote:
> Trivial fix for a long standing warning.
> At least not fixed in drm-msc-next for now.
> Just in case it was not fixed by someone else (Rob?) already.
>
> Sam
>
> Sam Ravnborg (1):
> dt-bindings: fix simple-framebuffer
On Sat, Jul 04, 2020 at 12:28:03PM +0200, Sam Ravnborg wrote:
> This patch-set convert 3 of the remaining panel bindings to yaml.
>
> This is a follow-up on v2 that converted a lot of panel bindings:
> https://lore.kernel.org/dri-devel/20200408195109.32692-1-...@ravnborg.org/
> All was applied
On 10/07/2020 07:28, Thomas Zimmermann wrote:
Hi Sam,
Thanks again for the patch. I've spotted some small typos that you may like to
fix if
you repost the patch:
> Hi
>
> Am 09.07.20 um 21:30 schrieb Sam Ravnborg:
>> Mark reported that sparc64 would panic while booting using qemu.
>> Mark
Hi Rob.
> > On Sat, Jul 04, 2020 at 12:28:03PM +0200, Sam Ravnborg wrote:
> > > This patch-set convert 3 of the remaining panel bindings to yaml.
> > >
> > > This is a follow-up on v2 that converted a lot of panel bindings:
> > >
Hi Marek.
On Tue, Jul 07, 2020 at 01:08:59PM +0200, Marek Szyprowski wrote:
> Add a proper cast on the exynos_gem->kvaddr assignment to avoid a sparse
> warning.
>
> Reported-by: kernel test robot
> Fixes: 9940d9d93406 ("drm/exynos: gem: Get rid of the internal 'pages' array")
> Signed-off-by:
On Tue, Jul 07, 2020 at 01:35:00PM -0700, Rob Clark wrote:
> From: Rob Clark
Might need a commit log here, but otherwise makes sense.
Reviewed-by: Jordan Crouse
> Signed-off-by: Rob Clark
> ---
> drivers/gpu/drm/msm/adreno/a5xx_gpu.c | 5 +++--
> drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 11
On Tue, Jul 07, 2020 at 10:07:21PM +0530, Suraj Upadhyay wrote:
> Change logging information from dev_info() to drm_info().
>
> Signed-off-by: Suraj Upadhyay
Thanks. Applied to drm-misc-next.
Also, because there was no more logging functions that needed an update.
Sam
> ---
>
On Tue, Jul 07, 2020 at 09:58:48PM +0530, Suraj Upadhyay wrote:
> Convert logging errors from dev_err() to drm_err().
>
> Signed-off-by: Suraj Upadhyay
Thanks. Applied to drm-misc-next as there was no more logging conversion
to do in this file.
Sam
> ---
>
Hi Suraj.
On Tue, Jul 07, 2020 at 10:04:14PM +0530, Suraj Upadhyay wrote:
>
> This patchset converts logging to drm_* functions in drm core.
>
> The following functions have been converted to their respective
> DRM alternatives :
> dev_info() --> drm_info()
> dev_err() --> drm_err()
On Wed, Jul 08, 2020 at 02:16:04PM +0200, Alexander A. Klimov wrote:
> Rationale:
> Reduces attack surface on kernel devs opening the links for MITM
> as HTTPS traffic is much harder to manipulate.
>
> Deterministic algorithm:
> For each file:
> If not .svg:
> For each line:
> If
Hi Alexander.
On Wed, Jul 08, 2020 at 06:38:47PM +0200, Alexander A. Klimov wrote:
> Rationale:
> Reduces attack surface on kernel devs opening the links for MITM
> as HTTPS traffic is much harder to manipulate.
>
> Deterministic algorithm:
> For each file:
> If not .svg:
> For each line:
On Tue, Jun 30, 2020 at 11:09:57PM -0400, Jonathan Marek wrote:
> This sets up bw tables for A640/A650 similar to A618/A630, 0 DDR bandwidth
> vote, and the CNOC vote. A640 has the same CNOC addresses as A630 and was
> working, but this is required for A650 to work.
>
> Eventually the bw table
On Thu, Jul 09, 2020 at 10:02:36AM +0800, Liu Ying wrote:
> It doesn't hurt to add the bridge in the global bridge list also for
> platform specific dw-hdmi drivers which are based on the component
> framework. This can be achieved by moving the drm_bridge_add() function
> call from
On Thu, Jul 09, 2020 at 10:02:35AM +0800, Liu Ying wrote:
> It's unnecessary to cleanup the i2c adapter and the ddc pointer in
> the bailout path of __dw_hdmi_probe(), since the adapter is not
> added and the ddc pointer is not set.
>
> Fixes: a23d6265f033 (drm: bridge: dw-hdmi: Extract PHY
On Mon, Jun 29, 2020 at 08:10:06PM -0400, Jonathan Marek wrote:
> A650 has a separate RSCC region, so dump RSCC registers separately, reading
> them from the RSCC base. Without this change a GPU hang will cause a system
> reset if CONFIG_DEV_COREDUMP is enabled.
Reviewed-by: Jordan Crouse
>
>-Original Message-
>From: dri-devel On Behalf Of
>Andrzej Hajda
>Sent: Friday, July 10, 2020 11:30 AM
>To: Greg Kroah-Hartman
>Cc: Jernej Skrabec ; Rafael J. Wysocki
>; Jonas Karlman ; Bartlomiej
>Zolnierkiewicz ; linux-ker...@vger.kernel.org;
>open list:DRM DRIVERS ; Russell King - ARM
On Thu, Jul 09, 2020 at 08:47:55PM +0200, Alexander A. Klimov wrote:
> Rationale:
> Reduces attack surface on kernel devs opening the links for MITM
> as HTTPS traffic is much harder to manipulate.
>
> Deterministic algorithm:
> For each file:
> If not .svg:
> For each line:
> If
Thanks for reviews Rob.
On 2020-07-09 13:21, Rob Herring wrote:
On Tue, Jun 30, 2020 at 11:45:01AM -0700, Tanmay Shah wrote:
These patches add Display-Port driver on SnapDragon/msm hardware.
This series also contains device-tree bindings for msm DP driver.
It also contains Makefile and Kconfig
On Thu, Jun 18, 2020 at 7:09 AM Kalyan Thota wrote:
>
> This change adds support to scale src clk and bandwidth as
> per composition requirements.
>
> Interconnect registration for bw has been moved to mdp
> device node from mdss to facilitate the scaling.
>
> Changes in v1:
> - Address armv7
On 07/02, Daniel Vetter wrote:
> On Wed, Jul 01, 2020 at 03:31:34PM +, Sidong Yang wrote:
> > there is an error when igt test is run continuously.
> > vkms_atomic_commit_tail()
> > need to call drm_atomic_helper_wait_for_vblanks() for give up ownership of
> > vblank events. without this code,
https://bugzilla.kernel.org/show_bug.cgi?id=205815
--- Comment #3 from Bernard MAUDRY (ramaspaces...@free.fr) ---
Using latest kernel:
juil. 10 12:39:47 Rama kernel: Linux version 5.7.0-1-amd64
(debian-ker...@lists.debian.org) (gcc version 9.3.0 (Debian 9.3.0-14), GNU ld
(GNU Binutils for Debian)
On Thu, Jun 25, 2020 at 5:46 AM Kalyan Thota wrote:
>
> Setup an RGB HW pipe as cursor which can be used on
> secondary interface.
>
> For SC7180 2 HW pipes are enumerated as cursors
> 1 - primary interface
> 2 - secondary interface
>
> Signed-off-by: Kalyan Thota
> ---
>
https://bugzilla.kernel.org/show_bug.cgi?id=208513
Alex Deucher (alexdeuc...@gmail.com) changed:
What|Removed |Added
CC|
This change expands the coverage for the IGT kms_cursor_crc test, where
the size varies between 64 and 512 for a square cursor. With this, in
addition to the cursor 64x64, this patch enables the test of cursors with
sizes: 128x128, 256x256, and 512x512.
Signed-off-by: Melissa Wen
---
Using dev_err_probe code has following advantages:
- shorter code,
- recorded defer probe reason for debugging,
- uniform error code logging.
Signed-off-by: Andrzej Hajda
Reviewed-by: Neil Armstrong
---
drivers/gpu/drm/bridge/lvds-codec.c | 10 +++---
1 file changed, 3 insertions(+), 7
/sys/kernel/debug/devices_deferred property contains list of deferred devices.
This list does not contain reason why the driver deferred probe, the patch
improves it.
The natural place to set the reason is dev_err_probe function introduced
recently, ie. if dev_err_probe will be called with
During probe every time driver gets resource it should usually check for
error printk some message if it is not -EPROBE_DEFER and return the error.
This pattern is simple but requires adding few lines after any resource
acquisition code, as a result it is often omitted or implemented only
Hi All,
Thanks for comments.
Changes since v7:
- improved commit message
- added R-Bs
Changes since v6:
- removed leftovers from old naming scheme in commit descritions,
- added R-Bs.
Changes since v5:
- removed patch adding macro, dev_err_probe(dev, PTR_ERR(ptr), ...) should be
used instead,
In case of error during resource acquisition driver should print error
message only in case it is not deferred probe, using dev_err_probe helper
solves the issue. Moreover it records defer probe reason for debugging.
Signed-off-by: Andrzej Hajda
Reviewed-by: Neil Armstrong
---
This is AD-HOC script, it should nt be merged.
Signed-off-by: Andrzej Hajda
---
probe_err.cocci | 247
1 file changed, 247 insertions(+)
create mode 100644 probe_err.cocci
diff --git a/probe_err.cocci b/probe_err.cocci
new file mode 100644
On 10.07.2020 15:31, Greg Kroah-Hartman wrote:
> On Thu, Jul 02, 2020 at 03:44:21PM +0200, Andrzej Hajda wrote:
>> /sys/kernel/debug/devices_deferred property contains list of deferred
>> devices.
>> This list does not contain reason why the driver deferred probe, the patch
>> improves it.
>>
Thank you Daniel,
Now this works perfectly, all while I was on vacation.
On 08/07/2020 17:20, Daniel Vetter wrote:
> Gives us proper nonblocking support for free, and a pile of other
> things. The tilcdc code is simply old enough that it was never
> converted over, but was stuck forever with the
Hi,
On Thu, Jul 9, 2020 at 11:15 PM Steev Klimaszewski wrote:
>
> Hi,
>
> On 7/9/20 11:12 PM, Doug Anderson wrote:
> >> root@c630:~# bus=$(i2cdetect -l | grep sn65 | sed
> >> 's/i2c-\([0-9]*\).*$/\1/')
> >> root@c630:~# i2cdump ${bus} 0x50 i > edid
> >> WARNING! This program can confuse your
https://bugzilla.kernel.org/show_bug.cgi?id=207383
--- Comment #58 from Anthony Ruhier (anthony.ruh...@gmail.com) ---
Sorry, I forgot to say that I have a vega64.
--
You are receiving this mail because:
You are watching the assignee of the bug.
___
On Fri, 10 Jul 2020 at 17:24, Juergen Gross wrote:
>
> efifb_probe() will issue an error message in case the kernel is booted
> as Xen dom0 from UEFI as EFI_MEMMAP won't be set in this case. Avoid
> that message by calling efi_mem_desc_lookup() only if EFI_MEMMAP is set.
>
> Fixes: 38ac0287b7f4
On 7/1/20 11:02 PM, Rikard Falkeborn wrote:
> These are not modified so make them const to allow the compiler to put
> them in read-only memory.
>
> Before:
>textdata bss dec hex filename
> 255097928 64 3350182dd drivers/video/fbdev/vt8623fb.o
>
> After:
>
On 7/6/20 5:53 PM, Evgeny Novikov wrote:
> If smtcfb_pci_probe() does not detect a valid chip it cleans up
> everything and returns 0. This can result in various bad things later.
> The patch sets the error code on the corresponding path.
>
> Found by Linux Driver Verification project
efifb_probe() will issue an error message in case the kernel is booted
as Xen dom0 from UEFI as EFI_MEMMAP won't be set in this case. Avoid
that message by calling efi_mem_desc_lookup() only if EFI_MEMMAP is set.
Fixes: 38ac0287b7f4 ("fbdev/efifb: Honour UEFI memory map attributes when
mapping
On 6/20/20 1:27 PM, Sam Ravnborg wrote:
> Hi Gustavo.
>
> On Wed, Jun 17, 2020 at 12:56:47PM -0500, Gustavo A. R. Silva wrote:
>> Make use of the struct_size() helper instead of an open-coded version
>> in order to avoid any potential type mistakes.
>>
>> This code was detected with the help of
On 6/30/20 9:54 PM, Evgeny Novikov wrote:
> neofb_probe() calls neo_scan_monitor() that can successfully allocate a
> memory for info->monspecs.modedb and proceed to case 0x03. There it does
> not free the memory and returns -1. neofb_probe() goes to label
> err_scan_monitor, thus, it does not
On 6/14/20 5:05 AM, Aditya Pakki wrote:
> On calling pm_runtime_get_sync() the reference count of the device
> is incremented. In case of failure, decrement the
> reference count before returning the error.
>
> Signed-off-by: Aditya Pakki
Applied to drm-misc-next tree, thanks.
Best regards,
On 7/2/20 6:05 PM, Evgeny Novikov wrote:
> fb_probe() can successfully allocate a new frame buffer, but then fail
> to perform some operations with regulator. In these cases fb_probe()
> goes to label err_pm_runtime_disable where the frame buffer is not
> released. The patch makes fb_probe() to
On 6/30/20 8:26 PM, Adam Ford wrote:
> The drm/omap driver was fixed to correct an issue where using a
> divider of 32 breaks the DSS despite the TRM stating 32 is a valid
> number. Through experimentation, it appears that 31 works, and
> it is consistent with the value used by the drm/omap
On 6/19/20 6:21 PM, Evgeny Novikov wrote:
> savagefb_probe() calls savage_init_fb_info() that can successfully
> allocate memory for info->pixmap.addr but then fail when
> fb_alloc_cmap() fails. savagefb_probe() goes to label failed_init and
> does not free allocated memory. It is not valid to
On 6/16/20 1:15 AM, Gustavo A. R. Silva wrote:
> Use array3_size() helper instead of the open-coded version in scr_memcpyw()
> and scr_memsetw(). These sorts of multiplication factors need to be wrapped
> in array3_size().
>
> This issue was found with the help of Coccinelle and, audited and
On 6/2/20 2:03 PM, Geert Uytterhoeven wrote:
> On Tue, Jun 2, 2020 at 1:50 PM Bartlomiej Zolnierkiewicz
> wrote:
>> On 5/14/20 10:21 PM, Geert Uytterhoeven wrote:
>>> These #ifdefs are relics from APUS (Amiga Power-Up System), which
>>> added a PPC board. APUS support was killed off a long
[ added dri-devel ML to Cc: ]
Hi,
Sorry for the delay.
On 5/13/20 8:48 PM, Rodrigo Alencar wrote:
> From: Rodrigo Rolim Mendes de Alencar
>
> This patch provides support for displays like VGM128064B0W10,
> which requires a column offset of 2, i.e., its segments starts
> in SEG2 and ends in
On 6/2/20 2:03 PM, Geert Uytterhoeven wrote:
> On Tue, Jun 2, 2020 at 1:52 PM Bartlomiej Zolnierkiewicz
> wrote:
>> Since we lack the hardware (or proper emulator setup) for
>> testing needed changes add FIXMEs to document the issues
>> (so at least they are not forgotten).
>>
>> Cc: Al Viro
On 6/17/20 7:56 PM, Gustavo A. R. Silva wrote:
> Make use of the struct_size() helper instead of an open-coded version
> in order to avoid any potential type mistakes.
>
> This code was detected with the help of Coccinelle and, audited and
> fixed manually.
>
> Signed-off-by: Gustavo A. R.
On Thu, Jul 9, 2020 at 11:15 PM Steev Klimaszewski wrote:
>
> Hi,
>
> On 7/9/20 11:12 PM, Doug Anderson wrote:
> >> root@c630:~# bus=$(i2cdetect -l | grep sn65 | sed
> >> 's/i2c-\([0-9]*\).*$/\1/')
> >> root@c630:~# i2cdump ${bus} 0x50 i > edid
> >> WARNING! This program can confuse your I2C
On Fri, Jul 10, 2020 at 3:48 PM Jason Gunthorpe wrote:
>
> On Fri, Jul 10, 2020 at 03:01:10PM +0200, Christian König wrote:
> > Am 10.07.20 um 14:54 schrieb Jason Gunthorpe:
> > > On Fri, Jul 10, 2020 at 02:48:16PM +0200, Christian König wrote:
> > > > Am 10.07.20 um 14:43 schrieb Jason
1 - 100 of 190 matches
Mail list logo
