Re: [RFC][PATCH 2/2] dma-heap: Add a system-uncached heap

2020-08-13 Thread John Stultz
On Mon, Aug 3, 2020 at 4:06 AM Robin Murphy wrote: > > On 2020-07-29 06:16, John Stultz wrote: > > This adds a heap that allocates non-contiguous buffers that are > > marked as writecombined, so they are not cached by the CPU. > > ... > > + ret = sg_alloc_table(new_table, table->nents,

Re: [PATCH 17/24] drm/virtio: implement blob resources: implement vram object

2020-08-13 Thread kernel test robot
://anongit.freedesktop.org/drm-intel for-linux-next config: parisc-randconfig-s031-20200813 (attached as .config) compiler: hppa-linux-gcc (GCC) 9.3.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin

Warnings with drm: Replace drm_modeset_lock/unlock_all with DRM_MODESET_LOCK_ALL_* helpers

2020-08-13 Thread Alex Deucher
The non-atomic modesetting code in amdgpu now spews warnings[1] with this patch applied. I haven't really paged the legacy locking stuff into my head in quite a while. Thoughts on how to proceed? Thanks, Alex commit 9bcaa3fe58ab7559e71df798bcff6e0795158695 Author: Michal Orzel Date: Tue

[PATCH 19/19] drm/msm: show process names in gem_describe

2020-08-13 Thread Rob Clark
From: Rob Clark In $debugfs/gem we already show any vma(s) associated with an object. Also show process names if the vma's address space is a per-process address space. Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/msm_drv.c | 2 +- drivers/gpu/drm/msm/msm_gem.c | 25

[PATCH 14/19] drm/msm: Add support to create a local pagetable

2020-08-13 Thread Rob Clark
From: Jordan Crouse Add support to create a io-pgtable for use by targets that support per-instance pagetables. In order to support per-instance pagetables the GPU SMMU device needs to have the qcom,adreno-smmu compatible string and split pagetables enabled. Signed-off-by: Jordan Crouse

[PATCH 17/19] arm: dts: qcom: sm845: Set the compatible string for the GPU SMMU

2020-08-13 Thread Rob Clark
From: Jordan Crouse Set the qcom,adreno-smmu compatible string for the GPU SMMU to enable split pagetables and per-instance pagetables for drm/msm. Signed-off-by: Jordan Crouse Signed-off-by: Rob Clark --- arch/arm64/boot/dts/qcom/sdm845.dtsi | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH 16/19] drm/msm/a6xx: Add support for per-instance pagetables

2020-08-13 Thread Rob Clark
From: Jordan Crouse Add support for using per-instance pagetables if all the dependencies are available. Signed-off-by: Jordan Crouse Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 70 +++ drivers/gpu/drm/msm/adreno/a6xx_gpu.h | 1 +

[PATCH 12/19] drm/msm: Drop context arg to gpu->submit()

2020-08-13 Thread Rob Clark
From: Jordan Crouse Now that we can get the ctx from the submitqueue, the extra arg is redundant. Signed-off-by: Jordan Crouse [split out of previous patch to reduce churny noise] Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/adreno/a5xx_gpu.c | 12 +---

[PATCH 13/19] drm/msm: Set the global virtual address range from the IOMMU domain

2020-08-13 Thread Rob Clark
From: Jordan Crouse Use the aperture settings from the IOMMU domain to set up the virtual address range for the GPU. This allows us to transparently deal with IOMMU side features (like split pagetables). Signed-off-by: Jordan Crouse Signed-off-by: Rob Clark ---

[PATCH 18/19] iommu/arm-smmu: add a way for implementations to influence SCTLR

2020-08-13 Thread Rob Clark
From: Rob Clark For the Adreno GPU's SMMU, we want SCTLR.HUPCF set to ensure that pending translations are not terminated on iova fault. Otherwise a terminated CP read could hang the GPU by returning invalid command-stream data. Signed-off-by: Rob Clark ---

[PATCH 15/19] drm/msm: Add support for private address space instances

2020-08-13 Thread Rob Clark
From: Jordan Crouse Add support for allocating private address space instances. Targets that support per-context pagetables should implement their own function to allocate private address spaces. The default will return a pointer to the global address space. Signed-off-by: Jordan Crouse

[PATCH 07/19] drm/msm: set adreno_smmu as gpu's drvdata

2020-08-13 Thread Rob Clark
From: Rob Clark This will be populated by adreno-smmu, to provide a way for coordinating enabling/disabling TTBR0 translation. Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/adreno/adreno_device.c | 2 -- drivers/gpu/drm/msm/msm_gpu.c | 2 +- drivers/gpu/drm/msm/msm_gpu.h

[PATCH 03/19] iommu/arm-smmu: Add support for split pagetables

2020-08-13 Thread Rob Clark
From: Jordan Crouse Enable TTBR1 for a context bank if IO_PGTABLE_QUIRK_ARM_TTBR1 is selected by the io-pgtable configuration. Signed-off-by: Jordan Crouse Signed-off-by: Rob Clark --- drivers/iommu/arm/arm-smmu/arm-smmu.c | 21 - drivers/iommu/arm/arm-smmu/arm-smmu.h |

[PATCH 10/19] dt-bindings: arm-smmu: Add compatible string for Adreno GPU SMMU

2020-08-13 Thread Rob Clark
From: Jordan Crouse Every Qcom Adreno GPU has an embedded SMMU for its own use. These devices depend on unique features such as split pagetables, different stall/halt requirements and other settings. Identify them with a compatible string so that they can be identified in the arm-smmu

[PATCH 09/19] iommu/arm-smmu-qcom: Add implementation for the adreno GPU SMMU

2020-08-13 Thread Rob Clark
From: Jordan Crouse Add a special implementation for the SMMU attached to most Adreno GPU target triggered from the qcom,adreno-smmu compatible string. The new Adreno SMMU implementation will enable split pagetables (TTBR1) for the domain attached to the GPU device (SID 0) and hard code it

[PATCH 02/19] iommu/arm-smmu: Pass io-pgtable config to implementation specific function

2020-08-13 Thread Rob Clark
From: Jordan Crouse Construct the io-pgtable config before calling the implementation specific init_context function and pass it so the implementation specific function can get a chance to change it before the io-pgtable is created. Signed-off-by: Jordan Crouse Signed-off-by: Rob Clark ---

[PATCH 04/19] iommu/arm-smmu: Prepare for the adreno-smmu implementation

2020-08-13 Thread Rob Clark
From: Jordan Crouse Do a bit of prep work to add the upcoming adreno-smmu implementation. Add an hook to allow the implementation to choose which context banks to allocate. Move some of the common structs to arm-smmu.h in anticipation of them being used by the implementations and update some

[PATCH 05/19] iommu: add private interface for adreno-smmu

2020-08-13 Thread Rob Clark
From: Rob Clark This interface will be used for drm/msm to coordinate with the qcom_adreno_smmu_impl to enable/disable TTBR0 translation. Once TTBR0 translation is enabled, the GPU's CP (Command Processor) will directly switch TTBR0 pgtables (and do the necessary TLB inv) synchronized to the

[PATCH 11/19] drm/msm: Add a context pointer to the submitqueue

2020-08-13 Thread Rob Clark
From: Jordan Crouse Each submitqueue is attached to a context. Add a pointer to the context to the submitqueue at create time and refcount it so that it stays around through the life of the queue. Co-developed-by: Rob Clark Signed-off-by: Jordan Crouse Signed-off-by: Rob Clark ---

[PATCH 08/19] iommu/arm-smmu: constify some helpers

2020-08-13 Thread Rob Clark
From: Rob Clark Sprinkle a few `const`s where helpers don't need write access. Signed-off-by: Rob Clark --- drivers/iommu/arm/arm-smmu/arm-smmu.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/iommu/arm/arm-smmu/arm-smmu.h

[PATCH 06/19] drm/msm/gpu: add dev_to_gpu() helper

2020-08-13 Thread Rob Clark
From: Rob Clark In a later patch, the drvdata will not directly be 'struct msm_gpu *', so add a helper to reduce the churn. Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/adreno/adreno_device.c | 10 -- drivers/gpu/drm/msm/msm_gpu.c | 6 +++---

[PATCH 01/19] drm/msm: remove dangling submitqueue references

2020-08-13 Thread Rob Clark
From: Rob Clark Currently it doesn't matter, since we free the ctx immediately. But when we start refcnt'ing the ctx, we don't want old dangling list entries to hang around. Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/msm_submitqueue.c | 4 +++- 1 file changed, 3 insertions(+), 1

[PATCH 24/24] drm/virtio: advertise features to userspace

2020-08-13 Thread Gurchetan Singh
New api changes are now available to userspace. Signed-off-by: Gurchetan Singh Acked-by: Tomeu Vizoso --- drivers/gpu/drm/virtio/virtgpu_ioctl.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/gpu/drm/virtio/virtgpu_ioctl.c b/drivers/gpu/drm/virtio/virtgpu_ioctl.c index

[PATCH 00/19] iommu/arm-smmu + drm/msm: per-process GPU pgtables

2020-08-13 Thread Rob Clark
From: Rob Clark NOTE: Since Jordan was out today, and I wanted to keep things moving on this, I took the liberty of respinning his series (originally titled "iommu/arm-smmu: Add Adreno SMMU specific implementation") with updates based on Will's review comments, and some fixes

[PATCH 19/24] drm/virtio: implement blob resources: blob display integration

2020-08-13 Thread Gurchetan Singh
SCANOUT_BLOB forwards the DRM framebuffer metadata to the host. The modifier is intentionally left out -- it may be possible to query the host for that. We also assume one blob resource per DRM framebuffer. That too is an intentional simplification. Signed-off-by: Gurchetan Singh Acked-by:

[PATCH 20/24] drm/virtio: implement blob resources: refactor UUID code somewhat

2020-08-13 Thread Gurchetan Singh
For upcoming blob resources, userspace can specify that the resource will be used for cross-device sharing. This is mainly for exportable blobs that will only shared with the virtgpu display but not across devices. Signed-off-by: Gurchetan Singh Acked-by: Tomeu Vizoso ---

[PATCH 07/24] virtio: Implement get_shm_region for MMIO transport

2020-08-13 Thread Gurchetan Singh
From: Sebastien Boeuf On MMIO a new set of registers is defined for finding SHM regions. Add their definitions and use them to find the region. Signed-off-by: Sebastien Boeuf --- drivers/virtio/virtio_mmio.c | 31 +++ include/uapi/linux/virtio_mmio.h | 11

[PATCH 23/24] drm/virtio: implement blob resources: resource create blob ioctl

2020-08-13 Thread Gurchetan Singh
From: Gerd Hoffmann Implement resource create blob as specified. Signed-off-by: Gerd Hoffmann Co-developed-by: Gurchetan Singh Signed-off-by: Gurchetan Singh Acked-by: Tomeu Vizoso --- drivers/gpu/drm/virtio/virtgpu_drv.h| 4 +- drivers/gpu/drm/virtio/virtgpu_ioctl.c | 136

[PATCH 15/24] drm/virtio: implement blob resources: expose virtio_gpu_resource_id_get

2020-08-13 Thread Gurchetan Singh
VRAM object will need it. Signed-off-by: Gurchetan Singh Acked-by: Tomeu Vizoso --- drivers/gpu/drm/virtio/virtgpu_drv.h| 2 ++ drivers/gpu/drm/virtio/virtgpu_object.c | 3 +-- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/virtio/virtgpu_drv.h

[PATCH 00/24] Blob prerequisites + blob resources

2020-08-13 Thread Gurchetan Singh
Dear all, I'm excited to share with you a breathtaking advance in the field of virtualized graphics: blob resources. Blob resources are size-based containers for host, guest, or host+guest allocations. These resources are designed with multi-process 3D support in mind, but also usable in

[PATCH 17/24] drm/virtio: implement blob resources: implement vram object

2020-08-13 Thread Gurchetan Singh
From: Gerd Hoffmann A virtio-gpu vram object is based on range-based allocation. No guest shmemfs backing, so we call drm_gem_private_object_init. This is for host memory without any guest backing (atleast initially). Signed-off-by: Gerd Hoffmann Co-developed-by: Gurchetan Singh

[PATCH 09/24] drm/virtio: blob prep: make CPU responses more generic

2020-08-13 Thread Gurchetan Singh
RESOURCE_MAP_BLOB / RESOURCE_UNMAP_BLOB can use this. Signed-off-by: Gurchetan Singh Acked-by: Tomeu Vizoso --- drivers/gpu/drm/virtio/virtgpu_drv.h | 6 +++--- drivers/gpu/drm/virtio/virtgpu_prime.c | 6 +++--- drivers/gpu/drm/virtio/virtgpu_vq.c| 10 +- 3 files changed, 11

[PATCH 22/24] drm/virtio: implement blob resources: report blob mem to userspace

2020-08-13 Thread Gurchetan Singh
The stride field has never been used, so repurpose it to be "blob_mem". This way, userspace can know the memory properties of the blob if it's passed between userspace processes and no suitable userspace API exists to transmit that knowledge. Signed-off-by: Gurchetan Singh Acked-by: Tomeu Vizoso

[PATCH 11/24] virtio-gpu api: host visible feature

2020-08-13 Thread Gurchetan Singh
From: Gerd Hoffmann This patch adds a new virtgpu feature that allows directly mapping host allocated resources. This is based on virtio shared memory regions, which allows querying for memory regions using PCI transport. Each shared memory region has an associated "shmid", the meaning of which

[PATCH 06/24] virtio: Implement get_shm_region for PCI transport

2020-08-13 Thread Gurchetan Singh
From: Sebastien Boeuf On PCI the shm regions are found using capability entries; find a region by searching for the capability. Signed-off-by: Sebastien Boeuf Signed-off-by: Dr. David Alan Gilbert --- drivers/virtio/virtio_pci_modern.c | 102 +

[PATCH 02/24] virtio: add dma-buf support for exported objects

2020-08-13 Thread Gurchetan Singh
From: David Stevens This change adds a new flavor of dma-bufs that can be used by virtio drivers to share exported objects. A virtio dma-buf can be queried by virtio drivers to obtain the UUID which identifies the underlying exported object. Signed-off-by: David Stevens ---

[PATCH 21/24] drm/virtio: implement blob resources: fix stride discrepancy

2020-08-13 Thread Gurchetan Singh
The old transfer ioctls may work on blob resources, and the guest may have a image view on the blob resources such that the stride is not equal to width * bytes_per_pixel. For host-only blobs, we can repurpose the transfer ioctls to synchronize caches as well. Also, with seamless Wayland

[PATCH 04/24] drm/virtio: Support virtgpu exported resources

2020-08-13 Thread Gurchetan Singh
From: David Stevens Add support for UUID-based resource sharing mechanism to virtgpu. This implements the new virtgpu commands and hooks them up to dma-buf's get_uuid callback. Signed-off-by: David Stevens --- drivers/gpu/drm/virtio/virtgpu_drv.c | 3 + drivers/gpu/drm/virtio/virtgpu_drv.h

[PATCH 10/24] virtio-gpu api: blob resources

2020-08-13 Thread Gurchetan Singh
From: Gerd Hoffmann A blob resource is a container for: - VIRTGPU_BLOB_MEM_GUEST: a guest memory allocation (referred to as a "guest-only blob resource") - VIRTGPU_BLOB_MEM_HOST3D: a host3d memory allocation (referred to as a "host-only blob resource") -

[PATCH 14/24] drm/virtio: implement blob resources: probe for host visible region

2020-08-13 Thread Gurchetan Singh
From: Gerd Hoffmann The availability of the host visible region means host 3D allocations can be directly mapped in the guest. Signed-off-by: Gerd Hoffmann Co-developed-by: Gurchetan Singh Signed-off-by: Gurchetan Singh Acked-by: Tomeu Vizoso --- drivers/gpu/drm/virtio/virtgpu_debugfs.c |

[PATCH 12/24] virtio-gpu api: cross-device feature

2020-08-13 Thread Gurchetan Singh
This feature was recently added to virtio-gpu, lets make it userspace queryable. Signed-off-by: Gurchetan Singh Acked-by: Tomeu Vizoso --- include/uapi/drm/virtgpu_drm.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/uapi/drm/virtgpu_drm.h b/include/uapi/drm/virtgpu_drm.h index

[PATCH 16/24] drm/virtio: implement blob resources: add new fields to internal structs

2020-08-13 Thread Gurchetan Singh
Useful for upcoming blob resources. Signed-off-by: Gurchetan Singh Acked-by: Tomeu Vizoso --- drivers/gpu/drm/virtio/virtgpu_drv.h | 17 ++--- 1 file changed, 14 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/virtio/virtgpu_drv.h b/drivers/gpu/drm/virtio/virtgpu_drv.h

[PATCH 18/24] drm/virtio: implement blob resources: hypercall interface

2020-08-13 Thread Gurchetan Singh
This implements the blob hypercall interface. Signed-off-by: Gurchetan Singh Acked-by: Tomeu Vizoso --- drivers/gpu/drm/virtio/virtgpu_drv.h | 15 +++ drivers/gpu/drm/virtio/virtgpu_vq.c | 65 2 files changed, 80 insertions(+) diff --git

[PATCH 08/24] drm/virtio: blob prep: refactor getting pages and attaching backing

2020-08-13 Thread Gurchetan Singh
Useful for upcoming blob resources. Signed-off-by: Gurchetan Singh Acked-by: Tomeu Vizoso --- drivers/gpu/drm/virtio/virtgpu_object.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/virtio/virtgpu_object.c

[PATCH 01/24] drm/virtio: Revert "drm/virtio: Call the right shmem helpers"

2020-08-13 Thread Gurchetan Singh
This reverts commit d323bb44e4d23802eb25d13de1f93f2335bd60d0. Fixes a double-free regression: [4.357928] drm_gem_shmem_free_object+0xb4/0x100 [4.358983] virtio_gpu_dequeue_ctrl_func+0xd9/0x290 [4.360343] process_one_work+0x1d2/0x3a0 [4.361581] worker_thread+0x45/0x3c0 [

[PATCH 05/24] virtio: Add get_shm_region method

2020-08-13 Thread Gurchetan Singh
From: Sebastien Boeuf Virtio defines 'shared memory regions' that provide a continuously shared region between the host and guest. Provide a method to find a particular region on a device. Signed-off-by: Sebastien Boeuf Signed-off-by: Dr. David Alan Gilbert --- include/linux/virtio_config.h

[PATCH 13/24] drm/virtio: implement blob resources: probe for the feature.

2020-08-13 Thread Gurchetan Singh
From: Gerd Hoffmann Signed-off-by: Gerd Hoffmann Signed-off-by: Gurchetan Singh Acked-by: Tomeu Vizoso --- drivers/gpu/drm/virtio/virtgpu_debugfs.c | 1 + drivers/gpu/drm/virtio/virtgpu_drv.c | 1 + drivers/gpu/drm/virtio/virtgpu_drv.h | 1 + drivers/gpu/drm/virtio/virtgpu_kms.c

[PATCH 03/24] virtio-gpu: add VIRTIO_GPU_F_RESOURCE_UUID feature

2020-08-13 Thread Gurchetan Singh
From: David Stevens This feature allows the guest to request a UUID from the host for a particular virtio_gpu resource. The UUID can then be shared with other virtio devices, to allow the other host devices to access the virtio_gpu's corresponding host resource. Signed-off-by: David Stevens

Re: [RFC][PATCH] dma-heap: Add proper kref handling on dma-buf heaps

2020-08-13 Thread John Stultz
On Thu, Aug 13, 2020 at 3:04 AM Brian Starkey wrote: > On Sat, Jul 25, 2020 at 03:26:33AM +, John Stultz wrote: > > Add proper refcounting on the dma_heap structure. > > While existing heaps are built-in, we may eventually > > have heaps loaded from modules, and we'll need to be > > able to

Re: [PATCH v4 2/2] drm: panel: Add tianma nt36672a panel driver

2020-08-13 Thread Sam Ravnborg
Hi Sumit. On Tue, Aug 11, 2020 at 11:51:07PM +0530, Sumit Semwal wrote: > Some Poco F1 phones have an LCD panel from Tianma, model nt36672a, > with a resolution of 1080x2246 that operates in DSI video mode. > > Add the drm panel driver for it. > > During testing, Benni Steini helped us fix >

Re: [PATCH] drm: panel: Fix bus format for OrtusTech COM43H4M85ULC panel

2020-08-13 Thread Sam Ravnborg
Hi Laurent. On Thu, Aug 13, 2020 at 01:02:44AM +0300, Laurent Pinchart wrote: > The OrtusTech COM43H4M85ULC panel is a 18-bit RGB panel, set the bus > format to MEDIA_BUS_FMT_RGB666_1X18. > > Fixes: 725c9d40f3fe ("drm/panel: Add support for OrtusTech COM43H4M85ULC > panel") > Signed-off-by:

[Bug 208893] Navi (RX 5700 XT) system appears to hang with more than one display connected

2020-08-13 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=208893 --- Comment #12 from Gordon (gor...@gordonite.tech) --- I'm not certain but: - uint32_t cur_value, i, timeout = adev->usec_timeout * 10; if adev_usec_timeout is the microseconds timeout, then most likely the * 10 is wrong, as the below for loop

Re: [RFC PATCH V2 2/2] drm: xlnx: dsi: driver for Xilinx DSI TX subsystem

2020-08-13 Thread Sam Ravnborg
Hi Venkateshwar On Tue, Aug 11, 2020 at 06:16:17AM +0530, Venkateshwar Rao Gannavarapu wrote: > The Xilinx MIPI DSI TX subsystem soft IP is used to display video > data from AXI-4 stream interface. > > It supports upto 4 lanes, multiple RGB color formats, video mode > and command mode. The

Re: [git pull] drm for 5.8-rc1

2020-08-13 Thread Karol Herbst
On Thu, Aug 13, 2020 at 7:45 PM James Jones wrote: > > I'll defer to Thierry, but I think that may be by design. Tegra format > modifiers were added to get things like this working in the first place, > right? It's not a regression, is it? > That would be slightly annoying as this would mean

Re: [git pull] drm for 5.8-rc1

2020-08-13 Thread James Jones
I'll defer to Thierry, but I think that may be by design. Tegra format modifiers were added to get things like this working in the first place, right? It's not a regression, is it? Thanks, -James On 8/13/20 10:19 AM, Karol Herbst wrote: another thing: with gsettings set org.gnome.mutter

[Bug 208893] Navi (RX 5700 XT) system appears to hang with more than one display connected

2020-08-13 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=208893 --- Comment #11 from Gordon (gor...@gordonite.tech) --- (In reply to Alex Deucher from comment #10) > Do things work correctly if you attach the second monitor after the system > is up and running? Yep they do indeed. -- You are receiving this

[PATCH v2 4/4] drm/msm/dp: signal the hotplug disconnect in the event handler

2020-08-13 Thread Abhinav Kumar
Signal the hotplug disconnect event to the audio side in the event handler so that they are notified earlier and have more time to process the disconnect event. Changes in v2: none Signed-off-by: Abhinav Kumar --- drivers/gpu/drm/msm/dp/dp_display.c | 20 ++-- 1 file changed,

[PATCH v2 2/4] drm/msm/dp: add audio support for Display Port on MSM

2020-08-13 Thread Abhinav Kumar
Introduce audio support for Display Port on MSM chipsets. This change integrates DP audio sub-module with the main Display Port platform driver. In addition, this change leverages hdmi_codec_ops to expose the operations to the audio driver. Changes in v2: fix up a compilation issue on drm-next

[PATCH v2 1/4] drm/msm/dp: store dp_display in the driver data

2020-08-13 Thread Abhinav Kumar
Store the dp_display in the platform driver data instead of the dp_display_private. This is required to allow other sub-modules to reuse the platform driver data. Changes in V2: none Signed-off-by: Abhinav Kumar --- drivers/gpu/drm/msm/dp/dp_display.c | 25 +++-- 1 file

[PATCH v2 0/4] Add audio support for MSM DisplayPort driver

2020-08-13 Thread Abhinav Kumar
This series adds audio support for DP on MSM chipsets. It leverages the hdmi-codec interface [1] to communicate between the Display Port driver and the audio subsystem. These changes depend on the series [2] which adds Display Port support to MSM chipsets. [1]

[PATCH v2 3/4] drm/msm/dp: add hook_plugged_cb hdmi-codec op for MSM DP driver

2020-08-13 Thread Abhinav Kumar
Add the hook_plugged_cb op for the MSM DP driver to signal connect and disconnect events to the hdmi-codec driver which in-turn shall notify the audio subsystem to start a new or teardown an existing session. Changes in v2: none Signed-off-by: Abhinav Kumar ---

Re: [git pull] drm for 5.8-rc1

2020-08-13 Thread Karol Herbst
another thing: with gsettings set org.gnome.mutter experimental-features '["kms-modifiers"]' it all just works out of the box with wayland, but that won't be enabled for quite some time, so we need to figure out what is broken (less so with my patch) under wayland with gnome :) On Thu, Aug 13,

Re: [Freedreno] [PATCH v12 07/13] drm/msm: Add a context pointer to the submitqueue

2020-08-13 Thread Rob Clark
On Mon, Aug 10, 2020 at 3:27 PM Jordan Crouse wrote: > > Each submitqueue is attached to a context. Add a pointer to the > context to the submitqueue at create time and refcount it so > that it stays around through the life of the queue. > > GPU submissions can access the active context via the

Re: [PATCH libdrm] INTEL: Add PCI ID support to RKL platform

2020-08-13 Thread Matt Roper
Reviewed-by: Matt Roper On Thu, Aug 13, 2020 at 11:03:38AM +0530, ssermsix wrote: > --- > intel/intel_chipset.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/intel/intel_chipset.c b/intel/intel_chipset.c > index f6e37ee7..c3ce8f51 100644 > --- a/intel/intel_chipset.c > +++

Re: [PATCH v1 2/4] drm/ast: Set display mode in atomic_begin()

2020-08-13 Thread Sasha Levin
Hi [This is an automated email] This commit has been processed because it contains a "Fixes:" tag fixing commit: 4961eb60f145 ("drm/ast: Enable atomic modesetting"). The bot has tested the following trees: v5.8, v5.7.14. v5.8: Failed to apply! Possible dependencies: 05f13f5b5996 ("drm/ast:

Re: [PATCH v1 1/4] drm/ast: Only set format registers if primary plane's format changes

2020-08-13 Thread Sasha Levin
Hi [This is an automated email] This commit has been processed because it contains a "Fixes:" tag fixing commit: 4961eb60f145 ("drm/ast: Enable atomic modesetting"). The bot has tested the following trees: v5.8, v5.7.14. v5.8: Failed to apply! Possible dependencies: 05f13f5b5996 ("drm/ast:

Re: [PATCH v1 4/4] drm/ast: Disable planes while switching display modes

2020-08-13 Thread Sasha Levin
Hi [This is an automated email] This commit has been processed because it contains a "Fixes:" tag fixing commit: 4961eb60f145 ("drm/ast: Enable atomic modesetting"). The bot has tested the following trees: v5.8, v5.7.14. v5.8: Failed to apply! Possible dependencies: 05f13f5b5996 ("drm/ast:

Re: [PATCH v1 3/4] drm/ast: Add commit-tail function

2020-08-13 Thread Sasha Levin
Hi [This is an automated email] This commit has been processed because it contains a "Fixes:" tag fixing commit: 4961eb60f145 ("drm/ast: Enable atomic modesetting"). The bot has tested the following trees: v5.8, v5.7.14. v5.8: Failed to apply! Possible dependencies: 05f13f5b5996 ("drm/ast:

Re: [Freedreno] [PATCH v12 07/13] drm/msm: Add a context pointer to the submitqueue

2020-08-13 Thread Rob Clark
On Mon, Aug 10, 2020 at 3:27 PM Jordan Crouse wrote: > > Each submitqueue is attached to a context. Add a pointer to the > context to the submitqueue at create time and refcount it so > that it stays around through the life of the queue. > > GPU submissions can access the active context via the

Re: [git pull] drm for 5.8-rc1

2020-08-13 Thread Karol Herbst
btw, I just noticed that wayland with gnome-shell is totally busted. With this MR it at least displays something, but without it doesn't work at all. On Thu, Aug 13, 2020 at 3:00 PM Karol Herbst wrote: > > At least for now I've created an MR to revert the change: >

[Bug 208893] Navi (RX 5700 XT) system appears to hang with more than one display connected

2020-08-13 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=208893 Alex Deucher (alexdeuc...@gmail.com) changed: What|Removed |Added CC|

Re: [PATCH v2 0/5] Fixes and improvements for Xen pvdrm

2020-08-13 Thread Jürgen Groß
On 13.08.20 17:10, Oleksandr Andrushchenko wrote: On 8/13/20 6:02 PM, Jürgen Groß wrote: On 13.08.20 08:21, Oleksandr Andrushchenko wrote: From: Oleksandr Andrushchenko Series pushed to: xen/tip.git for-linus-5.9 The top patch has strange title though: "Subject: [PATCH v2 5/5]

Re: [PATCH v2 0/5] Fixes and improvements for Xen pvdrm

2020-08-13 Thread Jürgen Groß
On 13.08.20 08:21, Oleksandr Andrushchenko wrote: From: Oleksandr Andrushchenko Series pushed to: xen/tip.git for-linus-5.9 Juergen ___ dri-devel mailing list dri-devel@lists.freedesktop.org

Re: [PATCH v2 2/4] drm/gem: Update client API to use struct drm_gem_membuf

2020-08-13 Thread Daniel Vetter
On Thu, Aug 13, 2020 at 12:46 PM Thomas Zimmermann wrote: > > Hi > > Am 13.08.20 um 12:26 schrieb Daniel Vetter: > > On Thu, Aug 06, 2020 at 10:52:37AM +0200, Thomas Zimmermann wrote: > >> GEM's vmap interface now wraps memory pointers in struct drm_gem_membuf. > >> The structure represents a

Re: [PATCH 19/20] drm/xlnx: Initialize DRM driver instance with CMA helper macro

2020-08-13 Thread Thomas Zimmermann
Hi Am 13.08.20 um 15:36 schrieb Laurent Pinchart: > Hi Thomas, > > Thank you for the patch. > > On Thu, Aug 13, 2020 at 10:36:43AM +0200, Thomas Zimmermann wrote: >> The xlnx driver uses CMA helpers with default callback functions. >> Initialize the driver structure with the rsp CMA helper

[PATCH v3 0/4] drm/ast: Disable HW cursor when switching modes

2020-08-13 Thread Thomas Zimmermann
Since converting the ast driver to atomic modesettting, modesetting occationally locks up the graphics hardware and turns the display permanently dark. This happens once or twice per 10 mode switches. Investigation shows that the ast hardware presumably requires the HW cursor to be disabled while

[PATCH v3 4/4] drm/ast: Enable CRTC before planes

2020-08-13 Thread Thomas Zimmermann
An active cursor plane requires a valid display mode. Change the commit_tail callback, so that it sets up the CRTC's mode before updating planes. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/ast/ast_mode.c | 7 +++ 1 file changed, 7 insertions(+) diff --git

[PATCH v3 1/4] drm/ast: Set format registers in primary plane's update

2020-08-13 Thread Thomas Zimmermann
The atomic modesetting code tried to distinguish format changes from full modesetting operations. But the implementation was buggy and the format registers were often updated even for simple pageflips. Fix this problem by handling format changes in the primary plane's update function. v3:

[PATCH v3 2/4] drm/ast: Disable planes while switching display modes

2020-08-13 Thread Thomas Zimmermann
The ast HW cursor requires the primary plane and CRTC to display at a valid mode and format. This is not the case while switching display modes, which can lead to the screen turing permanently dark. As a workaround, the ast driver now disables active planes while the mode or format switch takes

[PATCH v3 3/4] drm/ast: Program display mode in CRTC's atomic_enable()

2020-08-13 Thread Thomas Zimmermann
This change simplifies ast's modesetting code. The display mode is now programmed from within the CRTC's atomic_enable(), which only runs if we actually want to program the mode. Corresponding code in atomic_flush() is being removed. Also removed is atomic_begin(), which serves no purpose at all.

Re: [PATCH 2/3] backlight: pwm_bl: Artificially add 0% during interpolation

2020-08-13 Thread Daniel Thompson
On Fri, Aug 07, 2020 at 10:21:13AM +0200, dan...@ffwll.ch wrote: > On Mon, Jul 20, 2020 at 09:25:21PM -0700, Alexandru Stan wrote: > > Some displays need the low end of the curve cropped in order to make > > them happy. In that case we still want to have the 0% point, even though > > anything

Re: [PATCH 10/20] drm/omapdrm: Introduce GEM object functions

2020-08-13 Thread Laurent Pinchart
Hi Thomas, Thank you for the patch. On Thu, Aug 13, 2020 at 10:36:34AM +0200, Thomas Zimmermann wrote: > GEM object functions deprecate several similar callback interfaces in > struct drm_driver. This patch replaces the per-driver callbacks with > per-instance callbacks in omapdrm. > >

Re: [PATCH 19/20] drm/xlnx: Initialize DRM driver instance with CMA helper macro

2020-08-13 Thread Laurent Pinchart
Hi Thomas, Thank you for the patch. On Thu, Aug 13, 2020 at 10:36:43AM +0200, Thomas Zimmermann wrote: > The xlnx driver uses CMA helpers with default callback functions. > Initialize the driver structure with the rsp CMA helper macro. The > driver is being converted to use GEM object functions

Re: [PATCH v12 00/13] iommu/arm-smmu: Add Adreno SMMU specific implementation

2020-08-13 Thread Will Deacon
On Mon, Aug 10, 2020 at 04:26:44PM -0600, Jordan Crouse wrote: > This series adds an Adreno SMMU implementation to arm-smmu to allow GPU > hardware > pagetable switching. > > The Adreno GPU has built in capabilities to switch the TTBR0 pagetable during > runtime to allow each individual instance

Re: [PATCH] drm/nouveau/gem: Use vmemdup_user() rather than duplicating its implementation

2020-08-13 Thread kernel test robot
Hi Markus, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on drm-intel/for-linux-next] [also build test WARNING on drm-tip/drm-tip tegra-drm/drm/tegra/for-next linus/master drm/drm-next drm-exynos/exynos-drm-next v5.8 next-20200812] [If your patch is applied to

[PATCH] drm/nouveau/gem: fix err_cast.cocci warnings

2020-08-13 Thread kernel test robot
From: kernel test robot drivers/gpu/drm/nouveau/nouveau_gem.c:589:9-16: WARNING: ERR_CAST can be used with mem Use ERR_CAST inlined function instead of ERR_PTR(PTR_ERR(...)) Generated by: scripts/coccinelle/api/err_cast.cocci CC: Markus Elfring Signed-off-by: kernel test robot --- url:

Re: [git pull] drm for 5.8-rc1

2020-08-13 Thread Karol Herbst
At least for now I've created an MR to revert the change: https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6300 But it seems like there was probably a good reason why it got added? Happy to have better fixes, but that's the best we've got so far I think? Thierry, what do you think? On

Re: [PATCH 9/9] arm64: dts: renesas: r8a774e1-hihope-rzg2h: Setup DU clocks

2020-08-13 Thread Laurent Pinchart
On Wed, Aug 12, 2020 at 07:36:54PM +0300, Laurent Pinchart wrote: > Hi Prabhakar, > > Thank you for the patch. > > On Wed, Aug 12, 2020 at 03:02:17PM +0100, Lad Prabhakar wrote: > > Setup up the required clocks for the DU to be functional. > > > > Signed-off-by: Lad Prabhakar > > --- > >

Re: [PATCH] drm/nouveau: Add fine-grain temperature reporting

2020-08-13 Thread Karol Herbst
Reviewed-by: Karol Herbst On Wed, Aug 12, 2020 at 10:50 PM Jeremy Cline wrote: > > Commit d32656373857 ("drm/nouveau/therm/gp100: initial implementation of > new gp1xx temperature sensor") added support for reading finer-grain > temperatures, but continued to report temperatures in 1 degree

Re: [PATCH] drm/malidp: Use struct drm_gem_object_funcs.get_sg_table internally

2020-08-13 Thread Daniel Vetter
On Thu, Aug 13, 2020 at 12:39 PM Thomas Zimmermann wrote: > > Hi > > Am 13.08.20 um 12:31 schrieb Daniel Vetter: > > On Thu, Aug 13, 2020 at 12:28:55PM +0200, Thomas Zimmermann wrote: > >> > >> > >> Am 13.08.20 um 11:48 schrieb Daniel Vetter: > >>> On Thu, Aug 13, 2020 at 11:19:31AM +0200, Thomas

Re: [PATCH] dt-bindings: Whitespace clean-ups in schema files

2020-08-13 Thread Luca Ceresoli
Hi Rob, On 12/08/20 22:36, Rob Herring wrote: > Clean-up incorrect indentation, extra spaces, long lines, and missing > EOF newline in schema files. Most of the clean-ups are for list > indentation which should always be 2 spaces more than the preceding > keyword. > > Found with yamllint (which

Re: [PATCH v4 2/2] xen: add helpers to allocate unpopulated memory

2020-08-13 Thread Roger Pau Monné
On Wed, Aug 12, 2020 at 09:28:45AM +0200, Jürgen Groß wrote: > On 11.08.20 11:44, Roger Pau Monne wrote: > > To be used in order to create foreign mappings. This is based on the > > ZONE_DEVICE facility which is used by persistent memory devices in > > order to create struct pages and kernel

Re: [PATCH v2 0/5] Fixes and improvements for Xen pvdrm

2020-08-13 Thread Oleksandr Andrushchenko
Juergen, Boris, can we please merge these via Xen Linux tree as I have collected enough Ack/R-b? The series has DRM patches, but those anyway are Xen related, so I think this should be fine from DRI point of view. Thank you, Oleksandr On 8/13/20 9:21 AM, Oleksandr Andrushchenko wrote: >

Re: [PATCH 1/9] dt-bindings: display: renesas,du: Document r8a774e1 bindings

2020-08-13 Thread Laurent Pinchart
Hi Prabhakar, On Thu, Aug 13, 2020 at 12:08:58PM +0100, Lad, Prabhakar wrote: > On Thu, Aug 13, 2020 at 11:59 AM Laurent Pinchart wrote: > > On Thu, Aug 13, 2020 at 11:38:03AM +0100, Lad, Prabhakar wrote: > >> On Thu, Aug 13, 2020 at 10:05 AM Geert Uytterhoeven wrote: > >>> On Wed, Aug 12, 2020

Re: [PATCH 1/3 v2] dt-bindings: backlight: Add some common backlight properties

2020-08-13 Thread Daniel Thompson
On Wed, Aug 12, 2020 at 10:58:48AM +0200, Linus Walleij wrote: > Let's use a common.yaml include for the backlight like we do with > the LEDs. The LEDs are inherently incompatible so their bindings > cannot be reused for backlight. > > Cc: devicet...@vger.kernel.org > Suggested-by: Sam Ravnborg

Re: [PATCH 1/9] dt-bindings: display: renesas,du: Document r8a774e1 bindings

2020-08-13 Thread Laurent Pinchart
Hello, On Thu, Aug 13, 2020 at 11:38:03AM +0100, Lad, Prabhakar wrote: > On Thu, Aug 13, 2020 at 10:05 AM Geert Uytterhoeven wrote: > > On Wed, Aug 12, 2020 at 4:02 PM Lad Prabhakar wrote: > > > From: Marian-Cristian Rotariu > > > > > > Document the RZ/G2H (a.k.a. r8a774e1) SoC in the R-Car DU

Re: [PATCH 2/3 v2] dt-bindings: backlight: Add Kinetic KTD253 bindings

2020-08-13 Thread Daniel Thompson
On Wed, Aug 12, 2020 at 10:58:49AM +0200, Linus Walleij wrote: > This adds device tree bindings for the Kinetic KTD253 > white LED backlight driver. > > Cc: devicet...@vger.kernel.org > Cc: Sam Ravnborg > Signed-off-by: Linus Walleij > --- > ChangeLog v1->v2: > - Create common.yaml for

Re: [PATCH 12/20] drm/radeon: Introduce GEM object functions

2020-08-13 Thread Christian König
Am 13.08.20 um 12:41 schrieb Thomas Zimmermann: Hi Am 13.08.20 um 12:24 schrieb Christian König: Am 13.08.20 um 10:36 schrieb Thomas Zimmermann: GEM object functions deprecate several similar callback interfaces in struct drm_driver. This patch replaces the per-driver callbacks with

Re: [PATCH v2 2/4] drm/gem: Update client API to use struct drm_gem_membuf

2020-08-13 Thread Thomas Zimmermann
Hi Am 13.08.20 um 12:26 schrieb Daniel Vetter: > On Thu, Aug 06, 2020 at 10:52:37AM +0200, Thomas Zimmermann wrote: >> GEM's vmap interface now wraps memory pointers in struct drm_gem_membuf. >> The structure represents a pointer into the framebuffer, which is either >> in I/O memory or in system

Re: [PATCH 4/6] drm/rockchip: dw_hdmi: Add vendor hdmi properties

2020-08-13 Thread Laurent Pinchart
On Thu, Aug 13, 2020 at 10:42:28AM +0300, Pekka Paalanen wrote: > On Wed, 12 Aug 2020 16:30:17 +0300 Laurent Pinchart wrote: > > On Wed, Aug 12, 2020 at 07:08:10PM +0800, crj wrote: > > > 在 2020/8/12 17:33, Laurent Pinchart 写道: > > > > On Wed, Aug 12, 2020 at 04:35:43PM +0800, Algea Cao wrote:

  1   2   3   >