Re: [v4,1/3] drm/msm: Add support for GPU cooling

2020-10-29 Thread Akhil P Oommen
On 10/30/2020 2:18 AM, m...@chromium.org wrote: On Thu, Oct 29, 2020 at 01:37:19PM +0530, Akhil P Oommen wrote: Register GPU as a devfreq cooling device so that it can be passively cooled by the thermal framework. Signed-off-by: Akhil P Oommen Reviewed-by: Matthias Kaehlcke Wait, I did not

RE: [PATCH -next] drm/amdgpu/swsmu: Remove unused static struct 'navi10_i2c_algo'

2020-10-29 Thread Quan, Evan
[AMD Official Use Only - Internal Distribution Only] Other used APIs should be also dropped together. navi10_i2c_func() navi10_i2c_xfer() navi10_i2c_write_data() navi10_i2c_read_data() Regards, Evan -Original Message- From: amd-gfx On Behalf Of Zou Wei Sent: Thursday, October 29, 2020

linux-next: Fixes tag needs some work in the drm-fixes tree

2020-10-29 Thread Stephen Rothwell
Hi all, In commit 65d437b83b2b ("drm/amdgpu/pm: fix the fan speed in fan1_input in manual mode for navi1x") Fixes tag Fixes: 3033e9f1c2de ("drm/amdgpu/swsmu: handle manual fan readback on SMU11") has these problem(s): - Target SHA1 does not exist Mayne you meant Fixes: f6eb433954bf

Re: [PATCH] drivers: amdgpu: Correct spelling defalut to default in comment

2020-10-29 Thread Alex Deucher
Applied. Thanks! Alex On Thu, Oct 29, 2020 at 9:17 AM Bhaskar Chowdhury wrote: > > Correct spelling in one of the comment. > > s/defalut/default/p > > Signed-off-by: Bhaskar Chowdhury > --- > CCing Greg becasue it touched drivers file. Trivial though. > >

Re: [PATCH v4 7/7] dma-buf: system_heap: Add a system-uncached heap re-using the system heap

2020-10-29 Thread John Stultz
On Thu, Oct 29, 2020 at 7:48 PM Hillf Danton wrote: > On Thu, 29 Oct 2020 15:28:34 -0700 John Stultz wrote: > > On Thu, Oct 29, 2020 at 12:10 AM Hillf Danton wrote: > > > On Thu, 29 Oct 2020 00:16:24 + John Stultz wrote: > > > > @@ -194,6 +210,9 @@ static int system_heap_mmap(struct dma_buf

Re: [PATCH 4/5] drm/amdgpu: fix build_coefficients() argument

2020-10-29 Thread Alex Deucher
On Mon, Oct 26, 2020 at 5:01 PM Arnd Bergmann wrote: > > From: Arnd Bergmann > > gcc -Wextra warns about a function taking an enum argument > being called with a bool: > > drivers/gpu/drm/amd/amdgpu/../display/modules/color/color_gamma.c: In > function 'apply_degamma_for_user_regamma': >

Re: [PATCH 2/5] drm/amdgpu: fix incorrect enum type

2020-10-29 Thread Alex Deucher
Applied. Thanks! Alex On Mon, Oct 26, 2020 at 5:01 PM Arnd Bergmann wrote: > > From: Arnd Bergmann > > core_link_write_dpcd() returns enum dc_status, not ddc_result: > > display/dc/core/dc_link_dp.c: In function 'dp_set_panel_mode': > display/dc/core/dc_link_dp.c:4237:11: warning: implicit

Re: [PATCH] drm/amd/display: remove unneeded semicolon

2020-10-29 Thread Alex Deucher
Applied. Thanks! Alex On Tue, Oct 27, 2020 at 4:07 PM wrote: > > From: Tom Rix > > A semicolon is not needed after a switch statement. > > Signed-off-by: Tom Rix > --- > drivers/gpu/drm/amd/display/dc/dce112/dce112_resource.c | 2 +- > drivers/gpu/drm/amd/display/modules/hdcp/hdcp_log.c

Re: [PATCH] drm/amdgpu: remove unneeded semicolon

2020-10-29 Thread Alex Deucher
Applied. I dropped the first hunk as that fix had already been submitted by someone else. Alex On Tue, Oct 27, 2020 at 3:07 PM wrote: > > From: Tom Rix > > A semicolon is not needed after a switch statement. > > Signed-off-by: Tom Rix > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_pmu.c | 2 +- >

Re: [PATCH v4 5/7] dma-buf: system_heap: Allocate higher order pages if available

2020-10-29 Thread John Stultz
On Thu, Oct 29, 2020 at 7:34 PM Hillf Danton wrote: > On Thu, 29 Oct 2020 12:34:51 -0700 John Stultz wrote: > > As for your comment on HPAGE_PMD_ORDER (9 on arm64/arm) and > > PAGE_ALLOC_COSTLY_ORDER(3), I'm not totally sure I understand your > > question? Are you suggesting those values would be

[git pull] drm fixes for 5.10-rc2

2020-10-29 Thread Dave Airlie
Hi Linus, A busier rc2 than normal, have larger sets of fixes for amdgpu + nouveau, along with some i915, docs, core, panel, sun4i, v3d, vc4 fixes. Nothing spooky though or pumpkin related. Dave. drm-fixes-2020-10-30-1: drm fixes for 5.10-rc2 docs: - kernel doc fixes core: - fix shmem

Re: [PATCH 1/4] drm: allow drm_atomic_print_state() to accept any drm_printer

2020-10-29 Thread abhinavk
Hi Daniel On 2020-10-22 03:38, Daniel Vetter wrote: On Wed, Oct 21, 2020 at 10:01:45PM -0700, Abhinav Kumar wrote: Currently drm_atomic_print_state() internally allocates and uses a drm_info printer. Allow it to accept any drm_printer type so that the API can be leveraged even for taking drm

[PATCH v2 3/4] drm/msm: register the base address with dpu_dbg module

2020-10-29 Thread Abhinav Kumar
Register the base address of various dpu sub-modules with the dpu_dbg module so that it can be dumped out during error scenarios. changes in v2: - Fix an issue where the same dsi client was getting registered multiple times to the dpu_dbg module Signed-off-by: Abhinav Kumar ---

[PATCH v2 2/4] drm/msm/dpu: add support to dump dpu registers

2020-10-29 Thread Abhinav Kumar
Add the dpu_dbg module which adds supports to dump dpu registers which can be used in case of error conditions. changes in v2: Fix kbot errors Reported-by: kernel test robot Signed-off-by: Abhinav Kumar --- drivers/gpu/drm/msm/Makefile | 2 +

[PATCH v2 4/4] drm/msm/dpu: add dpu_dbg points across dpu driver

2020-10-29 Thread Abhinav Kumar
Add dpu_dbg points across dpu driver to trigger dumps when critical errors are hit. changes in v2: none Signed-off-by: Abhinav Kumar --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 12 ++-- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c | 5 +++--

[PATCH v2 1/4] drm: allow drm_atomic_print_state() to accept any drm_printer

2020-10-29 Thread Abhinav Kumar
Currently drm_atomic_print_state() internally allocates and uses a drm_info printer. Allow it to accept any drm_printer type so that the API can be leveraged even for taking drm snapshot. Rename the drm_atomic_print_state() to drm_atomic_print_new_state() so that it reflects its functionality

[PATCH v2 0/4] Add devcoredump support for DPU

2020-10-29 Thread Abhinav Kumar
This series adds support to use devcoredump for DPU driver. It introduces the dpu_dbg module which assists in the capturing of register dumps during error scenarios. When a display related error happens, the dpu_dbg module captures all the relevant register dumps along with the snapshot of the drm

[PULL] drm-intel-fixes

2020-10-29 Thread Rodrigo Vivi
Hi Dave and Daniel, Only 3 patches on this first round. I had blocked a few patches because CI results were strange and I had blocked GVT pull request for having a bad-formatted commit message. So we might see a bigger number of patches next week. Thanks, Rodrigo. drm-intel-fixes-2020-10-29: -

Re: [PATCH 3/3] drm/qxl: Remove fbcon acceleration leftovers

2020-10-29 Thread kernel test robot
Hi Daniel, I love your patch! Perhaps something to improve: [auto build test WARNING on drm-intel/for-linux-next] [also build test WARNING on drm-exynos/exynos-drm-next tegra-drm/drm/tegra/for-next linus/master v5.10-rc1 next-20201029] [If your patch is applied to the wrong git tree, kindly

[PATCH] fbdev/sh_mobile: Drop unused include

2020-10-29 Thread Linus Walleij
The driver includes but doesn't use any symbols from this file. Cc: Magnus Damm Cc: Geert Uytterhoeven Cc: linux-renesas-...@vger.kernel.org Signed-off-by: Linus Walleij --- drivers/video/fbdev/sh_mobile_lcdcfb.c | 1 - 1 file changed, 1 deletion(-) diff --git

[PATCH v7] backlight: lms283gf05: Convert to GPIO descriptors

2020-10-29 Thread Linus Walleij
This converts the lms283gf05 backlight driver to use GPIO descriptors and switches the single PXA Palm Z2 device over to defining these. Since the platform data was only used to convey GPIO information we can delete the platform data header. Notice that we define the proper active low semantics

[Bug 209457] AMDGPU resume fail with RX 580 GPU

2020-10-29 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=209457 Robert M. Muncrief (rmuncr...@humanavance.com) changed: What|Removed |Added Kernel Version|5.8.12 to 5.9-rc6 |5.8.12

linux-next: build failure after merge of the drm-misc tree

2020-10-29 Thread Stephen Rothwell
=implicit-function-declaration] 320 | need_swiotlb = !!swiotlb_nr_tbl(); | ^~ Caused by commit ee5d2a8e549e ("drm/ttm: wire up the new pool as default one v2") I have used the drm-misc tree from next-20201029 for today. -- Cheers, Stephe

[Bug 209457] AMDGPU resume fail with RX 580 GPU

2020-10-29 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=209457 --- Comment #13 from Robert M. Muncrief (rmuncr...@humanavance.com) --- (In reply to dark_sylinc from comment #12) > Btw I reported that I was experiencing this too in my RX 560, however for me > it went away with 5.8.15 > > I think my problem

[PULL] nouveau-fixes 5.10

2020-10-29 Thread Ben Skeggs
The following changes since commit 3650b228f83adda7e5ee532e2b90429c03f7b9ec: Linux 5.10-rc1 (2020-10-25 15:14:11 -0700) are available in the Git repository at: git://github.com/skeggsb/linux linux-5.10 for you to fetch changes up to d7787cc04e0a1f2043264d1550465081096bd065:

[Bug 209457] AMDGPU resume fail with RX 580 GPU

2020-10-29 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=209457 --- Comment #12 from dark_syl...@yahoo.com.ar --- Btw I reported that I was experiencing this too in my RX 560, however for me it went away with 5.8.15 I think my problem was unrelated to the one in this ticket, sorry. Btw it may be worth

[Bug 209457] AMDGPU resume fail with RX 580 GPU

2020-10-29 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=209457 --- Comment #11 from Robert M. Muncrief (rmuncr...@humanavance.com) --- This bug still exists in kernel 5.10-rc1. -- You are receiving this mail because: You are watching the assignee of the bug. ___

Re: [PATCH 2/5] drm/tidss: Set bus_format correctly from bridge/connector

2020-10-29 Thread Laurent Pinchart
Hi Nikhil, Thank you for the patch. On Fri, Oct 16, 2020 at 04:09:14PM +0530, Nikhil Devshatwar wrote: > When there is a chain of bridges attached to the encoder, > the bus_format should be ideally set from the input format of the > first bridge in the chain. > > Use the bridge state to get the

Re: [PATCH 1/5] drm/tidss: Move to newer connector model

2020-10-29 Thread Laurent Pinchart
Hi Nikhil, Thank you for the patch. On Fri, Oct 16, 2020 at 04:09:13PM +0530, Nikhil Devshatwar wrote: > To be able to support connector operations across multiple > bridges, it is recommended that the connector should be > created by the SoC driver instead of the bridges. > > Modify the tidss

Re: [PATCH 3/5] drm: bridge: Propagate the bus flags from bridge->timings

2020-10-29 Thread Laurent Pinchart
Hello, On Wed, Oct 28, 2020 at 08:04:53PM +0530, Nikhil Devshatwar wrote: > On 14:31-20201021, Tomi Valkeinen wrote: > > On 16/10/2020 13:39, Nikhil Devshatwar wrote: > > > When the next bridge does not specify any bus flags, use the > > > bridge->timings->input_bus_flags as fallback when

Re: [PATCH 5/5] drm/bridge: mhdp8564: Support format negotiation

2020-10-29 Thread Laurent Pinchart
Hi Nikhil, Thank you for the patch. On Fri, Oct 16, 2020 at 04:09:17PM +0530, Nikhil Devshatwar wrote: > With new connector model, mhdp bridge will not create the connector and > SoC driver will rely on format negotiation to setup the encoder format. > > Support format negotiations hooks in the

Re: [PATCH 4/5] drm/bridge: tfp410: Support format negotiation

2020-10-29 Thread Laurent Pinchart
Hi Nikhil, Thank you for the patch. On Fri, Oct 16, 2020 at 04:09:16PM +0530, Nikhil Devshatwar wrote: > With new connector model, tfp410 will not create the connector and > SoC driver will rely on format negotiation to setup the encoder format. > > Support format negotiations hooks in the

Re: [PATCH v10 5/6] drm/kmb: Mipi DSI part of the display driver

2020-10-29 Thread Sam Ravnborg
Hi Anitha et all. On Thu, Oct 29, 2020 at 02:27:56PM -0700, Anitha Chrisanthus wrote: > Initializes Mipi DSI and sets up connects to ADV bridge > > v2: removed license text > upclassed dev_private, removed HAVE_IRQ. (Sam) > > v3: Squashed all 59 commits to one > > v4: review changes from

Re: [PATCH v10 6/6] drm/kmb: Build files for KeemBay Display driver

2020-10-29 Thread Sam Ravnborg
On Thu, Oct 29, 2020 at 02:27:57PM -0700, Anitha Chrisanthus wrote: > v2: Added Maintainer entry > v3: Added one more Maintainer entry > v3: drop videomode_helpers > > Cc: Sam Ravnborg > Signed-off-by: Anitha Chrisanthus > Reviewed-by: Bob Paauwe Reviewed-by: Sam Ravnborg

Re: [PATCH v4 7/7] dma-buf: system_heap: Add a system-uncached heap re-using the system heap

2020-10-29 Thread John Stultz
On Thu, Oct 29, 2020 at 12:10 AM Hillf Danton wrote: > On Thu, 29 Oct 2020 00:16:24 + John Stultz wrote: > > @@ -194,6 +210,9 @@ static int system_heap_mmap(struct dma_buf *dmabuf, > > struct vm_area_struct *vma) > > struct sg_page_iter piter; > > int ret; > > > > + if

Re: [PATCH v10 4/6] drm/kmb: Add support for KeemBay Display

2020-10-29 Thread Sam Ravnborg
Hi Anitha, On Thu, Oct 29, 2020 at 02:27:55PM -0700, Anitha Chrisanthus wrote: > This is a basic KMS atomic modesetting display driver for KeemBay family of > SOCs. Driver has no 2D or 3D graphics. It calls into the ADV bridge > driver at the connector level. > > Single CRTC with LCD

Re: [PATCH v10 3/6] drm/kmb: Keem Bay driver register definition

2020-10-29 Thread Sam Ravnborg
Hi Anitha. On Thu, Oct 29, 2020 at 02:27:54PM -0700, Anitha Chrisanthus wrote: > Register definitions for Keem Bay display driver > > v2: removed license text (Sam) > v3: Squashed all 59 commits to one > v4: review changes from Sam Ravnborg > renamed dev_p to kmb > v5: corrected spellings

Re: [PATCH v10 2/6] dt-bindings: display: bridge: Intel KeemBay DSI

2020-10-29 Thread Sam Ravnborg
Hi Anitha. On Thu, Oct 29, 2020 at 02:27:53PM -0700, Anitha Chrisanthus wrote: > This patch adds bindings for Intel KeemBay MIPI DSI > > Signed-off-by: Anitha Chrisanthus > Cc: Sam Ravnborg > Cc: Thomas Zimmermann > Cc: Daniel Vetter This again matches my understanding of the HW - good.

Re: [PATCH v10 1/6] dt-bindings: display: Add support for Intel KeemBay Display

2020-10-29 Thread Sam Ravnborg
Hi Anitha. On Thu, Oct 29, 2020 at 02:27:52PM -0700, Anitha Chrisanthus wrote: > This patch adds bindings for Intel KeemBay Display > > v2: review changes from Rob Herring > v3: review changes from Sam Ravnborg (removed mipi dsi entries, and > encoder entry, connect port to dsi) > MSSCAM

Re: [PATCH][next] drm/amd/pm: fix out-of-bound read on pptable->SkuReserved

2020-10-29 Thread Alex Deucher
Applied. Thanks! On Wed, Oct 28, 2020 at 8:43 AM Colin King wrote: > > From: Colin Ian King > > A recent change added two uint16_t elements to PPTable_t and reduced the > uint32_t array down to 8 elements. This results in the dev_info printing > of pptable->SkuReserved[8] accessing a value

Re: [PATCH -next] drm/amd/display: remove useless if/else

2020-10-29 Thread Alex Deucher
Applied. Thanks! Alex On Wed, Oct 28, 2020 at 2:56 PM Zou Wei wrote: > > Fix the following coccinelle report: > > ./drivers/gpu/drm/amd/display/dc/calcs/dce_calcs.c:1367:3-5: > WARNING: possible condition with no effect (if == else) > > Both branches are the same, so remove the if/else

[PATCH v10 5/6] drm/kmb: Mipi DSI part of the display driver

2020-10-29 Thread Anitha Chrisanthus
Initializes Mipi DSI and sets up connects to ADV bridge v2: removed license text upclassed dev_private, removed HAVE_IRQ. (Sam) v3: Squashed all 59 commits to one v4: review changes from Sam Ravnborg renamed dev_p to kmb v5: corrected spellings v6: corrected checkpatch warnings v7:

[PATCH v10 3/6] drm/kmb: Keem Bay driver register definition

2020-10-29 Thread Anitha Chrisanthus
Register definitions for Keem Bay display driver v2: removed license text (Sam) v3: Squashed all 59 commits to one v4: review changes from Sam Ravnborg renamed dev_p to kmb v5: corrected spellings v6: corrected checkpatch warnings v7: removed redundant definitions v8: removed redundant

[PATCH v10 4/6] drm/kmb: Add support for KeemBay Display

2020-10-29 Thread Anitha Chrisanthus
This is a basic KMS atomic modesetting display driver for KeemBay family of SOCs. Driver has no 2D or 3D graphics. It calls into the ADV bridge driver at the connector level. Single CRTC with LCD controller->mipi DSI->ADV bridge Only 1080p resolution and single plane is supported at this time.

[PATCH v10 2/6] dt-bindings: display: bridge: Intel KeemBay DSI

2020-10-29 Thread Anitha Chrisanthus
This patch adds bindings for Intel KeemBay MIPI DSI Signed-off-by: Anitha Chrisanthus Cc: Sam Ravnborg Cc: Thomas Zimmermann Cc: Daniel Vetter --- .../bindings/display/bridge/intel,keembay-dsi.yaml | 101 + 1 file changed, 101 insertions(+) create mode 100644

[PATCH v10 6/6] drm/kmb: Build files for KeemBay Display driver

2020-10-29 Thread Anitha Chrisanthus
v2: Added Maintainer entry v3: Added one more Maintainer entry v3: drop videomode_helpers Cc: Sam Ravnborg Signed-off-by: Anitha Chrisanthus Reviewed-by: Bob Paauwe --- MAINTAINERS | 7 +++ drivers/gpu/drm/Kconfig | 2 ++ drivers/gpu/drm/Makefile | 1 +

[PATCH v10 1/6] dt-bindings: display: Add support for Intel KeemBay Display

2020-10-29 Thread Anitha Chrisanthus
This patch adds bindings for Intel KeemBay Display v2: review changes from Rob Herring v3: review changes from Sam Ravnborg (removed mipi dsi entries, and encoder entry, connect port to dsi) MSSCAM is part of the display submodule and its used to reset LCD and MIPI DSI clocks, so its

[PATCH v10 0/6] Add support for KeemBay DRM driver

2020-10-29 Thread Anitha Chrisanthus
This is a new DRM driver for Intel's KeemBay SOC. The SoC couples an ARM Cortex A53 CPU with an Intel Movidius VPU. This driver is tested with the KMB EVM board which is the refernce baord for Keem Bay SOC. The SOC's display pipeline is as follows +--++-+

[Bug 209939] radeontop causes kernel panic

2020-10-29 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=209939 --- Comment #3 from Alex Deucher (alexdeuc...@gmail.com) --- Does setting amdgpu.ppfeaturemask=0x3fff on the kernel command line in grub fix it? -- You are receiving this mail because: You are watching the assignee of the bug.

[PATCH] drm/msm/dp: do not notify audio subsystem if sink doesn't support audio

2020-10-29 Thread Abhinav Kumar
For sinks that do not support audio, there is no need to notify audio subsystem of the connection event. This will make sure that audio routes only to the primary display when connected to such sinks. Signed-off-by: Abhinav Kumar --- drivers/gpu/drm/msm/dp/dp_display.c | 12 ++-- 1

Re: [v4,1/3] drm/msm: Add support for GPU cooling

2020-10-29 Thread mka
On Thu, Oct 29, 2020 at 01:37:19PM +0530, Akhil P Oommen wrote: > Register GPU as a devfreq cooling device so that it can be passively > cooled by the thermal framework. > > Signed-off-by: Akhil P Oommen > Reviewed-by: Matthias Kaehlcke Wait, I did not post a 'Reviewed-by' tag for this patch!

[Bug 209939] radeontop causes kernel panic

2020-10-29 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=209939 --- Comment #2 from Janpieter Sollie (janpieter.sol...@edpnet.be) --- I am running radeontop the usual way - without arguments, default compile. amdgpu.runpm=0 has no effect -- You are receiving this mail because: You are watching the assignee

Re: [PATCH v4 5/7] dma-buf: system_heap: Allocate higher order pages if available

2020-10-29 Thread John Stultz
On Thu, Oct 29, 2020 at 12:02 AM Hillf Danton wrote: > > On Thu, 29 Oct 2020 00:16:22 + John Stultz wrote: > > > > +#define HIGH_ORDER_GFP (((GFP_HIGHUSER | __GFP_ZERO | __GFP_NOWARN \ > > + | __GFP_NORETRY) & ~__GFP_RECLAIM) \ > > + |

Re: [PATCH 1/3] fbcon: Disable accelerated scrolling

2020-10-29 Thread Thomas Zimmermann
Am 29.10.20 um 11:14 schrieb Daniel Vetter: > So ever since syzbot discovered fbcon, we have solid proof that it's > full of bugs. And often the solution is to just delete code and remove > features, e.g. 50145474f6ef ("fbcon: remove soft scrollback code"). > > Now the problem is that most

Re: [PATCH 2/3] fbcon: Drop EXPORT_SYMBOL

2020-10-29 Thread Thomas Zimmermann
Am 29.10.20 um 11:14 schrieb Daniel Vetter: > Every since > > commit 6104c37094e729f3d4ce65797002112735d49cd1 > Author: Daniel Vetter > Date: Tue Aug 1 17:32:07 2017 +0200 > > fbcon: Make fbcon a built-time depency for fbdev > > these are no longer distinct loadable modules, so

Re: [PATCH] drm/hisilicon: Adding a const declaration to an invariant construct

2020-10-29 Thread Thomas Zimmermann
Hi Am 29.10.20 um 08:11 schrieb Tian Tao: > Some constructs cannot be changed after being assigned a value, > so add const declarations to invariant constructs. > > Signed-off-by: Tian Tao Reviewed-by: Thomas Zimmermann > --- > drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_de.c | 2 +- >

Re: [PATCH] drm: Remove SCATTERLIST_MAX_SEGMENT

2020-10-29 Thread Daniel Vetter
On Thu, Oct 29, 2020 at 7:20 PM Jason Gunthorpe wrote: > > On Wed, Oct 28, 2020 at 08:49:11PM +0100, Daniel Vetter wrote: > > On Wed, Oct 28, 2020 at 04:15:26PM -0300, Jason Gunthorpe wrote: > > > Since commit 9a40401cfa13 ("lib/scatterlist: Do not limit max_segment to > > > PAGE_ALIGNED values")

Re: [PATCH v4 23/23] drm/msm: Don't implicit-sync if only a single ring

2020-10-29 Thread Daniel Vetter
On Thu, Oct 29, 2020 at 09:59:09AM -0700, Rob Clark wrote: > On Thu, Oct 29, 2020 at 9:14 AM Daniel Vetter wrote: > > > > On Mon, Oct 26, 2020 at 10:34 AM Daniel Vetter wrote: > > > > > > On Fri, Oct 23, 2020 at 08:49:14PM -0700, Rob Clark wrote: > > > > On Fri, Oct 23, 2020 at 11:20 AM Lucas

Re: [RFC PATCH 2/2] drm: etnaviv: Unmap gems on gem_close

2020-10-29 Thread Daniel Vetter
On Thu, Oct 29, 2020 at 03:38:21PM +0100, Lucas Stach wrote: > Hi Guido, > > Am Donnerstag, den 29.10.2020, 15:20 +0100 schrieb Guido Günther: > > So far the unmap from gpu address space only happened when dropping the > > last ref in gem_free_object_unlocked, however that is skipped if there's >

[PATCH] drm/panfrost: Don't corrupt the queue mutex on open/close

2020-10-29 Thread Steven Price
The mutex within the panfrost_queue_state should have the lifetime of the queue, however it was erroneously initialised/destroyed during panfrost_job_{open,close} which is called every time a client opens/closes the drm node. Move the initialisation/destruction to panfrost_job_{init,fini} where

Re: [PATCH v2] drm: Quieten [zero] EDID carping

2020-10-29 Thread Ville Syrjälä
On Thu, Oct 29, 2020 at 04:44:17PM +, Chris Wilson wrote: > We have a few displays in CI that always report their EDID as a bunch of > zeroes. This is consistent behaviour, so one assumes intentional > indication of an "absent" EDID. Flagging these consistent warnings > detracts from CI. > >

Re: [PATCH v4 23/23] drm/msm: Don't implicit-sync if only a single ring

2020-10-29 Thread Rob Clark
On Thu, Oct 29, 2020 at 9:14 AM Daniel Vetter wrote: > > On Mon, Oct 26, 2020 at 10:34 AM Daniel Vetter wrote: > > > > On Fri, Oct 23, 2020 at 08:49:14PM -0700, Rob Clark wrote: > > > On Fri, Oct 23, 2020 at 11:20 AM Lucas Stach > > > wrote: > > > > > > > > On Fr, 2020-10-23 at 09:51 -0700,

[PATCH v2] drm: Quieten [zero] EDID carping

2020-10-29 Thread Chris Wilson
We have a few displays in CI that always report their EDID as a bunch of zeroes. This is consistent behaviour, so one assumes intentional indication of an "absent" EDID. Flagging these consistent warnings detracts from CI. One option would be to ignore the zero EDIDs as intentional behaviour, but

Re: [PATCH 4/4] drm/bridge: ti-sn65dsi86: Update reply on aux failures

2020-10-29 Thread Doug Anderson
Hi, On Wed, Oct 28, 2020 at 6:12 PM Stephen Boyd wrote: > > We should be setting the drm_dp_aux_msg::reply field if a NACK or a > SHORT reply happens. I don't think you update the "reply" field for SHORT, right? You just return a different size? > Update the error bit handling logic in >

Re: [PATCH v4 23/23] drm/msm: Don't implicit-sync if only a single ring

2020-10-29 Thread Daniel Vetter
On Mon, Oct 26, 2020 at 10:34 AM Daniel Vetter wrote: > > On Fri, Oct 23, 2020 at 08:49:14PM -0700, Rob Clark wrote: > > On Fri, Oct 23, 2020 at 11:20 AM Lucas Stach wrote: > > > > > > On Fr, 2020-10-23 at 09:51 -0700, Rob Clark wrote: > > > > From: Rob Clark > > > > > > > > If there is only a

Re: [PATCH 3/4] drm/bridge: ti-sn65dsi86: Read EDID blob over DDC

2020-10-29 Thread Doug Anderson
Hi, On Wed, Oct 28, 2020 at 6:12 PM Stephen Boyd wrote: > > Use the DDC connection to read the EDID from the eDP panel instead of > relying on the panel to tell us the modes. > > Cc: Douglas Anderson > Cc: Laurent Pinchart > Cc: Jonas Karlman > Cc: Jernej Skrabec > Cc: Sean Paul >

Re: [PATCH 2/4] drm/bridge: ti-sn65dsi86: Make polling a busy loop

2020-10-29 Thread Doug Anderson
Hi, On Wed, Oct 28, 2020 at 6:12 PM Stephen Boyd wrote: > > There's no reason we need to wait here to poll a register over i2c. The > i2c bus is inherently slow and delays are practically part of the > protocol because we have to wait for the device to respond to any > request for a register.

Re: [PATCH 1/4] drm/bridge: ti-sn65dsi86: Combine register accesses in ti_sn_aux_transfer()

2020-10-29 Thread Doug Anderson
Hi, On Wed, Oct 28, 2020 at 6:11 PM Stephen Boyd wrote: > > These register reads and writes are sometimes directly next to each > other in the register address space. Let's use regmap bulk read/write > APIs to get the data with one transfer instead of multiple i2c > transfers. This helps cut

Re: [Intel-gfx] [PATCH] drm: Silence zero EDID carping

2020-10-29 Thread Ville Syrjälä
On Thu, Oct 29, 2020 at 04:01:23PM +, Chris Wilson wrote: > Quoting Ville Syrjälä (2020-10-29 14:07:46) > > On Thu, Oct 29, 2020 at 11:00:30AM +, Chris Wilson wrote: > > > We have a few displays in CI that always report their EDID as a bunch of > > > zeroes. This is consistent behavioud,

Re: [Intel-gfx] [PATCH] drm: Silence zero EDID carping

2020-10-29 Thread Chris Wilson
Quoting Ville Syrjälä (2020-10-29 14:07:46) > On Thu, Oct 29, 2020 at 11:00:30AM +, Chris Wilson wrote: > > We have a few displays in CI that always report their EDID as a bunch of > > zeroes. This is consistent behavioud, so one assumes intentional > > indication of an "absent" EDID. Let us

[PATCH 3/3] MAINTAINERS: add files for Mediatek DRM drivers

2020-10-29 Thread Chun-Kuang Hu
Mediatek MIPI DSI phy driver is moved from drivers/gpu/drm/mediatek to drivers/phy/mediatek, so add the new folder to the Mediatek DRM drivers' information. Signed-off-by: Chun-Kuang Hu --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index

[PATCH 2/3] phy: mediatek: Move mtk_mipi_dsi_phy driver into drivers/phy/mediatek folder

2020-10-29 Thread Chun-Kuang Hu
mtk_mipi_dsi_phy is currently placed inside mediatek drm driver, but it's more suitable to place a phy driver into phy driver folder, so move mtk_mipi_dsi_phy driver into phy driver folder. Signed-off-by: Chun-Kuang Hu --- drivers/gpu/drm/mediatek/Kconfig | 7 ---

[PATCH 1/3] drm/mediatek: Separate mtk_mipi_tx to an independent module

2020-10-29 Thread Chun-Kuang Hu
mtk_mipi_tx is a part of mtk_drm module, but phy driver should be an independent module rather than be part of drm module, so separate the phy driver to an independent module. Signed-off-by: Chun-Kuang Hu --- drivers/gpu/drm/mediatek/Kconfig | 8 drivers/gpu/drm/mediatek/Makefile

[PATCH 0/3] Move Mediatek MIPI DSI PHY driver from DRM folder to PHY folder

2020-10-29 Thread Chun-Kuang Hu
mtk_mipi_dsi_phy is currently placed inside mediatek drm driver, but it's more suitable to place a phy driver into phy driver folder, so move mtk_mipi_dsi_phy driver into phy driver folder. Chun-Kuang Hu (3): drm/mediatek: Separate mtk_mipi_tx to an independent module phy: mediatek: Move

Re: [RFC PATCH 2/2] drm: etnaviv: Unmap gems on gem_close

2020-10-29 Thread Lucas Stach
Hi Guido, Am Donnerstag, den 29.10.2020, 15:20 +0100 schrieb Guido Günther: > So far the unmap from gpu address space only happened when dropping the > last ref in gem_free_object_unlocked, however that is skipped if there's > still multiple handles to the same GEM object. > > Since userspace

[RFC PATCH 2/2] drm: etnaviv: Unmap gems on gem_close

2020-10-29 Thread Guido Günther
So far the unmap from gpu address space only happened when dropping the last ref in gem_free_object_unlocked, however that is skipped if there's still multiple handles to the same GEM object. Since userspace (here mesa) in the case of softpin hands back the memory region to the pool of available

[RFC PATCH 0/2] drm: etnaviv: Unmap gems on gem_close

2020-10-29 Thread Guido Günther
This is meant as a RFC since i'm not sure if this is the right way to fix the problem: So far the unmap from gpu address space only happened when dropping the last ref in gem_free_object_unlocked, however that is skipped if there's still multiple handles to the same GEM object. Since userspace

[RFC PATCH 1/2] drm: etnaviv: Add lockdep annotations for context lock

2020-10-29 Thread Guido Günther
etnaviv_iommu_find_iova has it so etnaviv_iommu_insert_exact and lockdep_assert_held should have it as well. Signed-off-by: Guido Günther --- drivers/gpu/drm/etnaviv/etnaviv_mmu.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/etnaviv/etnaviv_mmu.c

Re: [PATCH] drm: Silence zero EDID carping

2020-10-29 Thread Ville Syrjälä
On Thu, Oct 29, 2020 at 11:00:30AM +, Chris Wilson wrote: > We have a few displays in CI that always report their EDID as a bunch of > zeroes. This is consistent behavioud, so one assumes intentional > indication of an "absent" EDID. Let us treat is as such by silently > reporting the zero

Re: [PATCH 3/3] drm/qxl: Remove fbcon acceleration leftovers

2020-10-29 Thread kernel test robot
tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Daniel-Vetter/fbcon-Disable-accelerated-scrolling/20201029-181618 base: git://anongit.freedesktop.org/drm

Re: [PATCH 2/2] drm/atomic: Pass the full state to CRTC atomic begin and flush

2020-10-29 Thread Ville Syrjälä
On Wed, Oct 28, 2020 at 01:32:22PM +0100, Maxime Ripard wrote: > The current atomic helpers have either their object state being passed as > an argument or the full atomic state. > > The former is the pattern that was done at first, before switching to the > latter for new hooks or when it was

Re: [PATCH 1/2] drm/atomic: Pass the full state to CRTC atomic_check

2020-10-29 Thread Ville Syrjälä
On Wed, Oct 28, 2020 at 01:32:21PM +0100, Maxime Ripard wrote: > The current atomic helpers have either their object state being passed as > an argument or the full atomic state. > > The former is the pattern that was done at first, before switching to the > latter for new hooks or when it was

[PATCH] drm/qxl: Remove fbcon acceleration leftovers

2020-10-29 Thread Daniel Vetter
These are leftovers from 13aff184ed9f ("drm/qxl: remove dead qxl fbdev emulation code"). v2: Somehow these structs provided the struct qxl_device pre-decl, reorder the header to not anger compilers. Acked-by: Gerd Hoffmann Signed-off-by: Daniel Vetter Cc: Dave Airlie Cc: Gerd Hoffmann Cc:

[Bug 209939] radeontop causes kernel panic

2020-10-29 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=209939 Alex Deucher (alexdeuc...@gmail.com) changed: What|Removed |Added CC|

Re: [PATCH v2 4/7] drm/vc4: kms: Document the muxing corner cases

2020-10-29 Thread Daniel Vetter
On Thu, Oct 29, 2020 at 11:47:28AM +0100, Maxime Ripard wrote: > Hi! > > Thanks for your review > > On Thu, Oct 29, 2020 at 09:51:04AM +0100, Daniel Vetter wrote: > > On Wed, Oct 28, 2020 at 01:41:01PM +0100, Maxime Ripard wrote: > > > We've had a number of muxing corner-cases with specific ways

Re: [PATCH -next] drm/i915: Remove unused variable ret

2020-10-29 Thread Ville Syrjälä
On Thu, Oct 29, 2020 at 10:18:45AM +0800, Zou Wei wrote: > This patch fixes below warnings reported by coccicheck > > ./drivers/gpu/drm/i915/i915_debugfs.c:789:5-8: Unneeded variable: "ret". > Return "0" on line 1012 > > Reported-by: Hulk Robot > Signed-off-by: Zou Wei Thanks. Applied. >

[Bug 209939] New: radeontop causes kernel panic

2020-10-29 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=209939 Bug ID: 209939 Summary: radeontop causes kernel panic Product: Drivers Version: 2.5 Kernel Version: 5.9.1 Hardware: x86-64 OS: Linux Tree: Mainline

Re: [PATCH v5 1/1] drm/mediatek: dsi: fix scrolling of panel with small hfp or hbp

2020-10-29 Thread Chun-Kuang Hu
Hi, Jitao: Jitao Shi 於 2020年10月13日 週二 下午6:06寫道: > > Replace horizontal_backporch_byte with vm->hback_porch * bpp to aovid > flowing judgement negative number. > > if ((vm->hfront_porch * dsi_tmp_buf_bpp + horizontal_backporch_byte) > > data_phy_cycles * dsi->lanes + delta) > >

[PATCH] fbcon: Disable accelerated scrolling

2020-10-29 Thread Daniel Vetter
So ever since syzbot discovered fbcon, we have solid proof that it's full of bugs. And often the solution is to just delete code and remove features, e.g. 50145474f6ef ("fbcon: remove soft scrollback code"). Now the problem is that most modern-ish drivers really only treat fbcon as an dumb

Re: [Intel-gfx] [PATCH 1/3] fbcon: Disable accelerated scrolling

2020-10-29 Thread kernel test robot
to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Daniel-Vetter/fbcon-Disable-accelerated-scrolling/20201029-181618 base: git

Re: [PATCH 1/1] video: fbdev: fix divide error in fbcon_switch

2020-10-29 Thread Greg KH
On Thu, Oct 29, 2020 at 01:13:01PM +0200, Jani Nikula wrote: > On Thu, 29 Oct 2020, Greg KH wrote: > > On Tue, Oct 27, 2020 at 10:12:49AM -0700, Saeed Mirzamohammadi wrote: > >> Hi Greg, > >> > >> Sorry for the confusion. I’m requesting stable maintainers to cherry-pick > >> this patch into

Re: [PATCH 0/5] drm/tidss: Use new connector model for tidss

2020-10-29 Thread Tomi Valkeinen
On 28/10/2020 16:19, Nikhil Devshatwar wrote: >> Also, with J7 EVM and DP, when I unload the modules I see: >> > I confirm the same issue. > I doubt if it is because of the change I did. > Will try to revert the patches and confirm again My guess is that it's not your patches as such, but that

Re: [PATCH 3/3] drm/qxl: Remove fbcon acceleration leftovers

2020-10-29 Thread Gerd Hoffmann
On Thu, Oct 29, 2020 at 11:14:28AM +0100, Daniel Vetter wrote: > These are leftovers from 13aff184ed9f ("drm/qxl: remove dead qxl fbdev > emulation code"). Acked-by: Gerd Hoffmann ___ dri-devel mailing list dri-devel@lists.freedesktop.org

Re: [PATCH 1/1] video: fbdev: fix divide error in fbcon_switch

2020-10-29 Thread Jani Nikula
On Thu, 29 Oct 2020, Greg KH wrote: > On Tue, Oct 27, 2020 at 10:12:49AM -0700, Saeed Mirzamohammadi wrote: >> Hi Greg, >> >> Sorry for the confusion. I’m requesting stable maintainers to cherry-pick >> this patch into stable 5.4 and 5.8. >> commit cc07057c7c88fb8eff3b1991131ded0f0bcfa7e3 >>

Re: [PATCH 1/1] video: fbdev: fix divide error in fbcon_switch

2020-10-29 Thread Greg KH
On Tue, Oct 27, 2020 at 10:12:49AM -0700, Saeed Mirzamohammadi wrote: > Hi Greg, > > Sorry for the confusion. I’m requesting stable maintainers to cherry-pick > this patch into stable 5.4 and 5.8. > commit cc07057c7c88fb8eff3b1991131ded0f0bcfa7e3 > Author: Saeed Mirzamohammadi > Date: Wed Oct

[PATCH] drm: Silence zero EDID carping

2020-10-29 Thread Chris Wilson
We have a few displays in CI that always report their EDID as a bunch of zeroes. This is consistent behavioud, so one assumes intentional indication of an "absent" EDID. Let us treat is as such by silently reporting the zero edid using connector->null_edid_counter, leaving the loud carp to EDID

Re: [PATCH] drm/vc4: hdmi: Block odd horizontal timings

2020-10-29 Thread Dave Stevenson
On Thu, 29 Oct 2020 at 09:17, Maxime Ripard wrote: > > Hi! > > On Wed, Oct 28, 2020 at 01:42:20PM +, Dave Stevenson wrote: > > Hi Maxime > > > > On Fri, 25 Sep 2020 at 14:00, Maxime Ripard wrote: > > > > > > The FIFO between the pixelvalve and the HDMI controller runs at 2 pixels > > > per

[PATCH v2] drm/panfrost: Fix a race in the job timeout handling (again)

2020-10-29 Thread Boris Brezillon
In our last attempt to fix races in the panfrost_job_timedout() path we overlooked the case where a re-submitted job immediately triggers a fault. This lead to a situation where we try to stop a scheduler that's not resumed yet and lose the 'timedout' event without restarting the timeout, thus

[PATCH 3/3] drm/qxl: Remove fbcon acceleration leftovers

2020-10-29 Thread Daniel Vetter
These are leftovers from 13aff184ed9f ("drm/qxl: remove dead qxl fbdev emulation code"). Signed-off-by: Daniel Vetter Cc: Dave Airlie Cc: Gerd Hoffmann Cc: virtualizat...@lists.linux-foundation.org Cc: spice-de...@lists.freedesktop.org --- drivers/gpu/drm/qxl/qxl_drv.h | 14 -- 1

[PATCH 2/3] fbcon: Drop EXPORT_SYMBOL

2020-10-29 Thread Daniel Vetter
Every since commit 6104c37094e729f3d4ce65797002112735d49cd1 Author: Daniel Vetter Date: Tue Aug 1 17:32:07 2017 +0200 fbcon: Make fbcon a built-time depency for fbdev these are no longer distinct loadable modules, so exporting symbols is kinda pointless. Signed-off-by: Daniel Vetter

  1   2   >