Re: [PATCH v5 03/27] drm/amdgpu: Split amdgpu_device_fini into early and late

2021-04-29 Thread Lazar, Lijo
[AMD Official Use Only - Internal Distribution Only] That looks better to me :) As more things get added, I don't know how long you will be able to hold sw/hw cleanup separate and the name could confuse eventually. Thanks, Lijo ___ dri-devel mailing

Re: [Heads up to maintainers] Re: [PATCH v8 1/1] drm/drm_mst: Use Extended Base Receiver Capability DPCD space

2021-04-29 Thread Jani Nikula
On Thu, 29 Apr 2021, Lyude Paul wrote: > JFYI Jani and Ben: I will be pushing this patch to drm-misc-next sometime > today if there's no objections Thanks for the heads-up, I think this breaks i915. See my review comments elsewhere in the thread. BR, Jani. > > On Wed, 2021-04-28 at 19:43

Re: [Intel-gfx] [PATCH v8 1/1] drm/drm_mst: Use Extended Base Receiver Capability DPCD space

2021-04-29 Thread Jani Nikula
On Wed, 28 Apr 2021, Nikola Cornij wrote: > [why] > DP 1.4a spec madates that if DP_EXTENDED_RECEIVER_CAP_FIELD_PRESENT is > set, Extended Base Receiver Capability DPCD space must be used. Without > doing that, the three DPCD values that differ will be wrong, leading to > incorrect or limited

Re: [PATCH v5 03/27] drm/amdgpu: Split amdgpu_device_fini into early and late

2021-04-29 Thread Andrey Grodzovsky
On 2021-04-30 1:19 a.m., Lazar, Lijo wrote: [AMD Official Use Only - Internal Distribution Only] sysfs cleanup is a sw cleanup to me but done inside hw fini. sw/hw separation is not strictly followed, or name it like stage1/stage2 fini. The thing is that it was called early_fini and

Re: [PATCH v5 03/27] drm/amdgpu: Split amdgpu_device_fini into early and late

2021-04-29 Thread Lazar, Lijo
[AMD Official Use Only - Internal Distribution Only] sysfs cleanup is a sw cleanup to me but done inside hw fini. sw/hw separation is not strictly followed, or name it like stage1/stage2 fini. Thanks, Lijo From: amd-gfx on behalf of Andrey Grodzovsky Sent:

[PATCH v2] drm/radeon/dpm: Disable sclk switching on Oland when two 4K 60Hz monitors are connected

2021-04-29 Thread Kai-Heng Feng
Screen flickers rapidly when two 4K 60Hz monitors are in use. This issue doesn't happen when one monitor is 4K 60Hz (pixelclock 594MHz) and another one is 4K 30Hz (pixelclock 297MHz). The issue is gone after setting "power_dpm_force_performance_level" to "high". Following the indication, we found

Re: [Intel-gfx] [PATCH 08/21] drm/i915/gem: Disallow bonding of virtual engines

2021-04-29 Thread Matthew Brost
On Thu, Apr 29, 2021 at 02:14:19PM +0200, Daniel Vetter wrote: > On Wed, Apr 28, 2021 at 01:17:27PM -0500, Jason Ekstrand wrote: > > On Wed, Apr 28, 2021 at 1:02 PM Matthew Brost > > wrote: > > > > > > On Wed, Apr 28, 2021 at 12:46:07PM -0500, Jason Ekstrand wrote: > > > > On Wed, Apr 28, 2021

[git pull] drm tegra-next + fixes for 5.13-rc1

2021-04-29 Thread Dave Airlie
Hi Linus, Looks like I missed a tegra feature request for next, but should still be fine since it's pretty self contained. It does contain one fixes->next merge with no merge justification so I've pushed back on Thierry about not doing that in the future, but let it go now as rebasing might be

Re: [PATCH v5 06/27] drm/amdgpu: Handle IOMMU enabled case.

2021-04-29 Thread Alex Deucher
On Wed, Apr 28, 2021 at 11:13 AM Andrey Grodzovsky wrote: > > Handle all DMA IOMMU gropup related dependencies before the > group is removed. > > v5: Drop IOMMU notifier and switch to lockless call to ttm_tt_unpopulate > > Signed-off-by: Andrey Grodzovsky > --- >

Re: [PATCH 1/2] drm/msm/dp: service only one irq_hpd if there are multiple irq_hpd pending

2021-04-29 Thread Stephen Boyd
Quoting khs...@codeaurora.org (2021-04-29 10:23:31) > On 2021-04-29 02:26, Stephen Boyd wrote: > > Quoting khs...@codeaurora.org (2021-04-28 10:38:11) > >> On 2021-04-27 17:00, Stephen Boyd wrote: > >> > Quoting aravi...@codeaurora.org (2021-04-21 11:55:21) > >> >> On 2021-04-21 10:26,

Re: [PATCH v5 03/27] drm/amdgpu: Split amdgpu_device_fini into early and late

2021-04-29 Thread Alex Deucher
On Thu, Apr 29, 2021 at 3:04 AM Christian König wrote: > > > > Am 28.04.21 um 17:11 schrieb Andrey Grodzovsky: > > Some of the stuff in amdgpu_device_fini such as HW interrupts > > disable and pending fences finilization must be done right away on > > pci_remove while most of the stuff which

Re: [PATCH v5 01/20] drm/panel: panel-simple: Add missing pm_runtime_disable() calls

2021-04-29 Thread Doug Anderson
Hi, On Thu, Apr 29, 2021 at 5:58 PM Linus Walleij wrote: > > On Fri, Apr 23, 2021 at 6:59 PM Douglas Anderson > wrote: > > > In commit 3235b0f20a0a ("drm/panel: panel-simple: Use runtime pm to > > avoid excessive unprepare / prepare") we started using pm_runtime, but > > my patch neglected to

Re: [PATCH v5 01/20] drm/panel: panel-simple: Add missing pm_runtime_disable() calls

2021-04-29 Thread Linus Walleij
On Fri, Apr 30, 2021 at 3:25 AM Doug Anderson wrote: > > I think pm_runtime_disable(); need to be added there? > > I'm a bit confused. You're saying that I need to add > pm_runtime_disable() to panel_simple_remove()? Doesn't this patch do > that? It does, sorry, too late at night :D I was

Re: [PATCH v5 01/20] drm/panel: panel-simple: Add missing pm_runtime_disable() calls

2021-04-29 Thread Linus Walleij
On Fri, Apr 23, 2021 at 6:59 PM Douglas Anderson wrote: > In commit 3235b0f20a0a ("drm/panel: panel-simple: Use runtime pm to > avoid excessive unprepare / prepare") we started using pm_runtime, but > my patch neglected to add the proper pm_runtime_disable(). Doh! Add > them now. > > Fixes:

Re: linux-next: manual merge of the drm-intel tree with the drm tree

2021-04-29 Thread Stephen Rothwell
Hi all, On Thu, 18 Mar 2021 12:52:41 +1100 Stephen Rothwell wrote: > > On Wed, 17 Mar 2021 14:08:24 +1100 Stephen Rothwell > wrote: > > > > Today's linux-next merge of the drm-intel tree got a conflict in: > > > > drivers/gpu/drm/i915/display/intel_sprite.c > > > > between commit: > > >

[PATCH v10 1/1] drm/drm_mst: Use Extended Base Receiver Capability DPCD space

2021-04-29 Thread Nikola Cornij
[why] DP 1.4a spec madates that if DP_EXTENDED_RECEIVER_CAP_FIELD_PRESENT is set, Extended Base Receiver Capability DPCD space must be used. Without doing that, the three DPCD values that differ will be wrong, leading to incorrect or limited functionality. MST link rate, for example, could have a

[PATCH v10 0/1] drm/drm_mst: Use Extended Base Receiver Capability

2021-04-29 Thread Nikola Cornij
Change history: v10: - Removed mistakenly added temporary file v9: - Actually send the changes under v8 below (missed to commit before sending v8) v8: - Chaged link lanes and rate parameters to u8 v7: - Fixed formatting - Fixed 'unused variable' compile warning - Fixed comment format

Re: [Intel-gfx] [PATCH 16/21] drm/i915/gem: Delay context creation

2021-04-29 Thread Jason Ekstrand
On Thu, Apr 29, 2021 at 2:07 PM Daniel Vetter wrote: > > On Thu, Apr 29, 2021 at 02:01:16PM -0500, Jason Ekstrand wrote: > > On Thu, Apr 29, 2021 at 1:56 PM Daniel Vetter wrote: > > > On Thu, Apr 29, 2021 at 01:16:04PM -0500, Jason Ekstrand wrote: > > > > On Thu, Apr 29, 2021 at 10:51 AM Daniel

[PATCH v9 1/1] drm/drm_mst: Use Extended Base Receiver Capability DPCD space

2021-04-29 Thread Nikola Cornij
[why] DP 1.4a spec madates that if DP_EXTENDED_RECEIVER_CAP_FIELD_PRESENT is set, Extended Base Receiver Capability DPCD space must be used. Without doing that, the three DPCD values that differ will be wrong, leading to incorrect or limited functionality. MST link rate, for example, could have a

[PATCH v9 0/1] drm/drm_mst: Use Extended Base Receiver Capability

2021-04-29 Thread Nikola Cornij
Change history: v9: - Actually send the changes under v8 below (missed to commit before sending v8) v8: - Chaged link lanes and rate parameters to u8 v7: - Fixed formatting - Fixed 'unused variable' compile warning - Fixed comment format v6: - Submited from (hopefully) the correct

Re: [v3 1/2] dt-bindings: backlight: add DisplayPort aux backlight

2021-04-29 Thread Doug Anderson
Hi, On Thu, Apr 29, 2021 at 11:04 AM Rob Herring wrote: > > On Mon, Apr 26, 2021 at 11:29:15AM +0530, Rajeev Nandan wrote: > > Add bindings for DisplayPort aux backlight driver. > > > > Changes in v2: > > - New > > > > Signed-off-by: Rajeev Nandan > > --- > >

Re: [PATCH v5 08/27] PCI: add support for dev_groups to struct pci_device_driver

2021-04-29 Thread Andrey Grodzovsky
On 2021-04-29 3:23 p.m., Bjorn Helgaas wrote: On Thu, Apr 29, 2021 at 12:53:15PM -0400, Andrey Grodzovsky wrote: On 2021-04-28 12:53 p.m., Bjorn Helgaas wrote: On Wed, Apr 28, 2021 at 11:11:48AM -0400, Andrey Grodzovsky wrote: This is exact copy of 'USB: add support for dev_groups to

Re: [PATCH v5 20/27] drm: Scope all DRM IOCTLs with drm_dev_enter/exit

2021-04-29 Thread Andrey Grodzovsky
On 2021-04-29 3:05 p.m., Daniel Vetter wrote: On Thu, Apr 29, 2021 at 12:04:33PM -0400, Andrey Grodzovsky wrote: On 2021-04-29 7:32 a.m., Daniel Vetter wrote: On Thu, Apr 29, 2021 at 01:23:19PM +0200, Daniel Vetter wrote: On Wed, Apr 28, 2021 at 11:12:00AM -0400, Andrey Grodzovsky wrote:

Re: [PATCH 1/2] drm/panel: Add DT bindings for Samsung LMS397KF04

2021-04-29 Thread Doug Anderson
Hi, On Thu, Apr 29, 2021 at 7:34 AM Linus Walleij wrote: > > On Tue, Apr 6, 2021 at 1:47 AM Linus Walleij wrote: > > > This adds device tree bindings for the Samsung LMS397KF04 > > RGB DPI display panel. > > > > Cc: devicet...@vger.kernel.org > > Signed-off-by: Linus Walleij > > Someone on DRM

Re: [1/2] drm/panel: Add DT bindings for Samsung LMS397KF04

2021-04-29 Thread Doug Anderson
Hi, On Thu, Apr 29, 2021 at 8:39 AM Linus Walleij wrote: > > This adds device tree bindings for the Samsung LMS397KF04 > RGB DPI display panel. > > Cc: devicet...@vger.kernel.org > Signed-off-by: Linus Walleij > Reviewed-by: Rob Herring > --- > .../display/panel/samsung,lms397kf04.yaml |

Re: [2/2] drm/panel: lms397kf04: Add driver for LMS397KF04

2021-04-29 Thread Doug Anderson
Hi, On Thu, Apr 29, 2021 at 8:40 AM Linus Walleij > @@ -33,6 +33,7 @@ obj-$(CONFIG_DRM_PANEL_RASPBERRYPI_TOUCHSCREEN) += > panel-raspberrypi-touchscreen > obj-$(CONFIG_DRM_PANEL_RAYDIUM_RM67191) += panel-raydium-rm67191.o > obj-$(CONFIG_DRM_PANEL_RAYDIUM_RM68200) += panel-raydium-rm68200.o >

Re: [PATCH] drm/radeon/dpm: Disable sclk switching when two 4K 60Hz monitors are connected

2021-04-29 Thread Alex Deucher
On Thu, Apr 29, 2021 at 9:40 AM Kai-Heng Feng wrote: > > Screen flickers rapidly when two 4K 60Hz monitors are connected to an > Oland card. This issue doesn't happen when one monitor is 4K 60Hz > (pixelclock 594MHz) and another one is 4K 30Hz (pixelclock 297MHz). > > The issue is gone after

RE: [PATCH 7/8] drm/stm: Don't set allow_fb_modifiers explicitly

2021-04-29 Thread Philippe CORNU - foss
Hi Daniel, Many thanks for your patch, Acked-by: Philippe Cornu Philippe :-) De : Daniel Vetter Envoyé : mardi 27 avril 2021 11:20 À : DRI Development Cc : Intel Graphics Development; Daniel Vetter; Daniel Vetter; Yannick FERTRE - foss; Philippe CORNU -

Re: [PATCH v5 08/27] PCI: add support for dev_groups to struct pci_device_driver

2021-04-29 Thread Bjorn Helgaas
On Thu, Apr 29, 2021 at 12:53:15PM -0400, Andrey Grodzovsky wrote: > On 2021-04-28 12:53 p.m., Bjorn Helgaas wrote: > > On Wed, Apr 28, 2021 at 11:11:48AM -0400, Andrey Grodzovsky wrote: > > > This is exact copy of 'USB: add support for dev_groups to > > > struct usb_device_driver' patch by Greg

Re: [PATCH v8 1/5] drm/ast: Remove reference to struct drm_device.pdev

2021-04-29 Thread Thomas Zimmermann
Hi Am 29.04.21 um 18:04 schrieb Ruhl, Michael J: -Original Message- From: dri-devel On Behalf Of Thomas Zimmermann Sent: Thursday, April 29, 2021 6:51 AM To: jani.nik...@linux.intel.com; joonas.lahti...@linux.intel.com; Vivi, Rodrigo ; airl...@linux.ie; dan...@ffwll.ch; chris@chris-

Re: [Intel-gfx] [PATCH 09/21] drm/i915/gem: Disallow creating contexts with too many engines

2021-04-29 Thread Jason Ekstrand
On Thu, Apr 29, 2021 at 3:01 AM Tvrtko Ursulin wrote: > > > On 28/04/2021 18:09, Jason Ekstrand wrote: > > On Wed, Apr 28, 2021 at 9:26 AM Tvrtko Ursulin > > wrote: > >> On 28/04/2021 15:02, Daniel Vetter wrote: > >>> On Wed, Apr 28, 2021 at 11:42:31AM +0100, Tvrtko Ursulin wrote: > >

Re: [PATCH 1/9] drm/connector: Make the drm_sysfs connector->kdev device hold a reference to the connector

2021-04-29 Thread Daniel Vetter
On Thu, Apr 29, 2021 at 02:33:17PM +0200, Hans de Goede wrote: > Hi, > > On 4/29/21 2:04 PM, Daniel Vetter wrote: > > On Thu, Apr 29, 2021 at 01:54:46PM +0200, Greg Kroah-Hartman wrote: > >> On Thu, Apr 29, 2021 at 01:40:28PM +0200, Daniel Vetter wrote: > >>> On Wed, Apr 28, 2021 at 11:52:49PM

Re: [PATCH 1/1] i915/query: Correlate engine and cpu timestamps with better accuracy

2021-04-29 Thread Jason Ekstrand
On Wed, Apr 28, 2021 at 7:34 PM Umesh Nerlige Ramappa wrote: > > Perf measurements rely on CPU and engine timestamps to correlate > events of interest across these time domains. Current mechanisms get > these timestamps separately and the calculated delta between these > timestamps lack enough

Re: [Intel-gfx] [PATCH 16/21] drm/i915/gem: Delay context creation

2021-04-29 Thread Daniel Vetter
On Thu, Apr 29, 2021 at 02:01:16PM -0500, Jason Ekstrand wrote: > On Thu, Apr 29, 2021 at 1:56 PM Daniel Vetter wrote: > > On Thu, Apr 29, 2021 at 01:16:04PM -0500, Jason Ekstrand wrote: > > > On Thu, Apr 29, 2021 at 10:51 AM Daniel Vetter wrote: > > > > > + ret =

Re: [PATCH v5 20/27] drm: Scope all DRM IOCTLs with drm_dev_enter/exit

2021-04-29 Thread Daniel Vetter
On Thu, Apr 29, 2021 at 12:04:33PM -0400, Andrey Grodzovsky wrote: > > > On 2021-04-29 7:32 a.m., Daniel Vetter wrote: > > On Thu, Apr 29, 2021 at 01:23:19PM +0200, Daniel Vetter wrote: > > > On Wed, Apr 28, 2021 at 11:12:00AM -0400, Andrey Grodzovsky wrote: > > > > With this calling

[PATCH 24/25] i915/gem/selftests: Assign the VM at context creation in igt_shared_ctx_exec

2021-04-29 Thread Jason Ekstrand
We want to delete __assign_ppgtt and, generally, stop setting the VM after context creation. This is the one place I could find in the selftests where we set a VM after the fact. Signed-off-by: Jason Ekstrand --- drivers/gpu/drm/i915/gem/selftests/i915_gem_context.c | 6 +- 1 file changed,

[PATCH 19/25] drm/i915/gt: Drop i915_address_space::file (v2)

2021-04-29 Thread Jason Ekstrand
There's a big comment saying how useful it is but no one is using this for anything anymore. It was added in 2bfa996e031b ("drm/i915: Store owning file on the i915_address_space") and used for debugfs at the time as well as telling the difference between the global GTT and a PPGTT. In

[PATCH 23/25] drm/i915/selftests: Take a VM in kernel_context()

2021-04-29 Thread Jason Ekstrand
This better models where we want to go with contexts in general where things like the VM and engine set are create parameters instead of being set after the fact. Signed-off-by: Jason Ekstrand --- .../drm/i915/gem/selftests/i915_gem_context.c | 4 ++--

[PATCH 25/25] drm/i915/gem: Roll all of context creation together

2021-04-29 Thread Jason Ekstrand
Now that we have the whole engine set and VM at context creation time, we can just assign those fields instead of creating first and handling the VM and engines later. This lets us avoid creating useless VMs and engine sets and lets us git rid of the complex VM setting code. Signed-off-by: Jason

[PATCH 21/25] drm/i915/gem: Don't allow changing the VM on running contexts

2021-04-29 Thread Jason Ekstrand
Signed-off-by: Jason Ekstrand --- drivers/gpu/drm/i915/gem/i915_gem_context.c | 267 -- .../gpu/drm/i915/gem/i915_gem_context_types.h | 2 +- .../drm/i915/gem/selftests/i915_gem_context.c | 119 .../drm/i915/selftests/i915_mock_selftests.h | 1 - 4 files changed,

[PATCH 22/25] drm/i915/gem: Don't allow changing the engine set on running contexts

2021-04-29 Thread Jason Ekstrand
Signed-off-by: Jason Ekstrand --- drivers/gpu/drm/i915/gem/i915_gem_context.c | 302 1 file changed, 302 deletions(-) diff --git a/drivers/gpu/drm/i915/gem/i915_gem_context.c b/drivers/gpu/drm/i915/gem/i915_gem_context.c index a80d36c2a2663..dd066b5009fe7 100644 ---

[PATCH 20/25] drm/i915/gem: Delay context creation

2021-04-29 Thread Jason Ekstrand
The current context uAPI allows for two methods of setting context parameters: SET_CONTEXT_PARAM and CONTEXT_CREATE_EXT_SETPARAM. The former is allowed to be called at any time while the later happens as part of GEM_CONTEXT_CREATE. Currently, everything settable via one is settable via the

[PATCH 17/25] drm/i915/gem: Use the proto-context to handle create parameters

2021-04-29 Thread Jason Ekstrand
This means that the proto-context needs to grow support for engine configuration information as well as setparam logic. Fortunately, we'll be deleting a lot of setparam logic on the primary context shortly so it will hopefully balance out. Signed-off-by: Jason Ekstrand ---

[PATCH 18/25] drm/i915/gem: Return an error ptr from context_lookup

2021-04-29 Thread Jason Ekstrand
We're about to start doing lazy context creation which means contexts get created in i915_gem_context_lookup and we may start having more errors than -ENOENT. Signed-off-by: Jason Ekstrand Reviewed-by: Daniel Vetter --- drivers/gpu/drm/i915/gem/i915_gem_context.c| 12 ++--

[PATCH 15/25] drm/i915: Add gem/i915_gem_context.h to the docs

2021-04-29 Thread Jason Ekstrand
In order to prevent kernel doc warnings, also fill out docs for any missing fields and fix those that forgot the "@". Signed-off-by: Jason Ekstrand --- Documentation/gpu/i915.rst| 2 + .../gpu/drm/i915/gem/i915_gem_context_types.h | 43 --- 2 files changed,

[PATCH 16/25] drm/i915/gem: Add an intermediate proto_context struct

2021-04-29 Thread Jason Ekstrand
The current context uAPI allows for two methods of setting context parameters: SET_CONTEXT_PARAM and CONTEXT_CREATE_EXT_SETPARAM. The former is allowed to be called at any time while the later happens as part of GEM_CONTEXT_CREATE. Currently, everything settable via one is settable via the

[PATCH 06/25] drm/i915: Drop the CONTEXT_CLONE API

2021-04-29 Thread Jason Ekstrand
This API allows one context to grab bits out of another context upon creation. It can be used as a short-cut for setparam(getparam()) for things like I915_CONTEXT_PARAM_VM. However, it's never been used by any real userspace. It's used by a few IGT tests and that's it. Since it doesn't add any

[PATCH 13/25] drm/i915: Stop manually RCU banging in reset_stats_ioctl (v2)

2021-04-29 Thread Jason Ekstrand
As far as I can tell, the only real reason for this is to avoid taking a reference to the i915_gem_context. The cost of those two atomics probably pales in comparison to the cost of the ioctl itself so we're really not buying ourselves anything here. We're about to make context lookup a tiny bit

[PATCH 14/25] drm/i915/gem: Add a separate validate_priority helper

2021-04-29 Thread Jason Ekstrand
With the proto-context stuff added later in this series, we end up having to duplicate set_priority. This lets us avoid duplicating the validation logic. Signed-off-by: Jason Ekstrand Reviewed-by: Daniel Vetter --- drivers/gpu/drm/i915/gem/i915_gem_context.c | 42 + 1 file

[PATCH 05/25] drm/i915/gem: Return void from context_apply_all

2021-04-29 Thread Jason Ekstrand
None of the callbacks we use with it return an error code anymore; they all return 0 unconditionally. Signed-off-by: Jason Ekstrand Reviewed-by: Daniel Vetter --- drivers/gpu/drm/i915/gem/i915_gem_context.c | 26 +++-- 1 file changed, 8 insertions(+), 18 deletions(-) diff

[PATCH 10/25] drm/i915/gem: Remove engine auto-magic with FENCE_SUBMIT

2021-04-29 Thread Jason Ekstrand
Even though FENCE_SUBMIT is only documented to wait until the request in the in-fence starts instead of waiting until it completes, it has a bit more magic than that. If FENCE_SUBMIT is used to submit something to a balanced engine, we would wait to assign engines until the primary request was

[PATCH 04/25] drm/i915/gem: Set the watchdog timeout directly in intel_context_set_gem (v2)

2021-04-29 Thread Jason Ekstrand
Instead of handling it like a context param, unconditionally set it when intel_contexts are created. For years we've had the idea of a watchdog uAPI floating about. The aim was for media, so that they could set very tight deadlines for their transcodes jobs, so that if you have a corrupt

[PATCH 11/25] drm/i915/request: Remove the hook from await_execution

2021-04-29 Thread Jason Ekstrand
This was only ever used for FENCE_SUBMIT automatic engine selection which was removed in the previous commit. Signed-off-by: Jason Ekstrand --- .../gpu/drm/i915/gem/i915_gem_execbuffer.c| 3 +- drivers/gpu/drm/i915/i915_request.c | 42 ---

[PATCH 09/25] drm/i915/gem: Disallow bonding of virtual engines (v3)

2021-04-29 Thread Jason Ekstrand
This adds a bunch of complexity which the media driver has never actually used. The media driver does technically bond a balanced engine to another engine but the balanced engine only has one engine in the sibling set. This doesn't actually result in a virtual engine. This functionality was

[PATCH 12/25] drm/i915/gem: Disallow creating contexts with too many engines

2021-04-29 Thread Jason Ekstrand
There's no sense in allowing userspace to create more engines than it can possibly access via execbuf. Signed-off-by: Jason Ekstrand Reviewed-by: Daniel Vetter --- drivers/gpu/drm/i915/gem/i915_gem_context.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git

[PATCH 02/25] drm/i915: Stop storing the ring size in the ring pointer

2021-04-29 Thread Jason Ekstrand
Signed-off-by: Jason Ekstrand --- drivers/gpu/drm/i915/gem/i915_gem_context.c | 3 +-- drivers/gpu/drm/i915/gt/intel_context.c | 3 ++- drivers/gpu/drm/i915/gt/intel_context.h | 5 - drivers/gpu/drm/i915/gt/intel_context_types.h | 1 + drivers/gpu/drm/i915/gt/intel_lrc.c

[PATCH 07/25] drm/i915: Implement SINGLE_TIMELINE with a syncobj (v4)

2021-04-29 Thread Jason Ekstrand
This API is entirely unnecessary and I'd love to get rid of it. If userspace wants a single timeline across multiple contexts, they can either use implicit synchronization or a syncobj, both of which existed at the time this feature landed. The justification given at the time was that it would

[PATCH 00/25] drm/i915/gem: ioctl clean-ups (v4)

2021-04-29 Thread Jason Ekstrand
Overview: - This patch series attempts to clean up some of the IOCTL mess we've created over the last few years. The most egregious bit being context mutability. In summary, this series: 1. Drops two never-used context params: RINGSIZE and NO_ZEROMAP 2. Drops the entire CONTEXT_CLONE

[PATCH 08/25] drm/i915: Drop getparam support for I915_CONTEXT_PARAM_ENGINES

2021-04-29 Thread Jason Ekstrand
This has never been used by any userspace except IGT and provides no real functionality beyond parroting back parameters userspace passed in as part of context creation or via setparam. If the context is in legacy mode (where you use I915_EXEC_RENDER and friends), it returns success with zero

[PATCH 03/25] drm/i915: Drop I915_CONTEXT_PARAM_NO_ZEROMAP

2021-04-29 Thread Jason Ekstrand
The idea behind this param is to support OpenCL drivers with relocations because OpenCL reserves 0x0 for NULL and, if we placed memory there, it would confuse CL kernels. It was originally sent out as part of a patch series including libdrm [1] and Beignet [2] support. However, the libdrm and

[PATCH 01/25] drm/i915: Drop I915_CONTEXT_PARAM_RINGSIZE

2021-04-29 Thread Jason Ekstrand
This reverts commit 88be76cdafc7 ("drm/i915: Allow userspace to specify ringsize on construction"). This API was originally added for OpenCL but the compute-runtime PR has sat open for a year without action so we can still pull it out if we want. I argue we should drop it for three reasons: 1.

Re: [Intel-gfx] [PATCH 16/21] drm/i915/gem: Delay context creation

2021-04-29 Thread Jason Ekstrand
On Thu, Apr 29, 2021 at 1:56 PM Daniel Vetter wrote: > > On Thu, Apr 29, 2021 at 01:16:04PM -0500, Jason Ekstrand wrote: > > On Thu, Apr 29, 2021 at 10:51 AM Daniel Vetter wrote: > > > > + ret = set_proto_ctx_param(file_priv, pc, args); > > > > > > I think we should have a FIXME here of not

[Heads up to maintainers] Re: [PATCH v8 1/1] drm/drm_mst: Use Extended Base Receiver Capability DPCD space

2021-04-29 Thread Lyude Paul
JFYI Jani and Ben: I will be pushing this patch to drm-misc-next sometime today if there's no objections On Wed, 2021-04-28 at 19:43 -0400, Nikola Cornij wrote: > [why] > DP 1.4a spec madates that if DP_EXTENDED_RECEIVER_CAP_FIELD_PRESENT is > set, Extended Base Receiver Capability DPCD space

Re: [Intel-gfx] [PATCH 16/21] drm/i915/gem: Delay context creation

2021-04-29 Thread Daniel Vetter
On Thu, Apr 29, 2021 at 01:16:04PM -0500, Jason Ekstrand wrote: > On Thu, Apr 29, 2021 at 10:51 AM Daniel Vetter wrote: > > > + ret = set_proto_ctx_param(file_priv, pc, args); > > > > I think we should have a FIXME here of not allowing this on some future > > platforms because just use

Re: [Intel-gfx] [PATCH 03/21] drm/i915/gem: Set the watchdog timeout directly in intel_context_set_gem

2021-04-29 Thread Jason Ekstrand
On Thu, Apr 29, 2021 at 12:13 PM Daniel Vetter wrote: > > On Thu, Apr 29, 2021 at 07:12:05PM +0200, Daniel Vetter wrote: > > On Thu, Apr 29, 2021 at 09:54:15AM -0500, Jason Ekstrand wrote: > > > On Thu, Apr 29, 2021 at 3:04 AM Tvrtko Ursulin > > > wrote: > > > > > > > > > > > > On 28/04/2021

Re: [Intel-gfx] [PATCH 16/21] drm/i915/gem: Delay context creation

2021-04-29 Thread Jason Ekstrand
On Thu, Apr 29, 2021 at 10:51 AM Daniel Vetter wrote: > > Yeah this needs some text to explain what/why you're doing this, and maybe > some rough sketch of the locking design. Yup. Will add. > > On Fri, Apr 23, 2021 at 05:31:26PM -0500, Jason Ekstrand wrote: > > Signed-off-by: Jason Ekstrand

Re: [v3 1/2] dt-bindings: backlight: add DisplayPort aux backlight

2021-04-29 Thread Rob Herring
On Mon, Apr 26, 2021 at 11:29:15AM +0530, Rajeev Nandan wrote: > Add bindings for DisplayPort aux backlight driver. > > Changes in v2: > - New > > Signed-off-by: Rajeev Nandan > --- > .../bindings/leds/backlight/dp-aux-backlight.yaml | 49 > ++ > 1 file changed, 49

Re: [PATCH 1/2] drm/i915/overlay: Fix active retire callback alignment

2021-04-29 Thread Tvrtko Ursulin
On 29/04/2021 17:31, Ville Syrjälä wrote: On Thu, Apr 29, 2021 at 09:35:29AM +0100, Tvrtko Ursulin wrote: From: Tvrtko Ursulin __i915_active_call annotation is required on the retire callback to ensure correct function alignment. Signed-off-by: Tvrtko Ursulin Fixes: a21ce8ad12d2

Re: [Intel-gfx] [PATCH 1/2] drm/i915/overlay: Fix active retire callback alignment

2021-04-29 Thread Ville Syrjälä
On Thu, Apr 29, 2021 at 07:31:43PM +0300, Ville Syrjälä wrote: > On Thu, Apr 29, 2021 at 09:35:29AM +0100, Tvrtko Ursulin wrote: > > From: Tvrtko Ursulin > > > > __i915_active_call annotation is required on the retire callback to ensure > > correct function alignment. > > > > Signed-off-by:

Re: [PATCH 21/21] drm/i915/gem: Roll all of context creation together

2021-04-29 Thread Daniel Vetter
On Fri, Apr 23, 2021 at 05:31:31PM -0500, Jason Ekstrand wrote: > Now that we have the whole engine set and VM at context creation time, > we can just assign those fields instead of creating first and handling > the VM and engines later. This lets us avoid creating useless VMs and > engine sets

Re: [PATCH 1/2] drm/msm/dp: service only one irq_hpd if there are multiple irq_hpd pending

2021-04-29 Thread khsieh
On 2021-04-29 02:26, Stephen Boyd wrote: Quoting khs...@codeaurora.org (2021-04-28 10:38:11) On 2021-04-27 17:00, Stephen Boyd wrote: > Quoting aravi...@codeaurora.org (2021-04-21 11:55:21) >> On 2021-04-21 10:26, khs...@codeaurora.org wrote: >> >> >> >>> + >> >>>

Re: [PATCH] dt-bindings: display: renesas,du: Add missing power-domains property

2021-04-29 Thread Geert Uytterhoeven
Hi Laurent, On Thu, Apr 29, 2021 at 5:59 PM Laurent Pinchart wrote: > On Thu, Apr 29, 2021 at 02:47:56PM +0200, Geert Uytterhoeven wrote: > > "make dtbs_check" complains: > > > > arch/arm/boot/dts/r8a7779-marzen.dt.yaml: display@fff8: > > 'power-domains' does not match any of the

Re: [PATCH 18/21] drm/i915/gem: Don't allow changing the engine set on running contexts

2021-04-29 Thread Daniel Vetter
On Fri, Apr 23, 2021 at 05:31:28PM -0500, Jason Ekstrand wrote: > Signed-off-by: Jason Ekstrand I think with the additions move in here and commit message explaining a bit what's going on this looks all reasonable. I think minimally you should explain the audit you've done here and which

Re: [Intel-gfx] [PATCH 20/21] i915/gem/selftests: Assign the VM at context creation in igt_shared_ctx_exec

2021-04-29 Thread Daniel Vetter
On Fri, Apr 23, 2021 at 05:31:30PM -0500, Jason Ekstrand wrote: > Signed-off-by: Jason Ekstrand Maybe spend a few words on explaining why in these two selftest patches instead of letting me guess :-) -Daniel > --- > drivers/gpu/drm/i915/gem/selftests/i915_gem_context.c | 6 +- > 1 file

Re: [Intel-gfx] [PATCH 14/21] drm/i915/gem: Return an error ptr from context_lookup

2021-04-29 Thread Daniel Vetter
On Thu, Apr 29, 2021 at 10:29:51AM -0500, Jason Ekstrand wrote: > On Thu, Apr 29, 2021 at 8:27 AM Daniel Vetter wrote: > > > > On Fri, Apr 23, 2021 at 05:31:24PM -0500, Jason Ekstrand wrote: > > > We're about to start doing lazy context creation which means contexts > > > get created in

Re: [PATCH 08/21] drm/i915/gem: Disallow bonding of virtual engines

2021-04-29 Thread Daniel Vetter
On Thu, Apr 29, 2021 at 11:02:27AM -0500, Jason Ekstrand wrote: > On Thu, Apr 29, 2021 at 7:16 AM Daniel Vetter wrote: > > > > On Wed, Apr 28, 2021 at 01:58:17PM -0500, Jason Ekstrand wrote: > > > On Wed, Apr 28, 2021 at 12:18 PM Jason Ekstrand > > > wrote: > > > > > > > > On Wed, Apr 28, 2021

Re: [Intel-gfx] [PATCH 03/21] drm/i915/gem: Set the watchdog timeout directly in intel_context_set_gem

2021-04-29 Thread Daniel Vetter
On Thu, Apr 29, 2021 at 07:12:05PM +0200, Daniel Vetter wrote: > On Thu, Apr 29, 2021 at 09:54:15AM -0500, Jason Ekstrand wrote: > > On Thu, Apr 29, 2021 at 3:04 AM Tvrtko Ursulin > > wrote: > > > > > > > > > On 28/04/2021 18:24, Jason Ekstrand wrote: > > > > On Wed, Apr 28, 2021 at 10:55 AM

Re: [PATCH v5 13/27] drm/amdgpu: When filizing the fence driver. stop scheduler first.

2021-04-29 Thread Andrey Grodzovsky
On 2021-04-29 3:15 a.m., Christian König wrote: Filizing the fences? You mean finishing the fences, don't you? :) Yes, my bad. Andrey Am 28.04.21 um 17:11 schrieb Andrey Grodzovsky: No point calling amdgpu_fence_wait_empty before stopping the SW scheduler otherwise there is always a

Re: [Intel-gfx] [PATCH 03/21] drm/i915/gem: Set the watchdog timeout directly in intel_context_set_gem

2021-04-29 Thread Daniel Vetter
On Thu, Apr 29, 2021 at 09:54:15AM -0500, Jason Ekstrand wrote: > On Thu, Apr 29, 2021 at 3:04 AM Tvrtko Ursulin > wrote: > > > > > > On 28/04/2021 18:24, Jason Ekstrand wrote: > > > On Wed, Apr 28, 2021 at 10:55 AM Tvrtko Ursulin > > > wrote: > > >> On 23/04/2021 23:31, Jason Ekstrand wrote: >

Re: [PATCH v5 15/27] drm/scheduler: Fix hang when sched_entity released

2021-04-29 Thread Andrey Grodzovsky
On 2021-04-29 3:18 a.m., Christian König wrote: I need to take another look at this part when I don't have a massive headache any more. Maybe split the patch set up into different parts, something like: 1. Adding general infrastructure. 2. Making sure all memory is unpolated. 3. Job and

[Bug 212107] Temperature increase by 15°C on radeon gpu

2021-04-29 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=212107 Martin (martin...@gmx.com) changed: What|Removed |Added Status|CLOSED |REOPENED

Re: [PATCH v3 3/4] staging: fbtft: Don't spam logs when probe is deferred

2021-04-29 Thread Andy Shevchenko
On Thu, Apr 29, 2021 at 05:42:44PM +0300, Dan Carpenter wrote: > On Wed, Apr 28, 2021 at 04:04:14PM +0300, Andy Shevchenko wrote: > > + if (IS_ERR(*gpiop)) > > + dev_err_probe(dev, PTR_ERR(*gpiop), "Failed to request %s > > GPIO\n", name); > > This should be a return statement: > >

Re: [PATCH v5 16/27] drm/amdgpu: Unmap all MMIO mappings

2021-04-29 Thread Andrey Grodzovsky
On 2021-04-29 3:19 a.m., Christian König wrote: Am 28.04.21 um 17:11 schrieb Andrey Grodzovsky: Access to those must be prevented post pci_remove That is certainly a no-go. We want to get rid of the kernel pointers in BOs, not add another one. Christian. As we discussed internally,

Re: [PATCH v5 08/27] PCI: add support for dev_groups to struct pci_device_driver

2021-04-29 Thread Andrey Grodzovsky
On 2021-04-28 12:53 p.m., Bjorn Helgaas wrote: In subject: s/PCI: add support/PCI: Add support/ to match convention ("git log --oneline drivers/pci/pci-driver.c" to learn this). On Wed, Apr 28, 2021 at 11:11:48AM -0400, Andrey Grodzovsky wrote: This is exact copy of 'USB: add support for

Re: [Intel-gfx] [PATCH 13/21] drm/i915/gem: Add an intermediate proto_context struct

2021-04-29 Thread Jason Ekstrand
On Thu, Apr 29, 2021 at 8:02 AM Daniel Vetter wrote: > > The commit introducing a new data structure really should have a solid > intro in the commit message about. Please cover > > - that ctx really should be immutable, safe for exceptions like priority > > - that unfortunately we butchered the

Re: [PATCH v5 20/27] drm: Scope all DRM IOCTLs with drm_dev_enter/exit

2021-04-29 Thread Andrey Grodzovsky
On 2021-04-29 12:29 p.m., Felix Kuehling wrote: Am 2021-04-29 um 12:21 p.m. schrieb Andrey Grodzovsky: On 2021-04-29 12:15 p.m., Felix Kuehling wrote: Am 2021-04-29 um 12:04 p.m. schrieb Andrey Grodzovsky: So as I understand your preferred approach is that I scope any back_end, HW

Re: [PATCH 1/2] drm/i915/overlay: Fix active retire callback alignment

2021-04-29 Thread Ville Syrjälä
On Thu, Apr 29, 2021 at 09:35:29AM +0100, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > __i915_active_call annotation is required on the retire callback to ensure > correct function alignment. > > Signed-off-by: Tvrtko Ursulin > Fixes: a21ce8ad12d2 ("drm/i915/overlay: Switch to using

Re: [PATCH] drm/i915: Use might_alloc()

2021-04-29 Thread kernel test robot
Hi Bernard, Thank you for the patch! Yet something to improve: [auto build test ERROR on drm-intel/for-linux-next] [also build test ERROR on v5.12 next-20210429] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base

Re: [PATCH v5 20/27] drm: Scope all DRM IOCTLs with drm_dev_enter/exit

2021-04-29 Thread Felix Kuehling
Am 2021-04-29 um 12:21 p.m. schrieb Andrey Grodzovsky: > > > On 2021-04-29 12:15 p.m., Felix Kuehling wrote: >> Am 2021-04-29 um 12:04 p.m. schrieb Andrey Grodzovsky: >>> So as I understand your preferred approach is that I scope any >>> back_end, HW specific function with drm_dev_enter/exit

Re: [PATCH V2 2/2] drm/bridge: ti-sn65dsi83: Add TI SN65DSI83 and SN65DSI84 driver

2021-04-29 Thread Frieder Schrempf
On 28.04.21 16:16, Marek Vasut wrote: On 4/28/21 11:24 AM, Neil Armstrong wrote: [...] +static int sn65dsi83_probe(struct i2c_client *client, +   const struct i2c_device_id *id) +{ +    struct device *dev = >dev; +    enum sn65dsi83_model model; +    struct sn65dsi83 *ctx; +    int

Re: [PATCH v5 20/27] drm: Scope all DRM IOCTLs with drm_dev_enter/exit

2021-04-29 Thread Andrey Grodzovsky
On 2021-04-29 12:15 p.m., Felix Kuehling wrote: Am 2021-04-29 um 12:04 p.m. schrieb Andrey Grodzovsky: So as I understand your preferred approach is that I scope any back_end, HW specific function with drm_dev_enter/exit because that where MMIO access takes place. But besides explicit MMIO

Re: [PATCH v5 20/27] drm: Scope all DRM IOCTLs with drm_dev_enter/exit

2021-04-29 Thread Felix Kuehling
Am 2021-04-29 um 12:04 p.m. schrieb Andrey Grodzovsky: > So as I understand your preferred approach is that I scope any > back_end, HW specific function with drm_dev_enter/exit because that > where MMIO > access takes place. But besides explicit MMIO access thorough > register accessors in the HW

Re: [PATCH] dt-bindings: display: renesas,du: Add missing power-domains property

2021-04-29 Thread Laurent Pinchart
Hi Geert, Thank you for the patch. On Thu, Apr 29, 2021 at 02:47:56PM +0200, Geert Uytterhoeven wrote: > "make dtbs_check" complains: > > arch/arm/boot/dts/r8a7779-marzen.dt.yaml: display@fff8: > 'power-domains' does not match any of the regexes: 'pinctrl-[0-9]+' >

RE: [PATCH v8 1/5] drm/ast: Remove reference to struct drm_device.pdev

2021-04-29 Thread Ruhl, Michael J
>-Original Message- >From: dri-devel On Behalf Of >Thomas Zimmermann >Sent: Thursday, April 29, 2021 6:51 AM >To: jani.nik...@linux.intel.com; joonas.lahti...@linux.intel.com; Vivi, Rodrigo >; airl...@linux.ie; dan...@ffwll.ch; chris@chris- >wilson.co.uk >Cc: lkp ;

Re: [PATCH v5 20/27] drm: Scope all DRM IOCTLs with drm_dev_enter/exit

2021-04-29 Thread Andrey Grodzovsky
On 2021-04-29 7:32 a.m., Daniel Vetter wrote: On Thu, Apr 29, 2021 at 01:23:19PM +0200, Daniel Vetter wrote: On Wed, Apr 28, 2021 at 11:12:00AM -0400, Andrey Grodzovsky wrote: With this calling drm_dev_unplug will flush and block all in flight IOCTLs Also, add feature such that if device

RE: [PATCH v8 3/5] drm/i915: Remove reference to struct drm_device.pdev

2021-04-29 Thread Ruhl, Michael J
>-Original Message- >From: dri-devel On Behalf Of >Thomas Zimmermann >Sent: Thursday, April 29, 2021 6:51 AM >To: jani.nik...@linux.intel.com; joonas.lahti...@linux.intel.com; Vivi, Rodrigo >; airl...@linux.ie; dan...@ffwll.ch; chris@chris- >wilson.co.uk >Cc:

RE: [Intel-gfx] [PATCH v8 2/5] drm/i915/gt: Remove reference to struct drm_device.pdev

2021-04-29 Thread Ruhl, Michael J
>-Original Message- >From: Intel-gfx On Behalf Of >Thomas Zimmermann >Sent: Thursday, April 29, 2021 6:51 AM >To: jani.nik...@linux.intel.com; joonas.lahti...@linux.intel.com; Vivi, Rodrigo >; airl...@linux.ie; dan...@ffwll.ch; chris@chris- >wilson.co.uk >Cc: Winiarski, Michal ; Nikula,

Re: [PATCH 08/21] drm/i915/gem: Disallow bonding of virtual engines

2021-04-29 Thread Jason Ekstrand
On Thu, Apr 29, 2021 at 7:16 AM Daniel Vetter wrote: > > On Wed, Apr 28, 2021 at 01:58:17PM -0500, Jason Ekstrand wrote: > > On Wed, Apr 28, 2021 at 12:18 PM Jason Ekstrand > > wrote: > > > > > > On Wed, Apr 28, 2021 at 5:13 AM Daniel Vetter wrote: > > > > > > > > On Tue, Apr 27, 2021 at

Re: [Intel-gfx] [PATCH 16/21] drm/i915/gem: Delay context creation

2021-04-29 Thread Daniel Vetter
Yeah this needs some text to explain what/why you're doing this, and maybe some rough sketch of the locking design. On Fri, Apr 23, 2021 at 05:31:26PM -0500, Jason Ekstrand wrote: > Signed-off-by: Jason Ekstrand > --- > drivers/gpu/drm/i915/gem/i915_gem_context.c | 657 -- >

Re: [PATCH] dt-bindings: display: renesas,du: Make resets optional on R-Car H1

2021-04-29 Thread Laurent Pinchart
Hi Geert, Thank you for the patch. On Thu, Apr 29, 2021 at 02:47:31PM +0200, Geert Uytterhoeven wrote: > The "resets" property is not present on R-Car Gen1 SoCs. > Supporting it would require migrating from renesas,cpg-clocks to > renesas,cpg-mssr. > > Reflect this in the DT bindings by

  1   2   >