[PATCH 2/2] [RFC] drm: bridge: icn6211: Convert to regmap_config bulk read/write

2022-04-29 Thread Marek Vasut
Instead of working around the missing bulk register read/write in regmap_config using regmap_bus callbacks, switch to new regmap_config read/write callbacks. Signed-off-by: Marek Vasut Cc: Jagan Teki Cc: Mark Brown Cc: Maxime Ripard Cc: Robert Foss Cc: Sam Ravnborg Cc: Thomas Zimmermann

[PATCH 1/2] [RFC] regmap: Add bulk read/write callbacks into regmap_config

2022-04-29 Thread Marek Vasut
Currently the regmap_config structure only allows the user to implement single element register read/write using .reg_read/.reg_write callbacks. The regmap_bus already implements bulk counterparts of both, and is being misused as a workaround for the missing bulk read/write callbacks in

[PATCH] drm: bridge: icn6211: Register macro clean up

2022-04-29 Thread Marek Vasut
Drop two unused register macros, ICN6211_MAX_REGISTER and MIPI_ATE_STATUS_1, neither of which is used and where the later should be specified using macro MIPI_ATE_STATUS(1) instead. Drop the _(n) underscore and keep only the (n) part of register macros. No functional change. Signed-off-by: Marek

[PATCH v2] drm/msm/dpu: Clean up CRC debug logs

2022-04-29 Thread Jessica Zhang
Currently, dpu_hw_lm_collect_misr returns EINVAL if CRC is disabled. This causes a lot of spam in the DRM debug logs as it's called for every vblank. Instead of returning EINVAL when CRC is disabled in dpu_hw_lm_collect_misr, let's return ENODATA and add an extra ENODATA check before the debug

Re: [PATCH] drm/msm/dpu: Clean up CRC debug logs

2022-04-29 Thread Abhinav Kumar
Hi Jessica Please add reported by for dmitry and suggested-by for Rob. Thanks Abhinav On 4/29/2022 5:39 PM, Jessica Zhang wrote: Currently, dpu_hw_lm_collect_misr returns EINVAL if CRC is disabled. This causes a lot of spam in the DRM debug logs as it's called for every vblank. Instead of

[PATCH] drm/msm/dpu: Clean up CRC debug logs

2022-04-29 Thread Jessica Zhang
Currently, dpu_hw_lm_collect_misr returns EINVAL if CRC is disabled. This causes a lot of spam in the DRM debug logs as it's called for every vblank. Instead of returning EINVAL when CRC is disabled in dpu_hw_lm_collect_misr, let's return ENODATA and add an extra ENODATA check before the debug

Re: [PATCH 0/3] HDR aux backlight range calculation

2022-04-29 Thread Lyude Paul
Cool! Tested this on three different laptops, and it seems to work great on all of them. so, this series is: Tested-by: Lyude Paul Would review, but I basically have the same comments as jani On Tue, 2022-04-26 at 15:30 +0300, Jouni Högander wrote: > This patch set splits out static hdr

Re: [PATCH v2 00/48] ARM: PXA multiplatform support

2022-04-29 Thread Guenter Roeck
On 4/29/22 14:46, Arnd Bergmann wrote: On Fri, Apr 29, 2022 at 10:23 PM Guenter Roeck wrote: On 4/29/22 10:48, Guenter Roeck wrote: I tried the pxa-multiplatform-5.18 branch. Its failures match those in v5.18-rc1. Uuh, wait, the build wasn't complete. There are still some failures. I'll

Re: [PATCH] drm/nouveau/subdev/bus: Ratelimit logging for fault errors

2022-04-29 Thread Lyude Paul
On Sat, 2022-04-30 at 00:56 +0200, Karol Herbst wrote: > On Fri, Apr 29, 2022 at 9:54 PM Lyude Paul wrote: > > > > There's plenty of ways to fudge the GPU when developing on nouveau by > > mistake, some of which can result in nouveau seriously spamming dmesg with > > fault errors. This can be

Re: [PATCH] drm/nouveau/subdev/bus: Ratelimit logging for fault errors

2022-04-29 Thread Karol Herbst
On Fri, Apr 29, 2022 at 9:54 PM Lyude Paul wrote: > > There's plenty of ways to fudge the GPU when developing on nouveau by > mistake, some of which can result in nouveau seriously spamming dmesg with > fault errors. This can be somewhat annoying, as it can quickly overrun the > message buffer

Re: [RESEND 2/2] Revert "drm: bridge: mcde_dsi: Switch to devm_drm_of_get_bridge"

2022-04-29 Thread Linus Walleij
On Fri, Apr 29, 2022 at 10:59 AM Jagan Teki wrote: > commit <3d7039e1e649> ("drm: bridge: mcde_dsi: Switch to > devm_drm_of_get_bridge") > switched to devm_drm_of_get_bridge for looking up if child node has panel > or bridge. > > However commit ("Revert "drm: of: Lookup if child node > has

Re: [RESEND 1/2] Revert "drm: bridge: mcde_dsi: Drop explicit bridge remove"

2022-04-29 Thread Linus Walleij
On Fri, Apr 29, 2022 at 10:59 AM Jagan Teki wrote: > commit <3730bc6147b0> ("drm: bridge: mcde_dsi: Drop explicit bridge > remove") has removed downstream bridge as it's prior commit <3d7039e1e649> > ("drm: bridge: mcde_dsi: Switch to devm_drm_of_get_bridge") added > devm_drm_of_get_bridge for

Re: [PATCH 2/2] Revert "drm: bridge: mcde_dsi: Switch to devm_drm_of_get_bridge"

2022-04-29 Thread Linus Walleij
On Fri, Apr 29, 2022 at 10:56 AM Jagan Teki wrote: > From: Jagan Teki > > commit <3d7039e1e649> ("drm: bridge: mcde_dsi: Switch to > devm_drm_of_get_bridge") > switched to devm_drm_of_get_bridge for looking up if child node has panel > or bridge. > > However commit ("Revert "drm: of: Lookup

Re: [PATCH v2 0/7] Make the rest of the VFIO driver interface use vfio_device

2022-04-29 Thread Alex Williamson
On Fri, 29 Apr 2022 14:31:49 -0300 Jason Gunthorpe wrote: > On Thu, Apr 21, 2022 at 01:28:31PM -0300, Jason Gunthorpe wrote: > > Prior series have transformed other parts of VFIO from working on struct > > device or struct vfio_group into working directly on struct > > vfio_device. Based on that

Re: [PATCH v2] MAINTAINERS: Add Dmitry as MSM DRM driver co-maintainer

2022-04-29 Thread Rob Clark
On Fri, Apr 29, 2022 at 2:53 PM Dmitry Baryshkov wrote: > > For the past several releases I have been assisting Rob by writing, > collecting, testing and integrating patches for non-GPU and non-core > parts of MSM DRM driver, while Rob is more interested in improving the > GPU-related part. Let's

[PATCH v2] MAINTAINERS: Add Dmitry as MSM DRM driver co-maintainer

2022-04-29 Thread Dmitry Baryshkov
For the past several releases I have been assisting Rob by writing, collecting, testing and integrating patches for non-GPU and non-core parts of MSM DRM driver, while Rob is more interested in improving the GPU-related part. Let's note this in the MAINTAINERS file. While we are at it, per Rob's

Re: [PATCH v2 00/48] ARM: PXA multiplatform support

2022-04-29 Thread Arnd Bergmann
On Fri, Apr 29, 2022 at 10:23 PM Guenter Roeck wrote: > On 4/29/22 10:48, Guenter Roeck wrote: > > > > I tried the pxa-multiplatform-5.18 branch. Its failures match > > those in v5.18-rc1. > > > > Uuh, wait, the build wasn't complete. There are still some > failures. I'll report later. Sorry

Re: [Intel-gfx] [PATCH v2 0/4] i915: Turn on compute engine support

2022-04-29 Thread Jordan Justen
I did some light testing with our anvil (Vulkan) and iris (OpenGL) Mesa drivers after applying these patches on top of drm-tip tagged intel/CI_DRM_11574. All the unit tests that I tried passed. I also ran the gl_manhattan31 benchmark which used the compute engine for iris compute shader ops.

[PATCH v3] drm: mxsfb: Implement LCDIF scanout CRC32 support

2022-04-29 Thread Marek Vasut
The LCDIF controller as present in i.MX28/i.MX6SX/i.MX8M Mini/Nano has CRC_STAT register, which contains CRC32 of the frame as it was clocked out of the DPI interface of the LCDIF. This is most likely meant as a functional safety feature. Unfortunately, there is zero documentation on how the

Re: [PATCH v2] drm: mxsfb: Implement LCDIF scanout CRC32 support

2022-04-29 Thread Marek Vasut
On 4/29/22 16:08, Stefan Agner wrote: On 2022-04-11 22:35, Marek Vasut wrote: The LCDIF controller as present in i.MX28/i.MX6SX/i.MX8M Mini/Nano has CRC_STAT register, which contains CRC32 of the frame as it was clocked out of the DPI interface of the LCDIF. This is most likely meant as a

[PATCH 2/2] drm/bridge: tc358767: Add DSI-to-(e)DP mode support

2022-04-29 Thread Marek Vasut
Implement DSI-to-e(DP) mode, which is a mix of currently supported DSI-to-DPI and DPI-to-(e)DP modes. The input side is configured as either DSI or DPI, the DP AUX channel is registered for both input side options, and the DSI host is attached for both DPI and (e)DP output side options. One

[PATCH 1/2] drm/bridge: tc358767: Factor out DSI and DPI RX enablement

2022-04-29 Thread Marek Vasut
Factor out register programming to configure the chip video RX side for reception of video data from DSI or DPI. This is particularly useful in the (e)DP output mode, where the video data can be received from either DPI or DSI. While only the former is supported in (e)DP output mode so far, this

[PATCH] drm/bridge: tc358767: Fix DP bridge mode detection from DT endpoints

2022-04-29 Thread Marek Vasut
Per toshiba,tc358767.yaml DT binding document, port@2 the output (e)DP port is optional. In case this port is not described in DT, the bridge driver operates in DPI-to-DP mode. Make sure the driver treats this as a valid mode of operation instead of reporting invalid mode. Fixes: 71f7d9c03118

[PATCH] drm/stm: dsi: Enable wrapper glue regulator early

2022-04-29 Thread Marek Vasut
Certain DSI bridge chips like TC358767/TC358867/TC9595 expect the DSI D0 data lane to be in LP-11 state when released from reset. Currently the STM32MP157 DSI host wrapper glue logic keeps D0 data lane in LP-00 state until DSI init happens, which confuses the TC358767 into entering some sort of

Re: [PATCH v2 7/7] vfio: Remove calls to vfio_group_add_container_user()

2022-04-29 Thread Alex Williamson
On Thu, 21 Apr 2022 13:28:38 -0300 Jason Gunthorpe wrote: > When the open_device() op is called the container_users is incremented and > held incremented until close_device(). Thus, so long as drivers call > functions within their open_device()/close_device() region they do not > need to worry

Re: [PATCH v2 00/48] ARM: PXA multiplatform support

2022-04-29 Thread Guenter Roeck
On 4/29/22 10:48, Guenter Roeck wrote: On 4/28/22 06:44, Arnd Bergmann wrote: On Sun, Apr 24, 2022 at 8:48 PM Arnd Bergmann wrote: On Sun, Apr 24, 2022 at 5:28 PM Guenter Roeck wrote: On 4/24/22 01:52, Arnd Bergmann wrote: On Sun, Apr 24, 2022 at 4:09 AM Guenter Roeck wrote: into the

Re: [PATCH v5 1/4] dt-bindings: display: mediatek: dsi: Convert dsi_dtbinding to .yaml

2022-04-29 Thread Rob Herring
On Fri, Apr 29, 2022 at 09:55:37AM +0800, Rex-BC Chen wrote: > On Thu, 2022-04-28 at 15:33 -0500, Rob Herring wrote: > > On Thu, 28 Apr 2022 21:37:50 +0800, Rex-BC Chen wrote: > > > From: Xinlei Lee > > > > > > Convert mediatek,dsi.txt to mediatek,dsi.yaml format > > > > > > Signed-off-by:

Re: [PATCH 3/4] drm/nouveau: use drm_gem_plane_helper_prepare_fb

2022-04-29 Thread Lyude Paul
Reviewed-by: Lyude Paul Also consider this as permission to push this to drm-misc-next On Fri, 2022-04-29 at 15:42 +0200, Christian König wrote: > Instead of manually adjusting the plane state. > > Signed-off-by: Christian König > Cc: Karol Herbst > Cc: Lyude Paul > Cc: Ben Skeggs > Cc:

[PATCH] drm: drm_gem.h: Add explicit includes for DEFINE_DRM_GEM_FOPS

2022-04-29 Thread Jeffrey Hugo
DEFINE_DRM_GEM_FOPS() references drm functions from other headers. For example drm_open() is defined in drm_file.h and drm_ioctl() is defined in drm_ioctl.h. Since drm_gem.h doesn't include these headers, it relies on an implicit include from the .c file to have included these required headers

[PATCH] drm/nouveau/subdev/bus: Ratelimit logging for fault errors

2022-04-29 Thread Lyude Paul
There's plenty of ways to fudge the GPU when developing on nouveau by mistake, some of which can result in nouveau seriously spamming dmesg with fault errors. This can be somewhat annoying, as it can quickly overrun the message buffer (or your terminal emulator's buffer) and get rid of actually

Re: [PATCH] drm/nouveau: simplify the return expression of nouveau_debugfs_init()

2022-04-29 Thread Lyude Paul
Reviewed-by: Lyude Paul Will push to drm-misc-next in a bit (Kind of impressed that a bot managed to catch this, considering the route from here to the code capable of returning < 0 or 0 was definitely not obvious) On Fri, 2022-04-29 at 09:03 +, cgel@gmail.com wrote: > From: Minghao

[PATCH] MAINTAINERS: add Melissa to V3D maintainers

2022-04-29 Thread Melissa Wen
I've been contributing to v3d through improvements, reviews, testing, debugging, etc. So, I'm adding myself as a co-maintainer of the V3D driver. Signed-off-by: Melissa Wen --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index

Re: [PATCH 22/41] ARM: omap1: move plat/dma.c to mach/omap-dma.c

2022-04-29 Thread Péter Ujfalusi
On 4/19/22 16:37, Arnd Bergmann wrote: > From: Arnd Bergmann > > Most of the interface functions in plat/dma.c are only used from the > USB driver, which is practically OMAP1 specific, except for compile > testing. > > The omap_get_plat_info(), omap_request_dma() and omap_free_dma() >

Re: [PATCH 21/41] ARM: omap1: dma: remove omap2 specific bits

2022-04-29 Thread Péter Ujfalusi
On 4/19/22 16:37, Arnd Bergmann wrote: > From: Arnd Bergmann > > No part of plat-omap/dma.c is called on omap2 any more, so > anything omap2 specific in here can simply be removed. Reviewed-by: Peter Ujfalusi > Signed-off-by: Arnd Bergmann > --- > arch/arm/plat-omap/dma.c | 217

Re: [PATCH 19/41] ARM: omap: dma: make usb support optional

2022-04-29 Thread Péter Ujfalusi
On 4/19/22 16:37, Arnd Bergmann wrote: > From: Arnd Bergmann > > Most of the plat-omap/dma.c code is specific to the USB > driver. The reason is simple: the omap_udc is the only driver which has not been ported to DMAengine. I had a patch if I recall to convert it, but I don't have a way to

[PATCH] drm/etnaviv: avoid cleaning up sched_job when submit succeeded

2022-04-29 Thread Lucas Stach
While the labels may mislead the casual reader, the tail of the function etnaviv_ioctl_gem_submit is always executed, as a lot of the structures set up in this function need to be cleaned up regardless of whether the submit succeeded or failed. An exception is the newly added

[PATCH v1 5/7] drm/msm/hdmi: stop using drm_bridge_connector_en/disable_hpd()

2022-04-29 Thread Dmitry Baryshkov
The functionality of drm_bridge_connector_enable_hpd() and drm_bridge_connector_disable_hpd() is provided automatically by the drm_kms_poll helpers. Stop calling these functions manually. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/hdmi/hdmi.c | 2 -- 1 file changed, 2 deletions(-)

[PATCH v1 7/7] drm/bridge_connector: drop drm_bridge_connector_en/disable_hpd()

2022-04-29 Thread Dmitry Baryshkov
Now as all drivers stopped calling drm_bridge_connector_enable_hpd() and drm_bridge_connector_disable_hpd() it is safe to remove them complelely. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/drm_bridge_connector.c | 25 - include/drm/drm_bridge_connector.h |

[PATCH v1 3/7] drm/bridge_connector: rely on drm_kms_helper_poll_* for HPD enablement

2022-04-29 Thread Dmitry Baryshkov
Use drm_connector's helpers enable_hpd and disable_hpd to enable and disable HPD automatically by the means of drm_kms_helper_poll_* functions. As the drm_bridge_connector_enable_hpd() and drm_bridge_connector_disable_hpd() functions are now unused, replace them with stubs to ease driver

[PATCH v1 2/7] drm/probe-helper: enable and disable HPD on connectors

2022-04-29 Thread Dmitry Baryshkov
Intruct two drm_connector_helper_funcs: enable_hpd() and disable_hpd(). They are called by drm_kms_helper_poll_enable() and drm_kms_helper_poll_disable() (and thus drm_kms_helper_poll_init() and drm_kms_helper_poll_fini()) respectively. This allows drivers to rely on drm_kms_helper_poll for

[PATCH v1 4/7] drm/imx/dcss: stop using drm_bridge_connector_en/disable_hpd()

2022-04-29 Thread Dmitry Baryshkov
The functionality of drm_bridge_connector_enable_hpd() and drm_bridge_connector_disable_hpd() is provided automatically by the drm_kms_poll helpers. Stop calling these functions manually. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/imx/dcss/dcss-dev.c | 4

[PATCH v1 6/7] drm/omap: stop using drm_bridge_connector_en/disable_hpd()

2022-04-29 Thread Dmitry Baryshkov
The functionality of drm_bridge_connector_enable_hpd() and drm_bridge_connector_disable_hpd() is provided automatically by the drm_kms_poll helpers. Stop calling these functions manually. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/omapdrm/omap_drv.c | 41 --

[PATCH v1 1/7] drm/poll-helper: merge drm_kms_helper_poll_disable() and _fini()

2022-04-29 Thread Dmitry Baryshkov
Merge drm_kms_helper_poll_disable() and drm_kms_helper_poll_fini() code into a common helper function. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/drm_probe_helper.c | 21 + 1 file changed, 13 insertions(+), 8 deletions(-) diff --git

[PATCH v1 0/7] drm/bridge_connector: perform HPD enablement automatically

2022-04-29 Thread Dmitry Baryshkov
>From all the drivers using drm_bridge_connector only iMX/dcss and OMAP DRM driver do a proper work of calling drm_bridge_connector_en/disable_hpd() in right places. Rather than teaching each and every driver how to properly handle drm_bridge_connector's HPD, make that automatic. Add two

Re: [3/4] drm/i915/huc: Prepare for GSC-loaded HuC

2022-04-29 Thread Teres Alexis, Alan Previn
Reviewed-by: Alan Previn On Tue, 2022-04-26 at 17:26 -0700, Daniele Ceraolo Spurio wrote: > HuC loading via GSC is performed via a PXP command sent through the mei > modules, so we need both MEI_GSC and MEI_PXP to be available. Given that > the GSC will do both the transfer and the

Re: [2/4] drm/i915/huc: Add fetch support for gsc-loaded HuC binary

2022-04-29 Thread Teres Alexis, Alan Previn
minor nit: not sure if its worth mentioning in commit msg that "loaded_via_gsc" is zero-init-ed as fw_def macros we havent added fw_defs for gsc-loaded-huc-bins which explains why "loaded_via_gsc" not getting set anywhere in this series. Reviewed-by: Alan Previn On Tue, 2022-04-26 at 17:26

Re: [PATCH v2 00/48] ARM: PXA multiplatform support

2022-04-29 Thread Guenter Roeck
On 4/28/22 06:44, Arnd Bergmann wrote: On Sun, Apr 24, 2022 at 8:48 PM Arnd Bergmann wrote: On Sun, Apr 24, 2022 at 5:28 PM Guenter Roeck wrote: On 4/24/22 01:52, Arnd Bergmann wrote: On Sun, Apr 24, 2022 at 4:09 AM Guenter Roeck wrote: into the defconfig file, otherwise the multiplatform

[PATCH v3 4/4] drm/i915/selftest: Clear the output buffers before GPU writes

2022-04-29 Thread Ramalingam C
From: Chris Wilson When testing whether we can get the GPU to leak information about non-privileged state, we first need to ensure that the output buffer is set to a known value as the HW may opt to skip the write into memory for a non-privileged read of a sensitive register. We chose

[PATCH v3 3/4] drm/i915/selftest: Always cancel semaphore on error

2022-04-29 Thread Ramalingam C
From: Chris Wilson Ensure that we always signal the semaphore when timing out, so that if it happens to be stuck waiting for the semaphore we will quickly recover without having to wait for a reset. Reported-by: CQ Tang Signed-off-by: Chris Wilson Cc: CQ Tang cc: Joonas Lahtinen

[PATCH v3 2/4] drm/i915/selftests: Check for incomplete LRI from the context image

2022-04-29 Thread Ramalingam C
From: Chris Wilson In order to keep the context image parser simple, we assume that all commands follow a similar format. A few, especially not MI commands on the render engines, have fixed lengths not encoded in a length field. This caused us to incorrectly skip over 3D state commands, and

[PATCH v3 1/4] drm/i915/gt: Explicitly clear BB_OFFSET for new contexts

2022-04-29 Thread Ramalingam C
From: Chris Wilson Even though the initial protocontext we load onto HW has the register cleared, by the time we save it into the default image, BB_OFFSET has had the enable bit set. Reclear BB_OFFSET for each new context. Testcase: igt/i915_selftests/gt_lrc v2: Extend it for gen8.

[PATCH v3 0/4] lrc selftest fixes

2022-04-29 Thread Ramalingam C
Few bug fixes for lrc selftest. v3: Extending the first patch for gen8 Chris Wilson (4): drm/i915/gt: Explicitly clear BB_OFFSET for new contexts drm/i915/selftests: Check for incomplete LRI from the context image drm/i915/selftest: Always cancel semaphore on error drm/i915/selftest:

[PATCH] MAINTAINERS: Add Dmitry as MSM DRM driver co-maintainer

2022-04-29 Thread Dmitry Baryshkov
For the past several releases I have been assisting Rob by writing, collecting, testing and integrating patches for non-GPU and non-core parts of MSM DRM driver, while Rob is more interested in improving the GPU-related part. Let's note this in the MAINTAINERS file. Signed-off-by: Dmitry

Re: [PATCH v2 0/7] Make the rest of the VFIO driver interface use vfio_device

2022-04-29 Thread Jason Gunthorpe
On Thu, Apr 21, 2022 at 01:28:31PM -0300, Jason Gunthorpe wrote: > Prior series have transformed other parts of VFIO from working on struct > device or struct vfio_group into working directly on struct > vfio_device. Based on that work we now have vfio_device's readily > available in all the

Re: [PATCH v3 1/2] dt-bindings: display: simple: Add Startek KD070WVFPA043-C069A panel

2022-04-29 Thread Marek Vasut
On 4/29/22 19:20, Fabio Estevam wrote: From: Fabio Estevam Add Startek KD070WVFPA043-C069A 7" TFT LCD panel compatible string. Signed-off-by: Fabio Estevam Acked-by: Sam Ravnborg --- Changes since v2: - None .../devicetree/bindings/display/panel/panel-simple.yaml | 2 ++ 1 file

Re: [PATCH v3 2/2] drm/panel: simple: Add Startek KD070WVFPA043-C069A panel support

2022-04-29 Thread Marek Vasut
On 4/29/22 19:20, Fabio Estevam wrote: From: Heiko Schocher Add Startek KD070WVFPA043-C069A 7" TFT LCD panel support. Signed-off-by: Heiko Schocher [fabio: passed .flags and .bus_flags] Signed-off-by: Fabio Estevam Acked-by: Sam Ravnborg Reviewed-by: Marek Vasut

[PATCH v3 1/2] dt-bindings: display: simple: Add Startek KD070WVFPA043-C069A panel

2022-04-29 Thread Fabio Estevam
From: Fabio Estevam Add Startek KD070WVFPA043-C069A 7" TFT LCD panel compatible string. Signed-off-by: Fabio Estevam Acked-by: Sam Ravnborg --- Changes since v2: - None .../devicetree/bindings/display/panel/panel-simple.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git

[PATCH v3 2/2] drm/panel: simple: Add Startek KD070WVFPA043-C069A panel support

2022-04-29 Thread Fabio Estevam
From: Heiko Schocher Add Startek KD070WVFPA043-C069A 7" TFT LCD panel support. Signed-off-by: Heiko Schocher [fabio: passed .flags and .bus_flags] Signed-off-by: Fabio Estevam Acked-by: Sam Ravnborg --- Changes since v2: - Pass the full flags and bus_flags.

Re: [PATCH] gpu: drm: remove redundant dma_fence_put() when drm_sched_job_add_dependency() fails

2022-04-29 Thread Andrey Grodzovsky
Now it's easy to see it's redundant, it's a problematic design where the fence 'get' part is happening outside the job->dependencies array logic but the fence 'put' part is happening inside, leads to confusions such as adding this 'put' in the first place. I will look into improving this if

Re: [PATCH] drm/bridge: simplify the return expression of ps8640_bridge_host_attach

2022-04-29 Thread Doug Anderson
Hi, On Thu, Apr 28, 2022 at 10:51 PM wrote: > > From: Minghao Chi > > Simplify the return expression. > > Reported-by: Zeal Robot > Signed-off-by: Minghao Chi > --- > drivers/gpu/drm/bridge/parade-ps8640.c | 7 +-- > 1 file changed, 1 insertion(+), 6 deletions(-) Reviewed-by: Douglas

Re: [PATCHv5] drm/amdgpu: vi: disable ASPM on Intel Alder Lake based systems

2022-04-29 Thread Alex Deucher
Reviewed-by: Alex Deucher On Fri, Apr 29, 2022 at 12:08 PM Richard Gong wrote: > > Active State Power Management (ASPM) feature is enabled since kernel 5.14. > There are some AMD Volcanic Islands (VI) GFX cards, such as the WX3200 and > RX640, that do not work with ASPM-enabled Intel Alder Lake

[PATCHv5] drm/amdgpu: vi: disable ASPM on Intel Alder Lake based systems

2022-04-29 Thread Richard Gong
Active State Power Management (ASPM) feature is enabled since kernel 5.14. There are some AMD Volcanic Islands (VI) GFX cards, such as the WX3200 and RX640, that do not work with ASPM-enabled Intel Alder Lake based systems. Using these GFX cards as video/display output, Intel Alder Lake based

Re: [PATCH 2/2] Revert "drm: of: Lookup if child node has panel or bridge"

2022-04-29 Thread Laurent Pinchart
Hi Maxime, On Fri, Apr 29, 2022 at 05:46:45PM +0200, Maxime Ripard wrote: > On Fri, Apr 29, 2022 at 01:17:26AM +0300, Laurent Pinchart wrote: > > On Thu, Apr 28, 2022 at 02:09:42PM +0530, Jagan Teki wrote: > > > On Wed, Apr 27, 2022 at 8:04 PM Maxime Ripard wrote: > > > > On Tue, Apr 26, 2022 at

Re: [Intel-gfx] [PATCH 1/2] module: add a function to add module references

2022-04-29 Thread Lucas De Marchi
On Fri, Apr 29, 2022 at 11:23:51AM +0100, Mauro Carvalho Chehab wrote: Em Fri, 29 Apr 2022 12:10:07 +0200 Greg KH escreveu: On Fri, Apr 29, 2022 at 10:15:03AM +0100, Mauro Carvalho Chehab wrote: > HI Greg, > > Em Fri, 29 Apr 2022 10:30:33 +0200 > Greg KH escreveu: > > > On Fri, Apr 29, 2022

Re: [PATCH 2/2] Revert "drm: of: Lookup if child node has panel or bridge"

2022-04-29 Thread Maxime Ripard
On Fri, Apr 29, 2022 at 01:17:26AM +0300, Laurent Pinchart wrote: > Hi Jagan, > > On Thu, Apr 28, 2022 at 02:09:42PM +0530, Jagan Teki wrote: > > On Wed, Apr 27, 2022 at 8:04 PM Maxime Ripard wrote: > > > On Tue, Apr 26, 2022 at 01:40:31PM +0530, Jagan Teki wrote: > > > > On Tue, Apr 26, 2022 at

Re: [PATCH] gpu/drm/radeon: Fix spelling typo in comments

2022-04-29 Thread Alex Deucher
Applied. Thanks! On Fri, Apr 29, 2022 at 9:04 AM pengfuyuan wrote: > > Fix spelling typo in comments. > > Signed-off-by: pengfuyuan > --- > drivers/gpu/drm/radeon/atombios.h | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/drivers/gpu/drm/radeon/atombios.h

Re: [PATCH] drm/amdgpu: simplify the return expression of navi10_ih_hw_init()

2022-04-29 Thread Alex Deucher
Applied. Thanks! On Fri, Apr 29, 2022 at 1:50 AM wrote: > > From: Minghao Chi > > Simplify the return expression. > > Reported-by: Zeal Robot > Signed-off-by: Minghao Chi > --- > drivers/gpu/drm/amd/amdgpu/navi10_ih.c | 7 +-- > 1 file changed, 1 insertion(+), 6 deletions(-) > > diff

Re: [PATCH] drm/amdgpu: simplify the return expression of iceland_ih_hw_init

2022-04-29 Thread Alex Deucher
Applied. Thanks! On Fri, Apr 29, 2022 at 1:48 AM wrote: > > From: Minghao Chi > > Simplify the return expression. > > Reported-by: Zeal Robot > Signed-off-by: Minghao Chi > --- > drivers/gpu/drm/amd/amdgpu/iceland_ih.c | 7 +-- > 1 file changed, 1 insertion(+), 6 deletions(-) > > diff

[pull] amdgpu, amdkfd, radeon drm-next-5.19

2022-04-29 Thread Alex Deucher
Hi Dave, Daniel, More stuff for 5.19. The following changes since commit e15c9d06e9ad70df41285ca41d535de6215e0b21: drm/amd/amdgpu: Update PF2VF header (2022-04-21 16:00:14 -0400) are available in the Git repository at: https://gitlab.freedesktop.org/agd5f/linux.git

Re: (subset) [PATCH] drm/sun4i: dsi: delete unnecessary IS_ERR() checks

2022-04-29 Thread Maxime Ripard
On Thu, 28 Apr 2022 15:26:23 +0300, Dan Carpenter wrote: > The "dsi->bus_clk" pointer cannot be an error pointer at this point. > The check is confusing and unnecessary. Delete it. > > Applied to drm/drm-misc (drm-misc-next). Thanks! Maxime

Re: (subset) [PATCH] drm/vc4: simplify the return expression of vc4_prepare_fb()

2022-04-29 Thread Maxime Ripard
On Fri, 29 Apr 2022 05:49:45 +, cgel@gmail.com wrote: > From: Minghao Chi > > Simplify the return expression. > > Applied to drm/drm-misc (drm-misc-next). Thanks! Maxime

Re: (subset) [PATCH] drm/vc4: simplify the return expression of vc4_grab_bin_bo()

2022-04-29 Thread Maxime Ripard
On Fri, 29 Apr 2022 09:02:08 +, cgel@gmail.com wrote: > From: Minghao Chi > > Simplify the return expression. > > Applied to drm/drm-misc (drm-misc-next). Thanks! Maxime

RE: [Intel-gfx] [V2 3/3] drm/amd/display: Move connector debugfs to drm

2022-04-29 Thread Murthy, Arun R
> -Original Message- > From: Intel-gfx On Behalf Of > Bhanuprakash Modem > Sent: Monday, April 11, 2022 3:21 PM > To: intel-...@lists.freedesktop.org; dri-devel@lists.freedesktop.org; amd- > g...@lists.freedesktop.org; jani.nik...@linux.intel.com; > ville.syrj...@linux.intel.com;

RE: [Intel-gfx] [V2 1/3] drm/debug: Expose connector's max supported bpc via debugfs

2022-04-29 Thread Murthy, Arun R
> +static int output_bpc_show(struct seq_file *m, void *data) { Can we have a meaningful name instead of 'm' ? Upon changing this parameter name, you can have my Reviewed-By: Arun R Murthy Thanks and Regards, Arun R Murthy

Re: [PATCH v2] drm: mxsfb: Implement LCDIF scanout CRC32 support

2022-04-29 Thread Stefan Agner
On 2022-04-11 22:35, Marek Vasut wrote: > The LCDIF controller as present in i.MX28/i.MX6SX/i.MX8M Mini/Nano has > CRC_STAT register, which contains CRC32 of the frame as it was clocked > out of the DPI interface of the LCDIF. This is most likely meant as a > functional safety feature. > >

[CI] drm/i915: Fix assert in i915_ggtt_pin

2022-04-29 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Use lockdep_assert_not_held to simplify and correct the code. Otherwise false positive are hit if lock state is uknown like after a previous taint. Signed-off-by: Tvrtko Ursulin Reported-by: Ville Syrjälä Reviewed-by: Ville Syrjälä --- It's not pretty but it fired again

Re: [PATCH v2] drm: mxsfb: Implement LCDIF scanout CRC32 support

2022-04-29 Thread Lucas Stach
Am Montag, dem 11.04.2022 um 22:35 +0200 schrieb Marek Vasut: > The LCDIF controller as present in i.MX28/i.MX6SX/i.MX8M Mini/Nano has > CRC_STAT register, which contains CRC32 of the frame as it was clocked > out of the DPI interface of the LCDIF. This is most likely meant as a > functional

Re: [Intel-gfx] [PATCH 3/3] drm/i915/gt: Clear SET_PREDICATE_RESULT prior to executing the ring

2022-04-29 Thread Matthew Auld
On Mon, 25 Apr 2022 at 16:22, Ramalingam C wrote: > > From: Chris Wilson > > Userspace may leave predication enabled upon return from the batch > buffer, which has the consequent of preventing all operation from the > ring from being executed, including all the synchronisation, coherency >

[PATCH 4/4] drm/qxl: add drm_gem_plane_helper_prepare_fb

2022-04-29 Thread Christian König
We could need to wait for the pin to complete here. Signed-off-by: Christian König Cc: Dave Airlie Cc: Gerd Hoffmann Cc: virtualizat...@lists.linux-foundation.org Cc: spice-de...@lists.freedesktop.org --- drivers/gpu/drm/qxl/qxl_display.c | 8 +++- 1 file changed, 7 insertions(+), 1

[PATCH 3/4] drm/nouveau: use drm_gem_plane_helper_prepare_fb

2022-04-29 Thread Christian König
Instead of manually adjusting the plane state. Signed-off-by: Christian König Cc: Karol Herbst Cc: Lyude Paul Cc: Ben Skeggs Cc: Maxime Ripard --- drivers/gpu/drm/nouveau/dispnv50/wndw.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git

[PATCH 2/4] drm/amdgpu: switch DM to atomic fence helpers

2022-04-29 Thread Christian König
This gives us the standard atomic implicit and explicit fencing rules. Signed-off-by: Christian König Cc: Harry Wentland Cc: Nicholas Kazlauskas Cc: Roman Li Cc: Qingqing Zhuo Cc: Jude Shih Cc: Wayne Lin Cc: Rodrigo Siqueira --- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 23

[PATCH 1/4] drm: handle kernel fences in drm_gem_plane_helper_prepare_fb v2

2022-04-29 Thread Christian König
drm_gem_plane_helper_prepare_fb() was using drm_atomic_set_fence_for_plane() which ignores all implicit fences when an explicit fence is already set. That's rather unfortunate when the fb still has a kernel fence we need to wait for to avoid presenting garbage on the screen. So instead update the

[Bug 201991] amdgpu: clock management is disabled for the 4K resolution with polaris 10

2022-04-29 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=201991 Alex Deucher (alexdeuc...@gmail.com) changed: What|Removed |Added CC|

Re: [PATCH 2/3] drm/i915/selftests: Skip poisoning SET_PREDICATE_RESULT on dg2

2022-04-29 Thread Matthew Auld
On Mon, 25 Apr 2022 at 16:22, Ramalingam C wrote: > > From: Chris Wilson > > When predication is enabled all commands baring a few (such as MI_BB_END) > are nop'ed. If we accidentally enable predication while poisoning the > context, not only is the rest of the poisoning skipped (thus disabling

Re: [PATCH v5 6/9] drm: vkms: Refactor the plane composer to accept new formats

2022-04-29 Thread Pekka Paalanen
On Wed, 27 Apr 2022 21:44:34 -0300 Igor Torrente wrote: > On 4/27/22 04:43, Pekka Paalanen wrote: > > On Tue, 26 Apr 2022 22:22:22 -0300 > > Igor Torrente wrote: > > > >> On April 26, 2022 10:03:09 PM GMT-03:00, Igor Torrente > >> wrote: > >>> > >>> > >>> On 4/25/22 22:54, Igor Torrente

Re: [PATCH resend v8 1/5] drm/bridge: nwl-dsi: Set PHY mode in nwl_dsi_mode_set()

2022-04-29 Thread Liu Ying
Hi, On Fri, 2022-04-22 at 19:24 +0200, Guido Günther wrote: > Hi, > On Tue, Apr 19, 2022 at 09:08:48AM +0800, Liu Ying wrote: > > The Northwest Logic MIPI DSI host controller embedded in i.MX8qxp > > works with a Mixel MIPI DPHY + LVDS PHY combo to support either > > a MIPI DSI display or a LVDS

Re: [Intel-gfx] [PATCH 1/3] drm/i915/xehpsdv/dg1/tgl: Fix issue with LRI relative addressing

2022-04-29 Thread Matthew Auld
On Mon, 25 Apr 2022 at 16:22, Ramalingam C wrote: > > From: Akeem G Abodunrin > > When bit 19 of MI_LOAD_REGISTER_IMM instruction opcode is set on tgl+ > devices, HW does not care about certain register address offsets, but > instead check the following for valid address ranges on specific

Re: [PATCH 1/2] drm/edid: fix kernel-doc parameter name mismatches

2022-04-29 Thread Jani Nikula
On Tue, 26 Apr 2022, Jani Nikula wrote: > Fix the below drm/edid kernel-doc warnings: > > drivers/gpu/drm/drm_edid.c:1589: warning: Function parameter or member > '_edid' not described in 'drm_edid_header_is_valid' > drivers/gpu/drm/drm_edid.c:1589: warning: Excess function parameter >

Re: [RFC PATCH v4 02/11] drm/fb-helper: Set FBINFO_MISC_FIRMWARE flag for DRIVER_FIRMWARE fb

2022-04-29 Thread Javier Martinez Canillas
On 4/29/22 12:20, Thomas Zimmermann wrote: > Hi Javier [snip] >> >>> We can do this with DRIVER_FIRMWARE. Alternatively, I'd suggest to we >>> could also used the existing final parameter of >>> drm_fbdev_generic_setup() to pass a flag that designates a firmware device. >>> >> >> By existing

Re: linux-next: manual merge of the amdgpu tree with the drm-misc tree

2022-04-29 Thread Christian König
Am 29.04.22 um 03:13 schrieb Stephen Rothwell: Hi all, On Wed, 13 Apr 2022 10:10:14 +1000 Stephen Rothwell wrote: On Wed, 6 Apr 2022 10:34:05 +1000 Stephen Rothwell wrote: Today's linux-next merge of the amdgpu tree got a conflict in: drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c between

Re: [PULL] gvt-next-2022-04-29

2022-04-29 Thread Jani Nikula
On Thu, 28 Apr 2022, "Wang, Zhi A" wrote: > Hi folks: > > Here is the pull of gvt-next which fixes the compilation error and warnings > for the the GVT-g refactor patches: > > - Fix a compiling warning of non-static function only having one caller. > - Fix a potential NULL pointer reference in

Re: [PATCH 1/2] module: add a function to add module references

2022-04-29 Thread Greg KH
On Fri, Apr 29, 2022 at 11:23:51AM +0100, Mauro Carvalho Chehab wrote: > Em Fri, 29 Apr 2022 12:10:07 +0200 > Greg KH escreveu: > > > On Fri, Apr 29, 2022 at 10:15:03AM +0100, Mauro Carvalho Chehab wrote: > > > HI Greg, > > > > > > Em Fri, 29 Apr 2022 10:30:33 +0200 > > > Greg KH escreveu: > >

Re: [PATCH] omapdss: HDMI: simplify the return expression of hdmi_init_pll_data()

2022-04-29 Thread Tomi Valkeinen
On 29/04/2022 12:01, cgel@gmail.com wrote: From: Minghao Chi Simplify the return expression. Reported-by: Zeal Robot Signed-off-by: Minghao Chi --- drivers/gpu/drm/omapdrm/dss/hdmi_pll.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git

Re: [PATCH 1/2] module: add a function to add module references

2022-04-29 Thread Mauro Carvalho Chehab
Em Fri, 29 Apr 2022 12:10:07 +0200 Greg KH escreveu: > On Fri, Apr 29, 2022 at 10:15:03AM +0100, Mauro Carvalho Chehab wrote: > > HI Greg, > > > > Em Fri, 29 Apr 2022 10:30:33 +0200 > > Greg KH escreveu: > > > > > On Fri, Apr 29, 2022 at 09:07:57AM +0100, Mauro Carvalho Chehab wrote: > >

Re: [RFC PATCH v4 02/11] drm/fb-helper: Set FBINFO_MISC_FIRMWARE flag for DRIVER_FIRMWARE fb

2022-04-29 Thread Thomas Zimmermann
Hi Javier Am 29.04.22 um 11:23 schrieb Javier Martinez Canillas: Hello Thomas, On 4/29/22 11:14, Thomas Zimmermann wrote: Hi Am 29.04.22 um 10:42 schrieb Javier Martinez Canillas: The DRIVER_FIRMWARE flag denotes that a DRM driver uses a framebuffer that was initialized and provided by the

Re: [PATCH 1/2] module: add a function to add module references

2022-04-29 Thread Greg KH
On Fri, Apr 29, 2022 at 10:15:03AM +0100, Mauro Carvalho Chehab wrote: > HI Greg, > > Em Fri, 29 Apr 2022 10:30:33 +0200 > Greg KH escreveu: > > > On Fri, Apr 29, 2022 at 09:07:57AM +0100, Mauro Carvalho Chehab wrote: > > > Hi Daniel, > > > > > > Em Fri, 29 Apr 2022 09:54:10 +0200 > > > Daniel

[PATCH v4 4/5] fbdev: Rename pagelist to pagereflist for deferred I/O

2022-04-29 Thread Thomas Zimmermann
Rename various instances of pagelist to pagereflist. The list now stores pageref structures, so the new name is more appropriate. In their write-back helpers, several fbdev drivers refer to the pageref list in struct fb_deferred_io instead of using the one supplied as argument to the function.

[PATCH v4 3/5] fbdev: Refactor implementation of page_mkwrite

2022-04-29 Thread Thomas Zimmermann
Refactor the page-write handler for deferred I/O. Drivers use the function to let fbdev track written pages of mmap'ed framebuffer memory. v3: * keep locking within track-pages function for readability (Sam) v2: * don't export the helper until we have an external caller

[PATCH v4 2/5] fbdev: Track deferred-I/O pages in pageref struct

2022-04-29 Thread Thomas Zimmermann
Store the per-page state for fbdev's deferred I/O in struct fb_deferred_io_pageref. Maintain a list of pagerefs for the pages that have to be written back to video memory. Update all affected drivers. As with pages before, fbdev acquires a pageref when an mmaped page of the framebuffer is being

[PATCH v4 5/5] fbdev: Use pageref offset for deferred-I/O writeback

2022-04-29 Thread Thomas Zimmermann
Use pageref->offset instead of page->index for deferred-I/O writeback where appropriate. Distinguishes between file-mapping offset and video- memory offset. While at it, also remove unnecessary references to struct page. Fbdev's deferred-I/O code uses the two related page->index and

  1   2   >