Re: [PATCH v2 05/12] drm/i915/pvc: Remove additional 3D flags from PIPE_CONTROL

2022-05-10 Thread Matt Roper
On Fri, May 06, 2022 at 10:23:41AM -0700, Lucas De Marchi wrote: > On Thu, May 05, 2022 at 02:38:05PM -0700, Matt Roper wrote: > > From: Stuart Summers > > > > Although we already strip 3D-specific flags from PIPE_CONTROL > > instructions when submitting to a compute engine, there are some > >

[PATCH] drm/meson: Fix refcount leak in meson_encoder_hdmi_init

2022-05-10 Thread Miaoqian Lin
of_find_device_by_node() takes reference, we should use put_device() to release it when not need anymore. Add missing put_device() in error path to avoid refcount leak. Fixes: 0af5e0b41110 ("drm/meson: encoder_hdmi: switch to bridge DRM_BRIDGE_ATTACH_NO_CONNECTOR") Signed-off-by: Miaoqian Lin

[PATCH v2 3/3] drm/panel: introduce ebbg,ft8719 panel

2022-05-10 Thread Joel Selvaraj
Add DRM panel driver for EBBG FT8719 6.18" 2246x1080 DSI video mode panel, which can be found on some Xiaomi Poco F1 phones. The panel's backlight is managed through QCOM WLED driver. Signed-off-by: Joel Selvaraj --- MAINTAINERS | 7 +

[PATCH v2 2/3] dt-bindings: display: Add bindings for EBBG FT8719

2022-05-10 Thread Joel Selvaraj
Add bindings for the EBBG FT8719 6.18" 2246x1080 DSI video mode panel, which can be found on some Xiaomi Poco F1 phones. The backlight is managed through the QCOM WLED driver. Signed-off-by: Joel Selvaraj --- Changes in v2: (Krzysztof Kozlowski's Suggestions) - Specify maxItems for reg -

[PATCH v2 1/3] dt-bindings: vendor-prefixes: Add prefix for EBBG

2022-05-10 Thread Joel Selvaraj
Add a prefix for EBBG. They manufacture displays which are used in some Xiaomi phones, but I could not find much details about the company. Signed-off-by: Joel Selvaraj --- Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git

[PATCH v2 0/3] Introduce EBBG FT8719 DRM panel driver

2022-05-10 Thread Joel Selvaraj
Add bindings and DRM panel driver for EBBG FT8719 6.18" 2246x1080 DSI video mode panel, which can be found on some Xiaomi Poco F1 phones. The panel's backlight is managed through QCOM WLED driver. The driver is built using linux-mdss-dsi-panel-driver-generator[1], and additionally support for

Adding CI results to the kernel tree was Re: [RFC v2] drm/msm: Add initial ci/ subdirectory

2022-05-10 Thread Dave Airlie
> And use it to store expectations about what the drm/msm driver is > supposed to pass in the IGT test suite. I wanted to loop in Linus/Greg to see if there are any issues raised by adding CI results file to the tree in their minds, or if any other subsystem has done this already, and it's all

Re: [Freedreno] [RFC v2] drm/msm: Add initial ci/ subdirectory

2022-05-10 Thread Tomeu Vizoso
On 5/10/22 9:39 PM, Jessica Zhang wrote: On 5/10/2022 7:13 AM, Tomeu Vizoso wrote: +igt@kms_atomic_interruptible@legacy-setmode@pipe-a-edp-1 +igt@kms_atomic_interruptible@atomic-setmode@pipe-a-edp-1 +igt@kms_atomic_interruptible@legacy-dpms@pipe-a-edp-1

Re: [PATCH RFC v6 00/21] DEPT(Dependency Tracker)

2022-05-10 Thread Byungchul Park
On Tue, May 10, 2022 at 02:37:40PM +0900, Byungchul Park wrote: > Ted wrote: > > On Tue, May 10, 2022 at 09:32:13AM +0900, Byungchul Park wrote: > > > DEPT is tracking way more objects than Lockdep so it's inevitable to be > > > slower, but let me try to make it have the similar performance to > >

[PATCH v4 0/3] Clear TLB caches in all tiles when object is removed

2022-05-10 Thread Andi Shyti
Hi, Maybe I should not send patches this late at night as I end up messing things up and spamming sleeping people. Sorry for this version 4. The real fix is in patch 2. The rest is a helper that adds the with_intel_gt_pm_if_awake() (from Chris) and one more check on the status of the engine

[PATCH v4 3/3] drm/i915/gt: Skip TLB invalidation if the engine is not awake

2022-05-10 Thread Andi Shyti
We want to check if the engine is awake first before invalidating its cache. Suggested-by: Chris Wilson Signed-off-by: Andi Shyti --- drivers/gpu/drm/i915/gt/intel_gt.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/i915/gt/intel_gt.c

[PATCH v4 2/3] drm/i915/gem: Flush TLBs for all the tiles when clearing an obj

2022-05-10 Thread Andi Shyti
During object cleanup we invalidate the TLBs but we do it only for gt0. Invalidate the caches for all the tiles. Reported-by: Chris Wilson Signed-off-by: Andi Shyti --- drivers/gpu/drm/i915/gem/i915_gem_pages.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git

[PATCH v4 1/3] drm/i915/gt: Ignore TLB invalidations on idle engines

2022-05-10 Thread Andi Shyti
From: Chris Wilson As an extension of the current skip TLB invalidations if the device is powered down, we recognised that prior to any engine activity, all the TLBs are explicitly invalidated. Thus anytime we know the engine is asleep, we can skip invalidating the TLBs on that engine.

Re: [PATCH v3 3/4] drm/bridge: Add devm_drm_bridge_add()

2022-05-10 Thread Dmitry Baryshkov
On Tue, 10 May 2022 at 22:30, Douglas Anderson wrote: > > This adds a devm managed version of drm_bridge_add(). Like other > "devm" function listed in drm_bridge.h, this function takes an > explicit "dev" to use for the lifetime management. A few notes: > * In general we have a "struct device"

Re: [PATCH v3 1/4] drm/dp: Export symbol / kerneldoc fixes for DP AUX bus

2022-05-10 Thread Dmitry Baryshkov
On Tue, 10 May 2022 at 22:29, Douglas Anderson wrote: > > While working on the DP AUX bus code I found a few small things that > should be fixed. Namely the non-devm version of > of_dp_aux_populate_ep_devices() was missing an export. There was also > an extra blank line in a kerneldoc and a

Re: [PATCH] drm/msm/dpu: add writeback support for sc7180

2022-05-10 Thread Dmitry Baryshkov
On Wed, 11 May 2022 at 02:55, Abhinav Kumar wrote: > > Add writeback support for sc7180 devices. This has been > validated on sc7180 chromebook using IGT writeback test > suite. > > localhost /usr/local/libexec/igt-gpu-tools # ./kms_writeback > Starting subtest: writeback-pixel-formats > Subtest

[PATCH 3/3] drm/virtio: use the fence for every plane update

2022-05-10 Thread Dongwon Kim
Trying to use the fence to make plane update to wait for the host to consume the buffer for better synchronization in all cases Cc: Gurchetan Singh Cc: Gerd Hoffmann Cc: Vivek Kasireddy Signed-off-by: Dongwon Kim --- drivers/gpu/drm/virtio/virtgpu_plane.c | 7 +-- 1 file changed, 1

[PATCH 2/3] drm/virtio: fence created per cursor/plane update

2022-05-10 Thread Dongwon Kim
Having one fence for a vgfb would cause conflict in case there are multiple planes referencing the same vgfb (e.g. Xorg screen covering two displays in extended mode) being flushed simultaneously. So it makes sence to use a separated fence for each plane update to prevent this. vgfb->fence is not

[PATCH 1/3] drm/virtio: .release ops for virtgpu fence release

2022-05-10 Thread Dongwon Kim
virtio_gpu_fence_release is added to free virtio-gpu-fence upon release of dma_fence. Cc: Gurchetan Singh Cc: Gerd Hoffmann Cc: Vivek Kasireddy Signed-off-by: Dongwon Kim --- drivers/gpu/drm/virtio/virtgpu_fence.c | 8 1 file changed, 8 insertions(+) diff --git

Re: [RFC PATCH] drm/edid: drm_add_modes_noedid() should set lowest resolution as preferred

2022-05-10 Thread Abhinav Kumar
Hi Doug On 5/10/2022 2:41 PM, Doug Anderson wrote: Hi, On Tue, May 10, 2022 at 2:33 PM Abhinav Kumar wrote: Hi Doug On 5/10/2022 1:53 PM, Doug Anderson wrote: Hi, On Fri, May 6, 2022 at 9:33 AM Abhinav Kumar wrote: Hi Jani On 5/6/2022 4:16 AM, Jani Nikula wrote: On Thu, 05 May 2022,

Re: [PATCH v2] drm/probe-helper: Default to 640x480 if no EDID

2022-05-10 Thread Abhinav Kumar
On 5/10/2022 1:51 PM, Douglas Anderson wrote: If we're unable to read the EDID for a display because it's corrupt / bogus / invalid then we'll add a set of standard modes for the display. When userspace looks at these modes it doesn't really have a good concept for which mode to pick and

[PATCH] drm/msm/dpu: add writeback support for sc7180

2022-05-10 Thread Abhinav Kumar
Add writeback support for sc7180 devices. This has been validated on sc7180 chromebook using IGT writeback test suite. localhost /usr/local/libexec/igt-gpu-tools # ./kms_writeback Starting subtest: writeback-pixel-formats Subtest writeback-pixel-formats: SUCCESS (0.001s) Starting subtest:

Re: [PATCH RFC v6 00/21] DEPT(Dependency Tracker)

2022-05-10 Thread Byungchul Park
On Tue, May 10, 2022 at 08:18:12PM +0900, Hyeonggon Yoo wrote: > On Mon, May 09, 2022 at 09:16:37AM +0900, Byungchul Park wrote: > > On Sat, May 07, 2022 at 04:20:50PM +0900, Hyeonggon Yoo wrote: > > > On Fri, May 06, 2022 at 09:11:35AM +0900, Byungchul Park wrote: > > > > Linus wrote: > > > > > >

Re: [PATCH RFC v6 00/21] DEPT(Dependency Tracker)

2022-05-10 Thread Byungchul Park
On Tue, May 10, 2022 at 10:12:54AM -0400, Steven Rostedt wrote: > On Tue, 10 May 2022 08:38:38 +0900 > Byungchul Park wrote: > > > Yes, I was talking about A and L'. > > > > > detect that regardless of L. A nested lock associates the the nesting > > > with > > > > When I checked Lockdep

Re: [PATCH v11 20/24] arm64: dts: rockchip: enable vop2 and hdmi tx on rock-3a

2022-05-10 Thread Peter Geis
On Tue, May 10, 2022 at 4:54 PM Peter Geis wrote: > > On Tue, May 10, 2022 at 9:49 AM Piotr Oniszczuk > wrote: > > > > > > > > > Wiadomość napisana przez Peter Geis w dniu > > > 10.05.2022, o godz. 14:08: > > > > > > > > > You are on the clk_rtc32k_frac which is a fractional divider that is >

Re: [PATCH V2] dmabuf: ensure unique directory name for dmabuf stats

2022-05-10 Thread kernel test robot
Hi Charan, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on linus/master] [also build test WARNING on v5.18-rc6 next-20220510] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base

Re: [RFC PATCH] drm/edid: drm_add_modes_noedid() should set lowest resolution as preferred

2022-05-10 Thread Doug Anderson
Hi, On Tue, May 10, 2022 at 2:33 PM Abhinav Kumar wrote: > > Hi Doug > > On 5/10/2022 1:53 PM, Doug Anderson wrote: > > Hi, > > > > On Fri, May 6, 2022 at 9:33 AM Abhinav Kumar > > wrote: > >> > >> Hi Jani > >> > >> On 5/6/2022 4:16 AM, Jani Nikula wrote: > >>> On Thu, 05 May 2022, Doug

Re: [PATCH v2 08/12] drm: bridge: samsung-dsim: Add atomic_check

2022-05-10 Thread Marek Szyprowski
On 04.05.2022 13:40, Jagan Teki wrote: > Fixing up the mode flags is required in order to correlate the > correct sync flags of the surrounding components in the chain > to make sure the whole pipeline can work properly. > > So, handle the mode flags via bridge, atomic_check. > > v2: > * none > >

[PATCH v2 3/3] drm/i915/gt: Skip TLB invalidation if the engine is not awake

2022-05-10 Thread Andi Shyti
We want to check if the engine is awake first before invalidating its cache. Suggested-by: Chris Wilson Signed-off-by: Andi Shyti --- drivers/gpu/drm/i915/gt/intel_gt.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/i915/gt/intel_gt.c

[PATCH v2 2/3] drm/i915/gem: Flush TLBs for all the tiles when clearing an obj

2022-05-10 Thread Andi Shyti
During object cleanup we invalidate the TLBs but we do it only for gt0. Invalidate the caches for all the tiles. Reported-by: Chris Wilson Signed-off-by: Andi Shyti --- drivers/gpu/drm/i915/gem/i915_gem_pages.c | 12 +--- drivers/gpu/drm/i915/gt/intel_gt_pm.h | 2 +- 2 files

[PATCH v2 1/3] drm/i915/gt: Ignore TLB invalidations on idle engines

2022-05-10 Thread Andi Shyti
From: Chris Wilson As an extension of the current skip TLB invalidations if the device is powered down, we recognised that prior to any engine activity, all the TLBs are explicitly invalidated. Thus anytime we know the engine is asleep, we can skip invalidating the TLBs on that engine.

Re: [RFC PATCH] drm/edid: drm_add_modes_noedid() should set lowest resolution as preferred

2022-05-10 Thread Abhinav Kumar
Hi Doug On 5/10/2022 1:53 PM, Doug Anderson wrote: Hi, On Fri, May 6, 2022 at 9:33 AM Abhinav Kumar wrote: Hi Jani On 5/6/2022 4:16 AM, Jani Nikula wrote: On Thu, 05 May 2022, Doug Anderson wrote: Ville, On Tue, Apr 26, 2022 at 1:21 PM Douglas Anderson wrote: If we're unable to read

[PATCH v2 0/3] Clear TLB caches in all tiles when object is removed

2022-05-10 Thread Andi Shyti
Hi, The real fix is in patch 2. The rest is a helper that adds the with_intel_gt_pm_if_awake() (from Chris) and one more check on the status of the engine before accessing it for clearing the TLB. Andi Andi Shyti (2): drm/i915/gem: Flush TLBs for all the tiles when clearing an obj

Re: [PATCH v11 20/24] arm64: dts: rockchip: enable vop2 and hdmi tx on rock-3a

2022-05-10 Thread Peter Geis
On Tue, May 10, 2022 at 9:49 AM Piotr Oniszczuk wrote: > > > > > Wiadomość napisana przez Peter Geis w dniu > > 10.05.2022, o godz. 14:08: > > > > > > You are on the clk_rtc32k_frac which is a fractional divider that is > > fed from the 24m clock. Your clock likely isn't the issue here. I'd > >

Re: [RFC PATCH] drm/edid: drm_add_modes_noedid() should set lowest resolution as preferred

2022-05-10 Thread Doug Anderson
Hi, On Fri, May 6, 2022 at 9:33 AM Abhinav Kumar wrote: > > Hi Jani > > On 5/6/2022 4:16 AM, Jani Nikula wrote: > > On Thu, 05 May 2022, Doug Anderson wrote: > >> Ville, > >> > >> On Tue, Apr 26, 2022 at 1:21 PM Douglas Anderson > >> wrote: > >>> > >>> If we're unable to read the EDID for a

[PATCH v2] drm/probe-helper: Default to 640x480 if no EDID

2022-05-10 Thread Douglas Anderson
If we're unable to read the EDID for a display because it's corrupt / bogus / invalid then we'll add a set of standard modes for the display. When userspace looks at these modes it doesn't really have a good concept for which mode to pick and it'll likely pick the highest resolution one by

Re: [BUG] Warning and NULL-ptr dereference in amdgpu driver with 5.18

2022-05-10 Thread Alex Deucher
On Tue, May 10, 2022 at 2:17 PM Jörg Rödel wrote: > > > > Am 10.05.2022 um 17:31 schrieb Alex Deucher : > > > > On Tue, May 10, 2022 at 7:12 AM Jörg Rödel wrote: > >> > >> Gentle ping. This is a 5.18 regression and I also see it with > >> 5.18-rc6. Please let me know if you need anything else to

[PATCH] drm/i915/gem: Flush TLBs for all the tiles

2022-05-10 Thread Andi Shyti
During object cleanup we invalidate the TLBs but we do it only for gt0. Invalidate the caches for all the tiles. Reported-by: Chris Wilson Signed-off-by: Andi Shyti --- drivers/gpu/drm/i915/gem/i915_gem_pages.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git

Re: [PATCH v5 8/9] drm: vkms: Adds XRGB_16161616 and ARGB_1616161616 formats

2022-05-10 Thread Igor Torrente
Hi Thomas On 5/7/22 04:32, Thomas Zimmermann wrote: Hi Am 04.04.22 um 22:45 schrieb Igor Torrente: This will be useful to write tests that depends on these formats. ARGB and XRGB follows the a similar implementation of the former formats. Just adjusting for 16 bits per channel. V3: Adapt

Re: [Freedreno] [RFC v2] drm/msm: Add initial ci/ subdirectory

2022-05-10 Thread Rob Clark
On Tue, May 10, 2022 at 12:39 PM Jessica Zhang wrote: > > > > On 5/10/2022 7:13 AM, Tomeu Vizoso wrote: > > And use it to store expectations about what the drm/msm driver is > > supposed to pass in the IGT test suite. > > > > Also include a configuration file that points to the out-of-tree CI > >

[PATCH v2 2/2] drm/probe-helper: For DP, add 640x480 if all other modes are bad

2022-05-10 Thread Douglas Anderson
As per Displayport spec section 5.2.1.2 ("Video Timing Format") says that all detachable sinks shall support 640x480 @60Hz as a fail safe mode. A DP compliance test expected us to utilize the above fact when all modes it presented to the DP source were not achievable. It presented only modes that

[PATCH v2 1/2] drm/probe-helper: Add helper for drm_helper_probe_single_connector_modes()

2022-05-10 Thread Douglas Anderson
The drm_helper_probe_single_connector_modes() is a bit long. Let's break a chunk off to update and validate modes. This helps avoid one goto and also will allow us to more easily call the helper a second time in a future patch without adding looping or another goto. This change is intended to be

Re: [Freedreno] [RFC v2] drm/msm: Add initial ci/ subdirectory

2022-05-10 Thread Jessica Zhang
On 5/10/2022 7:13 AM, Tomeu Vizoso wrote: And use it to store expectations about what the drm/msm driver is supposed to pass in the IGT test suite. Also include a configuration file that points to the out-of-tree CI scripts. By storing the test expectations along the code we can make sure

[PATCH v3 3/4] drm/bridge: Add devm_drm_bridge_add()

2022-05-10 Thread Douglas Anderson
This adds a devm managed version of drm_bridge_add(). Like other "devm" function listed in drm_bridge.h, this function takes an explicit "dev" to use for the lifetime management. A few notes: * In general we have a "struct device" for bridges that makes a good candidate for where the lifetime

[PATCH v3 4/4] drm/bridge: parade-ps8640: Handle DP AUX more properly

2022-05-10 Thread Douglas Anderson
While it works, for the most part, to assume that the panel has finished probing when devm_of_dp_aux_populate_ep_devices() returns, it's a bit fragile. This is talked about at length in commit a1e3667a9835 ("drm/bridge: ti-sn65dsi86: Promote the AUX channel to its own sub-dev"). When reviewing

[PATCH v3 1/4] drm/dp: Export symbol / kerneldoc fixes for DP AUX bus

2022-05-10 Thread Douglas Anderson
While working on the DP AUX bus code I found a few small things that should be fixed. Namely the non-devm version of of_dp_aux_populate_ep_devices() was missing an export. There was also an extra blank line in a kerneldoc and a kerneldoc that incorrectly documented a return value. Fix these.

[PATCH v3 2/4] drm/dp: Add callbacks to make using DP AUX bus properly easier

2022-05-10 Thread Douglas Anderson
As talked about in this patch in the kerneldoc of of_dp_aux_populate_ep_device() and also in the past in commit a1e3667a9835 ("drm/bridge: ti-sn65dsi86: Promote the AUX channel to its own sub-dev"), it can be difficult for eDP controller drivers to know when the panel has finished probing when

[PATCH v3 0/4] drm/dp: Make DP AUX bus usage easier; use it on ps8640

2022-05-10 Thread Douglas Anderson
This patch is v3 of the first 2 patches from my RFC series ("drm/dp: Improvements for DP AUX channel") [1]. I've broken the series in two so we can make progress on the two halves separately. v2 of this series tries to incorporate all the feedback from v1. Hopefully things are less confusing and

Re: [PATCH v5 9/9] drm: vkms: Add support to the RGB565 format

2022-05-10 Thread Igor Torrente
On 5/9/22 04:53, Pekka Paalanen wrote: On Fri, 6 May 2022 20:05:39 -0300 Igor Torrente wrote: Hi Pekka, On 4/27/22 04:55, Pekka Paalanen wrote: On Tue, 26 Apr 2022 21:53:19 -0300 Igor Torrente wrote: Hi Pekka, On 4/21/22 07:58, Pekka Paalanen wrote: On Mon, 4 Apr 2022 17:45:15

Re: [PATCH v3 1/3] drm/print: Add drm_debug_once* macros

2022-05-10 Thread Souza, Jose
On Tue, 2022-05-10 at 21:33 +0300, Jouni Högander wrote: > Add drm_debug_once* macros to allow printing out one time debug > messages which can be still controlled via drm.debug parameter. Reviewed-by: José Roberto de Souza > > Cc: José Roberto de Souza > Cc: Mika Kahola > Cc: Mark Pearson

[PATCH] drm: Create support for Write-Only property blob

2022-05-10 Thread Mark Yacoub
[Why] User space might need to inject data into the kernel without allowing it to be read again by any user space. An example of where this is particularly useful is secret keys fetched by user space and injected into the kernel to enable content protection. [How] Create a

Re: [PATCH v3 3/3] drm/i915: Ensure damage clip area is within pipe area

2022-05-10 Thread Souza, Jose
On Tue, 2022-05-10 at 21:33 +0300, Jouni Högander wrote: > Current update area calculation is not handling situation where > e.g. cursor plane is fully or partially outside pipe area. > > Fix this by checking damage area against pipe_src area using > drm_rect_intersect. > > v2: Set x1 and x2 in

Re: [PATCH v3 2/3] drm/i915/psr: Use full update In case of area calculation fails

2022-05-10 Thread Souza, Jose
On Tue, 2022-05-10 at 21:33 +0300, Jouni Högander wrote: > Currently we have some corner cases where area calculation fails. For > these sel fetch area calculation ends up having update area as y1 = 0, > y2 = 4. Instead of these values safer option is full update. > > One of such for example is

Re: [BUG] Warning and NULL-ptr dereference in amdgpu driver with 5.18

2022-05-10 Thread Jörg Rödel
> Am 10.05.2022 um 17:31 schrieb Alex Deucher : > > On Tue, May 10, 2022 at 7:12 AM Jörg Rödel wrote: >> >> Gentle ping. This is a 5.18 regression and I also see it with >> 5.18-rc6. Please let me know if you need anything else to debug. >> > > Are you doing anything special when it

Re: [BUG] Warning and NULL-ptr dereference in amdgpu driver with 5.18

2022-05-10 Thread Jörg Rödel
Gentle ping. This is a 5.18 regression and I also see it with 5.18-rc6. Please let me know if you need anything else to debug. Thanks, Joerg On Fri, May 06, 2022 at 09:16:12AM -0400, Alex Deucher wrote: > + some display folks > > On Fri, May 6, 2022 at 6:19 AM Jörg Rödel wrote: > > >

[PATCH v3 2/3] drm/i915/psr: Use full update In case of area calculation fails

2022-05-10 Thread Jouni Högander
Currently we have some corner cases where area calculation fails. For these sel fetch area calculation ends up having update area as y1 = 0, y2 = 4. Instead of these values safer option is full update. One of such for example is big fb with offset. We don't have usable offset in

[PATCH v3 3/3] drm/i915: Ensure damage clip area is within pipe area

2022-05-10 Thread Jouni Högander
Current update area calculation is not handling situation where e.g. cursor plane is fully or partially outside pipe area. Fix this by checking damage area against pipe_src area using drm_rect_intersect. v2: Set x1 and x2 in damaged_area initialization v3: Move drm_rect_intersect into

[PATCH v3 1/3] drm/print: Add drm_debug_once* macros

2022-05-10 Thread Jouni Högander
Add drm_debug_once* macros to allow printing out one time debug messages which can be still controlled via drm.debug parameter. Cc: José Roberto de Souza Cc: Mika Kahola Cc: Mark Pearson Signed-off-by: Jouni Högander --- include/drm/drm_print.h | 29 + 1 file

[PATCH v3 0/3] Fixes for selective fetch area calculation

2022-05-10 Thread Jouni Högander
Currently selective fetch area calculation ends up as bogus area in at least following cases: 1. Updated plane is partially or fully outside pipe area 2. Big fb with only part of memory area used for plane These end up as y1 = 0, y2 = 4 or y2 being outside pipe area. This patch set addresses

[PATCH] drm: Add a debug message when getting a prop is missing

2022-05-10 Thread Mark Yacoub
[Why] If a connector property is attached but drm_atomic_connector_get_property doesn't handle a case for it, modeteset will crash with a segfault without. [How] Add a debug message indicating that a connector property is not handled when user space is trying to read it. TEST=modetest

Re: [PATCH] drm/bridge: simplify the return expression of ps8640_bridge_host_attach

2022-05-10 Thread Doug Anderson
Hi, On Fri, Apr 29, 2022 at 9:21 AM Doug Anderson wrote: > > Hi, > > On Thu, Apr 28, 2022 at 10:51 PM wrote: > > > > From: Minghao Chi > > > > Simplify the return expression. > > > > Reported-by: Zeal Robot > > Signed-off-by: Minghao Chi > > --- > > drivers/gpu/drm/bridge/parade-ps8640.c |

Re: [PATCH v0.5 5/9] dt-bindings: phy: add binding for the i.MX8MP HDMI PHY

2022-05-10 Thread Rob Herring
On Fri, May 06, 2022 at 08:10:30PM +0200, Lucas Stach wrote: > Add a DT binding for the HDMI PHY found on the i.MX8MP SoC. > > Signed-off-by: Lucas Stach > --- > .../bindings/phy/fsl,imx8mp-hdmi-phy.yaml | 62 +++ > 1 file changed, 62 insertions(+) > create mode 100644 >

Re: [PATCH v0.5 1/9] dt-bindings: display: imx: add binding for i.MX8MP HDMI TX

2022-05-10 Thread Rob Herring
On Fri, May 06, 2022 at 08:10:26PM +0200, Lucas Stach wrote: > The HDMI TX controller on the i.MX8MP SoC is a Synopsys designware IP > core with a little bit of SoC integration around it. > > Signed-off-by: Lucas Stach > --- > .../bindings/display/imx/fsl,imx8mp-hdmi.yaml | 73

Re: [PATCH] drm/msm: Fix fb plane offset calculation

2022-05-10 Thread Stephen Boyd
Quoting Rob Clark (2022-05-10 09:52:16) > From: Rob Clark > > The offset got dropped by accident. > > Fixes: d413e6f97134 ("drm/msm: Drop msm_gem_iova()") > Signed-off-by: Rob Clark > --- Reviewed-by: Stephen Boyd Tested-by: Stephen Boyd # CoachZ

Re: [PATCH] drm/msm: Fix fb plane offset calculation

2022-05-10 Thread Rob Clark
On Tue, May 10, 2022 at 10:46 AM Dmitry Baryshkov wrote: > > On Tue, 10 May 2022 at 19:52, Rob Clark wrote: > > > > From: Rob Clark > > > > The offset got dropped by accident. > > > > Fixes: d413e6f97134 ("drm/msm: Drop msm_gem_iova()") > > Signed-off-by: Rob Clark > > Reviewed-by: Dmitry

Re: [PATCH] drm/msm: Fix fb plane offset calculation

2022-05-10 Thread Dmitry Baryshkov
On Tue, 10 May 2022 at 19:52, Rob Clark wrote: > > From: Rob Clark > > The offset got dropped by accident. > > Fixes: d413e6f97134 ("drm/msm: Drop msm_gem_iova()") > Signed-off-by: Rob Clark Reviewed-by: Dmitry Baryshkov > --- > drivers/gpu/drm/msm/msm_fb.c | 2 +- > 1 file changed, 1

Re: [PATCH] drm/msm: Fix fb plane offset calculation

2022-05-10 Thread Abhinav Kumar
On 5/10/2022 9:52 AM, Rob Clark wrote: From: Rob Clark The offset got dropped by accident. Fixes: d413e6f97134 ("drm/msm: Drop msm_gem_iova()") Signed-off-by: Rob Clark Reviewed-by: Abhinav Kumar --- drivers/gpu/drm/msm/msm_fb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [PATCH V2] dmabuf: ensure unique directory name for dmabuf stats

2022-05-10 Thread Christian König
Am 10.05.22 um 19:14 schrieb Charan Teja Kalla: On 5/10/2022 8:42 PM, Christian König wrote:    * The information in the interface can also be used to derive per-exporter    * statistics. The data from the interface can be gathered on error conditions @@ -172,6 +172,7 @@ int

Re: [PATCH 1/3] dt-bindings: display: rockchip: make reg-names mandatory for VOP2

2022-05-10 Thread Rob Herring
On Tue, May 10, 2022 at 04:08:02PM +0200, Heiko Stübner wrote: > Hi Sascha, > > Am Dienstag, 10. Mai 2022, 09:09:12 CEST schrieb Sascha Hauer: > > The VOP2 driver relies on reg-names properties, but these are not > > documented. Add the missing documentation, make reg-names mandatory > > and

[PATCH] drm/i2c: tda9950: Lower severity of log message about missing interrupts

2022-05-10 Thread Mark Brown
The tda9950 driver prints an error message if it is instantiated without an interrupt being available since the device is non-functional in that case. Unfortunately due to packaging of tda9950 with tda998x series devices the tda998x driver unconditionally instantiates a tda9950 so systems with a

Re: [PATCH 1/3] dt-bindings: display: rockchip: make reg-names mandatory for VOP2

2022-05-10 Thread Rob Herring
On Tue, May 10, 2022 at 09:09:12AM +0200, Sascha Hauer wrote: > The VOP2 driver relies on reg-names properties, but these are not > documented. Add the missing documentation, make reg-names mandatory > and increase minItems to 2 as always both register spaces are needed. > > Signed-off-by: Sascha

Re: [PATCH V2] dmabuf: ensure unique directory name for dmabuf stats

2022-05-10 Thread Charan Teja Kalla
On 5/10/2022 8:42 PM, Christian König wrote: >>    * The information in the interface can also be used to derive >> per-exporter >>    * statistics. The data from the interface can be gathered on error >> conditions >> @@ -172,6 +172,7 @@ int dma_buf_stats_setup(struct dma_buf *dmabuf) >>   { >>   

Re: [Bug 215958] New: thunderbolt3 egpu cannot disconnect cleanly

2022-05-10 Thread Andrey Grodzovsky
On 2022-05-09 14:03, Deucher, Alexander wrote: [Public] -Original Message- From: Bjorn Helgaas Sent: Monday, May 9, 2022 12:23 PM To: Linux PCI Cc: r087...@yahoo.it; Deucher, Alexander ; Koenig, Christian ; Pan, Xinhui ; amd-gfx mailing list ; dri-devel Subject: Re: [Bug 215958]

[PATCH] drm/msm: Fix fb plane offset calculation

2022-05-10 Thread Rob Clark
From: Rob Clark The offset got dropped by accident. Fixes: d413e6f97134 ("drm/msm: Drop msm_gem_iova()") Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/msm_fb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/msm_fb.c b/drivers/gpu/drm/msm/msm_fb.c

Re: [BUG] Warning and NULL-ptr dereference in amdgpu driver with 5.18

2022-05-10 Thread Alex Deucher
On Tue, May 10, 2022 at 7:12 AM Jörg Rödel wrote: > > Gentle ping. This is a 5.18 regression and I also see it with > 5.18-rc6. Please let me know if you need anything else to debug. > Are you doing anything special when it happens? I.e., does it happen when the monitor is coming out of DPMS or

Re: [PATCH V2] dmabuf: ensure unique directory name for dmabuf stats

2022-05-10 Thread Christian König
Am 10.05.22 um 16:06 schrieb Charan Teja Kalla: The dmabuf file uses get_next_ino()(through dma_buf_getfile() -> alloc_anon_inode()) to get an inode number and uses the same as a directory name under /sys/kernel/dmabuf/buffers/. This directory is used to collect the dmabuf stats and it is

Re: [PATCH] drm/amdgpu: clean up some inconsistent indenting

2022-05-10 Thread Alex Deucher
Applied. Thanks! Alex On Tue, May 10, 2022 at 2:05 AM Jiapeng Chong wrote: > > Eliminate the follow smatch warning: > > drivers/gpu/drm/amd/amdgpu/nbio_v7_7.c:35 nbio_v7_7_get_rev_id() warn: > inconsistent indenting. > > drivers/gpu/drm/amd/amdgpu/nbio_v7_7.c:214 nbio_v7_7_init_registers() >

Re: [PATCH] drm/amdgpu: Remove duplicated argument in vcn_v4_0

2022-05-10 Thread Alex Deucher
Applied. Thanks! Alex On Mon, May 9, 2022 at 10:50 PM Wan Jiabing wrote: > > Fix following coccicheck warning: > ./drivers/gpu/drm/amd/amdgpu/vcn_v4_0.c:724:4-36: duplicated argument to & or > | > > Remove duplicated UVD_SUVD_CGC_GATE__SRE_H264_MASK. > > Signed-off-by: Wan Jiabing > --- >

[PATCH] drm/stm: ltdc: fix unchecked dereferenced pointer

2022-05-10 Thread Raphael Gallais-Pou
Pointer of struct *drm_crtc was dereferenced before checking it was non NULL. This could potentially create a kernel panic. Fixes: 79b44684a14e ("drm/stm: ltdc: add support for CRC hashing feature") Reported-by: kernel test robot Reported-by: Dan Carpenter Signed-off-by: Raphael Gallais-Pou

[RFC v2] drm/msm: Add initial ci/ subdirectory

2022-05-10 Thread Tomeu Vizoso
And use it to store expectations about what the drm/msm driver is supposed to pass in the IGT test suite. Also include a configuration file that points to the out-of-tree CI scripts. By storing the test expectations along the code we can make sure both stay in sync with each other, and so we can

Re: [PATCH RFC v6 00/21] DEPT(Dependency Tracker)

2022-05-10 Thread Steven Rostedt
On Tue, 10 May 2022 08:38:38 +0900 Byungchul Park wrote: > Yes, I was talking about A and L'. > > > detect that regardless of L. A nested lock associates the the nesting with > > When I checked Lockdep code, L' with depth n + 1 and L' with depth n > have different classes in Lockdep. If

Re: [PATCH 1/3] dt-bindings: display: rockchip: make reg-names mandatory for VOP2

2022-05-10 Thread Heiko Stübner
Hi Sascha, Am Dienstag, 10. Mai 2022, 09:09:12 CEST schrieb Sascha Hauer: > The VOP2 driver relies on reg-names properties, but these are not > documented. Add the missing documentation, make reg-names mandatory > and increase minItems to 2 as always both register spaces are needed. > >

[PATCH V2] dmabuf: ensure unique directory name for dmabuf stats

2022-05-10 Thread Charan Teja Kalla
The dmabuf file uses get_next_ino()(through dma_buf_getfile() -> alloc_anon_inode()) to get an inode number and uses the same as a directory name under /sys/kernel/dmabuf/buffers/. This directory is used to collect the dmabuf stats and it is created through dma_buf_stats_setup(). At current,

[PATCH] drm/i915/gt: Fix use of static in macro mismatch

2022-05-10 Thread Andi Shyti
The INTEL_GT_RPS_SYSFS_ATTR was creating to different structures but. When called with the "static" keyword this is affecting only the first structure, while the second is created as non static. Move the static keyword inside the macros to affect both the structures. Reported-by: Jani Nikula

Re: 5.18 vmwgfx seems to break booting VirtualBox VMs

2022-05-10 Thread Zack Rusin
On Tue, 2022-05-10 at 15:49 +0200, Thorsten Leemhuis wrote: > On 10.05.22 15:30, Zack Rusin wrote: > > On Tue, 2022-05-10 at 14:44 +0200, Thorsten Leemhuis wrote: > > > On 10.05.22 14:26, Zack Rusin wrote: > > > > > On May 10, 2022, at 7:06 AM, Thorsten Leemhuis > > > > > wrote: > > > > > On

Re: 5.18 vmwgfx seems to break booting VirtualBox VMs

2022-05-10 Thread Thorsten Leemhuis
On 10.05.22 15:30, Zack Rusin wrote: > On Tue, 2022-05-10 at 14:44 +0200, Thorsten Leemhuis wrote: >> On 10.05.22 14:26, Zack Rusin wrote: On May 10, 2022, at 7:06 AM, Thorsten Leemhuis wrote: On 10.05.22 02:12, Zack Rusin wrote: >> On May 9, 2022, at 6:57 AM, Hans de Goede

Re: [PATCH v11 20/24] arm64: dts: rockchip: enable vop2 and hdmi tx on rock-3a

2022-05-10 Thread Piotr Oniszczuk
> Wiadomość napisana przez Peter Geis w dniu 10.05.2022, > o godz. 14:08: > > > You are on the clk_rtc32k_frac which is a fractional divider that is > fed from the 24m clock. Your clock likely isn't the issue here. I'd > recommend setting up the cec-gpio node to validate your hardware >

Re: [PATCH v4 11/15] drm/shmem-helper: Add generic memory shrinker

2022-05-10 Thread Dmitry Osipenko
On 5/9/22 16:49, Daniel Vetter wrote: > On Fri, May 06, 2022 at 03:10:43AM +0300, Dmitry Osipenko wrote: >> On 5/5/22 11:34, Thomas Zimmermann wrote: >>> Hi >>> >>> Am 18.04.22 um 00:37 schrieb Dmitry Osipenko: Introduce a common DRM SHMEM shrinker. It allows to reduce code duplication

Re: [PATCH v4 10/15] drm/shmem-helper: Take reservation lock instead of drm_gem_shmem locks

2022-05-10 Thread Dmitry Osipenko
On 5/9/22 16:42, Daniel Vetter wrote: > On Fri, May 06, 2022 at 01:49:12AM +0300, Dmitry Osipenko wrote: >> On 5/5/22 11:12, Daniel Vetter wrote: >>> On Wed, May 04, 2022 at 06:56:09PM +0300, Dmitry Osipenko wrote: On 5/4/22 11:21, Daniel Vetter wrote: ... >>> - Maybe also do what

Re: 5.18 vmwgfx seems to break booting VirtualBox VMs

2022-05-10 Thread Zack Rusin
On Tue, 2022-05-10 at 14:44 +0200, Thorsten Leemhuis wrote: > On 10.05.22 14:26, Zack Rusin wrote: > > > On May 10, 2022, at 7:06 AM, Thorsten Leemhuis > > > wrote: > > > On 10.05.22 02:12, Zack Rusin wrote: > > > > > On May 9, 2022, at 6:57 AM, Hans de Goede > > > > > > > > > > wrote: On

Re: [RFC] drm/amdgpu: Convert to common fdinfo format

2022-05-10 Thread Tvrtko Ursulin
On 10/05/2022 12:26, Christian König wrote: Am 10.05.22 um 12:50 schrieb Tvrtko Ursulin: Hi, On 10/05/2022 09:48, Christian König wrote: Hi Tvrtko, Am 10.05.22 um 10:23 schrieb Tvrtko Ursulin: From: Tvrtko Ursulin Convert fdinfo format to one documented in drm-usage-stats.rst.

Re: [Linaro-mm-sig] Re: [PATCH] dmabuf: ensure unique directory name for dmabuf stats

2022-05-10 Thread Christian König
Am 10.05.22 um 14:10 schrieb Greg KH: On Tue, May 10, 2022 at 01:35:41PM +0200, Christian König wrote: Am 10.05.22 um 13:00 schrieb Greg KH: On Tue, May 10, 2022 at 03:53:32PM +0530, Charan Teja Kalla wrote: The dmabuf file uses get_next_ino()(through dma_buf_getfile() -> alloc_anon_inode())

Re: 5.18 vmwgfx seems to break booting VirtualBox VMs

2022-05-10 Thread Thorsten Leemhuis
On 10.05.22 14:26, Zack Rusin wrote: >> On May 10, 2022, at 7:06 AM, Thorsten Leemhuis >> wrote: >> On 10.05.22 02:12, Zack Rusin wrote: On May 9, 2022, at 6:57 AM, Hans de Goede wrote: On 4/11/22 16:24, Zack Rusin wrote: > On Mon, 2022-04-11 at 10:52 +0200, Hans de Goede wrote:

Re: 5.18 vmwgfx seems to break booting VirtualBox VMs

2022-05-10 Thread Zack Rusin
> On May 10, 2022, at 7:06 AM, Thorsten Leemhuis > wrote: > > Hi, this is your Linux kernel regression tracker. > > On 10.05.22 02:12, Zack Rusin wrote: >>> On May 9, 2022, at 6:57 AM, Hans de Goede >>> wrote: On 4/11/22 16:24, Zack Rusin wrote: On Mon, 2022-04-11 at 10:52 +0200, Hans

Re: [PATCH] dmabuf: ensure unique directory name for dmabuf stats

2022-05-10 Thread Christian König
Am 10.05.22 um 14:16 schrieb Charan Teja Kalla: Thanks Christian for the inputs!! On 5/10/2022 5:05 PM, Christian König wrote: And what's to keep the seconds field from also being the same? Well exporting two DMA-bufs with the same ino in the same nanosecond should be basically impossible,

Re: [PATCH] dmabuf: ensure unique directory name for dmabuf stats

2022-05-10 Thread Charan Teja Kalla
Thanks Christian for the inputs!! On 5/10/2022 5:05 PM, Christian König wrote: > >> And what's to keep the seconds field from also being the same? > > Well exporting two DMA-bufs with the same ino in the same nanosecond > should be basically impossible, but I would rather opt for using a 64bit

Re: [PATCH] dmabuf: ensure unique directory name for dmabuf stats

2022-05-10 Thread Greg KH
On Tue, May 10, 2022 at 01:35:41PM +0200, Christian König wrote: > Am 10.05.22 um 13:00 schrieb Greg KH: > > On Tue, May 10, 2022 at 03:53:32PM +0530, Charan Teja Kalla wrote: > > > The dmabuf file uses get_next_ino()(through dma_buf_getfile() -> > > > alloc_anon_inode()) to get an inode number

Re: [PATCH v11 20/24] arm64: dts: rockchip: enable vop2 and hdmi tx on rock-3a

2022-05-10 Thread Peter Geis
On Tue, May 10, 2022 at 3:29 AM Piotr Oniszczuk wrote: > > > > > Wiadomość napisana przez Peter Geis w dniu > > 10.05.2022, o godz. 03:35: > > > > Could you grab the clock tree from /sys/kernel/debug/clk/clk_summary > > for the clk_hdmi_cec tree? > > Here it is: >

Re: [PATCH v2 25/25] drm/edid: convert version_greater() to drm_edid

2022-05-10 Thread Nautiyal, Ankit K
LGTM Reviewed-by: Ankit Nautiyal Regards, Ankit On 5/9/2022 5:33 PM, Jani Nikula wrote: We'll need to propagate drm_edid everywhere. Also make version_greater() a function for type safety. Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 29 + 1

Re: [PATCH v2 24/25] drm/displayid: convert to drm_edid

2022-05-10 Thread Nautiyal, Ankit K
LGTM Reviewed-by: Ankit Nautiyal Regards, Ankit On 5/9/2022 5:33 PM, Jani Nikula wrote: We'll need to propagate drm_edid everywhere. v2: Rebase Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_displayid.c | 16 drivers/gpu/drm/drm_edid.c | 17 ++---

  1   2   >