Re: [RESEND 10/14] iio: adc: mt6370: Add Mediatek MT6370 support

2022-06-02 Thread ChiaEn Wu
Hi Jonathan, Sorry for sending the same email again. I miss to reply all in the last email.. Thanks for your valuable suggestions! Jonathan Cameron 於 2022年5月31日 週二 下午9:21寫道: > > On Tue, 31 May 2022 19:18:56 +0800 > ChiaEn Wu wrote: > > > From: ChiaEn Wu > > > > Add Mediatek MT6370 ADC

Re: [RESEND 14/14] video: backlight: mt6370: Add Mediatek MT6370 support

2022-06-02 Thread ChiaEn Wu
Hi Daniel, Thanks for your valuable feedback! Daniel Thompson 於 2022年6月1日 週三 下午5:46寫道: > > On Tue, May 31, 2022 at 07:19:00PM +0800, ChiaEn Wu wrote: > > From: ChiaEn Wu > > > > Add Mediatek MT6370 Backlight support. > > > > Signed-off-by: ChiaEn Wu > > --- > >

Re: [PATCH 10/14] dt-bindings: power: supply: Add Mediatek MT6370 Charger binding documentation

2022-06-02 Thread ChiaEn Wu
Hi Krzysztof, Thank you for the valuable suggestion. Sorry for sending the same email again. I forgot to reply to everyone in my last email.. Krzysztof Kozlowski 於 2022年6月1日 週三 上午4:15寫道: > > On 31/05/2022 12:42, ChiaEn Wu wrote: > > From: ChiaEn Wu > > > > Subject - remove "binding

linux-next: Fixes tag needs some work in the drm tree

2022-06-02 Thread Stephen Rothwell
Hi all, In commit 8caad14e7224 ("drm/msm/dpu: Fix pointer dereferenced before checking") Fixes tag Fixes: d7d0e73f7de33 ("drm/msm/dpu: introduce the dpu_encoder_phys_* for has these problem(s): - Subject has leading but no trailing parentheses - Subject has leading but no trailing

[ANNOUNCE] libdrm 2.4.111

2022-06-02 Thread Dave Airlie
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 libdrm 2.4.111, just a few things built up, and drop libkms. Alex Deucher (3): test/amdgpu: only disable deadlock tests on asics without GPU reset amdgpu: add marketing names from 21.50 amdgpu: add marketing names from 22.10

Re: [PATCH v2 3/8] drm/panel: panel-edp: Implement .get_orientation callback

2022-06-02 Thread Hsin-Yi Wang
On Fri, Jun 3, 2022 at 5:51 AM Doug Anderson wrote: > > Hi, > > On Wed, Jun 1, 2022 at 2:46 AM Hsin-Yi Wang wrote: > > > > To return the orientation property to drm/kms driver. > > > > Signed-off-by: Hsin-Yi Wang > > Reviewed-by: Hans de Goede > > --- > > drivers/gpu/drm/panel/panel-edp.c | 8

[git pull] drm for 5.19-rc1 part2/fixes

2022-06-02 Thread Dave Airlie
Hi Linus, It's been a long "my first covid" isolated week. hopefully stop coughing sometime next week! This is mostly regular fixes, msm and amdgpu. There is a tegra patch that is bit of prep work for a 5.20 feature to avoid some inter-tree syncs, and a couple of late addition amdgpu uAPI

Re: [RFC PATCH 3/5] drm/amdgpu: Allow explicit sync for VM ops.

2022-06-02 Thread Bas Nieuwenhuizen
On Wed, Jun 1, 2022 at 11:01 AM Christian König wrote: > > Am 01.06.22 um 10:48 schrieb Bas Nieuwenhuizen: > > On Wed, Jun 1, 2022 at 10:40 AM Christian König > > wrote: > >> Am 01.06.22 um 10:16 schrieb Bas Nieuwenhuizen: > >>> On Wed, Jun 1, 2022 at 10:03 AM Christian König > >>> wrote: >

Re: [Freedreno] [PATCH 3/3] drm/msm/dpu: Add interface support for CRC debugfs

2022-06-02 Thread Jessica Zhang
On 6/2/2022 3:51 PM, Dmitry Baryshkov wrote: On 28/05/2022 01:23, Jessica Zhang wrote: On 5/27/2022 12:46 PM, Dmitry Baryshkov wrote: On 27/05/2022 21:54, Jessica Zhang wrote: Add support for writing CRC values for the interface block to the debugfs by calling the necessary MISR

Re: [PATCH 2/3] drm/msm/dpu: Add MISR register support for interface

2022-06-02 Thread Jessica Zhang
On 6/2/2022 3:31 PM, Dmitry Baryshkov wrote: On 27/05/2022 23:11, Jessica Zhang wrote: On 5/27/2022 12:38 PM, Dmitry Baryshkov wrote: On 27/05/2022 21:54, Jessica Zhang wrote: Add support for setting MISR registers within the interface Signed-off-by: Jessica Zhang ---  

[PATCH] drm/i915/pvc: Add register steering

2022-06-02 Thread Matt Roper
Ponte Vecchio no longer has MSLICE or LNCF steering, but the bspec does document several new types of multicast register ranges. Fortunately, most of the different MCR types all provide valid values at instance (0,0) so there's no need to read fuse registers and calculate a valid instance. We'll

[PATCH] drm/i915/pvc: Add Wa_16015675438:pvc

2022-06-02 Thread Matt Roper
From: Badal Nilawar Even though PVC doesn't have an RCS engine, this workaround updates a register in the 0x2xxx range that traditionally belongs to the RCS. We need to set a special flag to tell the GuC that the presence of an "RCS" register on a CCS save/restore list is okay/expected. Cc:

[PATCH] drm/i915/pvc: GuC depriv applies to PVC

2022-06-02 Thread Matt Roper
We missed this setting in the initial device info patch's definition of XE_HPC_FEATURES. Signed-off-by: Matt Roper --- drivers/gpu/drm/i915/i915_pci.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/i915/i915_pci.c b/drivers/gpu/drm/i915/i915_pci.c index

Re: [PATCH 3/6] drm/qxl: Create mouse hotspot properties on cursor planes

2022-06-02 Thread kernel test robot
Hi Zack, I love your patch! Perhaps something to improve: [auto build test WARNING on drm/drm-next] [also build test WARNING on drm-exynos/exynos-drm-next drm-intel/for-linux-next drm-tip/drm-tip v5.18 next-20220602] [cannot apply to airlied/drm-next tegra-drm/drm/tegra/for-next] [If your patch

Re: [Freedreno] [PATCH v4 1/7] drm/msm/dpu: use feature bit for LM combined alpha check

2022-06-02 Thread Abhinav Kumar
On 6/2/2022 1:24 PM, Dmitry Baryshkov wrote: Rather than checking hwversion, follow the usual patter and add special bit to the lm->features to check whether the LM has combined or separate alpha registers. While we are at it, rename dpu_hw_lm_setup_blend_config_sdm845() to

Re: [PATCH v5 6/6] arm64: config: Enable DRM_V3D

2022-06-02 Thread Javier Martinez Canillas
On 6/1/22 13:02, Peter Robinson wrote: > From: Nicolas Saenz Julienne > > BCM2711, the SoC used on the Raspberry Pi 4 has a different GPU than its > predecessors. Enable it. > > Signed-off-by: Nicolas Saenz Julienne > Signed-off-by: Peter Robinson > --- Reviewed-by: Javier Martinez Canillas

Re: [PATCH v5 5/6] ARM: configs: Enable DRM_V3D

2022-06-02 Thread Javier Martinez Canillas
On 6/1/22 13:02, Peter Robinson wrote: > BCM2711, the SoC used on the Raspberry Pi 4 has a different 3D > render GPU IP than its predecessors. Enable it it on multi v7 > and bcm2835 configs. > > Signed-off-by: Nicolas Saenz Julienne > Signed-off-by: Peter Robinson > --- Reviewed-by: Javier

Re: [PATCH v5 4/6] ARM: dts: bcm2711: Enable V3D

2022-06-02 Thread Javier Martinez Canillas
On 6/1/22 13:02, Peter Robinson wrote: > This adds the entry for V3D for bcm2711 (used in the Raspberry Pi 4) > and the associated firmware clock entry. > > Signed-off-by: Nicolas Saenz Julienne > Signed-off-by: Peter Robinson > --- Once you fix the typo mentioned by Stefan already:

Re: [PATCH v5 3/6] drm/v3d: Add support for bcm2711

2022-06-02 Thread Javier Martinez Canillas
On 6/1/22 13:02, Peter Robinson wrote: > Add compatible string and Kconfig options for bcm2711. > > Signed-off-by: Nicolas Saenz Julienne > Signed-off-by: Peter Robinson > --- Reviewed-by: Javier Martinez Canillas I've one small nit though. [snip] > # SPDX-License-Identifier: GPL-2.0-only

Re: [PATCH v5 2/6] drm/v3d: Get rid of pm code

2022-06-02 Thread Javier Martinez Canillas
On 6/1/22 13:02, Peter Robinson wrote: > Runtime PM doesn't seem to work correctly on this driver. On top of > that, commit 8b6864e3e138 ("drm/v3d/v3d_drv: Remove unused static > variable 'v3d_v3d_pm_ops'") hints that it most likely never did as the > driver's PM ops were not hooked-up. > > So,

Re: [PATCH v5 1/6] dt-bindings: gpu: v3d: Add BCM2711's compatible

2022-06-02 Thread Javier Martinez Canillas
Hello Peter, On 6/1/22 13:02, Peter Robinson wrote: > BCM2711, Raspberry Pi 4's SoC, contains a V3D core. So add its specific > compatible to the bindings. > > Signed-off-by: Nicolas Saenz Julienne > Signed-off-by: Peter Robinson > --- Reviewed-by: Javier Martinez Canillas -- Best regards,

Re: [Freedreno] [PATCH 3/3] drm/msm/dpu: Add interface support for CRC debugfs

2022-06-02 Thread Dmitry Baryshkov
On 28/05/2022 01:23, Jessica Zhang wrote: On 5/27/2022 12:46 PM, Dmitry Baryshkov wrote: On 27/05/2022 21:54, Jessica Zhang wrote: Add support for writing CRC values for the interface block to the debugfs by calling the necessary MISR setup/collect methods. Signed-off-by: Jessica Zhang ---

XDC 2022: Registration & Call for Presentations still open!

2022-06-02 Thread Lyude Paul
Hello! This is just a reminder that the CFP for XDC in 2022 is still open! The 2022 X.Org Developers Conference is being held in conjunction with the 2022 Wine Developers Conference.  This is a meeting to bring together developers working on all things open graphics (Linux kernel, Mesa, DRM,

Re: [PATCH 2/3] drm/msm/dpu: Add MISR register support for interface

2022-06-02 Thread Dmitry Baryshkov
On 27/05/2022 23:11, Jessica Zhang wrote: On 5/27/2022 12:38 PM, Dmitry Baryshkov wrote: On 27/05/2022 21:54, Jessica Zhang wrote: Add support for setting MISR registers within the interface Signed-off-by: Jessica Zhang ---   drivers/gpu/drm/msm/disp/dpu1/dpu_hw_intf.c | 55

Re: [PATCH v3 0/4] drm/dp: Make DP AUX bus usage easier; use it on ps8640

2022-06-02 Thread Doug Anderson
Hi, On Tue, May 10, 2022 at 12:30 PM Douglas Anderson wrote: > > This patch is v3 of the first 2 patches from my RFC series ("drm/dp: > Improvements > for DP AUX channel") [1]. I've broken the series in two so we can make > progress on the two halves separately. > > v2 of this series tries to

Re: [PATCH 3/6] drm/qxl: Create mouse hotspot properties on cursor planes

2022-06-02 Thread kernel test robot
Hi Zack, I love your patch! Perhaps something to improve: [auto build test WARNING on drm/drm-next] [also build test WARNING on drm-exynos/exynos-drm-next drm-intel/for-linux-next drm-tip/drm-tip v5.18 next-20220602] [cannot apply to airlied/drm-next tegra-drm/drm/tegra/for-next] [If your patch

Re: [PATCH] drm/sun4i: sun8i: Add the ability to keep scaler enabled for VI layer

2022-06-02 Thread Ondřej Jirman
Hi Roman, On Thu, Jun 02, 2022 at 06:01:18PM +, Roman Stratiienko wrote: > According to DE2.0/DE3.0 manual VI scaler enable register is double > buffered, but de facto it doesn't, or the hardware has the shadow > register latching issues which causes single-frame picture corruption > after

Re: [PATCH v2 3/8] drm/panel: panel-edp: Implement .get_orientation callback

2022-06-02 Thread Doug Anderson
Hi, On Wed, Jun 1, 2022 at 2:46 AM Hsin-Yi Wang wrote: > > To return the orientation property to drm/kms driver. > > Signed-off-by: Hsin-Yi Wang > Reviewed-by: Hans de Goede > --- > drivers/gpu/drm/panel/panel-edp.c | 8 > 1 file changed, 8 insertions(+) > > diff --git

Re: [PATCH v2 0/8] Add a panel API to return panel orientation

2022-06-02 Thread Doug Anderson
Hi, On Wed, Jun 1, 2022 at 2:46 AM Hsin-Yi Wang wrote: > > Panels usually call drm_connector_set_panel_orientation(), which is > later than drm/kms driver calling drm_dev_register(). This leads to a > WARN()[1]. > > The orientation property is known earlier. For example, some panels > parse the

Re: [PATCH v3 0/7] drm/msm: clean up the hw catalog init

2022-06-02 Thread Dmitry Baryshkov
On 02/06/2022 23:24, Abhinav Kumar wrote: On 6/2/2022 1:22 PM, Dmitry Baryshkov wrote: Replace superfluous cfg_init functions, which just assign a static config to the struct dpu_mdss_cfg, with static instances of struct dpu_mdss_cfg. Changes since v2:   - Add DPU_MIXER_COMBINED_ALPHA to

[PATCH 2/3] drm/amdgpu/dm/mst: Stop grabbing mst_mgr->lock in pre_compute_mst_dsc_configs_for_state()

2022-06-02 Thread Lyude Paul
This lock is only needed if you're iterating through the in-memory topology (e.g. drm_dp_mst_branch->ports, drm_dp_mst_port->mstb, etc.). This doesn't actually seem to be what's going on here though, so we can just drop this lock. Signed-off-by: Lyude Paul ---

[PATCH 3/3] drm/amdgpu/dm: Drop != NULL check in dm_mst_get_pbn_divider()

2022-06-02 Thread Lyude Paul
A lot of code in amdgpu seems to sprinkle in if (foo != NULL) … Checks pretty much all over the place, many times in locations where it's clear foo (whatever foo may be) should never be NULL unless we've run into a programming error. This is definitely one of those places, as

[PATCH 1/3] drm/amdgpu/dm/mst: Stop grabbing mst_mgr->lock in compute_mst_dsc_configs_for_state()

2022-06-02 Thread Lyude Paul
Noticed this while trying to update amdgpu for the non-atomic MST removal changes - for some reason we appear to grab mst_mgr->lock before computing mst DSC configs. This is wrong though - mst_mgr->lock is only needed while traversing the actual MST topology state - which is not typically

Re: [RFC v3 1/3] drm/doc/rfc: VM_BIND feature design document

2022-06-02 Thread Niranjana Vishwanathapura
On Wed, Jun 01, 2022 at 07:13:16PM -0700, Zeng, Oak wrote: Regards, Oak -Original Message- From: dri-devel On Behalf Of Niranjana Vishwanathapura Sent: May 17, 2022 2:32 PM To: intel-...@lists.freedesktop.org; dri-devel@lists.freedesktop.org; Vetter, Daniel Cc: Brost, Matthew ;

Re: [PATCH 2/3] drm/display/dp_mst: Fix drm_atomic_get_mst_topology_state()

2022-06-02 Thread Lyude Paul
On Thu, 2022-06-02 at 23:42 +0300, Ville Syrjälä wrote: > On Thu, Jun 02, 2022 at 04:17:56PM -0400, Lyude Paul wrote: > > I noticed a rather surprising issue here while working on removing all of > > the non-atomic MST code: drm_atomic_get_mst_topology_state() doesn't check > > the return value of

Re: [PATCH 2/3] drm/display/dp_mst: Fix drm_atomic_get_mst_topology_state()

2022-06-02 Thread Ville Syrjälä
On Thu, Jun 02, 2022 at 04:17:56PM -0400, Lyude Paul wrote: > I noticed a rather surprising issue here while working on removing all of > the non-atomic MST code: drm_atomic_get_mst_topology_state() doesn't check > the return value of drm_atomic_get_private_obj_state() and instead just > passes it

Re: [Intel-gfx] [RFC v3 1/3] drm/doc/rfc: VM_BIND feature design document

2022-06-02 Thread Jason Ekstrand
On Thu, Jun 2, 2022 at 3:11 PM Niranjana Vishwanathapura < niranjana.vishwanathap...@intel.com> wrote: > On Wed, Jun 01, 2022 at 01:28:36PM -0700, Matthew Brost wrote: > >On Wed, Jun 01, 2022 at 05:25:49PM +0300, Lionel Landwerlin wrote: > >> On 17/05/2022 21:32, Niranjana Vishwanathapura wrote:

Re: [Intel-gfx] [RFC v3 1/3] drm/doc/rfc: VM_BIND feature design document

2022-06-02 Thread Niranjana Vishwanathapura
On Thu, Jun 02, 2022 at 09:22:46AM -0700, Matthew Brost wrote: On Thu, Jun 02, 2022 at 08:42:13AM +0300, Lionel Landwerlin wrote: On 02/06/2022 00:18, Matthew Brost wrote: > On Wed, Jun 01, 2022 at 05:25:49PM +0300, Lionel Landwerlin wrote: > > On 17/05/2022 21:32, Niranjana Vishwanathapura

[PATCH v4 6/7] drm/msm/dpu: constify struct dpu_mdss_cfg

2022-06-02 Thread Dmitry Baryshkov
Mark struct dpu_mdss_cfg instance as a const pointer. This is mostly a preparation for the next patch. Reviewed-by: Abhinav Kumar Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c | 4 ++-- drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.h | 4 ++--

[PATCH v4 7/7] drm/msm/dpu: make dpu hardware catalog static const

2022-06-02 Thread Dmitry Baryshkov
Replace superfluous cfg_init functions, which just assign a static config to the struct dpu_mdss_cfg, with static instances of struct dpu_mdss_cfg. Signed-off-by: Dmitry Baryshkov --- .../gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c| 475 --

[PATCH v4 1/7] drm/msm/dpu: use feature bit for LM combined alpha check

2022-06-02 Thread Dmitry Baryshkov
Rather than checking hwversion, follow the usual patter and add special bit to the lm->features to check whether the LM has combined or separate alpha registers. While we are at it, rename dpu_hw_lm_setup_blend_config_sdm845() to dpu_hw_lm_setup_blend_config_combined_alpha(). Signed-off-by:

[PATCH v4 3/7] drm/msm/dpu: remove hwversion field from data structures

2022-06-02 Thread Dmitry Baryshkov
The driver should not depend on hw revision for detecting features. Instead it should use features from the hw catalog. Drop the hwversion field from struct dpu_mdss_cfg and struct dpu_hw_blk_reg_map. Reviewed-by: Abhinav Kumar Signed-off-by: Dmitry Baryshkov ---

[PATCH v4 5/7] drm/msm/dpu: change catalog->dma_cfg to be a const pointer

2022-06-02 Thread Dmitry Baryshkov
Change dpu_mdss_cfg::dma_cfg to be a const pointer rather than embedding the dpu_reg_dma_cfg struct into the struct dpu_mdss_cfg. Reported-by: kernel test robot Reviewed-by: Abhinav Kumar Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 12 ++--

[PATCH v4 4/7] drm/msm/dpu: change catalog->perf to be a const pointer

2022-06-02 Thread Dmitry Baryshkov
Change dpu_mdss_cfg::perf to be a const pointer rather than embedding the dpu_perf_cfg struct into the struct dpu_mdss_cfg. Reported-by: kernel test robot Reviewed-by: Abhinav Kumar Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c | 20 +--

[PATCH v4 0/7] drm/msm: clean up the hw catalog init

2022-06-02 Thread Dmitry Baryshkov
Replace superfluous cfg_init functions, which just assign a static config to the struct dpu_mdss_cfg, with static instances of struct dpu_mdss_cfg. Changes since v3: - Add missed Reviewed-by tags by Abhinav. Changes since v2: - Add DPU_MIXER_COMBINED_ALPHA to sc7180's mixer features mask

Re: [PATCH v3 0/7] drm/msm: clean up the hw catalog init

2022-06-02 Thread Abhinav Kumar
On 6/2/2022 1:22 PM, Dmitry Baryshkov wrote: Replace superfluous cfg_init functions, which just assign a static config to the struct dpu_mdss_cfg, with static instances of struct dpu_mdss_cfg. Changes since v2: - Add DPU_MIXER_COMBINED_ALPHA to sc7180's mixer features mask (noted by

[PATCH v4 2/7] drm/msm/dpu: move VBIF_XINL_QOS_LVL_REMAP size to hw_catalog

2022-06-02 Thread Dmitry Baryshkov
Rather than detecting VBIF_XINL_QOS_LVL_REMAP_000 based on the hwversion, push the offset to the hw_catalog. Reviewed-by: Abhinav Kumar Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 2 ++ drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h | 2 ++

[PATCH v3 7/7] drm/msm/dpu: make dpu hardware catalog static const

2022-06-02 Thread Dmitry Baryshkov
Replace superfluous cfg_init functions, which just assign a static config to the struct dpu_mdss_cfg, with static instances of struct dpu_mdss_cfg. Signed-off-by: Dmitry Baryshkov --- .../gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c| 475 --

[PATCH v3 6/7] drm/msm/dpu: constify struct dpu_mdss_cfg

2022-06-02 Thread Dmitry Baryshkov
Mark struct dpu_mdss_cfg instance as a const pointer. This is mostly a preparation for the next patch. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c | 4 ++-- drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.h | 4 ++--

[PATCH v3 5/7] drm/msm/dpu: change catalog->dma_cfg to be a const pointer

2022-06-02 Thread Dmitry Baryshkov
Change dpu_mdss_cfg::dma_cfg to be a const pointer rather than embedding the dpu_reg_dma_cfg struct into the struct dpu_mdss_cfg. Reported-by: kernel test robot Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 12 ++--

[PATCH v3 4/7] drm/msm/dpu: change catalog->perf to be a const pointer

2022-06-02 Thread Dmitry Baryshkov
Change dpu_mdss_cfg::perf to be a const pointer rather than embedding the dpu_perf_cfg struct into the struct dpu_mdss_cfg. Reported-by: kernel test robot Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c | 20 +--

[PATCH v3 2/7] drm/msm/dpu: move VBIF_XINL_QOS_LVL_REMAP size to hw_catalog

2022-06-02 Thread Dmitry Baryshkov
Rather than detecting VBIF_XINL_QOS_LVL_REMAP_000 based on the hwversion, push the offset to the hw_catalog. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 2 ++ drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h | 2 ++

[PATCH v3 3/7] drm/msm/dpu: remove hwversion field from data structures

2022-06-02 Thread Dmitry Baryshkov
The driver should not depend on hw revision for detecting features. Instead it should use features from the hw catalog. Drop the hwversion field from struct dpu_mdss_cfg and struct dpu_hw_blk_reg_map. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c| 1 -

[PATCH v3 1/7] drm/msm/dpu: use feature bit for LM combined alpha check

2022-06-02 Thread Dmitry Baryshkov
Rather than checking hwversion, follow the usual patter and add special bit to the lm->features to check whether the LM has combined or separate alpha registers. While we are at it, rename dpu_hw_lm_setup_blend_config_sdm845() to dpu_hw_lm_setup_blend_config_combined_alpha(). Signed-off-by:

[PATCH v3 0/7] drm/msm: clean up the hw catalog init

2022-06-02 Thread Dmitry Baryshkov
Replace superfluous cfg_init functions, which just assign a static config to the struct dpu_mdss_cfg, with static instances of struct dpu_mdss_cfg. Changes since v2: - Add DPU_MIXER_COMBINED_ALPHA to sc7180's mixer features mask (noted by Abhinav). Changes since v1: - Turn catalog->perf and

[PATCH 3/3] drm/dp_mst: Get rid of old comment in drm_atomic_get_mst_topology_state docs

2022-06-02 Thread Lyude Paul
We don't actually care about connection_mutex here anymore, so let's get rid of the comment mentioning it in this function's kdocs. Signed-off-by: Lyude Paul --- drivers/gpu/drm/display/drm_dp_mst_topology.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git

[PATCH 0/3] Misc drive-by fixes for MST helpers

2022-06-02 Thread Lyude Paul
I'm now (finally!) finishing up my work with getting rid of the legacy MST code and makng everything atomic only, and while doing that I ended up coming up with a few unrelated patches along the way. These are those patches. Lyude Paul (3): drm/display/dp_mst: Don't validate port refs in

[PATCH 2/3] drm/display/dp_mst: Fix drm_atomic_get_mst_topology_state()

2022-06-02 Thread Lyude Paul
I noticed a rather surprising issue here while working on removing all of the non-atomic MST code: drm_atomic_get_mst_topology_state() doesn't check the return value of drm_atomic_get_private_obj_state() and instead just passes it directly to to_dp_mst_topology_state(). This means that if we hit a

[PATCH 1/3] drm/display/dp_mst: Don't validate port refs in drm_dp_check_and_send_link_address()

2022-06-02 Thread Lyude Paul
Drive-by cleanup, we don't need to validate the port references here as we already previously went through the effort of refactoring things such that we're guaranteed to be able to access ->mstb and ->port safely from drm_dp_check_and_send_link_address(), since the only two places in the codebase

Re: [Intel-gfx] [RFC v3 1/3] drm/doc/rfc: VM_BIND feature design document

2022-06-02 Thread Bas Nieuwenhuizen
On Thu, Jun 2, 2022 at 7:42 AM Lionel Landwerlin wrote: > > On 02/06/2022 00:18, Matthew Brost wrote: > > On Wed, Jun 01, 2022 at 05:25:49PM +0300, Lionel Landwerlin wrote: > >> On 17/05/2022 21:32, Niranjana Vishwanathapura wrote: > >>> +VM_BIND/UNBIND ioctl will immediately start

Re: [PATCH v2 1/7] drm/msm/dpu: use feature bit for LM combined alpha check

2022-06-02 Thread Dmitry Baryshkov
On Thu, 2 Jun 2022 at 21:37, Abhinav Kumar wrote: > > > > On 6/2/2022 6:30 AM, Dmitry Baryshkov wrote: > > Rather than checking hwversion, follow the usual patter and add special > > bit to the lm->features to check whether the LM has combined or separate > > alpha registers. While we are at it,

Re: [Freedreno] [PATCH] drm/msm: less magic numbers in msm_mdss_enable

2022-06-02 Thread Dmitry Baryshkov
On Thu, 2 Jun 2022 at 21:18, Abhinav Kumar wrote: > > > > On 6/1/2022 1:04 PM, Dmitry Baryshkov wrote: > > On Wed, 1 Jun 2022 at 20:38, Abhinav Kumar > > wrote: > >> > >> > >> > >> On 6/1/2022 2:46 AM, Dmitry Baryshkov wrote: > >>> On Wed, 1 Jun 2022 at 01:01, Abhinav Kumar > >>> wrote: >

Re: [Intel-gfx] [RFC v3 1/3] drm/doc/rfc: VM_BIND feature design document

2022-06-02 Thread Niranjana Vishwanathapura
On Wed, Jun 01, 2022 at 01:28:36PM -0700, Matthew Brost wrote: On Wed, Jun 01, 2022 at 05:25:49PM +0300, Lionel Landwerlin wrote: On 17/05/2022 21:32, Niranjana Vishwanathapura wrote: > +VM_BIND/UNBIND ioctl will immediately start binding/unbinding the mapping in an > +async worker. The

[PATCH] fbcon: Fix accelerated fbdev scrolling while logo is still shown

2022-06-02 Thread Helge Deller
There is no need to directly skip over to the SCROLL_REDRAW case while the logo is still shown. When using DRM, this change has no effect because the code will reach the SCROLL_REDRAW case immediately anyway. But if you run an accelerated fbdev driver and have

[PATCH] fbcon: Fix boundary checks for fbcon=vc:n1-n2 parameters

2022-06-02 Thread Helge Deller
The user may use the fbcon=vc:- option to tell fbcon to take over the given range (n1...n2) of consoles. The value for n1 and n2 needs to be a positive number and up to (MAX_NR_CONSOLES - 1). The given values were not fully checked against those boundaries yet. To fix the issue, convert

Re: [PATCH v2 6/7] drm/msm/dpu: constify struct dpu_mdss_cfg

2022-06-02 Thread Abhinav Kumar
On 6/2/2022 6:30 AM, Dmitry Baryshkov wrote: Mark struct dpu_mdss_cfg instance as a const pointer. This is mostly a preparation for the next patch. Signed-off-by: Dmitry Baryshkov Reviewed-by: Abhinav Kumar --- drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c | 4 ++--

Re: [PATCH v2 5/7] drm/msm/dpu: change catalog->dma_cfg to be a const pointer

2022-06-02 Thread Abhinav Kumar
On 6/2/2022 6:30 AM, Dmitry Baryshkov wrote: Change dpu_mdss_cfg::dma_cfg to be a const pointer rather than embedding the dpu_reg_dma_cfg struct into the struct dpu_mdss_cfg. Reported-by: kernel test robot Signed-off-by: Dmitry Baryshkov Reviewed-by: Abhinav Kumar ---

Re: [PATCH v2 4/7] drm/msm/dpu: change catalog->perf to be a const pointer

2022-06-02 Thread Abhinav Kumar
On 6/2/2022 6:30 AM, Dmitry Baryshkov wrote: Change dpu_mdss_cfg::perf to be a const pointer rather than embedding the dpu_perf_cfg struct into the struct dpu_mdss_cfg. Reported-by: kernel test robot Signed-off-by: Dmitry Baryshkov Reviewed-by: Abhinav Kumar ---

Re: [PATCH v2 3/7] drm/msm/dpu: remove hwversion field from data structures

2022-06-02 Thread Abhinav Kumar
On 6/2/2022 6:30 AM, Dmitry Baryshkov wrote: The driver should not depend on hw revision for detecting features. Instead it should use features from the hw catalog. Drop the hwversion field from struct dpu_mdss_cfg and struct dpu_hw_blk_reg_map. Signed-off-by: Dmitry Baryshkov Since the

Re: [PATCH v2 2/7] drm/msm/dpu: move VBIF_XINL_QOS_LVL_REMAP size to hw_catalog

2022-06-02 Thread Abhinav Kumar
On 6/2/2022 6:30 AM, Dmitry Baryshkov wrote: Rather than detecting VBIF_XINL_QOS_LVL_REMAP_000 based on the hwversion, push the offset to the hw_catalog. Signed-off-by: Dmitry Baryshkov This one is fine because sc7180 and sc7280 use sdm845_vbif. All chipsets listed in the catalog are

Re: [PATCH v2 1/7] drm/msm/dpu: use feature bit for LM combined alpha check

2022-06-02 Thread Abhinav Kumar
On 6/2/2022 6:30 AM, Dmitry Baryshkov wrote: Rather than checking hwversion, follow the usual patter and add special bit to the lm->features to check whether the LM has combined or separate alpha registers. While we are at it, rename dpu_hw_lm_setup_blend_config_sdm845() to

Re: [Freedreno] [PATCH] drm/msm: less magic numbers in msm_mdss_enable

2022-06-02 Thread Abhinav Kumar
On 6/1/2022 1:04 PM, Dmitry Baryshkov wrote: On Wed, 1 Jun 2022 at 20:38, Abhinav Kumar wrote: On 6/1/2022 2:46 AM, Dmitry Baryshkov wrote: On Wed, 1 Jun 2022 at 01:01, Abhinav Kumar wrote: On 5/31/2022 5:18 AM, Dmitry Baryshkov wrote: Replace magic register writes in

[PATCH] drm/sun4i: sun8i: Add the ability to keep scaler enabled for VI layer

2022-06-02 Thread Roman Stratiienko
According to DE2.0/DE3.0 manual VI scaler enable register is double buffered, but de facto it doesn't, or the hardware has the shadow register latching issues which causes single-frame picture corruption after changing the state of scaler enable register. Allow the user to keep the scaler always

Re: [RFC PATCH 1/1] drm/format-helper: Add KUnit tests for drm_fb_xrgb8888_to_rgb332()

2022-06-02 Thread Javier Martinez Canillas
On 6/2/22 19:12, David Gow wrote: > On Mon, May 30, 2022 at 9:29 AM José Expósito > wrote: [snip] >> >> A .kuniconfig example is present in the cover letter. (...) > > FYI: it's also possible to run these tests under UML with the extra options: > CONFIG_VIRTIO_UML=y >

[PATCH] drm/i915/guc: Check ctx while waiting for response

2022-06-02 Thread Zhanjun Dong
We are seeing error message of "No response for request". Some cases happened while waiting for response and reset/suspend action was triggered. In this case, no response is not an error, active requests will be cancelled. This patch will handle this condition and change the error message into

Re: [RFC PATCH 1/1] drm/format-helper: Add KUnit tests for drm_fb_xrgb8888_to_rgb332()

2022-06-02 Thread Javier Martinez Canillas
Hello David, On 6/2/22 19:07, David Gow wrote: > On Thu, Jun 2, 2022 at 9:27 AM Javier Martinez Canillas [snip] >> >> And doing that will also allow you to get rid of this, since just selecting >> CONFIG_DRM_KUNIT_TEST=y would be enough for the tests built and run by KUnit. >> > > This is

Re: How should "max bpc" and "Colorspace" KMS property work?

2022-06-02 Thread Ville Syrjälä
On Thu, Jun 02, 2022 at 07:08:33PM +0200, Sebastian Wick wrote: > On Thu, Jun 2, 2022 at 6:40 PM Ville Syrjälä > wrote: > > > > On Thu, Jun 02, 2022 at 10:47:59AM +0300, Pekka Paalanen wrote: > > > On Wed, 1 Jun 2022 17:06:25 +0300 > > > Ville Syrjälä wrote: > > > > > > > On Wed, Jun 01, 2022 at

Re: [PATCH v1 06/13] drm/probe-helper: make .get_modes() optional, add default action

2022-06-02 Thread Ville Syrjälä
On Tue, May 24, 2022 at 01:39:28PM +0300, Jani Nikula wrote: > Add default action when .get_modes() not set. This also defines what a > .get_modes() hook should do. > > Cc: David Airlie > Cc: Daniel Vetter > Signed-off-by: Jani Nikula > --- > drivers/gpu/drm/drm_probe_helper.c | 14

Re: [PATCH v1 04/13] drm/edid: add drm_edid_connector_update()

2022-06-02 Thread Ville Syrjälä
On Tue, May 24, 2022 at 01:39:26PM +0300, Jani Nikula wrote: > Add a new function drm_edid_connector_update() to replace the > combination of calls drm_connector_update_edid_property() and > drm_add_edid_modes(). Usually they are called in the drivers in this > order, however the former needs

Re: How should "max bpc" and "Colorspace" KMS property work?

2022-06-02 Thread Sebastian Wick
On Thu, Jun 2, 2022 at 6:40 PM Ville Syrjälä wrote: > > On Thu, Jun 02, 2022 at 10:47:59AM +0300, Pekka Paalanen wrote: > > On Wed, 1 Jun 2022 17:06:25 +0300 > > Ville Syrjälä wrote: > > > > > On Wed, Jun 01, 2022 at 10:21:26AM +0300, Pekka Paalanen wrote: > > > > On Tue, 31 May 2022 20:37:31

Re: [PATCH v1 01/13] drm/edid: add block count and data helper functions for drm_edid

2022-06-02 Thread Jani Nikula
On Thu, 02 Jun 2022, Ville Syrjälä wrote: > On Tue, May 24, 2022 at 01:39:23PM +0300, Jani Nikula wrote: >> Add drm_edid based block count and data access helper functions that >> take the EDID allocated size into account. >> >> At the moment, the allocated size should always match the EDID size

Re: [PATCH 07/14] leds: flashlight: mt6370: Add Mediatek MT6370 flashlight support

2022-06-02 Thread szuni chen
Thank you for the valuable suggestion. Andy Shevchenko 於 2022年6月1日 週三 下午5:57寫道: > > On Tue, May 31, 2022 at 1:32 PM ChiaEn Wu wrote: > > > > From: Alice Chen > > > > Add Mediatek MT6370 flashlight support > > Same comments about the commit message. > > ... > > > +#include > > +#include > >

[PATCH] fbdev: simplefb: Check before clk_put() not needed

2022-06-02 Thread Yihao Han
clk_put() already checks the clk ptr using !clk and IS_ERR() so there is no need to check it again before calling it. Signed-off-by: Yihao Han --- drivers/video/fbdev/simplefb.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/video/fbdev/simplefb.c

Re: [PATCH v1 01/13] drm/edid: add block count and data helper functions for drm_edid

2022-06-02 Thread Ville Syrjälä
On Tue, May 24, 2022 at 01:39:23PM +0300, Jani Nikula wrote: > Add drm_edid based block count and data access helper functions that > take the EDID allocated size into account. > > At the moment, the allocated size should always match the EDID size > indicated by the extension count, but this

Re: How should "max bpc" and "Colorspace" KMS property work?

2022-06-02 Thread Ville Syrjälä
On Thu, Jun 02, 2022 at 10:47:59AM +0300, Pekka Paalanen wrote: > On Wed, 1 Jun 2022 17:06:25 +0300 > Ville Syrjälä wrote: > > > On Wed, Jun 01, 2022 at 10:21:26AM +0300, Pekka Paalanen wrote: > > > On Tue, 31 May 2022 20:37:31 +0300 > > > Ville Syrjälä wrote: > > > > > > > On Wed, May 25,

Re: [Intel-gfx] [RFC v3 1/3] drm/doc/rfc: VM_BIND feature design document

2022-06-02 Thread Matthew Brost
On Thu, Jun 02, 2022 at 08:42:13AM +0300, Lionel Landwerlin wrote: > On 02/06/2022 00:18, Matthew Brost wrote: > > On Wed, Jun 01, 2022 at 05:25:49PM +0300, Lionel Landwerlin wrote: > > > On 17/05/2022 21:32, Niranjana Vishwanathapura wrote: > > > > +VM_BIND/UNBIND ioctl will immediately start

Re: [RFC PATCH 1/1] drm/format-helper: Add KUnit tests for drm_fb_xrgb8888_to_rgb332()

2022-06-02 Thread Javier Martinez Canillas
Hello José, On 5/30/22 12:20, José Expósito wrote: > Test the conversion from XRGB to RGB332. > > What is tested? > > - Different values for the X in XRGB to make sure it is ignored > - Different clip values: Single pixel and full and partial buffer > - Well know colors: White,

[PATCH] drm/tegra: dc: rgb: Fix refcount leak in tegra_dc_rgb_probe

2022-06-02 Thread Miaoqian Lin
of_get_child_by_name() returns a node pointer with refcount incremented, we should use of_node_put() on it when not need anymore. So add of_node_put() in error paths. Fixes: format:d8f4a9eda006 ("drm: Add NVIDIA Tegra20 support") Signed-off-by: Miaoqian Lin --- drivers/gpu/drm/tegra/rgb.c | 31

Re: DRM Master ignoring hotplug event during display switching (QT)

2022-06-02 Thread Jagan Teki
Hi Daniel, On Wed, Mar 30, 2022 at 3:27 PM Daniel Vetter wrote: > > On Wed, Mar 30, 2022 at 10:52:54AM +0200, Maxime Ripard wrote: > > On Tue, Mar 29, 2022 at 11:38:32PM +0530, Jagan Teki wrote: > > > Hi all, > > > > > > I have implemented runtime display switching in the MIPI switch design > >

[PATCH 6/6] drm: Remove legacy cursor hotspot code

2022-06-02 Thread Zack Rusin
From: Zack Rusin Atomic modesetting support mouse cursor offsets via the hotspot properties that are creates on cursor planes. All drivers which support hotspot are atomic and the legacy code has been implemented in terms of the atomic properties as well. Due to the above the lagacy cursor

[PATCH 4/6] drm/vboxvideo: Create mouse hotspot properties on cursor planes

2022-06-02 Thread Zack Rusin
From: Zack Rusin Atomic modesetting got support for mouse hotspots via the hotspot properties. Drivers need to create those properties on cursor planes which require the mouse hotspot coordinates. Add the code creating hotspot properties and port away from old legacy hotspot API. The legacy

[PATCH 5/6] drm/virtio: Create mouse hotspot properties on cursor planes

2022-06-02 Thread Zack Rusin
From: Zack Rusin Atomic modesetting got support for mouse hotspots via the hotspot properties. Drivers need to create those properties on cursor planes which require the mouse hotspot coordinates. Add the code creating hotspot properties and port away from old legacy hotspot API. The legacy

[PATCH 3/6] drm/qxl: Create mouse hotspot properties on cursor planes

2022-06-02 Thread Zack Rusin
From: Zack Rusin Atomic modesetting got support for mouse hotspots via the hotspot properties. Drivers need to create those properties on cursor planes which require the mouse hotspot coordinates. Add the code creating hotspot properties and port away from old legacy hotspot API. The legacy

[PATCH 2/6] drm/vmwgfx: Create mouse hotspot properties on cursor planes

2022-06-02 Thread Zack Rusin
From: Zack Rusin Atomic modesetting got support for mouse hotspots via the hotspot properties. Drivers need to create those properties on cursor planes which require the mouse hotspot coordinates. Add the code creating hotspot properties and port away from old legacy hotspot API. The legacy

[PATCH 1/6] drm/atomic: Add support for mouse hotspots

2022-06-02 Thread Zack Rusin
From: Zack Rusin Atomic modesetting code lacked support for specifying mouse cursor hotspots. The legacy kms DRM_IOCTL_MODE_CURSOR2 had support for setting the hotspot but the functionality was not implemented in the new atomic paths. Due to the lack of hotspots in the atomic paths userspace

[PATCH 0/6] drm: Add mouse cursor hotspot support to atomic KMS

2022-06-02 Thread Zack Rusin
From: Zack Rusin Support for setting mouse cursor hotspot never made the transition from the legacy kms to atomic. This left virtualized drivers, all which are atomic, in a weird spot because all userspace compositors put those drivers on deny-lists for atomic kms due to the fact that mouse

Re: [PATCH 1/2] dt-bindings: backlight: rt4831: Add the new property for ocp level selection

2022-06-02 Thread ChiYuan Huang
Krzysztof Kozlowski 於 2022年6月2日 週四 下午9:58寫道: > > On 02/06/2022 15:56, Rob Herring wrote: > > On Thu, May 26, 2022 at 12:32:12PM +0200, Krzysztof Kozlowski wrote: > >> On 26/05/2022 10:13, ChiYuan Huang wrote: > >>> Krzysztof Kozlowski 於 2022年5月26日 週四 > >>> 下午4:06寫道: > > On 26/05/2022

Re: [PATCH v3 2/4] drm/panel-edp: Take advantage of wait_hpd_asserted() in struct drm_dp_aux

2022-06-02 Thread Dmitry Baryshkov
On 18/04/2022 20:17, Douglas Anderson wrote: Let's add support for being able to read the HPD pin even if it's hooked directly to the controller. This will allow us to get more accurate delays also lets us take away the waiting in the AUX transfer functions of the eDP controller drivers.

Re: [PATCH v3 4/4] drm/bridge: parade-ps8640: Provide wait_hpd_asserted() in struct drm_dp_aux

2022-06-02 Thread Dmitry Baryshkov
On 18/04/2022 20:17, Douglas Anderson wrote: This implements the callback added by the patch ("drm/dp: Add wait_hpd_asserted() callback to struct drm_dp_aux"). With this change and all the two "DP AUX Endpoint" drivers changed to use wait_hpd_asserted(), we no longer need to have an long delay

Re: [PATCH v5 1/6] dt-bindings: gpu: v3d: Add BCM2711's compatible

2022-06-02 Thread Rob Herring
On Wed, 01 Jun 2022 12:02:44 +0100, Peter Robinson wrote: > BCM2711, Raspberry Pi 4's SoC, contains a V3D core. So add its specific > compatible to the bindings. > > Signed-off-by: Nicolas Saenz Julienne > Signed-off-by: Peter Robinson > --- > Changes since v5: > - Change compatible to align

  1   2   >