Re: [PATCH v7 01/14] mm: rename is_pinnable_pages to is_pinnable_longterm_pages

2022-07-01 Thread Andrew Morton
On Thu, 30 Jun 2022 00:15:06 +0200 David Hildenbrand wrote: > On 30.06.22 00:08, Felix Kuehling wrote: > > On 2022-06-29 03:33, David Hildenbrand wrote: > >> On 29.06.22 05:54, Alex Sierra wrote: > >>> is_pinnable_page() and folio_is_pinnable() were renamed to > >>> is_longterm_pinnable_page() an

[PATCH] dt-bindings: display: sun4i: Fix D1 pipeline count

2022-07-01 Thread Samuel Holland
When adding the bindings for the D1 display engine, I missed the condition for the number of pipelines. D1 has two mixers, so it will have two pipeline references. Fixes: ae5a5d26c15c ("dt-bindings: display: Add D1 display engine compatibles") Signed-off-by: Samuel Holland --- .../bindings/disp

Re: [PATCH] drm/i915/display: clean up comments

2022-07-01 Thread Matt Roper
On Fri, Jul 01, 2022 at 04:32:36PM -0400, Tom Rix wrote: > spelling changes > resoluition -> resolution > dont-> don't > commmit -> commit > Invalidade -> Invalidate > > Signed-off-by: Tom Rix Reviewed-by: Matt Roper and applied to drm-intel-next. Thanks for the patch. Matt >

Re: [Intel-gfx] [PATCH v8 0/3] drm/doc/rfc: i915 VM_BIND feature design + uapi

2022-07-01 Thread Matt Roper
On Thu, Jun 30, 2022 at 05:31:07PM -0700, Niranjana Vishwanathapura wrote: > This is the i915 driver VM_BIND feature design RFC patch series along > with the required uapi definition and description of intended use cases. > > v2: Reduce the scope to simple Mesa use case. > Remove all compute r

Re: [PATCH 2/2] drm/i915: DG2 and ATS-M device ID updates

2022-07-01 Thread Matt Roper
On Fri, Jul 01, 2022 at 09:59:50AM -0700, Lucas De Marchi wrote: > On Fri, Jul 01, 2022 at 08:22:31AM -0700, Matt Roper wrote: > > Small BAR support has now landed, which allows us to add the PCI IDs > > that correspond to add-in card designs of DG2 and ATS-M. There's also > > one additional MB-do

[PATCH] drm/i915/gt: Add general DSS steering iterator to intel_gt_mcr

2022-07-01 Thread Matt Roper
Although all DSS belong to a single pool on Xe_HP platforms (i.e., they're not organized into slices from a topology point of view), we do still need to pass 'group' and 'instance' targets when steering register accesses to a specific instance of a per-DSS multicast register. The rules for how to

[RFC 09/10] drm/i915/vm_bind: Skip vma_lookup for persistent vmas

2022-07-01 Thread Niranjana Vishwanathapura
vma_lookup is tied to segment of the object instead of section of VA space. Hence, it do not support aliasing (ie., multiple bindings to the same section of the object). Skip vma_lookup for persistent vmas as it supports aliasing. Signed-off-by: Niranjana Vishwanathapura --- drivers/gpu/drm/i915

[RFC 00/10] drm/i915/vm_bind: Add VM_BIND functionality

2022-07-01 Thread Niranjana Vishwanathapura
DRM_I915_GEM_VM_BIND/UNBIND ioctls allows UMD to bind/unbind GEM buffer objects (BOs) or sections of a BOs at specified GPU virtual addresses on a specified address space (VM). Multiple mappings can map to the same physical pages of an object (aliasing). These mappings (also referred to as persiste

[RFC 07/10] drm/i915/vm_bind: Handle persistent vmas in execbuf3

2022-07-01 Thread Niranjana Vishwanathapura
Handle persistent (VM_BIND) mappings during the request submission in the execbuf3 path. Signed-off-by: Niranjana Vishwanathapura --- .../gpu/drm/i915/gem/i915_gem_execbuffer3.c | 176 +- 1 file changed, 175 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/gem/i9

[RFC 04/10] drm/i915/vm_bind: Add out fence support

2022-07-01 Thread Niranjana Vishwanathapura
Add support for handling out fence of vm_bind call. Signed-off-by: Niranjana Vishwanathapura --- drivers/gpu/drm/i915/gem/i915_gem_vm_bind.h | 2 + .../drm/i915/gem/i915_gem_vm_bind_object.c| 74 +++ drivers/gpu/drm/i915/i915_vma.c | 6 +- drivers/gpu/drm/i9

[RFC 06/10] drm/i915/vm_bind: Add I915_GEM_EXECBUFFER3 ioctl

2022-07-01 Thread Niranjana Vishwanathapura
Add new execbuf3 ioctl (I915_GEM_EXECBUFFER3) which only works in vm_bind mode. The vm_bind mode only works with this new execbuf3 ioctl. The new execbuf3 ioctl will not have any execlist support and all the legacy support like relocations etc are removed. Signed-off-by: Niranjana Vishwanathapura

[RFC 10/10] drm/i915/vm_bind: Fix vm->vm_bind_mutex and vm->mutex nesting

2022-07-01 Thread Niranjana Vishwanathapura
VM_BIND functionality maintain that vm->vm_bind_mutex will never be taken while holding vm->mutex. However, while closing 'vm', vma is destroyed while holding vm->mutex. But vma releasing needs to take vm->vm_bind_mutex in order to delete vma from the vm_bind_list. To avoid this, destroy the vma ou

[RFC 01/10] drm/i915/vm_bind: Introduce VM_BIND ioctl

2022-07-01 Thread Niranjana Vishwanathapura
Add VM_BIND and VM_UNBIND ioctls to bind/unbind a section of an object at the specified GPU virtual addresses. Add I915_PARAM_VM_BIND_VERSION to indicate version of VM_BIND feature supported and I915_VM_CREATE_FLAGS_USE_VM_BIND for UMDs to select the vm_bind mode of binding. Signed-off-by: Niranj

[RFC 05/10] drm/i915/vm_bind: Handle persistent vmas

2022-07-01 Thread Niranjana Vishwanathapura
Treat VM_BIND vmas as persistent and handle them during the request submission in the execbuff path. Support eviction by maintaining a list of evicted persistent vmas for rebinding during next submission. Signed-off-by: Niranjana Vishwanathapura --- drivers/gpu/drm/i915/gem/i915_gem_object.c

[RFC 08/10] drm/i915/vm_bind: userptr dma-resv changes

2022-07-01 Thread Niranjana Vishwanathapura
For persistent (vm_bind) vmas of userptr BOs, handle the user page pinning by using the i915_gem_object_userptr_submit_init() /done() functions Signed-off-by: Niranjana Vishwanathapura --- .../gpu/drm/i915/gem/i915_gem_execbuffer3.c | 67 +++ .../drm/i915/gem/i915_gem_vm_bind_o

[RFC 02/10] drm/i915/vm_bind: Bind and unbind mappings

2022-07-01 Thread Niranjana Vishwanathapura
Bind and unbind the mappings upon VM_BIND and VM_UNBIND calls. Signed-off-by: Niranjana Vishwanathapura Signed-off-by: Prathap Kumar Valsan --- drivers/gpu/drm/i915/Makefile | 1 + drivers/gpu/drm/i915/gem/i915_gem_create.c| 10 +- drivers/gpu/drm/i915/gem/i915_gem_object

[RFC 03/10] drm/i915/vm_bind: Support private and shared BOs

2022-07-01 Thread Niranjana Vishwanathapura
Add uapi allowing user to specify a BO as private to a specified VM during the BO creation. VM private BOs can only be mapped on the specified VM and can't be dma_buf exported. VM private BOs share a single common dma_resv object, hence has a performance advantage requiring a single dma_resv object

[PATCH] drm/i915/display: clean up comments

2022-07-01 Thread Tom Rix
spelling changes resoluition -> resolution dont-> don't commmit -> commit Invalidade -> Invalidate Signed-off-by: Tom Rix --- drivers/gpu/drm/i915/display/intel_psr.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_psr.c

Re: [PATCH v13 01/10] dt-bindings: mediatek,dp: Add Display Port binding

2022-07-01 Thread Rob Herring
On Fri, Jul 01, 2022 at 02:27:59PM +0800, Bo-Chen Chen wrote: > From: Markus Schneider-Pargmann > > This controller is present on several mediatek hardware. Currently > mt8195 and mt8395 have this controller without a functional difference, > so only one compatible field is added. > > The contro

Re: [PATCH v2 0/4] fbcon: Fixes for screen resolution changes - round 2

2022-07-01 Thread Helge Deller
I resent this v2 patch series - this time including patch 4/4.

[PATCH v2 2/4] fbcon: Prevent that screen size is smaller than font size

2022-07-01 Thread Helge Deller
We need to prevent that users configure a screen size which is smaller than the currently selected font size. Otherwise rendering chars on the screen will access memory outside the graphics memory region. This patch adds a new function fbcon_modechange_possible() which implements this check and wh

[PATCH v2 4/4] fbcon: Use fbcon_info_from_console() in fbcon_modechange_possible()

2022-07-01 Thread Helge Deller
Use the fbcon_info_from_console() wrapper which was added to kernel v5.19 with commit 409d6c95f9c6 ("fbcon: Introduce wrapper for console->fb_info lookup"). Signed-off-by: Helge Deller Reviewed-by: Geert Uytterhoeven --- drivers/video/fbdev/core/fbcon.c | 2 +- 1 file changed, 1 insertion(+),

[PATCH v2 3/4] fbmem: Prevent invalid virtual screen sizes in fb_set_var()

2022-07-01 Thread Helge Deller
Prevent that drivers configure a virtual screen resolution smaller than the physical screen resolution. This is important, because otherwise we may access memory outside of the graphics memory area. Give a kernel WARNing and show the driver name to help locating the buggy driver. Signed-off-by:

[PATCH v2 0/4] fbcon: Fixes for screen resolution changes - round 2

2022-07-01 Thread Helge Deller
This series fixes possible out-of-bound memory accesses when users trigger screen resolutions changes with invalid input parameters, e.g. reconfigures screen which is smaller than the current font size, or if the virtual screen size is smaller than the physical screen size. Changes in v2: - don't

[PATCH v2 1/4] fbcon: Disallow setting font bigger than screen size

2022-07-01 Thread Helge Deller
Prevent that users set a font size which is bigger than the physical screen. It's unlikely this may happen (because screens are usually much larger than the fonts and each font char is limited to 32x32 pixels), but it may happen on smaller screens/LCD displays. Signed-off-by: Helge Deller Reviewe

[PATCH v2 3/4] fbmem: Prevent invalid virtual screen sizes in fb_set_var()

2022-07-01 Thread Helge Deller
Prevent that drivers configure a virtual screen resolution smaller than the physical screen resolution. This is important, because otherwise we may access memory outside of the graphics memory area. Give a kernel WARNing and show the driver name to help locating the buggy driver. Signed-off-by:

[PATCH v2 2/4] fbcon: Prevent that screen size is smaller than font size

2022-07-01 Thread Helge Deller
We need to prevent that users configure a screen size which is smaller than the currently selected font size. Otherwise rendering chars on the screen will access memory outside the graphics memory region. This patch adds a new function fbcon_modechange_possible() which implements this check and wh

[PATCH v2 0/4] fbcon: Fixes for screen resolution changes - round 2

2022-07-01 Thread Helge Deller
This series fixes possible out-of-bound memory accesses when users trigger screen resolutions changes with invalid input parameters, e.g. reconfigures screen which is smaller than the current font size, or if the virtual screen size is smaller than the physical screen size. Changes in v2: - don't

[PATCH v2 1/4] fbcon: Disallow setting font bigger than screen size

2022-07-01 Thread Helge Deller
Prevent that users set a font size which is bigger than the physical screen. It's unlikely this may happen (because screens are usually much larger than the fonts and each font char is limited to 32x32 pixels), but it may happen on smaller screens/LCD displays. Signed-off-by: Helge Deller Reviewe

Re: [PATCH 2/5] fbcon: Fix up user-provided virtual screen size

2022-07-01 Thread Helge Deller
On 7/1/22 16:52, Geert Uytterhoeven wrote: > Hi Helge, > > On Fri, Jul 1, 2022 at 11:30 AM Helge Deller wrote: >> On 7/1/22 09:28, Geert Uytterhoeven wrote: >>> On Thu, Jun 30, 2022 at 10:10 PM Helge Deller wrote: On 6/30/22 22:00, Geert Uytterhoeven wrote: > On Thu, Jun 30, 2022 at 9:46

Re: [PATCH 1/7] dt-bindings: msm: dsi: Fix phy-name binding

2022-07-01 Thread Rob Herring
On Thu, Jun 30, 2022 at 01:08:39PM +0100, Bryan O'Donoghue wrote: > The driver doesn't care about the name of the phy in DTS. msm8916 has since > 2016 named the phy "dsi-phy" with later SoCs taking the name "dsi". Also, for the subject, it's 'phy-names' not 'phy-name'. > There's no reason to have

Re: [PATCH v2 09/15] drm/fbconv: Mode-setting pipeline enable / disable

2022-07-01 Thread Geert Uytterhoeven
Hi Thomas, On Mon, May 30, 2022 at 10:34 AM Geert Uytterhoeven wrote: > On Mon, May 30, 2022 at 9:47 AM Thomas Zimmermann wrote: > > Am 28.05.22 um 22:17 schrieb Geert Uytterhoeven: > > > On Mon, Oct 14, 2019 at 4:05 PM Thomas Zimmermann > > > wrote: > > >> The display mode is set by convertin

Re: [PATCH 1/7] dt-bindings: msm: dsi: Fix phy-name binding

2022-07-01 Thread Rob Herring
On Thu, Jun 30, 2022 at 08:59:03PM +0200, Krzysztof Kozlowski wrote: > On 30/06/2022 14:08, Bryan O'Donoghue wrote: > > The driver doesn't care about the name of the phy in DTS. msm8916 has since > > 2016 named the phy "dsi-phy" with later SoCs taking the name "dsi". > > > > There's no reason to h

Re: [PATCH v3 05/15] dt-bindings: dma: dw-axi-dmac: extend the number of interrupts

2022-07-01 Thread Rob Herring
On Thu, Jun 30, 2022 at 11:12:53PM +, conor.doo...@microchip.com wrote: > On 30/06/2022 22:55, Serge Semin wrote: > > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > > content is safe > > > > On Wed, Jun 29, 2022 at 07:43:34PM +0100, Conor Dooley wrote: > >> From:

Re: [PATCH v3 03/15] ASoC: dt-bindings: convert designware-i2s to dt-schema

2022-07-01 Thread Rob Herring
On Wed, 29 Jun 2022 19:43:32 +0100, Conor Dooley wrote: > From: Conor Dooley > > Convert the Synopsys DesignWare I2S controller binding to dt-schema. > There was no listed maintainer but Jose Abreu was the last editor of the > txt binding so add him as maintainer. > > Signed-off-by: Conor Dooley

Re: [PATCH v3 02/15] dt-bindings: display: ili9341: document canaan kd233's lcd

2022-07-01 Thread Rob Herring
On Wed, 29 Jun 2022 19:43:31 +0100, Conor Dooley wrote: > From: Conor Dooley > > The Canaan KD233 development board has a built in LCD. > Add a specific compatible for it. > > Signed-off-by: Conor Dooley > --- > .../devicetree/bindings/display/panel/ilitek,ili9341.yaml| 1 + > 1 file c

[PATCH v4 14/14] riscv: dts: canaan: build all devicetress if SOC_CANAAN

2022-07-01 Thread Conor Dooley
From: Conor Dooley Testing & checking the Canaan devicetrees is inconvenient as only the devicetree corresponding to SOC_CANAAN_K210_DTB_BUILTIN will be built. Change the Makefile so that all devicetrees are built by default if SOC_CANAAN but only the one specified by SOC_CANAAN_K210_DTB_BUILTIN

[PATCH v4 13/14] riscv: dts: canaan: add specific compatible for kd233's LCD

2022-07-01 Thread Conor Dooley
From: Conor Dooley Add the recently introduced compatible for the LCD on the Canaan KD233. Signed-off-by: Conor Dooley --- arch/riscv/boot/dts/canaan/canaan_kd233.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/riscv/boot/dts/canaan/canaan_kd233.dts b/arch/riscv/b

[PATCH v4 12/14] riscv: dts: canaan: fix bus {ranges,reg} warnings

2022-07-01 Thread Conor Dooley
From: Conor Dooley The k210 devicetrees warn about missing/empty reg and/or ranges properties: arch/riscv/boot/dts/canaan/k210.dtsi:408.22-460.5: Warning (unit_address_vs_reg): /soc/bus@5200: node has a unit name, but no reg or ranges property arch/riscv/boot/dts/canaan/k210.dtsi:352.22-406

[PATCH v4 11/14] riscv: dts: canaan: remove spi-max-frequency from controllers

2022-07-01 Thread Conor Dooley
From: Conor Dooley spi-max-frequency is a device, not a controller property and should be removed. Link: https://lore.kernel.org/lkml/20220526014141.2872567-1-r...@kernel.org/ Tested-by: Niklas Cassel Signed-off-by: Conor Dooley --- arch/riscv/boot/dts/canaan/k210.dtsi | 5 + 1 file chan

[PATCH v4 10/14] riscv: dts: canaan: use custom compatible for k210 i2s

2022-07-01 Thread Conor Dooley
From: Conor Dooley The devicetrees using the Canaan k210 all have a sound-dai-cells value of 1, whereas the standard binding example for the DesignWare i2s and other use cases suggest 0. Use a k210 specific compatible which supports this difference. Signed-off-by: Conor Dooley --- arch/riscv/b

[PATCH v4 09/14] riscv: dts: canaan: fix kd233 display spi frequency

2022-07-01 Thread Conor Dooley
From: Conor Dooley The binding for the ili9341 specifies a const spi-max-frequency of 10 MHz but the kd233 devicetree entry has it listed at 15 Mhz. Align the devicetree with the value in the binding. Signed-off-by: Conor Dooley --- arch/riscv/boot/dts/canaan/canaan_kd233.dts | 2 +- 1 file ch

[PATCH v4 08/14] riscv: dts: canaan: fix mmc node names

2022-07-01 Thread Conor Dooley
From: Conor Dooley The newly-converted-to-dt-schema binding expects the mmc node name to be '^mmc(@.*)?$' so align the devicetree with the schema. Tested-by: Niklas Cassel Signed-off-by: Conor Dooley --- arch/riscv/boot/dts/canaan/canaan_kd233.dts | 2 +- arch/riscv/boot/dts/canaan/sipeed

[PATCH v4 07/14] riscv: dts: canaan: fix the k210's timer nodes

2022-07-01 Thread Conor Dooley
From: Conor Dooley The timers on the k210 have non standard interrupt configurations, which leads to dtbs_check warnings: k210_generic.dtb: timer@502d: interrupts: [[14], [15]] is too long >From schema: Documentation/devicetree/bindings/timer/snps,dw-apb-timer.yaml Split the timer nodes in

[PATCH v4 06/14] riscv: dts: canaan: fix the k210's memory node

2022-07-01 Thread Conor Dooley
From: Conor Dooley The k210 U-Boot port has been using the clocks defined in the devicetree to bring up the board's SRAM, but this violates the dt-schema. As such, move the clocks to a dedicated node with the same compatible string. The regs property does not fit in either node, so is replaced by

[PATCH v4 05/14] dt-bindings: memory-controllers: add canaan k210 sram controller

2022-07-01 Thread Conor Dooley
From: Conor Dooley The k210 U-Boot port has been using the clocks defined in the devicetree to bring up the board's SRAM, but this violates the dt-schema. As such, move the clocks to a dedicated node with the same compatible string & document it. Signed-off-by: Conor Dooley --- .../memory-cont

[PATCH v4 04/14] dt-bindings: dma: dw-axi-dmac: extend the number of interrupts

2022-07-01 Thread Conor Dooley
From: Conor Dooley The Canaan k210 apparently has a Sysnopsys Designware AXI DMA controller, but according to the documentation & devicetree it has 6 interrupts rather than the standard one. Support the 6 interrupt configuration by unconditionally extending the binding to a maximum of 8 per-chann

[PATCH v4 03/14] ASoC: dt-bindings: convert designware-i2s to dt-schema

2022-07-01 Thread Conor Dooley
From: Conor Dooley Convert the Synopsys DesignWare I2S controller binding to dt-schema. There was no listed maintainer but Jose Abreu was the last editor of the txt binding so add him as maintainer. Signed-off-by: Conor Dooley --- .../bindings/sound/designware-i2s.txt | 35 --- ...

[PATCH v4 02/14] dt-bindings: display: ili9341: document canaan kd233's lcd

2022-07-01 Thread Conor Dooley
From: Conor Dooley The Canaan KD233 development board has a built in LCD. Add a specific compatible for it. Signed-off-by: Conor Dooley --- .../devicetree/bindings/display/panel/ilitek,ili9341.yaml| 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/di

[PATCH v4 01/14] dt-bindings: display: convert ilitek, ili9341.txt to dt-schema

2022-07-01 Thread Conor Dooley
From: Conor Dooley A dt-schema binding for the Ilitek ili9341 was created as panel/ilitek,ili9341.yaml but the txt binding was ignored in the process. Move the remaining items in the txt binding to the yaml one & delete it. The example in the txt binding has a spi-max-frequency which disagrees w

[PATCH v4 00/14] Canaan devicetree fixes

2022-07-01 Thread Conor Dooley
From: Conor Dooley Hey all, This series should rid us of dtbs_check errors for the RISC-V Canaan k210 based boards. To make keeping it that way a little easier, I changed the Canaan devicetree Makefile so that it would build all of the devicetrees in the directory if SOC_CANAAN. I *DO NOT* have

[PATCH 10/10] drm/todo: remove task for idr_init_base()

2022-07-01 Thread dakr
From: Danilo Krummrich All IDRs in the DRM core and drivers which are applicable for using idr_init_base() over idr_init() should be set up to use a proper base in order to avoid unnecessary tree walks. Signed-off-by: Danilo Krummrich --- Documentation/gpu/todo.rst | 12 1 file ch

[PATCH 08/10] drm/v3d: use idr_init_base() to initialize v3d_priv->perfmon.idr

2022-07-01 Thread dakr
From: Danilo Krummrich idr_init_base(), implemented by commit 6ce711f27500 ("idr: Make 1-based IDRs more efficient"), let us set an arbitrary base other than idr_init(), which uses base 0. Since, for this IDR, no ID < 1 is ever requested/allocated, using idr_init_base(&idr, 1) avoids unnecessary

[PATCH 09/10] drm/via: use idr_init_base() to initialize dev_priv->object_idr

2022-07-01 Thread dakr
From: Danilo Krummrich idr_init_base(), implemented by commit 6ce711f27500 ("idr: Make 1-based IDRs more efficient"), let us set an arbitrary base other than idr_init(), which uses base 0. Since, for this IDR, no ID < 1 is ever requested/allocated, using idr_init_base(&idr, 1) avoids unnecessary

[PATCH 07/10] drm/sis: use idr_init_base() to initialize dev_priv->object_idr

2022-07-01 Thread dakr
From: Danilo Krummrich idr_init_base(), implemented by commit 6ce711f27500 ("idr: Make 1-based IDRs more efficient"), let us set an arbitrary base other than idr_init(), which uses base 0. Since, for this IDR, no ID < 1 is ever requested/allocated, using idr_init_base(&idr, 1) avoids unnecessary

[PATCH 05/10] drm: use idr_init_base() to initialize mode_config.object_idr

2022-07-01 Thread dakr
From: Danilo Krummrich idr_init_base(), implemented by commit 6ce711f27500 ("idr: Make 1-based IDRs more efficient"), let us set an arbitrary base other than idr_init(), which uses base 0. Since, for this IDR, no ID < 1 is ever requested/allocated, using idr_init_base(&idr, 1) avoids unnecessary

[PATCH 06/10] drm: use idr_init_base() to initialize mode_config.tile_idr

2022-07-01 Thread dakr
From: Danilo Krummrich idr_init_base(), implemented by commit 6ce711f27500 ("idr: Make 1-based IDRs more efficient"), let us set an arbitrary base other than idr_init(), which uses base 0. Since, for this IDR, no ID < 1 is ever requested/allocated, using idr_init_base(&idr, 1) avoids unnecessary

[PATCH 02/10] drm/amdgpu: use idr_init_base() to initialize fpriv->bo_list_handles

2022-07-01 Thread dakr
From: Danilo Krummrich idr_init_base(), implemented by commit 6ce711f27500 ("idr: Make 1-based IDRs more efficient"), let us set an arbitrary base other than idr_init(), which uses base 0. Since, for this IDR, no ID < 1 is ever requested/allocated, using idr_init_base(&idr, 1) avoids unnecessary

[PATCH 04/10] drm: use idr_init_base() to initialize master->lessee_idr

2022-07-01 Thread dakr
From: Danilo Krummrich idr_init_base(), implemented by commit 6ce711f27500 ("idr: Make 1-based IDRs more efficient"), let us set an arbitrary base other than idr_init(), which uses base 0. Since, for this IDR, no ID < 1 is ever requested/allocated, using idr_init_base(&idr, 1) avoids unnecessary

[PATCH 03/10] drm: use idr_init_base() to initialize master->magic_map

2022-07-01 Thread dakr
From: Danilo Krummrich idr_init_base(), implemented by commit 6ce711f27500 ("idr: Make 1-based IDRs more efficient"), let us set an arbitrary base other than idr_init(), which uses base 0. Since, for this IDR, no ID < 1 is ever requested/allocated, using idr_init_base(&idr, 1) avoids unnecessary

[PATCH 00/10] drm: use idr_init_base() over idr_init() if applicable

2022-07-01 Thread dakr
From: Danilo Krummrich This patch series initializes IDRs with idr_init_base(&idr, 1) rather than idr_init(&idr) in case for the particular IDR no IDs < 1 are ever requested - this avoids unnecessary tree walks. Danilo Krummrich (10): drm/amdgpu: use idr_init_base() to initialize mgr->ctx_hand

[PATCH 01/10] drm/amdgpu: use idr_init_base() to initialize mgr->ctx_handles

2022-07-01 Thread dakr
From: Danilo Krummrich idr_init_base(), implemented by commit 6ce711f27500 ("idr: Make 1-based IDRs more efficient"), let us set an arbitrary base other than idr_init(), which uses base 0. Since, for this IDR, no ID < 1 is ever requested, using idr_init_base(&idr, 1) avoids unnecessary tree walk

[Bug 216198] New: uvd page faults on Radeon

2022-07-01 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=216198 Bug ID: 216198 Summary: uvd page faults on Radeon Product: Drivers Version: 2.5 Kernel Version: 5.15 Hardware: AMD OS: Linux Tree: Mainline Status

Re: [PATCH 0/2] drm: A couple of fixes for drm_copy_field() helper function

2022-07-01 Thread Peter Robinson
On Fri, Jul 1, 2022 at 1:08 PM Javier Martinez Canillas wrote: > > Hello, > > Peter Robinson reported me a kernel bug in one of his aarch64 test boards > and even though I was not able to reproduce it, I think that figured out > what the problem was. It seems the cause is that a DRM driver doesn't

Re: [PATCH v3 1/4] dt-bindings: display: panel-common: allow for additional port node properties

2022-07-01 Thread Rob Herring
On Tue, Jun 28, 2022 at 08:18:35PM +0200, Max Krummenacher wrote: > From: Max Krummenacher > > Allow bindings which reference panel-common.yaml to add additional > properties under the port node. > I.e. 'panel-dpi' needs to add a new property to 'port/endpoint'. > > Signed-off-by: Max Krummenach

Re: [Intel-gfx] [PATCH 1/2] Revert "topic/core-for-CI: Add remaining DG2 and ATS-M device IDs"

2022-07-01 Thread Lucas De Marchi
On Fri, Jul 01, 2022 at 08:22:30AM -0700, Matt Roper wrote: This reverts commit f7d7dddaab81eeae4508197b5f38f0b974d97b8c. In reality we'll just rebase this patch out of the topic/core-for-CI branch after landing the "real" copy in drm-intel. But to prevent pre-merge CI from getting confused, we

Re: [PATCH 2/2] drm/i915: DG2 and ATS-M device ID updates

2022-07-01 Thread Lucas De Marchi
On Fri, Jul 01, 2022 at 08:22:31AM -0700, Matt Roper wrote: Small BAR support has now landed, which allows us to add the PCI IDs that correspond to add-in card designs of DG2 and ATS-M. There's also one additional MB-down PCI ID that recently appeared (0x5698) so we add it too. Cc: Lucas De Mar

[PATCH 1/2] Revert "topic/core-for-CI: Add remaining DG2 and ATS-M device IDs"

2022-07-01 Thread Matt Roper
This reverts commit f7d7dddaab81eeae4508197b5f38f0b974d97b8c. In reality we'll just rebase this patch out of the topic/core-for-CI branch after landing the "real" copy in drm-intel. But to prevent pre-merge CI from getting confused, we send it as an explicit revert on the mailing list. Cc: Lucas

[PATCH 2/2] drm/i915: DG2 and ATS-M device ID updates

2022-07-01 Thread Matt Roper
Small BAR support has now landed, which allows us to add the PCI IDs that correspond to add-in card designs of DG2 and ATS-M. There's also one additional MB-down PCI ID that recently appeared (0x5698) so we add it too. Cc: Lucas De Marchi Signed-off-by: Matt Roper --- drivers/gpu/drm/i915/i915

Re: [PATCH 2/5] fbcon: Fix up user-provided virtual screen size

2022-07-01 Thread Geert Uytterhoeven
Hi Helge, On Fri, Jul 1, 2022 at 11:30 AM Helge Deller wrote: > On 7/1/22 09:28, Geert Uytterhoeven wrote: > > On Thu, Jun 30, 2022 at 10:10 PM Helge Deller wrote: > >> On 6/30/22 22:00, Geert Uytterhoeven wrote: > >>> On Thu, Jun 30, 2022 at 9:46 PM Helge Deller wrote: > On 6/30/22 21:36,

Re: [PATCH 4/5] fbmem: Prevent invalid virtual screen sizes in fb_set_var()

2022-07-01 Thread Geert Uytterhoeven
Hi Helge, On Thu, Jun 30, 2022 at 9:38 PM Geert Uytterhoeven wrote: > On Thu, Jun 30, 2022 at 9:17 PM Helge Deller wrote: > > On 6/30/22 21:11, Geert Uytterhoeven wrote: > > > On Wed, Jun 29, 2022 at 10:00 PM Helge Deller wrote: > > >> Prevent that drivers configure a virtual screen resolution

Re: [PATCH v4 1/2] drm/i915/edid: convert DP, HDMI and LVDS to drm_edid

2022-07-01 Thread Ville Syrjälä
On Fri, Jul 01, 2022 at 11:55:38AM +0300, Jani Nikula wrote: > Convert all the connectors that use cached connector edid and > detect_edid to drm_edid. > > Since drm_get_edid() calls drm_connector_update_edid_property() while > drm_edid_read*() do not, we need to call drm_edid_connector_update() >

Re: [PATCH V2 0/5] I2S driver changes for Jadeite platform

2022-07-01 Thread Mukunda,Vijendar
On 7/1/22 5:21 PM, Mark Brown wrote: > On Fri, Jul 01, 2022 at 05:11:02PM +0530, Vijendar Mukunda wrote: > >> This patch set depends on: >> --checkpatch warnings patch >> >> --https://patchwork.kernel.org/project/alsa-devel/patch/20220627125834.481731-1-vijendar.muku...@amd.com/ > >

[PATCH 1/2] drm: Use size_t type for len variable in drm_copy_field()

2022-07-01 Thread Javier Martinez Canillas
The strlen() function returns a size_t which is an unsigned int on 32-bit arches and an unsigned long on 64-bit arches. But in the drm_copy_field() function, the strlen() return value is assigned to an 'int len' variable. Later, the len variable is passed as copy_from_user() third argument that is

[PATCH 2/2] drm: Prevent drm_copy_field() to attempt copying a NULL pointer

2022-07-01 Thread Javier Martinez Canillas
The drm_copy_field() helper is used to copy some struct drm_driver fields to userspace through the DRM_IOCTL_VERSION ioctl. But it could be possible that the driver didn't set some of the fields and are instead set to NULL. If that is the case, the drm_copy_field() attempts to copy a NULL pointer:

[PATCH 0/2] drm: A couple of fixes for drm_copy_field() helper function

2022-07-01 Thread Javier Martinez Canillas
Hello, Peter Robinson reported me a kernel bug in one of his aarch64 test boards and even though I was not able to reproduce it, I think that figured out what the problem was. It seems the cause is that a DRM driver doesn't set some of the struct drm fields copied to userspace via DRM_IOCTL_VERSIO

Re: [PATCH V2 0/5] I2S driver changes for Jadeite platform

2022-07-01 Thread Mark Brown
On Fri, Jul 01, 2022 at 05:11:02PM +0530, Vijendar Mukunda wrote: > This patch set depends on: > --checkpatch warnings patch > > --https://patchwork.kernel.org/project/alsa-devel/patch/20220627125834.481731-1-vijendar.muku...@amd.com/ That's "drm: amd: amdgpu: fix checkpatch warnin

[PATCH V2 5/5] ASoC: amd: enable machine driver build for Jadeite platform

2022-07-01 Thread Vijendar Mukunda
Enable machine driver build for Jadeite platform using ES8336 Codec. Signed-off-by: Vijendar Mukunda --- sound/soc/amd/Kconfig | 13 + sound/soc/amd/Makefile | 2 ++ 2 files changed, 15 insertions(+) diff --git a/sound/soc/amd/Kconfig b/sound/soc/amd/Kconfig index 1381aec23048..c3

[PATCH V2 4/5] ASoC: amd: add Machine driver for Jadeite platform

2022-07-01 Thread Vijendar Mukunda
Add Machine driver for Jadeite platform which uses ES8336 codec. Signed-off-by: Vijendar Mukunda --- sound/soc/amd/acp-es8336.c | 324 + 1 file changed, 324 insertions(+) create mode 100644 sound/soc/amd/acp-es8336.c diff --git a/sound/soc/amd/acp-es8336.c b

[PATCH V2 3/5] ASoC: amd: add I2S MICSP instance support

2022-07-01 Thread Vijendar Mukunda
Add I2S MICSP instance support for Stoney variant. Signed-off-by: Vijendar Mukunda --- sound/soc/amd/acp-pcm-dma.c | 50 +++-- sound/soc/amd/acp.h | 13 ++ 2 files changed, 61 insertions(+), 2 deletions(-) diff --git a/sound/soc/amd/acp-pcm-dma.c

[PATCH V2 2/5] drm/amdgpu: create I2S platform devices for Jadeite platform

2022-07-01 Thread Vijendar Mukunda
Jadeite platform uses I2S MICSP instance. Create platform devices for DMA controller and I2S controller for Jadeite platform. Signed-off-by: Vijendar Mukunda Acked-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c | 293 +++- 1 file changed, 184 insertions(+), 109

[PATCH V2 1/5] drm/amdgpu: add dmi check for jadeite platform

2022-07-01 Thread Vijendar Mukunda
DMI check is required to distinguish Jadeite platform from Stoney base variant. Add DMI check logic for Jadeite platform. Signed-off-by: Vijendar Mukunda Acked-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c | 36 + 1 file changed, 36 insertions(+) diff --g

[PATCH V2 0/5] I2S driver changes for Jadeite platform

2022-07-01 Thread Vijendar Mukunda
Jadeite(JD) platform is Stoney APU varaint which uses I2S MICSP instance and ES8336 Codec. This patch series creates I2S platform devices for JD platform, adds I2S MICSP instance support and Machine driver support This patch set depends on: --checkpatch warnings patch --https://pa

Re: [PATCH v3 00/15] Canaan devicetree fixes

2022-07-01 Thread Sudeep Holla
On Fri, Jul 01, 2022 at 06:16:14AM +0900, Damien Le Moal wrote: > On 7/1/22 02:53, Sudeep Holla wrote: > > On Thu, Jun 30, 2022 at 04:28:26PM +, Niklas Cassel wrote: > >> On Wed, Jun 29, 2022 at 07:43:29PM +0100, Conor Dooley wrote: > >>> From: Conor Dooley > >>> > >>> Hey all, > >>> This seri

Re: [PATCH 3/3] drm/bridge: fsl-ldb: Drop DE signal polarity inversion

2022-07-01 Thread Marek Vasut
On 7/1/22 08:56, Liu Ying wrote: It's unnecessary to invert input data enable signal polarity according to the output one. Let's drop the inversion. Since ->atomic_check() does nothing more than the inversion, it can be dropped entirely as well. Without this patch, 'koe,tx26d202vm0bwa' LVDS pane

Re: [PATCH 2/3] drm/bridge: fsl-ldb: Enable split mode for LVDS dual link

2022-07-01 Thread Marek Vasut
On 7/1/22 08:56, Liu Ying wrote: When LVDS dual link is used, we have to enable the LDB_CTRL_SPLIT_MODE bit. Fixes: 463db5c2ed4a ("drm: bridge: ldb: Implement simple Freescale i.MX8MP LDB bridge") Cc: Andrzej Hajda Cc: Neil Armstrong Cc: Robert Foss Cc: Laurent Pinchart Cc: Jonas Karlman C

Re: [PATCH 1/3] drm/bridge: fsl-ldb: Fix mode clock rate validation

2022-07-01 Thread Marek Vasut
On 7/1/22 08:56, Liu Ying wrote: With LVDS dual link, up to 160MHz mode clock rate is supported. With LVDS single link, up to 80MHz mode clock rate is supported. Fix mode clock rate validation by swapping the maximum mode clock rates of the two link modes. Fixes: 463db5c2ed4a ("drm: bridge: ldb:

Re: [PATCH v6 14/22] dma-buf: Introduce new locking convention

2022-07-01 Thread Dmitry Osipenko
On 6/29/22 00:26, Thomas Hellström (Intel) wrote: > > On 5/30/22 15:57, Dmitry Osipenko wrote: >> On 5/30/22 16:41, Christian König wrote: >>> Hi Dmitry, >>> >>> Am 30.05.22 um 15:26 schrieb Dmitry Osipenko: Hello Christian, On 5/30/22 09:50, Christian König wrote: > Hi Dmitry,

Re: (subset) [PATCH v3 00/15] Canaan devicetree fixes

2022-07-01 Thread Mark Brown
On Wed, 29 Jun 2022 19:43:29 +0100, Conor Dooley wrote: > From: Conor Dooley > > Hey all, > This series should rid us of dtbs_check errors for the RISC-V Canaan k210 > based boards. To make keeping it that way a little easier, I changed the > Canaan devicetree Makefile so that it would build all

Re: [PATCH 2/5] fbcon: Fix up user-provided virtual screen size

2022-07-01 Thread Helge Deller
Hi Geert, On 7/1/22 09:28, Geert Uytterhoeven wrote: > On Thu, Jun 30, 2022 at 10:10 PM Helge Deller wrote: >> On 6/30/22 22:00, Geert Uytterhoeven wrote: >>> On Thu, Jun 30, 2022 at 9:46 PM Helge Deller wrote: On 6/30/22 21:36, Geert Uytterhoeven wrote: > On Thu, Jun 30, 2022 at 9:31 P

[PATCH -next] drm/amd/display: clean up some inconsistent indenting

2022-07-01 Thread Yang Li
Eliminate the follow smatch warning: drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc.c:3151 commit_planes_for_stream() warn: inconsistent indenting Signed-off-by: Yang Li --- drivers/gpu/drm/amd/display/dc/core/dc.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a

[PATCH v8 1/2] drm/gem: Properly annotate WW context on drm_gem_lock_reservations() error

2022-07-01 Thread Dmitry Osipenko
Use ww_acquire_fini() in the error code paths. Otherwise lockdep thinks that lock is held when lock's memory is freed after the drm_gem_lock_reservations() error. The ww_acquire_context needs to be annotated as "released", which fixes the noisy "WARNING: held lock freed!" splat of VirtIO-GPU driver

[PATCH v8 2/2] drm/gem: Don't map imported GEMs

2022-07-01 Thread Dmitry Osipenko
Drivers that use drm_gem_mmap() and drm_gem_mmap_obj() helpers don't handle imported dma-bufs properly, which results in mapping of something else than the imported dma-buf. On NVIDIA Tegra we get a hard lockup when userspace writes to the memory mapping of a dma-buf that was imported into Tegra's

[PATCH v8 0/2] DRM GEM fixes

2022-07-01 Thread Dmitry Osipenko
This patchset fixes two problems in the common GEM code. First fixed problem is the bogus lockdep splat that complicates debugging of DRM drivers. Second problem is the inconsistency in behaviour and improper handling of mapping the imported GEMs by some drivers, to fix it we will prohibit to map t

Re: [PATCH v4 1/2] drm/i915/edid: convert DP, HDMI and LVDS to drm_edid

2022-07-01 Thread Jani Nikula
On Fri, 01 Jul 2022, Jani Nikula wrote: > Convert all the connectors that use cached connector edid and > detect_edid to drm_edid. > > Since drm_get_edid() calls drm_connector_update_edid_property() while > drm_edid_read*() do not, we need to call drm_edid_connector_update() > separately, in part

[PATCH v4 2/2] drm/i915/bios: convert intel_bios_init_panel() to drm_edid

2022-07-01 Thread Jani Nikula
Try to use struct drm_edid where possible, even if having to fall back to looking into struct edid down low via drm_edid_raw(). v2: Rebase Signed-off-by: Jani Nikula Reviewed-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_bios.c | 19 ++- drivers/gpu/drm/i915/display/

[PATCH v4 0/2] drm/i915: switch DP, HDMI and LVDS to drm_edid

2022-07-01 Thread Jani Nikula
The remaining patches to add HF-EEODB support to i915 by switching to using drm_edid in certain encoders. This depends on the drm_edid work in drm-misc-next, and either needs to be merged via drm-misc-next, or we'll need the dependencies merged to drm-intel-next via drm-misc-next pull request -> dr

[PATCH v4 1/2] drm/i915/edid: convert DP, HDMI and LVDS to drm_edid

2022-07-01 Thread Jani Nikula
Convert all the connectors that use cached connector edid and detect_edid to drm_edid. Since drm_get_edid() calls drm_connector_update_edid_property() while drm_edid_read*() do not, we need to call drm_edid_connector_update() separately, in part due to the EDID caching behaviour in HDMI and DP. Es

Re: [PATCH resend] drm: panel-orientation-quirks: Add quirk for the Lenovo Yoga Tablet 2 830

2022-07-01 Thread Hans de Goede
Hi, On 6/23/22 13:46, Javier Martinez Canillas wrote: > Hello Hans, > > On 6/23/22 13:27, Hans de Goede wrote: >> The Lenovo Yoga Tablet 2 830F / 830L use a panel which has been mounted >> 90 degrees rotated. Add a quirk for this. >> >> Signed-off-by: Hans de Goede >> --- > > The patch looks go

Re: [PATCH v6 3/3] drm/doc/rfc: VM_BIND uapi definition

2022-07-01 Thread Matthew Auld
On 30/06/2022 17:23, Matthew Auld wrote: On 30/06/2022 16:34, Jason Ekstrand wrote: On Thu, Jun 30, 2022 at 10:14 AM Matthew Auld > wrote:     On 30/06/2022 06:11, Jason Ekstrand wrote: > On Sat, Jun 25, 2022 at 8:49 PM Niranjana Vishwanathapura > mailto

  1   2   >