RE: [Intel-gfx] [PATCH v6 07/10] drm/i915/hdcp: Use HDCP helpers for i915

2023-03-13 Thread Kandpal, Suraj
> > From: Sean Paul > > Now that all of the HDCP 1.x logic has been migrated to the central HDCP > helpers, use it in the i915 driver. > > The majority of the driver code for HDCP 1.x will live in intel_hdcp.c, > however there are a few helper hooks which are connector-specific and > need to

[PATCH v2] drm/bridge: Fix returned array size name for atomic_get_input_bus_fmts kdoc

2023-03-13 Thread Liu Ying
The returned array size for input formats is set through atomic_get_input_bus_fmts()'s 'num_input_fmts' argument, so use 'num_input_fmts' to represent the array size in the function's kdoc, not 'num_output_fmts'. Fixes: 91ea83306bfa ("drm/bridge: Fix the bridge kernel doc") Fixes: f32df58acc68

[PATCH -next 2/3] video: fbdev: wm8505fb: Use devm_platform_ioremap_resource()

2023-03-13 Thread Yang Li
According to commit 7945f929f1a7 ("drivers: provide devm_platform_ioremap_resource()"), convert platform_get_resource(), devm_ioremap_resource() to a single call to Use devm_platform_ioremap_resource(), as this is exactly what this function does. Signed-off-by: Yang Li ---

[PATCH -next 3/3] video: fbdev: xilinxfb: Use devm_platform_get_and_ioremap_resource()

2023-03-13 Thread Yang Li
According to commit 890cc39a8799 ("drivers: provide devm_platform_get_and_ioremap_resource()"), convert platform_get_resource(), devm_ioremap_resource() to a single call to devm_platform_get_and_ioremap_resource(), as this is exactly what this function does. Signed-off-by: Yang Li ---

[PATCH -next 1/3] video: fbdev: pxa3xx-gcu: Use devm_platform_get_and_ioremap_resource()

2023-03-13 Thread Yang Li
According to commit 890cc39a8799 ("drivers: provide devm_platform_get_and_ioremap_resource()"), convert platform_get_resource(), devm_ioremap_resource() to a single call to devm_platform_get_and_ioremap_resource(), as this is exactly what this function does. Signed-off-by: Yang Li ---

[PATCH] drm/lima/lima_drv: Add missing unwind goto in lima_pdev_probe()

2023-03-13 Thread Harshit Mogalapalli
Smatch reports: drivers/gpu/drm/lima/lima_drv.c:396 lima_pdev_probe() warn: missing unwind goto? Store return value in err and goto 'err_out0' which has lima_sched_slab_fini() before returning. Fixes: a1d2a6339961 ("drm/lima: driver for ARM Mali4xx GPUs") Signed-off-by: Harshit

Re: [PATCH v5 30/32] drm/msm/dpu: drop smart_dma_rev from dpu_caps

2023-03-13 Thread Abhinav Kumar
On 3/9/2023 4:57 PM, Dmitry Baryshkov wrote: The code doesn't use dpu_caps::smart_dma_rev field. It checks if the corresponding feature is enabled in the SSPP features. Drop the smart_dma_rev field completely. Signed-off-by: Dmitry Baryshkov Reviewed-by: Abhinav Kumar

Re: [PATCH v5 29/32] drm/msm/dpu: enable SmartDMA for the rest of the platforms

2023-03-13 Thread Abhinav Kumar
On 3/9/2023 4:57 PM, Dmitry Baryshkov wrote: Enable SmartDMA features for the rest of the platforms where it is supposed to work. Signed-off-by: Dmitry Baryshkov I am so glad we split this. Without visual validation check we wouldnt have caught the issues and would have ended up with a

Re: [PATCH v5 28/32] drm/msm/dpu: populate SmartDMA features in hw catalog

2023-03-13 Thread Abhinav Kumar
On 3/9/2023 4:57 PM, Dmitry Baryshkov wrote: Downstream driver uses dpu->caps->smart_dma_rev to update sspp->cap->features with the bit corresponding to the supported SmartDMA version. Upstream driver does not do this, resulting in SSPP subdriver not enabling setup_multirect callback. Add

Re: [PATCH v5 32/32] drm/msm/dpu: remove unused dpu_plane_validate_multirect_v2 function

2023-03-13 Thread Abhinav Kumar
On 3/9/2023 4:57 PM, Dmitry Baryshkov wrote: From: Abhinav Kumar After cleaning up the older multirect support the function dpu_plane_validate_multirect_v2() is unused. Lets remove it. Signed-off-by: Abhinav Kumar this needs your signed-off too. ---

Re: [PATCH v5 31/32] drm/msm/dpu: log the multirect_index in _dpu_crtc_blend_setup_pipe

2023-03-13 Thread Abhinav Kumar
On 3/9/2023 4:57 PM, Dmitry Baryshkov wrote: From: Abhinav Kumar Lets print the multirect_index as well in _dpu_crtc_blend_setup_pipe() as it will give the complete information of the sw_pipe as well. Signed-off-by: Abhinav Kumar This needs your signed-off too ---

Re: [PATCH v5 16/32] drm/msm/dpu: move the rest of plane checks to dpu_plane_atomic_check()

2023-03-13 Thread Abhinav Kumar
On 3/13/2023 9:14 PM, Dmitry Baryshkov wrote: On 14/03/2023 06:02, Abhinav Kumar wrote: On 3/9/2023 4:56 PM, Dmitry Baryshkov wrote: Move plane state updates from dpu_crtc_atomic_check() to the function where they belong: to dpu_plane_atomic_check(). Signed-off-by: Dmitry Baryshkov

Re: [PATCH v5 27/32] drm/msm/dpu: add support for wide planes

2023-03-13 Thread Abhinav Kumar
On 3/9/2023 4:56 PM, Dmitry Baryshkov wrote: Typically SSPP can support rectangle with width up to 2560. However it's Please change 2560 > max line width of SSPP as previously commented possible to use multirect feature and split source to use the SSPP to output two consecutive

[PATCH] drm/amdgpu/nv: Apply ASPM quirk on Intel ADL + AMD Navi

2023-03-13 Thread Kai-Heng Feng
S2idle resume freeze can be observed on Intel ADL + AMD WX5500. This is caused by commit 0064b0ce85bb ("drm/amd/pm: enable ASPM by default"). The root cause is still not clear for now. So extend and apply the ASPM quirk from commit e02fe3bc7aba ("drm/amdgpu: vi: disable ASPM on Intel Alder Lake

Re: [PATCH v5 26/32] drm/msm/dpu: split pipe handling from _dpu_crtc_blend_setup_mixer

2023-03-13 Thread Abhinav Kumar
On 3/9/2023 4:56 PM, Dmitry Baryshkov wrote: Rework _dpu_crtc_blend_setup_mixer() to split away pipe handling to a separate functon. This is a preparation for the r_pipe support. Signed-off-by: Dmitry Baryshkov Reviewed-by: Abhinav Kumar

Re: [PATCH v5 25/32] drm/msm/dpu: rework static color fill code

2023-03-13 Thread Abhinav Kumar
On 3/9/2023 4:56 PM, Dmitry Baryshkov wrote: Rework static color fill code to separate the pipe / pipe_cfg handling. This is a preparation for the r_pipe support. Signed-off-by: Dmitry Baryshkov Reviewed-by: Abhinav Kumar

Re: [PATCH v5 23/32] drm/msm/dpu: rework dpu_plane_atomic_check()

2023-03-13 Thread Abhinav Kumar
On 3/9/2023 4:56 PM, Dmitry Baryshkov wrote: Split pipe-dependent code from dpu_plane_atomic_check() into the separate function dpu_plane_atomic_check_pipe(). This is one of preparational steps to add r_pipe support. Signed-off-by: Dmitry Baryshkov Reviewed-by: Abhinav Kumar

Re: [PATCH v5 22/32] drm/msm/dpu: rework dpu_plane_sspp_atomic_update()

2023-03-13 Thread Abhinav Kumar
On 3/9/2023 4:56 PM, Dmitry Baryshkov wrote: Split pipe-dependent code from dpu_plane_sspp_atomic_update() into the separate function dpu_plane_sspp_update_pipe(). This is one of preparational steps to add r_pipe support. Signed-off-by: Dmitry Baryshkov Reviewed-by: Abhinav Kumar

Re: [PATCH v5 21/32] drm/msm/dpu: simplify dpu_plane_validate_src()

2023-03-13 Thread Abhinav Kumar
On 3/9/2023 4:56 PM, Dmitry Baryshkov wrote: The plane's clipped coordinates has already been validated against FB size in the drm_atomic_plane_check(). There is no need to check them again. Remove corresponding checks and inline dpu_plane_validate_src(). Signed-off-by: Dmitry Baryshkov

Re: [PATCH v5 16/32] drm/msm/dpu: move the rest of plane checks to dpu_plane_atomic_check()

2023-03-13 Thread Dmitry Baryshkov
On 14/03/2023 06:02, Abhinav Kumar wrote: On 3/9/2023 4:56 PM, Dmitry Baryshkov wrote: Move plane state updates from dpu_crtc_atomic_check() to the function where they belong: to dpu_plane_atomic_check(). Signed-off-by: Dmitry Baryshkov Can you please elaborate a bit on this comment?

Re: [PATCH v5 20/32] drm/msm/dpu: add dpu_hw_sspp_cfg to dpu_plane_state

2023-03-13 Thread Abhinav Kumar
On 3/9/2023 4:56 PM, Dmitry Baryshkov wrote: Now as all accesses to pipe_cfg and pstate have been cleaned, add struct dpu_hw_sspp_cfg to struct dpu_plane_state, so that dpu_plane_atomic_check() and dpu_plane_atomic_update() do not have a chance to disagree about src/dst rectangles (currently

Re: [PATCH v5 16/32] drm/msm/dpu: move the rest of plane checks to dpu_plane_atomic_check()

2023-03-13 Thread Abhinav Kumar
On 3/9/2023 4:56 PM, Dmitry Baryshkov wrote: Move plane state updates from dpu_crtc_atomic_check() to the function where they belong: to dpu_plane_atomic_check(). Signed-off-by: Dmitry Baryshkov Can you please elaborate a bit on this comment?

Re: [PATCH v5 13/32] drm/msm/dpu: rename dpu_hw_sspp_cfg to dpu_sw_pipe_cfg

2023-03-13 Thread Abhinav Kumar
On 3/9/2023 4:56 PM, Dmitry Baryshkov wrote: As struct dpu_hw_sspp_cfg describes only the source and destination rectangles, it is a software pipe configuration now. Rename it accordingly. Signed-off-by: Dmitry Baryshkov Reviewed-by: Abhinav Kumar

linux-next: build warnings after merge of the drm-misc tree

2023-03-13 Thread Stephen Rothwell
Hi all, After merging the drm-misc tree, today's linux-next build (htmldocs) produced these warnings: drivers/gpu/drm/scheduler/sched_main.c:738: warning: Excess function parameter 'file_private' description in 'drm_sched_job_add_syncobj_dependency' drivers/gpu/drm/scheduler/sched_main.c:738:

Re: [PATCH v2] drm/i915/guc: Disable PL1 power limit when loading GuC firmware

2023-03-13 Thread kernel test robot
config: x86_64-randconfig-a016-20230313 (https://download.01.org/0day-ci/archive/20230314/202303141032.gnwwcyad-...@intel.com/config) compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project f28c006a5895fc0e329fe15fead81e37457cb1d1) reproduce (this is a W=1 build): wget https

[PATCH v13 08/10] drm/shmem-helper: Export drm_gem_shmem_get_pages_sgt_locked()

2023-03-13 Thread Dmitry Osipenko
Export drm_gem_shmem_get_pages_sgt_locked() that will be used by virtio-gpu shrinker during GEM swap-in operation done under the held reservation lock. Signed-off-by: Dmitry Osipenko --- drivers/gpu/drm/drm_gem_shmem_helper.c | 3 ++- include/drm/drm_gem_shmem_helper.h | 1 + 2 files

[PATCH v13 10/10] drm/panfrost: Switch to generic memory shrinker

2023-03-13 Thread Dmitry Osipenko
Replace Panfrost's custom memory shrinker with a common drm-shmem memory shrinker. Tested-by: Steven Price # Firefly-RK3288 Reviewed-by: Steven Price Signed-off-by: Dmitry Osipenko --- drivers/gpu/drm/panfrost/Makefile | 1 - drivers/gpu/drm/panfrost/panfrost_device.h| 4 -

[PATCH v13 09/10] drm/virtio: Support memory shrinking

2023-03-13 Thread Dmitry Osipenko
Support generic drm-shmem memory shrinker and add new madvise IOCTL to the VirtIO-GPU driver. BO cache manager of Mesa driver will mark BOs as "don't need" using the new IOCTL to let shrinker purge the marked BOs on OOM, the shrinker will also evict unpurgeable shmem BOs from memory if guest

[PATCH v13 06/10] drm/shmem-helper: Add memory shrinker

2023-03-13 Thread Dmitry Osipenko
Introduce common drm-shmem shrinker for DRM drivers. To start using drm-shmem shrinker drivers should do the following: 1. Implement evict() callback of GEM object where driver should check whether object is purgeable or evictable using drm-shmem helpers and perform the shrinking action

[PATCH v13 07/10] drm/shmem-helper: Remove obsoleted is_iomem test

2023-03-13 Thread Dmitry Osipenko
Everything that uses the mapped buffer should by agnostic to is_iomem. The only reason for the is_iomem test is is that we're setting shmem->vaddr to the returned map->vaddr. Now that the shmem->vaddr code is gone, remove the obsoleted is_iomem test to clean up the code. Suggested-by: Thomas

[PATCH v13 05/10] drm/shmem-helper: Factor out unpinning part from drm_gem_shmem_purge()

2023-03-13 Thread Dmitry Osipenko
Factor out pages unpinning code from drm_gem_shmem_purge() into new drm_gem_shmem_unpin_pages(). This prepares code for addition of memory shrinker support. The new common function will be used by shrinker for eviction of shmem pages. Signed-off-by: Dmitry Osipenko ---

[PATCH v13 03/10] drm/shmem-helper: Add pages_pin_count field

2023-03-13 Thread Dmitry Osipenko
And new pages_pin_count field to struct drm_gem_shmem_object that will determine whether pages are evictable by memory shrinker. The pages will be evictable only when pages_pin_count=0. This patch prepares code for addition of the memory shrinker that will utilize the new field. Signed-off-by:

[PATCH v13 04/10] drm/shmem-helper: Switch drm_gem_shmem_vmap/vunmap to use pin/unpin

2023-03-13 Thread Dmitry Osipenko
The vmapped pages shall be pinned in memory. Previously get/put pages were implicitly pinning/unpinning the pages. This will no longer be the case with addition of memory shrinker because pages_use_count>0 won't determine whether pages are pinned anymore, while the new pages_pin_count will do

[PATCH v13 01/10] drm/shmem-helper: Switch to reservation lock

2023-03-13 Thread Dmitry Osipenko
Replace all drm-shmem locks with a GEM reservation lock. This makes locks consistent with dma-buf locking convention where importers are responsible for holding reservation lock for all operations performed over dma-bufs, preventing deadlock between dma-buf importers and exporters. Suggested-by:

[PATCH v13 02/10] drm/shmem-helper: Factor out pages alloc/release from drm_gem_shmem_get/put_pages()

2023-03-13 Thread Dmitry Osipenko
Factor out pages allocation from drm_gem_shmem_get_pages() into drm_gem_shmem_acquire_pages() function and similar for the put_pages() in a preparation for addition of shrinker support to drm-shmem. Once shrinker will be added, the pages_use_count>0 will no longer determine whether pages are

[PATCH v13 00/10] Add generic memory shrinker to VirtIO-GPU and Panfrost DRM drivers

2023-03-13 Thread Dmitry Osipenko
This series: 1. Adds common drm-shmem memory shrinker 2. Enables shrinker for VirtIO-GPU driver 3. Switches Panfrost driver to the common shrinker Changelog: v13:- Updated virtio-gpu shrinker patch to use drm_gem_shmem_object_pin() directly instead of drm_gem_pin() and dropped patch

Re: [PATCH RFC 03/18] rust: drm: file: Add File abstraction

2023-03-13 Thread Boqun Feng
On Mon, Mar 13, 2023 at 12:49:57PM -0500, Faith Ekstrand wrote: > On Fri, 2023-03-10 at 07:16 +0900, Asahi Lina wrote: > > On 10/03/2023 06.16, Faith Ekstrand wrote: > > > On Tue, 2023-03-07 at 23:25 +0900, Asahi Lina wrote: > > > > A DRM File is the DRM counterpart to a kernel file structure, > >

Re: [PATCH v15 00/16] drm: Add Samsung MIPI DSIM bridge

2023-03-13 Thread Inki Dae
Hi Fabio Estevam, 2023년 3월 14일 (화) 오전 9:31, Fabio Estevam 님이 작성: > Hi Inki, > > On Mon, Mar 6, 2023 at 2:24 AM 대인기/Tizen Platform Lab(SR)/삼성전자 > wrote: > > > Seems some issue Marek found on testing. If fixed then I will try to > pick this > > patch series up. > > Marek has successfully tested

Re: [PATCH v15 00/16] drm: Add Samsung MIPI DSIM bridge

2023-03-13 Thread Fabio Estevam
Hi Inki, On Mon, Mar 6, 2023 at 2:24 AM 대인기/Tizen Platform Lab(SR)/삼성전자 wrote: > Seems some issue Marek found on testing. If fixed then I will try to pick this > patch series up. Marek has successfully tested v16. Could you please apply v16? Thanks

Re: [PATCH v3 10/10] arm64: dts: qcom: sm6115: Use the correct DSI compatible

2023-03-13 Thread Marijn Suijten
On 2023-03-07 14:01:48, Konrad Dybcio wrote: > Use the non-deprecated, SoC-specific DSI compatible. > > Reviewed-by: Dmitry Baryshkov > Signed-off-by: Konrad Dybcio Reviewed-by: Marijn Suijten > --- > arch/arm64/boot/dts/qcom/sm6115.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1

linux-next: manual merge of the drm-misc tree with Linus' tree

2023-03-13 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the drm-misc tree got a conflict in: drivers/gpu/drm/tiny/cirrus.c between commit: 7245e629dcaa ("drm/cirrus: NULL-check pipe->plane.state->fb in cirrus_pipe_update()") from Linus' tree and commits: d99c028941b3 ("drm/cirrus: Convert to regular

Re: [PATCH v3 09/10] dt-bindings: display/msm: dsi-controller-main: Add SM6115

2023-03-13 Thread Marijn Suijten
On 2023-03-08 12:51:03, Rob Herring wrote: > > On Tue, 07 Mar 2023 14:01:47 +0100, Konrad Dybcio wrote: > > Add a compatible for the DSI on SM6115. > > > > Signed-off-by: Konrad Dybcio > > --- > > .../devicetree/bindings/display/msm/dsi-controller-main.yaml | 2 ++ > >

Re: [PATCH v3 08/10] dt-bindings: display/msm: dsi-controller-main: Fix deprecated compatible

2023-03-13 Thread Marijn Suijten
On 2023-03-07 14:01:46, Konrad Dybcio wrote: > The point of the previous cleanup was to disallow "qcom,mdss-dsi-ctrl" > alone. This however didn't quite work out and the property became > undocumented instead of deprecated. Fix that. > > Fixes: 0c0f65c6dd44 ("dt-bindings: msm:

Re: [PATCH v3 07/10] drm/msm/dsi: Remove custom DSI config handling

2023-03-13 Thread Marijn Suijten
On 2023-03-07 14:01:45, Konrad Dybcio wrote: > Now that the only user is handled by common code, remove the option to > specify custom handlers through match data. > > This is effectively a revert of commit: > 5ae15e76271 ("drm/msm/dsi: Allow to specify dsi config as pdata") Would it also be

Re: [PATCH v3 06/10] drm/msm/dsi: Switch the QCM2290-specific compatible to index autodetection

2023-03-13 Thread Marijn Suijten
On 2023-03-07 14:01:44, Konrad Dybcio wrote: > Now that the logic can handle multiple sets of registers, move > the QCM2290 to the common logic and mark it deprecated. This allows us > to remove a couple of structs, saving some memory. > > Reviewed-by: Dmitry Baryshkov > Signed-off-by: Konrad

Re: [PATCH v3 05/10] drm/msm/dsi: dsi_cfg: Merge SC7180 config into SDM845

2023-03-13 Thread Marijn Suijten
On 2023-03-07 14:01:43, Konrad Dybcio wrote: > The configs are identical, other than the number of *maximum* DSI > hosts allowed. This isn't an issue, unless somebody deliberately > tries to access the inexistent host by adding a dt node for it. > > Remove the SC7180 struct and point the hw

Re: [PATCH v3 04/10] drm/msm/dsi: dsi_cfg: Deduplicate identical structs

2023-03-13 Thread Marijn Suijten
On 2023-03-07 14:01:42, Konrad Dybcio wrote: > Some structs were defined multiple times for no apparent reason. > Deduplicate them. > > Reviewed-by: Dmitry Baryshkov > Signed-off-by: Konrad Dybcio Seems a bit inconsistent to name some of these with their DSI host revision, and keep some named

Re: [Intel-gfx] [PATCH 2/2] drm/i915/guc: Allow for very slow GuC loading

2023-03-13 Thread Dixit, Ashutosh
On Fri, 10 Mar 2023 17:01:42 -0800, John Harrison wrote: > > >> + for (count = 0; count < 20; count++) { > >> + ret = wait_for(guc_load_done(uncore, , ), 1000); > > > > Isn't 20 secs a bit too long for an in-place wait? I get that if the GuC > > doesn't load (or fail to) within a few

Re: [PATCH v3 03/10] drm/msm/dsi: Fix DSI index detection when version clash occurs

2023-03-13 Thread Marijn Suijten
On 2023-03-07 14:01:41, Konrad Dybcio wrote: > Currently, we allow for MAX_DSI entries in io_start to facilitate for > MAX_DSI number of DSI hosts at different addresses. The configuration > is matched against the DSI CTRL hardware revision read back from the > component. We need a way to resolve

[PATCH v2] drm/i915/guc: Disable PL1 power limit when loading GuC firmware

2023-03-13 Thread Ashutosh Dixit
On dGfx, the PL1 power limit being enabled and set to a low value results in a low GPU operating freq. It also negates the freq raise operation which is done before GuC firmware load. As a result GuC firmware load can time out. Such timeouts were seen in the GL #8062 bug below (where the PL1 power

Re: [PATCH drm-next v2 05/16] drm: manager to keep track of GPUs VA mappings

2023-03-13 Thread Danilo Krummrich
On 3/7/23 23:43, Liam R. Howlett wrote: * Danilo Krummrich [230306 10:46]: On 3/2/23 03:38, Liam R. Howlett wrote: * Danilo Krummrich [230227 08:17]: ... Would this variant be significantly more efficient? Well, what you are doing is walking the tree to see if there's anything there...

Re: [PATCH v3 02/10] drm/msm/dsi: Get rid of msm_dsi_config::num_dsi

2023-03-13 Thread Marijn Suijten
On 2023-03-07 14:01:40, Konrad Dybcio wrote: > In preparation for supporting multiple sets of possible base registers, > remove the num_dsi variable. We're comparing the io_start array contents > with the reg value from the DTS, so it will either match one of the > expected values or don't match

Re: [PATCH v3 01/10] dt-bindings: display/msm: dsi-controller-main: Fix deprecated QCM2290 compatible

2023-03-13 Thread Marijn Suijten
On 2023-03-07 14:01:39, Konrad Dybcio wrote: > The qcom, prefix was missed previously. Fix it. > > Fixes: 0c0f65c6dd44 ("dt-bindings: msm: dsi-controller-main: Add compatible > strings for every current SoC") > Acked-by: Rob Herring > Signed-off-by: Konrad Dybcio Turns out I got booted from

Re: [PATCH v2 1/9] dt-bindings: display/msm: dsi-controller-main: Fix deprecated QCM2290 compatible

2023-03-13 Thread Marijn Suijten
On 2023-02-13 13:10:04, Konrad Dybcio wrote: > The qcom, prefix was missed previously. Fix it. > > Fixes: 0c0f65c6dd44 ("dt-bindings: msm: dsi-controller-main: Add compatible > strings for every current SoC") > Signed-off-by: Konrad Dybcio Reviewed-by: Marijn Suijten > --- >

[PATCH v2 2/2] drm/xe: Use GT oriented log messages in xe_gt.c

2023-03-13 Thread Michal Wajdeczko
Replace generic log messages with ones dedicated for the GT. Signed-off-by: Michal Wajdeczko --- drivers/gpu/drm/xe/xe_gt.c | 29 - 1 file changed, 12 insertions(+), 17 deletions(-) diff --git a/drivers/gpu/drm/xe/xe_gt.c b/drivers/gpu/drm/xe/xe_gt.c index

[PATCH v2 1/2] drm/xe: Introduce GT oriented log messages

2023-03-13 Thread Michal Wajdeczko
While debugging GT related problems, it's good to know which GT was reporting problems. Introduce helper macros to allow prefix GT logs with GT idetifier. We will use them in upcoming patches. v2: use xe_ prefix (Lucas) Signed-off-by: Michal Wajdeczko Cc: Lucas De Marchi Cc: Jani Nikula ---

Re: [PATCH v2 25/25] drm/pl111: Use GEM DMA fbdev emulation

2023-03-13 Thread Linus Walleij
On Mon, Mar 13, 2023 at 4:51 PM Thomas Zimmermann wrote: > Use the fbdev emulation that is optimized for DMA helpers. Avoids > possible shadow buffering and makes the code simpler. > > Reported-by: Linus Walleij > Link: >

Re: [PATCH v2 24/25] drm/mcde: Use GEM DMA fbdev emulation

2023-03-13 Thread Linus Walleij
On Mon, Mar 13, 2023 at 4:51 PM Thomas Zimmermann wrote: > Use the fbdev emulation that is optimized for DMA helpers. Avoids > possible shadow buffering and makes the code simpler. > > Reported-by: Linus Walleij > Link: >

Re: [PATCH v2 00/25] drm/dma-helper: Add dedicated fbdev emulation

2023-03-13 Thread Linus Walleij
On Mon, Mar 13, 2023 at 4:51 PM Thomas Zimmermann wrote: > Tested with fbcon and IGT on vc4. Also tested on the U8500 MCDE on Samsung GT-I8190 (Golden) successfully. Yours, Linus Walleij

[PATCH] drm/i915/huc: Cancel HuC delayed load timer on reset.

2023-03-13 Thread Daniele Ceraolo Spurio
In the rare case where we do a full GT reset after starting the HuC load and before it completes (which basically boils down to i915 hanging during init), we need to cancel the delayed load fence, as it will be re-initialized in the post-reset recovery. Fixes: 27536e03271d ("drm/i915/huc: track

Re: [PATCH RFC 11/18] drm/scheduler: Clean up jobs when the scheduler is torn down

2023-03-13 Thread Faith Ekstrand
On Fri, 2023-03-10 at 18:58 +0900, Asahi Lina wrote: > On 10/03/2023 04.59, Faith Ekstrand wrote: > > On Thu, 2023-03-09 at 18:43 +0900, Asahi Lina wrote: > > > On 09/03/2023 17.42, Christian König wrote: > > > > Long story short: Don't do this! This is what the Windows > > > > drivers > > > >

Re: [Intel-xe] [PATCH 1/2] drm/xe: Introduce GT oriented log messages

2023-03-13 Thread Jani Nikula
On Mon, 13 Mar 2023, Lucas De Marchi wrote: > +dri-devel > > On Mon, Mar 13, 2023 at 09:03:56AM +0100, Michal Wajdeczko wrote: >>While debugging GT related problems, it's good to know which GT was >>reporting problems. Introduce helper macros to allow prefix GT logs >>with GT idetifier. We will

Re: [Linaro-mm-sig] Re: [PATCH 2/2] drm/msm: Embed the hw_fence in msm_gem_submit

2023-03-13 Thread Christian König
Am 13.03.23 um 17:43 schrieb Rob Clark: On Mon, Mar 13, 2023 at 9:15 AM Christian König wrote: Am 13.03.23 um 15:45 schrieb Rob Clark: On Mon, Mar 13, 2023 at 12:19 AM Christian König wrote: Am 11.03.23 um 18:35 schrieb Rob Clark: From: Rob Clark Avoid allocating memory in job_run() by

Re: [PATCH v5 2/2] drm/panel: Add driver for Novatek NT36523

2023-03-13 Thread Sam Ravnborg
On Mon, Mar 13, 2023 at 09:06:50AM +0100, Neil Armstrong wrote: > On 11/03/2023 13:46, Jianhua Lu wrote: > > On Sat, Mar 11, 2023 at 01:38:52PM +0100, Konrad Dybcio wrote: > > > > > > > > > On 11.03.2023 13:32, Jianhua Lu wrote: > > > > Add a driver for panels using the Novatek NT36523 display

[PATCH 30/36] drm/i915/huc: use const struct bus_type pointers

2023-03-13 Thread Greg Kroah-Hartman
The struct bus_type pointers in the functions intel_huc_register_gsc_notifier() and intel_huc_unregister_gsc_notifier() should be a const pointer, as the structure is not modified anywhere in the functions, and the pointer they are passed will be a const * in the near future. Cc: Jani Nikula Cc:

Re: [PATCH RFC 03/18] rust: drm: file: Add File abstraction

2023-03-13 Thread Faith Ekstrand
On Fri, 2023-03-10 at 07:16 +0900, Asahi Lina wrote: > On 10/03/2023 06.16, Faith Ekstrand wrote: > > On Tue, 2023-03-07 at 23:25 +0900, Asahi Lina wrote: > > > A DRM File is the DRM counterpart to a kernel file structure, > > > representing an open DRM file descriptor. Add a Rust abstraction > >

Re: [PATCH v3 3/8] accel/qaic: Add MHI controller

2023-03-13 Thread Jeffrey Hugo
On 3/13/2023 7:39 AM, Jacek Lawrynowicz wrote: Hi, On 06.03.2023 22:33, Jeffrey Hugo wrote: An AIC100 device contains a MHI interface with a number of different channels for controlling different aspects of the device. The MHI controller works with the MHI bus to enable and drive that

Re: [PATCH v3 2/8] accel/qaic: Add uapi and core driver file

2023-03-13 Thread Jeffrey Hugo
On 3/13/2023 7:21 AM, Jacek Lawrynowicz wrote: Hi, On 06.03.2023 22:33, Jeffrey Hugo wrote: Add the QAIC driver uapi file and core driver file that binds to the PCIe device. The core driver file also creates the accel device and manages all the interconnections between the different parts of

Re: [PATCH] drm/virtio: Enable fb damage clips property for the primary plane

2023-03-13 Thread Javier Martinez Canillas
Javier Martinez Canillas writes: > Christian Hergert reports that the driver doesn't enable the property and > that leads to always doing a full plane update, even when the driver does > support damage clipping for the primary plane. > > Don't enable it for the cursor plane, because its

[PATCH 2/3] drm/i915/active: Serialize use of barriers as fence trackers

2023-03-13 Thread Janusz Krzysztofik
When adding a request to a composite tracker, we try to use an existing fence tracker already registered with that composite. The tracker we obtain can already track another fence, can be an idle barrier, or an active barrier. When we acquire an idle barrier, we don't claim it in any way until

[PATCH 3/3] drm/i915/active: Simplify llist search-and-delete

2023-03-13 Thread Janusz Krzysztofik
Inside active_del_barrier(), while searching for a node to be deleted, we now rebuild barrier_tasks llist content in reverse order. Theoretically neutral, that method was observed to provide an undocumented workaround for unexpected loops of llist nodes appearing now and again due to races,

[PATCH 1/3] drm/i915/active: Serialize preallocation of idle barriers

2023-03-13 Thread Janusz Krzysztofik
When we collect barriers for preallocating them, we reuse either idle or non-idle ones, whichever we find. In case of non-idle barriers, we depend on their successful deletion from their barrier tasks lists as an indication of them not being claimed by another thread. However, in case of idle

[PATCH 0/3] drm/i915/active: Fix other potential list corruption root causes

2023-03-13 Thread Janusz Krzysztofik
While perfroming root cause analyses of fence callback list corruptions, a couple of other potential though less likely root causes have been identified in addition to barrier tasks list deletion results ignored. This series tries to fix those potential issues, also in longterm stable releases

Re: [PATCH] backlight: apple_bl: Use acpi_video_get_backlight_type()

2023-03-13 Thread Lee Jones
On Thu, 09 Mar 2023, Daniel Thompson wrote: > On Tue, Mar 07, 2023 at 01:05:40PM +0100, Hans de Goede wrote: > > On some MacBooks both the apple_bl and the apple-gmux backlight drivers > > may be able to export a /sys/class/backlight device. > > > > To avoid having 2 backlight devices for one LCD

Re: [Freedreno] [PATCH v3 4/7] drm/msm/a2xx: Implement .gpu_busy

2023-03-13 Thread Konrad Dybcio
On 24.02.2023 16:04, Jonathan Marek wrote: > This won't work because a2xx freedreno userspace expects to own all the > perfcounters. > > This will break perfcounters for userspace, and when userspace isn't using > perfcounters, this won't count correctly because userspace writes 0 to >

Re: [Intel-xe] [PATCH 1/2] drm/xe: Introduce GT oriented log messages

2023-03-13 Thread Lucas De Marchi
+dri-devel On Mon, Mar 13, 2023 at 09:03:56AM +0100, Michal Wajdeczko wrote: While debugging GT related problems, it's good to know which GT was reporting problems. Introduce helper macros to allow prefix GT logs with GT idetifier. We will use them in upcoming patches. Signed-off-by: Michal

Re: [PATCH 2/2] drm/msm: Embed the hw_fence in msm_gem_submit

2023-03-13 Thread Rob Clark
On Mon, Mar 13, 2023 at 9:15 AM Christian König wrote: > > Am 13.03.23 um 15:45 schrieb Rob Clark: > > On Mon, Mar 13, 2023 at 12:19 AM Christian König > > wrote: > >> Am 11.03.23 um 18:35 schrieb Rob Clark: > >>> From: Rob Clark > >>> > >>> Avoid allocating memory in job_run() by embedding the

[PATCH v3 1/2] drm: Introduce plane SIZE_HINTS property

2023-03-13 Thread Ville Syrjala
From: Ville Syrjälä Add a new immutable plane property by which a plane can advertise a handful of recommended plane sizes. This would be mostly exposed by cursor planes as a slightly more capable replacement for the DRM_CAP_CURSOR_WIDTH/HEIGHT caps, which can only declare a one size fits all

Re: [PATCH 2/2] drm/msm: Embed the hw_fence in msm_gem_submit

2023-03-13 Thread Christian König
Am 13.03.23 um 15:45 schrieb Rob Clark: On Mon, Mar 13, 2023 at 12:19 AM Christian König wrote: Am 11.03.23 um 18:35 schrieb Rob Clark: From: Rob Clark Avoid allocating memory in job_run() by embedding the fence in the submit object. Since msm gpu fences are always 1:1 with msm_gem_submit

[PATCH v2 18/25] drm/tilcdc: Use GEM DMA fbdev emulation

2023-03-13 Thread Thomas Zimmermann
Use the fbdev emulation that is optimized for DMA helpers. Avoids possible shadow buffering and makes the code simpler. Signed-off-by: Thomas Zimmermann Reviewed-by: Javier Martinez Canillas --- drivers/gpu/drm/tilcdc/tilcdc_drv.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff

[PATCH v2 24/25] drm/mcde: Use GEM DMA fbdev emulation

2023-03-13 Thread Thomas Zimmermann
Use the fbdev emulation that is optimized for DMA helpers. Avoids possible shadow buffering and makes the code simpler. Reported-by: Linus Walleij Link: https://lore.kernel.org/dri-devel/cacrpkdawsqsnqkjkssosw3hmmhynxfuywxkdszptc-a_uza...@mail.gmail.com/ Signed-off-by: Thomas Zimmermann ---

[PATCH v2 25/25] drm/pl111: Use GEM DMA fbdev emulation

2023-03-13 Thread Thomas Zimmermann
Use the fbdev emulation that is optimized for DMA helpers. Avoids possible shadow buffering and makes the code simpler. Reported-by: Linus Walleij Link: https://lore.kernel.org/dri-devel/cacrpkdawsqsnqkjkssosw3hmmhynxfuywxkdszptc-a_uza...@mail.gmail.com/ Signed-off-by: Thomas Zimmermann ---

[PATCH v2 07/25] drm/imx/dcss: Use GEM DMA fbdev emulation

2023-03-13 Thread Thomas Zimmermann
Use the fbdev emulation that is optimized for DMA helpers. Avoids possible shadow buffering and makes the code simpler. Signed-off-by: Thomas Zimmermann Reviewed-by: Javier Martinez Canillas --- drivers/gpu/drm/imx/dcss/dcss-kms.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff

[PATCH v2 05/25] drm/atmel-hlcdc: Use GEM DMA fbdev emulation

2023-03-13 Thread Thomas Zimmermann
Use the fbdev emulation that is optimized for DMA helpers. Avoids possible shadow buffering and makes the code simpler. Signed-off-by: Thomas Zimmermann Reviewed-by: Javier Martinez Canillas Acked-by: Sam Ravnborg --- drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c | 4 ++-- 1 file changed, 2

[PATCH v2 02/25] arm/hdlcd: Use GEM DMA fbdev emulation

2023-03-13 Thread Thomas Zimmermann
Use the fbdev emulation that is optimized for DMA helpers. Avoids possible shadow buffering and makes the code simpler. Signed-off-by: Thomas Zimmermann Reviewed-by: Javier Martinez Canillas --- drivers/gpu/drm/arm/hdlcd_drv.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff

[PATCH v2 04/25] drm/aspeed: Use GEM DMA fbdev emulation

2023-03-13 Thread Thomas Zimmermann
Use the fbdev emulation that is optimized for DMA helpers. Avoids possible shadow buffering and makes the code simpler. Signed-off-by: Thomas Zimmermann Reviewed-by: Javier Martinez Canillas --- drivers/gpu/drm/aspeed/aspeed_gfx_drv.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

[PATCH v2 21/25] drm/vc4: Use GEM DMA fbdev emulation

2023-03-13 Thread Thomas Zimmermann
Use the fbdev emulation that is optimized for DMA helpers. Avoids possible shadow buffering and makes the code simpler. Signed-off-by: Thomas Zimmermann Reviewed-by: Javier Martinez Canillas --- drivers/gpu/drm/vc4/vc4_drv.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH v2 23/25] drm/mcde: Do not use dirty GEM FB handling

2023-03-13 Thread Thomas Zimmermann
From: Linus Walleij This driver has no way to handle damage, the reason the drm_gem_fb_create_with_dirty() was used was because I had the ambition that the driver would only send out updates to DSI command displays whenever something changed, so as to minimize traffic. It turns out this

[PATCH v2 22/25] drm/xlnx: Use GEM DMA fbdev emulation

2023-03-13 Thread Thomas Zimmermann
Use the fbdev emulation that is optimized for DMA helpers. Avoids possible shadow buffering and makes the code simpler. Signed-off-by: Thomas Zimmermann Reviewed-by: Javier Martinez Canillas --- drivers/gpu/drm/xlnx/zynqmp_kms.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff

[PATCH v2 12/25] drm/mxsfb/lcdif: Use GEM DMA fbdev emulation

2023-03-13 Thread Thomas Zimmermann
Use the fbdev emulation that is optimized for DMA helpers. Avoids possible shadow buffering and makes the code simpler. Signed-off-by: Thomas Zimmermann Reviewed-by: Javier Martinez Canillas --- drivers/gpu/drm/mxsfb/lcdif_drv.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff

[PATCH v2 11/25] drm/meson: Use GEM DMA fbdev emulation

2023-03-13 Thread Thomas Zimmermann
Use the fbdev emulation that is optimized for DMA helpers. Avoids possible shadow buffering and makes the code simpler. Signed-off-by: Thomas Zimmermann Reviewed-by: Javier Martinez Canillas Acked-by: Martin Blumenstingl --- drivers/gpu/drm/meson/meson_drv.c | 4 ++-- 1 file changed, 2

[PATCH v2 20/25] drm/tve200: Use GEM DMA fbdev emulation

2023-03-13 Thread Thomas Zimmermann
Use the fbdev emulation that is optimized for DMA helpers. Avoids possible shadow buffering and makes the code simpler. Signed-off-by: Thomas Zimmermann Reviewed-by: Javier Martinez Canillas Acked-by: Linus Walleij --- drivers/gpu/drm/tve200/tve200_drv.c | 4 ++-- 1 file changed, 2

[PATCH v2 06/25] drm/fsl-dcu: Use GEM DMA fbdev emulation

2023-03-13 Thread Thomas Zimmermann
Use the fbdev emulation that is optimized for DMA helpers. Avoids possible shadow buffering and makes the code simpler. Signed-off-by: Thomas Zimmermann Reviewed-by: Javier Martinez Canillas --- drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

[PATCH v2 19/25] drm/arcpgu: Use GEM DMA fbdev emulation

2023-03-13 Thread Thomas Zimmermann
Use the fbdev emulation that is optimized for DMA helpers. Avoids possible shadow buffering and makes the code simpler. Signed-off-by: Thomas Zimmermann Reviewed-by: Javier Martinez Canillas --- drivers/gpu/drm/tiny/arcpgu.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH v2 14/25] drm/sti: Use GEM DMA fbdev emulation

2023-03-13 Thread Thomas Zimmermann
Use the fbdev emulation that is optimized for DMA helpers. Avoids possible shadow buffering and makes the code simpler. Signed-off-by: Thomas Zimmermann Reviewed-by: Javier Martinez Canillas --- drivers/gpu/drm/sti/sti_drv.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH v2 08/25] drm/imx: Use GEM DMA fbdev emulation

2023-03-13 Thread Thomas Zimmermann
Use the fbdev emulation that is optimized for DMA helpers. Avoids possible shadow buffering and makes the code simpler. Signed-off-by: Thomas Zimmermann Reviewed-by: Javier Martinez Canillas --- drivers/gpu/drm/imx/ipuv3/imx-drm-core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

[PATCH v2 17/25] drm/tidss: Use GEM DMA fbdev emulation

2023-03-13 Thread Thomas Zimmermann
Use the fbdev emulation that is optimized for DMA helpers. Avoids possible shadow buffering and makes the code simpler. Signed-off-by: Thomas Zimmermann Reviewed-by: Javier Martinez Canillas --- drivers/gpu/drm/tidss/tidss_drv.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff

[PATCH v2 13/25] drm/mxsfb: Use GEM DMA fbdev emulation

2023-03-13 Thread Thomas Zimmermann
Use the fbdev emulation that is optimized for DMA helpers. Avoids possible shadow buffering and makes the code simpler. Signed-off-by: Thomas Zimmermann Reviewed-by: Javier Martinez Canillas --- drivers/gpu/drm/mxsfb/mxsfb_drv.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff

[PATCH v2 16/25] drm/sun4i: Use GEM DMA fbdev emulation

2023-03-13 Thread Thomas Zimmermann
Use the fbdev emulation that is optimized for DMA helpers. Avoids possible shadow buffering and makes the code simpler. Signed-off-by: Thomas Zimmermann Reviewed-by: Javier Martinez Canillas --- drivers/gpu/drm/sun4i/sun4i_drv.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff

[PATCH v2 15/25] drm/stm: Use GEM DMA fbdev emulation

2023-03-13 Thread Thomas Zimmermann
Use the fbdev emulation that is optimized for DMA helpers. Avoids possible shadow buffering and makes the code simpler. Signed-off-by: Thomas Zimmermann Reviewed-by: Javier Martinez Canillas --- drivers/gpu/drm/stm/drv.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

  1   2   >