[PATCH] drm/mediatek: dp: Remove redundant dev_err_probe() for platform_get_irq()

2023-08-31 Thread Jinjie Ruan
Since commit 7723f4c5ecdb ("driver core: platform: Add an error message to platform_get_irq*()") and commit 2043727c2882 ("driver core: platform: Make use of the helper function dev_err_probe()"), there is no need to call the dev_err_probe() function directly to print a custom message when handling

Re: [PATCH v2 5/6] drm/panfrost: Implement generic DRM object RSS reporting function

2023-08-31 Thread Boris Brezillon
On Fri, 1 Sep 2023 01:03:23 +0100 Adrián Larumbe wrote: > >> @@ -274,13 +286,23 @@ panfrost_gem_prime_import_sg_table(struct drm_device > >> *dev, > >> { > >>struct drm_gem_object *obj; > >>struct panfrost_gem_object *bo; > >> + struct scatterlist *sgl; > >> + unsigned int count; > >>

[PATCH 0/2] Add support for inlined documentation for kunit and kselftests

2023-08-31 Thread Mauro Carvalho Chehab
This is a follow-up of the discussions taken here: https://lore.kernel.org/linux-doc/20230704132812.02ba97ba@maurocar-mobl2/T/#t I sent a previous version as RFC. This is basically what we had there, with some improvements at test_list.py. It adds a new extension that allows documenting tests

Re: [RFC PATCH] drm/ssd130x: Allocate buffer in the CRTC's .atomic_check() callback

2023-08-31 Thread Thomas Zimmermann
Hi Javier, another idea about this patch: why not just keep the allocation in the plane's atomic check, but store the temporary buffers in a plane struct. You'd only grow the arrays length in atomic_check and later fetch the pointers in atomic_update. It needs some locking, but nothing complic

Re: [PATCH AUTOSEL 5.10 13/22] drm/amdgpu: install stub fence into potential unused fence pointers

2023-08-31 Thread Christian König
Am 31.08.23 um 20:55 schrieb Chia-I Wu: On Thu, Aug 31, 2023 at 7:01 AM Greg KH wrote: On Thu, Aug 31, 2023 at 03:26:28PM +0200, Christian König wrote: Am 31.08.23 um 12:56 schrieb Greg KH: On Thu, Aug 31, 2023 at 12:27:27PM +0200, Christian König wrote: Am 30.08.23 um 20:53 schrieb Chia-I W

Re: [PATCH drm-misc-next 2/3] drm/gpuva_mgr: generalize dma_resv/extobj handling and GEM validation

2023-08-31 Thread Intel
On 8/31/23 21:07, Danilo Krummrich wrote: On Thu, Aug 31, 2023 at 06:53:01PM +0200, Thomas Hellström (Intel) wrote: Hi, On 8/31/23 13:18, Danilo Krummrich wrote: On Thu, Aug 31, 2023 at 11:04:06AM +0200, Thomas Hellström (Intel) wrote: Hi! On 8/30/23 17:00, Danilo Krummrich wrote: On Wed,

Re: [PATCH 2/3] drm/ttm/tests: Add tests for ttm_tt

2023-08-31 Thread kernel test robot
Hi Karolina, kernel test robot noticed the following build errors: [auto build test ERROR on drm-misc/drm-misc-next] [also build test ERROR on drm/drm-next drm-exynos/exynos-drm-next drm-intel/for-linux-next drm-tip/drm-tip linus/master next-20230831] [cannot apply to drm-intel/for-linux-next

Re: Framebuffer mmap on PowerPC

2023-08-31 Thread Arnd Bergmann
On Thu, Aug 31, 2023, at 10:41, Thomas Zimmermann wrote: > Hi, > > there's a per-architecture function called fb_pgprotect() that sets > VMA's vm_page_prot for mmaped framebuffers. Most architectures use a > simple implementation based on pgprot_writecomine() [1] or > pgprot_noncached(). [2] > >

[PATCH -next 4/5] drm/amd/display: clean up some inconsistent indentings

2023-08-31 Thread Yang Li
drivers/gpu/drm/amd/amdgpu/../display/dc/clk_mgr/dcn35/dcn35_clk_mgr.c:288 dcn35_update_clocks() warn: inconsistent indenting Signed-off-by: Yang Li --- .../display/dc/clk_mgr/dcn35/dcn35_clk_mgr.c | 28 +-- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/driver

[PATCH -next 5/5] drm/amd/display: clean up one inconsistent indenting

2023-08-31 Thread Yang Li
drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn35/dcn35_fpu.c:260 dcn35_update_bw_bounding_box_fpu() warn: inconsistent indenting Signed-off-by: Yang Li --- drivers/gpu/drm/amd/display/dc/dml/dcn35/dcn35_fpu.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/

[PATCH -next 3/5] drm/amd/display: clean up some inconsistent indentings

2023-08-31 Thread Yang Li
drivers/gpu/drm/amd/amdgpu/../display/dc/dcn35/dcn35_hwseq.c:159 dcn35_init_hw() warn: inconsistent indentig Signed-off-by: Yang Li --- .../drm/amd/display/dc/dcn35/dcn35_hwseq.c| 32 +-- 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/drivers/gpu/drm/amd/dis

[PATCH -next 2/5] drm/amd/display: clean up one inconsistent indenting

2023-08-31 Thread Yang Li
drivers/gpu/drm/amd/amdgpu/../display/dc/dcn35/dcn35_resource.c:1877 dcn35_resource_construct() warn: inconsistent indenting Signed-off-by: Yang Li --- drivers/gpu/drm/amd/display/dc/dcn35/dcn35_resource.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/d

[PATCH -next 1/5] drm/amd/display: clean up one inconsistent indenting

2023-08-31 Thread Yang Li
drivers/gpu/drm/amd/amdgpu/../display/dmub/src/dmub_srv.c:355 dmub_srv_hw_setup() warn: inconsistent indenting Signed-off-by: Yang Li --- drivers/gpu/drm/amd/display/dmub/src/dmub_srv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/dmub/src/dmub

[PATCH -next 3/4] drm/amd/display: Remove duplicated include in dcn35_hwseq.c

2023-08-31 Thread Yang Li
./drivers/gpu/drm/amd/display/dc/dcn35/dcn35_hwseq.c: clk_mgr.h is included more than once. Signed-off-by: Yang Li --- drivers/gpu/drm/amd/display/dc/dcn35/dcn35_hwseq.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/dc/dcn35/dcn35_hwseq.c b/drivers/gpu/drm/amd/

[PATCH -next 4/4] drm/amd/display: Remove duplicated include in dcn35_clk_mgr.c

2023-08-31 Thread Yang Li
./drivers/gpu/drm/amd/display/dc/clk_mgr/dcn35/dcn35_clk_mgr.c: dcn35_clk_mgr.h is included more than once. Signed-off-by: Yang Li --- drivers/gpu/drm/amd/display/dc/clk_mgr/dcn35/dcn35_clk_mgr.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn35/dcn

[PATCH -next 2/4] drm/amd/display: Remove duplicated include in dcn35_optc.c

2023-08-31 Thread Yang Li
./drivers/gpu/drm/amd/display/dc/dcn35/dcn35_optc.c: dcn35_optc.h is included more than once. Signed-off-by: Yang Li --- drivers/gpu/drm/amd/display/dc/dcn35/dcn35_optc.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/dc/dcn35/dcn35_optc.c b/drivers/gpu/drm/amd/

[PATCH -next 1/4] drm/amd/display: Remove duplicated include in dcn35_resource.c

2023-08-31 Thread Yang Li
./drivers/gpu/drm/amd/display/dc/dcn35/dcn35_resource.c: dcn31/dcn31_dio_link_encoder.h is included more than once. Signed-off-by: Yang Li --- drivers/gpu/drm/amd/display/dc/dcn35/dcn35_resource.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/dc/dcn35/dcn35_reso

Re: [PATCH v7 1/1] vfio/nvgpu: Add vfio pci variant module for grace hopper

2023-08-31 Thread Jason Gunthorpe
On Thu, Aug 31, 2023 at 12:21:50PM -0600, Alex Williamson wrote: > I assume the above driver understands how to access and make use of > this coherent memory whether running bare-metal or virtualized, so > potentially we have some understanding of how it's used by the driver, > which can't be said

Re: [PATCH v2 5/6] drm/panfrost: Implement generic DRM object RSS reporting function

2023-08-31 Thread Adrián Larumbe
On 30.08.2023 12:52, Boris Brezillon wrote: >On Thu, 24 Aug 2023 02:34:48 +0100 >Adrián Larumbe wrote: > >> BO's RSS is updated every time new pages are allocated and mapped for the >> object, either in its entirety at creation time for non-heap buffers, or >> else on demand for heap buffers at GP

Re: [PATCH v2 2/6] drm/panfrost: Add fdinfo support GPU load metrics

2023-08-31 Thread Adrián Larumbe
On 30.08.2023 12:17, Boris Brezillon wrote: >On Thu, 24 Aug 2023 02:34:45 +0100 >Adrián Larumbe wrote: > >> The drm-stats fdinfo tags made available to user space are drm-engine, >> drm-cycles, drm-max-freq and drm-curfreq, one per job slot. > >Pretty sure this has already been discussed, but it's

Re: [PATCH v2 3/6] drm/panfrost: Add fdinfo support for memory stats

2023-08-31 Thread Adrián Larumbe
On 30.08.2023 12:31, Boris Brezillon wrote: >On Thu, 24 Aug 2023 02:34:46 +0100 >Adrián Larumbe wrote: > >> A new DRM GEM object function is added so that drm_show_memory_stats can >> provider more accurate memory usage numbers. > > s/provider/provide/ > >> >> Ideally, in panfrost_gem_status, th

[PATCH] MAINTAINERS: Add Jessica as a reviewer for drm/panel

2023-08-31 Thread Jessica Zhang
As I participate more actively in the drm/panel subsystem, I would like to get notified about new changes in this area. Since I have contributed and continue to contribute to drm/panel, add myself as a reviewer for the DRM panel drivers to help the review process Signed-off-by: Jessica Zhang ---

Re: [RFC PATCH 3/3] drm/virtio: drm_gem_plane_helper_prepare_fb for obj synchronization

2023-08-31 Thread Dmitry Osipenko
On 8/24/23 20:58, Kim, Dongwon wrote: ... >> You can do fence-wait in the guest userspace/Mesa after blitting/drawing >> to the udmabuf. > > There is already synchronization between QEMU and virtio-gpu driver on > the guest. Upon resource flush, virtio-gpu waits for the response for > the message

Re: [Patch v2 2/3] drm/mst: Refactor the flow for payload allocation/removement

2023-08-31 Thread Lyude Paul
On Thu, 2023-08-24 at 04:12 +, Lin, Wayne wrote: > [Public] > > Hi Lyude, > > I'm afraid that I don't have the permissions to push and would like to have > your help. Thanks! Whoops, sorry I only just noticed this message. I set a reminder on my phone to bug me to push it tomorrow :), sorry

Re: [PATCH v5] drm/i915: Avoid circular locking dependency when flush delayed work on gt reset

2023-08-31 Thread John Harrison
On 8/31/2023 07:00, Andi Shyti wrote: Hi, diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c b/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c index a0e3ef1c65d2..600388c849f7 100644 --- a/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c +++ b/drivers/gpu/drm/i915/gt/uc/intel_gu

Re: truncation in drivers/video/fbdev/neofb.c

2023-08-31 Thread Nick Desaulniers
On Thu, Aug 31, 2023 at 3:16 PM Helge Deller wrote: > > * Nick Desaulniers : > > On Thu, Aug 31, 2023 at 2:23 PM Helge Deller wrote: > > > > > > * Helge Deller : > > > > On 8/29/23 18:45, Nick Desaulniers wrote: > > > > > A recent change in clang made it better about spotting snprintf that > > >

Re: truncation in drivers/video/fbdev/neofb.c

2023-08-31 Thread Helge Deller
* Nick Desaulniers : > On Thu, Aug 31, 2023 at 2:23 PM Helge Deller wrote: > > > > * Helge Deller : > > > On 8/29/23 18:45, Nick Desaulniers wrote: > > > > A recent change in clang made it better about spotting snprintf that > > > > will result in truncation. Nathan reported the following instanc

Re: [PATCH 5/5] drm/debugfs: rework drm_debugfs_create_files implementation v2

2023-08-31 Thread Andi Shyti
Hi Christian, On Tue, Aug 29, 2023 at 01:01:15PM +0200, Christian König wrote: > Use managed memory allocation for this. That allows us to not keep > track of all the files any more. > > v2: keep drm_debugfs_cleanup(), but rename to drm_debugfs_unregister(), > we still need to cleanup the sym

Re: [Intel-gfx] [PATCH 0/4] drm/amd/display: stop using drm_edid_override_connector_update()

2023-08-31 Thread Alex Hung
On 2023-08-30 01:29, Jani Nikula wrote: On Tue, 29 Aug 2023, Alex Hung wrote: On 2023-08-29 11:03, Jani Nikula wrote: On Tue, 29 Aug 2023, Jani Nikula wrote: On Tue, 29 Aug 2023, Alex Deucher wrote: On Tue, Aug 29, 2023 at 6:48 AM Jani Nikula wrote: On Wed, 23 Aug 2023, Jani Nikula

Re: [PATCH 4/5] drm/debugfs: remove dev->debugfs_list and debugfs_mutex v2

2023-08-31 Thread Andi Shyti
Hi Christian, On Tue, Aug 29, 2023 at 01:01:14PM +0200, Christian König wrote: > The mutex was completely pointless in the first place since any > parallel adding of files to this list would result in random > behavior since the list is filled and consumed multiple times. > > Completely drop that

Re: [PATCH] fbdev: Update fbdev source file paths

2023-08-31 Thread Helge Deller
On 8/31/23 11:02, Helge Deller wrote: On 8/31/23 10:51, Daniel Vetter wrote: On Thu, Aug 31, 2023 at 08:44:59AM +0200, Jonathan Neuschäfer wrote: On Wed, Aug 30, 2023 at 09:10:26AM +0200, Thomas Zimmermann wrote: Hi Am 29.08.23 um 22:02 schrieb Jonathan Neuschäfer: The files fbmem.c, fb_defi

Re: [PATCH 3/5] drm/debugfs: rework debugfs directory creation v5

2023-08-31 Thread Andi Shyti
Hi Christian, On Tue, Aug 29, 2023 at 01:01:13PM +0200, Christian König wrote: > Instead of the per minor directories only create a single debugfs > directory for the whole device directly when the device is initialized. > > For DRM devices each minor gets a symlink to the per device directory >

Re: truncation in drivers/video/fbdev/neofb.c

2023-08-31 Thread Nick Desaulniers
On Thu, Aug 31, 2023 at 2:23 PM Helge Deller wrote: > > * Helge Deller : > > On 8/29/23 18:45, Nick Desaulniers wrote: > > > A recent change in clang made it better about spotting snprintf that > > > will result in truncation. Nathan reported the following instances: > > > > > > drivers/video/fbd

Re: [PATCH] fbdev: ssd1307fb: Use bool for ssd1307fb_deviceinfo flags

2023-08-31 Thread Helge Deller
On 8/31/23 14:05, Geert Uytterhoeven wrote: The .need_pwm and .need_chargepump fields in struct ssd1307fb_deviceinfo are flags that can have only two possible values: 0 and 1. Reduce kernel size by changing their types from int to bool. Signed-off-by: Geert Uytterhoeven applied to fbdev git t

Re: [PATCH v2 2/6] drm/panfrost: Add fdinfo support GPU load metrics

2023-08-31 Thread Adrián Larumbe
On 31.08.2023 16:54, Steven Price wrote: >On 24/08/2023 02:34, Adrián Larumbe wrote: >> The drm-stats fdinfo tags made available to user space are drm-engine, >> drm-cycles, drm-max-freq and drm-curfreq, one per job slot. >> >> This deviates from standard practice in other DRM drivers, where a sin

Re: truncation in drivers/video/fbdev/neofb.c

2023-08-31 Thread Helge Deller
* Helge Deller : > On 8/29/23 18:45, Nick Desaulniers wrote: > > A recent change in clang made it better about spotting snprintf that > > will result in truncation. Nathan reported the following instances: > > > > drivers/video/fbdev/neofb.c:1959:3: warning: 'snprintf' will always be > > truncate

Re: [PATCH 0/6] drm, cec and edid updates

2023-08-31 Thread Hans Verkuil
On 31/08/2023 20:51, Jani Nikula wrote: > On Thu, 24 Aug 2023, Jani Nikula wrote: >> Avoid accessing the raw edid directly. Pre-parse the source physical >> address during normal EDID parsing and use that for CEC. >> >> Jani Nikula (6): >> drm/edid: add drm_edid_is_digital() >> drm/i915/displa

[PULL] drm-intel-next-fixes

2023-08-31 Thread Rodrigo Vivi
Hi Dave and Daniel, Only a single patch towards -rc1. I noticed that you already sent this week's PR, but sending this just in case. Otherwise I believe it could wait for the regular fixes cycle. Here goes drm-intel-next-fixes-2023-08-31: - Mark requests for GuC virtual engines to avoid use-afte

Re: [PATCH 7/7] drm/msm/dp: Remove dp_display_is_ds_bridge()

2023-08-31 Thread Kuogee Hsieh
On 8/29/2023 11:47 AM, Stephen Boyd wrote: This function is simply drm_dp_is_branch() so use that instead of open-coding it. Cc: Vinod Polimera Cc: Kuogee Hsieh Signed-off-by: Stephen Boyd Tested-by: Kuogee Hsieh Reviewed-by: Kuogee Hsieh --- drivers/gpu/drm/msm/dp/dp_display.c | 9 +-

Re: [PATCH 4/7] drm/msm/dp: Remove aux_cfg_update_done and related code

2023-08-31 Thread Kuogee Hsieh
On 8/29/2023 11:47 AM, Stephen Boyd wrote: The member 'aux_cfg_update_done' is always false. This is dead code that never runs. Remove it. Cc: Vinod Polimera Cc: Kuogee Hsieh Signed-off-by: Stephen Boyd Tested-by: Kuogee Hsieh Reviewed-by: Kuogee Hsieh --- drivers/gpu/drm/msm/dp/dp_pa

Re: [PATCH 5/7] drm/msm/dp: Simplify with drm_dp_{max_link_rate,max_lane_count}()

2023-08-31 Thread Kuogee Hsieh
On 8/29/2023 11:47 AM, Stephen Boyd wrote: These are open-coded versions of common functions. Replace them with the common code to improve readability. Cc: Vinod Polimera Cc: Kuogee Hsieh Signed-off-by: Stephen Boyd Tested-by: Kuogee Hsieh Reviewed-by: Kuogee Hsieh --- drivers/gpu/drm

Re: [PATCH 6/7] drm/msm/dp: Inline dp_link_parse_sink_count()

2023-08-31 Thread Kuogee Hsieh
On 8/29/2023 11:47 AM, Stephen Boyd wrote: The function dp_link_parse_sink_count() is really just drm_dp_read_sink_count(). It debug prints out the bit for content protection (DP_SINK_CP_READY), but that is not useful beyond debug because 'link->dp_link.sink_count' is overwritten to only contai

Re: [PATCH 3/7] drm/msm/dp: Remove dead code related to downstream cap info

2023-08-31 Thread Kuogee Hsieh
On 8/29/2023 11:47 AM, Stephen Boyd wrote: We read the downstream port count and capability info but never use it anywhere. Remove 'ds_port_cnt' and 'ds_cap_info' and any associated code from this driver. Fold the check for 'dfp_present' into a call to drm_dp_is_branch() at the one place it is

Re: [PATCH 3/7] drm/msm/dp: Remove dead code related to downstream cap info

2023-08-31 Thread Kuogee Hsieh
On 8/29/2023 11:47 AM, Stephen Boyd wrote: We read the downstream port count and capability info but never use it anywhere. Remove 'ds_port_cnt' and 'ds_cap_info' and any associated code from this driver. Fold the check for 'dfp_present' into a call to drm_dp_is_branch() at the one place it is

Re: [PATCH 2/7] drm/msm/dp: Use drm_dp_read_sink_count() helper

2023-08-31 Thread Kuogee Hsieh
On 8/29/2023 11:47 AM, Stephen Boyd wrote: Use the common function drm_dp_read_sink_count() instead of open-coding it. This shrinks the kernel text a tiny bit. Cc: Vinod Polimera Cc: Kuogee Hsieh Signed-off-by: Stephen Boyd Tested-by: Kuogee Hsieh Reviewed-by: Kuogee Hsieh --- drivers

Re: [PATCH 1/7] drm/msm/dp: Replace open-coded drm_dp_read_dpcd_caps()

2023-08-31 Thread Kuogee Hsieh
On 8/29/2023 11:47 AM, Stephen Boyd wrote: This function duplicates the common function drm_dp_read_dpcd_caps(). The array of DPCD registers filled in is one size larger than the function takes, but from what I can tell that extra byte was never used. Resize the array and use the common functio

Re: [PATCH v2 1/2] Revert "drm/amd/display: Remove v_startup workaround for dcn3+"

2023-08-31 Thread Harry Wentland
On 2023-08-31 15:44, Zuo, Jerry wrote: > [AMD Official Use Only - General] > > > Series is: > > Reviewed-By: Fangzhi Zuo > Reviewed-by: Harry Wentland Harry > -

Re: [PATCH 1/3] drm/ttm/tests: Add tests for ttm_resource and ttm_sys_man

2023-08-31 Thread kernel test robot
Hi Karolina, kernel test robot noticed the following build errors: [auto build test ERROR on drm-misc/drm-misc-next] [also build test ERROR on drm/drm-next drm-exynos/exynos-drm-next drm-intel/for-linux-next drm-tip/drm-tip linus/master next-20230831] [cannot apply to drm-intel/for-linux-next

Re: [RFC PATCH 07/10] drm/sched: Add helper to set TDR timeout

2023-08-31 Thread Luben Tuikov
On 2023-07-30 21:09, Matthew Brost wrote: > On Thu, May 04, 2023 at 01:28:12AM -0400, Luben Tuikov wrote: >> On 2023-04-03 20:22, Matthew Brost wrote: >>> Add helper to set TDR timeout and restart the TDR with new timeout >>> value. This will be used in XE, new Intel GPU driver, to trigger the TDR

Re: [RFC PATCH 06/10] drm/sched: Submit job before starting TDR

2023-08-31 Thread Luben Tuikov
On 2023-07-31 03:26, Boris Brezillon wrote: > +the PVR devs > > On Mon, 31 Jul 2023 01:00:59 + > Matthew Brost wrote: > >> On Thu, May 04, 2023 at 01:23:05AM -0400, Luben Tuikov wrote: >>> On 2023-04-03 20:22, Matthew Brost wrote: If the TDR is set to a value, it can fire before a job

Re: [PATCH v2 1/2] Revert "drm/amd/display: Remove v_startup workaround for dcn3+"

2023-08-31 Thread Zuo, Jerry
[AMD Official Use Only - General] Series is: Reviewed-By: Fangzhi Zuo 发件人: Mahfooz, Hamza 发送时间: 星期四, 八月 31, 2023 3:39:04 下午 收件人: amd-...@lists.freedesktop.org 抄送: Zuo, Jerry ; Mahfooz, Hamza ; sta...@vger.kernel.org ; Wentland, Harry ; Li, Sun peng (Leo) ;

Re: [PATCH v2] drm/amd/display: enable cursor degamma for DCN3+ DRM legacy gamma

2023-08-31 Thread Alex Deucher
Applied. Thanks! Alex On Thu, Aug 31, 2023 at 12:12 PM Melissa Wen wrote: > > For DRM legacy gamma, AMD display manager applies implicit sRGB degamma > using a pre-defined sRGB transfer function. It works fine for DCN2 > family where degamma ROM and custom curves go to the same color block. > B

[PATCH v2 2/2] drm/amd/display: limit the v_startup workaround for ASICs older than DCN3.1

2023-08-31 Thread Hamza Mahfooz
Since, calling dcn20_adjust_freesync_v_startup() on DCN3.1+ ASICs can cause the display to flicker and underflow to occur we shouldn't call it for them. So, ensure that the DCN version is less than DCN_VERSION_3_1 before calling dcn20_adjust_freesync_v_startup(). Cc: sta...@vger.kernel.org Signed-

[PATCH v2 1/2] Revert "drm/amd/display: Remove v_startup workaround for dcn3+"

2023-08-31 Thread Hamza Mahfooz
This reverts commit 3a31e8b89b7240d9a17ace8a1ed050bdcb560f9e. We still need to call dcn20_adjust_freesync_v_startup() for older DCN3+ ASICs otherwise it can cause DP to HDMI 2.1 PCONs to fail to light up. Cc: sta...@vger.kernel.org Link: https://gitlab.freedesktop.org/drm/amd/-/issues/2809 Signed

Re: [PATCH] drm/amd/display: remove useless check in should_enable_fbc()

2023-08-31 Thread Alex Deucher
Applied. Thanks! Alex On Thu, Aug 31, 2023 at 2:48 PM Harry Wentland wrote: > > On 2023-08-30 10:01, Dembskiy Igor wrote: > > It does not make sense to compare a pointer to array element with NULL. > > > > Found by Linux Verification Center (linuxtesting.org) with SVACE. > > > > Fixes: 65d38262

Re: [PATCH v2] Documentation/gpu: VM_BIND locking document

2023-08-31 Thread Rodrigo Vivi
On Wed, Aug 16, 2023 at 11:15:47AM +0200, Thomas Hellström wrote: > Add the first version of the VM_BIND locking document which is > intended to be part of the xe driver upstreaming agreement. > > The document describes and discuss the locking used during exec- > functions, evicton and for userptr

Re: [PATCH 4/4] drm/doc/rfc: Mark GPU VA as complete.

2023-08-31 Thread Rodrigo Vivi
On Tue, Aug 29, 2023 at 12:30:04PM -0400, Rodrigo Vivi wrote: > Nouveau has landed the GPU VA helpers, support and documentation > already and Xe is already using the upstream GPU VA. Danilo, although this is more on the Xe side and I wouldn't ask you to review our code entirely, I'd like to get y

Re: [PATCH] Revert "drm/amd/display: Remove v_startup workaround for dcn3+"

2023-08-31 Thread Harry Wentland
On 2023-08-29 16:10, Hamza Mahfooz wrote: > This reverts commit 3a31e8b89b7240d9a17ace8a1ed050bdcb560f9e. > This isn't a straight-up revert. Please split it into a revert (git revert), followed by a patch to limit the revert to < DCN_VERSION_3_1. Harry > We still need to call dcn20_adjust_frees

Re: [PATCH 3/4] drm/doc/rfc: Mark DRM_VM_BIND as complete.

2023-08-31 Thread Rodrigo Vivi
On Tue, Aug 29, 2023 at 12:30:03PM -0400, Rodrigo Vivi wrote: > The consensus is for individual drivers VM_BIND uapis with > the GPUVA helpers that are already implemented and merged > upstream. > > The merged GPUVA documentation also establish some overall > rules for the locking to be followed b

Re: [PATCH 1/4] drm/doc/rfc: No STAGING out of drivers/staging.

2023-08-31 Thread Rodrigo Vivi
On Thu, Aug 31, 2023 at 10:31:07AM +0200, Daniel Vetter wrote: > On Tue, Aug 29, 2023 at 12:30:01PM -0400, Rodrigo Vivi wrote: > > Also the uapi should be reviewed and scrutinized before xe > > is accepted upstream and we shouldn't cause regression. > > > > Link: > > https://lore.kernel.org/all/2

Re: [PATCH drm-misc-next 2/3] drm/gpuva_mgr: generalize dma_resv/extobj handling and GEM validation

2023-08-31 Thread Danilo Krummrich
On Thu, Aug 31, 2023 at 06:53:01PM +0200, Thomas Hellström (Intel) wrote: > Hi, > > On 8/31/23 13:18, Danilo Krummrich wrote: > > On Thu, Aug 31, 2023 at 11:04:06AM +0200, Thomas Hellström (Intel) wrote: > > > Hi! > > > > > > On 8/30/23 17:00, Danilo Krummrich wrote: > > > > On Wed, Aug 30, 2023

Re: mainline build failure due to 501126083855 ("fbdev/g364fb: Use fbdev I/O helpers")

2023-08-31 Thread Linus Torvalds
On Thu, 31 Aug 2023 at 11:48, Sudip Mukherjee (Codethink) wrote: > The latest mainline kernel branch fails to build mips jazz_defconfig with > the error: > > drivers/video/fbdev/g364fb.c:115:9: error: 'FB_DEFAULT_IOMEM_HELPERS' > undeclared here (not in a function); did you mean 'FB_DEFAULT_IOMEM

Re: [PATCH AUTOSEL 5.10 13/22] drm/amdgpu: install stub fence into potential unused fence pointers

2023-08-31 Thread Chia-I Wu
On Thu, Aug 31, 2023 at 7:01 AM Greg KH wrote: > > On Thu, Aug 31, 2023 at 03:26:28PM +0200, Christian König wrote: > > Am 31.08.23 um 12:56 schrieb Greg KH: > > > On Thu, Aug 31, 2023 at 12:27:27PM +0200, Christian König wrote: > > > > Am 30.08.23 um 20:53 schrieb Chia-I Wu: > > > > > On Sun, Jul

Re: [PATCH 0/6] drm, cec and edid updates

2023-08-31 Thread Jani Nikula
On Thu, 24 Aug 2023, Jani Nikula wrote: > Avoid accessing the raw edid directly. Pre-parse the source physical > address during normal EDID parsing and use that for CEC. > > Jani Nikula (6): > drm/edid: add drm_edid_is_digital() > drm/i915/display: use drm_edid_is_digital() > drm/edid: parse

mainline build failure due to 501126083855 ("fbdev/g364fb: Use fbdev I/O helpers")

2023-08-31 Thread Sudip Mukherjee (Codethink)
Hi All, The latest mainline kernel branch fails to build mips jazz_defconfig with the error: drivers/video/fbdev/g364fb.c:115:9: error: 'FB_DEFAULT_IOMEM_HELPERS' undeclared here (not in a function); did you mean 'FB_DEFAULT_IOMEM_OPS'? 115 | FB_DEFAULT_IOMEM_HELPERS, | ^

Re: [PATCH] drm/amd/display: remove useless check in should_enable_fbc()

2023-08-31 Thread Harry Wentland
On 2023-08-30 10:01, Dembskiy Igor wrote: > It does not make sense to compare a pointer to array element with NULL. > > Found by Linux Verification Center (linuxtesting.org) with SVACE. > > Fixes: 65d38262b3e8 ("drm/amd/display: fbc state could not reach while enable > fbc") > Signed-off-by: Dem

Re: [PATCH v7 1/1] vfio/nvgpu: Add vfio pci variant module for grace hopper

2023-08-31 Thread Alex Williamson
On Thu, 31 Aug 2023 07:04:10 -0700 Christoph Hellwig wrote: > On Thu, Aug 31, 2023 at 01:51:11PM +, Ankit Agrawal wrote: > > Hi Christoph, > > > > >Whats the actual consumer running in a qemu VM here? > > The primary use case in the VM is to run the open source Nvidia > > driver (https:/

Re: [RFC PATCH 04/10] drm/panel_helper: Introduce drm_panel_helper

2023-08-31 Thread Doug Anderson
Hi, On Thu, Aug 31, 2023 at 12:38 AM Maxime Ripard wrote: > > If so, then I think we can implement everything by doing something like: > > - Implement enable and disable refcounting in panels. > drm_panel_prepare and drm_panel_enable would increase it, > drm_panel_unprepare and drm_pane

Re: [PATCH v2 1/2] drm/amdgpu: Merge debug module parameters

2023-08-31 Thread Felix Kuehling
On 2023-08-30 18:08, André Almeida wrote: Merge all developer debug options available as separated module parameters in one, making it obvious that are for developers. Drop the obsolete module options in favor of the new ones. Signed-off-by: André Almeida --- v2: - drop old module params - u

Re: Framebuffer mmap on PowerPC

2023-08-31 Thread Christophe Leroy
Le 31/08/2023 à 19:38, Christophe Leroy a écrit : > > > Le 31/08/2023 à 16:41, Thomas Zimmermann a écrit : >> Hi, >> >> there's a per-architecture function called fb_pgprotect() that sets >> VMA's vm_page_prot for mmaped framebuffers. Most architectures use a >> simple implementation based on

Re: [PATCH] fbdev: ssd1307fb: Use bool for ssd1307fb_deviceinfo flags

2023-08-31 Thread Javier Martinez Canillas
Geert Uytterhoeven writes: > The .need_pwm and .need_chargepump fields in struct ssd1307fb_deviceinfo > are flags that can have only two possible values: 0 and 1. > Reduce kernel size by changing their types from int to bool. > > Signed-off-by: Geert Uytterhoeven > --- Acked-by: Javier Martinez

Re: Framebuffer mmap on PowerPC

2023-08-31 Thread Christophe Leroy
Le 31/08/2023 à 16:41, Thomas Zimmermann a écrit : > Hi, > > there's a per-architecture function called fb_pgprotect() that sets > VMA's vm_page_prot for mmaped framebuffers. Most architectures use a > simple implementation based on pgprot_writecomine() [1] or > pgprot_noncached(). [2] > > O

Re: [Intel-gfx] [PATCH 2/6] drm/i915/display: use drm_edid_is_digital()

2023-08-31 Thread Ville Syrjälä
On Thu, Aug 24, 2023 at 04:46:03PM +0300, Jani Nikula wrote: > Reduce the use of struct edid and drm_edid_raw(). > > Signed-off-by: Jani Nikula > --- > drivers/gpu/drm/i915/display/intel_crt.c | 11 --- > drivers/gpu/drm/i915/display/intel_hdmi.c | 9 - > drivers/gpu/drm/i915/d

Re: [PATCH drm-misc-next 2/3] drm/gpuva_mgr: generalize dma_resv/extobj handling and GEM validation

2023-08-31 Thread Thomas Hellström
On 8/31/23 18:53, Thomas Hellström (Intel) wrote: Hi, On 8/31/23 13:18, Danilo Krummrich wrote: On Thu, Aug 31, 2023 at 11:04:06AM +0200, Thomas Hellström (Intel) wrote: Hi! On 8/30/23 17:00, Danilo Krummrich wrote: On Wed, Aug 30, 2023 at 03:42:08PM +0200, Thomas Hellström (Intel) wrote:

Re: [PATCH 1/6] drm/edid: add drm_edid_is_digital()

2023-08-31 Thread Ville Syrjälä
On Thu, Aug 24, 2023 at 04:46:02PM +0300, Jani Nikula wrote: > Checking edid->input & DRM_EDID_INPUT_DIGITAL is common enough to > deserve a helper that also lets us abstract the raw EDID a bit better. > > Signed-off-by: Jani Nikula Reviewed-by: Ville Syrjälä > --- > drivers/gpu/drm/drm_edid.

Re: [PATCH drm-misc-next 2/3] drm/gpuva_mgr: generalize dma_resv/extobj handling and GEM validation

2023-08-31 Thread Intel
Hi, On 8/31/23 13:18, Danilo Krummrich wrote: On Thu, Aug 31, 2023 at 11:04:06AM +0200, Thomas Hellström (Intel) wrote: Hi! On 8/30/23 17:00, Danilo Krummrich wrote: On Wed, Aug 30, 2023 at 03:42:08PM +0200, Thomas Hellström (Intel) wrote: On 8/30/23 14:49, Danilo Krummrich wrote: Hi Thomas

Re: [PATCH v6 3/4] drm/bridge: Drop CONFIG_OF conditionals around of_node pointers

2023-08-31 Thread Andy Shevchenko
On Thu, Aug 31, 2023 at 09:09:37AM +0100, Biju Das wrote: > Having conditional around the of_node pointers turns out to make driver > code use ugly #ifdef and #if blocks. So drop the conditionals. ... > anx78xx->bridge.of_node = client->dev.of_node; > panel_bridge->bridge.of_node = p

Re: [PATCH v6 4/4] drm/bridge: panel: Drop CONFIG_OF conditional around *_of_get_bridge()

2023-08-31 Thread Andy Shevchenko
On Thu, Aug 31, 2023 at 10:47:24AM +, Biju Das wrote: > > On Thu, Aug 31, 2023 at 09:09:38AM +0100, Biju Das wrote: ... > > > Drop unnecessary CONFIG_OF conditional around devm_drm_of_get_bridge() > > > and > > > drmm_of_get_bridge() as it is guarded with #if..#else blocks in > > > drm_bridge

[PATCH v2] drm/amd/display: enable cursor degamma for DCN3+ DRM legacy gamma

2023-08-31 Thread Melissa Wen
For DRM legacy gamma, AMD display manager applies implicit sRGB degamma using a pre-defined sRGB transfer function. It works fine for DCN2 family where degamma ROM and custom curves go to the same color block. But, on DCN3+, degamma is split into two blocks: degamma ROM for pre-defined TFs and `gam

Re: [PATCH v2 2/6] drm/panfrost: Add fdinfo support GPU load metrics

2023-08-31 Thread Steven Price
On 24/08/2023 02:34, Adrián Larumbe wrote: > The drm-stats fdinfo tags made available to user space are drm-engine, > drm-cycles, drm-max-freq and drm-curfreq, one per job slot. > > This deviates from standard practice in other DRM drivers, where a single > set of key:value pairs is provided for t

Re: [PATCH v2 1/6] drm/panfrost: Add cycle count GPU register definitions

2023-08-31 Thread Steven Price
On 24/08/2023 02:34, Adrián Larumbe wrote: > These GPU registers will be used when programming the cycle counter, which > we need for providing accurate fdinfo drm-cycles values to user space. > > Signed-off-by: Adrián Larumbe Reviewed-by: Steven Price > --- > drivers/gpu/drm/panfrost/panfros

Re: Refcounting in drm_exec

2023-08-31 Thread Thomas Hellström
On 8/31/23 17:19, Christian König wrote: Hi Thomas, Am 31.08.23 um 17:12 schrieb Thomas Hellström: Hi, Christian, Danilo Looking at the drm_exec code it seems we refcount *all* locked objects until drm_exec_fini(). Are callers supposed to be able to *rely* on this? Yes, that's one of the

[PATCH v3 2/2] drm/amdgpu: Create an option to disable soft recovery

2023-08-31 Thread André Almeida
Create a module option to disable soft recoveries on amdgpu, making every recovery go through the device reset path. This option makes easier to force device resets for testing and debugging purposes. Signed-off-by: André Almeida Reviewed-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgp

[PATCH v3 1/2] drm/amdgpu: Merge debug module parameters

2023-08-31 Thread André Almeida
Merge all developer debug options available as separated module parameters in one, making it obvious that are for developers. Drop the obsolete module options in favor of the new ones. Signed-off-by: André Almeida Reviewed-by: Christian König --- v3: - move from include/amd_shared.h to amdgpu/a

[PATCH v3 0/2] Merge all debug module parameters

2023-08-31 Thread André Almeida
As suggested by Christian at [0], this patchset merges all debug modules parameters and creates a new one for disabling soft recovery: > Maybe we can overload the amdgpu_gpu_recovery module option with this. > Or even better merge all the developer module parameter into a > amdgpu_debug option.

Re: Refcounting in drm_exec

2023-08-31 Thread Christian König
Hi Thomas, Am 31.08.23 um 17:12 schrieb Thomas Hellström: Hi, Christian, Danilo Looking at the drm_exec code it seems we refcount *all* locked objects until drm_exec_fini(). Are callers supposed to be able to *rely* on this? Yes, that's one of the motivations for this component. I'm asking

Refcounting in drm_exec

2023-08-31 Thread Thomas Hellström
Hi, Christian, Danilo Looking at the drm_exec code it seems we refcount *all* locked objects until drm_exec_fini(). Are callers supposed to be able to *rely* on this? I'm asking because refcounting appears only strictly necessary for contended- and prelocked objects, and callers would otherwis

[PATCH] drm/amd/display: remove useless check in should_enable_fbc()

2023-08-31 Thread Dembskiy Igor
It does not make sense to compare a pointer to array element with NULL. Found by Linux Verification Center (linuxtesting.org) with SVACE. Fixes: 65d38262b3e8 ("drm/amd/display: fbc state could not reach while enable fbc") Signed-off-by: Dembskiy Igor --- drivers/gpu/drm/amd/display/dc/dce110/d

[PATCH] drm/amd/pm: Replace 1-element arrays with flexible array members

2023-08-31 Thread Samuel Holland
Since commit df8fc4e934c1 ("kbuild: Enable -fstrict-flex-arrays=3"), UBSAN_BOUNDS no longer pretends 1-element arrays are unbounded. The bounds check is tripped in smu7_get_pp_table_entry_callback_func_v1(), while reading from mclk_dep_table. For consistency, fix all affected struct definitions in

RE: [PATCH v1 1/2] dt-bindings: backlight: Add MPS MP3309C

2023-08-31 Thread Flavio Suligoi
Hi Krzysztof, ... > >>> + > >>> + reg: > >>> +maxItems: 1 > >>> + > >>> + mps,dimming-mode: > >>> +description: The dimming mode (PWM or analog by I2C commands). > >>> +$ref: '/schemas/types.yaml#/definitions/string' > >> > >> Drop quotes, you should see warnings for this. > >> > >>

Re: [RFC PATCH v2 02/11] netdev: implement netlink api to bind dma-buf to netdevice

2023-08-31 Thread Yunsheng Lin
On 2023/8/10 9:57, Mina Almasry wrote: ... > + > +int netdev_bind_dmabuf_to_queue(struct net_device *dev, unsigned int > dmabuf_fd, > + u32 rxq_idx, struct netdev_dmabuf_binding **out) > +{ > + struct netdev_dmabuf_binding *binding; > + struct netdev_rx_queue

RE: [PATCH v1 2/2] backlight: mp3309c: Add support for MPS MP3309C

2023-08-31 Thread Flavio Suligoi
HI Daniel, > -Original Message- > From: Daniel Thompson > Sent: Tuesday, August 29, 2023 6:28 PM > To: Flavio Suligoi > Cc: Lee Jones ; Jingoo Han ; Helge > Deller ; Pavel Machek ; Rob Herring > ; Krzysztof Kozlowski > ; Conor Dooley ; > dri-devel@lists.freedesktop.org; linux-l...@vger.k

Re: [PATCH v2] MAINTAINERS: Add Boris Brezillon as Panfrost driver maintainer

2023-08-31 Thread Steven Price
On 22/08/2023 06:25, Dmitry Osipenko wrote: > Add Boris Brezillon as Panfrost driver maintainer. Boris is a new lead > developer of the Panfrost Mesa driver and main developer behind the > upcoming Panthor kernel driver that will serve next-gen Mali GPUs. > > Remove Tomeu and Alyssa, who left Coll

Re: [PATCH v2 12/15] drm/panthor: Add the driver frontend block

2023-08-31 Thread Steven Price
On 29/08/2023 18:46, Boris Brezillon wrote: > On Mon, 21 Aug 2023 12:31:29 +0100 > Steven Price wrote: > >> On 09/08/2023 17:53, Boris Brezillon wrote: [...] >>> + * // Collect signal operations on all jobs, such that each job can pick >>> + * // from it for its dependencies and update the fenc

Re: [PATCH AUTOSEL 5.10 13/22] drm/amdgpu: install stub fence into potential unused fence pointers

2023-08-31 Thread Greg KH
On Thu, Aug 31, 2023 at 03:26:28PM +0200, Christian König wrote: > Am 31.08.23 um 12:56 schrieb Greg KH: > > On Thu, Aug 31, 2023 at 12:27:27PM +0200, Christian König wrote: > > > Am 30.08.23 um 20:53 schrieb Chia-I Wu: > > > > On Sun, Jul 23, 2023 at 6:24 PM Sasha Levin wrote: > > > > > From: Lan

Re: [PATCH v2 0/2] Merge all debug module parameters

2023-08-31 Thread Helen Koike
Hi André, Thanks for your patches. On 30/08/2023 19:08, André Almeida wrote: As suggested by Christian at [0], this patchset merges all debug modules parameters and creates a new one for disabling soft recovery: Maybe we can overload the amdgpu_gpu_recovery module option with this. Or even be

Re: [PATCH v5] drm/i915: Avoid circular locking dependency when flush delayed work on gt reset

2023-08-31 Thread Andi Shyti
Hi, > > > > diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c > > > > b/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c > > > > index a0e3ef1c65d2..600388c849f7 100644 > > > > --- a/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c > > > > +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc

Re: [PATCH AUTOSEL 5.10 13/22] drm/amdgpu: install stub fence into potential unused fence pointers

2023-08-31 Thread Christian König
Am 31.08.23 um 12:56 schrieb Greg KH: On Thu, Aug 31, 2023 at 12:27:27PM +0200, Christian König wrote: Am 30.08.23 um 20:53 schrieb Chia-I Wu: On Sun, Jul 23, 2023 at 6:24 PM Sasha Levin wrote: From: Lang Yu [ Upstream commit 187916e6ed9d0c3b3abc27429f7a5f8c936bd1f0 ] When using cpu to upd

Re: [PATCH v2 15/15] drm/panthor: Add an entry to MAINTAINERS

2023-08-31 Thread Boris Brezillon
On Thu, 31 Aug 2023 14:18:42 +0100 Liviu Dudau wrote: > Hi Boris, > > On Wed, Aug 09, 2023 at 06:53:28PM +0200, Boris Brezillon wrote: > > Add an entry for the Panthor driver to the MAINTAINERS file. > > > > v2: > > - New commit > > > > Signed-off-by: Boris Brezillon > > --- > > > > If anyon

Re: [PATCH v2 15/15] drm/panthor: Add an entry to MAINTAINERS

2023-08-31 Thread Liviu Dudau
Hi Boris, On Wed, Aug 09, 2023 at 06:53:28PM +0200, Boris Brezillon wrote: > Add an entry for the Panthor driver to the MAINTAINERS file. > > v2: > - New commit > > Signed-off-by: Boris Brezillon > --- > > If anyone from Arm wants to volunteer to become a co-maintainer, that > would be highly

  1   2   >