Re: [Intel-gfx] [PATCH] drm/i915/mtl: avoid stringop-overflow warning

2023-10-16 Thread Arnd Bergmann
On Tue, Oct 17, 2023, at 00:10, Andi Shyti wrote: > Hi Arnd, > >> static void rc6_res_reg_init(struct intel_rc6 *rc6) >> { >> -memset(rc6->res_reg, INVALID_MMIO_REG.reg, sizeof(rc6->res_reg)); > > This is a complex initialization, indeed... how about just > >memset(rc6->res_reg, 0,

Re: [PATCH v7 04/23] dt-bindings: display: mediatek: padding: Add MT8188

2023-10-16 Thread 宋孝謙

[PATCH 2/2] gpu/drm: Eliminate DRM_SCHED_PRIORITY_UNSET

2023-10-16 Thread Luben Tuikov
Eliminate DRM_SCHED_PRIORITY_UNSET, value of -2, whose only user was amdgpu. Furthermore, eliminate an index bug, in that when amdgpu boots, it calls drm_sched_entity_init() with DRM_SCHED_PRIORITY_UNSET, which uses it to index sched->sched_rq[]. Cc: Alex Deucher Cc: Christian König

[PATCH 1/2] drm/amdgpu: Unset context priority is now invalid

2023-10-16 Thread Luben Tuikov
A context priority value of AMD_CTX_PRIORITY_UNSET is now invalid--instead of carrying it around and passing it to the Direct Rendering Manager--and it becomes AMD_CTX_PRIORITY_NORMAL in amdgpu_ctx_ioctl(), the gateway to context creation. Cc: Alex Deucher Cc: Christian König Signed-off-by:

RE: [EXT] Re: [PATCH v10 4/7] drm: bridge: Cadence: Add MHDP8501 DP/HDMI driver

2023-10-16 Thread Sandor Yu
> > On 13/10/2023 05:24, Sandor Yu wrote: > > Add a new DRM DisplayPort and HDMI bridge driver for Candence > MHDP8501 > > used in i.MX8MQ SOC. MHDP8501 could support HDMI or DisplayPort > > standards according embedded Firmware running in the uCPU. > > ... > > > + > > +static struct

[PATCH v4 5/6] drm/msm/dpu: Add hw revision 4.1 (SDM670)

2023-10-16 Thread Richard Acayan
The Snapdragon 670 uses similar clocks (with one frequency added) to the Snapdragon 845 but reports DPU revision 4.1. Add support for this DPU with configuration from the Pixel 3a downstream kernel. Since revision 4.0 is SDM845, reuse some configuration from its catalog entry. Link:

[PATCH v4 6/6] arm64: dts: qcom: sdm670: add display subsystem

2023-10-16 Thread Richard Acayan
The Snapdragon 670 has a display subsystem for controlling and outputting to the display. Add support for it in the device tree. Reviewed-by: Dmitry Baryshkov Signed-off-by: Richard Acayan --- arch/arm64/boot/dts/qcom/sdm670.dtsi | 292 +++ 1 file changed, 292

[PATCH v4 2/6] dt-bindings: display/msm: sdm845-dpu: Describe SDM670

2023-10-16 Thread Richard Acayan
The SDM670 display controller has the same requirements as the SDM845 display controller, despite having distinct properties as described in the catalog. Add the compatible for SDM670 to the SDM845 controller. Acked-by: Rob Herring Signed-off-by: Richard Acayan ---

[PATCH v4 4/6] drm/msm: mdss: add support for SDM670

2023-10-16 Thread Richard Acayan
Add support for the MDSS block on the SDM670 platform. Reviewed-by: Dmitry Baryshkov Signed-off-by: Richard Acayan --- drivers/gpu/drm/msm/msm_mdss.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/gpu/drm/msm/msm_mdss.c b/drivers/gpu/drm/msm/msm_mdss.c index

[PATCH v4 3/6] dt-bindings: display: msm: Add SDM670 MDSS

2023-10-16 Thread Richard Acayan
Add documentation for the SDM670 display subsystem, adapted from the SDM845 and SM6125 documentation. Reviewed-by: Rob Herring Signed-off-by: Richard Acayan --- .../display/msm/qcom,sdm670-mdss.yaml | 292 ++ 1 file changed, 292 insertions(+) create mode 100644

[PATCH v4 1/6] dt-bindings: display/msm: dsi-controller-main: add SDM670 compatible

2023-10-16 Thread Richard Acayan
The SDM670 has DSI ports. Add the compatible for the controller. Acked-by: Rob Herring Signed-off-by: Richard Acayan --- .../devicetree/bindings/display/msm/dsi-controller-main.yaml | 1 + 1 file changed, 1 insertion(+) diff --git

[PATCH v4 0/6] SDM670 display subsystem support

2023-10-16 Thread Richard Acayan
Changes since v3 (2023100927.485054-8-mailingrad...@gmail.com): - move status properties down (review tag retained) (6/6) - accumulate review tag (3/6) Changes since v2 (20231003012119.857198-9-mailingrad...@gmail.com): - rebase on series and reference generic sblk definitions (5/6) - add

Re: [Freedreno] [PATCH RFC v6 07/10] drm/atomic: Loosen FB atomic checks

2023-10-16 Thread Jessica Zhang
On 9/24/2023 3:23 AM, Dmitry Baryshkov wrote: On 22/09/2023 20:49, Jessica Zhang wrote: On 8/29/2023 1:22 AM, Pekka Paalanen wrote: On Mon, 28 Aug 2023 17:05:13 -0700 Jessica Zhang wrote: Loosen the requirements for atomic and legacy commit so that, in cases where pixel_source != FB,

Re: [Intel-gfx] [PATCH] drm/i915/mtl: Don't set PIPE_CONTROL_FLUSH_L3

2023-10-16 Thread Belgaumkar, Vinay
On 10/16/2023 4:24 PM, John Harrison wrote: On 10/16/2023 15:55, Vinay Belgaumkar wrote: This bit does not cause an explicit L3 flush. We already use At all? Or only on newer hardware? And as a genuine spec change or as a bug / workaround? If the hardware has re-purposed the bit then it is

[GIT PULL] mediatek drm fixes 20231017

2023-10-16 Thread Chun-Kuang Hu
Hi, Dave & Daniel: This includes: 1. Correctly free sg_table in gem prime vmap Regards, Chun-Kuang. The following changes since commit 58720809f52779dc0f08e53e54b014209d13eebb: Linux 6.6-rc6 (2023-10-15 13:34:39 -0700) are available in the Git repository at:

Re: [Intel-gfx] [PATCH] drm/i915/mtl: Don't set PIPE_CONTROL_FLUSH_L3

2023-10-16 Thread John Harrison
On 10/16/2023 15:55, Vinay Belgaumkar wrote: This bit does not cause an explicit L3 flush. We already use At all? Or only on newer hardware? And as a genuine spec change or as a bug / workaround? If the hardware has re-purposed the bit then it is probably worth at least adding a comment to

[PATCH] drm/i915/mtl: Don't set PIPE_CONTROL_FLUSH_L3

2023-10-16 Thread Vinay Belgaumkar
This bit does not cause an explicit L3 flush. We already use PIPE_CONTROL_DC_FLUSH_ENABLE for that purpose. Cc: Nirmoy Das Cc: Mikka Kuoppala Signed-off-by: Vinay Belgaumkar --- drivers/gpu/drm/i915/gt/gen8_engine_cs.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git

[PATCH v2] drm/modes: replace deprecated strncpy with strscpy_pad

2023-10-16 Thread Justin Stitt
`strncpy` is deprecated for use on NUL-terminated destination strings [1] and as such we should prefer more robust and less ambiguous string interfaces. We should NUL-pad as there are full struct copies happening in places: | struct drm_mode_modeinfo umode; | | ... |

Re: [Intel-gfx] [PATCH] drm/i915/mtl: avoid stringop-overflow warning

2023-10-16 Thread Andi Shyti
Hi Arnd, > static void rc6_res_reg_init(struct intel_rc6 *rc6) > { > - memset(rc6->res_reg, INVALID_MMIO_REG.reg, sizeof(rc6->res_reg)); This is a complex initialization, indeed... how about just memset(rc6->res_reg, 0, sizeof(rc6->res_reg)); > + i915_reg_t

Re: [PATCH v6 6/6] drm/doc: Define KMS atomic state set

2023-10-16 Thread Simon Ser
On Monday, October 16th, 2023 at 17:10, Ville Syrjälä wrote: > On Mon, Oct 16, 2023 at 05:52:22PM +0300, Pekka Paalanen wrote: > > > On Mon, 16 Oct 2023 15:42:16 +0200 > > André Almeida andrealm...@igalia.com wrote: > > > > > Hi Pekka, > > > > > > On 10/16/23 14:18, Pekka Paalanen wrote: > >

Re: [PATCH v2 1/2] video: fbdev: core: cfbcopyarea: fix sloppy typing

2023-10-16 Thread Helge Deller
On 10/13/23 22:50, Sergey Shtylyov wrote: In cfb_copyarea(), the local variable bits_per_line is needlessly typed as *unsigned long* -- which is a 32-bit type on the 32-bit arches and a 64-bit type on the 64-bit arches; that variable's value is derived from the __u32 typed

Re: [PATCH 1/2] fbdev/uvesafb: Remove uvesafb_exec() prototype from include/video/uvesafb.h

2023-10-16 Thread Helge Deller
On 10/6/23 22:43, Jorge Maidana wrote: uvesafb_exec() is a static function defined and called only in drivers/video/fbdev/uvesafb.c, remove the prototype from include/video/uvesafb.h. Fixes the warning: ./include/video/uvesafb.h:112:12: warning: 'uvesafb_exec' declared 'static' but never

Re: [PATCH] fbdev: fbmon: fix potential divide error in fb_validate_mode

2023-10-16 Thread Helge Deller
On 10/14/23 14:14, Zhang Shurong wrote: We can easily use FBIOPUT_VSCREENINFO set fb_var_screeninfo, so it's possible for a divide by zero error to occur. Fix this by making sure the divisor is non-zero before the computation. Signed-off-by: Zhang Shurong ---

Re: [PATCH] fbdev: omapfb: fix some error codes

2023-10-16 Thread Helge Deller
On 10/16/23 13:19, Dan Carpenter wrote: Return negative -ENXIO instead of positive ENXIO. Signed-off-by: Dan Carpenter applied. Thanks! Helge --- No fixes tag because the caller doesn't check for errors. drivers/video/fbdev/omap/omapfb_main.c | 4 ++-- 1 file changed, 2 insertions(+),

Re: [PATCH] fbdev: sa1100fb: mark sa1100fb_init() static

2023-10-16 Thread Helge Deller
On 10/16/23 22:04, Arnd Bergmann wrote: From: Arnd Bergmann This is a global function that is only referenced as an initcall. This causes a warning: drivers/video/fbdev/sa1100fb.c:1218:12: error: no previous prototype for 'sa1100fb_init' [-Werror=missing-prototypes] Make it static instead.

Re: (subset) [PATCH 0/5] Add Support for RK3566 Powkiddy RGB30

2023-10-16 Thread Heiko Stuebner
On Fri, 13 Oct 2023 13:39:13 -0500, Chris Morgan wrote: > From: Chris Morgan > > Add support for the Powkiddy RGB30 handheld gaming console. > > Chris Morgan (5): > dt-bindings: vendor-prefixes: document Powkiddy > dt-bindings: panel: Add Powkiddy RGB30 panel compatible > drm/panel:

Re: (subset) [PATCH 0/5] Add Support for RK3566 Powkiddy RGB30

2023-10-16 Thread Heiko Stuebner
On Fri, 13 Oct 2023 13:39:13 -0500, Chris Morgan wrote: > From: Chris Morgan > > Add support for the Powkiddy RGB30 handheld gaming console. > > Chris Morgan (5): > dt-bindings: vendor-prefixes: document Powkiddy > dt-bindings: panel: Add Powkiddy RGB30 panel compatible > drm/panel:

Re: [PATCH 1/3] drm/virtio: use uint64_t more in virtio_gpu_context_init_ioctl

2023-10-16 Thread Dmitry Osipenko
On 10/16/23 21:41, Gurchetan Singh wrote: > drm_virtgpu_context_set_param defines both param and > value to be u64s. > > Signed-off-by: Gurchetan Singh > --- > drivers/gpu/drm/virtio/virtgpu_ioctl.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git

Re: [PATCH 2/3] drm/uapi: add explicit virtgpu context debug name

2023-10-16 Thread Dmitry Osipenko
On 10/16/23 21:41, Gurchetan Singh wrote: > There are two problems with the current method of determining the > virtio-gpu debug name. > > 1) TASK_COMM_LEN is defined to be 16 bytes only, and this is a >Linux kernel idiom (see PR_SET_NAME + PR_GET_NAME). Though, >Android/FreeBSD get

Re: [PATCH 3/3] drm/virtio: implement debug name via CONTEXT_INIT

2023-10-16 Thread Dmitry Osipenko
On 10/16/23 21:42, Gurchetan Singh wrote: > This allows setting the debug name during CONTEXT_INIT. > > Signed-off-by: Gurchetan Singh > --- > drivers/gpu/drm/virtio/virtgpu_drv.h | 4 +++ > drivers/gpu/drm/virtio/virtgpu_ioctl.c | 38 ++ > 2 files changed, 36

Re: [Freedreno] [PATCH 6/7] arm64: dts: qcom: sc7280: Mark Adreno SMMU as DMA coherent

2023-10-16 Thread Akhil P Oommen
On Tue, Sep 26, 2023 at 08:24:41PM +0200, Konrad Dybcio wrote: > > The SMMUs on sc7280 are cache-coherent. APPS_SMMU is marked as such, > mark the GPU one as well. > > Signed-off-by: Konrad Dybcio Reviewed-by: Akhil P Oommen -Akhil > --- > arch/arm64/boot/dts/qcom/sc7280.dtsi | 1 + > 1

Re: [PATCH 5/7] arm64: dts: qcom: sc7280: Fix up GPU SIDs

2023-10-16 Thread Akhil P Oommen
On Tue, Sep 26, 2023 at 08:24:40PM +0200, Konrad Dybcio wrote: > > GPU_SMMU SID 1 is meant for Adreno LPAC (Low Priority Async Compute). > On platforms that support it (in firmware), it is necessary to > describe that link, or Adreno register access will hang the board. > > Add that and fix up

Re: [PATCH 3/3] drm/virtio: implement debug name via CONTEXT_INIT

2023-10-16 Thread Josh Simonot
Reviewed-by: Josh Simonot On Mon, 16 Oct 2023 at 14:42, Gurchetan Singh wrote: > This allows setting the debug name during CONTEXT_INIT. > > Signed-off-by: Gurchetan Singh > --- > drivers/gpu/drm/virtio/virtgpu_drv.h | 4 +++ > drivers/gpu/drm/virtio/virtgpu_ioctl.c | 38

Re: [PATCH 2/7] drm/msm/adreno: Add ZAP firmware name to A635

2023-10-16 Thread Akhil P Oommen
On Tue, Sep 26, 2023 at 08:24:37PM +0200, Konrad Dybcio wrote: > > Some (many?) devices with A635 expect a ZAP shader to be loaded. > > Set the file name to allow for that. > > Signed-off-by: Konrad Dybcio > --- > drivers/gpu/drm/msm/adreno/adreno_device.c | 1 + > 1 file changed, 1

Re: [PATCH 2/3] drm/uapi: add explicit virtgpu context debug name

2023-10-16 Thread Josh Simonot
Reviewed-by: Josh Simonot On Mon, 16 Oct 2023 at 14:42, Gurchetan Singh wrote: > There are two problems with the current method of determining the > virtio-gpu debug name. > > 1) TASK_COMM_LEN is defined to be 16 bytes only, and this is a >Linux kernel idiom (see PR_SET_NAME +

Re: [PATCH 1/3] drm/virtio: use uint64_t more in virtio_gpu_context_init_ioctl

2023-10-16 Thread Josh Simonot
Reviewed-by: Josh Simonot On Mon, 16 Oct 2023 at 14:42, Gurchetan Singh wrote: > drm_virtgpu_context_set_param defines both param and > value to be u64s. > > Signed-off-by: Gurchetan Singh > --- > drivers/gpu/drm/virtio/virtgpu_ioctl.c | 4 ++-- > 1 file changed, 2 insertions(+), 2

[PATCH] drm/i915/mtl: avoid stringop-overflow warning

2023-10-16 Thread Arnd Bergmann
From: Arnd Bergmann The newly added memset() causes a warning for some reason I could not figure out: In file included from arch/x86/include/asm/string.h:3, from drivers/gpu/drm/i915/gt/intel_rc6.c:6: In function 'rc6_res_reg_init', inlined from 'intel_rc6_init' at

[PATCH] fbdev: sa1100fb: mark sa1100fb_init() static

2023-10-16 Thread Arnd Bergmann
From: Arnd Bergmann This is a global function that is only referenced as an initcall. This causes a warning: drivers/video/fbdev/sa1100fb.c:1218:12: error: no previous prototype for 'sa1100fb_init' [-Werror=missing-prototypes] Make it static instead. Signed-off-by: Arnd Bergmann ---

[PATCH] drm/msm/a6xx: add QMP dependency

2023-10-16 Thread Arnd Bergmann
From: Arnd Bergmann When QMP is in a loadable module, the A6xx GPU driver fails to link as built-in: x86_64-linux-ld: drivers/gpu/drm/msm/adreno/a6xx_gmu.o: in function `a6xx_gmu_resume': a6xx_gmu.c:(.text+0xd62): undefined reference to `qmp_send' Add the usual dependency that still allows

Re: [PATCH 1/7] drm/msm/a6xx: Fix unknown speedbin case

2023-10-16 Thread Akhil P Oommen
On Tue, Sep 26, 2023 at 08:24:36PM +0200, Konrad Dybcio wrote: > > When opp-supported-hw is present under an OPP node, but no form of > opp_set_supported_hw() has been called, that OPP is ignored by the API > and marked as unsupported. > > Before Commit c928a05e4415 ("drm/msm/adreno: Move

Re: [PATCH v1] dt-bindings: backlight: add brightness-levels related common properties

2023-10-16 Thread Krzysztof Kozlowski
On 16/10/2023 17:05, Flavio Suligoi wrote: > Both files pwm-backlight.yaml and led-backlight.yaml contain properties > in common with each other, regarding the brightness levels: > > - brightness-levels > - default-brightness-level > > These properties can then be moved to backlight/common.yaml.

[PATCH 3/3] drm/virtio: implement debug name via CONTEXT_INIT

2023-10-16 Thread Gurchetan Singh
This allows setting the debug name during CONTEXT_INIT. Signed-off-by: Gurchetan Singh --- drivers/gpu/drm/virtio/virtgpu_drv.h | 4 +++ drivers/gpu/drm/virtio/virtgpu_ioctl.c | 38 ++ 2 files changed, 36 insertions(+), 6 deletions(-) diff --git

[PATCH 2/3] drm/uapi: add explicit virtgpu context debug name

2023-10-16 Thread Gurchetan Singh
There are two problems with the current method of determining the virtio-gpu debug name. 1) TASK_COMM_LEN is defined to be 16 bytes only, and this is a Linux kernel idiom (see PR_SET_NAME + PR_GET_NAME). Though, Android/FreeBSD get around this via setprogname(..)/getprogname(..) in libc.

[PATCH 1/3] drm/virtio: use uint64_t more in virtio_gpu_context_init_ioctl

2023-10-16 Thread Gurchetan Singh
drm_virtgpu_context_set_param defines both param and value to be u64s. Signed-off-by: Gurchetan Singh --- drivers/gpu/drm/virtio/virtgpu_ioctl.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/virtio/virtgpu_ioctl.c

Re: [PATCH 3/5] drm/panel: st7703: Add Powkiddy RGB30 Panel Support

2023-10-16 Thread Chris Morgan
On Mon, Oct 16, 2023 at 08:18:25PM +0200, Heiko Stübner wrote: > Hi, > > Am Montag, 16. Oktober 2023, 18:07:52 CEST schrieb Dragan Simic: > > On 2023-10-16 17:52, Chris Morgan wrote: > > > Confirmed that those pending patches DO fix the panel suspend issues. > > > Thank you. > > > > Awesome,

Re: [PATCH 3/5] drm/panel: st7703: Add Powkiddy RGB30 Panel Support

2023-10-16 Thread Heiko Stübner
Hi, Am Montag, 16. Oktober 2023, 18:07:52 CEST schrieb Dragan Simic: > On 2023-10-16 17:52, Chris Morgan wrote: > > Confirmed that those pending patches DO fix the panel suspend issues. > > Thank you. > > Awesome, that's great to hear! Perhaps a "Tested-by" in the original > LKML thread [1]

Re: [PATCH 5/9] drm/bridge: synopsys: dw-mipi-dsi: Use pixel clock rate to calculate lbcc

2023-10-16 Thread Heiko Stübner
Hi, Am Montag, 17. Juli 2023, 08:18:27 CEST schrieb Liu Ying: > To get better accuration, use pixel clock rate to calculate lbcc instead of > lane_mbps since the pixel clock rate is in KHz while lane_mbps is in MHz. > Without this, distorted image can be seen on a HDMI monitor connected with >

Re: [Intel-gfx] [PATCH] drm/i915/gem: Allow users to disable waitboost

2023-10-16 Thread Rodrigo Vivi
On Mon, Oct 16, 2023 at 09:02:38AM +0100, Tvrtko Ursulin wrote: > > On 13/10/2023 21:51, Rodrigo Vivi wrote: > > On Thu, Sep 28, 2023 at 01:48:34PM +0100, Tvrtko Ursulin wrote: > > > > > > On 27/09/2023 20:34, Belgaumkar, Vinay wrote: > > > > > > > > On 9/21/2023 3:41 AM, Tvrtko Ursulin wrote:

[PATCH v2 2/2] accel/qaic: Support MHI QAIC_TIMESYNC channel

2023-10-16 Thread Jeffrey Hugo
From: Pranjal Ramajor Asha Kanojiya Use QAIC_TIMESYNC MHI channel to send UTC time to device in SBL environment. Remove support for QAIC_TIMESYNC MHI channel in AMSS environment as it is not used in that environment. Signed-off-by: Pranjal Ramajor Asha Kanojiya Reviewed-by: Jeffrey Hugo

[PATCH v2 1/2] accel/qaic: Add support for periodic timesync

2023-10-16 Thread Jeffrey Hugo
From: Ajit Pal Singh Device and Host have a time synchronization mechanism that happens once during boot when device is in SBL mode. After that, in mission-mode there is no timesync. In an experiment after continuous operation, device time drifted w.r.t. host by approximately 3 seconds per day.

[PATCH v2 0/2] accel/qaic: Add support for host/device timesync

2023-10-16 Thread Jeffrey Hugo
AIC100 supports a timesync mechanism that allows AIC100 to timestamp device logs with a host based time. This becomes useful for putting host logs in a unified timeline with device logs for debugging and performance profiling. The mechanism consists of a boot-time initialization and a runtime

[PATCH v2] accel/qaic: Enable 1 MSI fallback mode

2023-10-16 Thread Jeffrey Hugo
From: Carl Vanderlip Several virtualization use-cases either don't support 32 MultiMSIs (Xen/VMware) or have significant drawbacks to their use (KVM's vIOMMU, which is required to support 32 MSI, needs to allocate an alternate system memory space for each device using vIOMMU (e.g. 8GB VM mem and

[RFC PATCH 09/10] drm/bridge: lt9611uxc: implement automatic DSI power control

2023-10-16 Thread Dmitry Baryshkov
The Lontium LT9611UXC driver doesn't need to control DSI power lines manually. Mark it for automatic power control. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/bridge/lontium-lt9611uxc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[RFC PATCH 08/10] drm/bridge: lt9611: mark for automatic DSI power control

2023-10-16 Thread Dmitry Baryshkov
The Lontium LT9611 driver doesn't need to control DSI power lines manually. Mark it for automatic power control. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/bridge/lontium-lt9611.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[RFC PATCH 10/10] drm/msm/dsi: drop (again) the ps8640 workaround

2023-10-16 Thread Dmitry Baryshkov
Now as the Parade PS8640 driver sets the MIPI_DSI_MANUAL_POWERUP flag, drop the workaround enforcing the late DSI link powerup in the case the next bridge is ps8640. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/dsi/dsi_manager.c | 20 1 file changed, 20

[RFC PATCH 07/10] drm/bridge: ps8640: require manual DSI power control

2023-10-16 Thread Dmitry Baryshkov
The Parade PS8640 bridge will fail to start if the DSI link is enabled when the bridge is being reset / powered up (even to the LP-11 state). To ensure that the DSI link is powered down, require manual control over the DSI link state. Signed-off-by: Dmitry Baryshkov ---

[RFC PATCH 04/10] drm/msm/dsi: use dsi_mgr_bridge_power_off in dsi_mgr_bridge_post_disable

2023-10-16 Thread Dmitry Baryshkov
Simplify dsi_mgr_bridge_post_disable() by using dsi_mgr_bridge_power_off() instead of hand-coding the same call sequence. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/dsi/dsi_manager.c | 24 +--- 1 file changed, 5 insertions(+), 19 deletions(-) diff --git

[RFC PATCH 06/10] drm/bridge: tc358762: add support for manual DSI power control

2023-10-16 Thread Dmitry Baryshkov
Start migrating tc358762 bridge to new manual DSI power control API. If the tight power control is not available, default to the existing pre_enable_prev_first flag. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/bridge/tc358762.c | 15 ++- 1 file changed, 14 insertions(+), 1

[RFC PATCH 02/10] drm/mipi-dsi: document DSI hosts limitations

2023-10-16 Thread Dmitry Baryshkov
Document the known limititations of the DSI hosts vs commands transfers in LP mode. For the details see sun6i_dsi_encoder_enable(). Signed-off-by: Dmitry Baryshkov --- include/drm/drm_mipi_dsi.h | 4 1 file changed, 4 insertions(+) diff --git a/include/drm/drm_mipi_dsi.h

[RFC PATCH 05/10] drm/msm/dsi: implement manual power control

2023-10-16 Thread Dmitry Baryshkov
Implement new API for tight control over the DSI link's power state. This allows bridge and panel drivers to send DSI commands at a proper time. Note, this also brings back the ps8640 workaround (to be removed later, once ps8640 driver sets up the MIPI_DSI_MANUAL_POWERUP flag).. We have to make

[RFC PATCH 03/10] drm/mipi-dsi: add API for manual control over the DSI link power state

2023-10-16 Thread Dmitry Baryshkov
The MIPI DSI links do not fully fall into the DRM callbacks model. The drm_bridge_funcs abstraction. Instead of having just two states (off and on) the DSI hosts have separate LP-11 state. In this state the host is on, but the video stream is not yet enabled. Introduce API that allows DSI bridges

[RFC PATCH 01/10] Revert "drm/bridge: tc358762: Split register programming from pre-enable to enable"

2023-10-16 Thread Dmitry Baryshkov
It has been pointed out (e.g. in [1]) that enable is not the best place for sending the DSI commands. There are hosts (sunxi) that can not support sending DSI commands once video stream has enabled. Also most panel drivers send DSI commands in the prepare() callback (which maps to

[RFC PATCH 00/10] drm/mipi-dsi: another attempt at sorting out DSI link powerup

2023-10-16 Thread Dmitry Baryshkov
It is well known that DSI dosn't fully fit into the DRM enable/disable model thanks to the intermediate LP-11 state: (roughly) the link is already up, but the video stream is not yet enabled. Previously we have handled this by forcing DSI link powerup in the mode_set callback. This worked, but it

Re: [PATCH 3/5] drm/panel: st7703: Add Powkiddy RGB30 Panel Support

2023-10-16 Thread Dragan Simic
On 2023-10-16 17:52, Chris Morgan wrote: Confirmed that those pending patches DO fix the panel suspend issues. Thank you. Awesome, that's great to hear! Perhaps a "Tested-by" in the original LKML thread [1] could help with having the patch pulled sooner. Links: [1]

Re: [PATCH v4 1/4] drm/format-helper: Export line conversion helper for drm_panic

2023-10-16 Thread Jocelyn Falempe
On 16/10/2023 12:47, Thomas Zimmermann wrote: Hi Am 03.10.23 um 16:22 schrieb Jocelyn Falempe: drm_panic will need the low-level drm_fb__line functions. It seems like premature optimization to not use drm_fb_blit(); especially since drm_panic is not performance critical. Also add

Re: [PATCH v7 15/16] dt-bindings: display: mediatek: split: add compatible for MT8195

2023-10-16 Thread Krzysztof Kozlowski
On 12/10/2023 10:40, Moudy Ho wrote: > Add compatible string and GCE property for MT8195 SPLIT, of > which is operated by MDP3. > > Signed-off-by: Moudy Ho > --- After feedback from Angelo: Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH v7 15/16] dt-bindings: display: mediatek: split: add compatible for MT8195

2023-10-16 Thread Krzysztof Kozlowski
On 16/10/2023 10:01, AngeloGioacchino Del Regno wrote: > Il 13/10/23 08:52, Krzysztof Kozlowski ha scritto: >> On 12/10/2023 10:40, Moudy Ho wrote: >>> Add compatible string and GCE property for MT8195 SPLIT, of >>> which is operated by MDP3. >>> >>> Signed-off-by: Moudy Ho >> >> >>> +allOf: >>>

Re: [PATCH 3/5] drm/panel: st7703: Add Powkiddy RGB30 Panel Support

2023-10-16 Thread Chris Morgan
Confirmed that those pending patches DO fix the panel suspend issues. Thank you. On Mon, Oct 16, 2023 at 3:41 AM Guido Günther wrote: > > Hi Chris, > On Fri, Oct 13, 2023 at 01:39:16PM -0500, Chris Morgan wrote: > > From: Chris Morgan > > > > The Powkiddy RGB30 4 inch panel is a 4 inch 720x720

Re: [PATCH v5 5/7] drm/sched: Split free_job into own work item

2023-10-16 Thread Luben Tuikov
On 2023-10-16 11:29, Luben Tuikov wrote: > On 2023-10-16 11:12, Matthew Brost wrote: >> On Sat, Oct 14, 2023 at 08:09:31PM -0400, Luben Tuikov wrote: >>> On 2023-10-13 22:49, Luben Tuikov wrote: On 2023-10-11 19:58, Matthew Brost wrote: > Rather than call free_job and run_job in same work

Re: [PATCH v5 5/7] drm/sched: Split free_job into own work item

2023-10-16 Thread Luben Tuikov
On 2023-10-16 11:12, Matthew Brost wrote: > On Sat, Oct 14, 2023 at 08:09:31PM -0400, Luben Tuikov wrote: >> On 2023-10-13 22:49, Luben Tuikov wrote: >>> On 2023-10-11 19:58, Matthew Brost wrote: Rather than call free_job and run_job in same work item have a dedicated work item for each.

Re: [PATCH v5 3/7] drm/sched: Move schedule policy to scheduler

2023-10-16 Thread Luben Tuikov
On 2023-10-16 11:08, Matthew Brost wrote: > On Fri, Oct 13, 2023 at 01:45:08PM -0400, Luben Tuikov wrote: >> On 2023-10-11 19:58, Matthew Brost wrote: >>> Rather than a global modparam for scheduling policy, move the scheduling >>> policy to scheduler so user can control each scheduler policy. >>>

Re: [PATCH v5 6/7] drm/sched: Add drm_sched_start_timeout_unlocked helper

2023-10-16 Thread Luben Tuikov
On 2023-10-16 10:57, Matthew Brost wrote: > On Fri, Oct 13, 2023 at 10:52:22PM -0400, Luben Tuikov wrote: >> On 2023-10-11 19:58, Matthew Brost wrote: >>> Also add a lockdep assert to drm_sched_start_timeout. >>> >>> Signed-off-by: Matthew Brost >>> Reviewed-by: Luben Tuikov >> >> I don't

Re: [PATCH v5 5/7] drm/sched: Split free_job into own work item

2023-10-16 Thread Matthew Brost
On Sat, Oct 14, 2023 at 08:09:31PM -0400, Luben Tuikov wrote: > On 2023-10-13 22:49, Luben Tuikov wrote: > > On 2023-10-11 19:58, Matthew Brost wrote: > >> Rather than call free_job and run_job in same work item have a dedicated > >> work item for each. This aligns with the design and intended use

Re: [PATCH v1] dynamic_debug: add support for logs destination

2023-10-16 Thread Łukasz Bartosik
czw., 12 paź 2023 o 20:48 napisał(a): > > > If you want the kernel to keep separate flight recorders I guess we could > > add that, but I don't think it currently exists for the dyndbg stuff at > > least. Maybe a flight recorder v2 feature, once the basics are in. > > > > dyndbg has +p

Re: [PATCH v5 3/7] drm/sched: Move schedule policy to scheduler

2023-10-16 Thread Matthew Brost
On Fri, Oct 13, 2023 at 01:45:08PM -0400, Luben Tuikov wrote: > On 2023-10-11 19:58, Matthew Brost wrote: > > Rather than a global modparam for scheduling policy, move the scheduling > > policy to scheduler so user can control each scheduler policy. > > > > v2: > > -

Re: [PATCH v5 4/7] drm/sched: Add DRM_SCHED_POLICY_SINGLE_ENTITY scheduling policy

2023-10-16 Thread Luben Tuikov
On 2023-10-16 11:00, Matthew Brost wrote: > On Fri, Oct 13, 2023 at 10:06:18PM -0400, Luben Tuikov wrote: >> On 2023-10-11 19:58, Matthew Brost wrote: >>> DRM_SCHED_POLICY_SINGLE_ENTITY creates a 1 to 1 relationship between >>> scheduler and entity. No priorities or run queue used in this mode.

Re: [PATCH v6 6/6] drm/doc: Define KMS atomic state set

2023-10-16 Thread Ville Syrjälä
On Mon, Oct 16, 2023 at 05:52:22PM +0300, Pekka Paalanen wrote: > On Mon, 16 Oct 2023 15:42:16 +0200 > André Almeida wrote: > > > Hi Pekka, > > > > On 10/16/23 14:18, Pekka Paalanen wrote: > > > On Mon, 16 Oct 2023 12:52:32 +0200 > > > André Almeida wrote: > > > > > >> Hi Michel, > > >> > >

[PATCH v1] dt-bindings: backlight: add brightness-levels related common properties

2023-10-16 Thread Flavio Suligoi
Both files pwm-backlight.yaml and led-backlight.yaml contain properties in common with each other, regarding the brightness levels: - brightness-levels - default-brightness-level These properties can then be moved to backlight/common.yaml. Signed-off-by: Flavio Suligoi ---

Re: [PATCH v5 7/7] drm/sched: Add helper to queue TDR immediately for current and future jobs

2023-10-16 Thread Matthew Brost
On Fri, Oct 13, 2023 at 11:04:47PM -0400, Luben Tuikov wrote: > On 2023-10-11 19:58, Matthew Brost wrote: > > Add helper to queue TDR immediately for current and future jobs. This is > > used in Xe, a new Intel GPU driver, to trigger a TDR to cleanup a > > drm_scheduler that encounter errors. > >

Re: [PATCH v5 4/7] drm/sched: Add DRM_SCHED_POLICY_SINGLE_ENTITY scheduling policy

2023-10-16 Thread Matthew Brost
On Fri, Oct 13, 2023 at 10:06:18PM -0400, Luben Tuikov wrote: > On 2023-10-11 19:58, Matthew Brost wrote: > > DRM_SCHED_POLICY_SINGLE_ENTITY creates a 1 to 1 relationship between > > scheduler and entity. No priorities or run queue used in this mode. > > Intended for devices with firmware

Re: [PATCH v1] dynamic_debug: add support for logs destination

2023-10-16 Thread Steven Rostedt
On Thu, 12 Oct 2023 11:53:52 +0200 Daniel Vetter wrote: > > You said that turning the kernel ring buffer contents into strings is a > > very heavy operation, so it is not possible to push this scope > > separation to userspace, right? > > I think it's the kernel that does the formatting, but

Re: [PATCH v6 6/6] drm/doc: Define KMS atomic state set

2023-10-16 Thread André Almeida
On 10/16/23 16:52, Pekka Paalanen wrote: On Mon, 16 Oct 2023 15:42:16 +0200 André Almeida wrote: Hi Pekka, On 10/16/23 14:18, Pekka Paalanen wrote: On Mon, 16 Oct 2023 12:52:32 +0200 André Almeida wrote: Hi Michel, On 8/17/23 12:37, Michel Dänzer wrote: On 8/15/23 20:57, André

Re: [PATCH v5 6/7] drm/sched: Add drm_sched_start_timeout_unlocked helper

2023-10-16 Thread Matthew Brost
On Fri, Oct 13, 2023 at 10:52:22PM -0400, Luben Tuikov wrote: > On 2023-10-11 19:58, Matthew Brost wrote: > > Also add a lockdep assert to drm_sched_start_timeout. > > > > Signed-off-by: Matthew Brost > > Reviewed-by: Luben Tuikov > > I don't remember sending a Reviewed-by email to this patch.

[PATCH 6.5 123/191] drm/tiny: correctly print `struct resource *` on error

2023-10-16 Thread Greg Kroah-Hartman
6.5-stable review patch. If anyone has any objections, please let me know. -- From: Joey Gouly commit c1165df2be2fffe3adeeaa68f4ee4325108c5e4e upstream. The `res` variable is already a `struct resource *`, don't take the address of it. Fixes incorrect output:

Re: [PATCH v6 6/6] drm/doc: Define KMS atomic state set

2023-10-16 Thread Pekka Paalanen
On Mon, 16 Oct 2023 15:42:16 +0200 André Almeida wrote: > Hi Pekka, > > On 10/16/23 14:18, Pekka Paalanen wrote: > > On Mon, 16 Oct 2023 12:52:32 +0200 > > André Almeida wrote: > > > >> Hi Michel, > >> > >> On 8/17/23 12:37, Michel Dänzer wrote: > >>> On 8/15/23 20:57, André Almeida wrote:

[PATCH 2/2] drm: introduce CLOSEFB IOCTL

2023-10-16 Thread Simon Ser
This new IOCTL allows callers to close a framebuffer without disabling planes or CRTCs. This takes inspiration from Rob Clark's unref_fb IOCTL [1] and DRM_MODE_FB_PERSIST [2]. User-space patch for wlroots available at [3]. IGT test available at [4]. [1]:

[PATCH 1/2] drm: extract closefb logic in separate function

2023-10-16 Thread Simon Ser
drm_mode_rmfb performs two operations: drop the FB from the file_priv->fbs list, and make sure the FB is no longer used on a plane. In the next commit an IOCTL which only does so former will be introduced, so let's split it into a separate function. No functional change, only refactoring.

Re: [PATCH] drm/rockchip: Fix type promotion bug in rockchip_gem_iommu_map()

2023-10-16 Thread Heiko Stuebner
On Wed, 11 Oct 2023 11:01:48 +0300, Dan Carpenter wrote: > The "ret" variable is declared as ssize_t and it can hold negative error > codes but the "rk_obj->base.size" variable is type size_t. This means > that when we compare them, they are both type promoted to size_t and the > negative error

Re: (subset) [PATCH v2 0/4] Some cleanup of vop2 driver

2023-10-16 Thread Heiko Stuebner
On Fri, 13 Oct 2023 20:20:01 +0800, Andy Yan wrote: > From: Andy Yan > > This is a preparation for the upcoming support for rk3588 vop. > Patch 1 remove unused struct > Patch 2 remove NR_LAYERS macro to support more layers on rk3588 > Patch 3 are plane format fix > Patch 4 is a format rename >

Re: [PATCH v6 6/6] drm/doc: Define KMS atomic state set

2023-10-16 Thread André Almeida
Hi Pekka, On 10/16/23 14:18, Pekka Paalanen wrote: On Mon, 16 Oct 2023 12:52:32 +0200 André Almeida wrote: Hi Michel, On 8/17/23 12:37, Michel Dänzer wrote: On 8/15/23 20:57, André Almeida wrote: From: Pekka Paalanen Specify how the atomic state is maintained between userspace and

[Bug 218015] amdgpu powerplay: Spontaneous changes to power_dpm_force_performance_level

2023-10-16 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=218015 --- Comment #4 from Alex Deucher (alexdeuc...@gmail.com) --- UMDs (e.g., mesa) can change the power profile as well. E.g., if they want to capture an SQ trace, etc. It's likely that is the cause. -- You may reply to this email to add a

Re: BUG: KASAN: slab-use-after-free in drm_connector_cleanup

2023-10-16 Thread Dan Carpenter
If I had to guess, I'd say it's an issue in the vc4_mock driver. It's crashing somewhere in Subtest: drm_vc4_test_pv_muxing. regards, dan carpenter On Fri, Oct 13, 2023 at 11:44:32PM +0530, Naresh Kamboju wrote: > Following kasan bug was noticed on arm64 bcm2711-rpi-4-b device running > Linux

Re: [PATCH v5 0/4] Improve test coverage of TTM

2023-10-16 Thread Somalapuram, Amaranath
On 10/16/2023 2:22 PM, Karolina Stolarek wrote: Add tests for building blocks of the TTM subsystem, such as ttm_resource, ttm_resource_manager, ttm_tt and ttm_buffer_object. This series covers basic functions such as initialization, allocation and clean-up of each struct. Testing of

Re: [PATCH 4/5] dt-bindings: arm64: rockchip: add Powkiddy RGB30

2023-10-16 Thread Krzysztof Kozlowski
On 13/10/2023 20:39, Chris Morgan wrote: > From: Chris Morgan > > The Powkiddy RGB30 is a portable handheld console from Powkiddy which > uses the Rockchip RK3566 SoC. > Acked-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH 2/5] dt-bindings: panel: Add Powkiddy RGB30 panel compatible

2023-10-16 Thread Krzysztof Kozlowski
On 13/10/2023 20:39, Chris Morgan wrote: > From: Chris Morgan > > The Powkiddy RGB30 panel is a 4 inch 720x720 MIPI-DSI LCD panel. It > appears to be based on the ST7703 LCD controller (this is assumed from > the init sequence similarity between this and other displays). Powkiddy > would not

Re: [PATCH] drm/ttm: Reorder sys manager cleanup step

2023-10-16 Thread Christian König
Am 16.10.23 um 14:15 schrieb Karolina Stolarek: With the current cleanup flow, we could trigger a NULL pointer dereference if there is a delayed destruction of a BO with a system resource that gets executed on drain_workqueue() call, as we attempt to free a resource using an already released

Re: [PATCH 1/5] dt-bindings: vendor-prefixes: document Powkiddy

2023-10-16 Thread Krzysztof Kozlowski
On 13/10/2023 20:39, Chris Morgan wrote: > From: Chris Morgan > > Document Powkiddy (https://powkiddy.com/). > > Signed-off-by: Chris Morgan > --- Acked-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH v6 6/6] drm/doc: Define KMS atomic state set

2023-10-16 Thread Pekka Paalanen
On Mon, 16 Oct 2023 12:52:32 +0200 André Almeida wrote: > Hi Michel, > > On 8/17/23 12:37, Michel Dänzer wrote: > > On 8/15/23 20:57, André Almeida wrote: > >> From: Pekka Paalanen > >> > >> Specify how the atomic state is maintained between userspace and > >> kernel, plus the special case

[PATCH] drm/ttm: Reorder sys manager cleanup step

2023-10-16 Thread Karolina Stolarek
With the current cleanup flow, we could trigger a NULL pointer dereference if there is a delayed destruction of a BO with a system resource that gets executed on drain_workqueue() call, as we attempt to free a resource using an already released resource manager. Remove the device from the device

Re: [PATCH v10 4/7] drm: bridge: Cadence: Add MHDP8501 DP/HDMI driver

2023-10-16 Thread Krzysztof Kozlowski
On 13/10/2023 05:24, Sandor Yu wrote: > Add a new DRM DisplayPort and HDMI bridge driver for Candence MHDP8501 > used in i.MX8MQ SOC. MHDP8501 could support HDMI or DisplayPort > standards according embedded Firmware running in the uCPU. ... > + > +static struct platform_driver

  1   2   >