[Bug 219492] amdgpu: failed to write reg 28b4 wait reg 28c6 and amdgpu: failed to write reg 1a6f4 wait reg 1a706

2024-11-11 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=219492 Shubhra Prakash Nandi (email2shub...@gmail.com) changed: What|Removed |Added Kernel Version||6.6.x an

[Bug 219492] New: amdgpu: failed to write reg 28b4 wait reg 28c6 and amdgpu: failed to write reg 1a6f4 wait reg 1a706

2024-11-11 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=219492 Bug ID: 219492 Summary: amdgpu: failed to write reg 28b4 wait reg 28c6 and amdgpu: failed to write reg 1a6f4 wait reg 1a706 Product: Drivers Version: 2.5 Hardware: AMD

[PATCH v4 resend] drm/meson: switch to a managed drm device

2024-11-11 Thread Anastasia Belova
Switch to a managed drm device to cleanup some error handling and make future work easier. Fix dereference of NULL in meson_drv_bind_master by removing drm_dev_put(drm) before meson_encoder_*_remove and component_unbind_all where drm is dereferenced. Co-developed by Linux Verification Center (lin

Re: [PATCH V9 07/10] accel/amdxdna: Add command execution

2024-11-11 Thread Matthew Brost
On Mon, Nov 11, 2024 at 10:17:08AM -0800, Lizhi Hou wrote: > Add interfaces for user application to submit command and wait for its > completion. > > Co-developed-by: Min Ma > Signed-off-by: Min Ma > Signed-off-by: Lizhi Hou > --- > drivers/accel/amdxdna/aie2_ctx.c | 607 +

Re: [PATCH v2 2/2] drm/bridge: tc358767: Improve DPI output pixel clock accuracy

2024-11-11 Thread Laurent Pinchart
Hi Marek, Thank you for the patch. On Tue, Nov 12, 2024 at 03:05:37AM +0100, Marek Vasut wrote: > The Pixel PLL is not very capable and may come up with wildly inaccurate > clock. Since DPI panels are often tolerant to slightly higher pixel clock > without being operated outside of specification,

Re: [PATCH next] drm: zynqmp_dp: Unlock on error in zynqmp_dp_bridge_atomic_enable()

2024-11-11 Thread Laurent Pinchart
Hi Dan, Thank you for the patch. On Mon, Nov 11, 2024 at 12:06:10PM +0300, Dan Carpenter wrote: > We added some locking to this function, but accidentally forgot to unlock > if zynqmp_dp_mode_configure() failed. Use a guard lock to fix it. > > Fixes: a7d5eeaa57d7 ("drm: zynqmp_dp: Add locking")

Re: [RFC PATCH v1 00/10] mm: Introduce and use folio_owner_ops

2024-11-11 Thread Matthew Wilcox
On Mon, Nov 11, 2024 at 08:26:54AM +, Fuad Tabba wrote: > Thanks for your comments Jason, and for clarifying my cover letter > David. I think David has covered everything, and I'll make sure to > clarify this in the cover letter when I respin. I don't want you to respin. I think this is a bad

Re: [PATCH] Documentation/CoC: spell out enforcement for unacceptable behaviors

2024-11-11 Thread Laurent Pinchart
On Mon, Nov 11, 2024 at 05:35:11PM -0700, Shuah Khan wrote: > On 11/11/24 15:35, Laurent Pinchart wrote: > > On Mon, Nov 11, 2024 at 02:50:45PM -0700, Shuah Khan wrote: > >> On 11/11/24 13:07, Simona Vetter wrote: > >>> On Fri, Nov 08, 2024 at 09:18:53AM -0700, Shuah Khan wrote: > The Code of

Re: [PATCH v2 RESEND 1/3] dmaengine: qcom: gpi: Add GPI Block event interrupt support

2024-11-11 Thread Bjorn Andersson
On Mon, Nov 11, 2024 at 07:32:42PM +0530, Jyothi Kumar Seerapu wrote: > GSI hardware generates an interrupt for each transfer completion. > For multiple messages within a single transfer, this results > in receiving N interrupts for N messages, which can introduce > significant software interrupt l

Re: [PATCH v2 RESEND 3/3] i2c: i2c-qcom-geni: Add Block event interrupt support

2024-11-11 Thread Bjorn Andersson
On Mon, Nov 11, 2024 at 07:32:44PM +0530, Jyothi Kumar Seerapu wrote: > The I2C driver gets an interrupt upon transfer completion. > For multiple messages in a single transfer, N interrupts will be > received for N messages, leading to significant software interrupt > latency. To mitigate this late

Re: [PATCH v2 RESEND 2/3] i2c: qcom_geni: Update compile dependenices for qcom geni

2024-11-11 Thread Bjorn Andersson
On Mon, Nov 11, 2024 at 07:32:43PM +0530, Jyothi Kumar Seerapu wrote: > I2C_QCOM_GENI is having compile dependencies on QCOM_GPI_DMA and > so update I2C_QCOM_GENI to depends on QCOM_GPI_DMA. > Given that this is a separate patch, your wording can only be interpreted as this being an existing prob

Re: [RFC PATCH 6/6 6.6] libfs: fix infinite directory reads for offset dir

2024-11-11 Thread yangerkun
在 2024/11/11 23:34, Chuck Lever III 写道: On Nov 11, 2024, at 10:20 AM, yangerkun wrote: 在 2024/11/11 22:39, Chuck Lever III 写道: On Nov 10, 2024, at 9:36 PM, Yu Kuai wrote: Hi, 在 2024/11/11 8:52, c...@kernel.org 写道: From: yangerkun [ Upstream commit 64a7ce76fb901bf9f9c36cf5d681328fc

Re: [PATCH v2] dt-bindings: display/msm: qcom,sa8775p-mdss: fix the example

2024-11-11 Thread Abhinav Kumar
On 11/11/2024 7:21 PM, Dmitry Baryshkov wrote: Add p1 region to the list of DP registers in the SA8775p example. This fixes the following warning: Documentation/devicetree/bindings/display/msm/qcom,sa8775p-mdss.example.dtb: displayport-controller@af54000: reg: [[183844864, 260], [183845376,

Re: [RFC PATCH 0/6] Common preempt fences and semantics

2024-11-11 Thread Matthew Brost
On Mon, Nov 11, 2024 at 02:42:02PM +0100, Christian König wrote: > Am 09.11.24 um 18:29 schrieb Matthew Brost: > > The motivation for this series comes from pending UMD submission work by > > AMD [1], ARM [3], and the Xe team, who are also beginning to look at > > this. Sima has suggested [4] some

[PATCH v2] dt-bindings: display/msm: qcom,sa8775p-mdss: fix the example

2024-11-11 Thread Dmitry Baryshkov
Add p1 region to the list of DP registers in the SA8775p example. This fixes the following warning: Documentation/devicetree/bindings/display/msm/qcom,sa8775p-mdss.example.dtb: displayport-controller@af54000: reg: [[183844864, 260], [183845376, 192], [183848960, 1904], [183853056, 156]] is too s

[PATCH] dt-bindings: display/msm: qcom,sa8775p-mdss: fix the example

2024-11-11 Thread Dmitry Baryshkov
Add p1 region to the list of DP registers in the SA8775p example. This fixes the following warning: Documentation/devicetree/bindings/display/msm/qcom,sa8775p-mdss.example.dtb: displayport-controller@af54000: reg: [[183844864, 260], [183845376, 192], [183848960, 1904], [183853056, 156]] is too s

Re: [PATCH v4 15/18] dt-bindings: usb: Add ports to google,cros-ec-typec for DP altmode

2024-11-11 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2024-11-08 23:05:18) > On Thu, Nov 07, 2024 at 04:28:24PM -0800, Stephen Boyd wrote: > > Quoting Dmitry Baryshkov (2024-10-31 15:54:49) > > > On Thu, Oct 31, 2024 at 02:45:29PM -0700, Stephen Boyd wrote: > > > > Quoting Dmitry Baryshkov (2024-10-31 11:42:36) > > > > > On T

[PATCH v2 2/2] drm/bridge: tc358767: Improve DPI output pixel clock accuracy

2024-11-11 Thread Marek Vasut
The Pixel PLL is not very capable and may come up with wildly inaccurate clock. Since DPI panels are often tolerant to slightly higher pixel clock without being operated outside of specification, calculate two Pixel PLL from either mode clock or display_timing .pixelclock.max , whichever is higher.

[PATCH v2 1/2] drm/bridge/panel: Add drm_bridge_get_panel to extract panel from last bridge

2024-11-11 Thread Marek Vasut
Add drm_bridge_get_panel() function to extract drm_panel pointer from panel_bridge. This can be used by bridges in the middle to look up and access drm_panel at the end, and e.g. extract display_timings from it. Signed-off-by: Marek Vasut --- Cc: Andrzej Hajda Cc: David Airlie Cc: Jernej Skrabe

Re: [PATCH] Documentation/CoC: spell out enforcement for unacceptable behaviors

2024-11-11 Thread Shuah Khan
On 11/11/24 15:35, Laurent Pinchart wrote: Hi Shuah, On Mon, Nov 11, 2024 at 02:50:45PM -0700, Shuah Khan wrote: On 11/11/24 13:07, Simona Vetter wrote: On Fri, Nov 08, 2024 at 09:18:53AM -0700, Shuah Khan wrote: The Code of Conduct committee's goal first and foremost is to bring about change

[PATCH 2/2] drm/amd/pm: Remove redundant check

2024-11-11 Thread Bhavin Sharma
The check for tools_size being non-zero is redundant as tools_size is explicitly set to a non-zero value (0x19000). Removing the if condition simplifies the code without altering functionality. Signed-off-by: Bhavin Sharma --- .../amd/pm/powerplay/smumgr/vega12_smumgr.c | 24 +---

[PATCH 1/2] drm/amd/display: Remove redundant check

2024-11-11 Thread Bhavin Sharma
The mode_422 variable is initialized to zero, making mode_422 ? 2 : 1 always false. Since is_dsc_possible is already checked just above, there's no need to check it again before filling out the DSC settings. Removing this redundant check simplifies the code without affecting functionality. Signe

Re: [RFC PATCH 6/6 6.6] libfs: fix infinite directory reads for offset dir

2024-11-11 Thread yangerkun
在 2024/11/11 22:39, Chuck Lever III 写道: On Nov 10, 2024, at 9:36 PM, Yu Kuai wrote: Hi, 在 2024/11/11 8:52, c...@kernel.org 写道: From: yangerkun [ Upstream commit 64a7ce76fb901bf9f9c36cf5d681328fc0fd4b5a ] After we switch tmpfs dir operations from simple_dir_operations to simple_offset_d

[PATCH 0/2] Remove redundant condition check

2024-11-11 Thread Bhavin Sharma
Bhavin Sharma (2): drm: amd: display: Remove redundant check drm: amd: pm: Remove redundant check .../display/dc/dml/dml1_display_rq_dlg_calc.c | 2 +- drivers/gpu/drm/amd/display/dc/dsc/dc_dsc.c | 13 -- .../amd/pm/powerplay/smumgr/vega12_smumgr.c | 24 +-- 3 fil

Re: [PATCH 1/7] kernel/cgroup: Add "dev" memory accounting cgroup

2024-11-11 Thread Maarten Lankhorst
Den 2024-10-28 kl. 15:53, skrev Friedrich Vock: On 23.10.24 09:52, Maarten Lankhorst wrote: The initial version was based roughly on the rdma and misc cgroup controllers, with a lot of the accounting code borrowed from rdma. The current version is a complete rewrite with page counter; it use

Re: [PATCH v6 2/8] drm/ttm: Add ttm_bo_access

2024-11-11 Thread Matthew Brost
On Mon, Nov 11, 2024 at 04:54:57PM +0100, Christian König wrote: > Am 11.11.24 um 15:00 schrieb Joonas Lahtinen: > > Quoting Christian König (2024-11-11 13:34:12) > > > Am 11.11.24 um 11:10 schrieb Simona Vetter: > > > > On Mon, Nov 11, 2024 at 10:00:17AM +0200, Joonas Lahtinen wrote: > > > > > Bac

Re: [PATCH v2 RESEND 1/3] dmaengine: qcom: gpi: Add GPI Block event interrupt support

2024-11-11 Thread Andi Shyti
Ping, Vinod :-) Andi On Mon, Nov 11, 2024 at 07:32:42PM +0530, Jyothi Kumar Seerapu wrote: > GSI hardware generates an interrupt for each transfer completion. > For multiple messages within a single transfer, this results > in receiving N interrupts for N messages, which can introduce > significa

Re: [PATCH] Documentation/CoC: spell out enforcement for unacceptable behaviors

2024-11-11 Thread Laurent Pinchart
Hi Shuah, On Mon, Nov 11, 2024 at 02:50:45PM -0700, Shuah Khan wrote: > On 11/11/24 13:07, Simona Vetter wrote: > > On Fri, Nov 08, 2024 at 09:18:53AM -0700, Shuah Khan wrote: > >> The Code of Conduct committee's goal first and foremost is to bring about > >> change to ensure our community continu

Re: [PATCH] Documentation/CoC: spell out enforcement for unacceptable behaviors

2024-11-11 Thread Shuah Khan
On 11/11/24 13:07, Simona Vetter wrote: On Fri, Nov 08, 2024 at 09:18:53AM -0700, Shuah Khan wrote: The Code of Conduct committee's goal first and foremost is to bring about change to ensure our community continues to foster respectful discussions. In the interest of transparency, the CoC enfor

Re: [PATCH RESEND v9 2/2] drm/amdgpu: Enable async flip on overlay planes

2024-11-11 Thread Harry Wentland
On 2024-11-01 14:23, André Almeida wrote: > amdgpu can handle async flips on overlay planes, so allow it for atomic > async checks. > > Signed-off-by: André Almeida > --- > drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_plane.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff

Re: [RFC 1/1] SWDEV476969 - dm: Fail dm_atomic_check if cursor overlay is required at MAX_SURFACES

2024-11-11 Thread Melissa Wen
On 28/10/2024 16:04, Leo Li wrote: On 2024-10-25 22:01, Melissa Wen wrote: On 25/10/2024 16:37, Zaeem Mohamed wrote: [why] Prevent index-out-of-bounds due to requiring cursor overlay when plane_count is MAX_SURFACES. Hi Zaeem, Thanks for working on this fix. [how] Bounds check on

Re: [RFC PATCH 00/10] drm/panthor: Add user submission

2024-11-11 Thread Matthew Brost
On Mon, Nov 11, 2024 at 01:57:15PM +0100, Christian König wrote: > Am 08.11.24 um 23:27 schrieb Matthew Brost: > > On Tue, Sep 24, 2024 at 11:30:53AM +0200, Simona Vetter wrote: > > > Apologies for the late reply ... > > > > > Also late reply, just read this. > > > > > On Wed, Sep 04, 2024 at 01:

Re: [PATCH 06/10] mtd: intel-dg: wake card on operations

2024-11-11 Thread Miquel Raynal
Hi Alexander, Please reduce the context when answering, otherwise it's hard to find all places where you commented. >> > > > That's the part that I'm not sure if I agree. if I remember from some >> > > > experiments in the past, >> > > > when you call to wake up the child, the parent will wakeup

Re: [PATCH] Documentation/CoC: spell out enforcement for unacceptable behaviors

2024-11-11 Thread Simona Vetter
On Fri, Nov 08, 2024 at 09:18:53AM -0700, Shuah Khan wrote: > The Code of Conduct committee's goal first and foremost is to bring about > change to ensure our community continues to foster respectful discussions. > > In the interest of transparency, the CoC enforcement policy is formalized > for u

Re: [PATCH v2 00/10] mtd: add driver for Intel discrete graphics

2024-11-11 Thread Miquel Raynal
Hello Alexander, On 07/11/2024 at 15:13:46 +02, Alexander Usyskin wrote: > Add driver for access to Intel discrete graphics card > internal NVM device. > Expose device on auxiliary bus by i915 and Xe drivers and > provide mtd driver to register this device with MTD framework. > > This is a rewr

Re: drm/fbdev-dma: regression

2024-11-11 Thread Nuno Gonçalves
On Mon, Nov 11, 2024, 14:37 Thomas Zimmermann wrote: > Hi > > > Am 11.11.24 um 14:42 schrieb Nuno Gonçalves: > > On Mon, Nov 11, 2024 at 1:22 PM Thomas Zimmermann > wrote: > >> The patch in question changes the whole memory management of the > >> affected code. It's also noteworthy that most of

[PATCH V9 03/10] accel/amdxdna: Support hardware mailbox

2024-11-11 Thread Lizhi Hou
The hardware mailboxes are used by the driver to submit requests to firmware and receive the completion notices from hardware. Initially, a management mailbox channel is up and running. The driver may request firmware to create/destroy more channels dynamically through management channel. Add dri

[PATCH V9 08/10] accel/amdxdna: Add suspend and resume

2024-11-11 Thread Lizhi Hou
Implement PCI power management suspend and resume callbacks. Co-developed-by: Narendra Gutta Signed-off-by: Narendra Gutta Co-developed-by: Xiaoming Ren Signed-off-by: Xiaoming Ren Co-developed-by: Min Ma Signed-off-by: Min Ma Reviewed-by: Jeffrey Hugo Signed-off-by: Lizhi Hou --- drivers

[PATCH V9 05/10] accel/amdxdna: Add hardware context

2024-11-11 Thread Lizhi Hou
The hardware can be shared among multiple user applications. The hardware resources are allocated/freed based on the request from user application via driver IOCTLs. DRM_IOCTL_AMDXDNA_CREATE_HWCTX Allocate tile columns and create a hardware context structure to track the usage and status of the re

[PATCH V9 10/10] accel/amdxdna: Add query functions

2024-11-11 Thread Lizhi Hou
Add GET_INFO ioctl to retrieve hardware information, including AIE, clock, hardware context etc. Co-developed-by: Min Ma Signed-off-by: Min Ma Reviewed-by: Jeffrey Hugo Signed-off-by: Lizhi Hou --- drivers/accel/amdxdna/aie2_message.c| 65 +++ drivers/accel/amdxdna/aie2_pci.c

[PATCH V9 04/10] accel/amdxdna: Add hardware resource solver

2024-11-11 Thread Lizhi Hou
The AI Engine consists of 2D array of tiles arranged as columns. Provides the basic column allocation and release functions for the tile columns. Co-developed-by: Min Ma Signed-off-by: Min Ma Reviewed-by: Jeffrey Hugo Signed-off-by: Lizhi Hou --- drivers/accel/amdxdna/Makefile | 1

[PATCH V9 02/10] accel/amdxdna: Add a new driver for AMD AI Engine

2024-11-11 Thread Lizhi Hou
AMD AI Engine forms the core of AMD NPU and can be used for accelerating machine learning applications. Add the driver to support AI Engine integrated to AMD CPU. Only very basic functionalities are added. - module and PCI device initialization - firmware load - power up - low level hardwa

[PATCH V9 09/10] accel/amdxdna: Add error handling

2024-11-11 Thread Lizhi Hou
When there is a hardware error, the NPU firmware notifies the host through a mailbox message. The message includes details of the error, such as the tile and column indexes where the error occurred. The driver starts a thread to handle the NPU error message. The thread stops the clients which are

[PATCH V9 07/10] accel/amdxdna: Add command execution

2024-11-11 Thread Lizhi Hou
Add interfaces for user application to submit command and wait for its completion. Co-developed-by: Min Ma Signed-off-by: Min Ma Signed-off-by: Lizhi Hou --- drivers/accel/amdxdna/aie2_ctx.c | 607 +- drivers/accel/amdxdna/aie2_message.c | 343 ++

[PATCH V9 01/10] accel/amdxdna: Add documentation for AMD NPU accelerator driver

2024-11-11 Thread Lizhi Hou
AMD NPU (Neural Processing Unit) is a multi-user AI inference accelerator integrated into AMD client APU. NPU enables efficient execution of Machine Learning applications like CNN, LLM, etc. NPU is based on AMD XDNA Architecture. NPU is managed by amdxdna driver. Co-developed-by: Sonal Santan Sig

[PATCH V9 06/10] accel/amdxdna: Add GEM buffer object management

2024-11-11 Thread Lizhi Hou
There different types of BOs are supported: - shmem A user application uses shmem BOs as input/output for its workload running on NPU. - device memory heap The fixed size buffer dedicated to the device. - device buffer The buffer object allocated from device memory heap. - command buffer The bu

[PATCH V9 00/10] AMD XDNA driver

2024-11-11 Thread Lizhi Hou
This patchset introduces a new Linux Kernel Driver, amdxdna for AMD NPUs. The driver is based on Linux accel subsystem. NPU (Neural Processing Unit) is an AI inference accelerator integrated into AMD client CPUs. NPU enables efficient execution of Machine Learning applications like CNNs, LLMs, etc

Re: [PATCH V8 00/10] AMD XDNA driver

2024-11-11 Thread Lizhi Hou
Sorry, just noticed that I miss merged one line. Please ignore this V8 set. I will send out V9 instead. Lizhi On 11/11/24 09:32, Lizhi Hou wrote: This patchset introduces a new Linux Kernel Driver, amdxdna for AMD NPUs. The driver is based on Linux accel subsystem. NPU (Neural Processing Uni

[PATCH] drm/mediatek: Initialize pointer before use to avoid undefiend behaviour

2024-11-11 Thread Karan Sanghavi
422b750038123334f6ecc2 change-id: 2024-uninitializedpointer1601557-9803b725b6bd Best regards, -- Karan Sanghavi

[PATCH v7 2/4] drm/amd/display: Add support for minimum backlight quirk

2024-11-11 Thread Thomas Weißschuh
Not all platforms provide the full range of PWM backlight capabilities supported by the hardware through ATIF. Use the generic drm panel minimum backlight quirk infrastructure to override the capabilities where necessary. Testing the backlight quirk together with the "panel_power_savings" sysfs fi

[PATCH v7 4/4] drm: panel-backlight-quirks: Add Framework 13 glossy and 2.8k panels

2024-11-11 Thread Thomas Weißschuh
From: "Dustin L. Howett" I have tested these panels on the Framework Laptop 13 AMD with firmware revision 3.05 (latest at time of submission). Signed-off-by: Dustin L. Howett Signed-off-by: Thomas Weißschuh Reviewed-by: Mario Limonciello Reviewed-by: Harry Wentland --- drivers/gpu/drm/drm_p

[PATCH v7 1/4] drm: Add panel backlight quirks

2024-11-11 Thread Thomas Weißschuh
Panels using a PWM-controlled backlight source do not have a standard way to communicate their valid PWM ranges. On x86 the ranges are read from ACPI through driver-specific tables. The built-in ranges are not necessarily correct, or may grow stale if an older device can be retrofitted with newer p

[PATCH v7 3/4] drm: panel-backlight-quirks: Add Framework 13 matte panel

2024-11-11 Thread Thomas Weißschuh
The value of "min_input_signal" returned from ATIF on a Framework AMD 13 is "12". This leads to a fairly bright minimum display backlight. Add a quirk to override that the minimum backlight PWM to "0" which leads to a much lower minimum brightness, which is still visible. Tested on a Framework AM

[PATCH v7 0/4] drm: Minimum backlight overrides and implementation for amdgpu

2024-11-11 Thread Thomas Weißschuh
The value of "min_input_signal" returned from ATIF on a Framework AMD 13 is "12". This leads to a fairly bright minimum display backlight. Introduce a quirk to override "min_input_signal" to "0" which leads to a much lower minimum brightness, which is still readable even in daylight. One solution

Re: [PATCH v2 0/2] drm/msm/adreno: Setup SMMU aparture

2024-11-11 Thread Bjorn Andersson
On Sun, 10 Nov 2024 09:33:39 -0800, Bjorn Andersson wrote: > Support for per-page tables requires the SMMU aparture to be setup, on > some targets this is done statically in firmware, on others it's > expected to be requested in runtime by the driver, through a SCM call. > > Marking the series a

Re: [PATCH] drm/bridge: cdns-mhdp8546: Remove unused functions

2024-11-11 Thread Robert Foss
On Sun, 06 Oct 2024 00:20:17 +0100, li...@treblig.org wrote: > cdns_mhdp_hdcp_set_lc() and cdns_mhdp_hdcp_set_public_key_param() > were added by commit > 6a3608eae6d3 ("drm: bridge: cdns-mhdp8546: Enable HDCP") > but never used. > > Remove them. > > [...] Applied, thanks! [1/1] drm/bridge: cdns

[PATCH V8 08/10] accel/amdxdna: Add suspend and resume

2024-11-11 Thread Lizhi Hou
Implement PCI power management suspend and resume callbacks. Co-developed-by: Narendra Gutta Signed-off-by: Narendra Gutta Co-developed-by: Xiaoming Ren Signed-off-by: Xiaoming Ren Co-developed-by: Min Ma Signed-off-by: Min Ma Reviewed-by: Jeffrey Hugo Signed-off-by: Lizhi Hou --- drivers

[PATCH V8 10/10] accel/amdxdna: Add query functions

2024-11-11 Thread Lizhi Hou
Add GET_INFO ioctl to retrieve hardware information, including AIE, clock, hardware context etc. Co-developed-by: Min Ma Signed-off-by: Min Ma Reviewed-by: Jeffrey Hugo Signed-off-by: Lizhi Hou --- drivers/accel/amdxdna/aie2_message.c| 65 +++ drivers/accel/amdxdna/aie2_pci.c

[PATCH V8 02/10] accel/amdxdna: Add a new driver for AMD AI Engine

2024-11-11 Thread Lizhi Hou
AMD AI Engine forms the core of AMD NPU and can be used for accelerating machine learning applications. Add the driver to support AI Engine integrated to AMD CPU. Only very basic functionalities are added. - module and PCI device initialization - firmware load - power up - low level hardwa

[PATCH V8 06/10] accel/amdxdna: Add GEM buffer object management

2024-11-11 Thread Lizhi Hou
There different types of BOs are supported: - shmem A user application uses shmem BOs as input/output for its workload running on NPU. - device memory heap The fixed size buffer dedicated to the device. - device buffer The buffer object allocated from device memory heap. - command buffer The bu

[PATCH V8 09/10] accel/amdxdna: Add error handling

2024-11-11 Thread Lizhi Hou
When there is a hardware error, the NPU firmware notifies the host through a mailbox message. The message includes details of the error, such as the tile and column indexes where the error occurred. The driver starts a thread to handle the NPU error message. The thread stops the clients which are

[PATCH V8 07/10] accel/amdxdna: Add command execution

2024-11-11 Thread Lizhi Hou
Add interfaces for user application to submit command and wait for its completion. Co-developed-by: Min Ma Signed-off-by: Min Ma Signed-off-by: Lizhi Hou --- drivers/accel/amdxdna/aie2_ctx.c | 607 +- drivers/accel/amdxdna/aie2_message.c | 343 ++

[PATCH V8 04/10] accel/amdxdna: Add hardware resource solver

2024-11-11 Thread Lizhi Hou
The AI Engine consists of 2D array of tiles arranged as columns. Provides the basic column allocation and release functions for the tile columns. Co-developed-by: Min Ma Signed-off-by: Min Ma Reviewed-by: Jeffrey Hugo Signed-off-by: Lizhi Hou --- drivers/accel/amdxdna/Makefile | 1

[PATCH V8 05/10] accel/amdxdna: Add hardware context

2024-11-11 Thread Lizhi Hou
The hardware can be shared among multiple user applications. The hardware resources are allocated/freed based on the request from user application via driver IOCTLs. DRM_IOCTL_AMDXDNA_CREATE_HWCTX Allocate tile columns and create a hardware context structure to track the usage and status of the re

[PATCH V8 03/10] accel/amdxdna: Support hardware mailbox

2024-11-11 Thread Lizhi Hou
The hardware mailboxes are used by the driver to submit requests to firmware and receive the completion notices from hardware. Initially, a management mailbox channel is up and running. The driver may request firmware to create/destroy more channels dynamically through management channel. Add dri

[PATCH V8 01/10] accel/amdxdna: Add documentation for AMD NPU accelerator driver

2024-11-11 Thread Lizhi Hou
AMD NPU (Neural Processing Unit) is a multi-user AI inference accelerator integrated into AMD client APU. NPU enables efficient execution of Machine Learning applications like CNN, LLM, etc. NPU is based on AMD XDNA Architecture. NPU is managed by amdxdna driver. Co-developed-by: Sonal Santan Sig

[PATCH V8 00/10] AMD XDNA driver

2024-11-11 Thread Lizhi Hou
This patchset introduces a new Linux Kernel Driver, amdxdna for AMD NPUs. The driver is based on Linux accel subsystem. NPU (Neural Processing Unit) is an AI inference accelerator integrated into AMD client CPUs. NPU enables efficient execution of Machine Learning applications like CNNs, LLMs, etc

Re: [PATCH v4 1/5] dt-bindings: display/msm: Document MDSS on SA8775P

2024-11-11 Thread Dmitry Baryshkov
On Mon, 11 Nov 2024 at 19:06, Rob Herring wrote: > > On Fri, Oct 18, 2024 at 6:00 AM Dmitry Baryshkov > wrote: > > > > On Wed, Oct 09, 2024 at 08:02:01PM +0530, Mahadevan wrote: > > > Document the MDSS hardware found on the Qualcomm SA8775P platform. > > > > > > Reviewed-by: Krzysztof Kozlowski

Re: [PATCH v4 1/5] dt-bindings: display/msm: Document MDSS on SA8775P

2024-11-11 Thread Rob Herring
On Fri, Oct 18, 2024 at 6:00 AM Dmitry Baryshkov wrote: > > On Wed, Oct 09, 2024 at 08:02:01PM +0530, Mahadevan wrote: > > Document the MDSS hardware found on the Qualcomm SA8775P platform. > > > > Reviewed-by: Krzysztof Kozlowski > > Signed-off-by: Mahadevan > > --- > > .../bindings/display/ms

Re: (subset) [PATCH 1/2] MAINTAINERS: Use Daniel Thompson's korg address for backlight work

2024-11-11 Thread Lee Jones
On Fri, 08 Nov 2024 08:30:44 +, Daniel Thompson wrote: > Going forward, I'll be using my kernel.org address for upstream work. > > Applied, thanks! [1/2] MAINTAINERS: Use Daniel Thompson's korg address for backlight work commit: 3adec6f907b698b32ab62f70da31b41abed00c59 -- Lee Jones [

[PATCH v2] drm/mgag200: Apply upper limit for clock variable

2024-11-11 Thread Murad Masimov
If the value of the clock variable is higher than 80, the value of the variable m, which is used as a divisor, will remain zero, because (clock * testp) will be higher than vcomax in every loop iteration, which leads to skipping every iteration and leaving variable m unmodified. Clamp value of

Re: [PATCH v11 2/8] drm/ttm: Add a virtual base class for graphics memory backup

2024-11-11 Thread Christian König
Am 11.11.24 um 15:38 schrieb Thomas Hellström: On Fri, 2024-11-08 at 15:32 +0100, Christian König wrote: Am 16.10.24 um 10:55 schrieb Thomas Hellström: Initially intended for experimenting with different backup solutions (shmem vs direct swap cache insertion), abstract the backup destination us

Re: [PATCH v6 2/8] drm/ttm: Add ttm_bo_access

2024-11-11 Thread Christian König
Am 11.11.24 um 15:00 schrieb Joonas Lahtinen: Quoting Christian König (2024-11-11 13:34:12) Am 11.11.24 um 11:10 schrieb Simona Vetter: On Mon, Nov 11, 2024 at 10:00:17AM +0200, Joonas Lahtinen wrote: Back from some time off and will try to answer below. Adding Dave and Sima as this topic has

Re: [RFC PATCH 6/6 6.6] libfs: fix infinite directory reads for offset dir

2024-11-11 Thread Chuck Lever III
> On Nov 11, 2024, at 10:20 AM, yangerkun wrote: > > > > 在 2024/11/11 22:39, Chuck Lever III 写道: >>> On Nov 10, 2024, at 9:36 PM, Yu Kuai wrote: >>> >>> Hi, >>> >>> 在 2024/11/11 8:52, c...@kernel.org 写道: From: yangerkun [ Upstream commit 64a7ce76fb901bf9f9c36cf5d681328fc0fd4b5a

Re: [PATCH v3 00/10] Initial support for Samsung Galaxy Tab 2 series

2024-11-11 Thread Rob Herring (Arm)
On Fri, 08 Nov 2024 20:04:29 +, Mithil Bavishi wrote: > This series adds initial support for the Samsung Galaxy Tab 2 > (samsung-espresso7/10) series of devices. It adds support for 6 variants > (P3100, P3110, P3113, P5100, P5110, P5113). Downstream categorised them > based on 3G and WiFi, bu

Re: [PATCH v2 2/2] drm/msm/adreno: Setup SMMU aparture for per-process page table

2024-11-11 Thread Rob Clark
On Sun, Nov 10, 2024 at 9:31 AM Bjorn Andersson wrote: > > Support for per-process page tables requires the SMMU aparture to be > setup such that the GPU can make updates with the SMMU. On some targets > this is done statically in firmware, on others it's expected to be > requested in runtime by t

Re: [PATCH v2 1/2] firmware: qcom: scm: Introduce CP_SMMU_APERTURE_ID

2024-11-11 Thread Rob Clark
On Sun, Nov 10, 2024 at 9:31 AM Bjorn Andersson wrote: > > The QCOM_SCM_SVC_MP service provides QCOM_SCM_MP_CP_SMMU_APERTURE_ID, > which is used to trigger the mapping of register banks into the SMMU > context for per-processes page tables to function (in case this isn't > statically setup by firm

Re: [PATCH] drm: Remove redundant statement in drm_crtc_helper_set_mode()

2024-11-11 Thread Jani Nikula
On Mon, 11 Nov 2024, Huacai Chen wrote: > Commit dbbfaf5f2641a ("drm: Remove bridge support from legacy helpers") > removes the drm_bridge_mode_fixup() call in drm_crtc_helper_set_mode(), > which makes the subsequent "encoder_funcs = encoder->helper_private" be > redundant, so remove it. > > Cc: s

Re: [RFC PATCH 6/6 6.6] libfs: fix infinite directory reads for offset dir

2024-11-11 Thread Chuck Lever III
> On Nov 10, 2024, at 9:36 PM, Yu Kuai wrote: > > Hi, > > 在 2024/11/11 8:52, c...@kernel.org 写道: >> From: yangerkun >> [ Upstream commit 64a7ce76fb901bf9f9c36cf5d681328fc0fd4b5a ] >> After we switch tmpfs dir operations from simple_dir_operations to >> simple_offset_dir_operations, every rena

Re: [PATCH v11 2/8] drm/ttm: Add a virtual base class for graphics memory backup

2024-11-11 Thread Thomas Hellström
On Fri, 2024-11-08 at 15:32 +0100, Christian König wrote: > Am 16.10.24 um 10:55 schrieb Thomas Hellström: > > Initially intended for experimenting with different backup > > solutions (shmem vs direct swap cache insertion), abstract > > the backup destination using a virtual base class. > > > > Al

Re: drm/fbdev-dma: regression

2024-11-11 Thread Thomas Zimmermann
Hi Am 11.11.24 um 14:42 schrieb Nuno Gonçalves: On Mon, Nov 11, 2024 at 1:22 PM Thomas Zimmermann wrote: The patch in question changes the whole memory management of the affected code. It's also noteworthy that most of it has been reworked for the upcoming v6.12. Maybe this already fixed the

[PATCH 0/5] drm/dumb-buffers: Fix and improve buffer-size calculation

2024-11-11 Thread Thomas Zimmermann
Dumb-buffer pitch and size is specified by width, height, bits-per-pixel plus various hardware-specific alignments. The calculation of these values is inconsistent and duplicated among drivers. The results for formats with bpp < 8 are incorrect. This series begins to fix this. Default scanline pit

[PATCH 4/5] drm/gem-shmem: Use aligned default pitch and size for dumb buffers

2024-11-11 Thread Thomas Zimmermann
Use the pitch and size values stored in the args parameter for allocating a dumb buffer in drm_gem_shmem_dumb_create(). The values come from drm_mode_create_dumb(). Align the pitch to a multiple of 8. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/drm_gem_shmem_helper.c | 16 +-

[PATCH 2/5] drm/dumb-buffers: Fix size calculations and set default pitch and size

2024-11-11 Thread Thomas Zimmermann
Calculate the dumb-buffer scanline pitch with existing 4CC format helpers and provide results to drivers. Fixes the overflow and size tests. Drivers can further reuse the computed values. The dumb-buffer overflow tests round up any given bits-per-pixel value to a multiple of 8. So even one-bit for

[PATCH 5/5] drm/gem-vram: Use default pitch and size for dumb buffers

2024-11-11 Thread Thomas Zimmermann
Use the pitch and size values stored in the args parameter for allocating a dumb buffer in drm_gem_vram_dumb_create(). Inline the relevant code from drm_gem_vram_fill_create_dumb(), but without the size computation. This value comes from drm_mode_create_dumb(). Align the pitch to a multiple of 8.

[PATCH 1/5] drm/dumb-buffers: Sanitize output on errors

2024-11-11 Thread Thomas Zimmermann
The ioctls MODE_CREATE_DUMB and MODE_MAP_DUMB return results into a memory buffer supplied by user space. On errors, it is possible that intermediate values are being returned. The exact semantics depends on the DRM driver's implementation of these ioctls. Although this is most-likely not a securit

[PATCH 3/5] drm/gem-dma: Use aligned default pitch and size for dumb buffers

2024-11-11 Thread Thomas Zimmermann
Use the pitch and size values stored in the args parameter for allocating a dumb buffer in drm_gem_dma_dumb_create(). The values come from drm_mode_create_dumb(). Align the pitch to a multiple of 8. Push the current calculation into the only direct caller imx. Imx's hardware requires the framebuff

Re: [PATCH next] drm: zynqmp_dp: Unlock on error in zynqmp_dp_bridge_atomic_enable()

2024-11-11 Thread Sean Anderson
On 11/11/24 04:06, Dan Carpenter wrote: > We added some locking to this function, but accidentally forgot to unlock > if zynqmp_dp_mode_configure() failed. Use a guard lock to fix it. > > Fixes: a7d5eeaa57d7 ("drm: zynqmp_dp: Add locking") > Signed-off-by: Dan Carpenter > --- > drivers/gpu/drm/

[PATCH v8 2/4] drm: make drm-active- stats optional

2024-11-11 Thread Yunxiang Li
When memory stats is generated fresh everytime by going though all the BOs, their active information is quite easy to get. But if the stats are tracked alongside BO's state changes this becomes harder since the job scheduling part doesn't really deal with individual buffers. Make drm-active- optio

[PATCH v2 RESEND 1/3] dmaengine: qcom: gpi: Add GPI Block event interrupt support

2024-11-11 Thread Jyothi Kumar Seerapu
GSI hardware generates an interrupt for each transfer completion. For multiple messages within a single transfer, this results in receiving N interrupts for N messages, which can introduce significant software interrupt latency. To mitigate this latency, utilize Block Event Interrupt (BEI) only whe

[PATCH v2 RESEND 3/3] i2c: i2c-qcom-geni: Add Block event interrupt support

2024-11-11 Thread Jyothi Kumar Seerapu
The I2C driver gets an interrupt upon transfer completion. For multiple messages in a single transfer, N interrupts will be received for N messages, leading to significant software interrupt latency. To mitigate this latency, utilize Block Event Interrupt (BEI) only when an interrupt is necessary.

[PATCH v2 RESEND 2/3] i2c: qcom_geni: Update compile dependenices for qcom geni

2024-11-11 Thread Jyothi Kumar Seerapu
I2C_QCOM_GENI is having compile dependencies on QCOM_GPI_DMA and so update I2C_QCOM_GENI to depends on QCOM_GPI_DMA. Signed-off-by: Jyothi Kumar Seerapu --- v1 -> v2: This patch is added in v2 to address the kernel test robot reported compilation error. ERROR: modpost: "

[PATCH v2 RESEND 0/3] Add Block event interrupt support for I2C protocol

2024-11-11 Thread Jyothi Kumar Seerapu
The I2C driver gets an interrupt upon transfer completion. For multiple messages in a single transfer, N interrupts will be received for N messages, leading to significant software interrupt latency. To mitigate this latency, utilize Block Event Interrupt (BEI) only when an interrupt is necessary.

Re: [PATCH] drm/mgag200: Apply upper limit for clock variable

2024-11-11 Thread Christophe JAILLET
Le 11/11/2024 à 14:46, Murad Masimov a écrit : If the value of the clock variable is higher than 80, the value of the variable m, which is used as a divisor, will remain zero, because (clock * testp) will be higher than vcomax in every loop iteration, which leads to skipping every iteration a

Re: [PATCH v6 2/8] drm/ttm: Add ttm_bo_access

2024-11-11 Thread Joonas Lahtinen
Quoting Christian König (2024-11-11 13:34:12) > Am 11.11.24 um 11:10 schrieb Simona Vetter: > > On Mon, Nov 11, 2024 at 10:00:17AM +0200, Joonas Lahtinen wrote: > >> Back from some time off and will try to answer below. > >> > >> Adding Dave and Sima as this topic has been previously discussed to s

[PATCH] drm/mgag200: Apply upper limit for clock variable

2024-11-11 Thread Murad Masimov
If the value of the clock variable is higher than 80, the value of the variable m, which is used as a divisor, will remain zero, because (clock * testp) will be higher than vcomax in every loop iteration, which leads to skipping every iteration and leaving variable m unmodified. Clamp value of

Re: [RFC PATCH 0/6] Common preempt fences and semantics

2024-11-11 Thread Christian König
Am 09.11.24 um 18:29 schrieb Matthew Brost: The motivation for this series comes from pending UMD submission work by AMD [1], ARM [3], and the Xe team, who are also beginning to look at this. Sima has suggested [4] some common driver preemptive fences and semantics, which we all agree on. This is

[PATCH v2] drm/panthor: Fix handling of partial GPU mapping of BOs

2024-11-11 Thread Akash Goel
This commit fixes the bug in the handling of partial mapping of the buffer objects to the GPU, which caused kernel warnings. Panthor didn't correctly handle the case where the partial mapping spanned multiple scatterlists and the mapping offset didn't point to the 1st page of starting scatterlist.

Re: drm/fbdev-dma: regression

2024-11-11 Thread Nuno Gonçalves
On Mon, Nov 11, 2024 at 1:22 PM Thomas Zimmermann wrote: > The patch in question changes the whole memory management of the > affected code. It's also noteworthy that most of it has been reworked > for the upcoming v6.12. Maybe this already fixed the problem. Kernel > v6.11-rc7 added commit 5a498d

Re: drm/fbdev-dma: regression

2024-11-11 Thread Thomas Zimmermann
Hi Am 11.11.24 um 12:51 schrieb Thorsten Leemhuis: [CCing a few more lists] On 21.10.24 15:03, Nuno Gonçalves wrote: Since 5ab91447aa13b8b98bc11f5326f33500b0ee2c48 and still happening in master, I often get a kernel crash, either a "Unable to handle kernel NULL pointer dereference at virtual

  1   2   >