Hi Hari,
On 03/09/25 15:39, Harikrishna Shenoy wrote:
Update VP SYNC LOST Bit as per register description for
DSS0_COMMON_VP_IRQENABLE_0 give in TRM.
Link:https://www.ti.com/lit/zip/spruil1/SPRUIL_DRA829_TDA4VM
Table 12-597. DSS0_COMMON_VP_IRQENABLE_0
Fixes: 32a1795f57ee ("drm/tidss: New drive
Hi Marek,
Thanks for the patch.
On 05/09/25 02:26, Marek Vasut wrote:
Add configuration for the 5" Raspberry Pi 720x1280 DSI panel
based on ili9881. This uses 10px longer horizontal sync pulse
and 10px shorter HBP to avoid very short hsync pulse.
Is there a publicly available datasheet for th
Hi Hari,
On 04/09/25 03:33, Rob Herring wrote:
On Wed, Sep 03, 2025 at 04:43:57PM +0530, Harikrishna Shenoy wrote:
From: Swapnil Jakhade
Add binding changes for DSC(Display Stream Compression) in the MHDP8546
DPI/DP bridge.
Signed-off-by: Swapnil Jakhade
Signed-off-by: Harikrishna Shenoy
-
es:
https://lore.kernel.org/oe-kbuild-all/202506301704.0sbj6ply-...@intel.com/
Signed-off-by: Douglas Anderson
Reviewed-by: Devarsh Thakkar
Regards
Devarsh
---
drivers/gpu/drm/bridge/ti-sn65dsi86.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/bridge/ti-sn65dsi86.c
Hi Tomi,
On 17/07/25 15:59, Tomi Valkeinen wrote:
Hi,
On 17/07/2025 12:36, Devarsh Thakkar wrote:
Hi Tomi
Thanks for the patch.
On 18/06/25 15:29, Tomi Valkeinen wrote:
While the cdns-dsi does not support DSI burst mode, the burst mode is
essentially DSI event mode with more versatile
Hi Tomi
Thanks for the patch.
On 18/06/25 15:29, Tomi Valkeinen wrote:
While the cdns-dsi does not support DSI burst mode, the burst mode is
essentially DSI event mode with more versatile clocking and timings.
I don't fully agree with this statement, DSI burst mode and DSI event
mode are two d
e support")
Signed-off-by: Jayesh Choudhary
Reviewed-by: Devarsh Thakkar
Regards
Devarsh
---
Warning log:
<https://gist.github.com/Jayesh2000/e42c235bb57cb0f0af06c8c3bf886ef2>
drivers/gpu/drm/tidss/tidss_oldi.c | 10 --
1 file changed, 4 insertions(+), 6 deletions(-)
On 02/07/25 12:31, Jayesh Choudhary wrote:
Hello Devarsh,
On 01/07/25 19:00, Devarsh Thakkar wrote:
On 01/07/25 15:25, Jayesh Choudhary wrote:
In an effort to make the existing compatibles more usable, we are
removing the max_pclk_khz form dispc_features structure and doing the
correspondig
gpu/drm/tidss/tidss_drv.h
@@ -25,6 +25,8 @@ struct tidss_device {
const struct dispc_features *feat;
struct dispc_device *dispc;
bool is_oldi_vp[TIDSS_MAX_PORTS];
+ /* stores max supported pixel clock requested during checking modes */
Stores highest pixel clock value found
tomic_pre_enable, tidss_oldi_atomic_post_disable so maybe
change those too ?
With suggested change,
Reviewed-by: Devarsh Thakkar
Regards
Devarsh
};
static int get_oldi_mode(struct device_node *oldi_tx, int *companion_instance)
On 01/07/25 15:25, Jayesh Choudhary wrote:
In an effort to make the existing compatibles more usable, we are
removing the max_pclk_khz form dispc_features structure and doing the
correspondig checks using "curr_max_pclk[]".
Changes are fully backwards compatible.
After integration of OLDI suppo
dss_oldi_init() and 'false' in tidss_oldi_deinit().
Signed-off-by: Jayesh Choudhary
Reviewed-by: Devarsh Thakkar
Regards
Devarsh
---
drivers/gpu/drm/tidss/tidss_drv.h | 2 ++
drivers/gpu/drm/tidss/tidss_oldi.c | 2 ++
2 files changed, 4 insertions(+)
diff --git a/drivers/gpu/drm/ti
Hi Jayesh,
Thanks for the patch.
On 18/06/25 15:35, Jayesh Choudhary wrote:
TIDSS hardware by itself does not have variable max_pclk for each VP.
Each VP supports a fixed maximum pixel clock.
As discussed offline, I think VP max pixel clock is more dependent on
SoC than DSS itself as SoC pr
Hi Michael, Tomi,
On 27/05/25 18:03, Tomi Valkeinen wrote:
Hi Michael (and Aradhya, Devarsh),
On 27/05/2025 12:13, Michael Walle wrote:
Hi Tomi,
While testing Aardhya's OLDI support patches [1], I've noticed that
the resulting LVDS clock is wrong if this patch is applied.
In practice, with
are
highlighted in the code.
Signed-off-by: Devarsh Thakkar
---
V6:
- Move hw_id indexing logic to skip uninstantiated planes to
internal functions dealing with relevant registers
V5:
- Use separate variable for hw_id and add it in missing places to access
correct VID pipeline bits in common
Choudhary
Reviewed-by: Tomi Valkeinen
Signed-off-by: Devarsh Thakkar
---
V6: No change
V5: No change
V4: No change
V3:
- Remove AM62A references as suggested
- Add Reviewed-by
V2:
- Add Reviewed-by
- s/ti,am62l,dss/ti,am62l-dss
.../bindings/display/ti/ti,am65x-dss.yaml | 21
tps://lore.kernel.org/all/20250306132914.1469387-1-devar...@ti.com/
V2: https://lore.kernel.org/all/20250204061552.3720261-1-devar...@ti.com/
V1: https://lore.kernel.org/all/20241231090432.3649158-1-devar...@ti.com/
Test logs:
https://gist.github.com/devarsht/09a5d64a507b7ccc096e857f122eda70
Devarsh Thakkar (3):
port are also routed to DSI Tx controller
present within the SoC.
[1]: Section 11.7 (Display Subsystem and Peripherals)
Link : https://www.ti.com/lit/pdf/sprujb4
Signed-off-by: Devarsh Thakkar
---
v6:
- No change
V5:
- No change
V4:
- Rebase on top of previous patch to use vid_info structure
Hi Tomi
On 03/05/25 14:14, Tomi Valkeinen wrote:
> On 02/05/2025 14:52, Devarsh Thakkar wrote:
>> Hi,
>>
>>
>> Ok I see what you mean to say.although functionally it is working
>> fine but from readability point of view it is confusing since both
>&g
Hi,
>> It uses hw_id i.e. 1 for all vid irqstatus related registers since it is
>> accessing am65x common region register space which has vid on idx0 which
>> we want to skip for am62l.
>>
>> For dispc_plane_enable(), the caller uses
>>> 0, for dispc_k3_vid_write_irqstatus(), the caller uses 1...
Hi Tomi,
Thanks for the quick revert.
On 02/05/25 13:37, Tomi Valkeinen wrote:
> Hi,
>
> On 02/05/2025 10:06, Devarsh Thakkar wrote:
>> Hi Tomi
>>
>> Thanks for quick comments.
>>
>> On 30/04/25 23:12, Tomi Valkeinen wrote:
>>> On 30/04
Hi Tomi
Thanks for quick comments.
On 30/04/25 23:12, Tomi Valkeinen wrote:
> On 30/04/2025 19:37, Devarsh Thakkar wrote:
>> Hi Tomi
>>
>> Thanks for the review.
>>
>>
>>>> @@ -2025,7 +2101,7 @@ int dispc_plane_check(struct dispc_device
>>&
Hi Tomi
Thanks for the review.
>> @@ -2025,7 +2101,7 @@ int dispc_plane_check(struct dispc_device
>> *dispc, u32 hw_plane,
>> const struct drm_plane_state *state,
>> u32 hw_videoport)
>> {
>> - bool lite = dispc->feat->vid_lite[hw_plane];
>> + bool lite
Hi Tomi
Thanks for the review. I had missed to respond back to below comment
before sending V5, so kindly find the response for the same as below.
On 27/03/25 16:48, Tomi Valkeinen wrote:
>> *dispc, u32 hw_plane,
>> const struct drm_plane_state *state,
>> u32 hw
Choudhary
Reviewed-by: Tomi Valkeinen
Signed-off-by: Devarsh Thakkar
---
V5:
- No change
V4:
- No change
V3:
- Remove AM62A references as suggested
- Add Reviewed-by
V2:
- Add Reviewed-by
- s/ti,am62l,dss/ti,am62l-dss
.../bindings/display/ti/ti,am65x-dss.yaml | 21 +
are
highlighted in the code.
Signed-off-by: Devarsh Thakkar
---
V5:
- Use separate variable for hw_id and add it in missing places to access
correct VID pipeline bits in common registers
V4:
- Create vid_info struct only for instantiated planes
- s/num_planes/num_vids
- s/vid_lite/is_lite
r...@ti.com/
V3: https://lore.kernel.org/all/20250306132914.1469387-1-devar...@ti.com/
V2: https://lore.kernel.org/all/20250204061552.3720261-1-devar...@ti.com/
V1: https://lore.kernel.org/all/20241231090432.3649158-1-devar...@ti.com/
Test logs:
https://gist.github.com/devarsht/82505ca69f0bd5d9788bfc240d2e83
port are also routed to DSI Tx controller
present within the SoC.
[1]: Section 11.7 (Display Subsystem and Peripherals)
Link : https://www.ti.com/lit/pdf/sprujb4
Signed-off-by: Devarsh Thakkar
---
V5:
- No change
V4:
- Rebase on top of previous patch to use vid_info structure
V3:
- Rebase on
port are also routed to DSI Tx controller
present within the SoC.
[1]: Section 11.7 (Display Subsystem and Peripherals)
Link : https://www.ti.com/lit/pdf/sprujb4
Signed-off-by: Devarsh Thakkar
---
V4:
- Rebase on top of previous patch to use vid_info structure
V3:
- Rebase on top of
0002-drm
Choudhary
Reviewed-by: Tomi Valkeinen
Signed-off-by: Devarsh Thakkar
---
V4:
- No change
V3:
- Remove AM62A references as suggested
- Add Reviewed-by
V2:
- Add Reviewed-by
- s/ti,am62l,dss/ti,am62l-dss
.../bindings/display/ti/ti,am65x-dss.yaml | 21 ++-
1 file c
github.com/devarsht/16fe796b8fd3ea8abf5df8e2327d2311
Devarsh Thakkar (3):
dt-bindings: display: ti,am65x-dss: Add support for AM62L DSS
drm/tidss: Update infrastructure to support K3 DSS cut-down versions
drm/tidss: Add support for AM62L display subsystem
.../bindings/display/ti/ti,am65x-dss.yaml | 21 ++-
dr
are
highlighted in the code.
Signed-off-by: Devarsh Thakkar
---
V4:
- Create vid_info struct only for instantiated planes
- s/num_planes/num_vids
- s/vid_lite/is_lite
- Add hw_id member in vid_info struct and remove is_present
V2->V3:
- No change (patch introduced in V3)
drivers/gpu/drm/ti
Test logs:
https://gist.github.com/devarsht/16fe796b8fd3ea8abf5df8e2327d2311
Devarsh Thakkar (3):
dt-bindings: display: ti,am65x-dss: Add support for AM62L DSS
drm/tidss: Update infra to support DSS7 cut-down versions
drm/tidss: Add support for AM62L display subsystem
.../bindings/dis
to indicate whether that plane is actually supported
or it is truncated. If the plane is truncated, then skip the access
to corresponding register space while doing plane related operations.
Signed-off-by: Devarsh Thakkar
---
V3: Patch is introduced
V2: Patch not present
drivers/gpu/drm/tidss
Choudhary
Reviewed-by: Tomi Valkeinen
Signed-off-by: Devarsh Thakkar
---
V3:
- Remove AM62A references as suggested
- Add Reviewed-by
V2:
- Add Reviewed-by
- s/ti,am62l,dss/ti,am62l-dss
.../bindings/display/ti/ti,am65x-dss.yaml | 21 ++-
1 file changed, 20 insertions(+),
port are also routed to DSI Tx controller
present within the SoC.
[1]: Section 11.7 (Display Subsystem and Peripherals)
Link : https://www.ti.com/lit/pdf/sprujb4
Signed-off-by: Devarsh Thakkar
---
V3:
- Rebase on top of
0002-drm-tidss-Update-infra-to-support-DSS7-cut-down-vers.patch
- Use the
Hi Tomi,
Thanks for the review.
On 04/02/25 19:25, Tomi Valkeinen wrote:
>> description: |
>> - The AM625 and AM65x TI Keystone Display SubSystem with two output
>> + The AM625 and AM65x TI Keystone Display SubSystem has two output
>> ports and two video planes. In AM65x DSS, the first
Hi Tomi
>> Thanks for pointing out, I probably missed this since the use-case still
>> worked since VP interrupts were still enabled and those were sufficient to
>> drive the display
>> but the VID underflow interrupts and VID specific bits were probably not
>> enabled at-all due to above miss, so
input channel value needs to be mandatorily set as 1 for the first
and only video lite pipeline for this SoC.
[1]: Section 11.7 (Display Subsystem and Peripherals)
Link : https://www.ti.com/lit/pdf/sprujb4
Signed-off-by: Devarsh Thakkar
---
V2:
- Add separate common reg space for AM62L
- Add separate
x:
https://lore.kernel.org/all/20250203155431.2174170-1-devar...@ti.com/
Devarsh Thakkar (2):
dt-bindings: display: ti,am65x-dss: Add support for AM62L DSS
drm/tidss: Add support for AM62L display subsystem
.../bindings/display/ti/ti,am65x-dss.yaml | 25 +++-
drivers/gpu/drm/tidss/tidss
Choudhary
Signed-off-by: Devarsh Thakkar
---
- Add Reviewed-by
- s/ti,am62l,dss/ti,am62l-dss
NOTE: This patch needs to be applied on top of AM62A dt-binding fix:
https://lore.kernel.org/all/20250203155431.2174170-1-devar...@ti.com/
.../bindings/display/ti/ti,am65x-dss.yam
Fix incorrect format of compatible string (comma instead of hyphen) for
TI's AM62A7 SoC.
s/ti,am62a7,dss/ti,am62a7-dss
Fixes: 7959ceb767e4 ("dt-bindings: display: ti: Add support for am62a7 dss")
Reviewed-by: Krzysztof Kozlowski
Signed-off-by: Devarsh Thakkar
---
V2: Add Reviewe
Fix compatible string for AM62A7 DSS.
s/ti,am62a7,dss/ti,am62a7-dss
Fixes: 7959ceb767e4 ("dt-bindings: display: ti: Add support for am62a7 dss")
Signed-off-by: Devarsh Thakkar
---
Documentation/devicetree/bindings/display/ti/ti,am65x-dss.yaml | 2 +-
1 file changed, 1 insertion(+),
Hi Jayesh,
On 24/01/25 13:50, Jayesh Choudhary wrote:
>> compatible:
>> enum:
>> - ti,am625-dss
>> - ti,am62a7,dss
>> + - ti,am62l,dss
>
>
> s/ti,am62l,dss/ti,am62l-dss
>
> There seems to be inconsistency in the usage of the compatible name in
> the conditional b
Hi Aradhya,
On 18/01/25 14:57, Aradhya Bhatia wrote:
> Hi Devarsh,
>
> Thanks for the patches.
>
Thanks for the review.
> On 31/12/24 14:34, Devarsh Thakkar wrote:
>> Enable display for AM62L DSS [1] which supports only a single display
>> pipeline using a single ov
This adds support for DSS subsystem present in TI's AM62L SoC
which supports single display pipeline with DPI output which
is also routed to DSI Tx controller within the SoC.
Devarsh Thakkar (2):
dt-bindings: display: ti,am65x-dss: Add support for AM62L DSS
drm/tidss: Add support for
eo port is routed to SoC boundary via DPI interface and
the DPI signals from the video port are also routed to DSI Tx controller
present within the SoC.
[1]: Section 11.7 (Display Subsystem and Peripherals)
Link : https://www.ti.com/lit/pdf/sprujb4
Signed-off-by: Devarsh Thakkar
---
.../bindings/dis
port are also routed to DSI Tx controller
present within the SoC.
[1]: Section 11.7 (Display Subsystem and Peripherals)
Link : https://www.ti.com/lit/pdf/sprujb4
Signed-off-by: Devarsh Thakkar
---
drivers/gpu/drm/tidss/tidss_dispc.c | 34 +
drivers/gpu/drm/tidss
On 21/10/24 19:37, Tomi Valkeinen wrote:
> We never use the DSS_IRQ_DEVICE_OCP_ERR flag, and the HW doesn't even
> have such a bit... So remove it.
>
> Signed-off-by: Tomi Valkeinen
Reviewed-by: Devarsh Thakkar
Regards
Devarsh
> ---
> drivers/gpu/drm/tidss/tidss_irq
n
Reviewed-by: Devarsh Thakkar
Regards
Devarsh
> ---
> drivers/gpu/drm/tidss/tidss_dispc.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/tidss/tidss_dispc.c
> b/drivers/gpu/drm/tidss/tidss_dispc.c
> index f8067578..99a1138f3e69 100644
> --
x27;wait_list' which doesn't exist in tidss.
>
> Signed-off-by: Tomi Valkeinen
Reviewed-by: Devarsh Thakkar
Regards
Devarsh
> ---
> drivers/gpu/drm/tidss/tidss_dispc.c | 4 ++--
> drivers/gpu/drm/tidss/tidss_drv.c | 2 +-
> drivers/gpu/drm/tidss/tid
On 21/10/24 19:37, Tomi Valkeinen wrote:
> Add printing of underflows the same way as we handle sync losts.
>
> Signed-off-by: Tomi Valkeinen
Reviewed-by: Devarsh Thakkar
Regards
Devarsh
> ---
> drivers/gpu/drm/tidss/tidss_irq.c | 14 ++
> dri
Hi Aradhya,
Thanks for the patch.
On 20/10/24 01:24, Aradhya Bhatia wrote:
> From: Aradhya Bhatia
[...]
> + /*
> + * Now that the DSI Link and DSI Phy are initialized,
> + * wait for the CLK and Data Lanes to be ready.
> + */
> + tmp = CLK_LANE_RDY;
> + for (int i =
& old_mask
This corrects the bit mask to make sure that it always clears any pending
interrupt events that are requested to be disabled before disabling them
actually.
Fixes: 32a1795f57ee ("drm/tidss: New driver for TI Keystone platform Display
SubSystem")
Reported-by: Jonathan Cormier
. To prevent such scenarioes, use a spinlock to serialize access
to interrupt related registers.
Fixes: 32a1795f57ee ("drm/tidss: New driver for TI Keystone platform Display
SubSystem")
Signed-off-by: Devarsh Thakkar
---
drivers/gpu/drm/tidss/tidss_dispc.c | 4
drivers/gpu
potential race scenario between interrupt subroutine and interrupt
enable/disable related functions as they both access interrupt registers
without a common lock. This series addresses the aforementioned problems.
Devarsh Thakkar (2):
drm/tidss: Clear the interrupt status for interrupts being disabled
Hi Laurent,
Thanks for the quick review.
On 13/09/24 13:54, Laurent Pinchart wrote:
> Hi Devarsh,
>
> On Thu, Sep 12, 2024 at 10:41:42PM +0530, Devarsh Thakkar wrote:
>> Modify license to include dual licensing as GPL-2.0-only OR MIT license for
>> tidss display driv
Modify license to include dual licensing as GPL-2.0-only OR MIT license for
tidss display driver. This allows other operating system ecosystems such as
Zephyr and also the commercial firmwares to refer and derive code from this
display driver in a more permissive manner.
Signed-off-by: Devarsh
Use generic macro round_closest_up() for rounding closest to specified
value instead of using local macro round_closest().
There is no change from functionality point of view as round_closest_up()
is functionally same as the previously used local macro round_closest().
Signed-off-by: Devarsh
ection.rst
[1]
Signed-off-by: Devarsh Thakkar
---
V9->V13: No change
V8: Update commit message with specification reference
V1->V7 (No change, patch introduced in V7)
---
drivers/media/platform/imagination/e5010-jpeg-enc.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff
Add tests for round_closest_up/down and roundclosest macros which round
to nearest multiple of specified argument. These are tested with kunit
tool as shared here [1] :
Link: https://gist.github.com/devarsht/3f9042825be3da4e133b8f4eda067876 [1]
Signed-off-by: Devarsh Thakkar
Acked-by: Andy
c files
Signed-off-by: Daniel Latypov
Reviewed-by: David Gow
Reviewed-by: Andy Shevchenko
[devarsht: Rebase to 6.9, remove kernel.h, update Kconfig and change license to
GPL]
Signed-off-by: Devarsh Thakkar
---
Changes since v11:
* Add Reviewed-by tag
Changes since v10:
* Include headers per
Add documentation for rounding, scaling, absolute value and 32-bit division
related macros and functions exported by math.h header file.
Signed-off-by: Devarsh Thakkar
Reviewed-by: Andy Shevchenko
---
V13: No change
V12: Add Reviewed-by
V11: Fix title for math function header
V10: Patch
* round_closest_up(15, 4) = 16
* round_closest_up(14, 4) = 16
* round_closest_down(17, 4) = 16
* round_closest_down(15, 4) = 16
* round_closest_down(14, 4) = 12
* roundclosest(21, 5) = 20
* roundclosest(19, 5) = 20
* roundclosest(17, 5) = 15
Signed-off-by: Devarsh Thakkar
Acked-by: Andy
com/
V5: https://lore.kernel.org/all/20240215134641.3381478-1-devar...@ti.com/
V4: https://lore.kernel.org/all/20240205114239.924697-1-devar...@ti.com/
V3: https://lore.kernel.org/all/20230816152210.4080779-1-devar...@ti.com/
V2: https://lore.kernel.org/all/20230727112546.2201995-1-devar...@ti.com/
Da
Hi Sebastian
Thanks for the update.
On 06/06/24 17:14, Sebastian Fricke wrote:
> Hey,
>
> On 04.06.2024 16:23, Devarsh Thakkar wrote:
>> If neither of the flags to round down (V4L2_SEL_FLAG_LE) or round up
>> (V4L2_SEL_FLAG_GE) are specified by the user, then round to n
Use generic macro round_closest_up() for rounding closest to specified
value instead of using local macro round_closest().
There is no change from functionality point of view as round_closest_up()
is functionally same as the previously used local macro round_closest().
Signed-off-by: Devarsh
ection.rst
[1]
Signed-off-by: Devarsh Thakkar
---
V12: No change
V11: No change
V10: No change
V9: No change
V8: Update commit message with specification reference
V1->V7 (No change, patch introduced in V7)
---
drivers/media/platform/imagination/e5010-jpeg-enc.c | 8
1 file changed,
Add tests for round_closest_up/down and roundclosest macros which round
to nearest multiple of specified argument. These are tested with kunit
tool as shared here [1] :
Link: https://gist.github.com/devarsht/3f9042825be3da4e133b8f4eda067876 [1]
Signed-off-by: Devarsh Thakkar
Acked-by: Andy
c files
Signed-off-by: Daniel Latypov
Reviewed-by: David Gow
Reviewed-by: Andy Shevchenko
[devarsht: Rebase to 6.9, remove kernel.h, update Kconfig and change license to
GPL]
Signed-off-by: Devarsh Thakkar
---
Changes since v11:
* Add Reviewed-by tag
Changes since v10:
* Include headers per
Add documentation for rounding, scaling, absolute value and 32-bit division
related macros and functions exported by math.h header file.
Signed-off-by: Devarsh Thakkar
Reviewed-by: Andy Shevchenko
---
V12: Add Reviewed-by
V11: Fix title for math function header
V10: Patch introduced
V1->V9
* round_closest_up(15, 4) = 16
* round_closest_up(14, 4) = 16
* round_closest_down(17, 4) = 16
* round_closest_down(15, 4) = 16
* round_closest_down(14, 4) = 12
* roundclosest(21, 5) = 20
* roundclosest(19, 5) = 20
* roundclosest(17, 5) = 15
Signed-off-by: Devarsh Thakkar
Acked-by: Andy
ti.com/
V2: https://lore.kernel.org/all/20230727112546.2201995-1-devar...@ti.com/
Daniel Latypov (1):
lib: add basic KUnit test for lib/math
Devarsh Thakkar (12):
media: dt-bindings: Add Imagination E5010 JPEG Encoder
media: imagination: Add E5010 JPEG Encoder driver
media: v4l
On 01/06/24 00:01, Randy Dunlap wrote:
> Hi,
>
> On 5/31/24 10:12 AM, Devarsh Thakkar wrote:
>> Add documentation for rounding, scaling, absolute value and difference,
>> 32-bit division related macros and functions exported by math.h header
>> file.
>>
&g
Use generic macro round_closest_up() for rounding closest to specified
value instead of using local macro round_closest().
There is no change from functionality point of view as round_closest_up()
is functionally same as the previously used local macro round_closest().
Signed-off-by: Devarsh
ection.rst
Signed-off-by: Devarsh Thakkar
---
V11: No change
V10: No change
V9: No change
V8: Update commit message with specification reference
V1->V7 (No change, patch introduced in V7)
---
drivers/media/platform/imagination/e5010-jpeg-enc.c | 8
1 file changed, 4 insertions(+)
Add tests for round_closest_up/down and roundclosest macros which round
to nearest multiple of specified argument. These are tested with kunit
tool as shared here [1].
[1]: https://gist.github.com/devarsht/3f9042825be3da4e133b8f4eda067876
Signed-off-by: Devarsh Thakkar
---
V1->V11 (No cha
c files
Signed-off-by: Daniel Latypov
Reviewed-by: David Gow
[devarsht: Rebase to 6.9, remove kernel.h, update Kconfig and change license to
GPL]
Signed-off-by: Devarsh Thakkar
---
Changes since v10:
* Include headers per IWYU principle and add module description
Changes since v9:
* Added Kco
Add documentation for rounding, scaling, absolute value and difference,
32-bit division related macros and functions exported by math.h header
file.
Signed-off-by: Devarsh Thakkar
---
V11: Fix title for math function header
V10: Patch introduced
V1->V9 (No change)
---
Documentation/core-
* round_closest_up(15, 4) = 16
* round_closest_up(14, 4) = 16
* round_closest_down(17, 4) = 16
* round_closest_down(15, 4) = 16
* round_closest_down(14, 4) = 12
* roundclosest(21, 5) = 20
* roundclosest(19, 5) = 20
* roundclosest(17, 5) = 15
Signed-off-by: Devarsh Thakkar
---
NOTE: This patch
10.4080779-1-devar...@ti.com/
V2: https://lore.kernel.org/all/20230727112546.2201995-1-devar...@ti.com/
Daniel Latypov (1):
lib: add basic KUnit test for lib/math
Devarsh Thakkar (10):
media: dt-bindings: Add Imagination E5010 JPEG Encoder
media: imagination: Add E5010 JPEG Encoder driver
media: v4l2-j
Hi Randy,
Thanks for the review.
On 31/05/24 04:14, Randy Dunlap wrote:
>
>
> On 5/30/24 10:17 AM, Devarsh Thakkar wrote:
>> Add documentation for rounding, scaling, absolute value and difference,
>> 32-bit division related macros and functions exported by math.h header
On 31/05/24 00:51, Andy Shevchenko wrote:
> On Thu, May 30, 2024 at 10:47:40PM +0530, Devarsh Thakkar wrote:
>> Add documentation for rounding, scaling, absolute value and difference,
>> 32-bit division related macros and functions exported by math.h header
>> file.
>
On 31/05/24 00:53, Andy Shevchenko wrote:
> On Thu, May 30, 2024 at 10:48:10PM +0530, Devarsh Thakkar wrote:
>> From: Daniel Latypov
>>
>> Add basic test coverage for files that don't require any config options:
>> * part of math.h (what seem to be the most
Hi Andy,
Thanks for the review.
On 31/05/24 00:49, Andy Shevchenko wrote:
> On Thu, May 30, 2024 at 10:42:25PM +0530, Devarsh Thakkar wrote:
>> Add below rounding related macros:
>>
>> round_closest_up(x, y) : Rounds x to closest multiple of y where y is a
>> power
Use generic macro round_closest_up() for rounding closest to specified
value instead of using local macro round_closest().
There is no change from functionality point of view as round_closest_up()
is functionally same as the previously used local macro round_closest().
Signed-off-by: Devarsh
ection.rst
Signed-off-by: Devarsh Thakkar
---
V10: No change
V9: No change
V8: Update commit message with specification reference
V1->V7 (No change, patch introduced in V7)
---
drivers/media/platform/imagination/e5010-jpeg-enc.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
Add tests for round_closest_up/down and roundclosest macros which round
to nearest multiple of specified argument. These are tested with kunit
tool as shared here [1].
[1]: https://gist.github.com/devarsht/3f9042825be3da4e133b8f4eda067876
Signed-off-by: Devarsh Thakkar
---
V1->V10 (No cha
c files
Signed-off-by: Daniel Latypov
Reviewed-by: David Gow
[devarsht: Rebase to 6.9, remove kernel.h, update Kconfig and change license to
GPL]
Signed-off-by: Devarsh Thakkar
---
Changes since v9:
* Added Kconfig dependency for KUNIT
Changes since v8:
* Remove unrequired header file linux/ke
Add documentation for rounding, scaling, absolute value and difference,
32-bit division related macros and functions exported by math.h header
file.
Signed-off-by: Devarsh Thakkar
---
V1->V9 (No change)
V10: Patch introduced
---
Documentation/core-api/kernel-api.rst | 6 ++
1 file chan
* round_closest_up(15, 4) = 16
* round_closest_up(14, 4) = 16
* round_closest_down(17, 4) = 16
* round_closest_down(15, 4) = 16
* round_closest_down(14, 4) = 12
* roundclosest(21, 5) = 20
* roundclosest(19, 5) = 20
* roundclosest(17, 5) = 15
Signed-off-by: Devarsh Thakkar
---
NOTE: This patch
0779-1-devar...@ti.com/
V2: https://lore.kernel.org/all/20230727112546.2201995-1-devar...@ti.com/
Daniel Latypov (1):
lib: add basic KUnit test for lib/math
Devarsh Thakkar (10):
media: dt-bindings: Add Imagination E5010 JPEG Encoder
media: imagination: Add E5010 JPEG Encoder driver
media: v4l2
Hi Javier, Maxime, Daniel,
Sorry for the delay. Please find response inline.
On 16/05/24 18:21, Daniel Vetter wrote:
> On Wed, May 15, 2024 at 04:45:09PM +0200, Javier Martinez Canillas wrote:
>> Devarsh Thakkar writes:
[..]
>>
>> If I understand you correctly, for now t
On 28/05/24 02:08, Andy Shevchenko wrote:
> On Mon, May 27, 2024 at 11:37:20PM +0300, Andy Shevchenko wrote:
>> On Sun, May 26, 2024 at 11:39:33PM +0530, Devarsh Thakkar wrote:
>
> ...
>
>>> +MODULE_LICENSE("GPL");
>>
>> modpost
Hi Andy,
Thanks for the review.
On 28/05/24 02:07, Andy Shevchenko wrote:
[..]
>> +#include
>> +#include
>> +#include
>
> + math.h (where abs()/DIV_ROUND_*()/etc come from?)
> I believe I mentioned that.
>
I did compile and test this, so math.h was indirectly getting included via
some othe
Hi Andy,
Thanks for the review.
On 28/05/24 02:02, Andy Shevchenko wrote:
> On Sun, May 26, 2024 at 11:38:56PM +0530, Devarsh Thakkar wrote:
...
>> +/**
>> + * round_closest_up - round closest to be multiple of specified value
>> (which is
>> + *
Use generic macro round_closest_up() for rounding closest to specified
value instead of using local macro round_closest().
There is no change from functionality point of view as round_closest_up()
is functionally same as the previously used local macro round_closest().
Signed-off-by: Devarsh
ection.rst
Signed-off-by: Devarsh Thakkar
---
V9: No change
V8: Update commit message with specification reference
V1->V7 (No change, patch introduced in V7)
---
drivers/media/platform/imagination/e5010-jpeg-enc.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/
Add tests for round_closest_up/down and roundclosest macros which round
to nearest multiple of specified argument. These are tested with kunit
tool as shared here [1].
[1]: https://gist.github.com/devarsht/3f9042825be3da4e133b8f4eda067876
Signed-off-by: Devarsh Thakkar
---
V1->V9 (No cha
c files
Signed-off-by: Daniel Latypov
Reviewed-by: David Gow
[devarsht: Rebase to 6.9, remove kernel.h and change license to GPL]
Signed-off-by: Devarsh Thakkar
---
Changes since v8:
* Remove unrequired header file linux/kernel.h
Changes since v7:
* Rebase to linux-next, change license to GPL
1 - 100 of 174 matches
Mail list logo
