Re: [PATCHv5 11/11] arm: sti: update sti-cec for CEC notifier support

2017-03-30 Thread Benjamin Gaignard
+ Patrice for sti DT 2017-03-29 16:15 GMT+02:00 Hans Verkuil : > From: Benjamin Gaignard > > To use CEC notifier sti CEC driver needs to get phandle > of the hdmi device. > > Signed-off-by: Benjamin Gaignard >

Re: [PATCH] Fix IB va_start+ib_bytes range check on 32Bit systems

2017-03-30 Thread Christian König
Am 30.03.2017 um 03:41 schrieb Michel Dänzer: On 30/03/17 12:18 AM, Christian König wrote: Am 29.03.2017 um 16:54 schrieb Michel Dänzer: On 29/03/17 10:22 PM, Christian König wrote: Am 29.03.2017 um 11:18 schrieb Jan Burgmeier: Signed-off-by: Jan Burgmeier

Re: [PATCH v5 4/5] drm: Connector helper function to release resources

2017-03-30 Thread Maarten Lankhorst
Op 30-03-17 om 10:42 schreef Dhinakaran Pandiyan: > From: "Pandiyan, Dhinakaran" > > Having an ->atomic_release callback is useful to release shared resources > that get allocated in compute_config(). This function is expected to be > called in the atomic_check()

Re: [PATCH 4/6] drm/amdgpu: drop alpha support

2017-03-30 Thread Alex Deucher
On Thu, Mar 30, 2017 at 2:39 AM, Michel Dänzer wrote: > On 29/03/17 09:55 PM, Christian König wrote: >> From: Christian König >> >> We will probably never see this combination. >> >> Signed-off-by: Christian König >> --- >>

Re: [Intel-gfx] [PATCH] drm/vblank: drop the mode argument from drm_calc_vbltimestamp_from_scanoutpos

2017-03-30 Thread Daniel Vetter
On Thu, Mar 30, 2017 at 2:03 PM, Ville Syrjälä wrote: > On Wed, Mar 22, 2017 at 09:56:12PM +0100, Daniel Vetter wrote: >> If we restrict this helper to only kms drivers (which is the case) we >> can look up the correct mode easily ourselves. But it's a bit tricky:

Re: [Intel-gfx] [PATCH] drm/vblank: drop the mode argument from drm_calc_vbltimestamp_from_scanoutpos

2017-03-30 Thread Ville Syrjälä
On Wed, Mar 22, 2017 at 09:56:12PM +0100, Daniel Vetter wrote: > If we restrict this helper to only kms drivers (which is the case) we > can look up the correct mode easily ourselves. But it's a bit tricky: > > - All legacy drivers look at crtc->hwmode. But that is update already > at the

[Bug 100465] Hard lockup with radeonsi driver on FirePro W600, W9000 and W9100

2017-03-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=100465 --- Comment #2 from Julien Isorce --- Created attachment 130569 --> https://bugs.freedesktop.org/attachment.cgi?id=130569=edit Same result with amdgpu using a 4.10 kernel -- You are receiving this mail because: You

[PATCH] dim: Add apply-pull command

2017-03-30 Thread Daniel Vetter
I'm getting real lazy, let's start scripting this. Very rough draft, but adds a Link: (patchwork tracks pull requests too, maybe we'll start CI-ing them too), and sob line. In the future we might add more checks here ... Signed-off-by: Daniel Vetter --- dim | 34

Re: [PATCH 4/6] drm/amdgpu: drop alpha support

2017-03-30 Thread Christian König
Am 30.03.2017 um 15:09 schrieb Alex Deucher: On Thu, Mar 30, 2017 at 2:39 AM, Michel Dänzer wrote: On 29/03/17 09:55 PM, Christian König wrote: From: Christian König We will probably never see this combination. Signed-off-by: Christian König

[PATCH] drm: Clear e after kfree in drm_mode_page_flip_ioctl

2017-03-30 Thread Daniel Vetter
With the explicit retry loop static analyzers get confused by the control flow and believe that e could be accessed after kfree. That's not possible, but it's non-obvious, so let's clear it to NULL. We already cleared e = NULL at the top of the function, so this is all in line. Cc: Julia Lawall

DRM: Component framework API support

2017-03-30 Thread Eugeniy Paltsev
Hi, I am trying to add support of new component framework API in ARC PGU driver. The point is that for now we have ARC PGU driver which works with adv7511 encoder. Both of them don't support component framework API. I had to add support of component framework based dw_hdmi encoder to ARC PGU

Re: [Intel-gfx] [PATCH] drm/vblank: drop the mode argument from drm_calc_vbltimestamp_from_scanoutpos

2017-03-30 Thread Ville Syrjälä
On Thu, Mar 30, 2017 at 03:27:57PM +0200, Daniel Vetter wrote: > On Thu, Mar 30, 2017 at 2:03 PM, Ville Syrjälä > wrote: > > On Wed, Mar 22, 2017 at 09:56:12PM +0100, Daniel Vetter wrote: > >> If we restrict this helper to only kms drivers (which is the case) we >

[Bug 99841] Switching to VT freezes X only on a dual screen

2017-03-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99841 --- Comment #21 from Michel Dänzer --- If people are okay with that before it lands in 4.10.y, sure. -- You are receiving this mail because: You are the assignee for the bug.___

[PATCH] drm/i915: disable KASAN for handlers

2017-03-30 Thread Jiri Slaby
Handlers are currently the only blocker to compile the kernel with gcc 7 and KASAN+use-after-scope enabled: drivers/gpu/drm/i915/gvt/handlers.c:2200:1: error: the frame size of 43760 bytes is larger than 2048 bytes [-Werror=frame-larger-than=] drivers/gpu/drm/i915/gvt/handlers.c:2402:1: error:

[PATCH] drm/amdgpu/virt: fix spelling mistake: "hypervior" -> "hypervisor"

2017-03-30 Thread Colin King
From: Colin Ian King trivial fix to spelling mistake in DRM_ERROR error message Signed-off-by: Colin Ian King --- drivers/gpu/drm/amd/amdgpu/mxgpu_vi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH 10/11] drm/vmwgfx: Switch over to internal atomic API for STDU

2017-03-30 Thread Daniel Vetter
On Wed, Mar 29, 2017 at 02:05:26PM -0700, Sinclair Yeh wrote: > Hi Daniel, > > On Tue, Mar 28, 2017 at 09:49:38AM +0200, Daniel Vetter wrote: > > On Mon, Mar 27, 2017 at 03:01:03PM -0700, Sinclair Yeh wrote: > > > Switch over to using internal atomic API for mode set. > > > > > > This removes

Re: [Intel-gfx] [PATCH] Revert unrelated part of "drm: simplify the locking in the GETCRTC ioctl"

2017-03-30 Thread Daniel Vetter
On Thu, Mar 30, 2017 at 07:48:45AM +, Pandiyan, Dhinakaran wrote: > On Thu, 2017-03-30 at 09:36 +0200, Maarten Lankhorst wrote: > > Op 28-03-17 om 09:01 schreef Daniel Vetter: > > > > > > diff --git a/drivers/gpu/drm/i915/intel_display.c > > > b/drivers/gpu/drm/i915/intel_display.c > > >

Re: [PATCH] drm/mm: Split up long running selftests with cond_resched()

2017-03-30 Thread Joonas Lahtinen
On ke, 2017-03-29 at 10:10 +0100, Chris Wilson wrote: > Scatter a few cond_resched() in between phases of the drm_mm selftests > to try and prevent us incurring the wrath of the NMI watchdog. > > Signed-off-by: Chris Wilson > Cc: Joonas Lahtinen

Re: [PATCHv3 24/30] drm/omap: display: Add displays in sorted order to the panel_list

2017-03-30 Thread Tomi Valkeinen
On 29/03/17 13:08, Laurent Pinchart wrote: > Hi Tomi, > > Thank you for the patch. > > On Tuesday 28 Mar 2017 16:08:10 Tomi Valkeinen wrote: >> From: Peter Ujfalusi >> >> Keep the panel_list ordered according to aliases. The DRM connectors will >> be created following the

[Bug 100465] Hard lockup with radeonsi driver on FirePro W600, W9000 and W9100

2017-03-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=100465 --- Comment #1 from Julien Isorce --- Created attachment 130564 --> https://bugs.freedesktop.org/attachment.cgi?id=130564=edit xorg.log -- You are receiving this mail because: You are the assignee for the

[Bug 100465] Hard lockup with radeonsi driver on FirePro W600, W9000 and W9100

2017-03-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=100465 Bug ID: 100465 Summary: Hard lockup with radeonsi driver on FirePro W600, W9000 and W9100 Product: DRI Version: DRI git Hardware: x86-64 (AMD64) OS: All

Re: [PATCH 1/6] drm/ttm: cleanup and optimize ttm_bo_mem_compat

2017-03-30 Thread Christian König
Am 30.03.2017 um 08:38 schrieb Michel Dänzer: On 29/03/17 09:55 PM, Christian König wrote: From: Christian König No need to implement the same logic twice. Also check if the busy placements are identical to the already scanned placements before checking them.

[PATCH v5 2/6] media: uapi: Add RGB and YUV bus formats for Synopsys HDMI TX Controller

2017-03-30 Thread Neil Armstrong
In order to describe the RGB and YUV bus formats used to feed the Synopsys DesignWare HDMI TX Controller, add missing formats to the list of Bus Formats. Documentation for these formats is added in a separate patch. Reviewed-by: Archit Taneja Reviewed-by: Jose Abreu

Re: [PATCHv3 23/30] drm/omap: fix plane update warning when crtc is disabled

2017-03-30 Thread Tomi Valkeinen
On 29/03/17 13:30, Laurent Pinchart wrote: > Hi Tomi, > > Thank you for the patch. > > On Tuesday 28 Mar 2017 16:08:09 Tomi Valkeinen wrote: >> If omap_plane_atomic_update() is called when the crtc is disabled, and >> the timings are zero, we'll see the following warning: >> >> omapdss DISPC

Re: [PATCHv5 00/11] video/exynos/sti/cec: add CEC notifier & use in drivers

2017-03-30 Thread Daniel Vetter
On Wed, Mar 29, 2017 at 09:59:34PM +0200, Hans Verkuil wrote: > Hi Daniel, > > On 29/03/17 19:47, Daniel Vetter wrote: > > On Wed, Mar 29, 2017 at 04:15:32PM +0200, Hans Verkuil wrote: > >> From: Hans Verkuil > >> > >> This patch series adds the CEC physical address

[Bug 99841] Switching to VT freezes X only on a dual screen

2017-03-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99841 Elimar Riesebieter changed: What|Removed |Added CC|

[PATCH] kernel: drm/vmwgfx: limit the number of mip levels in vmw_gb_surface_define_ioctl()

2017-03-30 Thread Vladis Dronov
The 'req->mip_levels' parameter in vmw_gb_surface_define_ioctl() is a user-controlled 'uint32_t' value which is used as a loop count limit. This can lead to a kernel lockup and DoS. Add check for 'req->mip_levels'. References: https://bugzilla.redhat.com/show_bug.cgi?id=1437431 Signed-off-by:

[PATCHv4 15/29] drm/omap: fill dispc_ops

2017-03-30 Thread Tomi Valkeinen
This patch changes the current omapdss driver to fill a dispc_ops struct and set it to omapdss-base. Signed-off-by: Tomi Valkeinen --- drivers/gpu/drm/omapdrm/dss/dispc.c | 40 + 1 file changed, 40 insertions(+) diff --git

[PATCHv4 17/29] drm/omap: remove all EXPORT_SYMBOLs from dispc.c

2017-03-30 Thread Tomi Valkeinen
omapdrm now uses dispc_ops instead of direct function calls so we can remove all EXPORT_SYMBOLs from dispc. Most of the functions can also be made static, but a few are used outside dispc.c. Signed-off-by: Tomi Valkeinen --- drivers/gpu/drm/omapdrm/dss/dispc.c | 84

[PATCHv4 12/29] drm/omap: move display, dss-of, output to omapdss-base

2017-03-30 Thread Tomi Valkeinen
This patch moves the common parts of omapdss to omapdss-base so that both the current omapdss driver and the new omapdss6 driver can use them. Signed-off-by: Tomi Valkeinen --- drivers/gpu/drm/omapdrm/dss/Makefile | 6 +++--- drivers/gpu/drm/omapdrm/dss/display.c | 2 --

[PATCHv4 07/29] drm/omap: fix HDMI sync polarities

2017-03-30 Thread Tomi Valkeinen
While implementing writeback support, odd behavior of WBDELAYCOUNT was observed with the combination of WB capture and HDMI. The result of the debugging was that the HDMI sync polarities are not set correctly. The current code sets the sync polarities going from HDMI WP to DISPC according to the

[PATCHv4 14/29] drm/omap: add dispc_ops

2017-03-30 Thread Tomi Valkeinen
We want to change the dispc API from plain functions to a struct with functions pointers, so that omapdrm can call either omapdss or omapdss6 depending on the platform. This patch adds 'struct dispc_ops' and adds functions to omapdss-base to set and get the ops. Signed-off-by: Tomi Valkeinen

[PATCHv4 13/29] drm/omap: move dispc related dss-feat funcs to dispc

2017-03-30 Thread Tomi Valkeinen
omapdrm still uses a few non-dispc functions: dss_feat_get_num_mgrs(), dss_feat_get_num_ovls() and dss_feat_get_supported_color_modes(). We want to provide omapdrm a single dispc_ops function pointer struct so that omapdrm will use either the current omapdss or the new omapdss6 driver depending

[PATCHv4 03/29] drm/omap: remove divider constraint from hsdiv

2017-03-30 Thread Tomi Valkeinen
The driver only uses even dividers for hsdiv when pclk >= 100MHz, as odd dividers can create uneven duty cycle. However, while this holds true for some dividers like DISPC's LCK and PCK dividers, it is not actually true for hsdiv. hsdiv always produces even duty cycle, so the constraint can be

[PATCHv4 09/29] drm/omap: move dss_initialized to omapdss-base

2017-03-30 Thread Tomi Valkeinen
omapdss_is_initialized() is used to find out if omapdss has been probed successfully. This patch moves the related code to the common omapdss-base module, so that the same support will be there for both omapdss and omapdss6. Signed-off-by: Tomi Valkeinen ---

[PATCHv4 27/29] drm/omap: fix display SYNC/DE flags

2017-03-30 Thread Tomi Valkeinen
At the moment VSYNC/HSYNC/DE high/low flags set by the panel/encoder drivers get lost when the videotimings are translated to DRM's videomode, as DRM's mode does not have corresponding flags. DRM has bus-flags for this purpose, and while it lacks a few flags at the moment, it should be used here.

Re: [drm-intel:drm-intel-nightly 1066/1091] drivers/gpu/drm/drm_plane.c:933:48-49: ERROR: reference preceded by free on line 926 (fwd)

2017-03-30 Thread Daniel Vetter
On Wed, Mar 29, 2017 at 10:47:34PM +0200, Julia Lawall wrote: > The kfree on line 926 would only be a problem for the references to e on > lines 933 and 937 if the return value of drm_event_reserve_init can be > -EDEADLK. It cannot, but would indeed be prudent to reset to NULL, like we do at the

Re: [PATCH RESEND] drm: use .hword to represent 16-bit numbers

2017-03-30 Thread Daniel Vetter
On Wed, Mar 29, 2017 at 02:45:23PM +0100, Javi Merino wrote: > The size of .word is the size of a word in the given platform, which > for intel systems is 16-bits but other architectures use different > sizes. However, .hword emits 16-bit numbers regardless of the > platform (and despite the

[PATCHv4 16/29] drm/omap: use dispc_ops

2017-03-30 Thread Tomi Valkeinen
Change omapdrm to get dispc_ops and use that to call the dispc functions instead or direct function calls. The change is very straightforward. The only problem was in omap_crtc_init() which calls pipe2vbl(crtc), and at that point of time the crtc->dev link, which is used to get the dispc_ops,

[PATCHv4 19/29] drm/omap: fix replication logic

2017-03-30 Thread Tomi Valkeinen
DSS uses "replication logic" to convert color components from smaller bit widths to bigger bit widths. Without replication logic, the color component would be shifted and the least significant bits would be left at 0, whereas with replication logic, the least significat bits will be filled with

[PATCHv4 23/29] drm/omap: display: Add displays in sorted order to the panel_list

2017-03-30 Thread Tomi Valkeinen
From: Peter Ujfalusi Keep the panel_list ordered according to aliases. The DRM connectors will be created following the panel_list. By keeping the list ordered the DRM connectors will be created in the same order regardless of the driver probe order. Signed-off-by: Peter

[PATCHv4 20/29] drm/omap: dss: Functions to check components in the display/output list

2017-03-30 Thread Tomi Valkeinen
From: Peter Ujfalusi The functions can be used to check a component (by it's of_node) if it is part of the omapdss display or output list. If the component is found, it means that the driver is loaded. Signed-off-by: Peter Ujfalusi Signed-off-by:

[PATCHv4 10/29] drm/omap: output: use dev_err instead of DSSERR

2017-03-30 Thread Tomi Valkeinen
We don't have omapdss's custom error printing functions in the common omapdss-base module, to which we want to move output.c. This patch changes output.c to use dev_err instead of DSSERR so that it doesn't depend on DSSERR. Signed-off-by: Tomi Valkeinen Acked-by: Laurent

[PATCHv4 28/29] drm/omap: use drm_atomic_helper_shutdown()

2017-03-30 Thread Tomi Valkeinen
Use drm_atomic_helper_shutdown() to ensure that all crtcs are disabled when unloading the driver. Signed-off-by: Tomi Valkeinen --- drivers/gpu/drm/omapdrm/omap_drv.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/omapdrm/omap_drv.c

[PATCHv4 06/29] drm/omap: Add support for render nodes

2017-03-30 Thread Tomi Valkeinen
From: Hemant Hariyani Add support for render nodes in omap driver and allow required ioctls to be accessible via render nodes. This enables unprivileged clients to allocate resources like GEM buffers for rendering their content into. Mode setting (KMS ioctls) is not

[PATCHv4 18/29] drm/omap: remove unused dispc_wb_enable & dispc_wb_is_enabled

2017-03-30 Thread Tomi Valkeinen
Remove two unused WB functions. Signed-off-by: Tomi Valkeinen Reviewed-by: Laurent Pinchart --- drivers/gpu/drm/omapdrm/dss/dispc.c | 10 -- drivers/gpu/drm/omapdrm/dss/dss.h | 2 -- 2 files changed, 12 deletions(-) diff

[PATCHv4 21/29] drm/omap: dss: Support for detecting display stack readiness

2017-03-30 Thread Tomi Valkeinen
From: Peter Ujfalusi When omapdss is loaded (all core components are in place) create a list of devices used in the display graph. This list later can be used by omapdrm via the omapdss_stack_is_ready() function to check that these components are loaded. Based on this

[PATCHv4 11/29] drm/omap: display: don't use dsi_get_pixel_size()

2017-03-30 Thread Tomi Valkeinen
display.c uses dsi_get_pixel_size() which is implemented in the DSI driver, and we won't have that in the omapdss-base module, to which we want to move display.c This patch changes display.c not to use dsi_get_pixel_size(). The call can be replaced with a simple check for OMAP_DSS_DSI_FMT_RGB565.

[PATCHv4 25/29] drm/omap: displays: panel-dpi: Support for handling backlight devices

2017-03-30 Thread Tomi Valkeinen
From: Peter Ujfalusi The associated backlight device can be configured via DT by providing the phandle to the device. If the backlight device is configured, the driver can manage the backligt along with the panel's power state, iow it can turn on the backlight when the

[PATCHv4 24/29] drm/omap: poll only connectors where the connect/disconnect can be checked

2017-03-30 Thread Tomi Valkeinen
From: Peter Ujfalusi When the connector associated detect callback is not provided, we can not detect if the display is connected or disconnected. These displays do not support hot plug, they are always connected. Let DRM know that connectors w/o detect callback should not

[PATCHv4 22/29] drm/omap: Use omapdss_stack_is_ready() to check that the display stack is up

2017-03-30 Thread Tomi Valkeinen
From: Peter Ujfalusi Instead of 'guessing' based on aliases of the status of the DSS drivers, use the new interface to check that all needed drivers are loaded. In this way we can be sure that all needed drivers are loaded so it is safe to continue the probing of omapdrm.

[PATCHv4 29/29] drm/omap: fix crash on module unload

2017-03-30 Thread Tomi Valkeinen
When unloading omapdrm we get a NULL pointer deref in omap_drm_irq_uninstall(). This is caused by: 967dd48417874dd25491a4e933648f394a64f70f ("drm: remove drm_vblank_no_hw_counter assignment from driver code") We shut down all the crtcs at unload time before calling omap_drm_irq_uninstall, so the

[PATCHv4 26/29] drm/omap: dispc: improve debug print of display flags

2017-03-30 Thread Tomi Valkeinen
Instead of printing 0/1 for display flags like vsync high/low, use a tri-state print (-1/0/1) to indicate the "undefined" state. Signed-off-by: Tomi Valkeinen --- drivers/gpu/drm/omapdrm/dss/dispc.c | 20 +++- 1 file changed, 15 insertions(+), 5

[PATCH v5 4/6] drm: bridge: dw-hdmi: Switch to V4L bus format and encodings

2017-03-30 Thread Neil Armstrong
Some display pipelines can only provide non-RBG input pixels to the HDMI TX Controller, this patch takes the pixel format from the plat_data if provided. Reviewed-by: Jose Abreu Signed-off-by: Neil Armstrong ---

[PATCH v5 0/6] drm: bridge: dw-hdmi: Add support for Custom PHYs

2017-03-30 Thread Neil Armstrong
The Amlogic GX SoCs implements a Synopsys DesignWare HDMI TX Controller in combination with a very custom PHY. Thanks to Laurent Pinchart's changes, the HW report the following : Detected HDMI TX controller v2.01a with HDCP (meson_dw_hdmi_phy) The following differs from common PHY integration

[PATCH v5 3/6] documentation: media: Add documentation for new RGB and YUV bus formats

2017-03-30 Thread Neil Armstrong
Add documentation for added Bus Formats to describe RGB and YUV formats used as input to the Synopsys DesignWare HDMI TX Controller. Signed-off-by: Neil Armstrong --- Documentation/media/uapi/v4l/subdev-formats.rst | 871 +++- 1 file changed, 857

[PATCH v5 6/6] drm: bridge: dw-hdmi: Move HPD handling to PHY operations

2017-03-30 Thread Neil Armstrong
The HDMI TX controller support HPD and RXSENSE signaling from the PHY via it's STAT0 PHY interface, but some vendor PHYs can manage these signals independently from the controller, thus these STAT0 handling should be moved to PHY specific operations and become optional. The existing STAT0 HPD and

[PATCH v5 1/6] drm: bridge: dw-hdmi: Extract PHY interrupt setup to a function

2017-03-30 Thread Neil Armstrong
From: Laurent Pinchart In preparation for adding PHY operations to handle RX SENSE and HPD, group all the PHY interrupt setup code in a single location and extract it to a separate function. Signed-off-by: Laurent Pinchart

[PATCH v5 5/6] drm: bridge: dw-hdmi: Add Documentation on supported input formats

2017-03-30 Thread Neil Armstrong
This patch adds a new DRM documentation entry and links to the input format table added in the dw_hdmi header. Signed-off-by: Neil Armstrong --- Documentation/gpu/bridge/dw-hdmi.rst | 15 +++ Documentation/gpu/index.rst | 1 + 2 files changed, 16

Re: [PATCHv5 11/11] arm: sti: update sti-cec for CEC notifier support

2017-03-30 Thread Hans Verkuil
On 03/30/2017 11:30 AM, Patrice CHOTARD wrote: > Hi Benjamin > > On 03/30/2017 09:41 AM, Benjamin Gaignard wrote: >> + Patrice for sti DT > > In order to be coherent with all previous STi DT patches, > > can you update the commit message with "ARM: dts: STiH410: update > sti-cec for CEC

Re: [PATCHv3 06/30] drm/omap: Add support for render nodes

2017-03-30 Thread Daniel Vetter
On Thu, Mar 30, 2017 at 08:44:25AM +0200, David Herrmann wrote: > Hey > > On Wed, Mar 29, 2017 at 11:42 PM, Laurent Pinchart > wrote: > > Hi David, > > > > On Wednesday 29 Mar 2017 14:51:48 David Herrmann wrote: > >> On Wed, Mar 29, 2017 at 2:20 PM, Laurent

Re: [PATCH 1/2] drm/bridge: ti-tfp410: support hpd via gpio

2017-03-30 Thread Archit Taneja
On 03/28/2017 07:02 PM, Jyri Sarha wrote: On 03/27/17 08:58, Archit Taneja wrote: Hi, On 03/07/2017 03:21 AM, Christopher Spinrath wrote: Hi Fabio, On 03/06/2017 10:46 PM, Fabio Estevam wrote: Hi Christopher, On Mon, Mar 6, 2017 at 6:40 PM, wrote:

Re: [PATCH v4 00/11] drm/fb-helper: Deferred setup support

2017-03-30 Thread Andrzej Hajda
Hi Thierry, On 29.03.2017 16:43, Thierry Reding wrote: > From: Thierry Reding > > This set of patches adds support for deferring FB helper setup, which is > useful to obtain a sane configuration even when no outputs are available > during probe. > > One example is HDMI, where

Re: [PATCH] Revert "drm/radeon: Try evicting from CPU accessible to inaccessible VRAM first"

2017-03-30 Thread Julien Isorce
Thx for the suggestions. No, it does not respond to ping. radeon.dpm=0 does not help. But it only tells to use the old power management right ? So I tried: low, mid and high for /sys/class/drm/card0/device/prower_profile (and setting profile for power_mode) With radeon.dpm=1 I tried all values

[PATCHv4 08/29] drm/omap: add omapdss-base.ko

2017-03-30 Thread Tomi Valkeinen
We are working towards enabling omapdss6, which will consists of a new dss, dispc and dpi drivers. omapdss6 will be a new module. The panel, encoder and omapdrm will need to use either the current omapdss driver or the new omapdss6 driver, depending on the platform. This will be implemented with

[PATCHv4 04/29] drm/omap: decrease min width & height

2017-03-30 Thread Tomi Valkeinen
mode_config's min_width and min_height are both set to 32, which is overly restrictive. The real limits depend on whether we're configuring a crtc or a plane, but a limit of 8x2 is safe for both cases. Signed-off-by: Tomi Valkeinen Reviewed-by: Laurent Pinchart

[PATCHv4 02/29] drm/omap: refactor CRTC HW property setup

2017-03-30 Thread Tomi Valkeinen
The current driver doesn't expose any of the CRTC HW properties like background color or transparency key, and sets them at CRTC enable time. Refactor this into a separate function and call that function from omap_crtc_atomic_flush(). This is the behavior we want when the properties can be

[PATCHv4 01/29] drm/omap: work-around for errata i886

2017-03-30 Thread Tomi Valkeinen
DRA7 errata i886 (FPDLink PLL Unlocks With Certain SoC PLL M/N Values) says that FPDLink is sensitive to jitter on the vout clock, and that low PLL M and N values result in more jitter than high M and N values. This patch implements a workaround for the problem by changing the PLL setup to search

[PATCHv4 05/29] drm/omap: improve DPI clock selection on DRA7xx

2017-03-30 Thread Tomi Valkeinen
The clock source selection for the LCD outputs is too hardcoded at the moment. For example, LCD3 is set to use PLL2_1, and PLL2 doesn't exist on DRA72x SoCs. There are quite many ways to configure the clocks, even using HDMI PLL for LCD outputs, but enabling full configuration of the clocks is

[PATCHv4 00/29] drm/omap: miscallaneous improvements

2017-03-30 Thread Tomi Valkeinen
This is the fouth revision of this series. Note that this series depends on "drm/atomic: Introduce drm_atomic_helper_shutdown" which has not yet been merged to drm-next. The main changes in v4: - fix missing breaks in "improve DPI clock selection on DRA7xx" - dropped "fix plane update warning

Re: [PATCH 3/3] drm/i915: Add format modifiers for Intel

2017-03-30 Thread Ville Syrjälä
On Wed, Mar 29, 2017 at 03:11:26PM -0700, Ben Widawsky wrote: > On 17-03-29 23:17:13, Ville Syrjälä wrote: > >On Fri, Mar 24, 2017 at 02:29:50PM -0700, Ben Widawsky wrote: > >> This was based on a patch originally by Kristian. It has been modified > >> pretty heavily to use the new callbacks from

Re: [PATCH] drm: Convert cmpxchg(bool) back to a two step operation

2017-03-30 Thread Ville Syrjälä
On Thu, Mar 30, 2017 at 03:08:32PM +0100, Chris Wilson wrote: > ARM v6 (at least) only allows cmpxchg on 32bit variables which doesn't > always include the bool type. > > drivers/built-in.o: In function `vblank_disable_and_save': > imx-ocotp.c:(.text+0xb45e8): undefined reference to

[Bug 100395] DC, Powerplay, Tonga, top screen flicker with current amd-staging-4.9

2017-03-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=100395 --- Comment #6 from Harry Wentland --- Thanks, Andy, for the report and taking the time to bisect. Jordan from my team spotted the bug as well and is working on a solution. If you're curious about the cause of this...

Re: [PATCH 1/6] virtio: wrap find_vqs

2017-03-30 Thread Michael S. Tsirkin
On Thu, Mar 30, 2017 at 02:00:08PM +0800, Jason Wang wrote: > > > On 2017年03月30日 04:48, Michael S. Tsirkin wrote: > > We are going to add more parameters to find_vqs, let's wrap the call so > > we don't need to tweak all drivers every time. > > > > Signed-off-by: Michael S.

[PATCH] drm: Convert cmpxchg(bool) back to a two step operation

2017-03-30 Thread Chris Wilson
ARM v6 (at least) only allows cmpxchg on 32bit variables which doesn't always include the bool type. drivers/built-in.o: In function `vblank_disable_and_save': imx-ocotp.c:(.text+0xb45e8): undefined reference to `__bad_cmpxchg' Makefile:986: recipe for target 'vmlinux' failed Reported-by: kbuild

Re: [PATCH] drm: Clear e after kfree in drm_mode_page_flip_ioctl

2017-03-30 Thread Harry Wentland
Reviewed-by: Harry Wentland On 2017-03-30 09:32 AM, Daniel Vetter wrote: With the explicit retry loop static analyzers get confused by the control flow and believe that e could be accessed after kfree. That's not possible, but it's non-obvious, so let's clear it to

Re: [PATCH] drm: Clear e after kfree in drm_mode_page_flip_ioctl

2017-03-30 Thread Daniel Vetter
On Thu, Mar 30, 2017 at 10:26:24AM -0400, Harry Wentland wrote: > Reviewed-by: Harry Wentland Thanks for the quick review, pushed to drm-misc. -Daniel > > On 2017-03-30 09:32 AM, Daniel Vetter wrote: > > With the explicit retry loop static analyzers get confused by the

Re: [Intel-gfx] [PATCH] drm/vblank: drop the mode argument from drm_calc_vbltimestamp_from_scanoutpos

2017-03-30 Thread Daniel Vetter
On Thu, Mar 30, 2017 at 04:41:57PM +0300, Ville Syrjälä wrote: > On Thu, Mar 30, 2017 at 03:27:57PM +0200, Daniel Vetter wrote: > > On Thu, Mar 30, 2017 at 2:03 PM, Ville Syrjälä > > wrote: > > > On Wed, Mar 22, 2017 at 09:56:12PM +0100, Daniel Vetter wrote: > > >>

[PATCH libdrm] configure.ac: bring back pthread-stubs check

2017-03-30 Thread Emil Velikov
Accidentally removed with earlier commit. Although rather than simply adding the check for all platforms, use the same heuristics as we do in mesa. Namely: pthread-stubs is a thing only for BSD platforms. Everyone else should have lightweight pthread API in their C runtime library. Fixes:

[PATCH v3 2/2] drm/pl111: Initial drm/kms driver for pl111

2017-03-30 Thread Eric Anholt
From: Tom Cooksey This is a modesetting driver for the pl111 CLCD display controller found on various ARM platforms such as the Versatile Express. The driver has only been tested on the bcm911360_entphn platform so far, with PRIME-based buffer sharing between vc4 and clcd.

[PATCH v3 1/2] video: ARM CLCD: Move registers to a separate header.

2017-03-30 Thread Eric Anholt
We'd like to reuse these register definitions for the DRM CLCD driver, but there's a bunch of fbdev-specific code in the current header. Signed-off-by: Eric Anholt --- include/linux/amba/clcd-regs.h | 76 ++ include/linux/amba/clcd.h

Re: [PATCH 2/2] drm/amdgpu: Avoid overflows/divide-by-zero in latency_watermark calculations.

2017-03-30 Thread Alex Deucher
On Wed, Mar 29, 2017 at 4:09 PM, Mario Kleiner wrote: > At dot clocks > approx. 250 Mhz, some of these calcs will overflow and > cause miscalculation of latency watermarks, and for some overflows also > divide-by-zero driver crash ("divide error: [#1] PREEMPT SMP"

[PATCH] drm: Fix locking gotcha in page_flip ioctl

2017-03-30 Thread Daniel Vetter
We want to lock the primary plane, not the cursor (which might be optional). Real bad case of copy-paste fail, unfortunately our CI didn't catch that because i915 does have a cursor plane. Cc: Eric Anholt Reported-by: Eric Anholt Fixes: 29dc0d1de182 ("drm: Roll

Re: CPU mapping of split VRAM buffers

2017-03-30 Thread Michel Dänzer
On 29/03/17 09:55 PM, Christian König wrote: > Hi guys, > > this set implements CPU mapping of split VRAM buffers and could > help with some performance issues regarding this. > > Please review and/or comment, Patches 5 & 6 look mostly good to me, but I don't fully understand all changes in

Re: [PATCHv3 06/30] drm/omap: Add support for render nodes

2017-03-30 Thread David Herrmann
Hey On Wed, Mar 29, 2017 at 11:42 PM, Laurent Pinchart wrote: > Hi David, > > On Wednesday 29 Mar 2017 14:51:48 David Herrmann wrote: >> On Wed, Mar 29, 2017 at 2:20 PM, Laurent Pinchart wrote: >> > On Wednesday 29 Mar 2017 11:58:23 Tomi Valkeinen wrote: >> >>

Re: [PATCH] drm/i915: fix build error without CONFIG_BACKLIGHT_CLASS_DEVICE

2017-03-30 Thread Jani Nikula
On Wed, 29 Mar 2017, Tobias Regnery wrote: > With CONFIG_ACPI=n and CONFIG_BACKLIGHT_CLASS_DEVICE=n we see the following > link error in the i915 driver: > > drivers/built-in.o: In function 'intel_backlight_device_register': > (.text+0x2a921d): undefined reference to

[Bug 99841] Switching to VT freezes X only on a dual screen

2017-03-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99841 --- Comment #20 from Jari Tahvanainen --- Michel and others - landed to drm-tip. Ready for resolved+fixed ? Or even verified... commit 12ffed96d4369f086261ba2ee734fa8c932d7f55 Author: Michel Dänzer

[PATCH] Revert unrelated part of "drm: simplify the locking in the GETCRTC ioctl"

2017-03-30 Thread Maarten Lankhorst
Op 28-03-17 om 09:01 schreef Daniel Vetter: > > diff --git a/drivers/gpu/drm/i915/intel_display.c > b/drivers/gpu/drm/i915/intel_display.c > index 68cded453882..43dbad62786e 100644 > --- a/drivers/gpu/drm/i915/intel_display.c > +++ b/drivers/gpu/drm/i915/intel_display.c > @@ -12463,6 +12463,11

Re: [PATCH libdrm] configure.ac: bring back pthread-stubs check

2017-03-30 Thread Eric Engestrom
On Thursday, 2017-03-30 18:01:12 +0100, Emil Velikov wrote: > Accidentally removed with earlier commit. Although rather than simply > adding the check for all platforms, use the same heuristics as we do in > mesa. > > Namely: pthread-stubs is a thing only for BSD platforms. Everyone else > should

Re: [PATCH] drm: Fix locking gotcha in page_flip ioctl

2017-03-30 Thread Harry Wentland
Reviewed-by: Harry Wentland Harry On 2017-03-30 04:48 PM, Daniel Vetter wrote: We want to lock the primary plane, not the cursor (which might be optional). Real bad case of copy-paste fail, unfortunately our CI didn't catch that because i915 does have a cursor plane.

Re: [PATCH v3 2/2] drm/pl111: Initial drm/kms driver for pl111

2017-03-30 Thread Eric Anholt
Eric Anholt writes: > From: Tom Cooksey > > This is a modesetting driver for the pl111 CLCD display controller > found on various ARM platforms such as the Versatile Express. The > driver has only been tested on the bcm911360_entphn platform so far, > with

Re: [PATCH v4 3/6] drm/omap: Fix one ugly indentation style break left by coccinelle

2017-03-30 Thread Laurent Pinchart
Hi Jyri, Thank you for the patch. On Friday 24 Mar 2017 16:47:53 Jyri Sarha wrote: > Fix one ugly indentation style break left by the previous coccilnelle > patch. > > Signed-off-by: Jyri Sarha Acked-by: Laurent Pinchart > --- >

Re: [PATCH v4 2/6] drm/omap: Rename enum omap_plane to enum omap_plane_id

2017-03-30 Thread Laurent Pinchart
Hi Jyri, On Friday 24 Mar 2017 16:47:52 Jyri Sarha wrote: > The enum omap_plane conflicted with the same struct name for omapdrm > plane private data. This rename should solve the conflict. > > The rename was implement with this very simple coccinelle patch: > > @@ > @@

Re: [PATCH v4 6/6] drm/omap: Implement CTM property for CRTC using OVL managers CPR matrix

2017-03-30 Thread Laurent Pinchart
Hi Jyri, Thank you for the patch. On Friday 24 Mar 2017 16:47:56 Jyri Sarha wrote: > Implement CTM color management property for OMAP CRTC using DSS > overlay manager's Color Phase Rotation matrix. The CPR matrix does not > exactly match the CTM property documentation. On DSS the CPR matrix is >

Re: [PATCH v4 1/6] drm/omap: Get rid of DRM_OMAP_NUM_CRTCS config option

2017-03-30 Thread Laurent Pinchart
Hi Jyri, Thank you for the patch. On Friday 24 Mar 2017 16:47:51 Jyri Sarha wrote: > Allocate one CRTC for each connected output and get rid of > DRM_OMAP_NUM_CRTCS config option. We still can not create more CRTCs > than we have DSS display managers. We also reserve one overlay per > CRTC for

[pull] radeon and amdgpu drm-next-4.12

2017-03-30 Thread Alex Deucher
Hi Dave, New stuff for 4.12: - Preliminary vega10 support - Support for multi-level page tables - GPU sensor stuff for mesa - job tracing improvements - PRT support for sparse buffers - Additional SR-IOV improvements - ttm improvements - misc bug fixes and code cleanups The following changes

Re: [PATCH v4 4/6] drm/omap: Remove the obsolete #define omap_plane _omap_plane hack

2017-03-30 Thread Laurent Pinchart
Hi Jyri, Thank you for the patch. On Friday 24 Mar 2017 16:47:54 Jyri Sarha wrote: > Remove the obsolete "#define omap_plane _omap_plane" hack and other > related hacks to get around the enum omap_plane colliding with struct > omap_plane. > > Signed-off-by: Jyri Sarha

Re: [ANNOUNCE] libdrm 2.4.76

2017-03-30 Thread Jani Nikula
On Wed, 29 Mar 2017, Marek Olšák wrote: > libdrm 2.4.76 has been released. > > git tag: libdrm-2.4.76 Should the release tags be signed? For a couple of years that has been the practise until this release. Admittedly RELEASING doesn't even say anything about tagging, let alone

Re: [PATCH 4/6] drm/amdgpu: drop alpha support

2017-03-30 Thread Michel Dänzer
On 29/03/17 09:55 PM, Christian König wrote: > From: Christian König > > We will probably never see this combination. > > Signed-off-by: Christian König > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 25 - > 1 file

Re: [PATCH 3/6] drm/ttm: add TTM_PL_FLAG_CONTIGUOUS

2017-03-30 Thread Michel Dänzer
On 29/03/17 09:55 PM, Christian König wrote: > From: Christian König > > This allows drivers to specify if they need a contiguous allocation or not. > > Signed-off-by: Christian König [...] > diff --git a/include/drm/ttm/ttm_placement.h

  1   2   >