Re: drm-next-misc merge breaks vmwgfx

2017-04-06 Thread Thomas Hellstrom
On 04/06/2017 02:34 PM, Daniel Vetter wrote: > Hi Thomas, > > Bisected an offender already? Afaik there's no one else who reported > issues thus far, and for our own CI it seems all still fine. > -Daniel Hi, Daniel, Yes, I rebased drm-misc-next on top of vmwgfx-next and found the culprit to be

Re: [PATCH libdrm 1/2] etnaviv: sync uapi header

2017-04-06 Thread Philipp Zabel
Hi Emil, On Thu, 2017-04-06 at 12:08 +0100, Emil Velikov wrote: > Hi Philipp > > On 5 April 2017 at 13:34, Philipp Zabel wrote: > > Import the etnaviv header changes from kernel commits 9ad59fea162c > > ("drm/etnaviv: submit support for in-fences") and 78ec187f64fa > >

Re: drm-next-misc merge breaks vmwgfx

2017-04-06 Thread Daniel Vetter
On Thu, Apr 6, 2017 at 4:10 PM, Thomas Hellstrom wrote: > > Also, when testing the tip of drm-misc-next (with the non-atomic vmwgfx) > there appeared to be warnings about a non-NULL > dev->mode_config.acquire_ctx. I'll see if I can reproduce those, but > perhaps removing

Re: drm-next-misc merge breaks vmwgfx

2017-04-06 Thread Thomas Hellstrom
On 04/06/2017 04:47 PM, Daniel Vetter wrote: > On Thu, Apr 6, 2017 at 4:10 PM, Thomas Hellstrom > wrote: >> Also, when testing the tip of drm-misc-next (with the non-atomic vmwgfx) >> there appeared to be warnings about a non-NULL >> dev->mode_config.acquire_ctx. I'll see

Re: drm-next-misc merge breaks vmwgfx

2017-04-06 Thread Daniel Vetter
On Thu, Apr 6, 2017 at 4:56 PM, Thomas Hellstrom wrote: > On 04/06/2017 04:47 PM, Daniel Vetter wrote: >> On Thu, Apr 6, 2017 at 4:10 PM, Thomas Hellstrom >> wrote: >>> Also, when testing the tip of drm-misc-next (with the non-atomic vmwgfx) >>>

Re: [PATCH v3 8/9] drm/rockchip: gem: Don't alloc/free gem buf when dev_private is invalid

2017-04-06 Thread Sean Paul
On Thu, Apr 06, 2017 at 10:47:59AM +0800, jeffy wrote: > Hi Sean, > > On 04/06/2017 12:28 AM, Sean Paul wrote: > > On Wed, Apr 05, 2017 at 04:29:26PM +0800, Jeffy Chen wrote: > > > After unbinding drm, the userspace may still has a chance to access > > > gem buf. > > > > > > Add a sanity check

Re: drm-next-misc merge breaks vmwgfx

2017-04-06 Thread Daniel Vetter
Hi Thomas, Bisected an offender already? Afaik there's no one else who reported issues thus far, and for our own CI it seems all still fine. -Daniel On Wed, Apr 5, 2017 at 7:45 PM, Thomas Hellstrom wrote: > Hi! > > It appears like the drm-next commit 320d8c3d3 "Merge tag

Re: [PATCH 0/4] drm/atomic: Cleanups for adding connector atomic check function.

2017-04-06 Thread Sean Paul
On Thu, Apr 06, 2017 at 01:18:59PM +0200, Maarten Lankhorst wrote: > Some small cleanups I came across to make drm_atomic_helper_check_modeset > more readable. > > This makes it a lot more clear what atomic_check does and why it's called in > the place it is. > > Maarten Lankhorst (4): >

[PATCH v2 0/4] Add ZTE VGA driver support

2017-04-06 Thread Shawn Guo
From: Shawn Guo The series adds the driver for ZTE VGA device, which becomes the third VOU output device we support, besides the existing HDMI and TV Encoder. Changes for v2: - Add return check for encoder and connector init function calls. - Improve comments in function

Re: [PATCH libdrm 2/2] etnaviv: add fence fd support

2017-04-06 Thread Philipp Zabel
On Thu, 2017-04-06 at 10:01 +0200, Christian Gmeiner wrote: > 2017-04-05 18:25 GMT+02:00 Philipp Zabel : > > On Wed, 2017-04-05 at 17:07 +0100, Eric Engestrom wrote: > >> On Wednesday, 2017-04-05 14:34:56 +0200, Philipp Zabel wrote: > >> > Add etna_cmd_stream_flush_explicit

[PATCH v2] kernel: drm/vmwgfx: limit the number of mip levels in vmw_gb_surface_define_ioctl()

2017-04-06 Thread Vladis Dronov
The 'req->mip_levels' parameter in vmw_gb_surface_define_ioctl() is a user-controlled 'uint32_t' value which is used as a loop count limit. This can lead to a kernel lockup and DoS. Add check for 'req->mip_levels'. References: https://bugzilla.redhat.com/show_bug.cgi?id=1437431 Signed-off-by:

[PATCH v2 4/4] drm: zte: add VGA driver support

2017-04-06 Thread Shawn Guo
From: Shawn Guo It adds VGA driver support, which needs to configure corresponding VOU interface in RGB_888 format, and thus the following changes are needed on zx_vou. - Rename the CSC block of Graphic Layer a bit to make it more specific, and add CSC of Channel to

Re: drm-next-misc merge breaks vmwgfx

2017-04-06 Thread Daniel Vetter
On Thu, Apr 6, 2017 at 4:10 PM, Thomas Hellstrom wrote: > On 04/06/2017 02:34 PM, Daniel Vetter wrote: >> Hi Thomas, >> >> Bisected an offender already? Afaik there's no one else who reported >> issues thus far, and for our own CI it seems all still fine. >> -Daniel > > Hi,

[Bug 100580] Adding unreachable "return" and "continue" in a GLSL shader leads to different image

2017-04-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=100580 Roland Scheidegger changed: What|Removed |Added Component|Drivers/Gallium/radeonsi|Mesa core

[PATCH v2 1/4] drm: zte: do not enable clock auto-gating by default

2017-04-06 Thread Shawn Guo
From: Shawn Guo Some VOU modules do not work well with clock auto-gating. For example, VGA I2C bus will fail to read EDID data from monitor. Let's not enable this feature by default, and leave it to the possible future low-power optimization. Signed-off-by: Shawn Guo

[PATCH v2 2/4] drm: zte: move CSC register definitions into a common header

2017-04-06 Thread Shawn Guo
From: Shawn Guo The CSC (Color Space Conversion) block in VOU is used by not only Graphic Layer (plane) but also channel (CRTC) module. Let's move its register definitions into a common header, so that CRTC driver can include it when needed. Signed-off-by: Shawn Guo

Re: [PATCH] drm/exynos: clean up description of exynos_drm_crtc

2017-04-06 Thread Tobias Jakobi
Hello Inki, Inki Dae wrote: > This patch removes unnecessary descriptions on > exynos_drm_crtc structure and adds one description > which specifies what pipe_clk member does. > > pipe_clk support had been added by below patch without any description, >drm/exynos: add support for

Re: [PATCH v2 4/4] drm: zte: add VGA driver support

2017-04-06 Thread Sean Paul
On Thu, Apr 06, 2017 at 11:01:10PM +0800, Shawn Guo wrote: > From: Shawn Guo > > It adds VGA driver support, which needs to configure corresponding VOU > interface in RGB_888 format, and thus the following changes are needed > on zx_vou. > > - Rename the CSC block of

[Bug 100465] Hard lockup with radeonsi driver on FirePro W600, W9000 and W9100

2017-04-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=100465 --- Comment #9 from Julien Isorce --- When using R600_DEBUG=check_vm on both Xorg and the gl app I can get some output in kern.log. It looks like a "ring 0 stalled" is detected and then follow a gpu softreset which

Re: drm-next-misc merge breaks vmwgfx

2017-04-06 Thread Thomas Hellstrom
On 04/06/2017 05:01 PM, Daniel Vetter wrote: > On Thu, Apr 6, 2017 at 4:56 PM, Thomas Hellstrom > wrote: >> On 04/06/2017 04:47 PM, Daniel Vetter wrote: >>> On Thu, Apr 6, 2017 at 4:10 PM, Thomas Hellstrom >>> wrote: Also, when testing the tip

Re: [RFC PATCH xserver] modesetting: re-set the crtc's mode when link-status goes BAD

2017-04-06 Thread Manasi Navare
On Sun, Apr 02, 2017 at 07:21:09PM -0700, Eric Anholt wrote: > Daniel Vetter writes: > > > On Fri, Mar 31, 2017 at 05:22:09PM -0700, Eric Anholt wrote: > >> Manasi Navare writes: > >> > >> > On Fri, Mar 31, 2017 at 01:08:41PM -0700, Eric Anholt

[PATCH] drm/virtio: don't leak bo on drm_gem_object_init failure

2017-04-06 Thread Gerd Hoffmann
Reported-by: 李强 Signed-off-by: Gerd Hoffmann --- drivers/gpu/drm/virtio/virtgpu_object.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/virtio/virtgpu_object.c b/drivers/gpu/drm/virtio/virtgpu_object.c index

[Bug 100465] Hard lockup with radeonsi driver on FirePro W600, W9000 and W9100

2017-04-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=100465 --- Comment #10 from Alex Deucher --- (In reply to Julien Isorce from comment #9) > > So I have 4 questions: > 1: Can an application causes a "ring 0 stalled" ? or is it a driver bug > (kernel side or mesa/drm or

Re: [PATCH v2 3/4] dt-bindings: display: add support for ZTE VGA device

2017-04-06 Thread Rob Herring
On Thu, Apr 6, 2017 at 10:01 AM, Shawn Guo wrote: > From: Shawn Guo > > It adds bindings doc for ZTE VOU VGA output device. > > Signed-off-by: Shawn Guo > --- > .../devicetree/bindings/display/zte,vou.txt | 21 >

Re: [PATCH 12/15] drm: Add acquire ctx to ->gamma_set hook

2017-04-06 Thread Eric Anholt
Daniel Vetter writes: > Atomic helpers really want this instead of the hacked-up legacy > backoff trick, which unfortunately prevents drivers from using their > own private drm_modeset_locks. > > Aside: There's a few atomic drivers (nv50, vc4, soon vmwgfx) which > don't

[PATCH v2 3/4] dt-bindings: display: add support for ZTE VGA device

2017-04-06 Thread Shawn Guo
From: Shawn Guo It adds bindings doc for ZTE VOU VGA output device. Signed-off-by: Shawn Guo --- .../devicetree/bindings/display/zte,vou.txt | 21 + 1 file changed, 21 insertions(+) diff --git

Re: [PATCH 12/15] drm: Add acquire ctx to ->gamma_set hook

2017-04-06 Thread Daniel Vetter
On Thu, Apr 6, 2017 at 6:51 PM, Eric Anholt wrote: > Daniel Vetter writes: >> Atomic helpers really want this instead of the hacked-up legacy >> backoff trick, which unfortunately prevents drivers from using their >> own private drm_modeset_locks. >> >>

Re: DRM_FORMAT_* byte order (was: Re: [PATCH] drm: virtio: fix virtio_gpu_cursor_formats)

2017-04-06 Thread Ville Syrjälä
On Thu, Apr 06, 2017 at 10:29:43AM +0200, Gerd Hoffmann wrote: > Hi, > > > > static const uint32_t virtio_gpu_cursor_formats[] = { > > > +#ifdef __BIG_ENDIAN > > > + DRM_FORMAT_BGRA, > > > +#else > > > DRM_FORMAT_ARGB, > > > +#endif > > > > DRM formats are supposed to be little

Re: DRM_FORMAT_* byte order (was: Re: [PATCH] drm: virtio: fix virtio_gpu_cursor_formats)

2017-04-06 Thread Ville Syrjälä
On Thu, Apr 06, 2017 at 08:27:47PM +0300, Ville Syrjälä wrote: > On Thu, Apr 06, 2017 at 10:29:43AM +0200, Gerd Hoffmann wrote: > > Hi, > > > > > > static const uint32_t virtio_gpu_cursor_formats[] = { > > > > +#ifdef __BIG_ENDIAN > > > > + DRM_FORMAT_BGRA, > > > > +#else > > > >

Re: drm-next-misc merge breaks vmwgfx

2017-04-06 Thread Thomas Hellstrom
On 04/06/2017 04:46 PM, Daniel Vetter wrote: > On Thu, Apr 6, 2017 at 4:10 PM, Thomas Hellstrom > wrote: >> On 04/06/2017 02:34 PM, Daniel Vetter wrote: >>> Hi Thomas, >>> >>> Bisected an offender already? Afaik there's no one else who reported >>> issues thus far, and for

[pull] amdgpu drm-next-4.12

2017-04-06 Thread Alex Deucher
Hi Dave, A few more things for 4.12: - ttm and amdgpu support for non-contiguous vram CPU mappings - lots of bug fixes and cleanups for vega10 - misc bug fixes and code cleanups The following changes since commit e1b489d207c73e67810659a88c45b8db4bd62773: Merge tag 'omapdrm-4.12' of

Re: drm-next-misc merge breaks vmwgfx

2017-04-06 Thread Daniel Vetter
On Thu, Apr 6, 2017 at 8:01 PM, Thomas Hellstrom wrote: > On 04/06/2017 04:46 PM, Daniel Vetter wrote: >> On Thu, Apr 6, 2017 at 4:10 PM, Thomas Hellstrom >> wrote: >>> On 04/06/2017 02:34 PM, Daniel Vetter wrote: Hi Thomas, Bisected

Re: [PATCH] drm: Take mode_config.mutex in setcrtc ioctl

2017-04-06 Thread Alex Deucher
On Thu, Apr 6, 2017 at 3:06 PM, Daniel Vetter wrote: > Legacy drivers insist that we really take all the locks in this path, > and the harm in doing so is minimal. > > v2: Like git add, it exists :( > > Fixes: 2ceb585a956c ("drm: Add explicit acquire ctx handling around >

[PATCH] drm: Take mode_config.mutex in setcrtc ioctl

2017-04-06 Thread Daniel Vetter
Legacy drivers insist that we really take all the locks in this path, and the harm in doing so is minimal. Fixes: 2ceb585a956c ("drm: Add explicit acquire ctx handling around ->set_config") Cc: Harry Wentland Cc: Daniel Vetter Cc: Daniel Vetter

[PATCH] drm/atomic: Acquire connection_mutex lock in drm_helper_probe_single_connector_modes, v4.

2017-04-06 Thread Maarten Lankhorst
mode_valid() called from drm_helper_probe_single_connector_modes() may need to look at connector->state because what a valid mode is may depend on connector properties being set. For example some HDMI modes might be rejected when a connector property forces the connector into DVI mode. Some

[PATCH] drm/vmwgfx: Fix fbdev emulation using legacy functions

2017-04-06 Thread Daniel Vetter
I've broken this by removing the backoff handling from the set_config2atomic helper in commit 38b6441e4e75c0b319cfe4d9364c1059fc1e3c2b Author: Daniel Vetter Date: Wed Mar 22 22:50:58 2017 +0100 drm/atomic-helper: Remove the backoff hack from set_config Fixing this

Re: [PATCH] drm: Take mode_config.mutex in setcrtc ioctl

2017-04-06 Thread Alex Deucher
On Thu, Apr 6, 2017 at 2:55 PM, Daniel Vetter wrote: > Legacy drivers insist that we really take all the locks in this path, > and the harm in doing so is minimal. > > Fixes: 2ceb585a956c ("drm: Add explicit acquire ctx handling around > ->set_config") > Cc: Harry

[PATCH] drm: Take mode_config.mutex in setcrtc ioctl

2017-04-06 Thread Daniel Vetter
Legacy drivers insist that we really take all the locks in this path, and the harm in doing so is minimal. v2: Like git add, it exists :( Fixes: 2ceb585a956c ("drm: Add explicit acquire ctx handling around ->set_config") Cc: Harry Wentland Cc: Daniel Vetter

Re: [PATCH] drm: panels: Add MAINTAINERS entry for LVS panel driver

2017-04-06 Thread Dave Airlie
On 5 April 2017 at 16:51, Laurent Pinchart wrote: > As the DRM LVDS panel driver uses a different approach to DT bindings > compared to what Thierry Reding advocates, add a specific MAINTAINERS > entry to avoid bothering Thierry with requests related to

Re: [PATCH] drm: Take mode_config.mutex in setcrtc ioctl

2017-04-06 Thread Daniel Vetter
On Thu, Apr 06, 2017 at 03:09:04PM -0400, Alex Deucher wrote: > On Thu, Apr 6, 2017 at 3:06 PM, Daniel Vetter wrote: > > Legacy drivers insist that we really take all the locks in this path, > > and the harm in doing so is minimal. > > > > v2: Like git add, it exists :( >

Re: [PATCH 0/4] drm/atomic: Cleanups for adding connector atomic check function.

2017-04-06 Thread Sean Paul
On Thu, Apr 06, 2017 at 08:48:36AM -0400, Sean Paul wrote: > On Thu, Apr 06, 2017 at 01:18:59PM +0200, Maarten Lankhorst wrote: > > Some small cleanups I came across to make drm_atomic_helper_check_modeset > > more readable. > > > > This makes it a lot more clear what atomic_check does and why

Re: [PATCH v4] drm: Add DPCD definitions for DP 1.4 DSC feature

2017-04-06 Thread Manasi Navare
Hi Ander, Could you take a look at this? Manasi On Mon, Apr 03, 2017 at 03:51:10PM -0700, Manasi Navare wrote: > From: "Navare, Manasi D" > > Display stream compression is supported on DP 1.4 DP > devices. This patch adds the corersponding DPCD > register

Re: [PATCH v11 1/3] dt-bindings: Add support for samsung s6e3ha2 panel binding

2017-04-06 Thread Thierry Reding
On Wed, Mar 08, 2017 at 10:42:35AM +0900, Hoegeun Kwon wrote: > The Samsung s6e3ha2 is a 5.7" 1440x2560 AMOLED panel connected > using MIPI-DSI interfaces. > > Signed-off-by: Donghwa Lee > Signed-off-by: Hyungwon Hwang > Signed-off-by: Hoegeun Kwon

Re: [PATCH v11 2/3] drm/panel: Add support for S6E3HA2 panel driver on TM2 board

2017-04-06 Thread Thierry Reding
On Wed, Mar 08, 2017 at 10:42:36AM +0900, Hoegeun Kwon wrote: > This patch add support for MIPI-DSI based S6E3HA2 AMOLED panel > driver. This panel has 1440x2560 resolution in 5.7-inch physical > panel in the TM2 device. > > Signed-off-by: Donghwa Lee > Signed-off-by:

Re: [PATCH 1/2] devicetree: add vendor prefix for Winstar Display Corp.

2017-04-06 Thread Thierry Reding
On Fri, Mar 03, 2017 at 04:21:55PM +0100, Richard Genoud wrote: > Winstar Display Corp. is specialized in LCD displays for embedded > products. > cf: http://www.winstar.com.tw > > Signed-off-by: Richard Genoud > --- >

[GIT PULL] drm/tegra: Changes for v4.12-rc1

2017-04-06 Thread Thierry Reding
Hi Dave, The following changes since commit 97da3854c526d3a6ee05c849c96e48d21527606c: Linux 4.11-rc3 (2017-03-19 19:09:39 -0700) are available in the git repository at: git://anongit.freedesktop.org/tegra/linux tags/drm/tegra/for-4.12-rc1 for you to fetch changes up to

Re: [PATCH v3 2/2] drm/panel: Add driver for sitronix ST7789V LCD controller

2017-04-06 Thread Thierry Reding
On Mon, Apr 03, 2017 at 03:38:32PM +0200, Maxime Ripard wrote: > The Sitronix ST7789v controller is used to drive 240x320 LCD panels through > various interfaces, including SPI and RGB/Parallel. > > The current driver is configuring it for the latter. Support for tinyDRM > can always be added

Re: [PATCH v3 1/2] dt-bindings: display: panel: Add bindings for the Sitronix ST7789V panel

2017-04-06 Thread Thierry Reding
On Mon, Apr 03, 2017 at 03:38:31PM +0200, Maxime Ripard wrote: > The Sitronix ST7789V is an LCD panel controller, controlled over SPI, that > can drive 18-bits 240x320 LCD displays. > > Signed-off-by: Maxime Ripard > Acked-by: Rob Herring > ---

Re: [PATCH v3 0/5] DRM OF graph clean-up

2017-04-06 Thread Sean Paul
On Wed, Mar 22, 2017 at 9:26 AM, Rob Herring wrote: > I've been unhappy with the OF graph API for some time and decided to > do something about it. The problem is drivers have to do too much of the > graph parsing and walking themselves. This has led to the same pattern >

Re: [PATCH v5 05/10] dt-bindings: Add Ampire AM-480272H3TMQW-T01H panel

2017-04-06 Thread Thierry Reding
On Tue, Mar 28, 2017 at 11:44:48AM +0200, Yannick Fertre wrote: > This patch adds documentation of device tree bindings for the WVGA panel > Ampire AM-480272H3TMQW-T01H. > > Acked-by: Rob Herring > Signed-off-by: Yannick Fertre > --- >

Re: [PATCH v5 06/10] drm/panel: simple: Add support for Ampire AM-480272H3TMQW-T01H

2017-04-06 Thread Thierry Reding
On Tue, Mar 28, 2017 at 11:44:49AM +0200, Yannick Fertre wrote: > Add simple-panel support for the Ampire AM-480272H3TMQW-T01H, > which is a 4.3" WQVGA panel. > > Signed-off-by: Yannick Fertre > --- > drivers/gpu/drm/panel/panel-simple.c | 29 +

Re: [bug report] drm: bridge: dw-hdmi: Switch to V4L bus format and encodings

2017-04-06 Thread Neil Armstrong
On 04/06/2017 07:21 AM, Dan Carpenter wrote: > Hello Neil Armstrong, > > The patch def23aa7e982: "drm: bridge: dw-hdmi: Switch to V4L bus > format and encodings" from Apr 4, 2017, leads to the following static > checker warning: > > drivers/gpu/drm/bridge/synopsys/dw-hdmi.c:1670

Re: [PATCH 1/2] drm: Add DRM_CAP_PRIME_SCANOUT.

2017-04-06 Thread Christopher James Halse Rogers
On Wed, 5 Apr 2017 at 20:14 Lucas Stach wrote: > Am Mittwoch, den 05.04.2017, 11:59 +0200 schrieb Daniel Vetter: > > On Wed, Apr 05, 2017 at 10:15:44AM +0200, Lucas Stach wrote: > > > Am Mittwoch, den 05.04.2017, 00:20 + schrieb Christopher James > Halse > > > Rogers:

[GIT PULL] Allwinner sun4i DRM changes for 4.12

2017-04-06 Thread Maxime Ripard
Hi Dave, Please pull the following changes for the next merge window. My tree is included in linux-next, so we should be pretty safe there. Thanks! Maxime The following changes since commit ca39b449f6d03e8235969f12f5dd25b8eb4304d6: drm/vc4: Fix OOPSes from trying to cache a partially

Re: [PATCH v3 8/9] drm/rockchip: gem: Don't alloc/free gem buf when dev_private is invalid

2017-04-06 Thread Daniel Vetter
On Wed, Apr 05, 2017 at 12:28:40PM -0400, Sean Paul wrote: > On Wed, Apr 05, 2017 at 04:29:26PM +0800, Jeffy Chen wrote: > > After unbinding drm, the userspace may still has a chance to access > > gem buf. > > > > Add a sanity check for a NULL dev_private to prevent that from > > happening. > >

[radeon-alex:drm-next-4.12-wip 34/69] drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c:1207:27: sparse: incompatible types in comparison expression (different signedness)

2017-04-06 Thread kbuild test robot
tree: git://people.freedesktop.org/~agd5f/linux.git drm-next-4.12-wip head: a738ad6108435367c1d7f1a4a499bebdd26c375e commit: d088e5038a6387552501705c797c0d0b84d3a935 [34/69] drm/amdgpu: fix vm size and block size for VMPT (v4) reproduce: # apt-get install sparse git checkout

Re: [PATCH] drm: virtio: fix virtio_gpu_cursor_formats

2017-04-06 Thread Daniel Vetter
On Wed, Apr 05, 2017 at 08:11:25PM +0300, Ville Syrjälä wrote: > On Wed, Apr 05, 2017 at 10:09:15AM +0200, Laurent Vivier wrote: > > When we use virtio-vga with a big-endian guest, > > the mouse pointer disappears. > > > > To fix that, on big-endian use DRM_FORMAT_BGRA > > instead of

Re: [PATCH] format-security: move static strings to const

2017-04-06 Thread Daniel Vetter
On Wed, Apr 05, 2017 at 02:47:11PM -0700, Kees Cook wrote: > While examining output from trial builds with -Wformat-security enabled, > many strings were found that should be defined as "const", or as a char > array instead of char pointer. This makes some static analysis easier, > by producing

[Bug 100593] corruption in total war warhammer when using mesa 17.1 - git

2017-04-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=100593 --- Comment #2 from tarp...@gmx.de --- Created attachment 130721 --> https://bugs.freedesktop.org/attachment.cgi?id=130721=edit Screenshot showing weird colours on background textures using Oibaf PPA -- You are receiving this mail because:

Re: [PATCH libdrm 2/2] etnaviv: add fence fd support

2017-04-06 Thread Christian Gmeiner
2017-04-05 14:34 GMT+02:00 Philipp Zabel : > Add etna_cmd_stream_flush_explicit with in-fence fd and out-fence fd > support for explicit fencing. > > Signed-off-by: Philipp Zabel > --- > etnaviv/etnaviv_cmd_stream.c | 33

Re: [PATCH 00/15] acquire ctx wire-up, part 2

2017-04-06 Thread Daniel Vetter
On Wed, Apr 05, 2017 at 03:45:41PM -0400, Alex Deucher wrote: > On Mon, Apr 3, 2017 at 4:32 AM, Daniel Vetter wrote: > > Hi all, > > > > Partially this is a resend of the patches now unblocked by the vmwgfx atomic > > conversion just merged. I could entirely drop the

Re: [PATCH v5 3/5] drm/exynos: dsi: Fix the parse_dt function

2017-04-06 Thread Inki Dae
2017년 04월 05일 00:38에 Krzysztof Kozlowski 이(가) 쓴 글: > On Tue, Mar 28, 2017 at 11:38 AM, Krzysztof Kozlowski wrote: >> On Tue, Mar 28, 2017 at 11:26 AM, Inki Dae wrote: >>> Merged. >> >> Hi, >> >> I do not see the tag (with DT patches) merged by you which I

Re: [PATCH v3 1/9] drm: bridge: analogix: Detach panel when unbinding analogix dp

2017-04-06 Thread Andrzej Hajda
On 05.04.2017 10:29, Jeffy Chen wrote: > The panel is attached when binding analogix dp. > > Signed-off-by: Jeffy Chen Reviewed-by: Andrzej Hajda -- Regards Andrzej > --- > > Changes in v3: None > Changes in v2: > Fix some commit messages. > >

Re: [PATCH libdrm 2/2] etnaviv: add fence fd support

2017-04-06 Thread Christian Gmeiner
2017-04-05 18:25 GMT+02:00 Philipp Zabel : > On Wed, 2017-04-05 at 17:07 +0100, Eric Engestrom wrote: >> On Wednesday, 2017-04-05 14:34:56 +0200, Philipp Zabel wrote: >> > Add etna_cmd_stream_flush_explicit with in-fence fd and out-fence fd >> > support for explicit

[radeon-alex:drm-next-4.12-wip 38/69] drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c:556:16: note: in expansion of macro 'do_div'

2017-04-06 Thread kbuild test robot
tree: git://people.freedesktop.org/~agd5f/linux.git drm-next-4.12-wip head: a738ad6108435367c1d7f1a4a499bebdd26c375e commit: 38574a66e897b70bbdc46d9da26845caab90da13 [38/69] drm/amdgpu: fix 64bit division config: xtensa-allyesconfig (attached as .config) compiler: xtensa-linux-gcc (GCC) 4.9.0

Re: [PATCH] format-security: move static strings to const

2017-04-06 Thread Jani Nikula
On Thu, 06 Apr 2017, Kees Cook wrote: > While examining output from trial builds with -Wformat-security enabled, > many strings were found that should be defined as "const", or as a char > array instead of char pointer. This makes some static analysis easier, > by producing

Re: [PATCH] MAINTAINERS: Add Laurent and Andrzej as maintainers for bridge drivers

2017-04-06 Thread Laurent Pinchart
Hi Archit, On Wednesday 05 Apr 2017 16:53:50 Archit Taneja wrote: > Add Laurent and Andrzej as maintainers for DRM bridge chip drivers. They > actively review and contribute to bridge drivers and the bridge API. How about adding me as a reviewer instead ? I can't commit maintain bridge drivers

Re: [PATCH] drm: bridge: dw-hdmi: fix input format/encoding from plat_data

2017-04-06 Thread Neil Armstrong
On 04/06/2017 11:34 AM, Neil Armstrong wrote: > The plat_data->input_bus_format and plat_data->input_bus_encoding > are unsigned long and are alsways >=0, but the value 0 was still > considered as RGB888 like the default behaviour. > > This patch changes the if test to > 0. > > Thanks to Dan

Re: [PATCH] MAINTAINERS: Add Laurent and Andrzej as maintainers for bridge drivers

2017-04-06 Thread Archit Taneja
Hi Laurent, On 4/6/2017 2:40 PM, Laurent Pinchart wrote: Hi Archit, On Wednesday 05 Apr 2017 16:53:50 Archit Taneja wrote: Add Laurent and Andrzej as maintainers for DRM bridge chip drivers. They actively review and contribute to bridge drivers and the bridge API. How about adding me as a

Re: [PATCH libdrm 1/2] etnaviv: sync uapi header

2017-04-06 Thread Emil Velikov
Hi Philipp On 5 April 2017 at 13:34, Philipp Zabel wrote: > Import the etnaviv header changes from kernel commits 9ad59fea162c > ("drm/etnaviv: submit support for in-fences") and 78ec187f64fa > ("drm/etnaviv: submit support for out-fences") for fence fd support. > Looking

Re: [PATCH v2] drm: hdlcd: Fix the calculation of the scanout start address

2017-04-06 Thread Jani Nikula
On Mon, 03 Apr 2017, Russell King - ARM Linux wrote: > So what the _hell_ do you think _this_ sentence means? It _was_ shared > with you. > > The following series is what I came up with, although I've had no time > to test it. > > which was in the mail which was the

[PATCH 4/4] drm/atomic: Add connector atomic_check function, v2.

2017-04-06 Thread Maarten Lankhorst
The atomic_check function is useful for implementing properties, but it can be used for other connector modeset related checks as well. Similar to plane check functions, on a modeset atomic_check() is always called. Changes since v1: - Make sure atomic_check() is called on any modeset.

[PATCH 3/4] drm/atomic: Move enable/connector check up in check_modeset()

2017-04-06 Thread Maarten Lankhorst
Now that handle_conflicting_encoders no longer touches active state, so there's no need to do the check quite that late any more. Doing it with all the other checks makes it a lot more clear what the below block tries to accomplish, and this feels like a better place to put the check.

[PATCH 1/4] drm/atomic: Unify conflicting encoder handling.

2017-04-06 Thread Maarten Lankhorst
Currently we use a flag to change behavior in atomic commit whether a conflicting encoder should be enabled or disabled. This is used for the legacy set_config helper, which disables connectors that have a conflicting encoder but not part of the active crtc list. There's no need for this to be

[PATCH 0/4] drm/atomic: Cleanups for adding connector atomic check function.

2017-04-06 Thread Maarten Lankhorst
Some small cleanups I came across to make drm_atomic_helper_check_modeset more readable. This makes it a lot more clear what atomic_check does and why it's called in the place it is. Maarten Lankhorst (4): drm/atomic: Unify conflicting encoder handling. drm/atomic: Set all the changed flags

[PATCH 2/4] drm/atomic: Set all the changed flags in one place.

2017-04-06 Thread Maarten Lankhorst
Now that handle_conflicting_encoders cannot disable crtc's any more it makes sense to set all the changed flags in 1 place. This makes the code slightly less magical. The (now removed) comment is out of date. The only reason the active_changed was set late was because handle_conflicting_encoders

[Bug 100580] Adding unreachable "return" and "continue" in a GLSL shader leads to different image

2017-04-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=100580 --- Comment #5 from Marc Dietrich --- also fine for r600 (RS780). So radeonsi specific. -- You are receiving this mail because: You are the assignee for the bug.___ dri-devel

Re: [PATCH] drm: bridge: dw-hdmi: remove unused hdmi_bus_fmt_is_yuv420

2017-04-06 Thread Neil Armstrong
On 04/05/2017 10:14 AM, Laurent Pinchart wrote: > Hi Neil, > > Thank you for the patch. > > On Wednesday 05 Apr 2017 09:32:59 Neil Armstrong wrote: >> Remove usused yet hdmi_bus_fmt_is_yuv420 function. >> >> Fixes: def23aa7e982 ("drm: bridge: dw-hdmi: Switch to V4L bus format and >> encodings")

Re: [PATCH libdrm v3 1/2] Headers: Sync drm{, _mode}.h with the kernel

2017-04-06 Thread Emil Velikov
On 5 April 2017 at 17:22, Daniel Stone wrote: > Generated using make headers_install, based on drm-misc-next commit > 5db06a8a98f515f67446a69c57577c4c363ec65d. > > This clarifies the comments around modifiers such that they are > per-framebuffer rather than per-plane, adds

drm-tip/drm-tip boot: 157 boots: 15 failed, 134 passed with 8 offline (v4.11-rc5-1642-gf64b9ef53ade)

2017-04-06 Thread kernelci . org bot
drm-tip/drm-tip boot: 157 boots: 15 failed, 134 passed with 8 offline (v4.11-rc5-1642-gf64b9ef53ade) Full Boot Summary: https://kernelci.org/boot/all/job/drm-tip/branch/drm-tip/kernel/v4.11-rc5-1642-gf64b9ef53ade/ Full Build Summary:

[PATCH v5 02/12] drm: bridge: analogix: Unregister dp aux when unbinding

2017-04-06 Thread Jeffy Chen
The dp aux is registered when binding analogix dp. Signed-off-by: Jeffy Chen Reviewed-by: Andrzej Hajda --- Changes in v5: None Changes in v4: None Changes in v3: None Changes in v2: None drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 1 +

[PATCH v4 11/12] drm/rockchip: Shutdown all crtcs when unbinding drm

2017-04-06 Thread Your Name
From: Jeffy Chen Signed-off-by: Jeffy Chen Signed-off-by: Your Name --- Changes in v4: None Changes in v3: Address Daniel Vetter 's comments. Update commit message. Changes in v2: None

drm-tip/drm-tip build: 197 builds: 0 failed, 197 passed, 202 warnings (v4.11-rc5-1632-g7303b362817a)

2017-04-06 Thread kernelci . org bot
drm-tip/drm-tip build: 197 builds: 0 failed, 197 passed, 202 warnings (v4.11-rc5-1632-g7303b362817a) Full Build Summary: https://kernelci.org/build/drm-tip/branch/drm-tip/kernel/v4.11-rc5-1632-g7303b362817a/ Tree: drm-tip Branch: drm-tip Git Describe: v4.11-rc5-1632-g7303b362817a Git Commit:

[PATCH v5 12/12] drm/drm_ioctl.c: Break ioctl when drm device not registered

2017-04-06 Thread Jeffy Chen
After unbinding drm, the user space may still owns the drm dev fd, and may still be able to call drm ioctl. Add a sanity check here to prevent that from happening. Signed-off-by: Jeffy Chen --- Changes in v5: None Changes in v4: None Changes in v3: None Changes in

Re: [PATCH v3 3/9] drm: bridge: analogix: Destroy connector when unbinding

2017-04-06 Thread jeffy
Hi Andrzej, On 04/06/2017 03:19 PM, Andrzej Hajda wrote: On 05.04.2017 10:29, Jeffy Chen wrote: Normally we do this in drm_mode_config_cleanup. But analogix dp's connector is allocated in bind, and freed after unbind. So we need to destroy it in unbind to avoid further access. Signed-off-by:

[PATCH v5 05/12] drm/rockchip: cdn-dp: Don't try to release firmware when not loaded

2017-04-06 Thread Jeffy Chen
Signed-off-by: Jeffy Chen --- Changes in v5: None Changes in v4: None Changes in v3: None Changes in v2: None drivers/gpu/drm/rockchip/cdn-dp-core.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/rockchip/cdn-dp-core.c

Re: [PATCH v3 2/9] drm: bridge: analogix: Unregister dp aux when unbinding

2017-04-06 Thread jeffy
Hi Andrzej, On 04/06/2017 03:11 PM, Andrzej Hajda wrote: On 05.04.2017 10:29, Jeffy Chen wrote: The dp aux is registered when binding analogix dp. Signed-off-by: Jeffy Chen Reviewed-by: Andrzej Hajda Btw, if you are working already in this

Re: [PATCH] drm: virtio: fix virtio_gpu_cursor_formats

2017-04-06 Thread Laurent Vivier
On 05/04/2017 19:11, Ville Syrjälä wrote: > On Wed, Apr 05, 2017 at 10:09:15AM +0200, Laurent Vivier wrote: >> When we use virtio-vga with a big-endian guest, >> the mouse pointer disappears. >> >> To fix that, on big-endian use DRM_FORMAT_BGRA >> instead of DRM_FORMAT_ARGB. >> >>

Re: [Intel-gfx] [PATCH] drm/atomic: Add connector atomic_check function.

2017-04-06 Thread Dhinakaran Pandiyan
On Thu, Apr 6, 2017 at 12:34 AM Maarten Lankhorst < maarten.lankho...@linux.intel.com> wrote: > Op 06-04-17 om 03:27 schreef Pandiyan, Dhinakaran: > > On Wed, 2017-04-05 at 12:06 +0200, Daniel Vetter wrote: > >> On Wed, Apr 05, 2017 at 10:41:24AM +0200, Maarten Lankhorst wrote: > >>> The

[PATCH v4 10/12] drm/rockchip: Reoder drm bind/unbind sequence

2017-04-06 Thread Your Name
From: Jeffy Chen Current drm bind/unbind sequence would cause some memory issues. For example we should not cleanup iommu before cleanup mode config. Reorder bind/unbind sequence, follow exynos drm. Signed-off-by: Jeffy Chen Signed-off-by:

[PATCH v4 09/12] drm/rockchip: analogix_dp: Disable clock when unbinding

2017-04-06 Thread Your Name
From: Jeffy Chen The clock is enabled when binding cdn dp. Signed-off-by: Jeffy Chen Signed-off-by: Your Name --- Changes in v4: None Changes in v3: None Changes in v2: None

[PATCH v4 04/12] drm: bridge: analogix: Destroy connector & encoder when unbinding

2017-04-06 Thread Your Name
From: Jeffy Chen Normally we do this in drm_mode_config_cleanup. But: 1/ analogix dp's connector is allocated in bind, and freed after unbind. So we need to destroy it in unbind to avoid further access. 2/ the drm bridge is attached in bind, and detached in encoder

[PATCH v4 01/12] drm: bridge: analogix: Detach panel when unbinding analogix dp

2017-04-06 Thread Your Name
From: Jeffy Chen The panel is attached when binding analogix dp. Signed-off-by: Jeffy Chen Reviewed-by: Andrzej Hajda Signed-off-by: Your Name --- Changes in v4: None Changes in v3: None Changes in

Re: [PATCH v3 8/9] drm/rockchip: gem: Don't alloc/free gem buf when dev_private is invalid

2017-04-06 Thread jeffy
Hi Sean, On 04/06/2017 08:26 PM, Sean Paul wrote: On Thu, Apr 06, 2017 at 10:47:59AM +0800, jeffy wrote: Hi Sean, On 04/06/2017 12:28 AM, Sean Paul wrote: On Wed, Apr 05, 2017 at 04:29:26PM +0800, Jeffy Chen wrote: After unbinding drm, the userspace may still has a chance to access gem buf.

[PATCH v5 10/12] drm/rockchip: Reoder drm bind/unbind sequence

2017-04-06 Thread Jeffy Chen
Current drm bind/unbind sequence would cause some memory issues. For example we should not cleanup iommu before cleanup mode config. Reorder bind/unbind sequence, follow exynos drm. Signed-off-by: Jeffy Chen --- Changes in v5: None Changes in v4: None Changes in v3:

[PATCH 4/5] i915: schedule while freeing the lists of gem objects

2017-04-06 Thread Andrea Arcangeli
Add cond_resched(). Signed-off-by: Andrea Arcangeli --- drivers/gpu/drm/i915/i915_gem.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c index 612fde3..c81baeb 100644 ---

[PATCH 5/5] i915: fence workqueue optimization

2017-04-06 Thread Andrea Arcangeli
Insist to run llist_del_all() until the free_list is found empty, this may avoid having to schedule more workqueues. Signed-off-by: Andrea Arcangeli --- drivers/gpu/drm/i915/intel_display.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

Re: Proposal for RandR version 1.6, Leases and EDID-based output grabs

2017-04-06 Thread Michel Dänzer
On 02/04/17 07:58 AM, Keith Packard wrote: > > 2. Provide a way to hide some monitors from other clients using EDID > manufacturer ids and product codes. Outputs with EDID properties > matching the grab will report 'disconnected' to all clients other > than the grabbing client. This

[RFC PATCH 2/2] drm/vgem: Enable dmabuf import interfaces

2017-04-06 Thread Laura Abbott
Enable the GEM dma-buf import interfaces in addition to the export interfaces. This lets vgem be used as a test source for other allocators (e.g. Ion). Signed-off-by: Laura Abbott --- drivers/gpu/drm/vgem/vgem_drv.c | 135

[RFC PATCH 0/2] dmabuf import interfaces for vgem

2017-04-06 Thread Laura Abbott
Hi, Ion[1] is making progress towards moving out of staging. I'd like to take advantage of the vgem driver for development of unit tests for Ion. To do this properly, vgem needs to support importing of foreign handles. This is an RFC to add that support. This passes the existing vgem_basic unit

  1   2   >